From: Namhyung Kim Date: Wed, 18 Dec 2013 05:21:11 +0000 (+0900) Subject: perf hists: Do not pass period and weight to add_hist_entry() X-Git-Tag: firefly_0821_release~176^2~4647^2~4^2~46 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=f1cbf78d175e6202a29f53a7f915520e40a37baf;p=firefly-linux-kernel-4.4.55.git perf hists: Do not pass period and weight to add_hist_entry() The @entry argument already has the info so no need to pass them. Signed-off-by: Namhyung Kim Acked-by: Jiri Olsa Cc: Arun Sharma Cc: Frederic Weisbecker Cc: Ingo Molnar Cc: Jiri Olsa Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Rodrigo Campos Link: http://lkml.kernel.org/r/1387344086-12744-4-git-send-email-namhyung@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c index 822903eaa201..63234e37583c 100644 --- a/tools/perf/util/hist.c +++ b/tools/perf/util/hist.c @@ -342,15 +342,15 @@ static u8 symbol__parent_filter(const struct symbol *parent) } static struct hist_entry *add_hist_entry(struct hists *hists, - struct hist_entry *entry, - struct addr_location *al, - u64 period, - u64 weight) + struct hist_entry *entry, + struct addr_location *al) { struct rb_node **p; struct rb_node *parent = NULL; struct hist_entry *he; int64_t cmp; + u64 period = entry->stat.period; + u64 weight = entry->stat.weight; p = &hists->entries_in->rb_node; @@ -437,7 +437,7 @@ struct hist_entry *__hists__add_entry(struct hists *hists, .transaction = transaction, }; - return add_hist_entry(hists, &entry, al, period, weight); + return add_hist_entry(hists, &entry, al); } int64_t