From: Yedidya Feldblum <yfeldblum@fb.com>
Date: Sun, 13 Sep 2015 20:23:17 +0000 (-0700)
Subject: Drop support for GCC < 4.8 in folly/experimental/Bits.h
X-Git-Tag: deprecate-dynamic-initializer~416
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=f25b0650c02182beba01f998ac862c60a11cffd7;p=folly.git

Drop support for GCC < 4.8 in folly/experimental/Bits.h

Summary: [Folly] Drop support for GCC < 4.8 in folly/experimental/Bits.h

Can't stay indefinitely backcompat with older compilers.

Reviewed By: @meyering

Differential Revision: D2420133
---

diff --git a/folly/experimental/Bits.h b/folly/experimental/Bits.h
index c7de2a14..1c9185d6 100644
--- a/folly/experimental/Bits.h
+++ b/folly/experimental/Bits.h
@@ -57,8 +57,7 @@ struct BitsTraits<Unaligned<T>, typename std::enable_if<
   static T loadRMW(const Unaligned<T>& x) {
 #pragma GCC diagnostic push
 #pragma GCC diagnostic ignored "-Wuninitialized"
-// make sure we compile without warning on gcc 4.6 with -Wpragmas
-#if __GNUC_PREREQ(4, 7)
+#if !__clang__ // for gcc version [4.8, ?)
 #pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
 #endif
     return x.value;
@@ -79,8 +78,7 @@ struct BitsTraits<UnalignedNoASan<T>, typename std::enable_if<
   loadRMW(const UnalignedNoASan<T>& x) {
 #pragma GCC diagnostic push
 #pragma GCC diagnostic ignored "-Wuninitialized"
-// make sure we compile without warning on gcc 4.6 with -Wpragmas
-#if __GNUC_PREREQ(4, 7)
+#if !__clang__ // for gcc version [4.8, ?)
 #pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
 #endif
     return x.value;
@@ -98,7 +96,7 @@ struct BitsTraits<T, typename std::enable_if<
   static T loadRMW(const T& x) {
 #pragma GCC diagnostic push
 #pragma GCC diagnostic ignored "-Wuninitialized"
-#if __GNUC_PREREQ(4, 7)
+#if !__clang__ // for gcc version [4.8, ?)
 #pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
 #endif
     return x;
@@ -205,7 +203,7 @@ struct Bits {
 
 #pragma GCC diagnostic push
 #pragma GCC diagnostic ignored "-Wuninitialized"
-#if __GNUC_PREREQ(4, 7)
+#if !__clang__ // for gcc version [4.8, ?)
 #pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
 #endif