From: Hannes Reinecke Date: Tue, 4 May 2010 14:49:21 +0000 (+0200) Subject: Enable retries for SYNCRONIZE_CACHE commands to fix I/O error X-Git-Tag: firefly_0821_release~10186^2~1625 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=f3dc6becaa6b5efdb5756cf6f47b724c9b32df0b;p=firefly-linux-kernel-4.4.55.git Enable retries for SYNCRONIZE_CACHE commands to fix I/O error commit c213e1407be6b04b144794399a91472e0ef92aec upstream. Some arrays are giving I/O errors with ext3 filesystems when SYNCHRONIZE_CACHE gets a UNIT_ATTENTION. What is happening is that these commands have no retries, so the UNIT_ATTENTION causes the barrier to fail. We should be enable retries here to clear any transient error and allow the barrier to succeed. Signed-off-by: Hannes Reinecke Signed-off-by: James Bottomley Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 9093c7261f33..7694a95bdb53 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -971,6 +971,7 @@ static void sd_prepare_flush(struct request_queue *q, struct request *rq) { rq->cmd_type = REQ_TYPE_BLOCK_PC; rq->timeout = SD_TIMEOUT; + rq->retries = SD_MAX_RETRIES; rq->cmd[0] = SYNCHRONIZE_CACHE; rq->cmd_len = 10; }