From: wangweidong Date: Thu, 19 Dec 2013 02:02:42 +0000 (+0800) Subject: sctp: remove the never used 'return' and redundant 'break' X-Git-Tag: firefly_0821_release~176^2~4570^2~398 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=f482f2fcd1bd644849bd75412d589cbb40fbaa01;p=firefly-linux-kernel-4.4.55.git sctp: remove the never used 'return' and redundant 'break' In switch() had do return, and never use the 'return NULL'. The 'break' after return or goto has no effect. Remove it. v2: make it more readable as suggested by Neil. Signed-off-by: Wang Weidong Acked-by: Neil Horman Signed-off-by: David S. Miller --- diff --git a/net/sctp/input.c b/net/sctp/input.c index 2a192a7c5d81..e978235c34fc 100644 --- a/net/sctp/input.c +++ b/net/sctp/input.c @@ -1116,19 +1116,10 @@ static struct sctp_association *__sctp_rcv_lookup_harder(struct net *net, return NULL; /* If this is INIT/INIT-ACK look inside the chunk too. */ - switch (ch->type) { - case SCTP_CID_INIT: - case SCTP_CID_INIT_ACK: + if (ch->type == SCTP_CID_INIT || ch->type == SCTP_CID_INIT_ACK) return __sctp_rcv_init_lookup(net, skb, laddr, transportp); - break; - default: - return __sctp_rcv_walk_lookup(net, skb, laddr, transportp); - break; - } - - - return NULL; + return __sctp_rcv_walk_lookup(net, skb, laddr, transportp); } /* Lookup an association for an inbound skb. */