From: Amit Pundir Date: Thu, 19 Feb 2015 07:51:00 +0000 (+0530) Subject: arm64: kuser32-bit helpers: do not include unistd32.h explicitly X-Git-Tag: firefly_0821_release~4158^2~207 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=f56ff9935a276d8caf5cefbe8af1aed519dba0e8;p=firefly-linux-kernel-4.4.55.git arm64: kuser32-bit helpers: do not include unistd32.h explicitly We get following warnings while building for arm64 arch: ----->8----- In file included from arch/arm64/kernel/kuser32.S:32:0: /linaro/android/kernel/pundir/arch/arm64/include/asm/unistd32.h:24:0: warning: "__NR_restart_syscall" redefined #define __NR_restart_syscall 0 ^ In file included from include/asm-generic/unistd.h:1:0, from /linaro/android/kernel/pundir/arch/arm64/include/uapi/asm/unistd.h:16, from /linaro/android/kernel/pundir/arch/arm64/include/asm/unistd.h:50, from arch/arm64/kernel/kuser32.S:31: include/uapi/asm-generic/unistd.h:390:0: note: this is the location of the previous definition #define __NR_restart_syscall 128 ^ In file included from arch/arm64/kernel/kuser32.S:32:0: /linaro/android/kernel/pundir/arch/arm64/include/asm/unistd32.h:26:0: warning: "__NR_exit" redefined #define __NR_exit 1 ^ In file included from include/asm-generic/unistd.h:1:0, from /linaro/android/kernel/pundir/arch/arm64/include/uapi/asm/unistd.h:16, from /linaro/android/kernel/pundir/arch/arm64/include/asm/unistd.h:50, from arch/arm64/kernel/kuser32.S:31: include/uapi/asm-generic/unistd.h:292:0: note: this is the location of the previous definition #define __NR_exit 93 ^ -----8<----- This patch removes unitstd32.h include to avoid duplication of "__NR_" syscall definitions. This patch is based on AOSP commit: cfc7e99e9e3900056028a7d90072e9ea0d886f8d, "arm64: Add __NR_* definitions for compat syscalls", which adds __NR_* definitions to asm/unistd32.h, moves the __NR_compat_* definitions to asm/unistd.h and removes all the explicit unistd32.h includes apart from the one building the compat syscall table. The aim is to have the compat __NR_* definitions available but without colliding with the native syscall definitions (required by lib/compat_audit.c to avoid duplicating the audit header files between native and compat). Signed-off-by: Amit Pundir Signed-off-by: Jon Medhurst --- diff --git a/arch/arm64/kernel/kuser32.S b/arch/arm64/kernel/kuser32.S index 9fb6d5a3cea7..997e6b27ff6a 100644 --- a/arch/arm64/kernel/kuser32.S +++ b/arch/arm64/kernel/kuser32.S @@ -29,7 +29,6 @@ */ #include -#include .align 5 .globl __kuser_helper_start