From: Dan Carpenter Date: Fri, 8 Jun 2012 06:52:58 +0000 (+0300) Subject: staging: comedi: amplc_pci230: add a missing unlock X-Git-Tag: firefly_0821_release~3680^2~2356^2~865 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=f59f231e3db835353d8d1ff91062d89140dc8be3;p=firefly-linux-kernel-4.4.55.git staging: comedi: amplc_pci230: add a missing unlock This side of the if else statement returned with the lock held and IRQs disabled. Signed-off-by: Dan Carpenter Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/comedi/drivers/amplc_pci230.c b/drivers/staging/comedi/drivers/amplc_pci230.c index 30487be11650..f2ad35c6527d 100644 --- a/drivers/staging/comedi/drivers/amplc_pci230.c +++ b/drivers/staging/comedi/drivers/amplc_pci230.c @@ -1387,6 +1387,8 @@ static int pci230_ao_inttrig_scan_begin(struct comedi_device *dev, /* Delay. Should driver be responsible for this? */ /* XXX TODO: See if DAC busy bit can be used. */ udelay(8); + } else { + spin_unlock_irqrestore(&devpriv->ao_stop_spinlock, irqflags); } return 1;