From: Sachin Kamat Date: Fri, 14 Feb 2014 11:49:59 +0000 (+0530) Subject: regulator: mc13xxx: Use of_get_child_by_name X-Git-Tag: firefly_0821_release~176^2~4202^2~2^5~2 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=fc5a6e5b0cf107517910b139e3d3af803fa09952;p=firefly-linux-kernel-4.4.55.git regulator: mc13xxx: Use of_get_child_by_name of_find_node_by_name walks the allnodes list, and can thus walk outside of the parent node. Use of_get_child_by_name instead. Signed-off-by: Sachin Kamat Signed-off-by: Mark Brown --- diff --git a/drivers/regulator/mc13xxx-regulator-core.c b/drivers/regulator/mc13xxx-regulator-core.c index da4859282302..4498a3f0733d 100644 --- a/drivers/regulator/mc13xxx-regulator-core.c +++ b/drivers/regulator/mc13xxx-regulator-core.c @@ -168,7 +168,7 @@ int mc13xxx_get_num_regulators_dt(struct platform_device *pdev) int num; of_node_get(pdev->dev.parent->of_node); - parent = of_find_node_by_name(pdev->dev.parent->of_node, "regulators"); + parent = of_get_child_by_name(pdev->dev.parent->of_node, "regulators"); if (!parent) return -ENODEV; @@ -188,7 +188,7 @@ struct mc13xxx_regulator_init_data *mc13xxx_parse_regulators_dt( int i, parsed = 0; of_node_get(pdev->dev.parent->of_node); - parent = of_find_node_by_name(pdev->dev.parent->of_node, "regulators"); + parent = of_get_child_by_name(pdev->dev.parent->of_node, "regulators"); if (!parent) return NULL;