From: Duncan P. N. Exon Smith <dexonsmith@apple.com>
Date: Fri, 7 Mar 2014 17:23:29 +0000 (+0000)
Subject: C++11: Copy pointers with const auto *
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=fc9031cdffa3063ef747bd3a98833f164d07fc4a;p=oota-llvm.git

C++11: Copy pointers with const auto *

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203254 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/docs/CodingStandards.rst b/docs/CodingStandards.rst
index a762bf358e3..f9685d69ad5 100644
--- a/docs/CodingStandards.rst
+++ b/docs/CodingStandards.rst
@@ -747,7 +747,7 @@ is a copy.  Particularly in range-based ``for`` loops, careless copies are
 expensive.
 
 As a rule of thumb, use ``const auto &`` unless you need to mutate or copy the
-result.
+result, and use ``const auto *`` when copying pointers.
 
 .. code-block:: c++
 
@@ -760,6 +760,10 @@ result.
   // Remove the reference if you really want a new copy.
   for (auto Val : Container) { Val.change(); saveSomewhere(Val); }
 
+  // Copy pointers, but make it clear that they're pointers.
+  for (const auto *Val : Container) { observe(*Val); }
+  for (auto *Val : Container) { Val->change(); }
+
 Style Issues
 ============