From: Li Zhong <zhong@linux.vnet.ibm.com>
Date: Wed, 28 Nov 2012 09:15:21 +0000 (+0800)
Subject: cgroup: move list add after list head initilization
X-Git-Tag: firefly_0821_release~3680^2~1492^2~7
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=fddfb02ad0d0d3b479c2a26a8ae7e6411b34706b;p=firefly-linux-kernel-4.4.55.git

cgroup: move list add after list head initilization

2243076ad1 ("cgroup: initialize cgrp->allcg_node in
init_cgroup_housekeeping()") initializes cgrp->allcg_node in
init_cgroup_housekeeping().  Then in init_cgroup_root(), we should
call init_cgroup_housekeeping() before adding it to &root->allcg_list;
otherwise, we are initializing an entry already in a list.

Signed-off-by: Li Zhong <zhong@linux.vnet.ibm.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
---

diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 55a0a770a5a2..c02b05560d10 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -1401,8 +1401,8 @@ static void init_cgroup_root(struct cgroupfs_root *root)
 	root->number_of_cgroups = 1;
 	cgrp->root = root;
 	cgrp->top_cgroup = cgrp;
-	list_add_tail(&cgrp->allcg_node, &root->allcg_list);
 	init_cgroup_housekeeping(cgrp);
+	list_add_tail(&cgrp->allcg_node, &root->allcg_list);
 }
 
 static bool init_root_id(struct cgroupfs_root *root)