From: Duncan P. N. Exon Smith <dexonsmith@apple.com>
Date: Fri, 7 Mar 2014 18:06:15 +0000 (+0000)
Subject: C++11: Remove const from in auto guidelines
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=feed88059f2ad150865b037c91aa0246ebcc8f76;p=oota-llvm.git

C++11: Remove const from in auto guidelines

Using const is orthogonal to guidelines on using auto& and auto*.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203257 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/docs/CodingStandards.rst b/docs/CodingStandards.rst
index f9685d69ad5..2ebdfbc91bf 100644
--- a/docs/CodingStandards.rst
+++ b/docs/CodingStandards.rst
@@ -746,23 +746,21 @@ The convenience of ``auto`` makes it easy to forget that its default behavior
 is a copy.  Particularly in range-based ``for`` loops, careless copies are
 expensive.
 
-As a rule of thumb, use ``const auto &`` unless you need to mutate or copy the
-result, and use ``const auto *`` when copying pointers.
+As a rule of thumb, use ``auto &`` unless you need to copy the result, and use
+``auto *`` when copying pointers.
 
 .. code-block:: c++
 
-  // Typically there's no reason to mutate or modify Val.
+  // Typically there's no reason to copy.
   for (const auto &Val : Container) { observe(Val); }
-
-  // Remove the const if you need to modify Val.
   for (auto &Val : Container) { Val.change(); }
 
   // Remove the reference if you really want a new copy.
   for (auto Val : Container) { Val.change(); saveSomewhere(Val); }
 
   // Copy pointers, but make it clear that they're pointers.
-  for (const auto *Val : Container) { observe(*Val); }
-  for (auto *Val : Container) { Val->change(); }
+  for (const auto *Ptr : Container) { observe(*Ptr); }
+  for (auto *Ptr : Container) { Ptr->change(); }
 
 Style Issues
 ============