From: H Hartley Sweeten <hartleys@visionengravers.com>
Date: Wed, 24 Oct 2012 23:28:36 +0000 (-0700)
Subject: staging: comedi: cb_pcidda: fix error test in cb_pcidda_attach_pci()
X-Git-Tag: firefly_0821_release~3680^2~1519^2~1004
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=ff331f7d9089a1917bf21d41110b0b182e74c766;p=firefly-linux-kernel-4.4.55.git

staging: comedi: cb_pcidda: fix error test in cb_pcidda_attach_pci()

As pointed out by Fengguang Wu, the error test after finding the
boardinfo should be testing for (!thisboard).

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/staging/comedi/drivers/cb_pcidda.c b/drivers/staging/comedi/drivers/cb_pcidda.c
index 798374fe8da9..06e546f3fdb4 100644
--- a/drivers/staging/comedi/drivers/cb_pcidda.c
+++ b/drivers/staging/comedi/drivers/cb_pcidda.c
@@ -657,7 +657,7 @@ static int cb_pcidda_attach_pci(struct comedi_device *dev,
 	int ret;
 
 	thisboard = cb_pcidda_find_boardinfo(dev, pcidev);
-	if (!pcidev)
+	if (!thisboard)
 		return -ENODEV;
 	dev->board_ptr = thisboard;
 	dev->board_name = thisboard->name;