From: lanshh Date: Fri, 14 Jul 2017 03:41:10 +0000 (+0800) Subject: hid: rkvr: fix application of sizeof to pointer X-Git-Tag: release-20171130_firefly~4^2~185 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=ff9ce5a7ba264648ccd1a191ee7f532d1d269f1b;p=firefly-linux-kernel-4.4.55.git hid: rkvr: fix application of sizeof to pointer Change-Id: I698445dd006551090578fc04226d5c792094ad05 Signed-off-by: lanshh --- diff --git a/drivers/hid/hid-rkvr.c b/drivers/hid/hid-rkvr.c index 969bbc78348d..f37c03c6485c 100644 --- a/drivers/hid/hid-rkvr.c +++ b/drivers/hid/hid-rkvr.c @@ -850,15 +850,15 @@ static int rkvr_hid_read(struct rkvr_iio_hw_device *hdev, int reg, unsigned char struct hid_device *hid = container_of(hdev->dev, struct hid_device, dev); unsigned char report_number = reg; unsigned char report_type = HID_REGR_REPORT; - char buf[1 + sizeof(data) * len]; - int readlen = 1 + sizeof(data) * len; + char buf[1 + sizeof(*data) * len]; + int readlen = 1 + sizeof(*data) * len; int ret; ret = hid_hw_raw_request(hid, report_number, (unsigned char *)buf, readlen, report_type, HID_REQ_GET_REPORT); if (ret != readlen) { hid_err(hid, "id_hw_raw_request fail\n"); } else { - memcpy(data, &buf[1], sizeof(data) * len); + memcpy(data, &buf[1], sizeof(*data) * len); } return 0;