From: Stephane Sezer Date: Wed, 18 Sep 2013 23:37:49 +0000 (-0700) Subject: Remove problematic log lines from folly JSON test. X-Git-Tag: v0.22.0~875 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=ffd25cf7d90cdfc11db8e5e09aac56a587e92eb2;p=folly.git Remove problematic log lines from folly JSON test. Summary: We are logging UTF-8 data in this test. This makes the test infra fail (when using `fbmake runtests` for example). Test Plan: Run existing JSON tests. Reviewed By: shreehari@fb.com FB internal diff: D975249 --- diff --git a/folly/test/JsonTest.cpp b/folly/test/JsonTest.cpp index e19ff21c..6ab97686 100644 --- a/folly/test/JsonTest.cpp +++ b/folly/test/JsonTest.cpp @@ -254,11 +254,6 @@ TEST(Json, UTF8Retention) { folly::fbstring output = folly::parseJson(jsonInput).asString(); folly::fbstring jsonOutput = folly::toJson(output); - LOG(INFO) << "input: " << input - <<" => json: " << jsonInput; - LOG(INFO) << "output: " << output - <<" => json: " << jsonOutput; - EXPECT_EQ(input, output); EXPECT_EQ(jsonInput, jsonOutput); @@ -281,11 +276,6 @@ TEST(Json, UTF8EncodeNonAsciiRetention) { folly::fbstring output = folly::parseJson(jsonInput).asString(); folly::fbstring jsonOutput = folly::json::serialize(output, opts); - LOG(INFO) << "input: " << input - <<" => json: " << jsonInput; - LOG(INFO) << "output: " << output - <<" => json: " << jsonOutput; - EXPECT_EQ(input, output); EXPECT_EQ(jsonInput, jsonOutput);