Chandler Carruth [Mon, 3 Mar 2014 19:28:52 +0000 (19:28 +0000)]
[C++11] Remove the completely unnecessary requirement on SetVector's
remove_if that its predicate is adaptable. We don't actually need this,
we can write a generic adapter for any predicate.
This lets us remove some very wrong std::function usages. We should
never be using std::function for predicates to algorithms. This incurs
an *indirect* call overhead for every evaluation of the predicate, and
makes it very hard to inline through.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202742
91177308-0d34-0410-b5e6-
96231b3b80d8
Diego Novillo [Mon, 3 Mar 2014 18:53:17 +0000 (18:53 +0000)]
Add DWARF discriminator support to DILexicalBlocks.
This adds support for emitting discriminators from DILexicalBlocks.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202736
91177308-0d34-0410-b5e6-
96231b3b80d8
Lang Hames [Mon, 3 Mar 2014 18:50:05 +0000 (18:50 +0000)]
Re-apply r202551, which introduced new PBQP solver.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202735
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Mon, 3 Mar 2014 18:02:34 +0000 (18:02 +0000)]
Revert "[C++11] Replace LLVM atomics with std::atomic."
Breaks the MSVC build.
DataStream.cpp(44): error C2552: 'llvm::Statistic::Value' : non-aggregates cannot be initialized with initializer list
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202731
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Mon, 3 Mar 2014 17:53:30 +0000 (17:53 +0000)]
[C++11] Replace LLVM atomics with std::atomic.
With C++11 we finally have a standardized way to specify atomic operations. Use
them to replace the existing custom implemention. Sadly the translation is not
entirely trivial as std::atomic allows more fine-grained control over the
atomicity. I tried to preserve the old semantics as well as possible.
Differential Revision: http://llvm-reviews.chandlerc.com/D2915
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202730
91177308-0d34-0410-b5e6-
96231b3b80d8
Duncan P. N. Exon Smith [Mon, 3 Mar 2014 16:48:47 +0000 (16:48 +0000)]
C++11: Beware unnecessary copies with auto
It's easy to copy unintentionally when using 'auto', particularly inside
range-based for loops. Best practise is to use 'const&' unless there's
a good reason not to.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202729
91177308-0d34-0410-b5e6-
96231b3b80d8
Duncan P. N. Exon Smith [Mon, 3 Mar 2014 16:48:44 +0000 (16:48 +0000)]
Clarify struct usage guidelines
The current coding standards restrict the use of struct to PODs, but no
one has been following them. This patch updates the standards to
clarify when structs are dangerous and describe common practice in LLVM.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202728
91177308-0d34-0410-b5e6-
96231b3b80d8
Tom Stellard [Mon, 3 Mar 2014 15:22:00 +0000 (15:22 +0000)]
Add patch level to llvm version in CMake and Autoconf
The shared library generated by autoconf will now be called
libLLVM-$(VERSION_MAJOR).$(VERSION_MINOR).$(VERSION_PATCH)$(VERSION_SUFFIX).so
and a symlink named
libLLVM-$(VERSION_MAJOR).$(VERSION_MINOR)$(VERSION_SUFFIX).so will
also be created in the install directory.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202720
91177308-0d34-0410-b5e6-
96231b3b80d8
Richard Osborne [Mon, 3 Mar 2014 15:06:14 +0000 (15:06 +0000)]
Don't emit a blank line when running llvm-config --system-libs.
Summary:
Previously llvm-config --system-libs would print something like:
$ llvm-config --system-libs
-lz -ltinfo -lrt -ldl -lm
Now we don't emit blank line. Functionality is unchanged otherwise, in
particular llvm-config --libs --system-libs still emits the LLVM libraries
and the system libraries on different lines.
Reviewers: chapuni
Reviewed By: chapuni
CC: llvm-commits
Differential Revision: http://llvm-reviews.chandlerc.com/D2901
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202719
91177308-0d34-0410-b5e6-
96231b3b80d8
Daniel Sanders [Mon, 3 Mar 2014 14:31:21 +0000 (14:31 +0000)]
[mips] Prevent %lo relocation being used on MSA loads and stores.
Summary:
Parts of the compiler still believed MSA load/stores have a 16-bit offset when
it is actually 10-bit. Corrected this, and fixed a closely related issue this
uncovered where load/stores with 10-bit and 12-bit offsets (MSA and microMIPS
respectively) could not load/store using offsets from the stack/frame pointer.
They accepted frameindex+offset, but not frameindex by itself.
Reviewers: jacksprat, matheusalmeida
Reviewed By: jacksprat
Differential Revision: http://llvm-reviews.chandlerc.com/D2888
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202717
91177308-0d34-0410-b5e6-
96231b3b80d8
Ed Maste [Mon, 3 Mar 2014 14:27:49 +0000 (14:27 +0000)]
[mips] support FK_Data_2 and FK_Data_8 to fix big-endian debug data
This fixes invalid lengths in .debug_aranges on big-endian mips64
(lengths appear to be left-shifted by 32 bits) and in .debug_loc.
Differential Revision: http://llvm-reviews.chandlerc.com/D2517
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202716
91177308-0d34-0410-b5e6-
96231b3b80d8
Vladimir Medic [Mon, 3 Mar 2014 14:05:14 +0000 (14:05 +0000)]
Fixing a build failure reported by certain buildbots. This will disable jalx instruction for micromips target.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202715
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Mon, 3 Mar 2014 13:59:41 +0000 (13:59 +0000)]
Unbreak the C++11 build.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202714
91177308-0d34-0410-b5e6-
96231b3b80d8
Evgeniy Stepanov [Mon, 3 Mar 2014 13:47:42 +0000 (13:47 +0000)]
[msan] Handle X86 SIMD bitshift intrinsics.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202712
91177308-0d34-0410-b5e6-
96231b3b80d8
Vladimir Medic [Mon, 3 Mar 2014 13:12:59 +0000 (13:12 +0000)]
This patch implements jalx instruction for Mips architecture.This instruction executes a procedure call within the current 256 MB-aligned region and change the ISA Mode from MIPS32 to microMIPS32 or MIPS16e. Usage samples for assembler and dissasembler are provided as well.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202706
91177308-0d34-0410-b5e6-
96231b3b80d8
Tobias Grosser [Mon, 3 Mar 2014 13:00:39 +0000 (13:00 +0000)]
[C++11] Add a basic block range view for RegionInfo
This also switches the users in LLVM to ensure this functionality is tested.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202705
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 3 Mar 2014 10:59:41 +0000 (10:59 +0000)]
[C++11] MSVC 2012 can't handle list-initialization that calls
a constructor either. Just call the constructor directly. I'll look into
making this work with aggregate initialization some other time (when
I have someone with MSVC 2012 handy to test ideas).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202688
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 3 Mar 2014 10:42:58 +0000 (10:42 +0000)]
[C++11] Add two range adaptor views to User: operands and
operand_values. The first provides a range view over operand Use
objects, and the second provides a range view over the Value*s being
used by those operands.
The naming is "STL-style" rather than "LLVM-style" because we have
historically named iterator methods STL-style, and range methods seem to
have far more in common with their iterator counterparts than with
"normal" APIs. Feel free to bikeshed on this one if you want, I'm happy
to change these around if people feel strongly.
I've switched code in SROA and LCG to exercise these mostly to ensure
they work correctly -- we don't really have an easy way to unittest this
and they're trivial.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202687
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 3 Mar 2014 10:28:38 +0000 (10:28 +0000)]
[C++11] Add an iterator_range class template. This is modeled on the
proposed std::iterator_pair which was in committee suggested to move
toward std::iterator_range. There isn't a formal paper yet, but there
seems little disagreement within the committee at this point so it seems
fine to provide our own version in the llvm namespace so we can easily
build range adaptors for the numerous iterators in LLVM's interfaces.
Note that I'm not really comfortable advocating a crazed range-based
migration just yet. The range stuff is still in a great deal of flux in
C++ and the committee hasn't entirely made up its mind (afaict) about
how it will work. So I'm mostly trying to provide the minimal
functionality needed to make writing easy and convenient range adaptors
for range based for loops easy and convenient. ;]
Subsequent patches will use this across the fundamental IR types, where
there are iterator views.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202686
91177308-0d34-0410-b5e6-
96231b3b80d8
Ahmed Charles [Mon, 3 Mar 2014 07:15:46 +0000 (07:15 +0000)]
[C++11] Pass unique_ptr by value instead of &&.
Suggestion by Richard Smith.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202678
91177308-0d34-0410-b5e6-
96231b3b80d8
Saleem Abdulrasool [Mon, 3 Mar 2014 06:35:00 +0000 (06:35 +0000)]
AsmParser: add missed tests
The diagnostics tests were missing from the previous introduction of ifeqs.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202674
91177308-0d34-0410-b5e6-
96231b3b80d8
Venkatraman Govindaraju [Sun, 2 Mar 2014 23:39:07 +0000 (23:39 +0000)]
[Sparc] Add trap on integer condition codes (Ticc) instructions to Sparc backend.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202670
91177308-0d34-0410-b5e6-
96231b3b80d8
Venkatraman Govindaraju [Sun, 2 Mar 2014 22:55:53 +0000 (22:55 +0000)]
[Sparc] Add return/rett instruction to Sparc backend.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202666
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Sun, 2 Mar 2014 21:24:52 +0000 (21:24 +0000)]
Remove unnecessary copy ctors.
They didn't provide any value over the default ones but blocked move semantics.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202664
91177308-0d34-0410-b5e6-
96231b3b80d8
Venkatraman Govindaraju [Sun, 2 Mar 2014 21:17:44 +0000 (21:17 +0000)]
[Sparc] Add support for decoding jmpl/retl/ret instruction.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202663
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Sun, 2 Mar 2014 20:56:28 +0000 (20:56 +0000)]
Give APInt move semantics.
The interaction between defaulted operators and move elision isn't
totally obvious, add a unit test so it doesn't break unintentionally.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202662
91177308-0d34-0410-b5e6-
96231b3b80d8
Venkatraman Govindaraju [Sun, 2 Mar 2014 19:56:19 +0000 (19:56 +0000)]
[Sparc] Add fcmpe* instructions to Sparc backend.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202661
91177308-0d34-0410-b5e6-
96231b3b80d8
Venkatraman Govindaraju [Sun, 2 Mar 2014 19:31:21 +0000 (19:31 +0000)]
[Sparc] Add VIS instructions to sparc backend.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202660
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Sun, 2 Mar 2014 18:23:39 +0000 (18:23 +0000)]
Add a PPC inline asm constraint type for single CR bits
Now that the PowerPC backend can track individual CR bits as first-class
registers, we should also have a way of allocating them for inline asm
statements. Because these registers are only one bit, if an output variable is
implicitly cast to a larger integer size, we'll get an any_extend to that
larger type (this is part of the existing target-independent logic). As a
result, regardless of the size of the output type, only the first bit is
meaningful.
The constraint identifier "wc" has been chosen for this purpose. Although gcc
does not currently support allocating individual CR bits, this identifier
choice has been coordinated with the gcc PowerPC team, and will be marked as
reserved for this purpose in the gcc constraints.md file.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202657
91177308-0d34-0410-b5e6-
96231b3b80d8
Michael Kuperstein [Sun, 2 Mar 2014 15:26:36 +0000 (15:26 +0000)]
Ensure bitcode encoding of instructions and their operands stays stable.
This includes instructions that relate to memory access (load/store/GEP), comparison instructions and calls.
Work was done by lama.saba@intel.com.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202647
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Sun, 2 Mar 2014 13:30:33 +0000 (13:30 +0000)]
[C++11] Replace llvm::tie with std::tie.
The old implementation is no longer needed in C++11.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202644
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Sun, 2 Mar 2014 13:10:45 +0000 (13:10 +0000)]
[C++11] Replace LLVM_STATIC_ASSERT with static_assert, we now have
access to it on all host toolchains.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202642
91177308-0d34-0410-b5e6-
96231b3b80d8
Ahmed Charles [Sun, 2 Mar 2014 13:08:46 +0000 (13:08 +0000)]
Test commit.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202641
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Sun, 2 Mar 2014 12:27:27 +0000 (12:27 +0000)]
[C++11] Replace llvm::next and llvm::prior with std::next and std::prev.
Remove the old functions.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202636
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Sun, 2 Mar 2014 10:07:45 +0000 (10:07 +0000)]
[C++11] Clarify in the Compiler.h support macros and comments (and
assert it with an #error) that we require MSVC 2012; MSVC 2010 will no
longer suffice.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202631
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sun, 2 Mar 2014 09:54:13 +0000 (09:54 +0000)]
[C++11] Remove LLVM_FINAL and LLVM_OVERRIDE macros now that all their uses are gone.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202629
91177308-0d34-0410-b5e6-
96231b3b80d8
Venkatraman Govindaraju [Sun, 2 Mar 2014 09:46:56 +0000 (09:46 +0000)]
[SparcV9] Adds support for branch on integer register instructions (BPr) and conditional moves on integer register (MOVr/FMOVr).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202628
91177308-0d34-0410-b5e6-
96231b3b80d8
Elena Demikhovsky [Sun, 2 Mar 2014 09:19:44 +0000 (09:19 +0000)]
AVX-512: Fixed extract_vector_elt for v8i1 vector
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202624
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Sun, 2 Mar 2014 09:13:39 +0000 (09:13 +0000)]
[C++11] Suggest placing callable arguments as the last argument to
facilitate the nice formatting of lambdas passed there. Suggested by
Chris during review of my lambda additions, and something I strongly
agree with.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202622
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sun, 2 Mar 2014 09:09:27 +0000 (09:09 +0000)]
Switch all uses of LLVM_OVERRIDE to just use 'override' directly.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202621
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Sun, 2 Mar 2014 08:38:35 +0000 (08:38 +0000)]
[C++11] Update the coding standards to provide some important guidance
about a few constructs in C++11 that are worth starting off in
a consistent manner within the codebase.
This will be matched with a change to clang-format's LLVM style which
will switch the options to support C++11 and use these conventions.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202620
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sun, 2 Mar 2014 08:34:05 +0000 (08:34 +0000)]
Add back LLVM_FINAL macro. lld still needs it.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202619
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sun, 2 Mar 2014 08:08:51 +0000 (08:08 +0000)]
Switch all uses of LLVM_FINAL to just use 'final', and remove the macro.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202618
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Sun, 2 Mar 2014 06:37:03 +0000 (06:37 +0000)]
remove an old entry whose link is broken anyway
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202617
91177308-0d34-0410-b5e6-
96231b3b80d8
Venkatraman Govindaraju [Sun, 2 Mar 2014 06:28:15 +0000 (06:28 +0000)]
[Sparc] Add support for parsing branches and conditional move instructions with %fcc1-%fcc3 conditional registers.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202616
91177308-0d34-0410-b5e6-
96231b3b80d8
Venkatraman Govindaraju [Sun, 2 Mar 2014 04:43:45 +0000 (04:43 +0000)]
[Sparc] Make floating point branch instruction formats to accept %fcc0-%fcc1 conditional registers as input.
No functionality change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202614
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Sun, 2 Mar 2014 04:08:41 +0000 (04:08 +0000)]
[C++11] Switch all uses of the llvm_move macro to use std::move
directly, and remove the macro.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202612
91177308-0d34-0410-b5e6-
96231b3b80d8
Venkatraman Govindaraju [Sun, 2 Mar 2014 03:39:39 +0000 (03:39 +0000)]
[Sparc] Add support for parsing fcmp with %fcc registers.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202610
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Sun, 2 Mar 2014 03:38:32 +0000 (03:38 +0000)]
[C++11] Add support for OwningPtr<T> to be converted to and from
std::unique_ptr<T>.
Patch by Ahmed Charles!
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202609
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Sun, 2 Mar 2014 03:26:39 +0000 (03:26 +0000)]
[C++11] Add unit tests for OwningPtr<T> in preparation for changes to make
it interoperate (minimally) with std::unique_ptr<T>. This is part of my
plan to migrate LLVM to use std::unique_ptr with a minimal impact on
out-of-tree code.
Patch by Ahmed Charles with some minor cleanups (and bool casts) by me.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202608
91177308-0d34-0410-b5e6-
96231b3b80d8
Alp Toker [Sun, 2 Mar 2014 03:20:38 +0000 (03:20 +0000)]
[C++11] Expand and eliminate the LLVM_ENUM_INT_TYPE() macro
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202607
91177308-0d34-0410-b5e6-
96231b3b80d8
Venkatraman Govindaraju [Sun, 2 Mar 2014 02:12:33 +0000 (02:12 +0000)]
[Sparc] Add register class for floating point conditional flags (%fcc0 - %fcc3).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202604
91177308-0d34-0410-b5e6-
96231b3b80d8
Sean Silva [Sun, 2 Mar 2014 00:21:42 +0000 (00:21 +0000)]
[docs] Fix some Sphinx warnings.
The docs now build cleanly. Yay!
The following warnings were fixed:
/home/sean/pg/llvm/llvm/docs/HowToReleaseLLVM.rst:364: WARNING: Enumerated list ends without a blank line; unexpected unindent.
/home/sean/pg/llvm/llvm/docs/InAlloca.rst:: WARNING: document isn't included in any toctree
/home/sean/pg/llvm/llvm/docs/CodingStandards.rst:85: WARNING: Title underline too short.
Supported C++11 Language and Library Features
-------------------------------------------
/home/sean/pg/llvm/llvm/docs/CodingStandards.rst:85: WARNING: Title underline too short.
Supported C++11 Language and Library Features
-------------------------------------------
/home/sean/pg/llvm/llvm/docs/GettingStarted.rst:185: WARNING: Explicit markup ends without a blank line; unexpected unindent.
/home/sean/pg/llvm/llvm/docs/GettingStarted.rst:565: WARNING: Explicit markup ends without a blank line; unexpected unindent.
/home/sean/pg/llvm/llvm/docs/GettingStarted.rst:567: WARNING: Block quote ends without a blank line; unexpected unindent.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202603
91177308-0d34-0410-b5e6-
96231b3b80d8
Venkatraman Govindaraju [Sat, 1 Mar 2014 22:03:07 +0000 (22:03 +0000)]
[SparcV9] Add support for parsing branch instructions with prediction.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202602
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Sat, 1 Mar 2014 21:45:41 +0000 (21:45 +0000)]
R600: Add failing control flow tests.
Simple cases hit a variety of problems at -O0.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202601
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Sat, 1 Mar 2014 21:36:57 +0000 (21:36 +0000)]
Remove extra truncs/exts around i32 bit operations on PPC64
This generalizes the code to eliminate extra truncs/exts around i1 bit
operations to also do the same on PPC64 for i32 bit operations. This eliminates
a fairly prevalent code wart:
int foo(int a) {
return a == 5 ? 7 : 8;
}
On PPC64, because of the extension implied by the ABI, this would generate:
cmplwi 0, 3, 5
li 12, 8
li 4, 7
isel 3, 4, 12, 2
rldicl 3, 3, 0, 32
blr
where the 'rldicl 3, 3, 0, 32', the extension, is completely unnecessary. At
least for the single-BB case (which is all that the DAG combine mechanism can
handle), this unnecessary extension is no longer generated.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202600
91177308-0d34-0410-b5e6-
96231b3b80d8
Venkatraman Govindaraju [Sat, 1 Mar 2014 20:08:48 +0000 (20:08 +0000)]
[Sparc] Add support for parsing annulled branch instructions.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202599
91177308-0d34-0410-b5e6-
96231b3b80d8
Venkatraman Govindaraju [Sat, 1 Mar 2014 18:54:52 +0000 (18:54 +0000)]
[Sparc] Add support for parsing sparcv9 instructions addc/subc/addccc/subccc.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202598
91177308-0d34-0410-b5e6-
96231b3b80d8
Venkatraman Govindaraju [Sat, 1 Mar 2014 17:51:00 +0000 (17:51 +0000)]
[Sparc] Add missing ALU instruction patterns.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202597
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Sat, 1 Mar 2014 17:24:40 +0000 (17:24 +0000)]
Make helper function static.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202596
91177308-0d34-0410-b5e6-
96231b3b80d8
Sasa Stankovic [Sat, 1 Mar 2014 16:14:29 +0000 (16:14 +0000)]
Add missing FileCheck in test command line.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202594
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Sat, 1 Mar 2014 11:47:00 +0000 (11:47 +0000)]
Now that we have C++11, turn simple functors into lambdas and remove a ton of boilerplate.
No intended functionality change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202588
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Sat, 1 Mar 2014 10:57:19 +0000 (10:57 +0000)]
[C++11] Remove LLVM_HAS_CXX11_STDLIB now that it is just on.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202587
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Sat, 1 Mar 2014 10:48:14 +0000 (10:48 +0000)]
[C++11] Remove LLVM_HAS_CXX11_TYPETRAITS now that it is a constant due
to the build being C++11.
There is clearly still plenty of simplification than can be done here by
using standard type traits instead of rolling our own in many places.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202586
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Sat, 1 Mar 2014 10:31:48 +0000 (10:31 +0000)]
[C++11] Now that we're not using it, remove the
LLVM_HAS_RVALUE_REFERENCES macro.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202585
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Sat, 1 Mar 2014 09:36:06 +0000 (09:36 +0000)]
[C++11] Remove uses of LLVM_HAS_RVALUE_REFERENCES from the unittests.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202583
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Sat, 1 Mar 2014 09:32:03 +0000 (09:32 +0000)]
[C++11] Remove the use of LLVM_HAS_RVALUE_REFERENCES from the rest of
the core LLVM libraries.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202582
91177308-0d34-0410-b5e6-
96231b3b80d8
Venkatraman Govindaraju [Sat, 1 Mar 2014 09:28:18 +0000 (09:28 +0000)]
[Sparc] Add support to decode unimp instruction.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202581
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Sat, 1 Mar 2014 09:27:28 +0000 (09:27 +0000)]
[C++11] Remove the R-value reference #if usage from the ADT and Support
libraries. It is now always 1 in LLVM builds.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202580
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Sat, 1 Mar 2014 09:12:30 +0000 (09:12 +0000)]
[C++11] Force the other C++11 standard library detection macros to be
on unconditionally. Continuing to break down the C++98 support,
hopefully without breaking anything.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202579
91177308-0d34-0410-b5e6-
96231b3b80d8
Venkatraman Govindaraju [Sat, 1 Mar 2014 09:11:57 +0000 (09:11 +0000)]
[Sparc] Add support to decode negative simm13 operands in the sparc disassembler.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202578
91177308-0d34-0410-b5e6-
96231b3b80d8
Venkatraman Govindaraju [Sat, 1 Mar 2014 08:30:58 +0000 (08:30 +0000)]
[Sparc] Add support for decoding call instructions in the sparc disassembler.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202577
91177308-0d34-0410-b5e6-
96231b3b80d8
Andrew Trick [Sat, 1 Mar 2014 07:57:02 +0000 (07:57 +0000)]
Rewrite a terrible comment about the machine model.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202576
91177308-0d34-0410-b5e6-
96231b3b80d8
Venkatraman Govindaraju [Sat, 1 Mar 2014 07:46:33 +0000 (07:46 +0000)]
[Sparc] Add support to disassemble sparc memory instructions.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202575
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Sat, 1 Mar 2014 06:31:00 +0000 (06:31 +0000)]
[C++11] Turn off compiler-based detection of R-value references, relying
on the fact that we now build in C++11 mode with modern compilers. This
should flush out any issues. If the build bots are happy with this, I'll
GC all the code for coping without R-value references.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202574
91177308-0d34-0410-b5e6-
96231b3b80d8
Venkatraman Govindaraju [Sat, 1 Mar 2014 06:21:00 +0000 (06:21 +0000)]
Add support for parsing sun-style section flags in ELFAsmParser.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202573
91177308-0d34-0410-b5e6-
96231b3b80d8
Venkatraman Govindaraju [Sat, 1 Mar 2014 05:45:09 +0000 (05:45 +0000)]
[Sparc] Implement writeNopData. Emit actual NOP instruction instead of just filling with zeroes.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202572
91177308-0d34-0410-b5e6-
96231b3b80d8
Venkatraman Govindaraju [Sat, 1 Mar 2014 05:07:21 +0000 (05:07 +0000)]
[Sparc] Teach SparcAsmParser to emit correct relocations for PIC code.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202571
91177308-0d34-0410-b5e6-
96231b3b80d8
Mark Seaborn [Sat, 1 Mar 2014 04:30:32 +0000 (04:30 +0000)]
Fix RWMutex to be thread-safe when pthread_rwlock is not available
lib/Support/RWMutex.cpp contains an implementation of RWMutex that
uses pthread_rwlock, but when pthread_rwlock is not available (such as
under NaCl, when using newlib), it silently falls back to using the
no-op definition in lib/Support/Unix/RWMutex.inc, which is not
thread-safe.
Fix this case to be thread-safe by using a normal mutex.
Differential Revision: http://llvm-reviews.chandlerc.com/D2892
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202570
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Sat, 1 Mar 2014 03:33:08 +0000 (03:33 +0000)]
[C++11] Replace autoconf --enable-cxx11 with --enable-cxx1y. The
baseline is now C++11, and we unconditionally add -std=c++11 to the
flags.
This has the dim potential to break some non-GNU-compatible compiler (in
terms of -std flags) using the makefiles, but those makefiles are
littered with GNU-style compile flags so it would be very surprising to
me for it to actually happen in practice. As always, do let me know if
there is a toolchain you're using where this doesn't work, and I'll be
watching the bots.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202569
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Sat, 1 Mar 2014 03:16:07 +0000 (03:16 +0000)]
[C++11] Switch the CMake option from LLVM_ENABLE_CXX11 (default on) to
LLVM_ENABLE_CXX1Y (default *off*). =D C++98 is dead. Long live C++11.
I don't exactly recommend using C++1y just yet though...
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202567
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Sat, 1 Mar 2014 02:48:03 +0000 (02:48 +0000)]
[docs] Update the docs to remove my hedging about C++98 vs. C++11. =]
The switch has been thrown. While I'm still watching for any failures or
problems with this, the documentation can go ahead and move forward.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202566
91177308-0d34-0410-b5e6-
96231b3b80d8
Venkatraman Govindaraju [Sat, 1 Mar 2014 02:28:34 +0000 (02:28 +0000)]
[Sparc] 80 column rule. No functionality change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202565
91177308-0d34-0410-b5e6-
96231b3b80d8
Venkatraman Govindaraju [Sat, 1 Mar 2014 02:18:04 +0000 (02:18 +0000)]
[Sparc] Add support for parsing directives in SparcAsmParser.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202564
91177308-0d34-0410-b5e6-
96231b3b80d8
Venkatraman Govindaraju [Sat, 1 Mar 2014 01:04:26 +0000 (01:04 +0000)]
[Sparc] Emit 'restore' instead of 'restore %g0, %g0, %g0'. This improves the readability of the generated code.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202563
91177308-0d34-0410-b5e6-
96231b3b80d8
Manman Ren [Fri, 28 Feb 2014 23:05:31 +0000 (23:05 +0000)]
SpillPlacement: fix a bug in iterate.
Inside iterate, we scan backwards then scan forwards in a loop. When iteration
is not zero, the last node was just updated so we can skip it. But when
iteration is zero, we can't skip the last node.
For the testing case, fixing this will save a spill and move register copies
from hot path to cold path.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202557
91177308-0d34-0410-b5e6-
96231b3b80d8
Reid Kleckner [Fri, 28 Feb 2014 22:51:27 +0000 (22:51 +0000)]
[CMake] Remove dead C backend option
Patch by Jevin Sweval!
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202556
91177308-0d34-0410-b5e6-
96231b3b80d8
Reid Kleckner [Fri, 28 Feb 2014 22:50:08 +0000 (22:50 +0000)]
Reflow isProfitableToMakeFastCC
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202555
91177308-0d34-0410-b5e6-
96231b3b80d8
Lang Hames [Fri, 28 Feb 2014 22:44:44 +0000 (22:44 +0000)]
Jumped the gun with r202551 and broke some bots that weren't yet C++11ified.
Reverting until the C++11 switch is complete.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202554
91177308-0d34-0410-b5e6-
96231b3b80d8
Lang Hames [Fri, 28 Feb 2014 22:25:24 +0000 (22:25 +0000)]
New PBQP solver, and updates to the PBQP graph.
The previous PBQP solver was very robust but consumed a lot of memory,
performed a lot of redundant computation, and contained some unnecessarily tight
coupling that prevented experimentation with novel solution techniques. This new
solver is an attempt to address these shortcomings.
Important/interesting changes:
1) The domain-independent PBQP solver class, HeuristicSolverImpl, is gone.
It is replaced by a register allocation specific solver, PBQP::RegAlloc::Solver
(see RegAllocSolver.h).
The optimal reduction rules and the backpropagation algorithm have been extracted
into stand-alone functions (see ReductionRules.h), which can be used to build
domain specific PBQP solvers. This provides many more opportunities for
domain-specific knowledge to inform the PBQP solvers' decisions. In theory this
should allow us to generate better solutions. In practice, we can at least test
out ideas now.
As a side benefit, I believe the new solver is more readable than the old one.
2) The solver type is now a template parameter of the PBQP graph.
This allows the graph to notify the solver of any modifications made (e.g. by
domain independent rules) without the overhead of a virtual call. It also allows
the solver to supply policy information to the graph (see below).
3) Significantly reduced memory overhead.
Memory management policy is now an explicit property of the PBQP graph (via
the CostAllocator typedef on the graph's solver template argument). Because PBQP
graphs for register allocation tend to contain many redundant instances of
single values (E.g. the value representing an interference constraint between
GPRs), the new RASolver class uses a uniquing scheme. This massively reduces
memory consumption for large register allocation problems. For example, looking
at the largest interference graph in each of the SPEC2006 benchmarks (the
largest graph will always set the memory consumption high-water mark for PBQP),
the average memory reduction for the PBQP costs was 400x. That's times, not
percent. The highest was 1400x. Yikes. So - this is fixed.
"PBQP: No longer feasting upon every last byte of your RAM".
Minor details:
- Fully C++11'd. Never copy-construct another vector/matrix!
- Cute tricks with cost metadata: Metadata that is derived solely from cost
matrices/vectors is attached directly to the cost instances themselves. That way
if you unique the costs you never have to recompute the metadata. 400x less
memory means 400x less cost metadata (re)computation.
Special thanks to Arnaud de Grandmaison, who has been the source of much
encouragement, and of many very useful test cases.
This new solver forms the basis for future work, of which there's plenty to do.
I will be adding TODO notes shortly.
- Lang.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202551
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Fri, 28 Feb 2014 21:59:51 +0000 (21:59 +0000)]
[docs] Clarify that there isn't much to be done other than watch build
bots when using the standard library facilities. The missing pieces here
aren't always in useful discreet chunks.
Fortunately, the missing pieces are few and far between, and we can
emulate most of them in our headers as needed.
Based on feedback from Lang and Dave.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202548
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Fri, 28 Feb 2014 21:47:41 +0000 (21:47 +0000)]
[C++11] Switch autoconf and make to use C++11 by default. Now both build
systems have the default as C++11, but retain the ability to build with
C++98.
Again, please restrain your enthusiasm a bit in case this needs to be
reverted. =]
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202546
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Fri, 28 Feb 2014 21:37:28 +0000 (21:37 +0000)]
Fix >> to be > > for non-c++11.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202545
91177308-0d34-0410-b5e6-
96231b3b80d8
Tom Stellard [Fri, 28 Feb 2014 21:36:41 +0000 (21:36 +0000)]
R600: Verify all instructions in the AsmPrinter on debug builds
Make a call to R600's implementation of verifyInstruction() to
check that instructions are only using legal operands.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202544
91177308-0d34-0410-b5e6-
96231b3b80d8
Tom Stellard [Fri, 28 Feb 2014 21:36:37 +0000 (21:36 +0000)]
R600/SI: Expand all v16[if]32 operations
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202543
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Fri, 28 Feb 2014 21:30:03 +0000 (21:30 +0000)]
[C++11] Switch CMake to use C++11 by default! Next up, autoconf/make!
Now, please don't get too excited. I've just toggled the default to suss
out the last remaining bot problems. This does *not* mean we can all go
write lots of C++11 code yet. I at least want to let the dust settle
from the bots first.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202542
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Fri, 28 Feb 2014 21:27:59 +0000 (21:27 +0000)]
80-col.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202541
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Fri, 28 Feb 2014 21:27:57 +0000 (21:27 +0000)]
Fix a crasher where when we're attempting to replace a type
during the finalization for CGDebugInfo in clang we would RAUW
a type and it would result in a corrupted MDNode for an
imported declaration.
Testcase pending as reducing has been difficult.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202540
91177308-0d34-0410-b5e6-
96231b3b80d8
Richard Smith [Fri, 28 Feb 2014 21:14:25 +0000 (21:14 +0000)]
Add more whitespace to fix more bullets.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202538
91177308-0d34-0410-b5e6-
96231b3b80d8
Richard Smith [Fri, 28 Feb 2014 21:11:28 +0000 (21:11 +0000)]
Add whitespace to try to fix bulleted list.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202537
91177308-0d34-0410-b5e6-
96231b3b80d8