Devang Patel [Sat, 26 Jan 2008 01:21:48 +0000 (01:21 +0000)]
Add another testcase.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46385
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Sat, 26 Jan 2008 01:09:19 +0000 (01:09 +0000)]
Fix some bugs in SimplifyNodeWithTwoResults where it would call deletenode to
delete a node even if it was not dead in some cases. Instead, just add it to
the worklist. Also, make sure to use the CombineTo methods, as it was doing
things that were unsafe: the top level combine loop could touch dangling memory.
This fixes CodeGen/Generic/2008-01-25-dag-combine-mul.ll
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46384
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Sat, 26 Jan 2008 01:05:42 +0000 (01:05 +0000)]
don't bother making x&-1 only to simplify it in dag combine. This commonly occurs expanding i64 ops.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46383
91177308-0d34-0410-b5e6-
96231b3b80d8
Evan Cheng [Sat, 26 Jan 2008 00:35:43 +0000 (00:35 +0000)]
New test case.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46382
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Fri, 25 Jan 2008 23:34:24 +0000 (23:34 +0000)]
reduce indentation
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46377
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Fri, 25 Jan 2008 22:36:24 +0000 (22:36 +0000)]
add a testcase for a bug Duncan pointed out.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46372
91177308-0d34-0410-b5e6-
96231b3b80d8
Duncan Sands [Fri, 25 Jan 2008 22:06:51 +0000 (22:06 +0000)]
Do this more neatly.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46369
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Fri, 25 Jan 2008 17:49:41 +0000 (17:49 +0000)]
Reorder a field to reduce the size of StackObject. Note that this
may require a clean rebuild on leopard. :(
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46360
91177308-0d34-0410-b5e6-
96231b3b80d8
Duncan Sands [Fri, 25 Jan 2008 17:36:44 +0000 (17:36 +0000)]
Test for PR1942.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46357
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Fri, 25 Jan 2008 17:24:52 +0000 (17:24 +0000)]
fix long lines.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46355
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Fri, 25 Jan 2008 16:41:09 +0000 (16:41 +0000)]
JITEmitter.cpp was trying to sync the icache for function stubs, but
was actually passing a completely incorrect size to sys_icache_invalidate.
Instead of having the JITEmitter do this (which doesn't have the correct
size), just make the target sync its own stubs.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46354
91177308-0d34-0410-b5e6-
96231b3b80d8
Duncan Sands [Fri, 25 Jan 2008 10:20:53 +0000 (10:20 +0000)]
Add more assertions to catch accesses outside of
arrays. Also, as a convenience, don't barf, just
return false, if someone calls isTruncStoreLegal
or isLoadXLegal with an extended type for the in
memory type.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46352
91177308-0d34-0410-b5e6-
96231b3b80d8
Owen Anderson [Fri, 25 Jan 2008 10:10:33 +0000 (10:10 +0000)]
DeadStoreElimination can treat byval parameters as if there were alloca's for the purpose of removing end-of-function stores.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46351
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Fri, 25 Jan 2008 07:29:34 +0000 (07:29 +0000)]
move this field back. Moving the field causes miscompilations (!) of voronoi and others.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46350
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Fri, 25 Jan 2008 07:20:16 +0000 (07:20 +0000)]
Add skeletal code to increase the alignment of loads and stores when
we can infer it. This will eventually help stuff, though it doesn't
do much right now because all fixed FI's have an alignment of 1.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46349
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Fri, 25 Jan 2008 07:19:06 +0000 (07:19 +0000)]
move MachineFrameInfo::CreateFixedObject out of line, give MachineFrameInfo
a reference to TargetFrameInfo. Rearrange order of fields in StackObject to
save a word.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46348
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Fri, 25 Jan 2008 06:40:45 +0000 (06:40 +0000)]
include alignment and volatility information in -view-*-dags output
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46347
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Fri, 25 Jan 2008 06:20:20 +0000 (06:20 +0000)]
add a fixme.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46346
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Fri, 25 Jan 2008 06:14:17 +0000 (06:14 +0000)]
optimize fxor like for
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46345
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Fri, 25 Jan 2008 05:46:26 +0000 (05:46 +0000)]
Add target-specific dag combines for FAND(x,0) and FOR(x,0). This allows
us to compile:
double test(double X) {
return copysign(0.0, X);
}
into:
_test:
andpd LCPI1_0(%rip), %xmm0
ret
instead of:
_test:
pxor %xmm1, %xmm1
andpd LCPI1_0(%rip), %xmm1
movapd %xmm0, %xmm2
andpd LCPI1_1(%rip), %xmm2
movapd %xmm1, %xmm0
orpd %xmm2, %xmm0
ret
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46344
91177308-0d34-0410-b5e6-
96231b3b80d8
Anton Korobeynikov [Fri, 25 Jan 2008 00:34:13 +0000 (00:34 +0000)]
Provide correct DWARF register numbering for debug information emission on x86-32/Darwin.
This should fix bunch of issues.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46337
91177308-0d34-0410-b5e6-
96231b3b80d8
Devang Patel [Thu, 24 Jan 2008 23:55:34 +0000 (23:55 +0000)]
New test.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46333
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Thu, 24 Jan 2008 19:28:11 +0000 (19:28 +0000)]
Don't dump the function!
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46320
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Thu, 24 Jan 2008 19:07:10 +0000 (19:07 +0000)]
getUnderlyingObject can return null, handle this.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46318
91177308-0d34-0410-b5e6-
96231b3b80d8
Ted Kremenek [Thu, 24 Jan 2008 18:59:52 +0000 (18:59 +0000)]
Added additional overloaded operators for APSInt to match the operators of
APInt.
While some operators were already specifically overloaded for APSInt, others
resulted in using the overloaded operator methods in APInt, which would result
in the signedness bit being lost.
Modified the APSInt(APInt&) constructor to be "explicit" and to take an
extra (optional) flag to indicate the signedness. Making the ctor explicit
will catch any implicit conversations between APSInt -> APInt -> APSInt that
results in the signedness flag being lost.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46316
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Thu, 24 Jan 2008 18:00:32 +0000 (18:00 +0000)]
Teach basicaa that 'byval' arguments define a new memory location that
can't be aliased to other known objects. This allows us to know that byval
pointer args don't alias globals, etc.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46315
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Thu, 24 Jan 2008 17:47:11 +0000 (17:47 +0000)]
Add hasByValAttr() and hasNoAliasAttr() methods to the Argument class.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46314
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Thu, 24 Jan 2008 17:10:01 +0000 (17:10 +0000)]
clarify a comment, thanks Duncan.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46313
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Thu, 24 Jan 2008 08:07:48 +0000 (08:07 +0000)]
Significantly simplify and improve handling of FP function results on x86-32.
This case returns the value in ST(0) and then has to convert it to an SSE
register. This causes significant codegen ugliness in some cases. For
example in the trivial fp-stack-direct-ret.ll testcase we used to generate:
_bar:
subl $28, %esp
call L_foo$stub
fstpl 16(%esp)
movsd 16(%esp), %xmm0
movsd %xmm0, 8(%esp)
fldl 8(%esp)
addl $28, %esp
ret
because we move the result of foo() into an XMM register, then have to
move it back for the return of bar.
Instead of hacking ever-more special cases into the call result lowering code
we take a much simpler approach: on x86-32, fp return is modeled as always
returning into an f80 register which is then truncated to f32 or f64 as needed.
Similarly for a result, we model it as an extension to f80 + return.
This exposes the truncate and extensions to the dag combiner, allowing target
independent code to hack on them, eliminating them in this case. This gives
us this code for the example above:
_bar:
subl $12, %esp
call L_foo$stub
addl $12, %esp
ret
The nasty aspect of this is that these conversions are not legal, but we want
the second pass of dag combiner (post-legalize) to be able to hack on them.
To handle this, we lie to legalize and say they are legal, then custom expand
them on entry to the isel pass (PreprocessForFPConvert). This is gross, but
less gross than the code it is replacing :)
This also allows us to generate better code in several other cases. For
example on fp-stack-ret-conv.ll, we now generate:
_test:
subl $12, %esp
call L_foo$stub
fstps 8(%esp)
movl 16(%esp), %eax
cvtss2sd 8(%esp), %xmm0
movsd %xmm0, (%eax)
addl $12, %esp
ret
where before we produced (incidentally, the old bad code is identical to what
gcc produces):
_test:
subl $12, %esp
call L_foo$stub
fstpl (%esp)
cvtsd2ss (%esp), %xmm0
cvtss2sd %xmm0, %xmm0
movl 16(%esp), %eax
movsd %xmm0, (%eax)
addl $12, %esp
ret
Note that we generate slightly worse code on pr1505b.ll due to a scheduling
deficiency that is unrelated to this patch.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46307
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Thu, 24 Jan 2008 07:57:06 +0000 (07:57 +0000)]
Fix this buggy transformation. Two observations:
1. we already know the value is dead, so don't bother replacing
it with undef.
2. The very case the comment describes actually makes the load
live which asserts in deletenode. If we do the replacement
and the node becomes live, just treat it as new. This fixes
a failure on X86/2008-01-16-InvalidDAGCombineXform.ll with
some local changes in my tree.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46306
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Thu, 24 Jan 2008 07:18:21 +0000 (07:18 +0000)]
The dag combiner is missing revisiting nodes that it really should, and thus leaving
dead stuff around. This gets fed into the isel pass and causes certain foldings from
happening because nodes have extraneous uses floating around. For example, if we turned
foo(bar(x)) -> baz(x), we sometimes left bar(x) around.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46305
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Thu, 24 Jan 2008 06:45:35 +0000 (06:45 +0000)]
fold fp_round(fp_round(x)) -> fp_round(x).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46304
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Thu, 24 Jan 2008 06:35:44 +0000 (06:35 +0000)]
take these with a pr #
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46303
91177308-0d34-0410-b5e6-
96231b3b80d8
Gordon Henriksen [Thu, 24 Jan 2008 05:16:36 +0000 (05:16 +0000)]
Fixing the stack walker.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46302
91177308-0d34-0410-b5e6-
96231b3b80d8
Anton Korobeynikov [Thu, 24 Jan 2008 01:20:48 +0000 (01:20 +0000)]
Fix potential buffer overflow
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46296
91177308-0d34-0410-b5e6-
96231b3b80d8
Owen Anderson [Thu, 24 Jan 2008 01:10:07 +0000 (01:10 +0000)]
Move some functionality for adding flags to MachineInstr's into methods on MachineInstr rather than LiveVariables.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46295
91177308-0d34-0410-b5e6-
96231b3b80d8
Evan Cheng [Thu, 24 Jan 2008 00:22:01 +0000 (00:22 +0000)]
Forgot these.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46292
91177308-0d34-0410-b5e6-
96231b3b80d8
Evan Cheng [Wed, 23 Jan 2008 23:17:41 +0000 (23:17 +0000)]
Let each target decide byval alignment. For X86, it's 4-byte unless the aggregare contains SSE vector(s). For x86-64, it's max of 8 or alignment of the type.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46286
91177308-0d34-0410-b5e6-
96231b3b80d8
Ted Kremenek [Wed, 23 Jan 2008 22:29:58 +0000 (22:29 +0000)]
Added special escape sequences "\{", "\}", and "\|" when processing
getNodeLabel(); these sequences allow the user to specify the characters '{',
'}', and '|' in the label, which facilitate breaking the label into multiple
record segments.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46283
91177308-0d34-0410-b5e6-
96231b3b80d8
Duncan Sands [Wed, 23 Jan 2008 20:39:46 +0000 (20:39 +0000)]
The last pieces needed for loading arbitrary
precision integers. This won't actually work
(and most of the code is dead) unless the new
legalization machinery is turned on. While
there, I rationalized the handling of i1, and
removed some bogus (and unused) sextload patterns.
For i1, this could result in microscopically
better code for some architectures (not X86).
It might also result in worse code if annotating
with AssertZExt nodes turns out to be more harmful
than helpful.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46280
91177308-0d34-0410-b5e6-
96231b3b80d8
Ted Kremenek [Wed, 23 Jan 2008 19:57:33 +0000 (19:57 +0000)]
Added "getRoot()" to ImmutableSet.
Made ImmutableSet::ImmutableSet(ImutAVLTree* Root) public. (this allows handy
casting between trees and sets).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46277
91177308-0d34-0410-b5e6-
96231b3b80d8
Dale Johannesen [Wed, 23 Jan 2008 00:58:14 +0000 (00:58 +0000)]
Honor explicit section information on Darwin.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46267
91177308-0d34-0410-b5e6-
96231b3b80d8
Owen Anderson [Tue, 22 Jan 2008 23:58:54 +0000 (23:58 +0000)]
Fix an iterator invalidation issue.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46263
91177308-0d34-0410-b5e6-
96231b3b80d8
Evan Cheng [Tue, 22 Jan 2008 23:26:53 +0000 (23:26 +0000)]
SSE varargs arguments are passed in memory.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46262
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Tue, 22 Jan 2008 19:09:33 +0000 (19:09 +0000)]
Simplify SelectionDAG::getNode so that a big switch stmt is not #ifndef
NDEBUG. This is in response to a really nasty bug I introduced that
Dale tracked down, hopefully this won't happen in the future.
Many thanks Dale.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46254
91177308-0d34-0410-b5e6-
96231b3b80d8
Anton Korobeynikov [Tue, 22 Jan 2008 11:01:23 +0000 (11:01 +0000)]
Silence a warning. Should we turn this into configure-time check?
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46251
91177308-0d34-0410-b5e6-
96231b3b80d8
Anton Korobeynikov [Tue, 22 Jan 2008 11:00:07 +0000 (11:00 +0000)]
Add interator interface to DAGInit also
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46250
91177308-0d34-0410-b5e6-
96231b3b80d8
Duncan Sands [Tue, 22 Jan 2008 07:17:34 +0000 (07:17 +0000)]
The final piece needed for storing arbitrary precision
integers. Handle truncstore of a legal type to an unusual
number of bits. Most of this code is not reachable unless
the new legalize infrastructure is turned on.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46249
91177308-0d34-0410-b5e6-
96231b3b80d8
Nick Lewycky [Tue, 22 Jan 2008 05:42:02 +0000 (05:42 +0000)]
Enable the fix I just checked in, silly me.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46247
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Tue, 22 Jan 2008 05:31:58 +0000 (05:31 +0000)]
update this test to pass with duncan's change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46246
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Tue, 22 Jan 2008 05:19:26 +0000 (05:19 +0000)]
One too many )'s breaks 'make clean' with certain versions of make.
This fixes PR1927
This should be pulled into llvm 2.2.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46245
91177308-0d34-0410-b5e6-
96231b3b80d8
Nick Lewycky [Tue, 22 Jan 2008 05:08:48 +0000 (05:08 +0000)]
Multiply can be evaluated in a different type, so long as the target type has
a smaller bitwidth.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46244
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Tue, 22 Jan 2008 04:47:47 +0000 (04:47 +0000)]
Trivial patch to fix two warnings, please pull into llvm 2.2
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46243
91177308-0d34-0410-b5e6-
96231b3b80d8
Ted Kremenek [Mon, 21 Jan 2008 22:54:46 +0000 (22:54 +0000)]
Fixed buggy caching of the hash value of an ImutAVLTree node.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46229
91177308-0d34-0410-b5e6-
96231b3b80d8
Ted Kremenek [Mon, 21 Jan 2008 22:51:35 +0000 (22:51 +0000)]
Moved method call within a conditional branch because its effects will
be ignored on the false branch.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46228
91177308-0d34-0410-b5e6-
96231b3b80d8
Ted Kremenek [Mon, 21 Jan 2008 22:50:37 +0000 (22:50 +0000)]
Adjusted ImutAVLTree::ComputeHash to compute a hash value that is based on a
clearer sequence of hashing compositions.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46227
91177308-0d34-0410-b5e6-
96231b3b80d8
Ted Kremenek [Mon, 21 Jan 2008 22:49:22 +0000 (22:49 +0000)]
Added "clear" method to FoldingSetNodeID to allow a FoldingSetNodeID object
to be reused to compute multiple object profiles.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46226
91177308-0d34-0410-b5e6-
96231b3b80d8
Ted Kremenek [Mon, 21 Jan 2008 22:33:30 +0000 (22:33 +0000)]
Replaced (FoldingSet) profiling of ImutAVLTree with a hashing based scheme. The
problem was that we previously hashed based on the pointers of the left and
right children, but this is bogus: we can easily have different trees that
represent the same set. Now we use a hashing based scheme that compares the
*contents* of the trees, but not without having to do a full scan of a tree. The
only caveat is that with hashing is that we may have collisions, which result in
two different trees being falsely labeled as equivalent. If this becomes a
problem, we can add extra data to the profile to hopefully resolve most
collisions.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46224
91177308-0d34-0410-b5e6-
96231b3b80d8
Anton Korobeynikov [Mon, 21 Jan 2008 22:30:26 +0000 (22:30 +0000)]
Provide iterator access to ListInit contents
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46223
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Mon, 21 Jan 2008 22:27:27 +0000 (22:27 +0000)]
Fix the failures in the PPC JIT by marking relocation entries for
external symbols (e.g. 'fmod') as needing a stub. This regression
was introduced by Evan's jit patch here:
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-
20071231/056749.html
With this fixed, the two ExecutionEngine failures are passing on ppc,
and the ppc jit works on freebench and olden.
This should be pulled into the 2.2 release branch.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46222
91177308-0d34-0410-b5e6-
96231b3b80d8
Devang Patel [Mon, 21 Jan 2008 22:15:58 +0000 (22:15 +0000)]
New test.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46220
91177308-0d34-0410-b5e6-
96231b3b80d8
Owen Anderson [Mon, 21 Jan 2008 22:03:00 +0000 (22:03 +0000)]
Clarify a deviation from the original algorithm.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46218
91177308-0d34-0410-b5e6-
96231b3b80d8
Owen Anderson [Mon, 21 Jan 2008 22:01:01 +0000 (22:01 +0000)]
Improve a few comments.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46217
91177308-0d34-0410-b5e6-
96231b3b80d8
Duncan Sands [Mon, 21 Jan 2008 21:37:41 +0000 (21:37 +0000)]
It turns out that in C++ it is legal to declare functions
that return an opaque type by value, as long as you don't
call it or provide a body (you can take the address of it).
So it is wrong to insist that sret parameters not be an
opaque*. And I guess it is really up to codegen to complain
if someone tries to call such a function. I'm also removing
the analogous check from byval parameters, since I don't
see why we shouldn't allow them as long as no-one tries to
call the function or give it a body.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46216
91177308-0d34-0410-b5e6-
96231b3b80d8
Devang Patel [Mon, 21 Jan 2008 19:28:13 +0000 (19:28 +0000)]
New test.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46209
91177308-0d34-0410-b5e6-
96231b3b80d8
Duncan Sands [Mon, 21 Jan 2008 11:28:49 +0000 (11:28 +0000)]
Check that sret is only used on pointers to types
with a size, like byval.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46207
91177308-0d34-0410-b5e6-
96231b3b80d8
Duncan Sands [Mon, 21 Jan 2008 11:27:55 +0000 (11:27 +0000)]
Be consistent with other attribute methods, and
check the callee also if it is known.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46206
91177308-0d34-0410-b5e6-
96231b3b80d8
Dale Johannesen [Mon, 21 Jan 2008 01:00:34 +0000 (01:00 +0000)]
Move DAG-changing code out of #ifndef NDEBUG.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46204
91177308-0d34-0410-b5e6-
96231b3b80d8
Duncan Sands [Sun, 20 Jan 2008 16:51:46 +0000 (16:51 +0000)]
Make sure the caller doesn't use freed memory.
Fixes PR1935.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46203
91177308-0d34-0410-b5e6-
96231b3b80d8
Anton Korobeynikov [Sun, 20 Jan 2008 14:00:07 +0000 (14:00 +0000)]
Honour ByVal parameter attribute for name decoration
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46200
91177308-0d34-0410-b5e6-
96231b3b80d8
Anton Korobeynikov [Sun, 20 Jan 2008 13:59:37 +0000 (13:59 +0000)]
Remove Darwin'ism
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46199
91177308-0d34-0410-b5e6-
96231b3b80d8
Anton Korobeynikov [Sun, 20 Jan 2008 13:58:16 +0000 (13:58 +0000)]
Enable PIC codegen on x86-64/linux
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46198
91177308-0d34-0410-b5e6-
96231b3b80d8
Duncan Sands [Sun, 20 Jan 2008 10:49:23 +0000 (10:49 +0000)]
Initializing an unsigned with ~0UL causes the compiler
to complain on x86-64 (gcc 4.1). Use ~0U instead.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46197
91177308-0d34-0410-b5e6-
96231b3b80d8
Dale Johannesen [Sun, 20 Jan 2008 01:18:38 +0000 (01:18 +0000)]
Do not generate a FP_ROUND of f64 to f64.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46195
91177308-0d34-0410-b5e6-
96231b3b80d8
Ted Kremenek [Sat, 19 Jan 2008 17:21:43 +0000 (17:21 +0000)]
Changed argument name for 'Profile' method to potentially fix a name conflict
reported in pr1929 (http://llvm.org/PR1929).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46193
91177308-0d34-0410-b5e6-
96231b3b80d8
Duncan Sands [Sat, 19 Jan 2008 16:42:10 +0000 (16:42 +0000)]
Need to handle any 'nest' parameter before integer
parameters, since otherwise it won't be passed in
the right register. With this change trampolines
work on x86-64 (thanks to Luke Guest for providing
access to an x86-64 box).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46192
91177308-0d34-0410-b5e6-
96231b3b80d8
Ted Kremenek [Sat, 19 Jan 2008 04:51:55 +0000 (04:51 +0000)]
Modified ImmutableSet/ImmutableMap to use FoldingSet profiling using
FoldingSetTrait instead of directly calling a 'Profile' method.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46190
91177308-0d34-0410-b5e6-
96231b3b80d8
Ted Kremenek [Sat, 19 Jan 2008 04:31:12 +0000 (04:31 +0000)]
Added FoldingSet style 'profiling' support for APSInt.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46189
91177308-0d34-0410-b5e6-
96231b3b80d8
Ted Kremenek [Sat, 19 Jan 2008 04:23:33 +0000 (04:23 +0000)]
Added FoldingSet style 'profiling' support for APInt.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46188
91177308-0d34-0410-b5e6-
96231b3b80d8
Ted Kremenek [Sat, 19 Jan 2008 04:22:50 +0000 (04:22 +0000)]
Made 'FoldingSetNodeID' a proper class instead of a nested class in
'FoldingSetNodeImpl' (previously 'FoldingSetNodeID' was a typedef of
'FoldingSetNodeImpl::NodeID').
Why? Clients can now easily forward declare 'FoldingSetNodeID' without having
to include FoldingSet.h.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46187
91177308-0d34-0410-b5e6-
96231b3b80d8
Ted Kremenek [Sat, 19 Jan 2008 03:58:00 +0000 (03:58 +0000)]
Made 'profiling' of objects in a FoldingSet trait-based using FoldingSetTrait
instead of always assuming that the stored objects had a method called
'Profile'. The default behavior is to dispatch to a 'Profile' method (as
before), but via template specialization this behavior can now be overridden by
clients.
Added templated class 'FoldingSetNodeWrapper', a generic wrapper class that
allows one to insert objects into a FoldingSet that do not directly inherit from
FoldingSetNode. This is useful for inserting objects that do not always need to
pay the overhead of inheriting from FoldingSetNode, or were designed with that
behavior in mind.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46186
91177308-0d34-0410-b5e6-
96231b3b80d8
Evan Cheng [Fri, 18 Jan 2008 21:01:00 +0000 (21:01 +0000)]
Fix makefiles to enable Apply style debug build.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46180
91177308-0d34-0410-b5e6-
96231b3b80d8
Dale Johannesen [Fri, 18 Jan 2008 19:55:37 +0000 (19:55 +0000)]
Implement flt_rounds for PowerPC.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46174
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Fri, 18 Jan 2008 19:53:43 +0000 (19:53 +0000)]
remove extraneous &&'s from tests, as Scott is apparently not going to.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46173
91177308-0d34-0410-b5e6-
96231b3b80d8
Dale Johannesen [Fri, 18 Jan 2008 19:53:31 +0000 (19:53 +0000)]
Test is correct again for the moment.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46172
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Fri, 18 Jan 2008 19:36:20 +0000 (19:36 +0000)]
remove extraneous &'s.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46171
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Fri, 18 Jan 2008 18:54:31 +0000 (18:54 +0000)]
don't form an std::string with a null pointer, it aborts.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46166
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Fri, 18 Jan 2008 18:51:16 +0000 (18:51 +0000)]
get symbolic information for ppc ldbl nodes.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46165
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Fri, 18 Jan 2008 17:13:03 +0000 (17:13 +0000)]
remove magic numbers.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46162
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Fri, 18 Jan 2008 16:54:56 +0000 (16:54 +0000)]
Fix a latent bug exposed by my truncstore patch. We compiled stfiwx-2.ll to:
_test:
fctiwz f0, f1
stfiwx f0, 0, r4
blr
instead of:
_test:
fctiwz f0, f1
stfd f0, -8(r1)
nop
nop
lwz r2, -4(r1)
stb r2, 0(r4)
blr
The former is not correct (stores 4 bytes, not 1).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46161
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Fri, 18 Jan 2008 06:52:41 +0000 (06:52 +0000)]
make a method public
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46159
91177308-0d34-0410-b5e6-
96231b3b80d8
Ted Kremenek [Fri, 18 Jan 2008 00:38:04 +0000 (00:38 +0000)]
Reverted implementation of ImmutableMap::find() to return a TreeTy* instead of
an iterator, since the implementation returned an iterator that pointed to a
different node! Renamed this implementation to SlimFind() so that users do not
expect it to return an iterator (it is a more efficient implementation than
returning an iterator if the user just wants to find the value of a key).
Added a FIXME to implement ImmutableMap::find() that returns an iterator.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46150
91177308-0d34-0410-b5e6-
96231b3b80d8
Dale Johannesen [Thu, 17 Jan 2008 23:36:04 +0000 (23:36 +0000)]
Revert the part of 45849 that treated weak globals
as weak globals rather than commons. While not wrong,
this change tickled a latent bug in Darwin's strip,
so revert it for now as a workaround.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46147
91177308-0d34-0410-b5e6-
96231b3b80d8
Dale Johannesen [Thu, 17 Jan 2008 23:04:07 +0000 (23:04 +0000)]
Revert the part of 45848 that treated weak globals
as weak globals rather than commons. While not wrong,
this change tickled a latent bug in Darwin's strip,
so revert it for now as a workaround.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46144
91177308-0d34-0410-b5e6-
96231b3b80d8
Scott Michel [Thu, 17 Jan 2008 20:38:41 +0000 (20:38 +0000)]
Forward progress: crtbegin.c now compiles successfully!
Fixed CellSPU's A-form (local store) address mode, so that all globals,
externals, constant pool and jump table symbols are now wrapped within
a SPUISD::AFormAddr pseudo-instruction. This now identifies all local
store memory addresses, although it requires a bit of legerdemain during
instruction selection to properly select loads to and stores from local
store, properly generating "LQA" instructions.
Also added mul_ops.ll test harness for exercising integer multiplication.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46142
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Thu, 17 Jan 2008 19:59:44 +0000 (19:59 +0000)]
This commit changes:
1. Legalize now always promotes truncstore of i1 to i8.
2. Remove patterns and gunk related to truncstore i1 from targets.
3. Rename the StoreXAction stuff to TruncStoreAction in TLI.
4. Make the TLI TruncStoreAction table a 2d table to handle from/to conversions.
5. Mark a wide variety of invalid truncstores as such in various targets, e.g.
X86 currently doesn't support truncstore of any of its integer types.
6. Add legalize support for truncstores with invalid value input types.
7. Add a dag combine transform to turn store(truncate) into truncstore when
safe.
The later allows us to compile CodeGen/X86/storetrunc-fp.ll to:
_foo:
fldt 20(%esp)
fldt 4(%esp)
faddp %st(1)
movl 36(%esp), %eax
fstps (%eax)
ret
instead of:
_foo:
subl $4, %esp
fldt 24(%esp)
fldt 8(%esp)
faddp %st(1)
fstps (%esp)
movl 40(%esp), %eax
movss (%esp), %xmm0
movss %xmm0, (%eax)
addl $4, %esp
ret
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46140
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Thu, 17 Jan 2008 19:47:23 +0000 (19:47 +0000)]
new testcase.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46139
91177308-0d34-0410-b5e6-
96231b3b80d8
Ted Kremenek [Thu, 17 Jan 2008 17:36:49 +0000 (17:36 +0000)]
Implemented "FIXME" in ImutAVLTree: isEqual() now also compares the *data* value
and not just the key value when comparing trees. To do this we added data_type
and data_type_ref to the ImutContainerInfo trait classes. For values stored in
the tree that do not have separate key and data components, data_type is simply
a typedef of bool, and isDataEqual() always evaluates to true. This allows us to
support both ImmutableSet and ImmutableMap using the same underlying logic.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46130
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Thu, 17 Jan 2008 07:30:38 +0000 (07:30 +0000)]
add some helper methods.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46128
91177308-0d34-0410-b5e6-
96231b3b80d8
Evan Cheng [Thu, 17 Jan 2008 07:26:31 +0000 (07:26 +0000)]
Test case for varargs parameter attribute issue I just fixed.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46127
91177308-0d34-0410-b5e6-
96231b3b80d8