Christopher Brannon [Fri, 15 Oct 2010 00:23:47 +0000 (19:23 -0500)]
staging: speakup: speakup_acntsa.c: style fixes
* Clean this file based on reports from checkpatch.pl.
* Eliminate an unused function-like macro.
Signed-off-by: Christopher Brannon <chris@the-brannons.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Christopher Brannon [Fri, 15 Oct 2010 00:23:46 +0000 (19:23 -0500)]
staging: speakup: speakup_acntpc.c: style fixes
* Clean this file based on reports from checkpatch.pl.
* Eliminate the unused synth_readable macro.
* Convert function-like macros to inline functions.
Signed-off-by: Christopher Brannon <chris@the-brannons.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Pavan Savoy [Tue, 12 Oct 2010 20:27:38 +0000 (16:27 -0400)]
drivers: misc: ti-st: fix review comments
Based on comments from Jiri Slaby, drop the register
storage specifier, remove the unused code, cleanup
the const to non-const type casting.
Also make the line discipline ops structure static, since
its a singleton, unmodified structure which need not be
in heap.
Reported-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Pavan Savoy <pavan_savoy@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
mike.rapoport@gmail.com [Tue, 12 Oct 2010 22:09:13 +0000 (00:09 +0200)]
staging: brcm80211: remove unrefrenced malloced field
from 'struct osl_info' structure
Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
mike.rapoport@gmail.com [Tue, 12 Oct 2010 22:09:12 +0000 (00:09 +0200)]
staging: brcm80211: replace MFREE with kfree
Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
mike.rapoport@gmail.com [Tue, 12 Oct 2010 22:09:11 +0000 (00:09 +0200)]
staging: brcm80211: remove unused NATIVE_{MALLOC,MFREE}
Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
mike.rapoport@gmail.com [Tue, 12 Oct 2010 22:09:10 +0000 (00:09 +0200)]
staging: brcm80211: replace MALLOC() with k[zm]alloc
Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
mike.rapoport@gmail.com [Tue, 12 Oct 2010 22:09:09 +0000 (00:09 +0200)]
staging: brcm80211: remove osl_malloced()/MALLOCED()
because there are other means to track memory leaks in kernel
Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
mike.rapoport@gmail.com [Tue, 12 Oct 2010 22:09:08 +0000 (00:09 +0200)]
staging: brcm80211: remove DHD_USE_STATIC_BUF
The DHD_USE_STATIC_BUF cannot be enabled in the build configuration,
remove it.
Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 14 Oct 2010 19:26:08 +0000 (12:26 -0700)]
Staging: brcm80211: fix up compiler warnings I created
I messed up on some of the uintptr conversions, this fixes them up
properly.
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
mike.rapoport@gmail.com [Tue, 12 Oct 2010 22:09:07 +0000 (00:09 +0200)]
staging: brcm80211: remove OSL_DELAY
and use udelay and mdelay instead
Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
nohee ko [Wed, 13 Oct 2010 21:26:52 +0000 (14:26 -0700)]
staging: brcm80211: brcmfmac: bug fix - scan result report
Scan result was reported with some duplicated information.
Those were about SSID/ rate. With this patch, the duplication
can be erased.
Signed-off-by: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
nohee ko [Wed, 13 Oct 2010 21:24:25 +0000 (14:24 -0700)]
staging: brcm80211: brcmfmac: replace KILL_PROC with send_sig()
logic optimization : replace KILL_PROC with send_sig()
Signed-off-by: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Brett Rudley [Tue, 12 Oct 2010 22:01:58 +0000 (15:01 -0700)]
staging: brcm80211: Purge unused bcmwpa.[ch]
Move two macros into wlc_mac80211.h and purge the rest.
Signed-off-by: Brett Rudley <brudley@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Randy Dunlap [Wed, 13 Oct 2010 20:10:49 +0000 (13:10 -0700)]
staging: speakup: fix printk format warning
Fix printk format warning:
drivers/staging/speakup/serialio.c:44: warning: format '%x' expects type 'unsigned int', but argument 2 has type 'long unsigned int'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: <speakup@braille.uwo.ca>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bernhard Walle [Wed, 13 Oct 2010 16:38:38 +0000 (18:38 +0200)]
staging: octeon: Remove USB code
Remove functions and definitions that refer to USB since the driver
doesn't support USB and it's not planned to add USB support to that
driver. So the code is just dead code which can be removed.
Cc: David Daney <ddaney@caviumnetworks.com>
Signed-off-by: Bernhard Walle <walle@corscience.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Thu, 14 Oct 2010 11:36:11 +0000 (13:36 +0200)]
staging: ft1000: Use specific error return value.
Signed-off-by: Marek Belisko <marek.belisko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Thu, 14 Oct 2010 12:14:33 +0000 (14:14 +0200)]
staging: ft1000: Get rid of using atoi.
Signed-off-by: Marek Belisko <marek.belisko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Thu, 14 Oct 2010 15:59:53 +0000 (16:59 +0100)]
staging: sst: Remove the aava bits
We don't need these special cases any more.
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Vinod Koul [Thu, 14 Oct 2010 15:59:38 +0000 (16:59 +0100)]
staging: sst: remove the kernel locking in ioctl
kernel locking in ioctl was introduced when ioctl function was
moved from ioctl to unlocked ioctl
This is no longer required hence removed
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Thu, 14 Oct 2010 09:41:00 +0000 (11:41 +0200)]
staging: ft1000: remove dead code.
was #ifdef so remove code which was under #else to make
code more readable.
Signed-off-by: Marek Belisko <marek.belisko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Thu, 14 Oct 2010 09:40:59 +0000 (11:40 +0200)]
staging: ft1000: correct indentations for ft1000_usb.c file.
Signed-off-by: Marek Belisko <marek.belisko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Thu, 14 Oct 2010 09:40:58 +0000 (11:40 +0200)]
staging: ft1000: replace and remove c99 comments.
Comments for probe, disconnect, init and exit functions
removed completely (functions names are self explaining).
Signed-off-by: Marek Belisko <marek.belisko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Thu, 14 Oct 2010 09:40:57 +0000 (11:40 +0200)]
staging: ft1000: lines over 80 characters corrected.
Signed-off-by: Marek Belisko <marek.belisko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Thu, 14 Oct 2010 09:40:56 +0000 (11:40 +0200)]
staging: ft1000: various checkpatch.pl fixes.
Signed-off-by: Marek Belisko <marek.belisko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Michael Hennerich [Thu, 14 Oct 2010 08:17:18 +0000 (10:17 +0200)]
staging: iio: ad7476: fix !CONFIG_IIO_RING_BUFFER build issue reported by Randy Dunlap
Fix function function decalration
Enable CONFIG_IIO_RING_BUFFER for the ad7476 driver
Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
nohee ko [Tue, 12 Oct 2010 20:33:29 +0000 (13:33 -0700)]
staging: brcm80211: bug fix- rmmod hang problem
Bug fix - rmmod hang problem.
Can keep both of kthread & down_interruptible.
And in the meantime, can terminate the threads
properly during rmmod process.
Signed-off-by: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 12 Oct 2010 21:04:26 +0000 (14:04 -0700)]
Staging: brcm80211: remove sbpciregs_t typedef
don't use a typedef, use a 'struct'.
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 12 Oct 2010 20:20:38 +0000 (13:20 -0700)]
Staging: brcm80211: util: remove unneeded use of uintptr
uintptr shouldn't be used when you are just casting to a pointer anyway,
so remove it from these usages.
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 12 Oct 2010 20:20:19 +0000 (13:20 -0700)]
Staging: brcm80211: sys: remove unneeded use of uintptr
uintptr shouldn't be used when you are just casting to a pointer anyway,
so remove it from these usages.
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 12 Oct 2010 20:20:00 +0000 (13:20 -0700)]
Staging: brcm80211: phy: remove unneeded use of uintptr
uintptr shouldn't be used when you are just casting to a pointer anyway,
so remove it from these usages.
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 12 Oct 2010 20:18:17 +0000 (13:18 -0700)]
Staging: brcm80211: include: remove unneeded use of uintptr
uintptr shouldn't be used when you are just casting to a pointer anyway,
so remove it from these usages.
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 12 Oct 2010 20:04:58 +0000 (13:04 -0700)]
Staging: brcm80211: bcmsdpcm: remove a bunch of unused macros
These direct memory reading macros are not being used, so remove them.
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 12 Oct 2010 19:50:15 +0000 (12:50 -0700)]
Staging: brcm80211: remove FALSE #define
use the kernel provided 'false' value instead, especially
as we are using a 'bool' for these variables.
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 12 Oct 2010 19:15:18 +0000 (12:15 -0700)]
Staging: brcm80211: remove TRUE #define
use the kernel provided 'true' value instead, especially
as we are using a 'bool' for these variables.
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
William Hubbs [Tue, 12 Oct 2010 16:39:30 +0000 (11:39 -0500)]
staging: speakup: kobjects.c: style fixes
clean upd this file based on reports from checkpatch.pl
Signed-off-by: William Hubbs <w.d.hubbs@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
William Hubbs [Tue, 12 Oct 2010 16:39:29 +0000 (11:39 -0500)]
staging: speakup: keyhelp.c: style fixes
Clean up this file based on reports from checkpatch.pl.
Signed-off-by: William Hubbs <w.d.hubbs@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
William Hubbs [Tue, 12 Oct 2010 16:39:28 +0000 (11:39 -0500)]
staging: speakup: i18n.c: style fixes
Clean up this file based on reports from checkpatch.pl.
Signed-off-by: William Hubbs <w.d.hubbs@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
William Hubbs [Tue, 12 Oct 2010 16:39:27 +0000 (11:39 -0500)]
staging: speakup: devsynth.c: style fixes
clean up this file based on reports from checkpatch.pl.
Signed-off-by: William Hubbs <w.d.hubbs@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Hank Janssen [Tue, 12 Oct 2010 17:45:23 +0000 (10:45 -0700)]
staging: hv: Doubled ringbuffer size for Hyper-v network driver
Double the default network ringsize buffer for Hyper-V network driver.
In very heavily loaded systems the there is a chance you run out of
ringbuffer space and error out.
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Tue, 12 Oct 2010 08:26:43 +0000 (10:26 +0200)]
staging: ft1000: get rid of typedef usage.
Signed-off-by: Marek Belisko <marek.belisko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Tue, 12 Oct 2010 08:26:42 +0000 (10:26 +0200)]
staging: ft1000: Remove unused/unnecessary comments.
Signed-off-by: Marek Belisko <marek.belisko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Tue, 12 Oct 2010 08:26:41 +0000 (10:26 +0200)]
staging: ft1000: Fix memory leak when polling fail.
Signed-off-by: Marek Belisko <marek.belisko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Tue, 12 Oct 2010 08:26:40 +0000 (10:26 +0200)]
staging: ft1000-usb: Remove global flag DSP_loading.
This patch remove global flag DSP_loading which was checked
only on one place. Instead check return value for dsp_reload() function.
Signed-off-by: Marek Belisko <marek.belisko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Andy Shevchenko [Tue, 12 Oct 2010 13:22:49 +0000 (16:22 +0300)]
staging: wlags49_h2: remove custom macros min() and max()
Signed-off-by: Andy Shevchenko <ext-andriy.shevchenko@nokia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Andy Shevchenko [Tue, 12 Oct 2010 13:22:48 +0000 (16:22 +0300)]
staging: rt2860: remove custom min() and max()
Signed-off-by: Andy Shevchenko <ext-andriy.shevchenko@nokia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Andy Shevchenko [Mon, 11 Oct 2010 13:58:33 +0000 (16:58 +0300)]
staging: brcm80211: remove useless bcm_ether_ntoa()
Since we have '%pM' modifier in the kernel's *printf() we don't need to
convert address to the string beforehand.
Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Nohee Ko <noheek@broadcom.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Cc: linux-wireless@vger.kernel.org
Cc: devel@driverdev.osuosl.org
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
nohee ko [Tue, 12 Oct 2010 01:33:45 +0000 (18:33 -0700)]
staging: brcm80211: remove duplicated function, wf_channel2mhz
remove duplicated function, wf_channel2mhz
Signed-off-by: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Michael Hennerich [Tue, 12 Oct 2010 08:30:51 +0000 (10:30 +0200)]
staging: iio: adc: ad799x miscellaneous cleanups
-Simplify by using iio_alloc_pollfunc helper function
-Print in_scale in decimal format.
-Simplify ring pointer dereferences
Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Michael Hennerich [Mon, 11 Oct 2010 16:05:56 +0000 (18:05 +0200)]
staging: iio: adc: ad7476 more list review feedback by Jonathan Cameron
Print in_scale in decimal format.
Kconfig list the names of the parts in full, to ease seraching.
Use st->spi in the call as it is only used the once.
Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Michael Hennerich [Mon, 11 Oct 2010 16:05:37 +0000 (18:05 +0200)]
staging: iio: adc: ad7476 new SPI ADC driver
New driver handling:
AD7475, AD7476, AD7477, AD7478, AD7466, AD7467, AD7468, AD7495
SPI micropower and high speed 12-/10-/8-Bit ADCs
staging: iio: adc: ad7476 apply list review feedback by Jonathan Cameron
Changes since last RFC post V1:
Mainly list review feedback by Jonathan Cameron
-Remove scan_attrs from chip info structure.
-Remove name from chip info structure, use new spi_device_id instead.
-Allow transfer buffers to live in their own cache lines, to avoid DMA/cache coherency issues.
-Move scan el code into the ring buffer file.
-Use helper function to alloc the pollfunc.
-Use regulator framework and get vref_mv from the regulator in case not specified by pdata.
-Devices with buit-in reference use vref from the chip info structure
-Don't error on missing platform_data
-Make vref_mv type unsigned short
-Print in_scale "Vref / 2^(bits)" if fractional.
Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Randy Dunlap [Tue, 12 Oct 2010 00:47:04 +0000 (17:47 -0700)]
staging: intel_sst: include delay.h to fix build error
intel_sst_drv_interface.c uses msleep() so it needs to include delay.h:
drivers/staging/intel_sst/intel_sst_drv_interface.c:88: error: implicit declaration of function 'msleep'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jason Cooper [Mon, 11 Oct 2010 14:03:00 +0000 (10:03 -0400)]
staging: brcm80211: remove BCMNMIATTACHFN() macro.
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jason Cooper [Mon, 11 Oct 2010 14:02:59 +0000 (10:02 -0400)]
staging: brcm80211: remove BCMUNINITFN() macro.
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jason Cooper [Mon, 11 Oct 2010 14:02:58 +0000 (10:02 -0400)]
staging: brcm80211: remove BCMINITFN() macro.
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jason Cooper [Mon, 11 Oct 2010 14:02:57 +0000 (10:02 -0400)]
staging: brcm80211: remove BCMINITDATA() macro.
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jason Cooper [Mon, 11 Oct 2010 14:02:56 +0000 (10:02 -0400)]
staging: brcm80211: fix various checkpatch errors.
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jason Cooper [Mon, 11 Oct 2010 14:02:55 +0000 (10:02 -0400)]
staging: brcm80211: s/unsigned char/size_t/ for min_t()
Avoid potential truncation.
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Andy Shevchenko [Mon, 11 Oct 2010 09:07:35 +0000 (12:07 +0300)]
staging: brcm80211: remove custom string library again
There was a clean up commit for softmac driver. Do the same for fullmac
implementation.
Here:
- strtoul and bcm_strtoul are changed to simple_strtoul
- bcmstrtok -> strsep
All unused functions are deleted.
Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Andy Shevchenko [Mon, 11 Oct 2010 09:07:34 +0000 (12:07 +0300)]
staging: brcm80211: clean up custom ctype library again
The similar cleanup was done before for softmac implementation. But the
fullmac driver brings this back. Remove it again.
Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Tracey Dent [Mon, 11 Oct 2010 04:00:44 +0000 (00:00 -0400)]
Staging: speakup: i18n.c: cleaned up file
Cleaned up file with the use of checkpatch.pl.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Vasiliy Kulikov [Sun, 10 Oct 2010 17:28:43 +0000 (21:28 +0400)]
staging: intel_sst: use signed int for error codes
As retval stores error code, it should be signed int.
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Vasiliy Kulikov [Sun, 10 Oct 2010 17:28:47 +0000 (21:28 +0400)]
staging: intel_sst: fix signess error
str_id was unsigned, so check for (str_id <= 0) made no sense.
Made it signed.
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Vasiliy Kulikov [Sun, 10 Oct 2010 17:28:55 +0000 (21:28 +0400)]
staging: tidspbridge: fix signess error
i was unsigned, so check for (i < 0) made no sense. Made it signed.
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jason Cooper [Sun, 10 Oct 2010 18:07:09 +0000 (14:07 -0400)]
staging: brcm80211: fix 'comparison..cast' compiler warnings.
Use min_t() macro instead of min().
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Sun, 10 Oct 2010 12:52:59 +0000 (05:52 -0700)]
Staging: brcm80211: remove __cplusplus markers
It's not needed within the kernel, so remove them.
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jason Cooper [Sat, 9 Oct 2010 18:51:15 +0000 (14:51 -0400)]
staging: brcm80211: remove BLOCKABLE so no one uses it.
BLOCKABLE() doesn't do what it's supposed to.
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jason Cooper [Sat, 9 Oct 2010 18:51:14 +0000 (14:51 -0400)]
staging: brcm80211: remove kernel_thread() for wl_iscan_thread and wl_event_thread.
Replace kernel_thread() with kthread_run(). Replace pid with tsk,
and exited with kthread_stop()/kthread_should_stop().
event_tsk, and tsk are NULL when their respective threads are not running.
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jason Cooper [Sat, 9 Oct 2010 18:51:13 +0000 (14:51 -0400)]
staging: brcm80211: remove kernel_thread() for _iscan_sysioc_thread.
Replace kernel_thread() with kthread_run, kthread_stop() and
kthread_should_stop(). Remove sysioc_pid, sysioc_exit, and DAEMONIZE.
sysioc_tsk is NULL when not running.
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jason Cooper [Sat, 9 Oct 2010 18:51:12 +0000 (14:51 -0400)]
staging: brcm80211: remove kernel_thread() for _dhd_sysioc_thread.
Replaced kernel_thread() with kthread_run(), kthread_stop(), and
kthread_should_stop(). Also removed all references to sysioc_pid and
sysioc_exit. DAEMONIZE removed because not used in dhd_linux.c.
sysioc_tsk is NULL when not running.
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jason Cooper [Sat, 9 Oct 2010 18:51:11 +0000 (14:51 -0400)]
staging: brcm80211: remove kernel_thread() for dhd_dpc_thread.
use kthread_run(), kthread_stop(), and kthread_should_stop(). Removes
dpc_pid, dpc_exited, and the call to DAEMONIZE.
dpc_tsk is NULL when not running.
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jason Cooper [Sat, 9 Oct 2010 18:51:10 +0000 (14:51 -0400)]
staging: brcm80211: remove kernel_thread() for dhd_watchdog_thread.
Replaced kernel_thread() with kthread_run(). Used kthread_should_stop()
in place of watchdog_exited completion. Replaced watchdog_pid with
struct task_struct.
watchdog_tsk is NULL when the task is not running.
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
nohee ko [Sat, 9 Oct 2010 17:41:05 +0000 (10:41 -0700)]
staging: brcm80211: remove unnecessary cflag, LINUX
remove unnecessary cflag, LINUX
Signed-off-by: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
nohee ko [Sat, 9 Oct 2010 17:39:49 +0000 (10:39 -0700)]
staging: brcm80211: remove unnecessary cflag, CONFIG_CFG80211
remove unnecessary cflag, CONFIG_CFG80211
Signed-off-by: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
nohee ko [Sat, 9 Oct 2010 17:38:21 +0000 (10:38 -0700)]
staging: brcm80211: remove unnecessary cflag, BCMWPA2
remove unnecessary cflag, BCMWPA2.
BCMDRIVER is already not used.
Signed-off-by: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
nohee ko [Sat, 9 Oct 2010 17:34:38 +0000 (10:34 -0700)]
staging: brcm80211: remove duplicated file, bcmutils.c
Remove duplicated file, bcmutils.c under brcm80211/brcmfmac.
brcm80211/util/bcmutils.c will be shared between softmac
& fullmac. Makefile, and some other files are also modified
accordingly
Signed-off-by: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arnd Bergmann [Sat, 9 Oct 2010 14:43:24 +0000 (16:43 +0200)]
staging: tidspbridge: add memory consistency to TODO list
This driver uses ioremap on regular memory to get an uncached mapping,
which causes problems on ARMv6 and higher due to aliasing with the
cached linar kernel mapping.
Make sure this gets fixed before the driver graduates from staging.
Cc: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Dan Carpenter [Sat, 9 Oct 2010 11:54:06 +0000 (13:54 +0200)]
Staging: brcm80211: make interface name buffer smaller
In the original code the interface name was IFNAMSIZ + 1, but that
caused problems in dhd_ifname2idx() which does:
strncmp(dhd->iflist[i]->name, name, IFNAMSIZ)
The wl_event_msg_t struct can only store 16 character names as well.
And thirdly there is a potential buffer overflow in dhd_op_if() because
if->net->name is IFNAMSIZ and we do:
strcpy(ifp->net->name, ifp->name);
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Sat, 9 Oct 2010 20:26:12 +0000 (13:26 -0700)]
Staging: phison: fix problem caused by libata change
The libata core changed this function so it needed to call a different
one.
See https://bugzilla.kernel.org/show_bug.cgi?id=19872 for details.
Reported-by: Heinz Wiesinger <HMWiesinger@gmx.at>
Tested-by: Heinz Wiesinger <HMWiesinger@gmx.at>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Brett Rudley [Fri, 8 Oct 2010 22:56:50 +0000 (15:56 -0700)]
staging: brcm80211: Purge unused wlc_id_name
Purge unused wlc_id_name_entry
Signed-off-by: Brett Rudley <brudley@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Brett Rudley [Sat, 9 Oct 2010 00:35:02 +0000 (17:35 -0700)]
staging: brcm80211: Purge unused packet engine
We're not using the packet engine anymore - goodbye.
Signed-off-by: Brett Rudley <brudley@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
nohee ko [Sat, 9 Oct 2010 01:44:29 +0000 (18:44 -0700)]
staging: brcm80211: bug fix- dual band problem
Bug fix for dual band problem. In particular it had an issue
to connect to 5G band AP.
Signed-off-by: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Tracey Dent [Fri, 8 Oct 2010 21:46:37 +0000 (17:46 -0400)]
Staging: speakup: serialio: Fixed errors in file
On line 40 printk() needed an KERN_* facility level, so I gave it
INFO. Also, fixed a C99 comment error.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Brett Rudley [Fri, 8 Oct 2010 20:57:13 +0000 (13:57 -0700)]
staging: brcm80211: Coalesce osl_dma_alloc_consistent between fullmac and softmac
Combine dma_alloc routine for full and softmac
Signed-off-by: Brett Rudley <brudley@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Brett Rudley [Fri, 8 Oct 2010 20:55:20 +0000 (13:55 -0700)]
staging: brcm80211: Purge unused memlist debugging
Purge unused memlist debugging
Signed-off-by: Brett Rudley <brudley@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 8 Oct 2010 21:28:21 +0000 (14:28 -0700)]
Staging: brcm80211: remove BCMATTACHFN macro
It's not doing anything and is a bit silly.
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 8 Oct 2010 21:11:20 +0000 (14:11 -0700)]
Staging: brcm80211: remove BCMATTACHDATA macro
It's not even used for anything, not to mention, it is pretty silly.
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 8 Oct 2010 19:37:39 +0000 (12:37 -0700)]
Staging: brcm80211: brcmfmac: fix some comparison warnings
Use min_t() instead of min() in some places to make the
comparison explicit and resolve some compiler warnings.
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 8 Oct 2010 19:28:02 +0000 (12:28 -0700)]
Staging: brcm80211: sys: fix some comparison warnings
Use min_t() instead of min() in some places to make the
comparison explicit and resolve some compiler warnings.
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 8 Oct 2010 19:25:23 +0000 (12:25 -0700)]
Staging: brcm80211: sys: wlc_ampdu: fix some comparison warnings
Use min_t() instead of min() in some places to make the comparison
explicit and resolve some compiler warnings.
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 8 Oct 2010 19:16:08 +0000 (12:16 -0700)]
Staging: brcm80211: phy: wlc_phy_n: fix some comparison warnings
Use min_t() instead of min() in some places to make the comparison
explicit and resolve some compiler warnings.
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.d
Greg Kroah-Hartman [Fri, 8 Oct 2010 19:07:33 +0000 (12:07 -0700)]
Staging: brcm80211: hnddma.c: fix compiler warning
Change the field types of dma_info_t to make comparing values easier
(and correct.) No need to keep rxbufsize as a u16, it can be an
unsigned int to make things easier.
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 8 Oct 2010 19:01:30 +0000 (12:01 -0700)]
Staging: brcm80211: remove VALID_MASK macro
No one is using it.
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 8 Oct 2010 18:59:06 +0000 (11:59 -0700)]
Staging: brcm80211: remove ROUNDUP macro
And use the kernel provided 'roundup' instead.
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 8 Oct 2010 18:55:40 +0000 (11:55 -0700)]
Staging: brcm80211: remove ISALIGNED macro
And use the kernel provided IS_ALIGNED one instead.
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 8 Oct 2010 18:52:16 +0000 (11:52 -0700)]
Staging: brcm80211: remove unused ALIGN_ADDR() macro
It's not used (and there's a kernel provided one if it's ever needed in
the future), so remove it.
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 8 Oct 2010 18:47:11 +0000 (11:47 -0700)]
Staging: brcm80211: remove ARRAYSIZE macro
Use the real 'ARRAY_SIZE' definition instead.
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 8 Oct 2010 18:44:45 +0000 (11:44 -0700)]
Staging: brcm80211: remove OFFSETOF macro
Use the real 'offsetof' definition instead.
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 8 Oct 2010 18:39:43 +0000 (11:39 -0700)]
Staging: brcm80211: remove broken MAX() implementation
Use the kernel-provided version, this one is broken.
Note, there are more compiler warnings now, that's due to different
types being compared, which shows how the original macro was wrong in at
least one way. They need to be fixed up.
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 8 Oct 2010 18:34:59 +0000 (11:34 -0700)]
Staging: brcm80211: remove broken MIN() implementation
Use the kernel-provided version, this one is broken.
Note, there are more compiler warnings now, that's due to different
types being compared, which shows how the original macro was wrong in at
least one way. They need to be fixed up.
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
projects / firefly-linux-kernel-4.4.55.git / log