firefly-linux-kernel-4.4.55.git
14 years agoStaging: rtl8192su: Remove Firmware from r8192SU_HWImg.c
Florian Schilhabel [Fri, 19 Feb 2010 19:10:00 +0000 (20:10 +0100)]
Staging: rtl8192su: Remove Firmware from r8192SU_HWImg.c

Because the Firmware is loaded from RTL8192SU/rtl8192sfw.bin,
it it save, to remove it from r8192SU_HWImg.c

Signed-off-by: Florian Schilhabel <florian.c.schilhabel@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: make drivers use spin_lock_init()
Sven-Thorsten Dietrich [Tue, 23 Feb 2010 21:59:18 +0000 (13:59 -0800)]
Staging: make drivers use spin_lock_init()

This fixes some RT-triggered compile errors and typos.

Signed-off-by: Sven-Thorsten Dietrich <sdietrich@novell.com>
Acked-by: Marek Lindner <lindner_marek@yahoo.de>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: crystalhd: Misc improvements for crystalhd_lnx.c
Ameya Palande [Wed, 24 Feb 2010 18:18:28 +0000 (20:18 +0200)]
Staging: crystalhd: Misc improvements for crystalhd_lnx.c

This patch does following improvements:

1. Follow kernel style for comments
2. Reorganize code for readability improvement
3. Use PCI helper macros
4. Use __devinit, __devexit, __devexit_p at necessary places
5. Mark functions and data as static when it is not exported

Signed-off-by: Ameya Palande <2ameya@gmail.com>
Cc: Naren Sankar <nsankar@broadcom.com>
Cc: Jarod Wilson <jarod@wilsonet.com>
Cc: Scott Davilla <davilla@4pi.com>
Cc: Manu Abraham <abraham.manu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: wlan-ng: Fixed line length issues in prism2usb.c
Jim Dog [Thu, 25 Feb 2010 11:38:21 +0000 (11:38 +0000)]
Staging: wlan-ng: Fixed line length issues in prism2usb.c

This is a patch to the prism2usb.c that fixes one line which was over
the 80 character limit by wrapping it to a new line and removes a
commented out configuration for a ZyDAS ZD1201 device since support for
this device with this driver is now deprecated.

Signed-off-by: Jim Dog <jimdog@northern-indymedia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging/pohmelfs: fix write_inode parameter warning
Randy Dunlap [Thu, 25 Feb 2010 22:41:22 +0000 (14:41 -0800)]
Staging/pohmelfs: fix write_inode parameter warning

sparse warns that:
drivers/staging/pohmelfs/inode.c:1797: warning: initialization from incompatible pointer type

so fix pohmelfs_write_inode() to have the expected parameters.

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Evgeniy Polyakov <zbr@ioremap.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: fix wlan-ng printk format warning
Randy Dunlap [Thu, 25 Feb 2010 17:55:03 +0000 (09:55 -0800)]
Staging: fix wlan-ng printk format warning

Fix prism2fw.c printk format warning:

drivers/staging/wlan-ng/prism2fw.c:209: warning: format '%d' expects type 'int', but argument 3 has type 'size_t'

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: rtl8192* needs semaphore.h
Randy Dunlap [Wed, 24 Feb 2010 19:39:20 +0000 (11:39 -0800)]
Staging: rtl8192* needs semaphore.h

The rtl8192* drivers in staging use semaphores, so they need
to #include <linux/semaphore.h>.

(similar to staging-rtl8187se-needs-semaphore.h.patch)

drivers/staging/rtl8192e/ieee80211/ieee80211.h:2038: error: field 'ips_sem' has incomplete type
drivers/staging/rtl8192e/ieee80211/ieee80211.h:2249: error: field 'wx_sem' has incomplete type
drivers/staging/rtl8192e/ieee80211/ieee80211.h:2250: error: field 'scan_sem' has incomplete type
drivers/staging/rtl8192e/ieee80211/ieee80211_softmac.c:442: error: implicit declaration of function 'down'
drivers/staging/rtl8192e/ieee80211/ieee80211_softmac.c:500: error: implicit declaration of function 'up'
drivers/staging/rtl8192e/ieee80 211/ieee80211_softmac.c:3165: error: implicit declaration of function 'sema_init'

drivers/staging/rtl8192su/ieee80211/ieee80211.h:1330: error: field 'wx_sem' has incomplete type
drivers/staging/rtl8192su/ieee80211/ieee80211.h:1331: error: field 'scan_sem' has incomplete type

drivers/staging/rtl8192u/ieee80211/ieee80211.h:2010: error: field 'wx_sem' has incomplete type
drivers/staging/rtl8192u/ieee80211/ieee80211.h:2011: error: field 'scan_sem' has incomplete type

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: line6: variax.c: fixed a space a "x ? a : b" coding style issue
Sylvain Trias [Tue, 23 Feb 2010 23:17:52 +0000 (00:17 +0100)]
Staging: line6: variax.c: fixed a space a "x ? a : b" coding style issue

Fixed a coding style issue.

Signed-off-by: Sylvain Trias <bozo@nobodix.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: Increased timeout for digital output dma loading
Frank Mori Hess [Mon, 22 Feb 2010 20:32:32 +0000 (15:32 -0500)]
Staging: comedi: Increased timeout for digital output dma loading

Increased timeout for digital output dma loading, due to report of it
being too short for some hardware.

Signed-off-by: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: serial2002: Fix filp_open usage
OGAWA Hirofumi [Mon, 22 Feb 2010 18:04:42 +0000 (03:04 +0900)]
Staging: comedi: serial2002: Fix filp_open usage

Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: amplc_pc236: Checkpatch cleanups
Benjamin Adolphi [Sun, 21 Feb 2010 20:51:00 +0000 (21:51 +0100)]
Staging: comedi: amplc_pc236: Checkpatch cleanups

This fixes all checkpatch issues in the amplc_pc236 comedi driver.

Signed-off-by: Benjamin Adolphi <b.adolphi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: amplc_dio200: Checkpatch cleanups
Benjamin Adolphi [Sun, 21 Feb 2010 20:44:57 +0000 (21:44 +0100)]
Staging: comedi: amplc_dio200: Checkpatch cleanups

This fixes all checkpatch issues in the amplc_dio200 comedi driver.

Signed-off-by: Benjamin Adolphi <b.adolphi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: aio_iiro_16: Checkpatch cleanups
Benjamin Adolphi [Sun, 21 Feb 2010 20:25:33 +0000 (21:25 +0100)]
Staging: comedi: aio_iiro_16: Checkpatch cleanups

This fixes all checkpatch issues in the aio_iiro_16 comedi driver.

Signed-off-by: Benjamin Adolphi <b.adolphi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: fix coding style issues in ni_labpc.c
Stewart Robertson [Sun, 21 Feb 2010 10:13:21 +0000 (10:13 +0000)]
Staging: comedi: fix coding style issues in ni_labpc.c

This is a patch to the ni_labpc.c file that fixes the brace warnings and
comments over 80 characters found by the checkpatch.pl tool. Some code
still goes over 80 characters because I didn't know what to do with it.

Signed-off-by: Stewart Robertson <stewart_r@aliencamel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: batman-adv: fix module initialization
Marek Lindner [Fri, 19 Feb 2010 15:18:11 +0000 (16:18 +0100)]
Staging: batman-adv: fix module initialization

Make sure that batman-adv does not process packets before its
initialization is complete. Some sanity checks added to the receiver
function.

Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: batman-adv: avoid crash on memory allocation error
Marek Lindner [Fri, 19 Feb 2010 15:18:10 +0000 (16:18 +0100)]
Staging: batman-adv: avoid crash on memory allocation error

skb_share_check() returns NULL if it can't allocate more memory but
it still frees the skbuff.

Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: batman-adv: Fix skbuff leak in VIS code.
Andrew Lunn [Fri, 19 Feb 2010 15:18:09 +0000 (16:18 +0100)]
Staging: batman-adv: Fix skbuff leak in VIS code.

The vis code takes a copy of the data inside the skbuf if it is interesting
for us, so we always need to release the skbuf.

Reported-by: Linus Luessing <linus.luessing@web.de>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: batman-adv: atomic variable for vis-srv activation
Linus Luessing [Fri, 19 Feb 2010 15:18:08 +0000 (16:18 +0100)]
Staging: batman-adv: atomic variable for vis-srv activation

This fixes the bug discovered by Marek Lindner which did not allow
turning on the vis-server before an interface has been added. With this
patch we are using a global atomic variable for activating and
deactiating the vis-server-mode, which can be used before
inserting an interface.

Signed-off-by: Linus Luessing <linus.luessing@web.de>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: batman-adv: remove obsolete variables
Marek Lindner [Fri, 19 Feb 2010 15:18:07 +0000 (16:18 +0100)]
Staging: batman-adv: remove obsolete variables

This patch removes a variable that became obsolete since the skb handling
replaced the packet handling thread.

Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: batman-adv: avoid having the same error message more than once
Marek Lindner [Fri, 19 Feb 2010 15:18:06 +0000 (16:18 +0100)]
Staging: batman-adv: avoid having the same error message more than once

The routing code has 2 sections which warn about ttl exceeded. The
corresponding warnings were identical which makes it hard to debug. In
addition, batman-adv does not need to warn about ttl exceeded in case
we encountered an echo request as this is commonly used to generate
traceroute graphs.

Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: batman-adv: don't lock while sending packets
Simon Wunderlich [Fri, 19 Feb 2010 15:18:05 +0000 (16:18 +0100)]
Staging: batman-adv: don't lock while sending packets

As in other parts of batman-adv, we should not lock while sending a packet but
keep the lock held for as short as possible. Additionally, we should check
whether the interface is active, otherwise batman_if->net_dev might not be
available ...

Signed-off-by: Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
Acked-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: batman-adv: depend on NET instead of PACKET in Kconfig
Sven Eckelmann [Fri, 19 Feb 2010 15:18:04 +0000 (16:18 +0100)]
Staging: batman-adv: depend on NET instead of PACKET in Kconfig

The code which uses the raw packet sockets was removed. The only related
dependencies are the skb and netdev handling code. This is provided by
NET in Kconfig.

Signed-off-by: Sven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: iio: Staticise non-exported functions
Mark Brown [Thu, 18 Feb 2010 17:19:17 +0000 (17:19 +0000)]
Staging: iio: Staticise non-exported functions

Staticise a number of functions which aren't exported outside their
source files, and also add a __user annotation for the buffer in
iio_event_chrdev_read().

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: fix brace and 80 character coding style issue in ni_daq_700.c
Graham M Howe [Mon, 15 Feb 2010 10:04:26 +0000 (10:04 +0000)]
Staging: comedi: fix brace and 80 character coding style issue in ni_daq_700.c

This is a patch to the ni_daq_700.c file that fixes up brace and 80 character warnings
found by the checkpatch.pl tool

Signed-off-by: Graham M Howe <gman.1352@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: vme: VMIVME-7805 board support
Arthur Benilov [Tue, 16 Feb 2010 14:41:51 +0000 (15:41 +0100)]
Staging: vme: VMIVME-7805 board support

VMIVME-7805 board has a special control register that has to be used in
order to activate the VME bus access via the Universe II bridge.
This control register also handles endianess convertion.

Signed-off-by: Arthur Benilov <arthur.benilov@iba-group.com>
Signed-off-by: Vincent Bossier <vincent.bossier@iba-group.com>
Acked-by: Martyn Welch <martyn.welch@ge.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: vme: Allocate memory buffers for master windows
Arthur Benilov [Tue, 16 Feb 2010 14:41:21 +0000 (15:41 +0100)]
Staging: vme: Allocate memory buffers for master windows

For VME device I/O operations on master windows the user driver tends
to use kern_buf buffer array which is not allocated. This causes an error
when reading from master window device files.

Signed-off-by: Arthur Benilov <arthur.benilov@iba-group.com>
Signed-off-by: Vincent Bossier <vincent.bossier@iba-group.com>
Acked-by: Martyn Welch <martyn.welch@ge.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: vme: Use A24 when requesting slave resource
Arthur Benilov [Tue, 16 Feb 2010 14:40:58 +0000 (15:40 +0100)]
Staging: vme: Use A24 when requesting slave resource

When requesting slave resources A16 addressing mode flag is used to find
available windows. Since the ca91cx42 bridge only supports two A16 slave windows
but four are requested, the driver fails to initialize. The flag has been
changed to A24, which is supported by all slave windows.

Signed-off-by: Arthur Benilov <arthur.benilov@iba-group.com>
Signed-off-by: Vincent Bossier <vincent.bossier@iba-group.com>
Acked-by: Martyn Welch <martyn.welch@ge.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: vme: llseek support in user driver
Arthur Benilov [Tue, 16 Feb 2010 14:40:30 +0000 (15:40 +0100)]
Staging: vme: llseek support in user driver

Provide vme_user_llseek() implementation.

Signed-off-by: Arthur Benilov <arthur.benilov@iba-group.com>
Signed-off-by: Vincent Bossier <vincent.bossier@iba-group.com>
Acked-by: Martyn Welch <martyn.welch@ge.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: vme: Remove legacy unsupported code
Martyn Welch [Thu, 18 Feb 2010 16:22:13 +0000 (16:22 +0000)]
Staging: vme: Remove legacy unsupported code

Remove the code from the drivers that we are not going to implement before
submitting for review.

Signed-off-by: Martyn Welch <martyn.welch@ge.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: vme: ca91cx42 slot detection
Martyn Welch [Thu, 18 Feb 2010 15:13:45 +0000 (15:13 +0000)]
Staging: vme: ca91cx42 slot detection

Sort out slot detection on the ca91cx42.

Signed-off-by: Martyn Welch <martyn.welch@ge.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: vme: Add ca91cx42 rmw support
Martyn Welch [Thu, 18 Feb 2010 15:13:38 +0000 (15:13 +0000)]
Staging: vme: Add ca91cx42 rmw support

Add support for Master Read-Modify-Write cycles on the ca91cx42.

Signed-off-by: Martyn Welch <martyn.welch@ge.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: vme: Correct ca91cx42 resource handling
Martyn Welch [Thu, 18 Feb 2010 15:13:32 +0000 (15:13 +0000)]
Staging: vme: Correct ca91cx42 resource handling

The ca91cx42 driver currently incorrectly handles master windows, setting
and retrieving the sizing parameters incorrectly. Also, in the slave window
handling, it uses an incorrectly set variable.

Signed-off-by: Martyn Welch <martyn.welch@ge.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: vme: add ca91cx42 dma support
Martyn Welch [Thu, 18 Feb 2010 15:13:25 +0000 (15:13 +0000)]
Staging: vme: add ca91cx42 dma support

Add support for the DMA controller in the ca91cx42 bridge.

Signed-off-by: Martyn Welch <martyn.welch@ge.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: vme: Add location monitor support for ca91cx42
Martyn Welch [Thu, 18 Feb 2010 15:13:19 +0000 (15:13 +0000)]
Staging: vme: Add location monitor support for ca91cx42

Signed-off-by: Martyn Welch <martyn.welch@ge.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: vme: Make vme_master_resource naming bus neutral
Martyn Welch [Thu, 18 Feb 2010 15:13:12 +0000 (15:13 +0000)]
Staging: vme: Make vme_master_resource naming bus neutral

The vme_master_resource structure contains an item called "pci_resource".
Rename to make bus agnostic.

Signed-off-by: Martyn Welch <martyn.welch@ge.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: vme: Enable drivers to handle more than one bridge
Martyn Welch [Thu, 18 Feb 2010 15:13:05 +0000 (15:13 +0000)]
Staging: vme: Enable drivers to handle more than one bridge

At the moment the vme bridge drivers are written in a way that only
allows them to support one bridge at a time. Modify the drivers to
enable more than one bridge to be present per board.

Signed-off-by: Martyn Welch <martyn.welch@ge.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: vme: Attribute Testing For Dma Request
Martyn Welch [Thu, 18 Feb 2010 15:12:58 +0000 (15:12 +0000)]
Staging: vme: Attribute Testing For Dma Request

Check the directions in which the DMA controller is expected to operate
before giving control of a resource.

Signed-off-by: Martyn Welch <martyn.welch@gefanuc.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: vme: Renaming following split of GE Fanuc joint venture
Martyn Welch [Thu, 18 Feb 2010 15:12:52 +0000 (15:12 +0000)]
Staging: vme: Renaming following split of GE Fanuc joint venture

This patch corrects author email addresses and Copyright notices as a
result of the split up of the GE Fanuc joint venture.

Signed-off-by: Martyn Welch <martyn.welch@gefanuc.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: rtl8187se: needs semaphore.h
Randy Dunlap [Tue, 16 Feb 2010 22:59:07 +0000 (14:59 -0800)]
Staging: rtl8187se: needs semaphore.h

rtl8187se needs to include semaphore.h to prevent build errors:

drivers/staging/rtl8187se/ieee80211/ieee80211.h:1004: error: field 'wx_sem' has incomplete type
drivers/staging/rtl8187se/ieee80211/ieee80211.h:1005: error: field 'scan_sem' has incomplete type

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: udlfb: remove printk and small cleanup
Bernie Thompson [Mon, 15 Feb 2010 14:46:48 +0000 (06:46 -0800)]
Staging: udlfb: remove printk and small cleanup

Remove last remaining printk and clarify comments

Signed-off-by: Bernie Thompson <bernie@plugable.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: udlfb: explicit dependencies and warnings
Bernie Thompson [Mon, 15 Feb 2010 14:46:35 +0000 (06:46 -0800)]
Staging: udlfb: explicit dependencies and warnings

Specify Kconfig dependencies, and include warnings for building as a module

udlfb is dependent on FB_DEFERRED_IO, FB_SYS_*, and FB_MODE_HELPERS

Because many kernels do not include defio (which cannot be built
as a module), yet users want to be able to build udlfb as a module later,
udlfb has ifdefs and these dependency warnings to help udlfb build with or
without certain dependencies, but also print warnings for any lost function.

Even though this kind of flexibility isn't common, we've gotten feedback
from a significant portion of users that they were frustrated without it.

Signed-off-by: Bernie Thompson <bernie@plugable.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: udlfb: Support for fbdev mmap clients (defio)
Bernie Thompson [Mon, 15 Feb 2010 14:46:26 +0000 (06:46 -0800)]
Staging: udlfb: Support for fbdev mmap clients (defio)

Add support for fbdev mmap clients who don't send damage ioctls

Because DisplayLink devices are out on the other end of usb, their
"framebuffer" is just normal system memory. So memory mapped writes
don't automatically trigger anything. So up to this point, standard
fbdev clients who rely on mmap() will get an unchanging screen.

This patch makes udlfb a client of Jaya Kumar's defio framework - which sets
up page fault triggers, and those faults are accumulated and sent to udlfb
on a defferred basis, to process as damage notifications for the framebuffer.

Because this involves more overhead than a notification directly from
the application (e.g. just passing on X DAMAGE extension notifications),
a sysfs attribute is provided by udlfb to control defio support.

/sys/class/graphics/fb*/use_defio - writing a "0" to this file before
calling mmap() causes defio to not be initialized - instead udlfb
will rely on getting damage notifications directly through the damage ioctl.

There are unsolved rendering problems with defio (horizontal dead regions
on framebuffer, that accumulate over time) which still needs a fix.

Signed-off-by: Bernie Thompson <bernie@plugable.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: udlfb: improved rendering performance
Bernie Thompson [Mon, 15 Feb 2010 14:46:21 +0000 (06:46 -0800)]
Staging: udlfb: improved rendering performance

Rework rendering for improved performance

Approx 10-20% gain avg across several "benchmarks": x11perf, gtkperf, glxgears
Moves from a single pre-alloc'd urb protected by a long-held mutex
To a list of (4) pre-alloc'd urbs which can be dispatched asynchonously

Improved rendering algorithm to hardware with lower CPU consumption,
fewer system memory accesses, and slightly higher compression.

Better scalability to multiple processors, especially with
multiple framebuffers active.

Signed-off-by: Bernie Thompson <bernie@plugable.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: udlfb: Rework startup and teardown to fix race conditions
Bernie Thompson [Mon, 15 Feb 2010 14:46:13 +0000 (06:46 -0800)]
Staging: udlfb: Rework startup and teardown to fix race conditions

Rework probe to use refcounts and std functions

Because the different parts of the driver (usb, fbdev) tear down
in different orders, the driver previously could crash accessing
data that had already been freed.  Refcounting system used to handle.

Reworked probe to make use of refcounts, set mode using std fbops,
and set up sysfs and pre-allocated urbs.

Signed-off-by: Bernie Thompson <bernie@plugable.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: udlfb: Add functions to expose sysfs metrics and controls
Bernie Thompson [Mon, 15 Feb 2010 14:46:08 +0000 (06:46 -0800)]
Staging: udlfb: Add functions to expose sysfs metrics and controls

Add sysfs controls for edid and performance metrics

There are 8 new files exposed in /sys/class/graphics/fb*

edid - returns 128 byte edid blog, suitable for parsing with parse-edid
metrics_bytes_identical
metrics_bytes_rendered
metrics_bytes_sent
metrics_cpu_kcycles_used
metrics_misc
and metrics_reset, which resets all perf metrics to zero

The 6 perf metrics are of type atomic_t.
So these metrics return precise results for short benchmarks, but
any test approx a minute or longer runtime may roll over.

Signed-off-by: Bernie Thompson <bernie@plugable.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: udlfb: clean up function naming
Bernie Thompson [Mon, 15 Feb 2010 14:46:04 +0000 (06:46 -0800)]
Staging: udlfb: clean up function naming

Move to more consistent naming scheme

All udlfb functions start with udlfb_
All functions for udlfb's fbdev interface start with udlfb_ops_
All functinos for udlfb's usb interface start with udlfb_usb_

Signed-off-by: Bernie Thompson <bernie@plugable.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: udlfb: pre-allocated urb list helpers
Bernie Thompson [Mon, 15 Feb 2010 14:45:55 +0000 (06:45 -0800)]
Staging: udlfb: pre-allocated urb list helpers

Add functions to pre-allocate and free usb bulk urbs for core render path.

Udlfb currently allocates a single urb, guarded by a mutex, that is a key
bottleneck. Because udlfb sends so much data, preallocation is most efficient.

Functions will be used by new rendering functions in later patches.

Signed-off-by: Bernie Thompson <bernie@plugable.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: udlfb: reorganize function order
Bernie Thompson [Mon, 15 Feb 2010 14:45:49 +0000 (06:45 -0800)]
Staging: udlfb: reorganize function order

Reorganize the location of a few things to be closer to related code

Signed-off-by: Bernie Thompson <bernie@plugable.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: udlfb: checkpatch cleanup
Bernie Thompson [Mon, 15 Feb 2010 14:45:43 +0000 (06:45 -0800)]
Staging: udlfb: checkpatch cleanup

Eliminate checkpatch.pl warnings and errors so later patches in series are clean

Signed-off-by: Bernie Thompson <bernie@plugable.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: r8187se: Remove dead code from r8185b_init.c
Larry Finger [Mon, 15 Feb 2010 04:07:57 +0000 (22:07 -0600)]
Staging: r8187se: Remove dead code from r8185b_init.c

Remove dead code from r8185b_init.c.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: r8187se: Remove two private variables that have a fixed value
Larry Finger [Mon, 15 Feb 2010 04:04:56 +0000 (22:04 -0600)]
Staging: r8187se: Remove two private variables that have a fixed value

For the RTL8187SE, the variable priv->rf_chip is always RF_ZEBRA4
and priv->RegThreeWireMode is always HW_THREE_WIRE_SI. Remove these
2 variables.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: r8187se: Remove write_phy routine
Larry Finger [Mon, 15 Feb 2010 03:55:16 +0000 (21:55 -0600)]
staging: r8187se: Remove write_phy routine

Remove a routine that is not used.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: wlan-ng: multiple safe style cleanups
Svenne Krap [Sun, 14 Feb 2010 17:59:00 +0000 (18:59 +0100)]
Staging: wlan-ng: multiple safe style cleanups

Cleanups as suggested by checkpatch.pl utiltiy.
.o's from before and after cleanup have matching SHA1s.

Signed-off-by: Svenne Krap <svenne@krap.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: wlan-ng: clean up assignments in if statements
Svenne Krap [Sun, 14 Feb 2010 17:59:42 +0000 (18:59 +0100)]
Staging: wlan-ng: clean up assignments in if statements

Trivial changes to code-paths.

Signed-off-by: Svenne Krap <svenne@krap.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: bracing fix to ni_atmio.c
Graham M Howe [Sat, 13 Feb 2010 20:21:43 +0000 (20:21 +0000)]
Staging: comedi: bracing fix to ni_atmio.c

This is a patch to ni_atmio.c file to fix up bracing style problems
found by checkpatch.pl tool

Signed-off-by: Graham M Howe <gman.1352@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: vt6655: add missing curly braces
Dan Carpenter [Fri, 12 Feb 2010 11:48:01 +0000 (14:48 +0300)]
staging: vt6655: add missing curly braces

It's clear from the indent levels and the context that there are supposed to
be curly braces here.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: r8187se: Fix for LED not following radio switch
Larry Finger [Thu, 11 Feb 2010 20:41:24 +0000 (14:41 -0600)]
Staging: r8187se: Fix for LED not following radio switch

The current driver does not follow the state of the RF switch.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: r8187se: Change to use common eeprom routines in EEPROM_93CX
Larry Finger [Thu, 11 Feb 2010 18:07:35 +0000 (12:07 -0600)]
staging: r8187se: Change to use common eeprom routines in EEPROM_93CX

The TODO list includes switching this driver to use the common EEPROM
routines in EEPROM_93CX.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Tested by: Bernhard Schiffner <bernhard@schiffner-limbach.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: dream: more Code style fixes
Jochen Maes [Thu, 11 Feb 2010 16:10:42 +0000 (17:10 +0100)]
staging: dream: more Code style fixes

Removed parenthesis from return statements,
split up assignment and if condition

Signed-off-by: Jochen Maes <jochen.maes@sejo.be>
Cc: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: dream: another Codestyle patch
Jochen Maes [Wed, 10 Feb 2010 09:27:14 +0000 (10:27 +0100)]
staging: dream: another Codestyle patch

Fixed code style issues.

Signed-off-by: Jochen Maes <jochen.maes@sejo.be>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: dream: Codestyle fix
Jochen Maes [Tue, 9 Feb 2010 23:19:46 +0000 (00:19 +0100)]
staging: dream: Codestyle fix

Fixed Codestyle issues

Signed-off-by: Jochen Maes <jochen.maes@sejo.be>
Cc: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: rti800: more Checkpatch cleanups
Benjamin Adolphi [Sat, 6 Feb 2010 14:12:32 +0000 (15:12 +0100)]
Staging: comedi: rti800: more Checkpatch cleanups

This fixes all checkpatch issues in the rti800 comedi driver.

Signed-off-by: Benjamin Adolphi <b.adolphi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: rar_register: add suspend and resume functions
Mark Allyn [Fri, 5 Feb 2010 18:53:34 +0000 (10:53 -0800)]
Staging: rar_register: add suspend and resume functions

Add suspend and resume functions (which are currently stubs
returning -ENOSYS)

Signed-off-by: Mark Allyn <mark.a.allyn@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: rar_register: fix checkpatch errors and debug program file
Mark Allyn [Fri, 5 Feb 2010 18:53:18 +0000 (10:53 -0800)]
Staging: rar_register: fix checkpatch errors and debug program file

Signed-off-by: Mark Allyn <mark.a.allyn@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: rar_register: fix checkpatch errors and debug header file
Mark Allyn [Fri, 5 Feb 2010 18:53:00 +0000 (10:53 -0800)]
Staging: rar_register: fix checkpatch errors and debug header file

Signed-off-by: Mark Allyn <mark.a.allyn@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: rar_register: provide better explanation in Kconfig
Mark Allyn [Fri, 5 Feb 2010 18:52:46 +0000 (10:52 -0800)]
Staging: rar_register: provide better explanation in Kconfig

Provides a better explanation of what this
driver is for in the Kconfig file

Signed-off-by: Mark Allyn <mark.a.allyn@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: rar_register: renaming directory to rar_register
Mark Allyn [Fri, 5 Feb 2010 18:52:26 +0000 (10:52 -0800)]
Staging: rar_register: renaming directory to rar_register

Renames the directory in which the driver files
are located; again for clarity.

Signed-off-by: Mark Allyn <mark.a.allyn@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: rar_register: renaming driver to rar_register
Mark Allyn [Fri, 5 Feb 2010 18:52:09 +0000 (10:52 -0800)]
staging: rar_register: renaming driver to rar_register

Patch renames rar_driver to rar_register to clarifiy and differentiate
from rar_handler that will be submitted later

Signed-off-by: Mark Allyn <mark.a.allyn@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: mimio: remove the mimio driver
Greg Kroah-Hartman [Fri, 12 Feb 2010 01:15:14 +0000 (17:15 -0800)]
Staging: mimio: remove the mimio driver

It turns out that Mimio has a userspace solution for this product using
libusb, and the in-kernel driver is just getting in the way now and
causing problems.  So they have asked that the in-kernel driver be
removed.  As the staging driver wasn't quite working anyway, and Mimio
supports their libusb solution for all distros, I am removing the
in-kernel driver.

The libusb solution can be downloaded from:
http://www.mimio.com/downloads/mimio_studio_software/linux.asp

Cc: <mwilder@cs.nmsu.edu>
Cc: Phil Hannent <phil@hannent.co.uk>
Cc: Marc Rousseau <Marc.Rousseau@mimio.com>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: dt3155: fix coding style issues in dt3155_io.c
Greg Kroah-Hartman [Tue, 9 Feb 2010 20:41:38 +0000 (12:41 -0800)]
Staging: dt3155: fix coding style issues in dt3155_io.c

This fixes up the sparse and coding style issues found in the
dt3155_io.c file.

No code is changed, only formatting and removing unused code.

Cc: Scott Smedley <ss@aao.gov.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: dt3155: replace u_int and u_long usage
Greg Kroah-Hartman [Tue, 9 Feb 2010 20:41:38 +0000 (12:41 -0800)]
Staging: dt3155: replace u_int and u_long usage

Use u32 and u64 instead, that's the proper thing to do.

Cc: Scott Smedley <ss@aao.gov.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: dt3155: replace u_char usage
Greg Kroah-Hartman [Tue, 9 Feb 2010 20:41:38 +0000 (12:41 -0800)]
Staging: dt3155: replace u_char usage

Use u8 instead, that's the proper thing to do.

Cc: Scott Smedley <ss@aao.gov.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: dt3155: coding cleanups for dt3155_io.h
Greg Kroah-Hartman [Tue, 9 Feb 2010 20:38:13 +0000 (12:38 -0800)]
Staging: dt3155: coding cleanups for dt3155_io.h

This fixes up some coding style issues in the dt3155_io.h file

Cc: Scott Smedley <ss@aao.gov.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: dt3155: fix build warnings
Greg Kroah-Hartman [Tue, 9 Feb 2010 20:37:25 +0000 (12:37 -0800)]
Staging: dt3155: fix build warnings

This fixes the build warnings in the dt3155 driver

Cc: Scott Smedley <ss@aao.gov.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: ssc_dnp: fixed a brace coding style issue
Greg Kroah-Hartman [Sun, 7 Feb 2010 16:51:51 +0000 (08:51 -0800)]
Staging: comedi: ssc_dnp: fixed a brace coding style issue

Fixed a coding style issue.

Created during the keynote presentation at FOSDEM 2010

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: ni_pcidio: Checkpatch cleanups
Benjamin Adolphi [Sat, 6 Feb 2010 15:17:06 +0000 (16:17 +0100)]
Staging: comedi: ni_pcidio: Checkpatch cleanups

This fixes almost all checkpatch issues in the ni_pcidio comedi driver.

Signed-off-by: Benjamin Adolphi <b.adolphi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: rti802: Checkpatch cleanups
Benjamin Adolphi [Sat, 6 Feb 2010 14:08:46 +0000 (15:08 +0100)]
Staging: comedi: rti802: Checkpatch cleanups

This fixes all checkpatch issues in the rti802 comedi driver.

Signed-off-by: Benjamin Adolphi <b.adolphi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: dt2815: Checkpatch cleanups
Benjamin Adolphi [Sat, 6 Feb 2010 14:02:50 +0000 (15:02 +0100)]
Staging: comedi: dt2815: Checkpatch cleanups

This fixes all checkpatch issues in the dt2815 comedi driver.

Signed-off-by: Benjamin Adolphi <b.adolphi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: samsung-laptop: fix coding style issues
Chihau Chau [Fri, 5 Feb 2010 18:23:48 +0000 (15:23 -0300)]
Staging: samsung-laptop: fix coding style issues

This fixes some lines over 80 characters coding style issues.

Signed-off-by: Chihau Chau <chihau@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: rt2860: correct onstack wait_queue_head declaration
Yong Zhang [Fri, 5 Feb 2010 13:52:40 +0000 (21:52 +0800)]
Staging: rt2860: correct onstack wait_queue_head declaration

Use DECLARE_WAIT_QUEUE_HEAD_ONSTACK to make lockdep happy

Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Alexander Beregalov <a.beregalov@gmail.com>
Cc: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: rtl8192e: fix spacing style issues in r8180_93cx6.c
Tim Schofield [Thu, 4 Feb 2010 19:57:09 +0000 (19:57 +0000)]
Staging: rtl8192e: fix spacing style issues in r8180_93cx6.c

This is a patch to the r8180_93cx6.c file that fixes up spacing issue
warnings found by the checkpatch.pl tool

Signed-off-by: Tim Schofield <tim@weberpafrica.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: fix brace coding style in comedi_fops.c
Paul Elms [Thu, 4 Feb 2010 08:24:28 +0000 (08:24 +0000)]
Staging: comedi: fix brace coding style in comedi_fops.c

This patch to the comedi_fops.c file fixes a brace warning found by the checkpatch.pl tool

Signed-off-by: Paul Elms <paul@uprocera.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: fix brace coding style issues in ni_labpc.c
tony burrows [Tue, 2 Feb 2010 16:52:49 +0000 (16:52 +0000)]
Staging: comedi: fix brace coding style issues in ni_labpc.c

This patch fixes all of the brace style warnings found by the
checkpatch.pl tool

Signed-off-by: Tony Burrows <tony@tonyburrows.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: Fix continuation line formats
Joe Perches [Tue, 2 Feb 2010 07:22:14 +0000 (23:22 -0800)]
Staging: Fix continuation line formats

String constants that are continued on subsequent lines with \
are not good.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: wlan-ng: minor cleanups
Richard Kennedy [Thu, 4 Feb 2010 11:33:49 +0000 (11:33 +0000)]
Staging: wlan-ng: minor cleanups

Remove iw_handle_def private initialisations as they are no longer need
these.

Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: Fix continuation line formats
Joe Perches [Sun, 31 Jan 2010 20:02:08 +0000 (12:02 -0800)]
Staging: Fix continuation line formats

String constants that are continued on subsequent lines with \
are not good.
Fixed a "is tryied" / tried typo

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: adq12b: Checkpatch cleanups 2
Benjamin Adolphi [Sun, 31 Jan 2010 23:04:14 +0000 (00:04 +0100)]
Staging: comedi: adq12b: Checkpatch cleanups 2

This fixes all checkpatch issues in the adq12b comedi driver.

Signed-off-by: Benjamin Adolphi <b.adolphi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: fl512: Checkpatch cleanups
Benjamin Adolphi [Sun, 31 Jan 2010 22:29:28 +0000 (23:29 +0100)]
Staging: comedi: fl512: Checkpatch cleanups

This fixes all checkpatch issues in the fl512 comedi driver.

Signed-off-by: Benjamin Adolphi <b.adolphi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: ni_65xx: Checkpatch cleanups
Benjamin Adolphi [Sat, 30 Jan 2010 12:03:20 +0000 (13:03 +0100)]
Staging: comedi: ni_65xx: Checkpatch cleanups

This fixes all checkpatch issues in the ni_65xx comedi driver.

Signed-off-by: Benjamin Adolphi <b.adolphi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: ni_670x: Checkpatch cleanups
Benjamin Adolphi [Sat, 30 Jan 2010 11:40:29 +0000 (12:40 +0100)]
Staging: comedi: ni_670x: Checkpatch cleanups

This fixes all checkpatch issues in the ni_670x comedi driver.

Signed-off-by: Benjamin Adolphi <b.adolphi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: ni_660x: Checkpatch cleanups
Benjamin Adolphi [Thu, 28 Jan 2010 23:42:30 +0000 (00:42 +0100)]
Staging: comedi: ni_660x: Checkpatch cleanups

This fixes all checkpatch issues in the ni_660x comedi driver.

Signed-off-by: Benjamin Adolphi <b.adolphi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: poc: Checkpatch cleanups
Benjamin Adolphi [Thu, 28 Jan 2010 23:28:46 +0000 (00:28 +0100)]
Staging: comedi: poc: Checkpatch cleanups

This fixes all checkpatch issues in the poc comedi driver.

Signed-off-by: Benjamin Adolphi <b.adolphi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: pcm3730: Checkpatch cleanups
Benjamin Adolphi [Thu, 28 Jan 2010 23:17:06 +0000 (00:17 +0100)]
Staging: comedi: pcm3730: Checkpatch cleanups

This fixes all checkpatch issues in the pcm3730 comedi driver.

Signed-off-by: Benjamin Adolphi <b.adolphi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: pcm3724: Checkpatch cleanups
Benjamin Adolphi [Thu, 28 Jan 2010 23:16:19 +0000 (00:16 +0100)]
Staging: comedi: pcm3724: Checkpatch cleanups

This fixes all checkpatch issues in the pcm3724 comedi driver.

Signed-off-by: Benjamin Adolphi <b.adolphi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: ramzswap: Update copyright notice
Nitin Gupta [Thu, 28 Jan 2010 15:51:35 +0000 (21:21 +0530)]
Staging: ramzswap: Update copyright notice

Update copyright notice.

Signed-off-by: Nitin Gupta <ngupta@vflare.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: ramzswap: Handle case for invalid backing swap
Nitin Gupta [Thu, 28 Jan 2010 15:49:59 +0000 (21:19 +0530)]
Staging: ramzswap: Handle case for invalid backing swap

Currently, we crash (issue BUG_ON) if backing swap
disk size is zero. This can happen is user specified
an extended partition or simply a bad disk as backing
swap. A crash is really an unpleasant surprise to user
for such trivial problems.

Now, we check for this condition and simply fail device
initialization if this is the case.

Additional cleanups:
 * use static for all functions
 * remove extra newline between functions
 * memset backing_swap_name to NULL on device reset

Signed-off-by: Nitin Gupta <ngupta@vflare.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: ramzswap: Remove redundant check for zero page
Nitin Gupta [Thu, 28 Jan 2010 15:43:41 +0000 (21:13 +0530)]
Staging: ramzswap: Remove redundant check for zero page

ramzswap_free_page() already handles the case for zero filled
pages. So, remove redundant logic for the same in ramzswap_write().

Signed-off-by: Nitin Gupta <ngupta@vflare.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: ramzswap: Return proper error code on device create failure
Nitin Gupta [Thu, 28 Jan 2010 15:43:40 +0000 (21:13 +0530)]
Staging: ramzswap: Return proper error code on device create failure

Currently, we return 0 if create_device() fails and 1 otherwise.
Now, proper error code is returned from create_device() and the
same is propagated as module error code from ramzswap_init().

Also added some cleanups for ramzswap_init(), improving function
structure.

Signed-off-by: Nitin Gupta <ngupta@vflare.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: ramzswap: Set block size to PAGE_SIZE
Nitin Gupta [Thu, 28 Jan 2010 15:43:39 +0000 (21:13 +0530)]
Staging: ramzswap: Set block size to PAGE_SIZE

ramzswap block size needs to be set equal to PAGE_SIZE to
avoid receiving any unaligned block I/O requests (happens
due to readahead logic during swapon). These unaligned
accesses produce unnecessary I/O errors, scaring users.

Signed-off-by: Nitin Gupta <ngupta@vflare.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: ramzswap: Flush block device before reset
Nitin Gupta [Thu, 28 Jan 2010 15:43:38 +0000 (21:13 +0530)]
Staging: ramzswap: Flush block device before reset

Make sure we flush block device before freeing all metadata
during reset ioctl.

Signed-off-by: Nitin Gupta <ngupta@vflar.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>