Chandler Carruth [Thu, 5 Jul 2012 11:40:23 +0000 (11:40 +0000)]
Remove dead infrastructure for building DenseMaps with a SlotIndex as
the key -- they are now stored in an IntervalMap.
I noticed this while looking into PR12652.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159745
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Thu, 5 Jul 2012 11:06:22 +0000 (11:06 +0000)]
Finish fixing the MachineOperand hashing, providing a nice modern
hash_value overload for MachineOperands. This addresses a FIXME
sufficient for me to remove it, and cleans up the code nicely too.
The important changes to the hashing logic:
- TargetFlags are now included in all of the hashes. These were complete
missed.
- Register operands have their subregisters and whether they are a def
included in the hash.
- We now actually hash all of the operand types. Previously, many
operand types were simply *dropped on the floor*. For example:
- Floating point immediates
- Large integer immediates (>64-bit)
- External globals!
- Register masks
- Metadata operands
- It removes the offset from the block-address hash; I'm a bit
suspicious of this, but isIdenticalTo doesn't consider the offset for
black addresses.
Any patterns involving these entities could have triggered extreme
slowdowns in MachineCSE or PHIElimination. Let me know if there are PRs
you think might be closed now... I'm looking myself, but I may miss
them.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159743
91177308-0d34-0410-b5e6-
96231b3b80d8
Duncan Sands [Thu, 5 Jul 2012 10:14:33 +0000 (10:14 +0000)]
All cases are covered, no need for a default. This deals with the
corresponding clang warning.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159742
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Thu, 5 Jul 2012 10:03:57 +0000 (10:03 +0000)]
The hash function for MI expressions, used by MachineCSE, is really
broken. This patch fixes the superficial problems which lead to the
intractably slow compile times reported in PR13225.
The specific issue is that we were failing to include the *offset* of
a global variable in the hash code. Oops. This would in turn cause all
MIs which were only distinguishable due to operating on different
offsets of a global variable to produce identical hash functions. In
some of the test cases attached to the PR I saw hash table activity
where there were O(1000) probes-per-lookup *on average*. A very few
entries were responsible for most of these probes.
There is still quite a bit more to do here. The ad-hoc layering of data
in MachineOperands makes them *extremely* brittle to hash correctly.
We're missing quite a few other cases, the only ones I've fixed here are
the specific MO types which were allowed through the assert() in
getOffset().
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159741
91177308-0d34-0410-b5e6-
96231b3b80d8
Duncan Sands [Thu, 5 Jul 2012 09:32:46 +0000 (09:32 +0000)]
Use the right kind of booleans: we were emitting 0/1 booleans, instead of 0/-1
booleans. Patch by James Benton.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159739
91177308-0d34-0410-b5e6-
96231b3b80d8
Kostya Serebryany [Thu, 5 Jul 2012 09:07:31 +0000 (09:07 +0000)]
[tsan] fix compile-time falilure found while building Chromium with tsan (tsan issue #3). A unit test will follow separately.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159736
91177308-0d34-0410-b5e6-
96231b3b80d8
Nick Lewycky [Thu, 5 Jul 2012 06:19:21 +0000 (06:19 +0000)]
Remove ParentMap. You can just ask the domnode for its parent. No functionality
change.
Move the "Not profitable, avoid CSE!" debug message next to where we fail the
check for profitability and use a different message for avoiding CSE due to
being in different register classes.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159729
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Wed, 4 Jul 2012 23:53:27 +0000 (23:53 +0000)]
Make X86 call and return instructions non-variadic.
Function argument and return value registers aren't part of the
encoding, so they should be implicit operands.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159728
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Wed, 4 Jul 2012 23:53:23 +0000 (23:53 +0000)]
Allow trailing physreg RegisterSDNode operands on non-variadic instructions.
Also allow trailing register mask operands on non-variadic both
MachineSDNodes and MachineInstrs.
The extra physreg RegisterSDNode operands are added to the MI as
<imp-use> operands. This makes it possible to have non-variadic call
instructions.
Call and return instructions really are non-variadic, the argument
registers should only be used implicitly - they are not part of the
encoding.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159727
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Wed, 4 Jul 2012 23:53:19 +0000 (23:53 +0000)]
Print SlotIndexes when available for -print-machineinstrs.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159726
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Wed, 4 Jul 2012 19:52:05 +0000 (19:52 +0000)]
Allow multiple terminators to read virtual registers.
Find the kill as the last terminator to read SrcReg.
Patch by Philipp Brüschweiler!
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159722
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Wed, 4 Jul 2012 19:28:31 +0000 (19:28 +0000)]
Ensure CopyToReg nodes are always glued to the call instruction.
The CopyToReg nodes that set up the argument registers before a call
must be glued to the call instruction. Otherwise, the scheduler may emit
the physreg copies long before the call, causing long live ranges for
the fixed registers.
Besides disabling good register allocation, that can also expose
problems when EmitInstrWithCustomInserter() splits a basic block during
the live range of a physreg.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159721
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Wed, 4 Jul 2012 19:28:27 +0000 (19:28 +0000)]
Make sure -print-machineinstrs applies to the first pass as well.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159720
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Wed, 4 Jul 2012 16:06:00 +0000 (16:06 +0000)]
Add a testcase for pr13209. It is not a great test, but it still fails if
159509 and 159479 are reverted. It would be really nice to be able to run
just the coalescer :-(
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159715
91177308-0d34-0410-b5e6-
96231b3b80d8
Alexey Samsonov [Wed, 4 Jul 2012 09:42:54 +0000 (09:42 +0000)]
Fix a bug in DebugInfo lib, extend a comment for one of the methods
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159707
91177308-0d34-0410-b5e6-
96231b3b80d8
Stepan Dyatkovskiy [Wed, 4 Jul 2012 06:07:06 +0000 (06:07 +0000)]
Reverted r159658:
Optimized diff operation: implemented the case when LHS and RHS subsets contains single numbers only.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159704
91177308-0d34-0410-b5e6-
96231b3b80d8
Stepan Dyatkovskiy [Wed, 4 Jul 2012 05:53:05 +0000 (05:53 +0000)]
Reverted r156659, due to probable performance regressions, DenseMap should be used here:
IntegersSubsetMapping
- Replaced type of Items field from std::list with std::map. In neares future I'll test it with DenseMap and do the correspond replacement
if possible.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159703
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Wed, 4 Jul 2012 02:02:18 +0000 (02:02 +0000)]
Reduce some code duplication.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159701
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Beaumont-Gay [Wed, 4 Jul 2012 01:09:45 +0000 (01:09 +0000)]
Fix some ascii art in a comment to not have trailing backslashes (inspiration
from IfConversion.cc), and fix some spelling and grammar in the surrounding
prose.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159699
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Wed, 4 Jul 2012 00:09:58 +0000 (00:09 +0000)]
Add early if-conversion support to X86.
Implement the TII hooks needed by EarlyIfConversion to create cmov
instructions and estimate their latency.
Early if-conversion is still not enabled by default.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159695
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Wed, 4 Jul 2012 00:09:54 +0000 (00:09 +0000)]
Add an experimental early if-conversion pass, off by default.
This pass performs if-conversion on SSA form machine code by
speculatively executing both sides of the branch and using a cmov
instruction to select the result. This can help lower the number of
branch mispredictions on architectures like x86 that don't have
predicable instructions.
The current implementation is very aggressive, and causes regressions on
mosts tests. It needs good heuristics that have yet to be implemented.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159694
91177308-0d34-0410-b5e6-
96231b3b80d8
Nuno Lopes [Tue, 3 Jul 2012 21:15:40 +0000 (21:15 +0000)]
PHINode::hasConstantValue(): return undef if the PHI is fully recursive.
Thanks Duncan for the idea
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159687
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Tue, 3 Jul 2012 20:01:02 +0000 (20:01 +0000)]
Use the DebugInfo's 'print()' method to emit the comments.
These give quite a bit more information about the DebugInfo and makes it more
readable.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159680
91177308-0d34-0410-b5e6-
96231b3b80d8
Nuno Lopes [Tue, 3 Jul 2012 17:30:18 +0000 (17:30 +0000)]
BoundsChecking: optimize out the check for offset < 0 if size is known to be >= 0 (signed).
(LLVM optimizers cannot do this optimization by themselves)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159668
91177308-0d34-0410-b5e6-
96231b3b80d8
Nuno Lopes [Tue, 3 Jul 2012 17:13:25 +0000 (17:13 +0000)]
fold PHI nodes in SizeOffsetEvaluator whenever possible.
Unfortunately this change requires the cache map to hold WeakVHs instead
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159667
91177308-0d34-0410-b5e6-
96231b3b80d8
Nuno Lopes [Tue, 3 Jul 2012 17:10:28 +0000 (17:10 +0000)]
improve PHINode::hasConstantValue() to detect recursive cases like %phi = phi(%phi,42) as constant
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159666
91177308-0d34-0410-b5e6-
96231b3b80d8
Stepan Dyatkovskiy [Tue, 3 Jul 2012 14:29:26 +0000 (14:29 +0000)]
IntegersSubsetMappin: cosmetic changes in diff operation.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159661
91177308-0d34-0410-b5e6-
96231b3b80d8
Stepan Dyatkovskiy [Tue, 3 Jul 2012 14:15:36 +0000 (14:15 +0000)]
Part of r159527. Splitted into series of patches and gone with fixed PR13256:
IntegersSubsetMapping
Added new methods
- add(self& RHS, SuccessorClass *S)
- detachCase
- removeCase
- findSuccessor
- getCases
- getCaseSingleNumber
- isOverlapped
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159660
91177308-0d34-0410-b5e6-
96231b3b80d8
Stepan Dyatkovskiy [Tue, 3 Jul 2012 13:46:45 +0000 (13:46 +0000)]
Part of r159527. Splitted into series of patches and gone with fixed PR13256:
IntegersSubsetMapping
- Replaced type of Items field from std::list with std::map. In neares future I'll test it with DenseMap and do the correspond replacement
if possible.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159659
91177308-0d34-0410-b5e6-
96231b3b80d8
Stepan Dyatkovskiy [Tue, 3 Jul 2012 13:29:14 +0000 (13:29 +0000)]
Part of r159527. Splitted into series of patches and gone with fixed PR13256:
Optimized diff operation: implemented the case when LHS and RHS subsets contains single numbers only.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159658
91177308-0d34-0410-b5e6-
96231b3b80d8
Peter Collingbourne [Tue, 3 Jul 2012 12:25:40 +0000 (12:25 +0000)]
Document the llvm.fabs intrinsic.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159657
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Tue, 3 Jul 2012 07:16:13 +0000 (07:16 +0000)]
Micro-optimize this function a bit. This shrinks the generated code
some, and allows the routine to be inlined into common callers. The
various bits that hit this code in their hotpath seem slightly lower on
the profile, but I can't really measure a performance improvement as
everything seems to still be bottlenecked on likely cache misses. =/
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159648
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Tue, 3 Jul 2012 06:48:58 +0000 (06:48 +0000)]
Remove extra space.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159647
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Tue, 3 Jul 2012 06:11:06 +0000 (06:11 +0000)]
Change i128mem/i256mem to f128mem/f256mem on some floating point vector instructions.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159646
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Tue, 3 Jul 2012 06:01:27 +0000 (06:01 +0000)]
MCContext.cpp: Fixup for my odd previous commit. No functional changes.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159645
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Tue, 3 Jul 2012 05:49:45 +0000 (05:49 +0000)]
Add aliases for pblendvb, blendvpd, and blendvps instructions with the implicit xmm0 operand specified. Fixes PR13252.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159644
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Tue, 3 Jul 2012 04:29:20 +0000 (04:29 +0000)]
test/CodeGen/SPARC/private.ll: Fixup. Forgot to prune old RUN lines.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159643
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Tue, 3 Jul 2012 04:21:57 +0000 (04:21 +0000)]
test/CodeGen/SPARC/private.ll: FileCheck-ize.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159642
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Tue, 3 Jul 2012 03:59:34 +0000 (03:59 +0000)]
llvm/test/lit.cfg: Retweak for Win32 to fix testing.
- execute_external should be;
- Not on Win32.
- Using bash.
In reverse, "execute_internal" shoud be (Win32 && !bash).
- lit.getBashPath() behaves differently before and after tweaking $PATH.
I will add a few explanations there later.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159641
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Tue, 3 Jul 2012 03:59:29 +0000 (03:59 +0000)]
MCContext::GetDwarfFile(): Make FileName parsing tolerant of DOSish pathsep with PathV2.
It fixes failure in test/MC/MachO/gen-dwarf.s on Win32 w/o bash.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159640
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Tue, 3 Jul 2012 03:59:22 +0000 (03:59 +0000)]
test/CodeGen/X86/sincos.ll: FileCheck-ize.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159639
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Tue, 3 Jul 2012 03:59:15 +0000 (03:59 +0000)]
test/CodeGen/X86/fabs.ll: FileCheck-ize.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159638
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Tue, 3 Jul 2012 03:59:08 +0000 (03:59 +0000)]
test/CodeGen/X86/2007-09-05-InvalidAsm.ll: FileCheck-ize.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159637
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Tue, 3 Jul 2012 03:58:59 +0000 (03:58 +0000)]
test/CodeGen/X86/2004-03-30-Select-Max.ll: FileCheck-ize.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159636
91177308-0d34-0410-b5e6-
96231b3b80d8
Jack Carter [Mon, 2 Jul 2012 23:35:23 +0000 (23:35 +0000)]
mips32 long long register inline asm constraint support.
inlineasm-cnstrnt-bad-r-1.ll is NOT supposed to fail, so it was removed. This resulted in the removal of a negative test (inlineasm-cnstrnt-bad-r-1.ll)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159625
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Mon, 2 Jul 2012 23:22:25 +0000 (23:22 +0000)]
Revert " mips32 long long register inline asm constraint support." as
it appears to be breaking the bots.
This reverts commit
1b055ce320fa13f6f1ac81670d11b45e01f79876.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159619
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Mon, 2 Jul 2012 23:22:21 +0000 (23:22 +0000)]
Revert "IntRange:" as it appears to be breaking self hosting.
This reverts commit
b2833d9dcba88c6f0520cad760619200adc0442c.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159618
91177308-0d34-0410-b5e6-
96231b3b80d8
Jack Carter [Mon, 2 Jul 2012 23:21:22 +0000 (23:21 +0000)]
deleted test/CodeGen/Mips/inlineasm-cnstrnt-bad-r-1.ll
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159617
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 2 Jul 2012 22:56:41 +0000 (22:56 +0000)]
All glory to address sanitizer. ;]
It appears to have caught a use-after-free introduced as by r159567
and/or friends which call 'addPass' from many more places. The bug in
'addPass' doesn't appear to be new, and was spotted by inspection when
ASan shown a bright light of a stacktrace at these functions.
Hopefully this will fix the ASan failure -- I have no test case other
than running an ASan-built clang over the test suite.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159614
91177308-0d34-0410-b5e6-
96231b3b80d8
Evan Cheng [Mon, 2 Jul 2012 22:39:56 +0000 (22:39 +0000)]
Target option DisableJumpTables is a gross hack. Move it to TargetLowering instead.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159611
91177308-0d34-0410-b5e6-
96231b3b80d8
Jack Carter [Mon, 2 Jul 2012 22:39:45 +0000 (22:39 +0000)]
mips32 long long register inline asm constraint support.
inlineasm-cnstrnt-bad-r-1.ll is NOT supposed to fail, so it was removed. This resulted in the removal of a negative test (inlineasm-cnstrnt-bad-r-1.ll)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159610
91177308-0d34-0410-b5e6-
96231b3b80d8
Andrew Trick [Mon, 2 Jul 2012 21:55:12 +0000 (21:55 +0000)]
misched: allow NULL InstrItineraries.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159599
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 2 Jul 2012 21:45:22 +0000 (21:45 +0000)]
Extend the workaround from r159593 to cover a few explicit alias
targets.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159597
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 2 Jul 2012 21:31:03 +0000 (21:31 +0000)]
Revert r159588, and apply a more principled fix. Place the fix for this
in the abstraction for lit test suites so that the various other layers
of abstraction pick up the same behavioral fix, and so that we still get
a complete list of dependencies for the 'check-all' target.
This should fix the follow-on issues of the same nature with various
other build targets, including Clang targets. Sorry for the churn, and
again thanks to Matt for testing and breaking this more thoroughly.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159593
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Mon, 2 Jul 2012 21:16:43 +0000 (21:16 +0000)]
Turn an assert into an error to make it a bit more friendly.
Part of rdar://
6880388 and rdar://
11766377
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159590
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 2 Jul 2012 21:14:06 +0000 (21:14 +0000)]
Work around a really frustrating apparant CMake bug.
No functionality changed here, except that the CMake installed by
default on Ubuntu Lucid should actually work with the makefile
generators now.
Thanks to Matt for the report and head-desking required to figure out
why it was failing.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159588
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Mon, 2 Jul 2012 21:00:00 +0000 (21:00 +0000)]
Fix -Wstring-conversion warning.
Patch by Matt Beaumont-Gay.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159583
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 2 Jul 2012 20:43:21 +0000 (20:43 +0000)]
Revert r159528 which taught lit's builtin shell test runner about the
'|&' bash syntax. We have lots of users with a bash on their system
which doesn't support this syntax, and as bash is still significantly
faster, we should support them.
The test suite has already been updated to cope with this.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159580
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 2 Jul 2012 20:14:54 +0000 (20:14 +0000)]
Switch from using a lit.cfg-generator variable that happens to be found
due to strange scoping rules to the actual canonical variable name
within the LLVM CMake build.
No functionality changed.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159575
91177308-0d34-0410-b5e6-
96231b3b80d8
Jack Carter [Mon, 2 Jul 2012 20:04:43 +0000 (20:04 +0000)]
Pass the correct ELFOSABI enumeration to the MipsELFObjectWriter constructor
Contributer: Sasa Stankovic
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159574
91177308-0d34-0410-b5e6-
96231b3b80d8
Bob Wilson [Mon, 2 Jul 2012 19:48:45 +0000 (19:48 +0000)]
Extend TargetPassConfig to allow running only a subset of the normal passes.
This is still a work in progress but I believe it is currently good enough
to fix PR13122 "Need unit test driver for codegen IR passes". For example,
you can run llc with -stop-after=loop-reduce to have it dump out the IR after
running LSR. Serializing machine-level IR is not yet supported but we have
some patches in progress for that.
The plan is to serialize the IR to a YAML file, containing separate sections
for the LLVM IR, machine-level IR, and whatever other info is needed. Chad
suggested that we stash the stop-after pass in the YAML file and use that
instead of the start-after option to figure out where to restart the
compilation. I think that's a great idea, but since it's not implemented yet
I put the -start-after option into this patch for testing purposes.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159570
91177308-0d34-0410-b5e6-
96231b3b80d8
Bob Wilson [Mon, 2 Jul 2012 19:48:39 +0000 (19:48 +0000)]
Move assertion with TargetPassConfig's Initialized flag.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159569
91177308-0d34-0410-b5e6-
96231b3b80d8
Bob Wilson [Mon, 2 Jul 2012 19:48:37 +0000 (19:48 +0000)]
Consistently use AnalysisID types in TargetPassConfig.
This makes it possible to just use a zero value to represent "no pass", so
the phony NoPassID global variable is no longer needed.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159568
91177308-0d34-0410-b5e6-
96231b3b80d8
Bob Wilson [Mon, 2 Jul 2012 19:48:31 +0000 (19:48 +0000)]
Add all codegen passes to the PassManager via TargetPassConfig.
This is a preliminary step toward having TargetPassConfig be able to
start and stop the compilation at specified passes for unit testing
and debugging. No functionality change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159567
91177308-0d34-0410-b5e6-
96231b3b80d8
Bob Wilson [Mon, 2 Jul 2012 19:48:18 +0000 (19:48 +0000)]
Add a missing forward declaration of PassManagerBase.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159566
91177308-0d34-0410-b5e6-
96231b3b80d8
Evan Cheng [Mon, 2 Jul 2012 19:45:42 +0000 (19:45 +0000)]
Need a space.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159565
91177308-0d34-0410-b5e6-
96231b3b80d8
Andrew Trick [Mon, 2 Jul 2012 19:12:29 +0000 (19:12 +0000)]
Revert accidental checkin.
My last checkin was apparently not the branch I intended. It was missing one change (added by chandlerc), and contained a spurious change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159548
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 2 Jul 2012 19:09:46 +0000 (19:09 +0000)]
Fix the remaining TCL-style quotes found in the testsuite. This is
another mechanical change accomplished though the power of terrible Perl
scripts.
I have manually switched some "s to 's to make escaping simpler.
While I started this to fix tests that aren't run in all configurations,
the massive number of tests is due to a really frustrating fragility of
our testing infrastructure: things like 'grep -v', 'not grep', and
'expected failures' can mask broken tests all too easily.
Essentially, I'm deeply disturbed that I can change the testsuite so
radically without causing any change in results for most platforms. =/
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159547
91177308-0d34-0410-b5e6-
96231b3b80d8
Duncan Sands [Mon, 2 Jul 2012 18:55:39 +0000 (18:55 +0000)]
GlobalOpt forgot to handle bitcast when analyzing globals. Found by inspection.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159546
91177308-0d34-0410-b5e6-
96231b3b80d8
Manman Ren [Mon, 2 Jul 2012 18:55:36 +0000 (18:55 +0000)]
Added assertion in getVRegDef of MachineRegisterInfo to make sure the virtual
register does not have multiple definitions. Modified TwoAddressInstructionPass
to use getUniqueVRegDef instead of getVRegDef.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159545
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 2 Jul 2012 18:37:59 +0000 (18:37 +0000)]
Convert the uses of '|&' to use '2>&1 |' instead, which works on old
versions of Bash. In addition, I can back out the change to the lit
built-in shell test runner to support this.
This should fix the majority of fallout on Darwin, but I suspect there
will be a few straggling issues.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159544
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 2 Jul 2012 18:28:34 +0000 (18:28 +0000)]
Fix the C++11 build. I hate narrowing conversions.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159543
91177308-0d34-0410-b5e6-
96231b3b80d8
Andrew Trick [Mon, 2 Jul 2012 18:10:42 +0000 (18:10 +0000)]
Reapply "Make NumMicroOps a variable in the subtarget's instruction itinerary."
Reapplies r159406 with minor cleanup. The regressions appear to have been spurious.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159541
91177308-0d34-0410-b5e6-
96231b3b80d8
Stepan Dyatkovskiy [Mon, 2 Jul 2012 17:42:46 +0000 (17:42 +0000)]
Fixed switch in IntRange::isSingleNumber method.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159540
91177308-0d34-0410-b5e6-
96231b3b80d8
Bob Wilson [Mon, 2 Jul 2012 17:22:47 +0000 (17:22 +0000)]
Do not attempt to use ROR for Thumb1.
Patch by Matt Fischer!
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159538
91177308-0d34-0410-b5e6-
96231b3b80d8
Nuno Lopes [Mon, 2 Jul 2012 16:14:47 +0000 (16:14 +0000)]
fix the regression I introduced in r159385 (it's necessary to update PHI nodes in unwind BB
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159534
91177308-0d34-0410-b5e6-
96231b3b80d8
Stepan Dyatkovskiy [Mon, 2 Jul 2012 14:10:46 +0000 (14:10 +0000)]
IntRange, fixed warning in isSingleNumber method
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159532
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 2 Jul 2012 13:35:01 +0000 (13:35 +0000)]
The built-in shell test runner for some reason doesn't like the quoting
and multi-line nature of this test. I don't really feel like bugging
this kind of edge-case, so just put it on one line and use single
quotes. With this, every test *really* passes with the built-in shell
test runner.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159530
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 2 Jul 2012 13:29:47 +0000 (13:29 +0000)]
Fix the TCL-style quoting in one random test that somehow slipped
through my perl nets.
With this, the test suite passes even if I force it to run with the
built-in shell test logic, except for a test which REQUIREs shell.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159529
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 2 Jul 2012 13:10:15 +0000 (13:10 +0000)]
Teach the built-in shell test runner in lit to handle '|&'-style pipes.
This is directly cloned from the logic in the TCL test bits of lit.
Hopefully will fix most of the windows build bot fallout.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159528
91177308-0d34-0410-b5e6-
96231b3b80d8
Stepan Dyatkovskiy [Mon, 2 Jul 2012 13:02:18 +0000 (13:02 +0000)]
IntRange:
- Changed isSingleNumber method behaviour. Now this flag is calculated on demand.
IntegersSubsetMapping
- Optimized diff operation.
- Replaced type of Items field from std::list with std::map.
- Added new methods:
bool isOverlapped(self &RHS)
void add(self& RHS, SuccessorClass *S)
void detachCase(self& NewMapping, SuccessorClass *Succ)
void removeCase(SuccessorClass *Succ)
SuccessorClass *findSuccessor(const IntTy& Val)
const IntTy* getCaseSingleNumber(SuccessorClass *Succ)
IntegersSubsetTest
- DiffTest: Added checks for successors.
SimplifyCFG
Updated SwitchInst usage (now it is case-ragnes compatible) for
- SimplifyEqualityComparisonWithOnlyPredecessor
- FoldValueComparisonIntoPredecessors
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159527
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 2 Jul 2012 12:47:22 +0000 (12:47 +0000)]
Convert all tests using TCL-style quoting to use shell-style quoting.
This was done through the aid of a terrible Perl creation. I will not
paste any of the horrors here. Suffice to say, it require multiple
staged rounds of replacements, state carried between, and a few
nested-construct-parsing hacks that I'm not proud of. It happens, by
luck, to be able to deal with all the TCL-quoting patterns in evidence
in the LLVM test suite.
If anyone is maintaining large out-of-tree test trees, feel free to poke
me and I'll send you the steps I used to convert things, as well as
answer any painful questions etc. IRC works best for this type of thing
I find.
Once converted, switch the LLVM lit config to use ShTests the same as
Clang. In addition to being able to delete large amounts of Python code
from 'lit', this will also simplify the entire test suite and some of
lit's architecture.
Finally, the test suite runs 33% faster on Linux now. ;]
For my 16-hardware-thread (2x 4-core xeon e5520): 36s -> 24s
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159525
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 2 Jul 2012 12:23:19 +0000 (12:23 +0000)]
Make tests which first provide a negative assertion via 'not', then
a pipeline, and then a positive assertion via grep, use two RUN lines
instead.
Supporting these complex ideas of 'success' and 'failure' across
multiple stages of a pipeline is brittle in the shell world, and would
block switching to ShTest format; it only worked due to contrivances
introduced by the TclTest format.
Writing this as two separate RUN lines seems clearer in any event.
This is another step toward completely removing TclTests from lit.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159524
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 2 Jul 2012 12:20:14 +0000 (12:20 +0000)]
Rewrite three tests that had truly egregious abuses of 'grep' in them to
use FileCheck.
Aside from removing a dependence on TCL-style quoting, this also makes
the tests ... significantly more robust. =] It would be really, *really*
great of the maintainer(s) of the CellSPU backend went through and
systematically rewrite these tests to use FileCheck. There are a lot
more that have nearly this bad of abuses.
Another step along the path to a TclTest-free testsuite.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159523
91177308-0d34-0410-b5e6-
96231b3b80d8
Kostya Serebryany [Mon, 2 Jul 2012 11:42:29 +0000 (11:42 +0000)]
[asan] small code simplification
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159522
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 2 Jul 2012 10:18:06 +0000 (10:18 +0000)]
Switch a bunch of Linker tests from using elaborate echo productions to
just provide and reference separate input files from an Inputs
subdirectory. This pattern works very well in the Clang tree and is
easier to understand in my opinion. It also has fewer limitations and
will remove one particularly annoying use of TCL-style {} quoting from
the testsuite.
Also teach the LLVM lit configuration to avoid recursing into 'Inputs'
subdirectories. This wasn't required for the previous 'Inputs'
subdirectories used due to fortuitous suffix patterns.
This is the first step to completely removing support for TCL-style tests.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159520
91177308-0d34-0410-b5e6-
96231b3b80d8
Alexey Samsonov [Mon, 2 Jul 2012 05:54:45 +0000 (05:54 +0000)]
This patch extends the libLLVMDebugInfo which contains a minimalistic DWARF parser:
1) DIContext is now able to return function name for a given instruction address (besides file/line info).
2) llvm-dwarfdump accepts flag --functions that prints the function name (if address is specified by --address flag).
3) test case that checks the basic functionality of llvm-dwarfdump added
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159512
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Sun, 1 Jul 2012 17:08:01 +0000 (17:08 +0000)]
Now that RegistersDefinedFromSameValue handles one instruction being an
implicit_def, the other instruction can be anything, including instructions
that define multiple values. Be careful about that and don't assume what operand
0 is.
Fixes pr13249.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159509
91177308-0d34-0410-b5e6-
96231b3b80d8
Elena Demikhovsky [Sun, 1 Jul 2012 06:12:26 +0000 (06:12 +0000)]
Optimization of shuffle node that can fit to the register form of VBROADCAST instruction on AVX2.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159504
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sun, 1 Jul 2012 02:55:34 +0000 (02:55 +0000)]
Reduce code size by using a second switch statement to avoid extra calls to SelectAtomic64. Also catch cases where SelectAtomic64 fails.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159503
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sun, 1 Jul 2012 02:18:18 +0000 (02:18 +0000)]
Add a break to the end of case statement missed in r159501.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159502
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sun, 1 Jul 2012 02:17:08 +0000 (02:17 +0000)]
Fix a crash on release builds if gather intrinsics are passed a non-constant value for the last argument.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159501
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sun, 1 Jul 2012 02:05:52 +0000 (02:05 +0000)]
Use a second switch statement to reduce number of calls to SelectGather in code. Reduces code size a bit.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159500
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Sat, 30 Jun 2012 22:37:15 +0000 (22:37 +0000)]
Reduce use list thrashing by using DenseMap's find_as for maps with ValueHandle keys.
No functionality change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159497
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Sat, 30 Jun 2012 20:21:19 +0000 (20:21 +0000)]
Don't reinsert the 'atexit' function if it already exists.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159491
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Sat, 30 Jun 2012 10:14:14 +0000 (10:14 +0000)]
Hoist LLVM's lit testsuite infrastructure into module so that it can be
re-used. Also, build in direct support for accumulating a set of lit
parameters, arguments, and testsuites to run as part of a 'check-all'
rule. This sinks 'check-all' from a Clang-specific construct to
a generic construct of the project.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159482
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Sat, 30 Jun 2012 10:02:08 +0000 (10:02 +0000)]
Avoid sign compare warning.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159481
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Sat, 30 Jun 2012 01:45:55 +0000 (01:45 +0000)]
Handle implicit_defs in the register coalescer. I am still trying to produce
a reduced testcase, but this fixes pr13209.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159479
91177308-0d34-0410-b5e6-
96231b3b80d8
Nuno Lopes [Fri, 29 Jun 2012 22:10:10 +0000 (22:10 +0000)]
revert r159440. As Duncan pointed out, the test for invoke is not needed at this point
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159471
91177308-0d34-0410-b5e6-
96231b3b80d8
Manman Ren [Fri, 29 Jun 2012 22:06:19 +0000 (22:06 +0000)]
ARM: Clean up optimizeCompare in peephole, no functional change.
Use getUniqueVRegDef.
Replace a loop with existing interfaces: modifiesRegister and readsRegister.
Factor out code into inline functions and simplify the code.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159470
91177308-0d34-0410-b5e6-
96231b3b80d8