Ilia Mirkin [Sun, 13 Mar 2011 05:29:10 +0000 (00:29 -0500)]
staging: speakup: Remove NULL check before kfree
This patch was generated by the following semantic patch:
// <smpl>
@@ expression E; @@
- if (E != NULL) { kfree(E); }
+ kfree(E);
@@ expression E; @@
- if (E != NULL) { kfree(E); E = NULL; }
+ kfree(E);
+ E = NULL;
// </smpl>
Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ilia Mirkin [Sun, 13 Mar 2011 05:29:09 +0000 (00:29 -0500)]
staging: serqt_usb2: Remove NULL check before kfree
This patch was generated by the following semantic patch:
// <smpl>
@@ expression E; @@
- if (E != NULL) { kfree(E); }
+ kfree(E);
@@ expression E; @@
- if (E != NULL) { kfree(E); E = NULL; }
+ kfree(E);
+ E = NULL;
// </smpl>
Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ilia Mirkin [Sun, 13 Mar 2011 05:29:08 +0000 (00:29 -0500)]
staging: rtl8712: Remove NULL check before kfree
This patch was generated by the following semantic patch:
// <smpl>
@@ expression E; @@
- if (E != NULL) { kfree(E); }
+ kfree(E);
@@ expression E; @@
- if (E != NULL) { kfree(E); E = NULL; }
+ kfree(E);
+ E = NULL;
// </smpl>
Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ilia Mirkin [Sun, 13 Mar 2011 05:29:07 +0000 (00:29 -0500)]
staging: rtl8192u: Remove NULL check before kfree
This patch was generated by the following semantic patch:
// <smpl>
@@ expression E; @@
- if (E != NULL) { kfree(E); }
+ kfree(E);
@@ expression E; @@
- if (E != NULL) { kfree(E); E = NULL; }
+ kfree(E);
+ E = NULL;
// </smpl>
Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ilia Mirkin [Sun, 13 Mar 2011 05:29:06 +0000 (00:29 -0500)]
staging: rtl8192e: Remove NULL check before kfree
This patch was generated by the following semantic patch:
// <smpl>
@@ expression E; @@
- if (E != NULL) { kfree(E); }
+ kfree(E);
@@ expression E; @@
- if (E != NULL) { kfree(E); E = NULL; }
+ kfree(E);
+ E = NULL;
// </smpl>
Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ilia Mirkin [Sun, 13 Mar 2011 05:29:05 +0000 (00:29 -0500)]
staging: rtl8187se: Remove NULL check before kfree
This patch was generated by the following semantic patch:
// <smpl>
@@ expression E; @@
- if (E != NULL) { kfree(E); }
+ kfree(E);
@@ expression E; @@
- if (E != NULL) { kfree(E); E = NULL; }
+ kfree(E);
+ E = NULL;
// </smpl>
Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ilia Mirkin [Sun, 13 Mar 2011 05:29:04 +0000 (00:29 -0500)]
staging: rt2860: Remove NULL check before kfree
This patch was generated by the following semantic patch:
// <smpl>
@@ expression E; @@
- if (E != NULL) { kfree(E); }
+ kfree(E);
@@ expression E; @@
- if (E != NULL) { kfree(E); E = NULL; }
+ kfree(E);
+ E = NULL;
// </smpl>
Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ilia Mirkin [Sun, 13 Mar 2011 05:29:03 +0000 (00:29 -0500)]
staging: pohmelfs: Remove NULL check before kfree
This patch was generated by the following semantic patch:
// <smpl>
@@ expression E; @@
- if (E != NULL) { kfree(E); }
+ kfree(E);
@@ expression E; @@
- if (E != NULL) { kfree(E); E = NULL; }
+ kfree(E);
+ E = NULL;
// </smpl>
Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ilia Mirkin [Sun, 13 Mar 2011 05:29:02 +0000 (00:29 -0500)]
staging: line6: Remove NULL check before kfree
This patch was generated by the following semantic patch:
// <smpl>
@@ expression E; @@
- if (E != NULL) { kfree(E); }
+ kfree(E);
@@ expression E; @@
- if (E != NULL) { kfree(E); E = NULL; }
+ kfree(E);
+ E = NULL;
// </smpl>
Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ilia Mirkin [Sun, 13 Mar 2011 05:29:01 +0000 (00:29 -0500)]
staging: keucr: Remove NULL check before kfree
This patch was generated by the following semantic patch:
// <smpl>
@@ expression E; @@
- if (E != NULL) { kfree(E); }
+ kfree(E);
@@ expression E; @@
- if (E != NULL) { kfree(E); E = NULL; }
+ kfree(E);
+ E = NULL;
// </smpl>
Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ilia Mirkin [Sun, 13 Mar 2011 05:28:59 +0000 (00:28 -0500)]
staging: go7007: Remove NULL check before kfree
This patch was generated by the following semantic patch:
// <smpl>
@@ expression E; @@
- if (E != NULL) { kfree(E); }
+ kfree(E);
@@ expression E; @@
- if (E != NULL) { kfree(E); E = NULL; }
+ kfree(E);
+ E = NULL;
// </smpl>
Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ilia Mirkin [Sun, 13 Mar 2011 05:28:58 +0000 (00:28 -0500)]
staging: cx25821: Remove NULL check before kfree
This patch was generated by the following semantic patch:
// <smpl>
@@ expression E; @@
- if (E != NULL) { kfree(E); }
+ kfree(E);
@@ expression E; @@
- if (E != NULL) { kfree(E); E = NULL; }
+ kfree(E);
+ E = NULL;
// </smpl>
Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ilia Mirkin [Sun, 13 Mar 2011 05:28:57 +0000 (00:28 -0500)]
staging: comedi: Remove NULL check before kfree
This patch was generated by the following semantic patch:
// <smpl>
@@ expression E; @@
- if (E != NULL) { kfree(E); }
+ kfree(E);
@@ expression E; @@
- if (E != NULL) { kfree(E); E = NULL; }
+ kfree(E);
+ E = NULL;
// </smpl>
Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ilia Mirkin [Sun, 13 Mar 2011 05:28:56 +0000 (00:28 -0500)]
staging: brcm80211: Remove NULL check before kfree
This patch was generated by the following semantic patch:
// <smpl>
@@ expression E; @@
- if (E != NULL) { kfree(E); }
+ kfree(E);
@@ expression E; @@
- if (E != NULL) { kfree(E); E = NULL; }
+ kfree(E);
+ E = NULL;
// </smpl>
Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ilia Mirkin [Sun, 13 Mar 2011 05:28:55 +0000 (00:28 -0500)]
staging: bcm: Remove NULL check before kfree
This patch was generated by the following semantic patch:
// <smpl>
@@ expression E; @@
- if (E != NULL) { kfree(E); }
+ kfree(E);
@@ expression E; @@
- if (E != NULL) { kfree(E); E = NULL; }
+ kfree(E);
+ E = NULL;
// </smpl>
Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ilia Mirkin [Sun, 13 Mar 2011 05:28:54 +0000 (00:28 -0500)]
staging: ath6kl: Remove NULL check before kfree
This patch was generated by the following semantic patch:
// <smpl>
@@ expression E; @@
- if (E != NULL) { kfree(E); }
+ kfree(E);
@@ expression E; @@
- if (E != NULL) { kfree(E); E = NULL; }
+ kfree(E);
+ E = NULL;
// </smpl>
Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
Acked-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Aaro Koskinen [Sun, 13 Mar 2011 10:26:28 +0000 (12:26 +0200)]
staging: xgifb: clean up register function variable names
Eliminate mixed case from variable names.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Aaro Koskinen [Sun, 13 Mar 2011 10:26:27 +0000 (12:26 +0200)]
staging: xgifb: clean up register access types
Make type usage consistent. Use u8 for HW registers and unsigned for
bitmasks.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Aaro Koskinen [Sun, 13 Mar 2011 10:26:26 +0000 (12:26 +0200)]
staging: xgifb: rename XGINew_SetRegAND() to xgifb_reg_and()
Rename XGINew_SetRegAND() to xgifb_reg_and().
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Aaro Koskinen [Sun, 13 Mar 2011 10:26:25 +0000 (12:26 +0200)]
staging: xgifb: rename XGINew_SetRegANDOR() to xgifb_reg_and_or()
Rename XGINew_SetRegANDOR() to xgifb_reg_and_or().
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Aaro Koskinen [Sun, 13 Mar 2011 10:26:24 +0000 (12:26 +0200)]
staging: xgifb: rename XGINew_SetRegOR() to xgifb_reg_or()
Rename XGINew_SetRegOR() to xgifb_reg_or().
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Aaro Koskinen [Sun, 13 Mar 2011 10:26:23 +0000 (12:26 +0200)]
staging: xgifb: rename XGINew_GetReg1() to xgifb_reg_get()
Rename XGINew_GetReg1() to xgifb_reg_get().
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Aaro Koskinen [Sun, 13 Mar 2011 10:26:22 +0000 (12:26 +0200)]
staging: xgifb: rename XGINew_SetReg1() to xgifb_reg_set()
Rename XGINew_SetReg1() to xgifb_reg_set().
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Aaro Koskinen [Sun, 13 Mar 2011 10:26:21 +0000 (12:26 +0200)]
staging: xgifb: replace XGINew_SetReg4() with outl()
Replace XGINew_SetReg4() with outl().
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Aaro Koskinen [Sun, 13 Mar 2011 10:26:20 +0000 (12:26 +0200)]
staging: xgifb: replace XGINew_SetReg3() with outb()
Replace XGINew_SetReg3() with outb().
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Aaro Koskinen [Sun, 13 Mar 2011 10:26:19 +0000 (12:26 +0200)]
staging: xgifb: replace XGINew_GetReg3() with inl()
Replace XGINew_GetReg3() with inl().
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Aaro Koskinen [Sun, 13 Mar 2011 10:26:18 +0000 (12:26 +0200)]
staging: xgifb: replace XGINew_GetReg2() with inb()
Replace XGINew_GetReg2() with inb().
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Aaro Koskinen [Sun, 13 Mar 2011 10:26:17 +0000 (12:26 +0200)]
staging: xgifb: vb_util: delete commented-out code
Delete commented-out code.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Aaro Koskinen [Sun, 13 Mar 2011 10:26:16 +0000 (12:26 +0200)]
staging: xgifb: vb_util: include the .h file
Include the .h file and delete redundant definitions.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Aaro Koskinen [Sun, 13 Mar 2011 10:26:15 +0000 (12:26 +0200)]
staging: xgifb: replace DelayUS() with udelay()
Replace DelayUS() with udelay().
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Aaro Koskinen [Sun, 13 Mar 2011 10:26:14 +0000 (12:26 +0200)]
staging: xgifb: use mdelay() for millisecond delays
Use mdelay() instead of udelay() for millisecond delays.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Aaro Koskinen [Sun, 13 Mar 2011 10:26:13 +0000 (12:26 +0200)]
staging: xgifb: delete incorrect I/O mapping
If the PCI device was disabled when the probe() routine started, the
driver will create 256 MB video memory mapping which is never used or
properly released. It's also unsafe as the size is incorrect for many
video cards. Deleting it also allows eliminating XGIvga_enable global
variable.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Aaro Koskinen [Sun, 13 Mar 2011 10:26:12 +0000 (12:26 +0200)]
staging: xgifb: delete redundant extended register access enable
The extended register access enable in !XGIvga_enabled case is not needed.
The driver has enabled the access unconditionally already earlier in
the routine.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Aaro Koskinen [Sun, 13 Mar 2011 10:26:11 +0000 (12:26 +0200)]
staging: xgifb: delete unused LINUXBIOS code
Delete unused LINUXBIOS code.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Aaro Koskinen [Sun, 13 Mar 2011 10:26:10 +0000 (12:26 +0200)]
staging: xgifb: eliminate redudant chip type >= XG40 checks
Since all chips supported by the driver are >= XG40, these checks are
redundant and the code can be modified accordingly.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Aaro Koskinen [Sun, 13 Mar 2011 10:26:09 +0000 (12:26 +0200)]
staging: xgifb: delete dead code for chip types < XG40
XG40 is the first supported chip, so the code for earlier chips can
be dropped.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Aaro Koskinen [Sun, 13 Mar 2011 10:26:08 +0000 (12:26 +0200)]
staging: xgifb: delete unsupported chip types
The probe routine will fail if the chip is other than XG40..XG27, so
the other types can be dropped.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Aaro Koskinen [Sun, 13 Mar 2011 10:26:07 +0000 (12:26 +0200)]
staging: xgifb: vb_setmode: move functions to avoid forward declarations
Move functions to avoid forward declarations.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Aaro Koskinen [Sun, 13 Mar 2011 10:26:06 +0000 (12:26 +0200)]
staging: xgifb: vb_init: move functions to avoid forward declarations
Move functions to avoid forward declarations.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Aaro Koskinen [Sun, 13 Mar 2011 10:26:05 +0000 (12:26 +0200)]
staging: xgifb: vb_ext: move functions to avoid forward declarations
Move functions to avoid forward declarations.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Thu, 10 Mar 2011 10:51:35 +0000 (11:51 +0100)]
staging: ft1000: Fix coding style in ft1000_proc_drvmsg function.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Thu, 10 Mar 2011 10:51:34 +0000 (11:51 +0100)]
staging: ft1000: Fix coding style in ft1000_dsp_prov function.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Thu, 10 Mar 2011 10:51:33 +0000 (11:51 +0100)]
staging: ft1000: Fix coding style in ft1000_receive_cmd function.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Thu, 10 Mar 2011 10:51:32 +0000 (11:51 +0100)]
staging: ft1000: Fix coding style in ft1000_chkcard function.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Thu, 10 Mar 2011 10:51:31 +0000 (11:51 +0100)]
staging: ft1000: Fix coding style in ft1000_close function.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Thu, 10 Mar 2011 10:51:30 +0000 (11:51 +0100)]
staging: ft1000: Fix coding style in ft1000_open function.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Thu, 10 Mar 2011 10:51:29 +0000 (11:51 +0100)]
staging: ft1000: Fix coding style in ft1000_copy_up_pkt function.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Thu, 10 Mar 2011 10:51:28 +0000 (11:51 +0100)]
staging: ft1000: Fix coding style in ft1000_submit_rx_urb function.
Fix coding style and also replace printk with proper pr_err
function.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Thu, 10 Mar 2011 10:51:27 +0000 (11:51 +0100)]
staging: ft1000: Fix coding style in ft1000_start_xmit function.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Thu, 10 Mar 2011 10:51:26 +0000 (11:51 +0100)]
staging: ft1000: Fix coding style in ft1000_copy_down_pkt function.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Thu, 10 Mar 2011 10:51:25 +0000 (11:51 +0100)]
staging: ft1000: Fix coding style in ft1000_usb_transmit_complete function.
Fix coding style and also replace printk with proper pr_err
function.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Thu, 10 Mar 2011 10:51:24 +0000 (11:51 +0100)]
staging: ft1000: Fix coding style in ft1000_reset function.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Thu, 10 Mar 2011 10:51:23 +0000 (11:51 +0100)]
staging: ft1000: Fix coding style in reg_ft1000_netdev function.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Thu, 10 Mar 2011 10:51:22 +0000 (11:51 +0100)]
staging: ft1000: Change return value for init_ft1000_netdev function.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Thu, 10 Mar 2011 10:51:21 +0000 (11:51 +0100)]
staging: ft1000: Fix coding style in init_ft1000_netdev function.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Thu, 10 Mar 2011 10:51:20 +0000 (11:51 +0100)]
staging: ft1000: Fix identation in ftnet_ops struct.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Thu, 10 Mar 2011 10:51:19 +0000 (11:51 +0100)]
staging: ft1000: Fix coding style in ft1000_reset_card function.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Thu, 10 Mar 2011 10:51:18 +0000 (11:51 +0100)]
staging: ft1000: Fix coding style in ft1000_reset_asic function.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Thu, 10 Mar 2011 10:51:17 +0000 (11:51 +0100)]
staging: ft1000: Fix coding style in dsp_reload function.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Thu, 10 Mar 2011 10:51:16 +0000 (11:51 +0100)]
staging: ft1000: Fix coding style in card_send_command function.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Thu, 10 Mar 2011 10:51:15 +0000 (11:51 +0100)]
staging: ft1000: Replace camelcase CardSendCommand function name.
Replace CardSendCommand by card_send_command.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Michael Hennerich [Thu, 10 Mar 2011 12:26:48 +0000 (13:26 +0100)]
staging: IIO: DAC: AD5446: Add support for AD5601/AD5611/AD5621
This patch adds support for the AD5601/AD5611/AD5621 single channel,
8-/10-/12-bit, buffered voltage output DACs.
Changes since v1:
Sort Kconfig description my number
Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Michael Hennerich [Thu, 10 Mar 2011 12:26:47 +0000 (13:26 +0100)]
staging: IIO: DAC: AD5446: Add power down support
Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Michael Hennerich [Thu, 10 Mar 2011 12:26:46 +0000 (13:26 +0100)]
staging: IIO: DAC: AD5446: Add missing ID table entries
Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Dan Carpenter [Mon, 14 Mar 2011 09:35:31 +0000 (12:35 +0300)]
Staging: crystalhd: don't waste the last char of buffer
pinfo->name is a 32 char buffer. In the original code, the last char
wasn't fully utilized.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Dan Carpenter [Mon, 14 Mar 2011 09:33:37 +0000 (12:33 +0300)]
Staging: crystalhd: change GFP_ATOMIC to GFP_KERNEL
These two allocations are only called from the probe() path and there
aren't any locks held for probe().
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Roland Vossen [Thu, 10 Mar 2011 13:40:20 +0000 (14:40 +0100)]
staging: brcm80211: lower number of wlc_bsscfg.h includes
Code cleanup.
Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Roland Vossen [Thu, 10 Mar 2011 13:40:19 +0000 (14:40 +0100)]
staging: brcm80211: replaced wlc_bsscfg_t by struct wlc_bsscfg
Code cleanup.
Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Roland Vossen [Thu, 10 Mar 2011 13:40:17 +0000 (14:40 +0100)]
staging: brcm80211: removed comment in rx status processing
Code cleanup. The comment is hinting that we should sanity check the
header to verify that if it claims its from a 5Ghz channel, that the
chip actually supports 5 Ghz. This is redundant (2.4G only chips do
not report 5G channels) and thus the comment was removed.
Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Roland Vossen [Thu, 10 Mar 2011 10:35:09 +0000 (11:35 +0100)]
staging: brcm80211: invalidate all AMPDU packets on IEEE80211_AMPDU_TX_STOP
The previous patch flushed the AMPDU packets associated to a certain STA/AP
in the driver queues, but left the AMPDU packets in the DMA queue untouched.
This patch invalidates AMPDU packets in the DMA queue, so they can be
processed accordingly when hardware releases the packets to the driver.
Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Roland Vossen [Thu, 10 Mar 2011 10:35:08 +0000 (11:35 +0100)]
staging: brcm80211: added IEEE80211_AMPDU_TX_STOP handling
Driver now flushes AMPDU packets for a specified station on Mac80211 calling
wl_ops_ampdu_action(IEEE80211_AMPDU_TX_STOP). Not all AMPDU packets are flushed
yet: there can still be AMPDU packets pending in hardware (DMA). That is the
subject of the next patch in this series.
Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Roland Vossen [Thu, 10 Mar 2011 10:35:07 +0000 (11:35 +0100)]
staging: brcm80211: bugfix for control.sta NULL ptr dereference
Mac80211 can transmit packets where the control.sta field is NULL.
The driver dereferenced this. Bugfix was to only dereference a non NULL
ieee80211_sta pointer.
Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Roland Vossen [Thu, 10 Mar 2011 10:35:06 +0000 (11:35 +0100)]
staging: brcm80211: bugfix for NULL scb ptr dereference
The driver uses a struct called 'scb', this struct is primarily used for AMPDU
functionality and is embedded in struct ieee80211_sta. To increase driver
robustness, the case in which this scb pointer is NULL is now handled graceful.
This paves the way for the next patch in this series.
Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 11 Mar 2011 22:32:01 +0000 (14:32 -0800)]
Staging: samsung-laptop: add support for N230 model
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Luis R. Rodriguez [Fri, 11 Mar 2011 02:55:47 +0000 (18:55 -0800)]
staging: ath6kl: remove-typedef DEV_SCATTER_DMA_VIRTUAL_INFO
remove-typedef -s DEV_SCATTER_DMA_VIRTUAL_INFO \
"struct dev_scatter_dma_virtual_info" drivers/staging/ath6kl/
Cc: Naveen Singh <naveen.singh@atheros.com>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Luis R. Rodriguez [Fri, 11 Mar 2011 02:55:46 +0000 (18:55 -0800)]
staging: ath6kl: remove-typedef COMMON_CREDIT_STATE_INFO
remove-typedef -s COMMON_CREDIT_STATE_INFO \
"struct common_credit_state_info" drivers/staging/ath6kl/
Cc: Naveen Singh <naveen.singh@atheros.com>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Luis R. Rodriguez [Fri, 11 Mar 2011 02:55:45 +0000 (18:55 -0800)]
staging: ath6kl: remove-typedef BUFFER_PROC_LIST
remove-typedef -s BUFFER_PROC_LIST \
"struct buffer_proc_list" drivers/staging/ath6kl/
Cc: Naveen Singh <naveen.singh@atheros.com>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Luis R. Rodriguez [Fri, 11 Mar 2011 02:55:44 +0000 (18:55 -0800)]
staging: ath6kl: remove-typedef ATH_DEBUG_MASK_DESCRIPTION
remove-typedef -s ATH_DEBUG_MASK_DESCRIPTION \
"struct ath_debug_mask_description" drivers/staging/ath6kl/
Cc: Naveen Singh <naveen.singh@atheros.com>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Luis R. Rodriguez [Fri, 11 Mar 2011 02:55:43 +0000 (18:55 -0800)]
staging: ath6kl: remove-typedef ATHBT_FILTER_INSTANCE
We mark this as unused as well, given that I find no users,
at a later time we can determine to nuke this or not...
Cc: Naveen Singh <naveen.singh@atheros.com>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Luis R. Rodriguez [Fri, 11 Mar 2011 02:55:42 +0000 (18:55 -0800)]
staging: ath6kl: remove-typedef AR_VIRTUAL_INTERFACE_T
remove-typedef -s AR_VIRTUAL_INTERFACE_T \
"struct ar_virtual_interface" drivers/staging/ath6kl/
Cc: Naveen Singh <naveen.singh@atheros.com>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Luis R. Rodriguez [Fri, 11 Mar 2011 02:55:41 +0000 (18:55 -0800)]
staging: ath6kl: remove-typedef AR6K_IRQ_PROC_REGISTERS
remove-typedef -s AR6K_IRQ_PROC_REGISTERS \
"struct ar6k_irq_proc_registers" drivers/staging/ath6kl/
Cc: Naveen Singh <naveen.singh@atheros.com>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Luis R. Rodriguez [Fri, 11 Mar 2011 02:55:40 +0000 (18:55 -0800)]
staging: ath6kl: remove-typedef AR6K_IRQ_ENABLE_REGISTERS
remove-typedef -s AR6K_IRQ_ENABLE_REGISTERS \
"struct ar6k_irq_enable_registers" drivers/staging/ath6kl/
Cc: Naveen Singh <naveen.singh@atheros.com>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Luis R. Rodriguez [Fri, 11 Mar 2011 02:55:39 +0000 (18:55 -0800)]
staging: ath6kl: remove-typedef AR6K_HCI_BRIDGE_INFO
remove-typedef -s AR6K_HCI_BRIDGE_INFO \
"struct ar6k_hci_bridge_info" drivers/staging/ath6kl/
Cc: Naveen Singh <naveen.singh@atheros.com>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Luis R. Rodriguez [Fri, 11 Mar 2011 02:55:38 +0000 (18:55 -0800)]
staging: ath6kl: remove-typedef AR6K_GMBOX_INFO
remove-typedef -s AR6K_GMBOX_INFO \
"struct ar6k_gmbox_info" drivers/staging/ath6kl/
Cc: Naveen Singh <naveen.singh@atheros.com>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Luis R. Rodriguez [Fri, 11 Mar 2011 02:55:37 +0000 (18:55 -0800)]
staging: ath6kl: remove-typedef AR6K_GMBOX_CTRL_REGISTERS
remove-typedef -s AR6K_GMBOX_CTRL_REGISTERS \
"struct ar6k_gmbox_ctrl_registers" drivers/staging/ath6k
Cc: Naveen Singh <naveen.singh@atheros.com>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Luis R. Rodriguez [Fri, 11 Mar 2011 02:55:36 +0000 (18:55 -0800)]
staging: ath6kl: remove-typedef AR6K_DEVICE
remove-typedef -s AR6K_DEVICE \
"struct ar6k_device" drivers/staging/ath6kl/
Cc: Naveen Singh <naveen.singh@atheros.com>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Luis R. Rodriguez [Fri, 11 Mar 2011 02:55:35 +0000 (18:55 -0800)]
staging: ath6kl: remove-typedef AR6K_ASYNC_REG_IO_BUFFER
remove-typedef -s AR6K_ASYNC_REG_IO_BUFFER \
"struct ar6k_async_reg_io_buffer" drivers/staging/ath6kl/
Cc: Naveen Singh <naveen.singh@atheros.com>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Luis R. Rodriguez [Fri, 11 Mar 2011 02:55:34 +0000 (18:55 -0800)]
staging: ath6kl: remove-typedef AR6000_USER_SETKEYS_INFO
remove-typedef -s AR6000_USER_SETKEYS_INFO \
"struct ar6000_user_setkeys_info" drivers/staging/ath6kl/
Cc: Naveen Singh <naveen.singh@atheros.com>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Luis R. Rodriguez [Fri, 11 Mar 2011 02:55:33 +0000 (18:55 -0800)]
staging: ath6kl: remove-typedef AR3K_CONFIG_INFO
remove-typedef -s AR3K_CONFIG_INFO \
"struct ar3k_config_info" drivers/staging/ath6kl/
Cc: Naveen Singh <naveen.singh@atheros.com>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Luis R. Rodriguez [Fri, 11 Mar 2011 02:55:32 +0000 (18:55 -0800)]
staging: ath6kl: remove-typedef AGGR_INFO
remove-typedef -s AGGR_INFO \
"struct aggr_info" drivers/staging/ath6kl/
Cc: Naveen Singh <naveen.singh@atheros.com>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Luis R. Rodriguez [Fri, 11 Mar 2011 02:55:31 +0000 (18:55 -0800)]
staging: ath6kl: remove-typedef: A_UCHAR
remove-typedef -s A_UCHAR u8 drivers/staging/ath6kl/
This uses the remove-typedef utility:
http://www.kernel.org/pub/linux/kernel/people/mcgrof/scripts/remove-typedef
Cc: Naveen Singh <naveen.singh@atheros.com>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Luis R. Rodriguez [Fri, 11 Mar 2011 02:55:30 +0000 (18:55 -0800)]
staging: ath6kl: s|A_MEMCMP|memcmp|g
for i in $(find ./drivers/staging/ath6kl/ -name \*.[ch]) ; do \
sed -r -i -e "s/A_MEMCMP/memcmp/g" $i; done
Cc: Naveen Singh <naveen.singh@atheros.com>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Luis R. Rodriguez [Fri, 11 Mar 2011 02:55:29 +0000 (18:55 -0800)]
staging: ath6kl: s|A_MEMCPY|memcpy|g
for i in $(find ./drivers/staging/ath6kl/ -name \*.[ch]) ; do \
sed -r -i -e "s/A_MEMCPY/memcpy/g" $i; done
Cc: Naveen Singh <naveen.singh@atheros.com>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Javier Martinez Canillas [Fri, 11 Mar 2011 02:55:28 +0000 (18:55 -0800)]
staging: ath6kl: Cast variable to size_t to avoid compile warning
The min() macro does strict type-checking so use min_t() instead
to silence a compile warning.
Cc: Naveen Singh <naveen.singh@atheros.com>
Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Randy Dunlap [Fri, 11 Mar 2011 00:49:56 +0000 (16:49 -0800)]
usb-storage: fix menu ordering
Move the USB_STORAGE_ENE_UB6250 entry so that it stays under the
USB_STORAGE menu.
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Randy Dunlap [Fri, 11 Mar 2011 00:48:36 +0000 (16:48 -0800)]
usb-storage: ene_ub6250 depends on USB_STORAGE
Fix ene_ub6250 build: it uses usb_storage driver interfaces, so it
should depend on USB_STORAGE.
ene_ub6250.c:(.text+0x14ff19): undefined reference to `usb_stor_reset_resume'
ene_ub6250.c:(.text+0x14ffb1): undefined reference to `usb_stor_bulk_transfer_buf'
ene_ub6250.c:(.text+0x14ffdd): undefined reference to `usb_stor_bulk_srb'
ene_ub6250.c:(.text+0x14fff1): undefined reference to `usb_stor_bulk_transfer_sg'
ene_ub6250.c:(.text+0x1503dd): undefined reference to `usb_stor_set_xfer_buf'
ene_ub6250.c:(.text+0x15048e): undefined reference to `usb_stor_access_xfer_buf'
ene_ub6250.c:(.text+0x150723): undefined reference to `usb_stor_probe1'
ene_ub6250.c:(.text+0x150795): undefined reference to `usb_stor_probe2'
ene_ub6250.c:(.text+0x1507af): undefined reference to `usb_stor_disconnect'
drivers/built-in.o:(.data+0x10224): undefined reference to `usb_stor_suspend'
drivers/built-in.o:(.data+0x10230): undefined reference to `usb_stor_pre_reset'
drivers/built-in.o:(.data+0x10234): undefined reference to `usb_stor_post_reset'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Dan Carpenter [Thu, 10 Mar 2011 08:31:33 +0000 (11:31 +0300)]
USB: ene_ub6250: fix memory leak in ene_load_bincode()
"buf" gets allocated twice in a row. It's the second allocation which
is correct. The first one should be removed.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: huajun li <huajun.li.lee@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Aaro Koskinen [Tue, 8 Mar 2011 20:16:20 +0000 (22:16 +0200)]
staging: xgifb: vb_init: make internal functions static
Make some internal functions static.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Aaro Koskinen [Tue, 8 Mar 2011 20:16:19 +0000 (22:16 +0200)]
staging: xgifb: vb_init: delete unused functions
Delete unused functions.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Aaro Koskinen [Tue, 8 Mar 2011 20:16:18 +0000 (22:16 +0200)]
staging: xgifb: vb_init: delete redundant declarations
Delete redundant declarations.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
projects / firefly-linux-kernel-4.4.55.git / log