Matt Arsenault [Thu, 10 Sep 2015 21:51:15 +0000 (21:51 +0000)]
AMDGPU: Use StringRef value
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247344
91177308-0d34-0410-b5e6-
96231b3b80d8
James Y Knight [Thu, 10 Sep 2015 21:49:06 +0000 (21:49 +0000)]
[SPARC] Switch to the Machine Scheduler.
The (mostly-deprecated) SelectionDAG-based ILPListDAGScheduler scheduler
was making poor scheduling decisions, causing high register pressure and
extraneous register spills.
Switching to the newer machine scheduler generates better code -- even
without there being a machine model defined for SPARC yet.
(Actually committing the test changes too, this time, unlike r247315)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247343
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Thu, 10 Sep 2015 21:48:36 +0000 (21:48 +0000)]
Mark two methods const.
While at it, optimize getOffset a bit.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247342
91177308-0d34-0410-b5e6-
96231b3b80d8
Reid Kleckner [Thu, 10 Sep 2015 21:46:36 +0000 (21:46 +0000)]
Fix SEH state numbering algorithm to handle cleanupendpads
WinEHPrepare's new coloring algorithm really expects to see
cleanupendpads now, so Clang will start emitting them soon.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247341
91177308-0d34-0410-b5e6-
96231b3b80d8
Matthew Simpson [Thu, 10 Sep 2015 21:12:57 +0000 (21:12 +0000)]
[LV] Relax Small Size Reduction Type Requirement
This patch enables small size reductions in which the source types are smaller
than the reduction type (e.g., computing an i16 sum from the values in an i8
array). The previous behavior was to only allow small size reductions if the
source types and reduction type were the same. The change accounts for the fact
that the existing sign- and zero-extend instructions in these cases should
still be included in the cost model.
Differential Revision: http://reviews.llvm.org/D12770
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247337
91177308-0d34-0410-b5e6-
96231b3b80d8
Lang Hames [Thu, 10 Sep 2015 21:05:58 +0000 (21:05 +0000)]
[RuntimeDyld] Support non-zero addends for the MachO X86_64 SUBTRACTOR reloc.
This functionality was accidentally left out of r247119.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247336
91177308-0d34-0410-b5e6-
96231b3b80d8
Lang Hames [Thu, 10 Sep 2015 20:44:36 +0000 (20:44 +0000)]
[RuntimeDyld] Fix a bug in debugging output: all sections should be dumped
before any relocations have been applied, and again after all relocations have
been applied.
Previously each section was dumped before and after relocations targetting it
were applied, but this only shows the impact of relocations that point to other
symbols in the same section.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247335
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Thu, 10 Sep 2015 20:34:57 +0000 (20:34 +0000)]
Add an explicit 'inline' specifier to these static functions. GCC is
warning on them having always_inline attribute for reasons I don't fully
understand -- static functions are just as inlinable as inline
functions in terms of linkage.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247334
91177308-0d34-0410-b5e6-
96231b3b80d8
Reid Kleckner [Thu, 10 Sep 2015 20:07:25 +0000 (20:07 +0000)]
Correct the return type of CreateCleanupEndPad
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247331
91177308-0d34-0410-b5e6-
96231b3b80d8
James Y Knight [Thu, 10 Sep 2015 19:42:03 +0000 (19:42 +0000)]
Revert "[SPARC] Switch to the Machine Scheduler."
This reverts commit r247315.
Accidentally omitted test changes; will resubmit full change shortly.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247328
91177308-0d34-0410-b5e6-
96231b3b80d8
David Majnemer [Thu, 10 Sep 2015 18:50:09 +0000 (18:50 +0000)]
[IR] Conservatively mark 'catchpad' as accessing memory
The exact semantics of 'catchpad' are really in the hands of the
personality routine so we shouldn't assume that they have no side
effects.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247322
91177308-0d34-0410-b5e6-
96231b3b80d8
Kostya Serebryany [Thu, 10 Sep 2015 18:48:38 +0000 (18:48 +0000)]
[libFuzzer] refactor the code to allow building libFuzzer on platforms that don't have dfsan and don't support weak functions
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247321
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Bieneman [Thu, 10 Sep 2015 18:22:33 +0000 (18:22 +0000)]
[CMake] Add lto subdirectory explicitly.
This is required because ExternalProject_Add requires all targets specified in the DEPENDS argument must exist before calling ExternalProject_Add.
I have a follow-up patch to clang that enables using the just-built libLTO in bootstrap builds, so we need to be able to add the LTO target as a dependency in clang.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247316
91177308-0d34-0410-b5e6-
96231b3b80d8
James Y Knight [Thu, 10 Sep 2015 18:20:45 +0000 (18:20 +0000)]
[SPARC] Switch to the Machine Scheduler.
The (mostly-deprecated) SelectionDAG-based ILPListDAGScheduler scheduler
was making poor scheduling decisions, causing high register pressure and
extraneous register spills.
Switching to the newer machine scheduler generates better code -- even
without there being a machine model defined for SPARC yet.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247315
91177308-0d34-0410-b5e6-
96231b3b80d8
Matthew Simpson [Thu, 10 Sep 2015 18:12:47 +0000 (18:12 +0000)]
[SCEV] Consistently Handle Expressions That Cannot Be Divided
This patch addresses the issue of SCEV division asserting on some
input expressions (e.g., non-affine expressions) and quietly giving
up on others. When giving up, we set the quotient to be equal to
zero and the remainder to be equal to the numerator. With this
patch, we always quietly give up when we cannot perform the
division.
This patch also adds a test case for DependenceAnalysis that
previously caused an assertion.
Differential Revision: http://reviews.llvm.org/D11725
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247314
91177308-0d34-0410-b5e6-
96231b3b80d8
JF Bastien [Thu, 10 Sep 2015 18:08:35 +0000 (18:08 +0000)]
[MergeFuncs] Fix callsite attributes in thunk generation
This change correctly sets the attributes on the callsites
generated in thunks. This makes sure things such as sret, sext, etc.
are correctly set, so that the call can be a proper tailcall.
Also, the transfer of attributes in the replaceDirectCallers function
appears to be unnecessary, but until this is confirmed it will remain.
Author: jrkoenig
Reviewers: dschuff, jfb
Subscribers: llvm-commits, nlewycky
Differential revision: http://reviews.llvm.org/D12581
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247313
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Thu, 10 Sep 2015 18:03:45 +0000 (18:03 +0000)]
Tidy up some alias syntax to make explicit pointer type migration easier
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247312
91177308-0d34-0410-b5e6-
96231b3b80d8
Jordan Rose [Thu, 10 Sep 2015 17:55:02 +0000 (17:55 +0000)]
[CMake] s/LLVM_SOURCE_DIR/LLVM_MAIN_SRC_DIR/
Fix-up for r247305 to use the right variable. There's another use of
LLVM_SOURCE_DIR in this file that is probably also questionable, but it's
for Windows so I'm going to leave it alone.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247311
91177308-0d34-0410-b5e6-
96231b3b80d8
Philip Reames [Thu, 10 Sep 2015 17:44:47 +0000 (17:44 +0000)]
[SimplifyCFG] Use known bits to eliminate dead switch defaults
This is a follow up to http://reviews.llvm.org/D11995 implementing the suggestion by Hans.
If we know some of the bits of the value being switched on, we know that the maximum number of unique cases covers the unknown bits. This allows to eliminate switch defaults for large integers (i32) when most bits in the value are known.
Note that I had to make the transform contingent on not having any dead cases. This is conservatively correct with the old code, but required for the new code since we might have a dead case which varies one of the known bits. Counting that towards our number of covering cases would be bad. If we do have dead cases, we'll eliminate them first, then revisit the possibly dead default.
Differential Revision: http://reviews.llvm.org/D12497
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247309
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Bieneman [Thu, 10 Sep 2015 17:28:51 +0000 (17:28 +0000)]
[CMake] Add DARWIN_LTO_LIBRARY option to allow overriding -lto_library.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247308
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Bieneman [Thu, 10 Sep 2015 17:23:32 +0000 (17:23 +0000)]
[CMake] Allow LLVM_TOOLCHAIN_TOOLS to be overridden
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247306
91177308-0d34-0410-b5e6-
96231b3b80d8
Jordan Rose [Thu, 10 Sep 2015 17:18:51 +0000 (17:18 +0000)]
[CMake] Fix Xcode build with LLVM_ENABLE_OBJLIB.
This amends chapuni's r246156 to handle an Xcode quirk, one even called out
in the CMake documentation:
Some native build systems may not like targets that have only object files,
so consider adding at least one real source file to any target that
references $<TARGET_OBJECTS:objlib>.
I've limited the scope of this hack to Xcode for now.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247305
91177308-0d34-0410-b5e6-
96231b3b80d8
Adrian Prantl [Thu, 10 Sep 2015 17:13:58 +0000 (17:13 +0000)]
Debug Info: Allow a DIModule to appear as the scope of other entities.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247304
91177308-0d34-0410-b5e6-
96231b3b80d8
Philip Reames [Thu, 10 Sep 2015 17:03:10 +0000 (17:03 +0000)]
[docs][PerformanceTips] Add text on allocas and alignment
This summarizes two recent llvm-dev discussions. Most of the text provided by David Chisnall and Benoit Belley with minor editting by me.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247301
91177308-0d34-0410-b5e6-
96231b3b80d8
Kostya Serebryany [Thu, 10 Sep 2015 16:57:57 +0000 (16:57 +0000)]
[libFuzzer] add two more variants of FuzzerDriver for convenience
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247300
91177308-0d34-0410-b5e6-
96231b3b80d8
Joseph Tremoulet [Thu, 10 Sep 2015 16:51:25 +0000 (16:51 +0000)]
[WinEH] Fix single-block cleanup coloring
Summary:
The coloring code in WinEHPrepare queues cleanuprets' successors with the
correct color (the parent one) when it sees their cleanuppad, and so later
when iterating successors knows to skip processing cleanuprets since
they've already been queued. This latter check was incorrectly under an
'else' condition and so inadvertently was not kicking in for single-block
cleanups. This change sinks the check out of the 'else' to fix the bug.
Reviewers: majnemer, andrew.w.kaylor, rnk
Subscribers: llvm-commits
Differential Revision: http://reviews.llvm.org/D12751
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247299
91177308-0d34-0410-b5e6-
96231b3b80d8
Hans Wennborg [Thu, 10 Sep 2015 16:49:58 +0000 (16:49 +0000)]
Re-commit r247216: "Fix Clang-tidy misc-use-override warnings, other minor fixes"
Except the changes that defined virtual destructors as =default, because that
ran into problems with GCC 4.7 and overriding methods that weren't noexcept.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247298
91177308-0d34-0410-b5e6-
96231b3b80d8
Steven Wu [Thu, 10 Sep 2015 16:32:28 +0000 (16:32 +0000)]
Fix an undefined behavior introduces in r247234
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247296
91177308-0d34-0410-b5e6-
96231b3b80d8
Sanjay Patel [Thu, 10 Sep 2015 16:31:19 +0000 (16:31 +0000)]
80-cols; NFC
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247295
91177308-0d34-0410-b5e6-
96231b3b80d8
Sanjay Patel [Thu, 10 Sep 2015 16:25:38 +0000 (16:25 +0000)]
use range-based for loop; NFCI
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247294
91177308-0d34-0410-b5e6-
96231b3b80d8
Sanjay Patel [Thu, 10 Sep 2015 16:15:21 +0000 (16:15 +0000)]
use range-based for loop; NFCI
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247293
91177308-0d34-0410-b5e6-
96231b3b80d8
Vedant Kumar [Thu, 10 Sep 2015 16:02:24 +0000 (16:02 +0000)]
[Bitcode] Add xfail test for PR24755 (uselistorder)
This test stresses verify-uselistorder. PR24755 is caused by our
ignoring uses when they occur in the function personality slot, the
prologue data slot, or the prefix data slot.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247292
91177308-0d34-0410-b5e6-
96231b3b80d8
Sanjay Patel [Thu, 10 Sep 2015 15:14:34 +0000 (15:14 +0000)]
fix typo; NFC
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247287
91177308-0d34-0410-b5e6-
96231b3b80d8
Alex Lorenz [Thu, 10 Sep 2015 14:04:34 +0000 (14:04 +0000)]
Fix PR 24724 - The implicit register verifier shouldn't assume certain operand
order.
The implicit register verifier in the MIR parser should only check if the
instruction's default implicit operands are present in the instruction. It
should not check the order in which they occur.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247283
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Thu, 10 Sep 2015 13:44:28 +0000 (13:44 +0000)]
Cleaning up LLVM IR mode for Emacs.
I've made a range of improvements to the Emacs mode for LLVM IR.
Most importantly, it changes llvm-mode to inherit from prog-mode. This
means llvm-mode will be treated as a normal programming mode in Emacs,
so many Emacs features will just work. prog-mode is new to Emacs 24,
so I've added an alias to ensure compatibility with Emacs 23 too.
I've changed the mode definition to use define-derived-mode. This
saves us needing to set up local variables ourselves, and saves us
needing to define llvm-mode-map, llvm-mode-abbrev-table,
llvm-mode-map.
I've removed the keybindings to tab-to-tab-stop, center-line and
center-paragraph. This shouldn't be llvm-mode's responsibility, and
the code didn't actually work anyway (since `(not llvm-mode-map)`
always evaluated to `t`, the keybindings were never executed).
I've simplified the syntax-table definition, it's equivalent (e.g. `"`
is treated as string delimiter by default in Emacs). I've added `.` as
a symbol constituent, so functions like `llvm.memset.p0i8.i32` are
recognised as a single symbol. I've also changed `%` to be a symbol
constituent, so users can move between words or symbols at their
choice, rather than conflating the two.
I've fixed regexp for types, which incorrect used `symbol` instead of
`symbols` as an argument to `regexp-opt`. This was causing incorrect
highlighting on lines like `call void @foovoid`.
I've removed string and comment highlighting from
`llvm-font-lock-keywords`. This is already handled by the
syntax-table.
Finally, I've removed the reference to jasmin. That project is long
abandoned and the link 404s. For reference, I've found an old copy of
the project here:
https://github.com/stevej/emacs/blob/master/vendor/jasmin/jasmin.el
Patch by Wilfred Hughes!
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247281
91177308-0d34-0410-b5e6-
96231b3b80d8
Igor Breger [Thu, 10 Sep 2015 12:54:54 +0000 (12:54 +0000)]
AVX512: Implemented encoding and intrinsics for
vextracti64x4 ,vextracti64x2, vextracti32x8, vextracti32x4, vextractf64x4, vextractf64x2, vextractf32x8, vextractf32x4
Added tests for intrinsics and encoding.
Differential Revision: http://reviews.llvm.org/D11802
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247276
91177308-0d34-0410-b5e6-
96231b3b80d8
Aaron Ballman [Thu, 10 Sep 2015 12:53:40 +0000 (12:53 +0000)]
Silencing C4141 warnings that were introduced en masse because __forceinline cannot be combined with inline in MSVC without triggering this diagnostic. This is safe to disable because clang will catch instances of the issue with -Wduplicate-decl-specifier, so we are not losing diagnostic coverage.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247275
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Thu, 10 Sep 2015 11:59:55 +0000 (11:59 +0000)]
[FileCheck] Use range-based for loops. NFC.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247272
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakub Kuderski [Thu, 10 Sep 2015 11:31:20 +0000 (11:31 +0000)]
There is a trunc(lshr (zext A), Cst) optimization in InstCombineCasts that
removes cast by performing the lshr on smaller types. However, currently there
is no trunc(lshr (sext A), Cst) variant.
This patch add such optimization by transforming trunc(lshr (sext A), Cst)
to ashr A, Cst.
Differential Revision: http://reviews.llvm.org/D12520
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247271
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Thu, 10 Sep 2015 11:17:49 +0000 (11:17 +0000)]
[ADT] Rewrite the StringRef::find implementation to be simpler, clearer,
and tremendously less reliant on the optimizer to fix things.
The code is always necessarily looking for the entire length of the
string when doing the equality tests in this find implementation, but it
previously was needlessly re-checking the size each time among other
annoyances.
By writing this so simply an ddirectly in terms of memcmp, it also is
about 8x faster in a debug build, which in turn makes FileCheck about 2x
faster in 'ninja check-llvm'. This saves about 8% of the time for
FileCheck-heavy parts of the test suite like the x86 backend tests.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247269
91177308-0d34-0410-b5e6-
96231b3b80d8
Silviu Baranga [Thu, 10 Sep 2015 10:34:34 +0000 (10:34 +0000)]
[DAGCombine] Truncate BUILD_VECTOR operators if necessary when constant folding vectors
Summary:
The BUILD_VECTOR node will truncate its operators to match the
type. We need to take this into account when constant folding -
we need to perform a truncation before constant folding the elements.
This is because the upper bits can change the result, depending on
the operation type (for example this is the case for min/max).
This change also adds a regression test.
Reviewers: jmolloy
Subscribers: jmolloy, llvm-commits
Differential Revision: http://reviews.llvm.org/D12697
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247265
91177308-0d34-0410-b5e6-
96231b3b80d8
James Molloy [Thu, 10 Sep 2015 10:22:20 +0000 (10:22 +0000)]
Enable GlobalsAA by default
This can give significant improvements to alias analysis in some situations, and improves its testing coverage in all situations.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247264
91177308-0d34-0410-b5e6-
96231b3b80d8
James Molloy [Thu, 10 Sep 2015 10:22:12 +0000 (10:22 +0000)]
Add GlobalsAA as preserved to a bunch of transforms
GlobalsAA must by definition be preserved in function passes, but the passmanager doesn't know that. Make each pass explicitly preserve GlobalsAA.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247263
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Thu, 10 Sep 2015 09:46:47 +0000 (09:46 +0000)]
[ADT] Force inline several super boring and unusually hot methods on
SmallVector to further help debug builds not waste their time calling
one line functions.
To give you an idea of why this is worthwhile, this change alone gets
another >10% reduction in the runtime of TripleTest.Normalization! It's
now under 9 seconds for me. Sadly, this is the end of the easy wins for
that test. Anything further will require some different architecture of
the test itself. Still, I'm pretty happy. 'check-llvm' now is under 35s
for me.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247259
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Thu, 10 Sep 2015 09:25:59 +0000 (09:25 +0000)]
[ADT] Micro-optimize and force inlining for string switches.
These are now quite heavily used in unit tests and the host tools,
making it worth having them be reasonably fast even in an unoptimized
build. This change reduces the total runtime of TripleTest.Normalization
by yet another 10% to 15%. It is now under 10 seconds on my machine, and
the total check-llvm time has dropped from 38s to around 36s.
I experimented with a number of different options, and the code pattern
here consistently seemed to lower the cleanest, likely due to the
significantly simple CFG and far fewer redundant tests of 'Result'.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247257
91177308-0d34-0410-b5e6-
96231b3b80d8
James Molloy [Thu, 10 Sep 2015 08:42:28 +0000 (08:42 +0000)]
[ARM] Do not use vtrn for vectorshuffle if the order is reversed
The tests in isVTRNMask and isVTRN_v_undef_Mask should also check that the elements of the upper and lower half of the vectorshuffle occur in the correct order when both halves are used. Without this test the code assumes that it is correct to use vector transpose (vtrn) for the masks <1, 1, 0, 0> and <1, 3, 0, 2>, among others, but the transpose actually incorrectly generates shuffles for <0, 0, 1, 1> and <0, 2, 1, 3> in this case.
Patch by Jeroen Ketema!
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247254
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Thu, 10 Sep 2015 08:29:35 +0000 (08:29 +0000)]
[ADT] Apply a large hammer to StringRef functions: attribute always_inline.
The logic of this follows something Howard does in libc++ and something
I discussed with Chris eons ago -- for a lot of functions, there is
really no benefit to preserving "debug information" by leaving the
out-of-line even in debug builds. This is especially true as we now do
a very good job of preserving most debug information even in the face of
inlining. There are a bunch of methods in StringRef that we are paying
a completely unacceptable amount for with every debug build of every
LLVM developer.
Some day, we should fix Clang/LLVM so that developers can reasonable
use a default of something other than '-O0' and not waste their lives
waiting on *completely* unoptimized code to execute. We should have
a default that doesn't impede debugging while providing at least
plausable performance.
But today is not that day.
So today, I'm applying always_inline to the functions that are really
hurting the critical path for stuff like 'check_llvm'. I'm being very
cautious here, but there are a few other APIs that we really should do
this for as a matter of pragmatism. Hopefully we can rip this out some
day.
With this change, TripleTest.Normalization runtime decreases by over
10%, and the total 'check-llvm' time on my 48-core box goes from 38s to
just under 37s.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247253
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Thu, 10 Sep 2015 08:29:30 +0000 (08:29 +0000)]
[Support] Fix the always_inline attribute macro to not include the
'inline' specifier. That specifier may or may not be valid for a given
function, or it may be required for correct linkage even when the
compiler doesn't support the always_inline attribute.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247252
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Thu, 10 Sep 2015 07:51:43 +0000 (07:51 +0000)]
[ADT] Micro-optimize the Triple constructor by doing a single split and
re-using the resulting components rather than repeatedly splitting and
re-splitting to compute each component as part of the initializer list.
This is more work on PR23676. Sadly, it doesn't help much. It removes
the constructor from my profile, but doesn't make a sufficient dent in
the total time. But it should play together nicely with subsequent
changes.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247250
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Thu, 10 Sep 2015 07:51:37 +0000 (07:51 +0000)]
[ADT] Fix a confusing interface spec and some annoying peculiarities
with the StringRef::split method when used with a MaxSplit argument
other than '-1' (which nobody really does today, but which should
actually work).
The spec claimed both to split up to MaxSplit times, but also to append
<= MaxSplit strings to the vector. One of these doesn't make sense.
Given the name "MaxSplit", let's go with it being a max over how many
*splits* occur, which means the max on how many strings get appended is
MaxSplit+1. I'm not actually sure the implementation correctly provided
this logic either, as it used a really opaque loop structure.
The implementation was also playing weird games with nullptr in the data
field to try to rely on a totally opaque hidden property of the split
method that returns a pair. Nasty IMO.
Replace all of this with what is (IMO) simpler code that doesn't use the
pair returning split method, and instead just finds each separator and
appends directly. I think this is a lot easier to read, and it most
definitely matches the spec. Added some tests that exercise the corner
cases around StringRef() and StringRef("") that all now pass.
I'll start using this in code in the next commit.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247249
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Thu, 10 Sep 2015 07:16:42 +0000 (07:16 +0000)]
GlobalsAAResult(&&): Move every members.
Or, one of MSVC builders failed with unexpected behavior.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247247
91177308-0d34-0410-b5e6-
96231b3b80d8
Elena Demikhovsky [Thu, 10 Sep 2015 06:33:13 +0000 (06:33 +0000)]
Added isUndef() interface for SDNode
Differential Revision: http://reviews.llvm.org/D12720
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247246
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Thu, 10 Sep 2015 06:12:31 +0000 (06:12 +0000)]
[ADT] Switch a bunch of places in LLVM that were doing single-character
splits to actually use the single character split routine which does
less work, and in a debug build is *substantially* faster.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247245
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Thu, 10 Sep 2015 06:07:03 +0000 (06:07 +0000)]
[ADT] Add a single-character version of the small vector split routine
on StringRef. Finding and splitting on a single character is
substantially faster than doing it on even a single character StringRef
-- we immediately get to a *very* tuned memchr call this way.
Even nicer, we get to this even in a debug build, shaving 18% off the
runtime of TripleTest.Normalization, helping PR23676 some more.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247244
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Thu, 10 Sep 2015 05:47:43 +0000 (05:47 +0000)]
Add a way to skip the Go bindings tests even when Go is configured in
CMake.
The Go bindings tests in an unoptimized build take over 30 seconds for
me, making it the slowest test in 'check-llvm' by a factor of two.
I've only rigged this up fully to the CMake build. If someone is
interested in rigging it up to the autoconf build, they're welcome to do
so.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247243
91177308-0d34-0410-b5e6-
96231b3b80d8
Sanjoy Das [Thu, 10 Sep 2015 05:27:38 +0000 (05:27 +0000)]
[ScalarEvolution] Fix PR24757.
Summary:
PR24757 was caused by some incorect math in
`ScalarEvolution::HowFarToZero` -- the smallest unsigned solution for X
in
2^N * A = 2^N * X
is not necessarily A.
Reviewers: atrick, majnemer, meheff
Subscribers: llvm-commits, sanjoy
Differential Revision: http://reviews.llvm.org/D12721
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247242
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Thu, 10 Sep 2015 04:22:36 +0000 (04:22 +0000)]
[LPM] Simplify this code and fix a compile error for compilers that
don't correctly implement the scoping rules of C++11 range based for
loops. This kind of aliasing isn't a good idea anyways (and wasn't
really intended).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247241
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Thu, 10 Sep 2015 02:31:42 +0000 (02:31 +0000)]
[LPM] Use a map from analysis ID to immutable passes in the legacy pass
manager to avoid a slow linear scan of every immutable pass and on every
attempt to find an analysis pass.
This speeds up 'check-llvm' on an unoptimized build for me by 15%, YMMV.
It should also help (a tiny bit) other folks that are really
bottlenecked on repeated runs of tiny pass pipelines across small IR
files.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247240
91177308-0d34-0410-b5e6-
96231b3b80d8
Kit Barton [Thu, 10 Sep 2015 01:55:44 +0000 (01:55 +0000)]
Enable the shrink wrapping optimization for PPC64.
The changes in this patch are as follows:
1. Modify the emitPrologue and emitEpilogue methods to work properly when the prologue and epilogue blocks are not the first/last blocks in the function
2. Fix a bug in PPCEarlyReturn optimization caused by an empty entry block in the function
3. Override the runShrinkWrap PredicateFtor (defined in TargetMachine) to check whether shrink wrapping should run:
Shrink wrapping will run on PPC64 (Little Endian and Big Endian) unless -enable-shrink-wrap=false is specified on command line
A new test case, ppc-shrink-wrapping.ll was created based on the existing shrink wrapping tests for x86, arm, and arm64.
Phabricator review: http://reviews.llvm.org/D11817
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247237
91177308-0d34-0410-b5e6-
96231b3b80d8
Ahmed Bougacha [Thu, 10 Sep 2015 01:54:43 +0000 (01:54 +0000)]
[AArch64] Match FI+offset in STNP addressing mode.
First, we need to teach isFrameOffsetLegal about STNP.
It already knew about the STP/LDP variants, but those were probably
never exercised, because it's only the load/store optimizer that
generates STP/LDP, and the only user of the method is frame lowering,
which runs earlier.
The STP/LDP cases were wrong: they didn't take into account the fact
that they return two results, not one, so the immediate offset will be
the 4th operand, not the 3rd.
Follow-up to r247234.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247236
91177308-0d34-0410-b5e6-
96231b3b80d8
Davide Italiano [Thu, 10 Sep 2015 01:50:00 +0000 (01:50 +0000)]
[MC] Convert all the remaining tests from macho-dump to llvm-readobj.
This sort-of deprecates macho-dump. It may take still a little while
to garbage collect it, but at least there's no real usage of it in
the tree anymore. New tests should always rely on llvm-readobj or
llvm-objdump.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247235
91177308-0d34-0410-b5e6-
96231b3b80d8
Ahmed Bougacha [Thu, 10 Sep 2015 01:48:29 +0000 (01:48 +0000)]
[AArch64] Match base+offset in STNP addressing mode.
Followup to r247231.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247234
91177308-0d34-0410-b5e6-
96231b3b80d8
Mehdi Amini [Thu, 10 Sep 2015 01:45:55 +0000 (01:45 +0000)]
Makes EmitRecord() accepting ArrayRef and raw array (NFC)
After r247186, a vector is no longer needed as the push_front for
the code is removed.
From: Mehdi Amini <mehdi.amini@apple.com>
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247232
91177308-0d34-0410-b5e6-
96231b3b80d8
Ahmed Bougacha [Thu, 10 Sep 2015 01:42:28 +0000 (01:42 +0000)]
[AArch64] Support selecting STNP.
We could go through the load/store optimizer and match STNP where
we would have matched a nontemporal-annotated STP, but that's not
reliable enough, as an opportunistic optimization.
Insetad, we can guarantee emitting STNP, by matching them at ISel.
Since there are no single-input nontemporal stores, we have to
resort to some high-bits-extracting trickery to generate an STNP
from a plain store.
Also, we need to support another, LDP/STP-specific addressing mode,
base + signed scaled 7-bit immediate offset.
For now, only match the base. Let's make it smart separately.
Part of PR24086.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247231
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Thu, 10 Sep 2015 01:23:28 +0000 (01:23 +0000)]
AMDGPU/SI: Fix more cases of losing exec operands
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247230
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Thu, 10 Sep 2015 01:06:06 +0000 (01:06 +0000)]
AMDGPU/SI: Fix creating v_mov_b32s without exec uses
This will be caught by existing tests with a
verifier check to be added in a future commit.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247229
91177308-0d34-0410-b5e6-
96231b3b80d8
Hans Wennborg [Thu, 10 Sep 2015 00:57:26 +0000 (00:57 +0000)]
Revert r247216: "Fix Clang-tidy misc-use-override warnings, other minor fixes"
This caused build breakges, e.g.
http://lab.llvm.org:8011/builders/clang-x86_64-ubuntu-gdb-75/builds/24926
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247226
91177308-0d34-0410-b5e6-
96231b3b80d8
Ahmed Bougacha [Thu, 10 Sep 2015 00:53:15 +0000 (00:53 +0000)]
[CodeGen] Make x86 nontemporal store patfrags generic. NFC.
To be used by other targets.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247225
91177308-0d34-0410-b5e6-
96231b3b80d8
Philip Reames [Thu, 10 Sep 2015 00:44:10 +0000 (00:44 +0000)]
[RewriteStatepointsForGC] Minor refactor to use shared implementation [NFC]
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247223
91177308-0d34-0410-b5e6-
96231b3b80d8
Philip Reames [Thu, 10 Sep 2015 00:32:56 +0000 (00:32 +0000)]
[RewriteStatepointsForGC] Strengthen a confusingly weak assertion [NFC]
The assertion was weaker than it should be and gave the impression we're growing the number of base defining values being considered during the fixed point interation. That's not true. The tighter form of the assert is useful documentation.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247221
91177308-0d34-0410-b5e6-
96231b3b80d8
Philip Reames [Thu, 10 Sep 2015 00:27:50 +0000 (00:27 +0000)]
[RewriteStatepointsForGC] One last bit of naming [NFCI]
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247220
91177308-0d34-0410-b5e6-
96231b3b80d8
Reid Kleckner [Thu, 10 Sep 2015 00:25:23 +0000 (00:25 +0000)]
[WinEH] Add codegen support for cleanuppad and cleanupret
All of the complexity is in cleanupret, and it mostly follows the same
codepaths as catchret, except it doesn't take a return value in RAX.
This small example now compiles and executes successfully on win32:
extern "C" int printf(const char *, ...) noexcept;
struct Dtor {
~Dtor() { printf("~Dtor\n"); }
};
void has_cleanup() {
Dtor o;
throw 42;
}
int main() {
try {
has_cleanup();
} catch (int) {
printf("caught it\n");
}
}
Don't try to put the cleanup in the same function as the catch, or Bad
Things will happen.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247219
91177308-0d34-0410-b5e6-
96231b3b80d8
Philip Reames [Thu, 10 Sep 2015 00:22:49 +0000 (00:22 +0000)]
[RewriteStatepointsForGC] Further style/naming fixup [NFCI]
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247217
91177308-0d34-0410-b5e6-
96231b3b80d8
Hans Wennborg [Thu, 10 Sep 2015 00:12:56 +0000 (00:12 +0000)]
Fix Clang-tidy misc-use-override warnings, other minor fixes
Patch by Eugene Zelenko!
Differential Revision: http://reviews.llvm.org/D12740
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247216
91177308-0d34-0410-b5e6-
96231b3b80d8
Mehdi Amini [Thu, 10 Sep 2015 00:05:09 +0000 (00:05 +0000)]
Bitcode Writer: EmitRecordWith* takes an ArrayRef instead of a SmallVector (NFC)
This reapply commit r247178 after post-commit review from D.Blaikie
in a way that makes it compatible with the existing API.
From: Mehdi Amini <mehdi.amini@apple.com>
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247215
91177308-0d34-0410-b5e6-
96231b3b80d8
Mehdi Amini [Thu, 10 Sep 2015 00:05:04 +0000 (00:05 +0000)]
Add makeArrayRef() overload for ArrayRef input (no-op/identity) NFC
The purpose is to allow templated wrapper to work with either
ArrayRef or any convertible operation:
template<typename Container>
void wrapper(const Container &Arr) {
impl(makeArrayRef(Arr));
}
with Container being a std::vector, a SmallVector, or an ArrayRef.
From: Mehdi Amini <mehdi.amini@apple.com>
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247214
91177308-0d34-0410-b5e6-
96231b3b80d8
Philip Reames [Thu, 10 Sep 2015 00:01:53 +0000 (00:01 +0000)]
[RewriteStatepointsForGC] More naming cleanup [NFCI]
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247213
91177308-0d34-0410-b5e6-
96231b3b80d8
Philip Reames [Wed, 9 Sep 2015 23:57:18 +0000 (23:57 +0000)]
[RewriteStatepointsForGC] Code cleanup [NFC]
Factor out common code related to naming values, fix a small style issue. More to follow in separate changes.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247211
91177308-0d34-0410-b5e6-
96231b3b80d8
Philip Reames [Wed, 9 Sep 2015 23:40:12 +0000 (23:40 +0000)]
[RewriteStatepointsForGC] Extend base pointer inference to handle insertelement
This change is simply enhancing the existing inference algorithm to handle insertelement instructions by conservatively inserting a new instruction to propagate the vector of associated base pointers. In the process, I'm ripping out the peephole optimizations which mostly helped cover the fact this hadn't been done.
Note that most of the newly inserted nodes will be nearly immediately removed by the post insertion optimization pass introduced in 246718. Arguably, we should be trying harder to avoid the malloc traffic here, but I'd rather get the code correct, then worry about compile time.
Unlike previous extensions of the algorithm to handle more case, I discovered the existing code was causing miscompiles in some cases. In particular, we had an implicit assumption that the peephole covered *all* insert element instructions, so if we had a value directly based on a insert element the peephole didn't cover, we proceeded as if it were a base anyways. Not good. I believe we had the same issue with shufflevector which is why I adjusted the predicate for them as well.
Differential Revision: http://reviews.llvm.org/D12583
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247210
91177308-0d34-0410-b5e6-
96231b3b80d8
Philip Reames [Wed, 9 Sep 2015 23:26:08 +0000 (23:26 +0000)]
[RewriteStatepointsForGC] Make base pointer inference deterministic
Previously, the base pointer algorithm wasn't deterministic. The core fixed point was (of course), but we were inserting new nodes and optimizing them in an order which was unspecified and variable. We'd somewhat hacked around this for testing by sorting by value name, but that doesn't solve the general determinism problem.
Instead, we can use the order of traversal over the def/use graph to give us a single consistent ordering. Today, this is a DFS order, but the exact order doesn't mater provided it's deterministic for a given input.
(Q: It is safe to rely on a deterministic order of operands right?)
Note that this only fixes the determinism within a single inference step. The inference step is currently invoked many times in a non-deterministic order. That's a future change in the sequence. :)
Differential Revision: http://reviews.llvm.org/D12640
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247208
91177308-0d34-0410-b5e6-
96231b3b80d8
Peter Collingbourne [Wed, 9 Sep 2015 22:30:32 +0000 (22:30 +0000)]
LowerBitSets: Fix non-determinism bug.
Visit disjoint sets in a deterministic order based on the maximum BitSetNM
index, otherwise the order in which we visit them will depend on pointer
comparisons. This was being exposed by MSan.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247201
91177308-0d34-0410-b5e6-
96231b3b80d8
Reid Kleckner [Wed, 9 Sep 2015 21:10:03 +0000 (21:10 +0000)]
[SEH] Emit 32-bit SEH tables for the new EH IR
The 32-bit tables don't actually contain PC range data, so emitting them
is incredibly simple.
The 64-bit tables, on the other hand, use the same table for state
numbering as well as label ranges. This makes things more difficult, so
it will be implemented later.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247192
91177308-0d34-0410-b5e6-
96231b3b80d8
Dan Gohman [Wed, 9 Sep 2015 20:54:31 +0000 (20:54 +0000)]
[WebAssembly] Update target datalayout strings.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247187
91177308-0d34-0410-b5e6-
96231b3b80d8
Teresa Johnson [Wed, 9 Sep 2015 20:53:31 +0000 (20:53 +0000)]
Change EmitRecordWithAbbrevImpl to take Optional record code. NFC.
This change enables EmitRecord to pass the supplied record Code to
EmitRecordWithAbbrevImpl, rather than insert it into the Vals array.
It is an enabler for changing EmitRecord to take an ArrayRef<uintty> instead
of a SmallVectorImpl<uintty>&
Patch suggested by Duncan P. N. Exon Smith, modified by myself a bit to get
correct assertion checking.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247186
91177308-0d34-0410-b5e6-
96231b3b80d8
Piotr Padlewski [Wed, 9 Sep 2015 20:47:30 +0000 (20:47 +0000)]
ScalarEvolution assume hanging bugfix
http://reviews.llvm.org/D12719
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247184
91177308-0d34-0410-b5e6-
96231b3b80d8
Mehdi Amini [Wed, 9 Sep 2015 20:35:15 +0000 (20:35 +0000)]
Revert "Bitcode Writer: EmitRecordWith* takes an ArrayRef instead of a SmallVector (NFC)"
This reverts commit r247178.
From: Mehdi Amini <mehdi.amini@apple.com>
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247182
91177308-0d34-0410-b5e6-
96231b3b80d8
David Majnemer [Wed, 9 Sep 2015 20:20:08 +0000 (20:20 +0000)]
Revert trunc(lshr (sext A), Cst) to ashr A, Cst
This reverts commit r246997, it introduced a regression (PR24763).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247180
91177308-0d34-0410-b5e6-
96231b3b80d8
Mehdi Amini [Wed, 9 Sep 2015 20:08:39 +0000 (20:08 +0000)]
Bitcode Writer: EmitRecordWith* takes an ArrayRef instead of a SmallVector (NFC)
From: Mehdi Amini <mehdi.amini@apple.com>
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247178
91177308-0d34-0410-b5e6-
96231b3b80d8
Renato Golin [Wed, 9 Sep 2015 19:44:40 +0000 (19:44 +0000)]
Revert "AVX512: Implemented encoding and intrinsics for vextracti64x4 ,vextracti64x2, vextracti32x8, vextracti32x4, vextractf64x4, vextractf64x2, vextractf32x8, vextractf32x4 Added tests for intrinsics and encoding."
This reverts commit r247149, as it was breaking numerous buildbots of varied architectures.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247177
91177308-0d34-0410-b5e6-
96231b3b80d8
Sanjay Patel [Wed, 9 Sep 2015 18:38:30 +0000 (18:38 +0000)]
allow unpredictable metadata on switch statements
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247174
91177308-0d34-0410-b5e6-
96231b3b80d8
Matthias Braun [Wed, 9 Sep 2015 18:08:03 +0000 (18:08 +0000)]
Save LaneMask with livein registers
With subregister liveness enabled we can detect the case where only
parts of a register are live in, this is expressed as a 32bit lanemask.
The current code only keeps registers in the live-in list and therefore
enumerated all subregisters affected by the lanemask. This turned out to
be too conservative as the subregister may also cover additional parts
of the lanemask which are not live. Expressing a given lanemask by
enumerating a minimum set of subregisters is computationally expensive
so the best solution is to simply change the live-in list to store the
lanemasks as well. This will reduce memory usage for targets using
subregister liveness and slightly increase it for other targets
Differential Revision: http://reviews.llvm.org/D12442
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247171
91177308-0d34-0410-b5e6-
96231b3b80d8
Matthias Braun [Wed, 9 Sep 2015 18:07:54 +0000 (18:07 +0000)]
VirtRegMap: Improve addMBBLiveIns() using SlotIndex::MBBIndexIterator; NFC
Now that we have an explicit iterator over the idx2MBBMap in SlotIndices
we can use the fact that segments and the idx2MBBMap is sorted by
SlotIndex position so can advance both simultaneously instead of
starting from the beginning for each segment.
This complicates the code for the subregister case somewhat but should
be more efficient and has the advantage that we get the final lanemask
for each block immediately which will be important for a subsequent
change.
Removes the now unused SlotIndexes::findMBBLiveIns function.
Differential Revision: http://reviews.llvm.org/D12443
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247170
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Wed, 9 Sep 2015 17:55:00 +0000 (17:55 +0000)]
[PM/AA] Rebuild LLVM's alias analysis infrastructure in a way compatible
with the new pass manager, and no longer relying on analysis groups.
This builds essentially a ground-up new AA infrastructure stack for
LLVM. The core ideas are the same that are used throughout the new pass
manager: type erased polymorphism and direct composition. The design is
as follows:
- FunctionAAResults is a type-erasing alias analysis results aggregation
interface to walk a single query across a range of results from
different alias analyses. Currently this is function-specific as we
always assume that aliasing queries are *within* a function.
- AAResultBase is a CRTP utility providing stub implementations of
various parts of the alias analysis result concept, notably in several
cases in terms of other more general parts of the interface. This can
be used to implement only a narrow part of the interface rather than
the entire interface. This isn't really ideal, this logic should be
hoisted into FunctionAAResults as currently it will cause
a significant amount of redundant work, but it faithfully models the
behavior of the prior infrastructure.
- All the alias analysis passes are ported to be wrapper passes for the
legacy PM and new-style analysis passes for the new PM with a shared
result object. In some cases (most notably CFL), this is an extremely
naive approach that we should revisit when we can specialize for the
new pass manager.
- BasicAA has been restructured to reflect that it is much more
fundamentally a function analysis because it uses dominator trees and
loop info that need to be constructed for each function.
All of the references to getting alias analysis results have been
updated to use the new aggregation interface. All the preservation and
other pass management code has been updated accordingly.
The way the FunctionAAResultsWrapperPass works is to detect the
available alias analyses when run, and add them to the results object.
This means that we should be able to continue to respect when various
passes are added to the pipeline, for example adding CFL or adding TBAA
passes should just cause their results to be available and to get folded
into this. The exception to this rule is BasicAA which really needs to
be a function pass due to using dominator trees and loop info. As
a consequence, the FunctionAAResultsWrapperPass directly depends on
BasicAA and always includes it in the aggregation.
This has significant implications for preserving analyses. Generally,
most passes shouldn't bother preserving FunctionAAResultsWrapperPass
because rebuilding the results just updates the set of known AA passes.
The exception to this rule are LoopPass instances which need to preserve
all the function analyses that the loop pass manager will end up
needing. This means preserving both BasicAAWrapperPass and the
aggregating FunctionAAResultsWrapperPass.
Now, when preserving an alias analysis, you do so by directly preserving
that analysis. This is only necessary for non-immutable-pass-provided
alias analyses though, and there are only three of interest: BasicAA,
GlobalsAA (formerly GlobalsModRef), and SCEVAA. Usually BasicAA is
preserved when needed because it (like DominatorTree and LoopInfo) is
marked as a CFG-only pass. I've expanded GlobalsAA into the preserved
set everywhere we previously were preserving all of AliasAnalysis, and
I've added SCEVAA in the intersection of that with where we preserve
SCEV itself.
One significant challenge to all of this is that the CGSCC passes were
actually using the alias analysis implementations by taking advantage of
a pretty amazing set of loop holes in the old pass manager's analysis
management code which allowed analysis groups to slide through in many
cases. Moving away from analysis groups makes this problem much more
obvious. To fix it, I've leveraged the flexibility the design of the new
PM components provides to just directly construct the relevant alias
analyses for the relevant functions in the IPO passes that need them.
This is a bit hacky, but should go away with the new pass manager, and
is already in many ways cleaner than the prior state.
Another significant challenge is that various facilities of the old
alias analysis infrastructure just don't fit any more. The most
significant of these is the alias analysis 'counter' pass. That pass
relied on the ability to snoop on AA queries at different points in the
analysis group chain. Instead, I'm planning to build printing
functionality directly into the aggregation layer. I've not included
that in this patch merely to keep it smaller.
Note that all of this needs a nearly complete rewrite of the AA
documentation. I'm planning to do that, but I'd like to make sure the
new design settles, and to flesh out a bit more of what it looks like in
the new pass manager first.
Differential Revision: http://reviews.llvm.org/D12080
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247167
91177308-0d34-0410-b5e6-
96231b3b80d8
Matthias Braun [Wed, 9 Sep 2015 17:49:46 +0000 (17:49 +0000)]
MachineVerifier: Check that SlotIndex MBBIndexList is sorted.
This introduces a check that the MBBIndexList is sorted as proposed in
http://reviews.llvm.org/D12443 but split up into a separate commit.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247166
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Wed, 9 Sep 2015 17:03:29 +0000 (17:03 +0000)]
AMDGPU: Extract full 64-bit subregister and use subregs
Instead of extracting both 32-bit components from the 128-bit
register. This produces fewer copies and is easier for
the copy peephole optimizer to understand and see the actual uses
as extracts from a reg_sequence.
This avoids needing to handle subregister composing in the
PeepholeOptimizer's ValueTracker for this case.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247162
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Wed, 9 Sep 2015 17:03:18 +0000 (17:03 +0000)]
AMDGPU: Remove unused multiclass argument
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247161
91177308-0d34-0410-b5e6-
96231b3b80d8
Tom Stellard [Wed, 9 Sep 2015 16:39:30 +0000 (16:39 +0000)]
llvm-config: Add --build-system option
Summary:
This can be used for distinguishing between cmake and autoconf builds.
Users may need this in order to handle inconsistencies between the
outputs of the two build systems.
Reviewers: echristo, chandlerc, beanz
Subscribers: llvm-commits
Differential Revision: http://reviews.llvm.org/D11838
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247159
91177308-0d34-0410-b5e6-
96231b3b80d8
Dan Gohman [Wed, 9 Sep 2015 16:13:47 +0000 (16:13 +0000)]
[WebAssembly] Implement calls with void return types.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247158
91177308-0d34-0410-b5e6-
96231b3b80d8
Tom Stellard [Wed, 9 Sep 2015 15:43:26 +0000 (15:43 +0000)]
AMDGPU/SI: Fold operands through REG_SEQUENCE instructions
Summary:
This helps mostly when we use add instructions for address calculations
that contain immediates.
Reviewers: arsenm
Subscribers: arsenm, llvm-commits
Differential Revision: http://reviews.llvm.org/D12256
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247157
91177308-0d34-0410-b5e6-
96231b3b80d8
Silviu Baranga [Wed, 9 Sep 2015 15:35:02 +0000 (15:35 +0000)]
[CostModel][AArch64] Remove amortization factor for some of the vector select instructions
Summary:
We are not scalarizing the wide selects in codegen for i16 and i32 and
therefore we can remove the amortization factor. We still have issues
with i64 vectors in codegen though.
Reviewers: mcrosier
Subscribers: mcrosier, aemerson, llvm-commits, rengolin
Differential Revision: http://reviews.llvm.org/D12724
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247156
91177308-0d34-0410-b5e6-
96231b3b80d8