Greg Kroah-Hartman [Sun, 13 Jul 2014 01:00:44 +0000 (18:00 -0700)]
staging: lustre: remove LL_PROC_PROTO macro
Spell out what is happening with the proc file functions, it helps to
unwind the call chain mess here.
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: hpdd-discuss <hpdd-discuss@lists.01.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 12 Jul 2014 19:12:45 +0000 (20:12 +0100)]
staging: vt6656: baseband.c rename abyVT3184_VT3226D0 to vnt_vt3184_vt3226d0
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 12 Jul 2014 19:12:44 +0000 (20:12 +0100)]
staging: vt6656: baseband.c remame abyVT3184_AL2230 to vnt_vt3184_al2230
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 12 Jul 2014 19:12:43 +0000 (20:12 +0100)]
staging: vt6656: baseband.c rename abyVT3184_AGC to vnt_vt3184_agc
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 12 Jul 2014 19:12:42 +0000 (20:12 +0100)]
staging: vt6656: baseband clean up VT3184 static variables
Remove white space comments and arrange 8 bytes wide
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 12 Jul 2014 10:30:03 +0000 (11:30 +0100)]
staging: vt6656: rf.c cleanup comments
named comments are already referenced in revision history
in high-level comment.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 12 Jul 2014 10:30:02 +0000 (11:30 +0100)]
staging: vt6656: vnt_rf_write_embedded add reg length and IFREGCTL_REGW
The rf register always have *_REG_LEN and IFREGCTL_REGW macros added.
*_REG_LEN is always 23(0x17) replace them with VNT_RF_REG_LEN.
Remove *_REG_LEN and IFREGCTL_REGW from tables and vnt_rf_set_txpower and
apply VNT_RF_REG_LEN and IFREGCTL_REGW in vnt_rf_write_embedded
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 12 Jul 2014 10:30:01 +0000 (11:30 +0100)]
staging: vt6656: rf.c remove dead code RFaby11aChannelIndex
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 12 Jul 2014 10:30:00 +0000 (11:30 +0100)]
staging: vt6656: rf.c clean up channel and power tables
Remove comments to channel number execpt where there is a
change to 5gHz channel 15
named comments are already referenced in revision history
in high-level comment.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Sat, 12 Jul 2014 09:36:25 +0000 (11:36 +0200)]
Staging: bcm: Transmit.c: Removed obvious comment
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Sat, 12 Jul 2014 09:36:24 +0000 (11:36 +0200)]
Staging: bcm: Transmit.c: Line length / Whitespace cleanup
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Sat, 12 Jul 2014 09:36:23 +0000 (11:36 +0200)]
Staging: bcm: Transmit.c: Replaced member accessing with variable
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 12 Jul 2014 06:53:48 +0000 (07:53 +0100)]
staging: vt6656: wcmd replace debug message with dev_dbg
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 12 Jul 2014 06:53:47 +0000 (07:53 +0100)]
staging: vt6656: vResetCommandTimer remove camel case
pDevice -> priv
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 12 Jul 2014 06:53:46 +0000 (07:53 +0100)]
staging: vt6656: bScheduleCommand remove camel case
Camel case changes
pDevice -> priv
eCommand -> command
pbyItem0 -> item0
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 12 Jul 2014 06:53:45 +0000 (07:53 +0100)]
staging: vt6656: s_bCommandComplete clean up and remove camel case
pDevice -> priv
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 12 Jul 2014 06:53:44 +0000 (07:53 +0100)]
staging: vt6656: s_bCommandComplete remove else from if
if returns out so remove else
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 12 Jul 2014 06:53:43 +0000 (07:53 +0100)]
staging: vt6656: remove unused variables from struct tagCMD_ITEM
Also remove local variables
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 12 Jul 2014 06:53:42 +0000 (07:53 +0100)]
staging: vt6656: vRunCommand remove camel case.
pDevice -> priv
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 12 Jul 2014 06:53:41 +0000 (07:53 +0100)]
staging: vt6656: wcmd remove unused commands
WLAN_CMD_CHANGE_BBSENSITIVITY and WLAN_CMD_MAC_DISPOWERSAVING
are already implemented and don't need the command timer.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 12 Jul 2014 06:53:40 +0000 (07:53 +0100)]
staging: vt6656: wcmd Remove command WLAN_CMD_RADIO
Part of it has already been removed. checking isr1 & ISR_GPIO3
serves no purpose.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 12 Jul 2014 06:53:39 +0000 (07:53 +0100)]
staging: vt6656: vCommandTimerWait remove camel case.
camel case changes
pDevice -> priv
MSecond -> msecs
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 08:09:15 +0000 (01:09 -0700)]
staging: lustre: fid: fid_request.c: checkpatch cleanup: align arguments to parenthesis
whitespace changes only - git diff -w shows no difference
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 08:03:41 +0000 (01:03 -0700)]
staging: lustre: remove cfs_time_before()
Just call time_before() instead.
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: hpdd-discuss <hpdd-discuss@lists.01.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 07:54:26 +0000 (00:54 -0700)]
staging: lustre: cfs_time_sub() must return unsigned long
It looks like someone ment for it to return this value (there's a cast),
but the funtion says 'long' which causes problems when comparing values
from this function.
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: hpdd-discuss <hpdd-discuss@lists.01.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 07:45:51 +0000 (00:45 -0700)]
staging: lustre: remove cfs_duration_t typedef
Just use 'long' as that is what it was defined as.
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: hpdd-discuss <hpdd-discuss@lists.01.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 07:38:48 +0000 (00:38 -0700)]
staging: lustre: remove cfs_time_current_sec wrapper
Just call get_seconds() directly.
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: hpdd-discuss <hpdd-discuss@lists.01.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 07:31:18 +0000 (00:31 -0700)]
staging: lustre: remove cfs_time_beforeq wrapper
Use time_before_eq() call instead.
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: hpdd-discuss <hpdd-discuss@lists.01.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 07:27:46 +0000 (00:27 -0700)]
staging: lustre: remove cfs_time_t typedef
Just use unsigned long everywhere, like the rest of the kernel does.
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: hpdd-discuss <hpdd-discuss@lists.01.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 07:10:33 +0000 (00:10 -0700)]
staging: lustre: remove unused functions from linux-time.h
No one was using them, so delete them.
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: hpdd-discuss <hpdd-discuss@lists.01.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 07:04:53 +0000 (00:04 -0700)]
staging: lustre: remove cfs_fs_time_t
Use 'struct timespec' like the rest of the kernel does
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: hpdd-discuss <hpdd-discuss@lists.01.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 07:01:03 +0000 (00:01 -0700)]
staging: lustre: remove linux-tcpip.h
There were just a few macros being used, remove them and have the places
where they were being used to make the proper kernel api call instead.
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: hpdd-discuss <hpdd-discuss@lists.01.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 06:52:29 +0000 (23:52 -0700)]
staging: lustre: linux-tcpip.h: remove unused macros
Some macros are never used, so remove them.
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: hpdd-discuss <hpdd-discuss@lists.01.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 06:49:54 +0000 (23:49 -0700)]
staging: lustre: fix makefile build breakage
Forgot to test with infiniband enabled.
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 06:42:52 +0000 (23:42 -0700)]
staging: lustre: remove socket_t typedef
Use 'struct socket' like the rest of the kernel does.
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: hpdd-discuss <hpdd-discuss@lists.01.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org
Greg Kroah-Hartman [Sat, 12 Jul 2014 06:38:41 +0000 (23:38 -0700)]
staging: lustre: remove ctl_table typedefs
No need for these, just use the "real" struct the kernel provides.
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: hpdd-discuss <hpdd-discuss@lists.01.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 06:32:19 +0000 (23:32 -0700)]
staging: lustre: remove linux-types.h
It's an empty file, so remove it.
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: hpdd-discuss <hpdd-discuss@lists.01.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 06:29:34 +0000 (23:29 -0700)]
staging: lustre: fix build breakage on microblaze
I missed an include path that microblaze found in it's build paths.
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: hpdd-discuss <hpdd-discuss@lists.01.org>
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 06:28:12 +0000 (23:28 -0700)]
staging: lustre: delete linux-lock.h
It was a few empty defines, so just remove the thing.
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: hpdd-discuss <hpdd-discuss@lists.01.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 06:20:31 +0000 (23:20 -0700)]
staging: lustre: linux-cpu.h
Remove large commented out section for compatibility stuff that will
never be needed again.
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: hpdd-discuss <hpdd-discuss@lists.01.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 06:15:15 +0000 (23:15 -0700)]
staging: lustre: remove include/libcfs/linux/linux-bitops.h
It was just includeing bitops.h so do that instead in the one place that
was calling it.
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: hpdd-discuss <hpdd-discuss@lists.01.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 06:12:04 +0000 (23:12 -0700)]
staging: lustre: make include/linux/libcfs/linux/linux-crypto.h private
There are only 2 functions that are actually called from it, so move it
to the local place where it is needed, no need for it to be "global" for
the rest of lustre to see it.
Also remove the unneeded EXPORT_SYMBOL() markings for these functions,
as no one else calls them.
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: hpdd-discuss <hpdd-discuss@lists.01.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 06:05:14 +0000 (23:05 -0700)]
staging: lustre: remove unneeded DECLARE_LL_PROC_PPOS_DECL macro
It did nothing, so remove it.
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: hpdd-discuss <hpdd-discuss@lists.01.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 05:57:40 +0000 (22:57 -0700)]
staging: lustre: remove l_filep_open define
Just call filep_open(), no need to rename the thing.
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: hpdd-discuss <hpdd-discuss@lists.01.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 05:56:16 +0000 (22:56 -0700)]
staging: lustre: remove l_file define
It's a "file" structure, so use it instead of trying to rename it.
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: hpdd-discuss <hpdd-discuss@lists.01.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 05:53:32 +0000 (22:53 -0700)]
staging: lustre: remove l_dentry define
It's a 'dentry', so use it instead of something else.
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: hpdd-discuss <hpdd-discuss@lists.01.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 05:50:23 +0000 (22:50 -0700)]
staging: lustre: remove empty bitmap.h
The file was empty, remove it as it wasn't doing anything.
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: hpdd-discuss <hpdd-discuss@lists.01.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 05:47:02 +0000 (22:47 -0700)]
staging: lustre: libcfs: include: minor whitespace fixes
Found by the checkpatch.pl tool
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 05:40:51 +0000 (22:40 -0700)]
staging: lustre: lnet: include: minor whitespace fixes
Found by the checkpatch.pl tool
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 05:30:54 +0000 (22:30 -0700)]
staging: lustre: ptlrpc: gss: delete unused code
The gss code has never been built, there is no Kconfig option for it, so
delete it as code that can not build goes bad really fast.
If someone wants it back, they can revert this and fix any build errors
that might be in it.
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: hpdd-discuss <hpdd-discuss@lists.01.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 05:29:36 +0000 (22:29 -0700)]
staging: lustre: ptlrpc/ldlm: remove ccflags from Makefile
Fix up the relative paths in the .c files to properly build with the
Makefile change.
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: hpdd-discuss <hpdd-discuss@lists.01.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 05:17:53 +0000 (22:17 -0700)]
staging: lustre: obdecho: remove ccflags from Makefile
Fix up the relative paths in the .c files to properly build with the
Makefile change.
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: hpdd-discuss <hpdd-discuss@lists.01.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 05:16:18 +0000 (22:16 -0700)]
staging: lustre: osc: remove ccflags from Makefile
Fix up the relative paths in the .c files to properly build with the
Makefile change.
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: hpdd-discuss <hpdd-discuss@lists.01.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 05:16:07 +0000 (22:16 -0700)]
staging: lustre: mgc: remove ccflags from Makefile
Fix up the relative paths in the .c files to properly build with the
Makefile change.
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: hpdd-discuss <hpdd-discuss@lists.01.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 05:15:24 +0000 (22:15 -0700)]
staging: lustre: obdclass: remove ccflags from Makefile
Fix up the relative paths in the .c files to properly build with the
Makefile change.
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: hpdd-discuss <hpdd-discuss@lists.01.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 05:04:56 +0000 (22:04 -0700)]
staging: lustre: mdc: remove ccflags from Makefile
Fix up the relative paths in the .c files to properly build with the
Makefile change.
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: hpdd-discuss <hpdd-discuss@lists.01.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 05:02:26 +0000 (22:02 -0700)]
staging: lustre: lvfs: remove ccflags from Makefile
Fix up the relative paths in the .c files to properly build with the
Makefile change.
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: hpdd-discuss <hpdd-discuss@lists.01.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 05:01:58 +0000 (22:01 -0700)]
staging: lustre: lov: remove ccflags from Makefile
Fix up the relative paths in the .c files to properly build with the
Makefile change.
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: hpdd-discuss <hpdd-discuss@lists.01.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 04:57:32 +0000 (21:57 -0700)]
staging: lustre: lmv: remove ccflags from Makefile
Fix up the relative paths in the .c files to properly build with the
Makefile change.
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: hpdd-discuss <hpdd-discuss@lists.01.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 04:51:41 +0000 (21:51 -0700)]
staging: lustre: llite: remove ccflags from Makefile
Fix up the relative paths in the .c files to properly build with the
Makefile change.
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: hpdd-discuss <hpdd-discuss@lists.01.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 04:51:13 +0000 (21:51 -0700)]
staging: lustre: fld: remove ccflags from Makefile
Also fix up the relative paths in the .c files to properly build
now
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: hpdd-discuss <hpdd-discuss@lists.01.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 04:50:29 +0000 (21:50 -0700)]
staging: lustre: fid: remove ccflags from Makefile
Also fix up the relative paths in the .c files to properly build now
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: hpdd-discuss <hpdd-discuss@lists.01.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 04:34:24 +0000 (21:34 -0700)]
staging: lustre: fix include relative paths
In drivers/staging/lustre/lustre/include there was a bunch of .h files
relying on ccflags to be set up right. Make all of them proper relative
paths so that ccflags for different subdirs can be now removed.
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: hpdd-discuss <hpdd-discuss@lists.01.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 04:00:57 +0000 (21:00 -0700)]
staging: lustre: libcfs: remove ccflags from Makefile
There were two paths being added, yet only one was needed. Remove both,
and fix up the 3 .c files to point to the location of the needed .h
file.
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: hpdd-discuss <hpdd-discuss@lists.01.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 03:58:15 +0000 (20:58 -0700)]
staging: lustre: remove some unneeded cflags
The lnet code did not even need the cflags setting in the Makefile, so
remove it, as it is not doing anything at all.
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: hpdd-discuss <hpdd-discuss@lists.01.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 03:51:16 +0000 (20:51 -0700)]
staging: lustre: remove top level ccflags variable
We need to remove the ccflags from the Lustre code as it prevents
individual object files from building properly in the kernel build
system. It also hids the horrid mess that the Lustre include files are
made up of.
Start out by removing the toplevel ccflags variable pointing to
drivers/staging/lustre/include/ as a valid include path. This requires
the absolute include markings of a bunch of .h and .c files, which is
also done here.
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: hpdd-discuss <hpdd-discuss@lists.01.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 01:45:28 +0000 (18:45 -0700)]
staging: lnet: ptllnd_wire.h: checkpatch cleanup: whitespace neatening
whitespace changes only - git diff -w shows no difference
Cc: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 01:45:14 +0000 (18:45 -0700)]
staging: lnet: lnetctl.h: checkpatch cleanup: whitespace neatening
whitespace changes only - git diff -w shows no difference
Cc: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 01:44:57 +0000 (18:44 -0700)]
staging: lnet: lib-lnet.h: checkpatch cleanup: remove unnecessary externs
Cc: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 01:44:39 +0000 (18:44 -0700)]
staging: lnet: lib-lnet.h: checkpatch cleanup: align arguments to parenthesis
whitespace changes only - git diff -w shows no difference
Cc: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 01:40:36 +0000 (18:40 -0700)]
staging: lnet: types.h: checkpatch cleanup: whitespace neatening
whitespace changes only - git diff -w shows no difference
Cc: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Andrey Utkin [Fri, 11 Jul 2014 14:38:30 +0000 (15:38 +0100)]
staging: comedi: ni_atmio16d.c: remove pointless condition
The issue was discovered with static analysis and has two instances in
this file. The code looks like this
if (x <
65536000) {
...
} else if (x <
655360000) {
...
} else if (x <= 0xffffffff /*
6553600000 */) {
...
} else if (x <= 0xffffffff /*
65536000000 */) {
...
}
The meaning of this block is to select appropriate clock frequency for
interval timer basing on "x", which is amount of time.
Notes:
1. That last condition matches previous one - that's the issue.
2. Decimal numbers in comments don't match hex numbers in expressions.
But in first case the numbers have same order, while in the second case
the hex number is the same, and the decimal one is 10 times bigger.
3. Actually type of "x" is "unsigned int", so its exact upper limit is
not obviously known.
4. There's no "else" block.
So it makes sense to make an "else" block from last "else if" case. The
code inside the block seems correct for such usage.
[ Actually, get rid of the final "else if" case and change the
next-to-last "else if" case to an "else" as the upper limit of "x" _is_
known to be 0xffffffff (UINT_MAX), which is less than
6553600000 -- Ian ]
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=79871
Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Andrey Utkin <andrey.krieger.utkin@gmail.com>
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chase Southwood [Fri, 11 Jul 2014 04:02:55 +0000 (23:02 -0500)]
staging: comedi: addi_apci_1564: fix s->maxdata assignment in do subdevice init.
s->maxdata for the do subdevice should be 1, however currently it is
being set to 0xffffffff. Fix this.
Signed-off-by: Chase Southwood <chase.southwood@gmail.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chase Southwood [Fri, 11 Jul 2014 04:02:27 +0000 (23:02 -0500)]
staging: comedi: addi_apci_1564: remove null check of devpriv in apci1564_detach()
There is no need to test whether devpriv is null in this function. The
check looks left over and we can just remove it.
Signed-off-by: Chase Southwood <chase.southwood@gmail.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chase Southwood [Fri, 11 Jul 2014 04:02:04 +0000 (23:02 -0500)]
staging: comedi: addi_apci_1564: remove unnecessary dev->board_name initialization
The dev->board_name is now initialized by the comedi core before calling
the(*attach) or (*auto_attach) function in a driver. As long as the driver
does no additional probing, it's no longer necessary initialize the board_name.
Signed-off-by: Chase Southwood <chase.southwood@gmail.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chase Southwood [Fri, 11 Jul 2014 04:01:26 +0000 (23:01 -0500)]
staging: comedi: addi_apci_1564: remove len_chanlist from di and do subdevices
This value is only needed for subdevices that support async commands.
The comedi core will default the value to 1 when it is not initialized.
Signed-off-by: Chase Southwood <chase.southwood@gmail.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 11 Jul 2014 19:02:18 +0000 (20:02 +0100)]
staging: vt6656: Fix pairwise key for non station modes
patch 'vnt_set_keymode don't save pairwise key entry' caused
a slight regression in access point mode
Only don't save in station mode.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 11 Jul 2014 19:02:17 +0000 (20:02 +0100)]
staging: vt6656: vnt_init_bands fix missing default.
The default is that all the channels are enabled for rf types
not mentioned here.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Fri, 11 Jul 2014 16:25:42 +0000 (01:25 +0900)]
MAINTAINERS: Adds Daeseok Youn to maintainers list for dgap
Adds "Daeseok Youn" to maintainers list for dgap driver.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Fri, 11 Jul 2014 10:24:34 +0000 (19:24 +0900)]
staging: dgap: removes redundant null check and change paramter for dgap_tty_digisetcustombaud()
Null checks in dgap_tty_digisetcustombaud() are already done by
dgap_tty_ioctl() and change "tty" as a paramter of this function
to "ch", "bd and "un".
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Fri, 11 Jul 2014 10:24:14 +0000 (19:24 +0900)]
staging: dgap: removes redundant null check and change paramter for dgap_tty_digigetcustombaud()
Null checks in dgap_tty_digigetcustombaud() are already done by
dgap_tty_ioctl() and change "tty" as a paramter of this function
to "ch" and "un".
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Fri, 11 Jul 2014 10:23:54 +0000 (19:23 +0900)]
staging: dgap: removes redundant null check and change paramter for dgap_tty_digisetedelay()
Null checks in dgap_tty_digisetedelay() are already done by
dgap_tty_ioctl() and change "tty" as a paramter of this function
to "ch", "bd and "un".
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Fri, 11 Jul 2014 10:23:34 +0000 (19:23 +0900)]
staging: dgap: removes redundant null check and change paramter for dgap_set_modem_info()
Null checks in dgap_set_modem_info() are already done by
dgap_tty_ioctl() and change "tty" as a paramter of this function
to "ch", "bd" and "un".
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Fri, 11 Jul 2014 10:23:16 +0000 (19:23 +0900)]
staging: dgap: removes redundant null check and change paramter for dgap_tty_digigeta()
Null checks in dgap_tty_digigeta() are already done by
dgap_tty_ioctl() and change "tty" as a paramter of this function
to "ch" and "un".
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Fri, 11 Jul 2014 10:22:58 +0000 (19:22 +0900)]
staging: dgap: removes redundant null check and change paramter for dgap_tty_digiseta()
Null checks in dgap_tty_digiseta() are already done by
dgap_tty_ioctl() and change "tty" as a paramter of this function
to "ch" and "bd" which are used in dgap_tty_digiseta().
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Fri, 11 Jul 2014 10:22:39 +0000 (19:22 +0900)]
staging: dgap: removes redundant null check and change the paramter for dgap_param()
The dgap_param() has a paramter which is tty_struct and
use variables in that struct. That variables which are "ch", "bd", "bs"
and "un" do not need to check NULL so these statements are removed.
And also change the parameter of this function because
it is possible to let someone know what paramters
are needed for this function.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Fri, 11 Jul 2014 10:22:21 +0000 (19:22 +0900)]
staging: dgap: remove unused variable in dgap_param()
The "ts" is not used in dgap_param().
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Fri, 11 Jul 2014 10:22:04 +0000 (19:22 +0900)]
staging: dgap: redundant NULL and magic check in dgap_get_modem_info()
The "ch" is already checking in caller.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 11 Jul 2014 00:08:31 +0000 (01:08 +0100)]
staging: vt6656: rxtx replace debug messages DBG_PRT
Replace with dev_dbg
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 11 Jul 2014 00:08:30 +0000 (01:08 +0100)]
staging: vt6656: rxtx remove unneeded comments
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 11 Jul 2014 00:08:29 +0000 (01:08 +0100)]
staging: vt6656: rxtx remove static declarations
all functions are in visibility order.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 11 Jul 2014 00:08:28 +0000 (01:08 +0100)]
staging: vt6656: rename s_vGetFreeContext to vnt_get_free_context
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 11 Jul 2014 00:08:27 +0000 (01:08 +0100)]
staging: vt6656: clean up and rename wFB_Opt1 to vnt_fb_opt1
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 11 Jul 2014 00:08:26 +0000 (01:08 +0100)]
staging: vt6656: clean up and rename wFB_Opt0 to vnt_fb_opt0
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 11 Jul 2014 00:08:25 +0000 (01:08 +0100)]
staging: vt6656: rename and cleanup wTimeStampOff
Rename to vnt_time_stampoff
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 11 Jul 2014 00:08:24 +0000 (01:08 +0100)]
staging: vt6656: rename s_uGetTxRsvTime to vnt_get_rsvtime
Drop tx from name
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 11 Jul 2014 00:08:23 +0000 (01:08 +0100)]
staging: vt6656: rename s_uGetRTSCTSRsvTime to vnt_get_rtscts_rsvtime_le
Function always returns little endian.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 11 Jul 2014 00:08:22 +0000 (01:08 +0100)]
staging: vt6656: rename s_uGetDataDuration to vnt_get_duration_le
Drop data and the function always returns little endian
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 11 Jul 2014 00:08:21 +0000 (01:08 +0100)]
staging: vt6656: s_uGetDataDuration remove camel case
camel case changes
pDevice -> priv
byPktType -> pkt_type
bNeedAck -> need_ack
uAckTime -> ack_time
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 11 Jul 2014 00:08:20 +0000 (01:08 +0100)]
staging: vt6656: rxtx rename s_uGetRTSCTSDuration to vnt_get_rtscts_duration_le
Function always returns little endian value.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
projects / firefly-linux-kernel-4.4.55.git / log