Chandler Carruth [Tue, 18 Mar 2014 22:00:32 +0000 (22:00 +0000)]
[LV] While I'm here, use range based for loops which are so much cleaner
for this kind of walk.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204188
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Tue, 18 Mar 2014 21:58:38 +0000 (21:58 +0000)]
[LV] The actual change I intended to commit in r204148. Sorry for the
noise.
Original commit log:
Replace some dead code with an assert. When I first ported this pass
from a loop pass to a function pass I did so in the naive, recursive
way. It doesn't actually work, we need a worklist instead. When
I switched to the worklist I didn't delete the naive recursion. That
recursion was also buggy because it was dead and never really exercised.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204187
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Tue, 18 Mar 2014 21:51:46 +0000 (21:51 +0000)]
[LV] Replace some dead code with an assert. When I first ported this
pass from a loop pass to a function pass I did so in the naive,
recursive way. It doesn't actually work, we need a worklist instead.
When I switched to the worklist I didn't delete the naive recursion.
That recursion was also buggy because it was dead and never really
exercised.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204184
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Tue, 18 Mar 2014 21:44:12 +0000 (21:44 +0000)]
More header and forward declaration cleanup.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204183
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Tue, 18 Mar 2014 20:58:35 +0000 (20:58 +0000)]
Add back the headers we're getting via (likely) transitive includes.
We really do use these things in the header.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204180
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Tue, 18 Mar 2014 20:40:38 +0000 (20:40 +0000)]
Add back r203962, r204028 and r204059.
This reverts commit r204137.
This includes a fix for handling aliases of aliases.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204178
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Tue, 18 Mar 2014 20:39:54 +0000 (20:39 +0000)]
Fix for coding style.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204177
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Tue, 18 Mar 2014 20:37:10 +0000 (20:37 +0000)]
Remove a bunch of unnecessary includes and forward declarations.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204176
91177308-0d34-0410-b5e6-
96231b3b80d8
Hans Wennborg [Tue, 18 Mar 2014 20:04:34 +0000 (20:04 +0000)]
X86 memcpy lowering: use "rep movs" even when esi is used as base pointer
For functions where esi is used as base pointer, we would previously fall back
from lowering memcpy with "rep movs" because that clobbers esi.
With this patch, we just store esi in another physical register, and restore
it afterwards. This adds a little bit of register preassure, but the more
efficient memcpy should be worth it.
Differential Revision: http://llvm-reviews.chandlerc.com/D2968
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204174
91177308-0d34-0410-b5e6-
96231b3b80d8
Rui Ueyama [Tue, 18 Mar 2014 18:58:51 +0000 (18:58 +0000)]
Use early returns to reduce nesting.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204171
91177308-0d34-0410-b5e6-
96231b3b80d8
Michael Zolotukhin [Tue, 18 Mar 2014 18:17:59 +0000 (18:17 +0000)]
Fix test lsr-normalization.ll broken in r204161.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204166
91177308-0d34-0410-b5e6-
96231b3b80d8
Raul E. Silvera [Tue, 18 Mar 2014 17:49:12 +0000 (17:49 +0000)]
Add support for scalarizing/splitting vector bswap.
Summary:
SLP Vectorization of intrinsics (r203707) has exposed cases where the
expansion of vector bswap is failing (PR19151).
Reviewers: hfinkel
CC: chandlerc
Differential Revision: http://llvm-reviews.chandlerc.com/D3104
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204163
91177308-0d34-0410-b5e6-
96231b3b80d8
Adrian Prantl [Tue, 18 Mar 2014 17:41:15 +0000 (17:41 +0000)]
Debug info: Remove OdrMemberMap from DwarfDebug, it's not necessary.
Follow-up to r203982.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204162
91177308-0d34-0410-b5e6-
96231b3b80d8
Michael Zolotukhin [Tue, 18 Mar 2014 17:34:03 +0000 (17:34 +0000)]
Add stride normalization to SCEV Normalize/Denormalize transformation.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204161
91177308-0d34-0410-b5e6-
96231b3b80d8
Andrea Di Biagio [Tue, 18 Mar 2014 17:12:59 +0000 (17:12 +0000)]
[DAGCombiner] teach how to simplify xor/and/or nodes according to the following rules:
1) (AND (shuf (A, C, Mask), shuf (B, C, Mask)) -> shuf (AND (A, B), C, Mask)
2) (OR (shuf (A, C, Mask), shuf (B, C, Mask)) -> shuf (OR (A, B), C, Mask)
3) (XOR (shuf (A, C, Mask), shuf (B, C, Mask)) -> shuf (XOR (A, B), V_0, Mask)
4) (AND (shuf (C, A, Mask), shuf (C, B, Mask)) -> shuf (C, AND (A, B), Mask)
5) (OR (shuf (C, A, Mask), shuf (C, B, Mask)) -> shuf (C, OR (A, B), Mask)
6) (XOR (shuf (C, A, Mask), shuf (C, B, Mask)) -> shuf (V_0, XOR (A, B), Mask)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204160
91177308-0d34-0410-b5e6-
96231b3b80d8
Manuel Jacob [Tue, 18 Mar 2014 16:14:11 +0000 (16:14 +0000)]
X86: Use enums for memory operand decoding instead of integer literals.
Summary:
X86BaseInfo.h defines an enum for the offset of each operand in a memory operand
sequence. Some code uses it and some does not. This patch replaces (hopefully)
all remaining locations where an integer literal was used instead of this enum.
No functionality change intended.
Reviewers: nadav
CC: llvm-commits, t.p.northover
Differential Revision: http://llvm-reviews.chandlerc.com/D3108
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204158
91177308-0d34-0410-b5e6-
96231b3b80d8
Krzysztof Parzyszek [Tue, 18 Mar 2014 16:02:37 +0000 (16:02 +0000)]
Enable CFI on Hexagon.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204157
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Schmidt [Tue, 18 Mar 2014 14:32:50 +0000 (14:32 +0000)]
Fix PR19144: Incorrect offset generated for int-to-fp conversion at -O0.
When converting a signed 32-bit integer to double-precision floating point on
hardware without a lfiwax instruction, we have to instead use a lfd followed
by fcfid. We were erroneously offsetting the address by 4 bytes in
preparation for either a lfiwax or lfiwzx when generating the lfd. This fixes
that silly error.
This was not caught in the test suite since the conversion tests were run with
-mcpu=pwr7, which implies availability of lfiwax. I've added another test
case for older hardware that checks the code we expect in the absence of
lfiwax and other flavors of fcfid. There are fewer tests in this test case
because we punt to DAG selection in more cases on older hardware. (We must
generate complex fiddly sequences in those cases, and there is marginal
benefit in duplicating that logic in fast-isel.)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204155
91177308-0d34-0410-b5e6-
96231b3b80d8
Evgeniy Stepanov [Tue, 18 Mar 2014 13:30:56 +0000 (13:30 +0000)]
[msan] Origin tracking with history.
LLVM part of MSan implementation of advanced origin tracking,
when we record not only creation point, but all locations where
an uninitialized value was stored to memory, too.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204151
91177308-0d34-0410-b5e6-
96231b3b80d8
Diego Novillo [Tue, 18 Mar 2014 12:03:12 +0000 (12:03 +0000)]
Tolerate unmangled names in sample profiles.
Summary:
The compiler does not always generate linkage names. If a function
has been inlined and its body elided, its linkage name may not be
generated.
When the binary executes, the profiler will use its unmangled name
when attributing samples. This results in unmangled names in the
input profile.
We are currently failing hard when this happens. However, in this case
all that happens is that we fail to attribute samples to the inlined
function. While this means fewer optimization opportunities, it should
not cause a compilation failure.
This patch accepts all valid function names, regardless of whether
they were mangled or not.
Reviewers: chandlerc
CC: llvm-commits
Differential Revision: http://llvm-reviews.chandlerc.com/D3087
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204142
91177308-0d34-0410-b5e6-
96231b3b80d8
Alexander Kornienko [Tue, 18 Mar 2014 10:36:11 +0000 (10:36 +0000)]
Revert r203962 and two revisions depending on it: r204028 and r204059.
The revision I'm reverting breaks handling of transitive aliases. This blocks us
and breaks sanitizer bootstrap:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/2651
(and checked locally by Alexey).
This revision is the result of:
svn merge -r204059:204058 -r204028:204027 -r203962:203961 .
+ the regression test added to test/MC/ELF/alias.s
Another way to reproduce the regression with clang:
$ cat q.c
void a1();
void a2() __attribute__((alias("a1")));
void a3() __attribute__((alias("a2")));
void a1() {}
$ ~/work/llvm-build/bin/clang-3.5-good -c q.c && mv q.o good.o && \
~/work/llvm-build/bin/clang-3.5-bad -c q.c && mv q.o bad.o && \
objdump -t good.o bad.o
good.o: file format elf64-x86-64
SYMBOL TABLE:
0000000000000000 l df *ABS*
0000000000000000 q.c
0000000000000000 l d .text
0000000000000000 .text
0000000000000000 l d .data
0000000000000000 .data
0000000000000000 l d .bss
0000000000000000 .bss
0000000000000000 l d .comment
0000000000000000 .comment
0000000000000000 l d .note.GNU-stack
0000000000000000 .note.GNU-stack
0000000000000000 l d .eh_frame
0000000000000000 .eh_frame
0000000000000000 g F .text
0000000000000006 a1
0000000000000000 g F .text
0000000000000006 a2
0000000000000000 g F .text
0000000000000006 a3
bad.o: file format elf64-x86-64
SYMBOL TABLE:
0000000000000000 l df *ABS*
0000000000000000 q.c
0000000000000000 l d .text
0000000000000000 .text
0000000000000000 l d .data
0000000000000000 .data
0000000000000000 l d .bss
0000000000000000 .bss
0000000000000000 l d .comment
0000000000000000 .comment
0000000000000000 l d .note.GNU-stack
0000000000000000 .note.GNU-stack
0000000000000000 l d .eh_frame
0000000000000000 .eh_frame
0000000000000000 g F .text
0000000000000006 a1
0000000000000000 g F .text
0000000000000006 a2
0000000000000000 g .text
0000000000000000 a3
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204137
91177308-0d34-0410-b5e6-
96231b3b80d8
Renato Golin [Tue, 18 Mar 2014 10:16:15 +0000 (10:16 +0000)]
Add IAS/EHABI changes to release notes
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204134
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Tue, 18 Mar 2014 09:58:28 +0000 (09:58 +0000)]
DebugIRTests: Fixup for r204130.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204132
91177308-0d34-0410-b5e6-
96231b3b80d8
Evgeniy Stepanov [Tue, 18 Mar 2014 09:47:06 +0000 (09:47 +0000)]
[msan] Kill -msan-store-clean-origin flag.
Not only is it slower than the alternative, but also subtly broken.
This commit does not change the default behavior.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204131
91177308-0d34-0410-b5e6-
96231b3b80d8
Alon Mishne [Tue, 18 Mar 2014 09:41:07 +0000 (09:41 +0000)]
[C++11] Change DebugInfoFinder to use range-based loops
Also changes the iterators to return actual DI type over MDNode.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204130
91177308-0d34-0410-b5e6-
96231b3b80d8
Evgeniy Stepanov [Tue, 18 Mar 2014 08:29:42 +0000 (08:29 +0000)]
[msan] Remove unused code.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204125
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Tue, 18 Mar 2014 07:27:13 +0000 (07:27 +0000)]
[C++11] Mark the target fast isel classes as 'final' so that the compiler can de-virtualize some of the internal calls.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204123
91177308-0d34-0410-b5e6-
96231b3b80d8
Alexey Samsonov [Tue, 18 Mar 2014 06:53:02 +0000 (06:53 +0000)]
[C++11] Change the interface of getCOFF{Section,Relocation,Symbol} to make it work with range-based for loops.
Reviewers: ruiu
Reviewed By: ruiu
CC: llvm-commits
Differential Revision: http://llvm-reviews.chandlerc.com/D3097
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204120
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Tue, 18 Mar 2014 06:17:22 +0000 (06:17 +0000)]
CodeGen/R600/v_cndmask.ll: Relax an expression to unbreak msvcrt.
V_CNDMASK_B32_e64 v0, v0, -1.#QNAN0e+00, s[2:3], 0, 0, 0, 0
FIXME: We really need to implement our formatter...
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204118
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Tue, 18 Mar 2014 06:01:14 +0000 (06:01 +0000)]
DebugInfo/lto-comp-dir.ll: Tweak for dos path.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204117
91177308-0d34-0410-b5e6-
96231b3b80d8
Saleem Abdulrasool [Tue, 18 Mar 2014 05:26:55 +0000 (05:26 +0000)]
ARM: add an assertion
Add an assertion that a valid section is referenced. The potential NULL pointer
dereference was identified by the clang static analyzer.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204114
91177308-0d34-0410-b5e6-
96231b3b80d8
Adrian Prantl [Tue, 18 Mar 2014 02:35:03 +0000 (02:35 +0000)]
DwarfDebug: Only unique retained types instead of all types.
This is a follow-up to r203983 based on feedback from dblaikie and mren (Thanks!)
No functionality change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204107
91177308-0d34-0410-b5e6-
96231b3b80d8
Adrian Prantl [Tue, 18 Mar 2014 02:34:58 +0000 (02:34 +0000)]
Switch the type field in DIVariable and DIGlobalVariable over to DITypeRefs.
This allows us to catch more opportunities for ODR-based type uniquing
during LTO.
Paired commit with CFE which updates some testcases to verify the new
DIBuilder behavior.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204106
91177308-0d34-0410-b5e6-
96231b3b80d8
Adrian Prantl [Tue, 18 Mar 2014 02:34:52 +0000 (02:34 +0000)]
Replace unnecessary #include directive with forward declarations.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204104
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Tue, 18 Mar 2014 02:18:27 +0000 (02:18 +0000)]
Add explanatory comment.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204103
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Tue, 18 Mar 2014 02:18:24 +0000 (02:18 +0000)]
Shorten DotDebugLocEntry to just DebugLocEntry and reformat.
No functional change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204102
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Tue, 18 Mar 2014 02:13:23 +0000 (02:13 +0000)]
DebugInfo: Avoid emitting standard opcode lengths in debug_line.dwo headers where opcodes are never used anyway
Introduce a slightly tighter wrapper around the header structure that
handles this use case. (MCDwarfDwoLineTable)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204101
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Tue, 18 Mar 2014 01:17:26 +0000 (01:17 +0000)]
DebugInfo: Implement debug_line.dwo for file names used in type units during -gsplit-dwarf
This removes an attribute (and more importantly, a relocation) from
skeleton type units and removes some unnecessary file names from the
debug_line section that remains in the .o (and linked executable) file.
There's still a few places we could shave off some more space here:
* use compilation dir of the underlying compilation unit (since all the
type units share that compilation dir - though this would be more
complicated in LTO cases where they don't (keep a map of compilation
dir->line table header?))
* Remove some of the unnecessary header fields from the line table since
they're not needed in this situation (about 12 bytes per table).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204099
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Tue, 18 Mar 2014 00:12:25 +0000 (00:12 +0000)]
DebugInfo: Flag test as requiring object emission support
Cleans up buildbot failures on R600 and similar.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204095
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Tue, 18 Mar 2014 00:11:48 +0000 (00:11 +0000)]
DebugInfo: Do not rely on the compilation dir (index 0) for files in line tables shared between compilation units
When emitting assembly there's no support for emitting separate line
tables for each compilation unit - so LLVM emits .loc directives
producing a single line table.
Line tables have an implicit directory (index 0) equal to the
compilation directory (DW_AT_comp_dir) of the compilation unit that
references them.
If multiple compilation units (with possibly disparate compilation
directories) reference the same line table, we must avoid relying on
this ambiguous directory.
Achieve this my simply not setting the compilation directory on the line
table when we're in this situation (multiple units while emitting
assembly).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204094
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Mon, 17 Mar 2014 23:53:25 +0000 (23:53 +0000)]
DebugInfo: Move getOrCreateSourceID from DwarfDebug to DwarfCompileUnit
We still do a few lookups into the line table mapping in MCContext that
could be factored out into a single lookup (rather than looking it up
once for the table label, once to set the compilation unit, once for
each time we need a file ID, etc... ) but assembly output complicates
that somewhat as we still need a virtual dispatch back to the
MCAsmStreamer in that case.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204092
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Mon, 17 Mar 2014 23:29:40 +0000 (23:29 +0000)]
DebugInfo: Move line table zero-directory-index (compilation dir) handling into MCDwarf
Our handling of compilation directory in DwarfDebug was broken
(incorrectly using the 'last' compilation directory (that of the last
CU in the metadata list) for all function emission in any CU). By moving
this handling down into MCDwarf the issue is fixed as the compilation
dir is tracked correctly per line table.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204089
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Mon, 17 Mar 2014 22:23:09 +0000 (22:23 +0000)]
Make methods static
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204085
91177308-0d34-0410-b5e6-
96231b3b80d8
Dan Gohman [Mon, 17 Mar 2014 19:57:04 +0000 (19:57 +0000)]
Use range metadata instead of introducing selects.
When GlobalOpt has determined that a GlobalVariable only ever has two values,
it would convert the GlobalVariable to a boolean, and introduce SelectInsts
at every load, to choose between the two possible values. These SelectInsts
introduce overhead and other unpleasantness.
This patch makes GlobalOpt just add range metadata to loads from such
GlobalVariables instead. This enables the same main optimization (as seen in
test/Transforms/GlobalOpt/integer-bool.ll), without introducing selects.
The main downside is that it doesn't get the memory savings of shrinking such
GlobalVariables, but this is expected to be negligible.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204076
91177308-0d34-0410-b5e6-
96231b3b80d8
Owen Anderson [Mon, 17 Mar 2014 19:36:09 +0000 (19:36 +0000)]
Switch a number of loops in lib/CodeGen over to range-based for-loops, now that
the MachineRegisterInfo iterators are compatible with it.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204075
91177308-0d34-0410-b5e6-
96231b3b80d8
Owen Anderson [Mon, 17 Mar 2014 19:34:51 +0000 (19:34 +0000)]
Really REALLY finish adding const to the MachineRegisterInfo iterator range methods.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204074
91177308-0d34-0410-b5e6-
96231b3b80d8
Kevin Enderby [Mon, 17 Mar 2014 19:00:03 +0000 (19:00 +0000)]
Making a guess to fix the test case with r204056 to get the build bot working.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204073
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Mon, 17 Mar 2014 18:58:11 +0000 (18:58 +0000)]
R600: Match sign_extend_inreg to BFE instructions
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204072
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Mon, 17 Mar 2014 18:58:01 +0000 (18:58 +0000)]
Make DAGCombiner work on vector bitshifts with constant splat vectors.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204071
91177308-0d34-0410-b5e6-
96231b3b80d8
Owen Anderson [Mon, 17 Mar 2014 18:16:10 +0000 (18:16 +0000)]
Add one more const marker that I missed.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204070
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Mon, 17 Mar 2014 18:13:58 +0000 (18:13 +0000)]
DebugInfo: Use MC line table file entry uniquing for non-asm input as well.
See r204027 for the precursor to this that applied to asm debug info.
This required some non-obvious API changes to handle the case of asm
output (we never go asm->asm so this didn't come up in r204027): the
modification of the file/directory name by MCDwarfLineTableHeader needed
to be reflected in the MCAsmStreamer caller so it could print the
appropriate .file directive, so those StringRef parameters are now
non-const ref (in/out) parameters rather than just const.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204069
91177308-0d34-0410-b5e6-
96231b3b80d8
Owen Anderson [Mon, 17 Mar 2014 18:05:05 +0000 (18:05 +0000)]
Mark MachineRegisterInfo's iterator range methods as const.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204067
91177308-0d34-0410-b5e6-
96231b3b80d8
Owen Anderson [Mon, 17 Mar 2014 18:01:41 +0000 (18:01 +0000)]
Add iterator range definitions for the MachineRegisterInfo iterators.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204066
91177308-0d34-0410-b5e6-
96231b3b80d8
Adam Nemet [Mon, 17 Mar 2014 17:32:53 +0000 (17:32 +0000)]
[X86] Fix unused variable warning with NDEBUG from r204058
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204063
91177308-0d34-0410-b5e6-
96231b3b80d8
Saleem Abdulrasool [Mon, 17 Mar 2014 17:13:57 +0000 (17:13 +0000)]
MC: change runtime check to an assertion
It is unclear how it would be possible to get M to be NULL in normal scenarios.
Change this to an assert rather than a runtime check as per dblakie's
suggestion.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204060
91177308-0d34-0410-b5e6-
96231b3b80d8
Saleem Abdulrasool [Mon, 17 Mar 2014 17:13:54 +0000 (17:13 +0000)]
ARM IAS: support .thumb_set
This performs the equivalent of a .set directive in that it creates a symbol
which is an alias for another symbol or value which may possibly be yet
undefined. This directive also has the added property in that it marks the
aliased symbol as being a thumb function entry point, in the same way that the
.thumb_func directive does.
The current implementation fails one test due to an unrelated issue. Functions
within .thumb sections are not marked as thumb_func. The result is that
the aliasee function is not valued correctly.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204059
91177308-0d34-0410-b5e6-
96231b3b80d8
Adam Nemet [Mon, 17 Mar 2014 17:06:14 +0000 (17:06 +0000)]
[VectorLegalizer/X86] Don't unvectorize fp_to_uint for v8f32->v8i16
Rather than LegalizeAction::Expand, this needs LegalizeAction::Promote to get
promoted to fp_to_sint v8f32->v8i32. This is a legal operation on AVX.
For that to work properly, we also need to teach the legalizer about the
specific promotion required here. The default vector promotion uses
bitcasting to a vector type of the same total size. We want to promote the
vector element type, effectively widening the operation and then truncating
the result. This is analogous to the current logic of how int_to_fp is
promoted.
The change also factors out some code from the int_to_fp promotion code to
ValueType::widenIntegerVectorElementType. This is now shared between
int_to_fp and fp_to_int.
There is no longer need for the custom lowering of fp_to_sint f32->v8i16 in
X86. It can now go through the new target-independent fp_to_*int promotion
logic.
I also checked that no other target uses Promote for these ops yet, so there
shouldn't be any unexpected change in behavior.
Fixes <rdar://problem/
16202247>
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204058
91177308-0d34-0410-b5e6-
96231b3b80d8
Tom Stellard [Mon, 17 Mar 2014 17:03:52 +0000 (17:03 +0000)]
R600/SI: Fix implementation of isInlineConstant() used by the verifier
The type of the immediates should not matter as long as the encoding is
equivalent to the encoding of one of the legal inline constants.
Tested-by: Michel Dänzer <michel.daenzer@amd.com>
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204056
91177308-0d34-0410-b5e6-
96231b3b80d8
Tom Stellard [Mon, 17 Mar 2014 17:03:51 +0000 (17:03 +0000)]
R600/SI: Use correct dest register class for V_READFIRSTLANE_B32
This instructions writes to an 32-bit SGPR. This change required adding
the 32-bit VCC_LO and VCC_HI registers, because the full VCC register
is 64 bits.
This fixes verifier errors on several of the indirect addressing piglit
tests.
Tested-by: Michel Dänzer <michel.daenzer@amd.com>
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204055
91177308-0d34-0410-b5e6-
96231b3b80d8
Tom Stellard [Mon, 17 Mar 2014 17:03:49 +0000 (17:03 +0000)]
R600/SI: Add generic checks to SIInstrInfo::verifyInstruction()
Added checks for number of operands and operand register classes.
Tested-by: Michel Dänzer <michel.daenzer@amd.com>
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204054
91177308-0d34-0410-b5e6-
96231b3b80d8
Eli Bendersky [Mon, 17 Mar 2014 16:19:07 +0000 (16:19 +0000)]
Consistent use of the noduplicate attribute.
The "noduplicate" attribute of call instructions is sometimes queried directly
and sometimes through the cannotDuplicate() predicate. This patch streamlines
all queries to use the cannotDuplicate() predicate. It also adds this predicate
to InvokeInst, to mirror what CallInst has.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204049
91177308-0d34-0410-b5e6-
96231b3b80d8
Alexey Samsonov [Mon, 17 Mar 2014 07:28:19 +0000 (07:28 +0000)]
[C++11] Introduce ObjectFile::symbols() to use range-based loops.
Reviewers: rafael
Reviewed By: rafael
CC: llvm-commits
Differential Revision: http://llvm-reviews.chandlerc.com/D3081
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204031
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Mon, 17 Mar 2014 05:31:54 +0000 (05:31 +0000)]
llvm/test/MC/MachO/gen-dwarf-cpp.s: Relax an expression to match DOS pat.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204030
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Mon, 17 Mar 2014 04:29:51 +0000 (04:29 +0000)]
Consider the base pointer for setting the symbol type.
This is really a consistency fix. Since given
a = b
we propagate the information, we should propagate it too given
a = b + (1 - 1)
Fixes pr19145.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204028
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Mon, 17 Mar 2014 01:52:11 +0000 (01:52 +0000)]
DebugInfo: Improve reuse of file table entries in asm debug info
The previous deduping strategy was woefully inadequate - it only
considered the most recent file used and avoided emitting a duplicate in
that case - never considering the a/b/a scenario.
It was also lacking when it came to directory paths as the previous
filename would never match the current if the filename had been split
into file and directory components.
This change builds caching functionality into the line table at the
lowest level in an optional form (a file number of 0 indicates that one
should be chosen and returned) and will eventually be reused by the
normal source level debugging DWARF emission.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204027
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Mon, 17 Mar 2014 01:52:04 +0000 (01:52 +0000)]
Test case
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204026
91177308-0d34-0410-b5e6-
96231b3b80d8
Lang Hames [Mon, 17 Mar 2014 01:51:51 +0000 (01:51 +0000)]
Deleted copy-constructor/copy-assignment broke a buildbot. Removing while I
investigate.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204025
91177308-0d34-0410-b5e6-
96231b3b80d8
Nico Rieck [Mon, 17 Mar 2014 01:46:52 +0000 (01:46 +0000)]
llvm-readobj: Print referred symbol name for CLR token definition
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204024
91177308-0d34-0410-b5e6-
96231b3b80d8
Nico Rieck [Mon, 17 Mar 2014 01:46:28 +0000 (01:46 +0000)]
llvm-readobj: Add test for COFF auxiliary symbols as used by C++/CLI
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204023
91177308-0d34-0410-b5e6-
96231b3b80d8
Lang Hames [Mon, 17 Mar 2014 01:33:21 +0000 (01:33 +0000)]
Rename PBQP RegAllocSolver local variables to conform to LLVM coding style.
No functional change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204022
91177308-0d34-0410-b5e6-
96231b3b80d8
Lang Hames [Mon, 17 Mar 2014 01:22:54 +0000 (01:22 +0000)]
[X86] New and improved VZeroUpperInserter optimization.
- Adds support for inserting vzerouppers before tail-calls.
This is enabled implicitly by having MachineInstr::copyImplicitOps preserve
regmask operands, which allows VZeroUpperInserter to see where tail-calls use
vector registers.
- Fixes a bug that caused the previous version of this optimization to miss some
vzeroupper insertion points in loops. (Loops-with-vector-code that followed
loops-without-vector-code were mistakenly overlooked by the previous version).
- New algorithm never revisits instructions.
Fixes <rdar://problem/
16228798>
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204021
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Sun, 16 Mar 2014 23:58:43 +0000 (23:58 +0000)]
Untabify.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204020
91177308-0d34-0410-b5e6-
96231b3b80d8
Manman Ren [Sun, 16 Mar 2014 18:44:23 +0000 (18:44 +0000)]
Add FIXMEs to use DIScopeRef instead of DIScope for LTO type uniqueing.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204019
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Sun, 16 Mar 2014 13:51:24 +0000 (13:51 +0000)]
[CMake][cygming] Disable --out-implib from executables.
It doesn't make sense even with --export-all-symbols.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204017
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Sun, 16 Mar 2014 01:36:18 +0000 (01:36 +0000)]
Remove named Twine.
While technically correct, we generally disallow any instance of named
Twines due to their subtlety.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204016
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Sat, 15 Mar 2014 23:01:29 +0000 (23:01 +0000)]
Use a fixed subtarget for test so atom scheduling can't change the addresses this test relies on.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204014
91177308-0d34-0410-b5e6-
96231b3b80d8
Arnaud A. de Grandmaison [Sat, 15 Mar 2014 22:13:15 +0000 (22:13 +0000)]
Remove some dead assignements found by scan-build
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204013
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Sat, 15 Mar 2014 18:47:07 +0000 (18:47 +0000)]
Make some assertions on constant expressions static.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204011
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Sat, 15 Mar 2014 18:10:49 +0000 (18:10 +0000)]
PointerIntPair: Avoid an (academic) case of undefined behavior in the DenseMapInfo specialization.
If we use a pair with an enum type this could create values outside
of the enum range. Avoid it by creating the bit pattern directly.
While there turn a dynamic assert into a static one. No functionality
change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204010
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Sat, 15 Mar 2014 17:17:48 +0000 (17:17 +0000)]
LSR: Compress a pair (and get rid of the DenseMapInfo for it).
Also convert a horrible hash function to use our hashing infrastructure.
No functionality change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204008
91177308-0d34-0410-b5e6-
96231b3b80d8
Patrik Hagglund [Sat, 15 Mar 2014 09:11:41 +0000 (09:11 +0000)]
Replace ValueTypes.h with MachineValueType.h if possible.
Utilize the previous move of MVT to a separate header for all trivial
cases (that don't need any further restructuring).
Reviewed By: Tim Northover
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204003
91177308-0d34-0410-b5e6-
96231b3b80d8
Justin Bogner [Sat, 15 Mar 2014 04:05:59 +0000 (04:05 +0000)]
Support: Make error_category's constructor public
Since our error_category is based on the std one, we should have the
same visibility for the constructor. This also allows us to avoid
using the _do_message implementation detail in our own categories.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203998
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Sat, 15 Mar 2014 02:32:21 +0000 (02:32 +0000)]
llvm/test/Transforms/SampleProfile/syntax.ll: Suppress checking the message catalog in ENOENT. It is locale-dependent on Windows.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203997
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Sat, 15 Mar 2014 01:56:17 +0000 (01:56 +0000)]
SampleProfile.cpp: Fix take #2. The issue was abuse of StringRef here.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203996
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Sat, 15 Mar 2014 00:10:12 +0000 (00:10 +0000)]
SampleProfile.cpp: Quick fix to r203976 about abuse of Twine. The life of Twine was too short.
FIXME: DiagnosticInfoSampleProfile should not hold Twine&.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203990
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Sat, 15 Mar 2014 00:08:26 +0000 (00:08 +0000)]
R600: Remove unnecessary attempt to zext a pointer.
Private pointers are now always 32-bits.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203989
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Sat, 15 Mar 2014 00:08:22 +0000 (00:08 +0000)]
R600: Code cleanup.
Use sign_extend_inreg and getZeroExtendInReg instead of
using the bit operations they expand into.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203988
91177308-0d34-0410-b5e6-
96231b3b80d8
Rui Ueyama [Sat, 15 Mar 2014 00:04:08 +0000 (00:04 +0000)]
Object/COFF: change data type of SymbolNumber from int16 to uint16.
Microsoft PE/COFF Spec clearly states that the field is of signed interger
type. However, in reality, it's unsigned. If cl.exe needs to create a large
number of sections for COMDAT sections, it will just create more than 32768
sections. Handling large section number as negative number is not correct.
I think this is a spec bug.
Differential Revision: http://llvm-reviews.chandlerc.com/D3088
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203986
91177308-0d34-0410-b5e6-
96231b3b80d8
Adrian Prantl [Fri, 14 Mar 2014 23:08:29 +0000 (23:08 +0000)]
Debug info: Unique types before emitting them to DWARF, where applicable.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203983
91177308-0d34-0410-b5e6-
96231b3b80d8
Adrian Prantl [Fri, 14 Mar 2014 23:08:25 +0000 (23:08 +0000)]
Debug Info: Fix LTO type uniquing for C++ member declarations
based on the ODR.
This adds an OdrMemberMap to DwarfDebug which is used to unique C++
member function declarations based on the unique identifier of their
containing class and their mangled name.
We can't use the usual DIRef mechanism here because DIScopes are indexed
using their entire MDNode, including decl_file and decl_line, which need
not be unique (see testcase).
Prior to this change multiple redundant member function declarations would
end up in the same uniqued DW_TAG_class_type.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203982
91177308-0d34-0410-b5e6-
96231b3b80d8
Adrian Prantl [Fri, 14 Mar 2014 23:08:21 +0000 (23:08 +0000)]
Re-add checks that were in this testcase before it was converted to dwarfdump.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203981
91177308-0d34-0410-b5e6-
96231b3b80d8
Adrian Prantl [Fri, 14 Mar 2014 23:08:17 +0000 (23:08 +0000)]
typo
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203980
91177308-0d34-0410-b5e6-
96231b3b80d8
Jim Grosbach [Fri, 14 Mar 2014 22:41:58 +0000 (22:41 +0000)]
MC: don't create a backtrace for diagnostics.
For better or worse, this is currently the normal error reporting path
when dealing with backend errors from inline assembly. It's not just
internal compiler issues that come through here, so we shouldn't be
creating a backtrace on this path.
rdar://
16329947
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203979
91177308-0d34-0410-b5e6-
96231b3b80d8
Diego Novillo [Fri, 14 Mar 2014 22:07:18 +0000 (22:07 +0000)]
Re-format SampleProfile.cpp with clang-format. No functional changes.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203977
91177308-0d34-0410-b5e6-
96231b3b80d8
Diego Novillo [Fri, 14 Mar 2014 21:58:59 +0000 (21:58 +0000)]
Use DiagnosticInfo facility.
Summary:
The sample profiler pass emits several error messages. Instead of
just aborting the compiler with report_fatal_error, we can emit
better messages using DiagnosticInfo.
This adds a new sub-class of DiagnosticInfo to handle the sample
profiler.
Reviewers: chandlerc, qcolombet
CC: llvm-commits
Differential Revision: http://llvm-reviews.chandlerc.com/D3086
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203976
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Fri, 14 Mar 2014 21:20:07 +0000 (21:20 +0000)]
Remove command line option for CU hashing. This is on by default now.
Fix up testcases and use of flag.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203973
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Fri, 14 Mar 2014 21:16:54 +0000 (21:16 +0000)]
Make the arbitrary section name be something mach-o compatible.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203972
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Fri, 14 Mar 2014 20:53:49 +0000 (20:53 +0000)]
If we see that we're emitting code for a function that doesn't have
any lexical scopes then go ahead and turn on DW_AT_ranges for the
compile unit since we would be claiming to describe in the CU
a range for which we don't have information in the CU otherwise.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203969
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Fri, 14 Mar 2014 20:53:43 +0000 (20:53 +0000)]
Remove the -generate-dwarf-cu-ranges flag.
Rewrite a couple of testcases to cover areas that would be normally
by turning it on into testcases that will follow the logic.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203968
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Fri, 14 Mar 2014 20:36:44 +0000 (20:36 +0000)]
MCDwarf: Initialize MCLineTableHeader::Label
This sometimes remains null into MCLineTableHeader::Emit where we
conditionally construct a label if one isn't provided for us. We need it
to remain null (rather than just always constructing the label) so we
can identify unused line tables... which is a bit weird and maybe we can
do away with that logic one day (& on that day we can always construct
the label up-front and just have compilation units query the line table
for its label, etc)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203967
91177308-0d34-0410-b5e6-
96231b3b80d8