Kostya Serebryany [Thu, 21 Nov 2013 07:29:28 +0000 (07:29 +0000)]
Don't speculate loads under ThreadSanitizer
Summary:
Don't speculate loads under ThreadSanitizer.
This fixes https://code.google.com/p/thread-sanitizer/issues/detail?id=40
Also discussed here: http://lists.cs.uiuc.edu/pipermail/llvmdev/2013-November/067929.html
Reviewers: chandlerc
Reviewed By: chandlerc
CC: llvm-commits, dvyukov
Differential Revision: http://llvm-reviews.chandlerc.com/D2227
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195324
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Thu, 21 Nov 2013 07:04:30 +0000 (07:04 +0000)]
The basic problem is that some mainstream programs cannot deal with the way
clang optimizes tail calls, as in this example:
int foo(void);
int bar(void) {
return foo();
}
where the call is transformed to:
calll .L0$pb
.L0$pb:
popl %eax
.Ltmp0:
addl $_GLOBAL_OFFSET_TABLE_+(.Ltmp0-.L0$pb), %eax
movl foo@GOT(%eax), %eax
popl %ebp
jmpl *%eax # TAILCALL
However, the GOT references must all be resolved at dlopen() time, and so this
approach cannot be used with lazy dynamic linking (e.g. using RTLD_LAZY), which
usually populates the PLT with stubs that perform the actual resolving.
This patch changes X86TargetLowering::LowerCall() to skip tail call
optimization, if the called function is a global or external symbol.
Patch by Dimitry Andric!
PR15086
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195318
91177308-0d34-0410-b5e6-
96231b3b80d8
Paul Robinson [Thu, 21 Nov 2013 06:33:32 +0000 (06:33 +0000)]
Teach ISel not to optimize 'optnone' functions.
Based on work by Andrea Di Biagio.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195317
91177308-0d34-0410-b5e6-
96231b3b80d8
Lang Hames [Thu, 21 Nov 2013 06:30:14 +0000 (06:30 +0000)]
Dereference the node iterator when dumping the PBQP graph structure in DOT
format.
Thanks to Arnaud A. de Grandmaison for the patch!
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195316
91177308-0d34-0410-b5e6-
96231b3b80d8
Reed Kotler [Thu, 21 Nov 2013 05:13:23 +0000 (05:13 +0000)]
Add, to constant islands, long jumps similar to ARM far branch.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195312
91177308-0d34-0410-b5e6-
96231b3b80d8
Yuchen Wu [Thu, 21 Nov 2013 04:53:39 +0000 (04:53 +0000)]
llvm-cov: Don't assume FileChecksum was generated.
For cases where emitProfileArcs() was called but emitProfileNotes() was
not, set the CfgChecksum to 0.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195311
91177308-0d34-0410-b5e6-
96231b3b80d8
Yuchen Wu [Thu, 21 Nov 2013 04:12:10 +0000 (04:12 +0000)]
llvm-cov: Formatting change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195310
91177308-0d34-0410-b5e6-
96231b3b80d8
Yuchen Wu [Thu, 21 Nov 2013 04:01:05 +0000 (04:01 +0000)]
llvm-cov: Fixed some bugs related to file checksum.
Added call to update CfgChecksum. Made FileChecksum a vector, separate
for each source file.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195309
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Thu, 21 Nov 2013 02:11:31 +0000 (02:11 +0000)]
[PM] Add a module analysis pass proxy for the function analysis manager.
This proxy will fill the role of proxying invalidation events down IR
unit layers so that when a module changes we correctly invalidate
function analyses. Currently this is a very coarse solution -- any
change blows away the entire thing -- but the next step is to make
invalidation handling more nuanced so that we can propagate specific
amounts of invalidation from one layer to the next.
The test is extended to place a module pass between two function pass
managers each of which have preserved function analyses which get
correctly invalidated by the module pass that might have changed what
functions are even in the module.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195304
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Thu, 21 Nov 2013 01:29:16 +0000 (01:29 +0000)]
Move DebugInfoOffset member near the other data member it helps describe.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195299
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Thu, 21 Nov 2013 01:29:13 +0000 (01:29 +0000)]
Reflow some documentation and remove whitespace comments. Move
DebugInfoOffset data member up with the rest of the data members.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195298
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Thu, 21 Nov 2013 01:16:31 +0000 (01:16 +0000)]
Add more documenation for the lookup tables data members.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195297
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Thu, 21 Nov 2013 01:14:00 +0000 (01:14 +0000)]
Reorder language in the CompileUnit description and add a comment.
Language may only be a temporary addition.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195296
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Thu, 21 Nov 2013 01:01:30 +0000 (01:01 +0000)]
Update comment.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195293
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Thu, 21 Nov 2013 00:48:22 +0000 (00:48 +0000)]
Constify the DIEs used for pubname and pubtype tables. Propagate
through findAttribute etc.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195290
91177308-0d34-0410-b5e6-
96231b3b80d8
Nick Kledzik [Thu, 21 Nov 2013 00:28:07 +0000 (00:28 +0000)]
YAML I/O add support for validate()
MappingTrait template specializations can now have a validate() method which
performs semantic checking. For details, see <http://llvm.org/docs/YamlIO.html>.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195286
91177308-0d34-0410-b5e6-
96231b3b80d8
Nick Kledzik [Thu, 21 Nov 2013 00:20:10 +0000 (00:20 +0000)]
revert r194655
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195285
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Wed, 20 Nov 2013 20:54:55 +0000 (20:54 +0000)]
PPC popcnt[dw] do not have record forms
The instruction definitions incorrectly specified that popcntd and popcntw have
record forms; they do not. This mistake was causing invalid code generation.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195272
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Wed, 20 Nov 2013 20:54:33 +0000 (20:54 +0000)]
Add loop rerolling code owner
I am the code owner of the loop reroller.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195271
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Wed, 20 Nov 2013 19:08:44 +0000 (19:08 +0000)]
MachineBlockPlacement: Strengthen the source order bias when picking an exit block.
We now only allow breaking source order if the exit block frequency is
significantly higher than the other exit block. The actual bias is
currently under a flag so the best cut-off can be found; the flag
defaults to the old behavior. The idea is to get some benchmark coverage
over different values for the flag and pick the best one.
When we require the new frequency to be at least 20% higher than the old
frequency I see a 5% speedup on zlib's deflate when compressing a random
file on x86_64/westmere. Hal reported a small speedup on Fhourstones on
a BG/Q and no regressions in the test suite.
The test case is the full long_match function from zlib's deflate. I was
reluctant to add it for previous tweaks to branch probabilities because
it's large and potentially fragile, but changed my mind since it's an
important use case and more likely to break with all the current work
going into the PGO infrastructure.
Differential Revision: http://llvm-reviews.chandlerc.com/D2202
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195265
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Wed, 20 Nov 2013 18:52:39 +0000 (18:52 +0000)]
DwarfCompileUnit: Initialize DebugInfoOffset.
While not strictly necessary (the class has an invariant that
"setDebugInfoOffset" is called before "getDebugInfoOffset" - anyone
client that actually gets the default zero offset is buggy/broken) this
is consistent with the code as originally written and the removal of the
initialization was an accident in r195166.
Suggested by Manman Ren.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195263
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Wed, 20 Nov 2013 18:40:16 +0000 (18:40 +0000)]
CR feedback for r195166: Add comments regarding type unit mapping and type units disabling cross-CU sharing.
Changes suggested by Manman Ren.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195262
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Wed, 20 Nov 2013 18:29:56 +0000 (18:29 +0000)]
Make the moved-from SmallPtrSet be a valid, empty, small-state object.
Enhance the tests to actually require moves in C++11 mode, in addition
to testing the moved-from state. Further enhance the tests to cover
copy-assignment into a moved-from object and moving a large-state
object. (Note that we can't really test small-state vs. large-state as
that isn't an observable property of the API really.) This should finish
addressing review on r195239.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195261
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Wed, 20 Nov 2013 18:21:25 +0000 (18:21 +0000)]
Add a test for assignment operator behavior which was changed in
r195239, as well as a comment about the fact that assigning over
a moved-from object was in fact tested. Addresses some of the review
feedback on r195239.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195260
91177308-0d34-0410-b5e6-
96231b3b80d8
Daniel Sanders [Wed, 20 Nov 2013 14:32:28 +0000 (14:32 +0000)]
[mips][msa] Pseudo instructions require HasMSA too. Inherit from MSAPseudo instead of MipsPseudo
There's no test case for this commit. This is because it is doubtful that the
incorrect behaviour can actually trigger. When MSA is not enabled, the type
legalizer should have eliminated all occurrences of patterns the affected
pseudo-instruction could possibly match before instruction selection occurs.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195252
91177308-0d34-0410-b5e6-
96231b3b80d8
Daniel Sanders [Wed, 20 Nov 2013 13:25:05 +0000 (13:25 +0000)]
FileCheck: fix a bug with multiple --check-prefix options. Similar to r194565
Summary:
Directives are being ignored, when they occur between a partial-word false
match and any match on another prefix.
For example, with FOO and BAR prefixes:
_FOO
FOO: foo
BAR: bar
FileCheck incorrectly matches:
fog
bar
This happens because FOO falsely matched as a partial word at '_FOO' and was
ignored while BAR matched at 'BAR:'. The match of BAR is incorrectly returned
as the 'first match' causing the FOO directive to be discarded.
Fixed this the same way as r194565 (D2166) did for a similar test case.
The partial-word false match should be counted as a match for the purposes of
finding the first match of a prefix, but should be returned as a false match
using CheckTy::CheckNone so that it isn't treated as a directive.
Fixes PR17995
Reviewers: samsonov, arsenm
Reviewed By: samsonov
CC: llvm-commits
Differential Revision: http://llvm-reviews.chandlerc.com/D2228
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195248
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Wed, 20 Nov 2013 13:11:48 +0000 (13:11 +0000)]
llvm/CMakeLists.txt: Update LLVM_VERSION_MINOR to 5.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195247
91177308-0d34-0410-b5e6-
96231b3b80d8
Daniel Sanders [Wed, 20 Nov 2013 13:01:10 +0000 (13:01 +0000)]
[mips][msa] Remove unused instruction class MSA_I8_X_DESC_BASE
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195245
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Wed, 20 Nov 2013 11:31:50 +0000 (11:31 +0000)]
[PM] Add the preservation system to the new pass manager.
This adds a new set-like type which represents a set of preserved
analysis passes. The set is managed via the opaque PassT::ID() void*s.
The expected convenience templates for interacting with specific passes
are provided. It also supports a symbolic "all" state which is
represented by an invalid pointer in the set. This state is nicely
saturating as it comes up often. Finally, it supports intersection which
is used when finding the set of preserved passes after N different
transforms.
The pass API is then changed to return the preserved set rather than
a bool. This is much more self-documenting than the previous system.
Returning "none" is a conservatively correct solution just like
returning "true" from todays passes and not marking any passes as
preserved. Passes can also be dynamically preserved or not throughout
the run of the pass, and whatever gets returned is the binding state.
Finally, preserving "all" the passes is allowed for no-op transforms
that simply can't harm such things.
Finally, the analysis managers are changed to instead of blindly
invalidating all of the analyses, invalidate those which were not
preserved. This should rig up all of the basic preservation
functionality. This also correctly combines the preservation moving up
from one IR-layer to the another and the preservation aggregation across
N pass runs. Still to go is incrementally correct invalidation and
preservation across IR layers incrementally during N pass runs. That
will wait until we have a device for even exposing analyses across IR
layers.
While the core of this change is obvious, I'm not happy with the current
testing, so will improve it to cover at least some of the invalidation
that I can test easily in a subsequent commit.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195241
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Wed, 20 Nov 2013 11:14:33 +0000 (11:14 +0000)]
Give SmallPtrSet move semantics when we have R-value references.
Somehow, this ADT got missed which is moderately terrifying considering
the efficiency of move for it.
The code to implement move semantics for it is pretty horrible
currently but was written to reasonably closely match the rest of the
code. Unittests that cover both copying and moving (at a basic level)
added.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195239
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Wed, 20 Nov 2013 10:55:22 +0000 (10:55 +0000)]
X86ISelLowering.cpp: Mark a variable VT as LLVM_ATTRIBUTE_UNUSED. [-Wunused-variable]
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195238
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Wed, 20 Nov 2013 10:55:15 +0000 (10:55 +0000)]
Whitespace.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195237
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Wed, 20 Nov 2013 10:10:50 +0000 (10:10 +0000)]
Update to reflect the next release.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195235
91177308-0d34-0410-b5e6-
96231b3b80d8
Elena Demikhovsky [Wed, 20 Nov 2013 09:23:22 +0000 (09:23 +0000)]
Fixed compilation error.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195230
91177308-0d34-0410-b5e6-
96231b3b80d8
Elena Demikhovsky [Wed, 20 Nov 2013 09:10:40 +0000 (09:10 +0000)]
AVX-512: Concat 4 128-bit vectors in one 512-bit vector.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195229
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Wed, 20 Nov 2013 04:55:20 +0000 (04:55 +0000)]
Add -triple option.
The -triple option is used to create a named tarball of the release binaries.
Also disable the RPATH modifications on Mac OS X. It's not needed.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195193
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Wed, 20 Nov 2013 04:39:16 +0000 (04:39 +0000)]
[PM] Make the function pass manager more regular.
The FunctionPassManager is now itself a function pass. When run over
a function, it runs all N of its passes over that function. This is the
1:N mapping in the pass dimension only. This allows it to be used in
either a ModulePassManager or potentially some other manager that
works on IR units which are supersets of Functions.
This commit also adds the obvious adaptor to map from a module pass to
a function pass, running the function pass across every function in the
module.
The test has been updated to use this new pattern.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195192
91177308-0d34-0410-b5e6-
96231b3b80d8
Yuchen Wu [Wed, 20 Nov 2013 04:15:05 +0000 (04:15 +0000)]
llvm-cov: Added file checksum to gcno and gcda files.
Instead of permanently outputting "MVLL" as the file checksum, clang
will create gcno and gcda checksums by hashing the destination block
numbers of every arc. This allows for llvm-cov to check if the two gcov
files are synchronized.
Regenerated the test files so they contain the checksum. Also added
negative test to ensure error when the checksums don't match.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195191
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Wed, 20 Nov 2013 04:01:38 +0000 (04:01 +0000)]
[PM] Split the analysis manager into a function-specific interface and
a module-specific interface. This is the first of many steps necessary
to generalize the infrastructure such that we can support both
a Module-to-Function and Module-to-SCC-to-Function pass manager
nestings.
After a *lot* of attempts that never worked and didn't even make it to
a committable state, it became clear that I had gotten the layering
design of analyses flat out wrong. Four days later, I think I have most
of the plan for how to correct this, and I'm starting to reshape the
code into it. This is just a baby step I'm afraid, but starts separating
the fundamentally distinct concepts of function analysis passes and
module analysis passes so that in subsequent steps we can effectively
layer them, and have a consistent design for the eventual SCC layer.
As part of this, I've started some interface changes to make passes more
regular. The module pass accepts the module in the run method, and some
of the constructor parameters are gone. I'm still working out exactly
where constructor parameters vs. method parameters will be used, so
I expect this to fluctuate a bit.
This actually makes the invalidation less "correct" at this phase,
because now function passes don't invalidate module analysis passes, but
that was actually somewhat of a misfeature. It will return in a better
factored form which can scale to other units of IR. The documentation
has gotten less verbose and helpful.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195189
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Wed, 20 Nov 2013 01:10:15 +0000 (01:10 +0000)]
PPC: Optimize rldicl generation for masked shifts
Masking operations (where only some number of the low bits are being kept) are
selected to rldicl(x, 0, mb). If x is a logical right shift (which would become
rldicl(y, 64-n, n)), we might be able to fold the two instructions together:
rldicl(rldicl(x, 64-n, n), 0, mb) -> rldicl(x, 64-n, mb) for n <= mb
The right shift is really a left rotate followed by a mask, and if the explicit
mask is a more-restrictive sub-mask of the mask implied by the shift, only one
rldicl is needed.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195185
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Wed, 20 Nov 2013 00:54:31 +0000 (00:54 +0000)]
Remove polymorphic destruction for DIE. DIEBlocks are owned elsewhere
and not polymorphically deleted and they are the only thing that derive
from DIE.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195183
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Wed, 20 Nov 2013 00:54:28 +0000 (00:54 +0000)]
Remove capability for polymorphic destruction from LexicalScope
and LexicalScopes, we're not using it.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195182
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Wed, 20 Nov 2013 00:54:25 +0000 (00:54 +0000)]
Grammar.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195181
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Wed, 20 Nov 2013 00:54:19 +0000 (00:54 +0000)]
Formatting, 80-col, trailing whitespace.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195180
91177308-0d34-0410-b5e6-
96231b3b80d8
Jack Carter [Wed, 20 Nov 2013 00:32:32 +0000 (00:32 +0000)]
long line correction
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195179
91177308-0d34-0410-b5e6-
96231b3b80d8
Jack Carter [Wed, 20 Nov 2013 00:12:44 +0000 (00:12 +0000)]
long line correction
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195175
91177308-0d34-0410-b5e6-
96231b3b80d8
Filip Pizlo [Wed, 20 Nov 2013 00:07:49 +0000 (00:07 +0000)]
Expose the fence instruction via the C API.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195173
91177308-0d34-0410-b5e6-
96231b3b80d8
Aditya Nandakumar [Tue, 19 Nov 2013 23:51:32 +0000 (23:51 +0000)]
Fixed an extra for(typo) in the comments
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195171
91177308-0d34-0410-b5e6-
96231b3b80d8
Jack Carter [Tue, 19 Nov 2013 23:43:22 +0000 (23:43 +0000)]
long lines and white space correction
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195170
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Tue, 19 Nov 2013 23:08:21 +0000 (23:08 +0000)]
DebugInfo: Partial implementation of DWARF type units.
Emit DW_TAG_type_units into the debug_info section using compile unit
headers. This is bogus/unusable by debuggers, but testable and provides
more isolated review.
Subsequent patches will include support for type unit headers and
emission into the debug_types section, as well as comdat grouping the
types based on their hash. Also the CompileUnit type will be renamed
'Unit' and relevant portions pulled out into respective CompileUnit and
TypeUnit types.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195166
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Tue, 19 Nov 2013 22:51:04 +0000 (22:51 +0000)]
DebugInfo: Constify accelerator table handling, and separate type accelarator insertion in preparation for a second use of this code from type units.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195164
91177308-0d34-0410-b5e6-
96231b3b80d8
Arnold Schwaighofer [Tue, 19 Nov 2013 22:20:20 +0000 (22:20 +0000)]
SLPVectorizer: Fix stale for Value pointer array
We are slicing an array of Value pointers and process those slices in a loop.
The problem is that we might invalidate a later slice by vectorizing a former
slice.
Use a WeakVH to track the pointer. If the pointer is deleted or RAUW'ed we can
tell.
The test case will only fail when running with libgmalloc.
radar://
15498655
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195162
91177308-0d34-0410-b5e6-
96231b3b80d8
Arnold Schwaighofer [Tue, 19 Nov 2013 22:20:18 +0000 (22:20 +0000)]
SLPVectorizer: Fix whitespace errors
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195161
91177308-0d34-0410-b5e6-
96231b3b80d8
Petar Jovanovic [Tue, 19 Nov 2013 21:56:00 +0000 (21:56 +0000)]
[mips] Resolve relocation for the stubs in MCJIT when load address is known
Instead of processing relocation for branch to stubs right away, emit a
modified relocation and add it to queue to be resolved later when final load
address is known.
This resolves seven MIPS MCJIT issues that were caused by missing relocation
fixups at the end.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195157
91177308-0d34-0410-b5e6-
96231b3b80d8
Juergen Ributzka [Tue, 19 Nov 2013 21:20:17 +0000 (21:20 +0000)]
[DAG] Refactor vector splitting code in SelectionDAG. No functional change intended.
Reviewed by Tom
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195156
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Tue, 19 Nov 2013 21:12:39 +0000 (21:12 +0000)]
Make it explicit that nulls are not allowed in names.
The object files we support use null terminated strings, so there is no way to
support these.
This patch adds an assert to catch bad API use and an error check in the .ll
parser.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195155
91177308-0d34-0410-b5e6-
96231b3b80d8
Yuchen Wu [Tue, 19 Nov 2013 20:57:20 +0000 (20:57 +0000)]
llvm-cov: Moved printing after error checks.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195153
91177308-0d34-0410-b5e6-
96231b3b80d8
Jack Carter [Tue, 19 Nov 2013 20:53:28 +0000 (20:53 +0000)]
reverts 195057 per request
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195152
91177308-0d34-0410-b5e6-
96231b3b80d8
Yuchen Wu [Tue, 19 Nov 2013 20:33:32 +0000 (20:33 +0000)]
llvm-cov: Added constness property to methods.
Added constness to methods that shouldn't modify objects. Replaced
operator[] lookup in maps with find() instead.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195151
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Tue, 19 Nov 2013 20:28:04 +0000 (20:28 +0000)]
DataLayout: value initialize globals to avoid static construction.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195150
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Tue, 19 Nov 2013 19:52:52 +0000 (19:52 +0000)]
Support multiple COFF sections with the same name but different COMDAT.
This is the first step to fix pr17918.
It extends the .section directive a bit, inspired by what the ELF one looks
like. The problem with using linkonce is that given
.section foo
.linkonce....
.section foo
.linkonce
we would already have switched sections when getting to .linkonce. The cleanest
solution seems to be to add the comdat information in the .section itself.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195148
91177308-0d34-0410-b5e6-
96231b3b80d8
Andrew Trick [Tue, 19 Nov 2013 18:29:45 +0000 (18:29 +0000)]
Obvious pasto survived a couple rounds of cleanup.
Caught by Aaron Ballman.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195138
91177308-0d34-0410-b5e6-
96231b3b80d8
John Thompson [Tue, 19 Nov 2013 17:28:21 +0000 (17:28 +0000)]
YAML I/O - Added default trait support for std:string. Making another attempt at this, this time doing a clean build on Linux, and running the LLVM, clang, and extra tests, to try to make sure there's no problems.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195134
91177308-0d34-0410-b5e6-
96231b3b80d8
Cameron McInally [Tue, 19 Nov 2013 14:36:00 +0000 (14:36 +0000)]
Fix assembly operands for the SSE2 cvtsd2ss instruction.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195129
91177308-0d34-0410-b5e6-
96231b3b80d8
Simon Atanasyan [Tue, 19 Nov 2013 12:20:17 +0000 (12:20 +0000)]
[Mips] Adjust float ABI settings in case of MIPS16 mode.
Hard float for mips16 means essentially to compile as soft float but to
use a runtime library for soft float that is written with native mips32
floating point instructions (those runtime routines run in mips32 hard
float mode).
The patch reviewed by Reed Kotler.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195123
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Tue, 19 Nov 2013 09:28:34 +0000 (09:28 +0000)]
Formatting and 80-col.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195122
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Tue, 19 Nov 2013 09:11:26 +0000 (09:11 +0000)]
Fix comment.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195121
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Tue, 19 Nov 2013 09:04:50 +0000 (09:04 +0000)]
Refactor the section emission code to remove duplicates now that
we can emit various sections in any order.
No functional change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195120
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Tue, 19 Nov 2013 09:04:36 +0000 (09:04 +0000)]
Reformat file.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195119
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Tue, 19 Nov 2013 09:03:18 +0000 (09:03 +0000)]
Fix an issue where SROA computed different results based on the relative
order of slices of the alloca which have exactly the same size and other
properties. This was found by a perniciously unstable sort
implementation used to flush out buggy uses of the algorithm.
The fundamental idea is that findCommonType should return the best
common type it can find across all of the slices in the range. There
were two bugs here previously:
1) We would accept an integer type smaller than a byte-width multiple,
and if there were different bit-width integer types, we would accept
the first one. This caused an actual failure in the testcase updated
here when the sort order changed.
2) If we found a bad combination of types or a non-load, non-store use
before an integer typed load or store we would bail, but if we found
the integere typed load or store, we would use it. The correct
behavior is to always use an integer typed operation which covers the
partition if one exists.
While a clever debugging sort algorithm found problem #1 in our existing
test cases, I have no useful test case ideas for #2. I spotted in by
inspection when looking at this code.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195118
91177308-0d34-0410-b5e6-
96231b3b80d8
Michael Ilseman [Tue, 19 Nov 2013 06:54:19 +0000 (06:54 +0000)]
Add support for software expansion of 64-bit integer division instructions.
Patch by Dmitri Shtilman!
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195116
91177308-0d34-0410-b5e6-
96231b3b80d8
Andrew Trick [Tue, 19 Nov 2013 05:05:43 +0000 (05:05 +0000)]
Fix patchpoint comments.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195103
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Tue, 19 Nov 2013 04:58:46 +0000 (04:58 +0000)]
Add lld to projects to tag.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195102
91177308-0d34-0410-b5e6-
96231b3b80d8
Daniel Jasper [Tue, 19 Nov 2013 04:26:05 +0000 (04:26 +0000)]
Add .clang-format without column limit to subdirectory tests/.
A column limit in the test folder can lead to trouble as the RUN, CHECK,
etc. comments can potentially be broken over multiple lines changing
their meaning. Without column limit, clang-format will simply keep the
test author's line breaks.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195100
91177308-0d34-0410-b5e6-
96231b3b80d8
Andrew Trick [Tue, 19 Nov 2013 03:29:59 +0000 (03:29 +0000)]
Use symbolic operands in the patchpoint folding routine and fix a spilling bug.
Fixes <rdar://
15487687> [JS] AnyRegCC argument ends up being spilled
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195094
91177308-0d34-0410-b5e6-
96231b3b80d8
Andrew Trick [Tue, 19 Nov 2013 03:29:56 +0000 (03:29 +0000)]
Add an abstraction to handle patchpoint operands.
Hard-coded operand indices were scattered throughout lowering stages
and layers. It was super bug prone.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195093
91177308-0d34-0410-b5e6-
96231b3b80d8
Juergen Ributzka [Tue, 19 Nov 2013 03:08:35 +0000 (03:08 +0000)]
[weak vtables] Place class definitions into anonymous namespaces to prevent weak vtables.
This patch places class definitions in implementation files into anonymous
namespaces to prevent weak vtables. This eliminates the need of providing an
out-of-line definition to pin the vtable explicitly to the file.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195092
91177308-0d34-0410-b5e6-
96231b3b80d8
Hao Liu [Tue, 19 Nov 2013 02:17:05 +0000 (02:17 +0000)]
Implement AArch64 neon instructions class SIMD lsone and SIMD lone-post.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195078
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Tue, 19 Nov 2013 02:01:07 +0000 (02:01 +0000)]
Remove unused special member functions and reformat.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195077
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Tue, 19 Nov 2013 01:52:38 +0000 (01:52 +0000)]
Fix previous commit and fully remove variable.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195076
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Tue, 19 Nov 2013 01:50:29 +0000 (01:50 +0000)]
Remove unused variable.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195075
91177308-0d34-0410-b5e6-
96231b3b80d8
Jiangning Liu [Tue, 19 Nov 2013 01:46:48 +0000 (01:46 +0000)]
Implement AArch64 SISD intrinsics for vget_high and vget_low.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195074
91177308-0d34-0410-b5e6-
96231b3b80d8
Kevin Qin [Tue, 19 Nov 2013 01:40:25 +0000 (01:40 +0000)]
implement MC layer of AArch64 neon instruction PMULL and PMULL2 with 128 bit integer.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195072
91177308-0d34-0410-b5e6-
96231b3b80d8
Jiangning Liu [Tue, 19 Nov 2013 01:38:31 +0000 (01:38 +0000)]
Add predicate for AArch64 crypto instructions.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195071
91177308-0d34-0410-b5e6-
96231b3b80d8
Jack Carter [Tue, 19 Nov 2013 01:25:18 +0000 (01:25 +0000)]
[Mips] Support for MicroMips STO refactoring.
No true functional changes.
Change the "hack" name of emitMipsHackSTOCG to emitSymSTO.
Remove demonstration code in AsmParser for emitMipsHackSTOCG and
emitMipsHackELFFlags. The STO field is in an ELF symbol and is not
an explicit directive. That said, we are missing the compliment call
in AsmParser and that will need to be addressed soon.
XFAIL dummy tests for emitMipsHackELFFlags and emitMipsHackELFFlags.
These will built out with following patches.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195067
91177308-0d34-0410-b5e6-
96231b3b80d8
Juergen Ributzka [Tue, 19 Nov 2013 00:57:56 +0000 (00:57 +0000)]
[weak vtables] Remove a bunch of weak vtables
This patch removes most of the trivial cases of weak vtables by pinning them to
a single object file. The memory leaks in this version have been fixed. Thanks
Alexey for pointing them out.
Differential Revision: http://llvm-reviews.chandlerc.com/D2068
Reviewed by Andy
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195064
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Tue, 19 Nov 2013 00:29:42 +0000 (00:29 +0000)]
llvm-dwarfdump: support for emitting only the debug_types section using -debug-dump
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195063
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Mon, 18 Nov 2013 23:59:04 +0000 (23:59 +0000)]
DwarfDebug: Move trailing else to the same line as prior closing brace
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195060
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Mon, 18 Nov 2013 23:57:26 +0000 (23:57 +0000)]
DwarfDebug: Remove some more redundant explicit constructions.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195059
91177308-0d34-0410-b5e6-
96231b3b80d8
Jack Carter [Mon, 18 Nov 2013 23:55:27 +0000 (23:55 +0000)]
[Mips] MipsTargetStreamer refactoring.
No functionality changes.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195057
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Mon, 18 Nov 2013 23:33:32 +0000 (23:33 +0000)]
DebugInfo: Simplify a few more explicit constructions, underconstrained types, and make DIType(MDNode*) explicit like all the other DI* node ctors.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195055
91177308-0d34-0410-b5e6-
96231b3b80d8
Reid Kleckner [Mon, 18 Nov 2013 23:08:12 +0000 (23:08 +0000)]
Revert "COFF: Emit all MCSymbols rather than filtering out some of them"
This reverts commit r190888, to fix PR17967. The original change wasn't
the right way to get @feat.00 into the object file. The right fix is to
make @feat.00 be a global symbol.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195053
91177308-0d34-0410-b5e6-
96231b3b80d8
Adrian Prantl [Mon, 18 Nov 2013 23:04:38 +0000 (23:04 +0000)]
Debug info: Let LowerDbgDeclare perfom the dbg.declare -> dbg.value
lowering only for load/stores to scalar allocas. The resulting values
confuse the backend and don't add anything because we can describe
array-allocas with a dbg.declare intrinsic just fine.
rdar://problem/
15464571
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195052
91177308-0d34-0410-b5e6-
96231b3b80d8
Ahmed Bougacha [Mon, 18 Nov 2013 22:26:59 +0000 (22:26 +0000)]
Docs: tweak code-block spacing.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195049
91177308-0d34-0410-b5e6-
96231b3b80d8
Paul Robinson [Mon, 18 Nov 2013 21:44:03 +0000 (21:44 +0000)]
The 'optnone' attribute means don't inline anything into this function
(except functions marked always_inline).
Functions with 'optnone' must also have 'noinline' so they don't get
inlined into any other function.
Based on work by Andrea Di Biagio.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195046
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Mon, 18 Nov 2013 20:09:55 +0000 (20:09 +0000)]
R600/SI: Fix moveToVALU when the first operand is VSrc.
Moving into a VSrc doesn't always work, since it could be
replaced with an SGPR later.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195042
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Mon, 18 Nov 2013 20:09:50 +0000 (20:09 +0000)]
R600/SI: Fix multiple SGPR reads when using VCC.
No other SGPR operands are allowed, so if VCC is
used, move the other to a VGPR.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195041
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Mon, 18 Nov 2013 20:09:47 +0000 (20:09 +0000)]
R600/SI: Implement add i64, but do not yet enable.
Test doesn't actually check the output. I need
to fix add i64 being matched for the addressing
calculations.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195040
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Mon, 18 Nov 2013 20:09:43 +0000 (20:09 +0000)]
R600/SI: Specify SSrc operands
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195039
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Mon, 18 Nov 2013 20:09:40 +0000 (20:09 +0000)]
R600/SI: addc / adde i32 are legal
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195038
91177308-0d34-0410-b5e6-
96231b3b80d8