Dave Watson [Wed, 18 Feb 2015 17:28:09 +0000 (09:28 -0800)]
some moar unittests
Summary: from discussion
Test Plan: unit tests
Reviewed By: hans@fb.com
Subscribers: doug, folly-diffs@, jsedgwick, yfeldblum
FB internal diff:
D1829282
Signature: t1:
1829282:
1423180907:
3630dac1378750b05f316c672fbbd71138d2bc0a
Dave Watson [Wed, 18 Feb 2015 16:12:06 +0000 (08:12 -0800)]
Use folly's async udp socket
Summary: They are functionaly equivalent, no need to have more than one
Test Plan: fbconfig -r realtime/voip; fbmake runtests
Reviewed By: naizhi@fb.com
Subscribers: trunkagent, doug, ps, bmatheny, folly-diffs@, yfeldblum
FB internal diff:
D1828044
Tasks:
6154007
Signature: t1:
1828044:
1423165354:
f71d2fd28ca76a8f67a597c747f8578d2909823c
Andrii Grynenko [Wed, 18 Feb 2015 01:03:58 +0000 (17:03 -0800)]
Kill get_fast/get_weak_fast Singletonn API
Summary: After
D1827390 regular get and get_weak is comparable to Meyers and static singletons, so there's no need to keey _fast APIs.
Test Plan: benchmark && fbmake
Reviewed By: mshneer@fb.com
Subscribers: trunkagent, configerator-diffs@, fbcode-common-diffs@, mcduff, hitesh, mshneer, fugalh, acampi, alikhtarov, folly-diffs@, jsedgwick, yfeldblum
FB internal diff:
D1843219
Signature: t1:
1843219:
1424216566:
f2f182a1c86bb5f0fb1f978d8c6b7a4388198f5f
Andrei Alexandrescu [Thu, 12 Feb 2015 21:17:31 +0000 (13:17 -0800)]
Migrate FunctionScheduler from common/concurrency/ to folly/experimental/
Summary: This are the open-source-related additions. A separate diff will replace the current implementation in common/concurrency/ to use this one.
Test Plan: fbmake runtests
Reviewed By: simpkins@fb.com
Subscribers: trunkagent, net-systems@, folly-diffs@, yfeldblum
FB internal diff:
D1845525
Signature: t1:
1845525:
1424207291:
d30e3c5e85222527c2aff39c1250aa1e41b9a2cf
Sara Golemon [Tue, 17 Feb 2015 19:45:21 +0000 (11:45 -0800)]
Reformat comment for readability, 80-col rule, and gcc cleanliness
Summary:
The continuation at the end of the line with the while
was causing gcc to complain about it because it's a
single line comment.
Reformat it into a multiline comment and wrap it to 80 chars.
Test Plan: It's just a comment...
Reviewed By: paulbiss@fb.com
Subscribers: trunkagent, folly-diffs@, yfeldblum
FB internal diff:
D1850876
Signature: t1:
1850876:
1424124973:
b2afbc2a8177ac6d11a21bf5a52093bcfd9cbb3e
Hannes Roth [Tue, 17 Feb 2015 19:15:36 +0000 (11:15 -0800)]
(Wangle) Shrink Core to 128 bytes
Summary: I think this makes sense, especially if `interrupt_` is really rare.
Test Plan:
============================================================================
folly/futures/test/Benchmark.cpp relative time/iter iters/s
============================================================================
constantFuture 101.25ns 9.88M
promiseAndFuture 92.86% 109.03ns 9.17M
withThen 28.96% 349.65ns 2.86M
----------------------------------------------------------------------------
oneThen 337.33ns 2.96M
twoThens 58.46% 577.06ns 1.73M
fourThens 32.42% 1.04us 961.23K
hundredThens 1.45% 23.24us 43.04K
----------------------------------------------------------------------------
no_contention 4.45ms 224.48
contention 72.89% 6.11ms 163.61
----------------------------------------------------------------------------
throwAndCatch 6.34us 157.77K
throwAndCatchWrapped 95.65% 6.63us 150.91K
throwWrappedAndCatch 142.58% 4.45us 224.95K
throwWrappedAndCatchWrapped 488.86% 1.30us 771.27K
----------------------------------------------------------------------------
throwAndCatchContended 1.01s 987.01m
throwAndCatchWrappedContended 100.03% 1.01s 987.27m
throwWrappedAndCatchContended 148.37% 682.86ms 1.46
throwWrappedAndCatchWrappedContended 18765.19% 5.40ms 185.21
============================================================================
Compare to
D1843129#31 (seems to be an improvement?)
Reviewed By: hans@fb.com
Subscribers: trunkagent, folly-diffs@, jsedgwick, yfeldblum
FB internal diff:
D1847843
Signature: t1:
1847843:
1423855151:
3602d49df245eda3f85325ab5efd63514213ca44
Jim Meyering [Sat, 14 Feb 2015 01:20:06 +0000 (17:20 -0800)]
ExceptionWrapperTest.cpp vs clang's new warning about side effects in typeid argument list
Summary:
Disable the -Wunevaluated-expression warning for this test:
EXPECT_EQ(typeid(ie), typeid(IntException));
Otherwise, clang warns about the unevaluated expression because
the expansion of EXPECT_EQ applies sizeof to an expression
with side effects:
folly/test/ExceptionWrapperTest.cpp:179:122: error: expression with side effects has no effect in an unevaluated context [-Werror,-Wunevaluated-expression]
switch (0) case 0: default: if (const ::testing::AssertionResult gtest_ar = (::testing::internal:: EqHelper<(sizeof(::testing::internal::IsNullLiteralHelper(typeid(ie))) == 1)>::Compare("typeid(ie)", "typeid(IntException)", typeid(ie), typeid(IntException)))) ; else ::testing::internal::AssertHelper(::testing::TestPartResult::kNonFatalFailure, "folly/test/ExceptionWrapperTest.cpp", 179, gtest_ar.failure_message()) = ::testing::Message();
Test Plan:
Ensure this compiles with clang-3.4, 3.5 and clang:dev.
I.e., ensure that this prints PASS at the end.
for i in '' 3.5 dev; do
test -n "$i" && i=--with-project-version=clang:$i
fbconfig -r --clang $i folly/test:exception_wrapper_test && fbmake dbgo
done && echo PASS
Reviewed By: mpawlowski@fb.com
Subscribers: mathieubaudet, folly-diffs@, yfeldblum
FB internal diff:
D1850778
Tasks:
6244745
Signature: t1:
1850778:
1424111029:
136478e9a3cc3a219047547d501de4c579a1a181
Jim Meyering [Sat, 14 Feb 2015 00:37:37 +0000 (16:37 -0800)]
wangle: make new pragma use portable to older clang
Summary:
* folly/wangle/channel/test/MockChannelHandler.h:
Avoiding a new warning that rendered this file uncompilable
by clang-3.5 and older. Add cpp conditionals to protect
against that.
Test Plan:
Ensure it works with clang-3.4, 3.5 and clang:dev.
I.e., ensure that this prints PASS at the end.
for i in '' 3.5 dev; do
test -n "$i" && i=--with-project-version=clang:$i
fbconfig -r --clang $i folly/wangle/channel/test && fbmake runtests_dbgo
done && echo PASS
Reviewed By: meyering@fb.com
Subscribers: mpawlowski, fugalh, mathieubaudet, folly-diffs@, jsedgwick, yfeldblum
FB internal diff:
D1849474
Tasks:
6244745
Blame Revision:
D1848330
@build-break
Jim Meyering [Fri, 13 Feb 2015 22:37:55 +0000 (14:37 -0800)]
folly: OptionalTest.cpp: suppress a -Wself-move warning
Summary:
Clang's new -Wself-move warning dings this code:
b = std::move(b);
But in this case, that is a deliberate test of
this capability, so we suppress that particular
warning for the duration of this small test function.
Test Plan:
Run this and note that it now compiles: (it passes the tests, too)
fbconfig --clang --with-project-version=clang:dev -r folly/test:optional_test && fbmake dbgo
Reviewed By: watashi@fb.com
Subscribers: folly-diffs@, yfeldblum
FB internal diff:
D1849689
Tasks:
6244745
Signature: t1:
1849689:
1423877932:
4f479d682bd8ba97dcabed7fc29ce0a22c013969
@build-break (using this to work around bogus push failure: https://phabricator.fb.com/P19730606)
Jim Meyering [Fri, 13 Feb 2015 17:23:08 +0000 (09:23 -0800)]
folly/ExceptionWrapper.h: avoid warning about typeid operand side effects
Summary:
* folly/ExceptionWrapper.h (class_name): Clang is not yet smart enough to
see that there is no harm in dereferencing an "item_" that we've just
verified is non-NULL. Accommodate it, to avoid this:
./folly/ExceptionWrapper.h:199:30: error: expression with side effects will be evaluated despite being used as an operand to 'typeid' [-Werror,-Wpotentially-evaluated-expression]
return demangle(typeid(*item_));
^
Test Plan:
Run these commands and note there are fewer errors than before:
fbconfig --clang --with-project-version=clang:dev -r folly && fbmake dbgo
Reviewed By: mhorowitz@fb.com
Subscribers: trunkagent, yfeldblum, folly-diffs@
FB internal diff:
D1848327
Tasks:
6244745
Signature: t1:
1848327:
1423869597:
a58c9e9e3671befb78ae07fbd274a13d08ffb2a7
Blame Revision:
Yedidya Feldblum [Fri, 13 Feb 2015 22:35:04 +0000 (14:35 -0800)]
clang:dev rejects vector<atomic<T>> in EventBaseTest.cpp.
Summary: [Folly] clang:dev rejects vector<atomic<T>> in EventBaseTest.cpp.
Test Plan: Build and run `folly/io/async/test/EventBaseTest.cpp` using the current `clang`; try building with `clang:dev` and verifying that at least the related failures are gone.
Reviewed By: meyering@fb.com
Subscribers: mathieubaudet, folly-diffs@, yfeldblum, dougw, brettp
FB internal diff:
D1848749
Tasks:
6244720
Signature: t1:
1848749:
1423866420:
7b7354d4568b6a6d6a824236ae8d271f6855d90b
Jim Meyering [Fri, 13 Feb 2015 19:06:37 +0000 (11:06 -0800)]
folly: move side effects out of EXPECT_EQ args
Summary:
This avoids warnings about e.g., sizeof(k++) that result
from macro expansion.
* folly/futures/test/ExecutorTest.cpp: Move increment out
of macro argument list.
* folly/test/FBVectorTestBenchmarks.cpp.h: Likewise.
* folly/test/LazyTest.cpp: Likewise.
Otherwise, we'd get errors like this:
folly/test/LazyTest.cpp:49:118: error: expression with side effects has no effect in an unevaluated context [-Werror,-Wunevaluated-expression]
switch (0) case 0: default: if (const ::testing::AssertionResult gtest_ar = (::testing::internal:: EqHelper<(sizeof(::testing::internal::IsNullLiteralHelper(++globalCount())) == 1)>::Compare("++globalCount()", "1", ++globalCount(), 1))) ; else ::testing::internal::AssertHelper(::testing::TestPartResult::kNonFatalFailure, "folly/test/LazyTest.cpp", 49, gtest_ar.failure_message()) = ::testing::Message();
^
Test Plan:
Run these commands and note there are fewer errors than before:
fbconfig --clang --with-project-version=clang:dev -r folly && fbmake dbgo
Reviewed By: njormrod@fb.com
Subscribers: folly-diffs@, jsedgwick, yfeldblum
FB internal diff:
D1848324
Tasks:
6244745
Signature: t1:
1848324:
1423860890:
bce44c5e0895804a21957893ae6b78e76dfbc4d3
Jim Meyering [Fri, 13 Feb 2015 18:36:27 +0000 (10:36 -0800)]
folly: avoid new warnings from -Winconsistent-missing-override
Summary:
Upgrading to clang:dev (clang >3.6) brought in some new warnings.
This change address all of the issues exposed by the new
-Winconsistent-missing-override, usually by simply adding the
missing "override" keyword. However, in
folly/wangle/channel/test/MockChannelHandler.h, I chose
to ignore those warnings for the mocked functions.
* folly/futures/test/ViaTest.cpp: Add missing "override"(s).
* folly/io/async/AsyncSSLSocket.h: Likewise.
* folly/io/async/AsyncSocket.h: Likewise.
* folly/io/async/EventBase.h: Likewise.
* folly/test/ExceptionWrapperTest.cpp: Likewise.
* folly/wangle/channel/AsyncSocketHandler.h: Likewise.
* folly/wangle/channel/test/MockChannelHandler.h: Ignore
the new warning for these functions.
Test Plan:
Run these commands and note there are fewer errors than before:
fbconfig --clang --with-project-version=clang:dev -r folly && fbmake dbgo
Reviewed By: hans@fb.com
Subscribers: trunkagent, fugalh, folly-diffs@, jsedgwick, yfeldblum
FB internal diff:
D1848330
Tasks:
6244745
Signature: t1:
1848330:
1423858909:
b167ca220d6c9fe036d3adca08cf3053a7a9de16
Hannes Roth [Fri, 13 Feb 2015 21:14:22 +0000 (13:14 -0800)]
(Wangle) Have Core own an FSM instead of inheriting
Summary:
This seems cleaner. I also moved a Core member around and changed state to be a smaller size to save us 16 bytes. Might be neat to try to get this down to 128?
Fixed compilation with GCC 4.9, too.
Test Plan: Ran all the tests. Will also benchmark.
Reviewed By: hans@fb.com
Subscribers: trunkagent, folly-diffs@, jsedgwick, yfeldblum
FB internal diff:
D1843129
Signature: t1:
1843129:
1423789502:
60e56d1af553994991195fcc350d37d644a556ca
Jonathan Frank [Fri, 13 Feb 2015 17:59:56 +0000 (09:59 -0800)]
Be able to access proxy client IP (including Lua)
Summary:
Pass TransportInfo object through connection setup. This allows us to
pass along additional info from the setup if necessary.
Test Plan:
Run proxygen on my devserver listening on ipv4 and ipv6 for ports 80 and 443.
Configure it to run a lua request rule with the following lines:
io.stderr:write("jonlog: proxy " .. conn:getClientAddrOriginal() .. "\n")
io.stderr:write("jonlog: client " .. request:getClientIPStr() .. "\n")
Run haproxy also on my devserver, listening on ports 8555-8558, with each
forwarding to one of the four pairs (ipv4-localhost/ipv6-localhost, 80/443)
From my laptop, run curls against each of these four endpoints and make
sure that we print out "127.0.0.1" as the proxy IP, and my laptop's IP
as the client IP.
Reviewed By: cgheorghe@fb.com
Subscribers: jsedgwick, yfeldblum, trunkagent, ruibalp, bmatheny, folly-diffs@, dsp, nbm
FB internal diff:
D1746590
Tasks:
5688127
Signature: t1:
1746590:
1423695880:
f647964d95636a69a00304e144aef71ee0213d28
Giuseppe Ottaviano [Fri, 13 Feb 2015 01:46:14 +0000 (17:46 -0800)]
Fix EliasFanoReader position() when past-the-end
Summary:
`EliasFanoReader::position()` used to return `size() - 1` both when
the reader is positioned on the last element, and after `next()` is
called after that (and it return `false`). Now in the latter case
`position()` returns `size()` (consistently with the usual behaviour
of past-the-end iterators).
Also fix the return type of `jumpTo`.
Test Plan:
fbconfig folly/experimental/test:eliasfano_test && fbmake runtests_opt
Reviewed By: philipp@fb.com
Subscribers: trunkagent, folly-diffs@, yfeldblum
FB internal diff:
D1846275
Signature: t1:
1846275:
1423790264:
151f5d2e1e09d4e24dfb758473dfb9cd52c070bd
Keith Adams [Thu, 12 Feb 2015 23:52:39 +0000 (15:52 -0800)]
std::atomicize MicroSpinLock.
Summary:
A colleague at another company started making fun of
MicroSpinLock for its x86 assembly and ad hoc compiler memory
barriers. Use C++11 (which wasn't really a thing at the time I wrote
this).
Test Plan: folly's runtests. What else would we like?
Reviewed By: andrei.alexandrescu@fb.com
Subscribers: folly-diffs@, yfeldblum
FB internal diff:
D1841563
Signature: t1:
1841563:
1423780458:
a447c081fbd72e3420b23e95dcf26575c9a06798
Giuseppe Ottaviano [Thu, 12 Feb 2015 21:34:47 +0000 (13:34 -0800)]
Elias-Fano micro-optimizations
Summary:
Short skips have been optimized by adding special cases that use simple iteration when it is convenient. Large skips have been optimized by using the broadword selection algorithm by Vigna (improved with ideas by Gog&Petri) instead of iterating on the zeros/ones of the upper bits.
The benchmarks had to be made more granular to measure the differences, in particular they used to test skipping with a fixed skip length for each test, while now we average over a range of skips to better simulate a random distribution.
The improvements are very significant for `skipTo()` on short skips, about 2-3x for skips at distance 1 or 2, which can occur when intersecting dense lists. On large skips the gain is about 17%.
`skip()` exhibits slightly smaller improvements.
before after
============================================================================ ==================
folly/experimental/test/EliasFanoCodingTest.cpp relative time/iter iters/s time/iter iters/s
============================================================================ ==================
Next 2.52ns 396.26M 2.52ns 397.28M
Skip_ForwardQ128(1) 8.66ns 115.52M 3.92ns 255.28M
Skip_ForwardQ128(2) 8.37ns 119.42M 5.08ns 197.04M
Skip_ForwardQ128(4_pm_1) 9.67ns 103.41M 7.04ns 142.02M
Skip_ForwardQ128(16_pm_4) 21.44ns 46.65M 19.68ns 50.82M
Skip_ForwardQ128(64_pm_16) 30.86ns 32.40M 27.58ns 36.26M
Skip_ForwardQ128(256_pm_64) 37.80ns 26.45M 32.49ns 30.78M
Skip_ForwardQ128(1024_pm_256) 38.99ns 25.65M 33.39ns 29.95M
Jump_ForwardQ128 37.91ns 26.37M 34.05ns 29.37M
---------------------------------------------------------------------------- ------------------
SkipTo_SkipQ128(1) 13.87ns 72.10M 4.42ns 226.49M
SkipTo_SkipQ128(2) 18.80ns 53.20M 8.58ns 116.55M
SkipTo_SkipQ128(4_pm_1) 23.59ns 42.38M 11.43ns 87.50M
SkipTo_SkipQ128(16_pm_4) 36.04ns 27.74M 31.19ns 32.06M
SkipTo_SkipQ128(64_pm_16) 53.34ns 18.75M 43.88ns 22.79M
SkipTo_SkipQ128(256_pm_64) 62.27ns 16.06M 49.08ns 20.37M
SkipTo_SkipQ128(1024_pm_256) 65.63ns 15.24M 52.24ns 19.14M
JumpTo_SkipQ128 65.89ns 15.18M 54.61ns 18.31M
---------------------------------------------------------------------------- ------------------
Encode_10 111.94ns 8.93M 117.24ns 8.53M
Encode 5.35ms 187.02 5.64ms 177.15
---------------------------------------------------------------------------- ------------------
Select64 8.07ns 123.96M 8.04ns 124.35M
============================================================================ ==================
Test Plan:
fbconfig folly/experimental/test:eliasfano_test && fbmake runtests_opt
Reviewed By: philipp@fb.com
Subscribers: yfeldblum, fbcode-common-diffs@, chaoyc, search-fbcode-diffs@, unicorn-diffs@, trunkagent, folly-diffs@
FB internal diff:
D1793554
Signature: t1:
1793554:
1423619344:
1b078c0789639f317342ebcc77b11fe91859cd7b
Hannes Roth [Thu, 12 Feb 2015 18:27:33 +0000 (10:27 -0800)]
(Wangle) Catch all exceptions in `then() -> Future`
Summary: Saw this while debugging some stuff. Just an oversight, right?
Test Plan: Ran all the tests.
Reviewed By: hans@fb.com
Subscribers: folly-diffs@, jsedgwick, yfeldblum
FB internal diff:
D1843016
Signature: t1:
1843016:
1423704557:
d9fdb4b879ab4fcfda54a5fcb16a639df15872b5
Sara Golemon [Thu, 12 Feb 2015 16:55:12 +0000 (08:55 -0800)]
Bump version to 26:0
Tom Jackson [Wed, 11 Feb 2015 23:42:11 +0000 (15:42 -0800)]
Making 'just()' reference arguments like 'from()' (fixed)
Summary: That is, for all inputs except r-values. Now with support for GCC.
Test Plan: Run tests
Reviewed By: ajaymenon@fb.com
Subscribers: moharrami, trunkagent, folly-diffs@, yfeldblum
FB internal diff:
D1822339
Signature: t1:
1822339:
1423683482:
027871549d69017a7a23a675025851a0b876ad77
Sara Golemon [Wed, 11 Feb 2015 23:11:14 +0000 (15:11 -0800)]
Remove unsed header from singleton-inl.h
Summary:
This was recently added by @andrii to provide stack traces,
but it no longer needed since he now produces them from a hook in
folly/experimental/SingletonStackTrace.cpp
Test Plan: Continues to build without the include.
Reviewed By: andrii@fb.com
Subscribers: folly-diffs@, yfeldblum, andrii
FB internal diff:
D1842654
Signature: t1:
1842654:
1423696133:
cfa91851f28696082f790eb13c3b0b015c813590
Nathan Bronson [Wed, 11 Feb 2015 22:23:06 +0000 (14:23 -0800)]
Revert "[folly] TLS cache for AccessSpreader"
Summary:
This reverts commit
4ebb2303bbcf343d7c2bcc95d55557c0a3b444f3.
The caching mechanism was based on a misunderstanding of the
implementation of CLOCK_MONOTONIC_COARSE, and is not correct.
On the plus side, the upstream kernel patch
e76b027e6408 x86,vdso: Use LSL unconditionally for vgetcpu
gets the vdso getcpu from 16 nanos down to 10 (half of which is the
inherent indirect call).
Test Plan: unit tests
Reviewed By: delong.j@fb.com
Subscribers: trunkagent, bmaurer, tudorb, folly-diffs@, yfeldblum, jdelong
FB internal diff:
D1840690
Signature: t1:
1840690:
1423693026:
33801341ec0b83bf47e050be6528c5dd05021ed5
Andrii Grynenko [Wed, 11 Feb 2015 21:41:55 +0000 (13:41 -0800)]
Make Singleton dependency on Symbolizer Facebook-only
Summary: Open-source build was broken because Symbolizer is not part of it.
Test Plan: singleton unit test w/ and w/o SingletonStackTrace.cpp linked in.
Reviewed By: alikhtarov@fb.com
Subscribers: trunkagent, folly-diffs@, yfeldblum
FB internal diff:
D1840346
Signature: t1:
1840346:
1423690004:
926c2aa21e0b7916260749120997ad56fab6f742
Sara Golemon [Wed, 11 Feb 2015 02:02:15 +0000 (18:02 -0800)]
Bump version to 25:0
Sara Golemon [Wed, 11 Feb 2015 02:00:05 +0000 (18:00 -0800)]
Autodetect pthread_atfork() support
Summary: This is usually available on linux
Test Plan: Existing tests and manual test on arclinux
Reviewed By: mpawlowski@fb.com
Subscribers: folly-diffs@, yfeldblum
FB internal diff:
D1840081
Signature: t1:
1840081:
1423619986:
911c95f9f04f286e9f113543ab4b705cf1b17396
Ranjeeth Dasineni [Fri, 6 Feb 2015 06:15:05 +0000 (22:15 -0800)]
remove stray / in include path
Summary: removing // as it could break some comment parser
Test Plan: unitz
Reviewed By: dancol@fb.com
Subscribers: trunkagent, doug, seanc, folly-diffs@, yfeldblum
FB internal diff:
D1830591
Signature: t1:
1830591:
1423203436:
9e8b28b714eb2dc080462ab3e8ce04c176df8586
Hans Fugal [Tue, 10 Feb 2015 20:32:04 +0000 (12:32 -0800)]
switch order of method/object in Future::then to match std::bind
Summary:
I have half a mind to just rip this out and let people use std::bind if they need this. But I won't be so cruel.
Why isn't this just implemented as `then(std::bind(method, object))` anyway? Is the template soup we have now faster?
Test Plan:
Fixed the unit tests to use the new format.
Will look to contbuild to catch all the things this might break (if anyone is using it at all?), and will fix them.
Reviewed By: hannesr@fb.com
Subscribers: trunkagent, exa, folly-diffs@, yfeldblum, jsedgwick, davejwatson
FB internal diff:
D1831118
Signature: t1:
1831118:
1423243771:
65db9a89daf14d8bd88331c503ba1ea7ab03b679
Hans Fugal [Tue, 10 Feb 2015 20:24:07 +0000 (12:24 -0800)]
futures::chain
Summary:
`futures::chain<A,Z>(a, b, c, d, e, f, ..., z)` where `a` is a callback suitable for `Future<A>::then` and `z` is a callback suitable for `Future<Y>::then<Z>`.
This will be important, at least in the background, for the new `via`. It will probably also be useful to some user sometime.
I imagine this will be tweaked over time if people find magic ways to get it to deduce the types better. But this works and it's not *too* much trouble to specify A and Z.
Test Plan: unit
Reviewed By: davejwatson@fb.com
Subscribers: trunkagent, exa, folly-diffs@, yfeldblum, jsedgwick
FB internal diff:
D1831073
Tasks:
6048744
Signature: t1:
1831073:
1423259292:
711be0e047a2acb706fd74e529d5d5fb6abda566
Andrii Grynenko [Fri, 6 Feb 2015 03:41:31 +0000 (19:41 -0800)]
folly::Singleton leak diagnostics utils
Summary: This adds different types of messages depending on whether Singleton was depending on other Singleton or just leaked. It also adds destruction stack trace for such Singletons (if they were ever destroyed) to help debug such leaks/broken dependencies.
Test Plan: unit test
Reviewed By: chip@fb.com
Subscribers: trunkagent, folly-diffs@, yfeldblum
FB internal diff:
D1830526
Signature: t1:
1830526:
1423266462:
ba328b0da0bf4030b1c4f686d8f7b609fd20683c
Andrii Grynenko [Wed, 4 Feb 2015 17:48:12 +0000 (09:48 -0800)]
Making each SingletonEntry a singleton
Summary:
Most of the singleton construction logic is moved to SingletonEntry, and each SingletonEntry is now also a singleton.
SingletonVault becomes only responsible for keeping singleton construction order (and potentially dependencies) and destoying them in correct order.
This also significantly improves perf of get() / get_weak() (not-fast)
This diff is based on
D1823663.
Test Plan:
unit test
============================================================================
folly/experimental/test/SingletonTest.cpp relative time/iter iters/s
============================================================================
NormalSingleton 333.35ps 3.00G
MeyersSingleton 99.99% 333.39ps 3.00G
FollySingletonSlow 49.99% 666.84ps 1.50G
FollySingletonFast 95.90% 347.61ps 2.88G
FollySingletonFastWeak 2.22% 15.00ns 66.66M
============================================================================
Reviewed By: chip@fb.com
Subscribers: trunkagent, folly-diffs@, yfeldblum
FB internal diff:
D1827390
Signature: t1:
1827390:
1423268514:
da322d1dcaba54905d478b253f26dd76f890fb4e
Philip Pronin [Tue, 10 Feb 2015 01:54:29 +0000 (17:54 -0800)]
make decodeVarint accept StringPiece
Summary: `decodeVarint` now accepts all of `StringPiece`, `MutableStringPiece`, `ByteRange`, and `MutableByteRange`.
Test Plan: fbconfig -r folly unicorn/utils && fbmake runtests_opt -j32
Reviewed By: ott@fb.com, lucian@fb.com
Subscribers: trunkagent, chaoyc, search-fbcode-diffs@, unicorn-diffs@, folly-diffs@, yzhan, yfeldblum
FB internal diff:
D1836805
Signature: t1:
1836805:
1423534085:
cca5c3e83ad699e5d56e1d1e3394644ec3f94dab
Andre Pinto [Tue, 10 Feb 2015 03:01:47 +0000 (19:01 -0800)]
typo
Summary: Correct typo on docs.
Test Plan: N/A
Reviewed By: alikhtarov@fb.com
Subscribers: folly-diffs@, yfeldblum
FB internal diff:
D1836264
Signature: t1:
1836264:
1423527402:
4e5f263f446346f7145c33c671f0b9e694db15fd
Marcin Pawlowski [Mon, 9 Feb 2015 21:41:02 +0000 (13:41 -0800)]
fix open source build
Summary:
include was missing, causing build to fail on
Arch Linux with gcc 4.9.2 -- found this while resolving
other issues.
Test Plan: build folly on my personal linux and on dev server
Reviewed By: viswanath@fb.com
Subscribers: fugalh, folly-diffs@, jsedgwick, yfeldblum
FB internal diff:
D1835143
Signature: t1:
1835143:
1423513128:
5dcff69a82878f47b40512711ed254f239399c2c
Andrii Grynenko [Fri, 6 Feb 2015 23:48:19 +0000 (15:48 -0800)]
Revert "Revert "Using type-tags for test SingletonVaults""
Summary:
This reverts commit
4893c09795ad4b1187518b184ac4812079039988.
Fix unit test in
D1823663.
Test Plan: fbconfig -r folly fbmake dbg
Reviewed By: alikhtarov@fb.com
Subscribers: folly-diffs@, yfeldblum
FB internal diff:
D1832645
Signature: t1:
1832645:
1423267466:
6012f1d7700d540c7290c29b01b33148cf91183c
Nathan Bronson [Fri, 6 Feb 2015 23:16:53 +0000 (15:16 -0800)]
TLS cache for AccessSpreader
Summary:
Under Linux the process gtod doesn't contain the current cpu, so
__vdso_getcpu uses RDTSCP, which makes it cost about 20 nanos. The gtod
_does_, however, contain a nanosecond time (for CLOCK_REALTIME_COARSE)
updated during context switches. This diff adds a TLS cache that uses
__vdso_clock_gettime_ns(CLOCK_REALTIME_COARSE) to detect context switches.
The end result is that AccessSpreader goes from ~20 nanos to ~6.
Test Plan: unit tests
Reviewed By: davejwatson@fb.com
Subscribers: yfeldblum, trunkagent, folly-diffs@
FB internal diff:
D1798922
Signature: t1:
1798922:
1423264298:
32312a5e9bddb3b8aa630c146ef708164a6a4651
Nicholas Ormrod [Fri, 6 Feb 2015 21:34:15 +0000 (13:34 -0800)]
Revert "Using type-tags for test SingletonVaults"
Summary: This reverts commit
315cfed207895455ecd359d0c1b9d98f28ed0519.
Test Plan:
fbconfig -r folly && fbmake dbg
Reviewed By: robbert@fb.com
Subscribers: sdwilsh, folly-diffs@, yfeldblum
FB internal diff:
D1831932
Signature: t1:
1831932:
1423258329:
0962b939a93bbf1722a9e1c90090dcc024b63765
Blame Revision:
D1823663
Yedidya Feldblum [Fri, 6 Feb 2015 19:37:36 +0000 (11:37 -0800)]
Dedupe the implementations of EventBase::runInEventBaseThreadAndWait.
Summary: [Folly] Dedupe the implementations of EventBase::runInEventBaseThreadAndWait.
Test Plan:
Unit tests:
* `folly/io/async/test/EventBaseTest.cpp`
Reviewed By: subodh@fb.com
Subscribers: trunkagent, folly-diffs@, yfeldblum, dougw, brettp
FB internal diff:
D1826291
Signature: t1:
1826291:
1423225534:
42264d8dcc8adec6b90ac8a3d6ce1f4b98f29297
Blame Revision:
D1810764,
D1823407
Andrii Grynenko [Wed, 4 Feb 2015 00:48:31 +0000 (16:48 -0800)]
Using type-tags for test SingletonVaults
Summary: This makes test SingletonVaults more similar to global SingletonVault. It also ensures that every SingletonVault is a singleton, which allows potential optimization of making each SingletonEntry a Singleton too, which itself will make get/get_weak as efficient as get_fast/get_weak_fast.
Test Plan: unit test
Reviewed By: chip@fb.com
Subscribers: folly-diffs@, yfeldblum
FB internal diff:
D1823663
Signature: t1:
1823663:
1423188884:
4ab2b47cfba270a66613f6f2458b6affc0ed96ad
Hans Fugal [Fri, 6 Feb 2015 00:20:51 +0000 (16:20 -0800)]
make wait() and friends return reference to self instead of new Future
Summary:
we still make the new Future, but assign it to ourselves. this avoids the following buggy pattern that people might expect to work
```
auto f = ...
f.wait();
// Careful. f.value() was moved out into the new Future, so you may have lost something
someOperationOn(f.value());
// Nope. We already set a callback internally in wait()
f.then(...);
```
Test Plan: unit
Reviewed By: davejwatson@fb.com
Subscribers: exa, yfeldblum, trunkagent, fbcode-common-diffs@, sammerat, cold-storage-diffs@, folly-diffs@, jsedgwick, aflock
FB internal diff:
D1809040
Tasks:
6048284
Signature: t1:
1809040:
1422900812:
1b416408eb5eaa71e88778c9c22ed8bfba087efe
Andrei Alexandrescu [Wed, 4 Feb 2015 21:09:20 +0000 (13:09 -0800)]
Add StringKeyed(Unordered){Set,Map} to folly
Summary: We're using StringKeyed* from common/datastruct to avoid unnecessary string creation whenever we're looking up string keys. C++14 does offer a solution, see e.g. http://stackoverflow.com/questions/
10536788/avoiding-key-construction-for-stdmapfind. That is not supported by current compilers.
Test Plan: unittests
Reviewed By: pavlo@fb.com
Subscribers: trunkagent, net-systems@, folly-diffs@, yfeldblum
FB internal diff:
D1825700
Signature: t1:
1825700:
1423086724:
530550c3c80e33c80900f31c0ade05c66b22cbe8
Andrei Alexandrescu [Wed, 4 Feb 2015 19:57:51 +0000 (11:57 -0800)]
Disallow assignment to rvalue Range objects (and StringPiece in particular)
Summary:
Before this diff the code below compiled and did absolutely nothing of interest:
StringPiece fun();
...
fun() = "hello";
i.e. assignment to an rvalue range was allowed. Such code is almost always, if not always, in error. This diff fixes that.
Test Plan: ran unittests
Reviewed By: ldbrandy@fb.com
Subscribers: mpawlowski, net-systems@, folly-diffs@, yfeldblum
FB internal diff:
D1825360
Signature: t1:
1825360:
1423097817:
fdaaf893cd1abbe71dc857a315df7c45cb6a0bd0
Darren Mo [Thu, 5 Feb 2015 17:56:04 +0000 (09:56 -0800)]
Subprocess Process Group Improvements
Summary: Eliminated a potential race condition by removing unnecessary code.
Test Plan: Unit tests pass.
Reviewed By: lesha@fb.com
Subscribers: tudorb, trunkagent, folly-diffs@, yfeldblum
FB internal diff:
D1824924
Signature: t1:
1824924:
1423102017:
6bce388dccf9126d6ac3a1741d8300a51c5276ed
Blame Revision:
D1492526
Yedidya Feldblum [Wed, 4 Feb 2015 23:10:51 +0000 (15:10 -0800)]
Avoid EventBase depending on Baton (mutex/condvar variant).
Summary: [Folly] Avoid EventBase depending on Baton (mutex/condvar variant).
Test Plan:
Unit tests:
* folly/io/async/test/EventBaseTest.cpp
Reviewed By: subodh@fb.com
Subscribers: trunkagent, fma, folly-diffs@, yfeldblum, dougw, brettp
FB internal diff:
D1823407
Signature: t1:
1823407:
1423088450:
71ae1673ed8067103e2aaa1ac9b239eae9ebe9de
Blame Revision:
D1810764
Hans Fugal [Wed, 4 Feb 2015 21:03:26 +0000 (13:03 -0800)]
Fix comment
Summary: It is true. Also, add a useful message about which thread this Future will complete in.
Test Plan: it should still compile
Reviewed By: davejwatson@fb.com
Subscribers: trunkagent, exa, folly-diffs@, jsedgwick, yfeldblum
FB internal diff:
D1819849
Tasks:
5705286,
6008465
Signature: t1:
1819849:
1423074012:
79bf11c877eb2f061cb5d07f7ab45fa4cc4a894b
Hans Fugal [Wed, 4 Feb 2015 20:55:23 +0000 (12:55 -0800)]
Future<T>::onTimeout(Duration, function<T()>, Timekeeper*=nullptr)
Summary:
(or func returns Future<T>)
Invoke and respond to a timeout with a callback, rather than using `within` and adding `onError` or `then` or something.
Test Plan: new tests
Reviewed By: davejwatson@fb.com
Subscribers: jsedgwick, yfeldblum, trunkagent, fugalh, exa, folly-diffs@
FB internal diff:
D1763174
Tasks:
4548494
Signature: t1:
1763174:
1423074062:
05cec1dfb1110b31b599033949ebe0ee70dd0552
Hans Fugal [Wed, 4 Feb 2015 20:54:10 +0000 (12:54 -0800)]
Fix another comment
Summary:
I don't know what this paragraph is even saying. It looks like
copypasta
Test Plan: still compiles or my uncle is a monkey
Reviewed By: davejwatson@fb.com
Subscribers: trunkagent, exa, folly-diffs@, jsedgwick, yfeldblum
FB internal diff:
D1819905
Tasks:
5705286
Signature: t1:
1819905:
1423074021:
a095fe2a17d5698678a527b60c9384625df869fd
Tom Jackson [Wed, 4 Feb 2015 20:51:11 +0000 (12:51 -0800)]
Fixing find_first_of O(n) case
Summary:
The `memchr()`-based `find_first_of()` behaves extremely badly when it's used in a loop and the input string doesn't contain all the needles. This was discovered when a reasonable line-breaking routine tried to use it to break lines by a mix of '\r' and '\n'. The entire remainder of the file was scanned each time a line was read.
Before:
```
CountDelimsBase 1.26s 794.86m
CountDelimsNoSSE 100.03% 1.26s 795.12m
CountDelimsStd 40501.63% 3.11ms 321.93
CountDelimsMemchr 98.31% 1.28s 781.41m
CountDelimsByteSet 23162.41% 5.43ms 184.11
```
After:
```
CountDelimsBase 3.20ms 312.08 <-- Base impl no longer considers memchr
CountDelimsNoSSE 102.37% 3.13ms 319.47
CountDelimsStd 103.19% 3.11ms 322.05
CountDelimsMemchr 0.25% 1.27s 788.39m
CountDelimsByteSet 59.68% 5.37ms 186.27
```
Test Plan: Benchmarks
Reviewed By: njormrod@fb.com
Subscribers: folly-diffs@, yfeldblum
FB internal diff:
D1823536
Signature: t1:
1823536:
1423081687:
bb2ec8cdea477ee9b9c8d8ad2bfdecdc52657515
Sara Golemon [Wed, 11 Feb 2015 01:54:30 +0000 (17:54 -0800)]
Revert "fix configure script to check pthread_atfork(3) in the correct way"
This reverts commit
462e13b135cfa772403fddc16105bf23ea78105a.
Marcin [Mon, 9 Feb 2015 20:02:49 +0000 (20:02 +0000)]
Merge pull request #125 from 0mok/fix-configure-pthread-atfork
fix configure script to check pthread_atfork(3) in the correct way
Brad Kim [Mon, 9 Feb 2015 05:04:00 +0000 (14:04 +0900)]
Merge commit '
64f2f2734ad853784bdd260bcf31e065c47c0741' into fix-configure-pthread-atfork
Andrew Cox [Wed, 4 Feb 2015 21:04:02 +0000 (13:04 -0800)]
Bump version to 24:0
Andrii Grynenko [Wed, 4 Feb 2015 20:01:39 +0000 (12:01 -0800)]
Fix folly::Singleton error message
Test Plan: fbmake runtests
Reviewed By: chip@fb.com, pavlo@fb.com
Subscribers: folly-diffs@, yfeldblum
FB internal diff:
D1825369
Signature: t1:
1825369:
1423080185:
8507643a3f8860bae6a2240e0ae28fbaf2885b12
Dave Watson [Wed, 4 Feb 2015 18:52:49 +0000 (10:52 -0800)]
Future constructor
Summary:
As a replacement for makeFuture(). The main advantage is for non-void futures, implicit conversion works pretty well.
See unittest for examples
Test Plan: fbconfig -r folly/futures; fbmake runtests
Reviewed By: hannesr@fb.com
Subscribers: yfeldblum, trunkagent, doug, folly-diffs@, jsedgwick
FB internal diff:
D1806575
Signature: t1:
1806575:
1422465608:
6099f791591b70ce1bcda439b49307b8f3187d89
Tom Jackson [Wed, 4 Feb 2015 18:52:34 +0000 (10:52 -0800)]
Adding demonstrative test of O(n^2) string split case
Summary:
Even though the benchmark only keeps the first 10 lines, it gets slower the bigger the "file" is.
```
folly/gen/test/StringBenchmark.cpp relative time/iter iters/s
----------------------------------------------------------------------------
Lines_Gen(1e3) 5.53us 180.94K
Lines_Gen(2e3) 66.43% 8.32us 120.21K
Lines_Gen(3e3) 48.26% 11.45us 87.33K
```
Test Plan: Benchmarks
Reviewed By: lesha@fb.com
Subscribers: folly-diffs@, yfeldblum
FB internal diff:
D1823545
Tasks:
6155600
Signature: t1:
1823545:
1423023712:
86fdb3dadbec44195e4b3596cf793cea80ae3a76
Philip Pronin [Tue, 3 Feb 2015 07:53:46 +0000 (23:53 -0800)]
fix AsyncServerSocket::bind issue
Summary:
When closing sockets on retry, we should use `shutdownSocketSet_`
if it is set (so socket will properly be removed from the set).
Also I changed all `::close()` and `::shutdown()` calls to `*NoInt()`
version.
Test Plan:
fbconfig unicorn/test:basic_compression_test && fbmake opt -j32
while _bin/unicorn/test/test:basic_compression_test; do echo DONE; done
Reviewed By: mcduff@fb.com
Subscribers: trunkagent, folly-diffs@, yzhan, yfeldblum
FB internal diff:
D1821104
Tasks:
4752579,
6123510
Signature: t1:
1821104:
1423001050:
5bc09ffdd6666c2884ea82dbd70831a56513cfc9
Blame Revision:
D1795120
Tianjiao Yin [Tue, 3 Feb 2015 22:03:18 +0000 (14:03 -0800)]
print better error message
Summary:
before:
E0203 12:32:34.548096
3354863 [admonitor-local] Singleton.cpp:72] Singleton of type N8facebook12configerator22ConfigeratorStaticDataE has a living reference at destroyInstances time; beware! Raw pointer is 0x7fd6ccc81000. It is very likely that some other singleton is holding a shared_ptr to it. Make dependencies between these singletons are properly defined.
after:
E0203 13:48:09.013022
3913115 Singleton.cpp:72] Singleton of type facebook::configerator::ConfigeratorStaticData has a living reference at destroyInstances time; beware! Raw pointer is 0x7f6f7dc4c000. It is very likely that some other singleton is holding a shared_ptr to it. Make dependencies between these singletons are properly defined.
Test Plan: run it
Reviewed By: chip@fb.com
Subscribers: folly-diffs@, yfeldblum
FB internal diff:
D1822466
Signature: t1:
1822466:
1423000686:
345f40fa706701476256a7157468521bc69166a0
Dave Watson [Mon, 2 Feb 2015 22:10:44 +0000 (14:10 -0800)]
kill asyncsslserversocket
Summary: This was only used in a unittest, every real use case uses AsyncServerSocket, and decides on its own to do SSL or not.
Test Plan: fbconfig -r thrift/lib/cpp/test; fbmake runtests
Reviewed By: alandau@fb.com
Subscribers: fugalh, trunkagent, doug, alandau, bmatheny, ssl-diffs@, mshneer, jsedgwick, folly-diffs@
FB internal diff:
D1806807
Signature: t1:
1806807:
1422396209:
02333c736e1ef10963e3fe0b4ed6ecf6122475bb
Dave Watson [Tue, 27 Jan 2015 21:05:18 +0000 (13:05 -0800)]
Remove request context enable flag
Summary:
Originally meant as a kill switch. It's turned on in everything except adfinder, so we can probably remove this flag after running a couple adfinder canaries
I have no idea who should review this in ads team, guessed and added some people
Test Plan: https://our.intern.facebook.com/intern/tupperware/canary/view/?experiment_id=32937
Reviewed By: haijunz@fb.com
Subscribers: trunkagent, doug, ruibalp, nli, alandau, bmatheny, wormhole-diffs@, mshneer, folly-diffs@
FB internal diff:
D1809255
Tasks:
5645329
Signature: t1:
1809255:
1422490068:
5b4551e6c126d86cac8f8e7b06da6474e6b8a25a
Andrii Grynenko [Wed, 28 Jan 2015 04:09:27 +0000 (20:09 -0800)]
Wait for some time if Singleton isn't destroyed immediately
Summary: This diff introduces 5 seconds wait time to let other threads release Singleton which may be temporarily locked. This helps prevent most of "Singleton object alive after destruction" warnings in cases where weak_ptr API is used correctly. Abusive use of folly::Singletons, where dependencies between singletons are not properly defined will still cause a warning.
Test Plan: unit test
Reviewed By: chip@fb.com
Subscribers: trunkagent, folly-diffs@
FB internal diff:
D1808371
Signature: t1:
1808371:
1422487261:
573eb40b6a260e428d96be476659335250c7ea76
Haijun Zhu [Mon, 2 Feb 2015 19:41:38 +0000 (11:41 -0800)]
Set CLOEXEC for connected fd
Summary:
AsyncSocket sets CLOEXEC if it connects an address, but won't
if it uses a connected fd. This sets CLOEXEC for such fd.
Test Plan: fbconfig folly/io/async/test && fbmake runtests
Reviewed By: davejwatson@fb.com
Subscribers: trunkagent, folly-diffs@, zacm
FB internal diff:
D1809300
Signature: t1:
1809300:
1422900997:
40fcc84506582ac67076fd975a36d094522c35c2
Yedidya Feldblum [Mon, 2 Feb 2015 19:37:23 +0000 (11:37 -0800)]
EventBase::runInEventLoopThreadAndWait.
Summary:
[Folly] EventBase::runInEventLoopThreadAndWait.
Useful for when some code needs to be run in the event loop thread, but another thread needs to trigger the code and then wait for it to be done.
Test Plan:
Unit tests:
* `folly/io/async/test/EventBaseTest.cpp`
Reviewed By: davejwatson@fb.com
Subscribers: trunkagent, folly-diffs@, brettp, dougw
FB internal diff:
D1810764
Signature: t1:
1810764:
1422900654:
7ff0aa7feb2792266f620b344cf8a1110a09f7ef
Brad Kim [Wed, 4 Feb 2015 15:27:55 +0000 (00:27 +0900)]
fix configure script to check pthread_atfork(3) in the correct way
woo [Mon, 2 Feb 2015 21:15:32 +0000 (13:15 -0800)]
Bump version to 23:0
Marcin Pawlowski [Wed, 28 Jan 2015 00:01:46 +0000 (16:01 -0800)]
fixing readme and configure script links to double-conv
Summary:
Fixing following the issues raised by nsuke on github
following his diff (https://github.com/facebook/folly/pull/112)
Test Plan: visual inspection, tested build on arch linux
Reviewed By: davejwatson@fb.com
Subscribers: folly-diffs@
FB internal diff:
D1807378
Tasks:
5909189
Signature: t1:
1807378:
1422403093:
ca024f396a27ecd9b304c57643f0107764a38ca1
Nathan Bronson [Mon, 2 Feb 2015 16:46:18 +0000 (08:46 -0800)]
add some missing methods to DeterministicAtomic
Summary:
fetch_and and fetch_or are actually required in some instances,
since the operation they perform isn't reversible. This also adds some
other missing functions, ^= and fetch_{add,sub,xor}.
Test Plan: use from other code's unit tests
Reviewed By: mssarang@fb.com
Subscribers: yfeldblum, folly-diffs@
FB internal diff:
D1798924
Signature: t1:
1798924:
1422892374:
a9859039075ddcac54f75259b9bc6a29bb963a09
Chip Turner [Sat, 31 Jan 2015 03:51:20 +0000 (19:51 -0800)]
Revert "[folly::gen] Making 'just()' reference arguments like 'from()'"
Summary: This reverts commit
90da92b05762f8032560d0d6a66237ab2772d7f2.
Test Plan: compiles
Reviewed By: tjackson@fb.com
Subscribers: lins, anca, folly-diffs@, yfeldblum
FB internal diff:
D1817376
Tasks:
6118752
Hans Fugal [Fri, 30 Jan 2015 23:23:24 +0000 (15:23 -0800)]
Rework the Future::Core state machine
Summary:
There was a race reading `callback_` in `maybeCallback` and setting `callback_` in `setCallback`. This diff reworks the state machine to make this unpossible. To avoid the explosion of states due to the cross-product of has-interrupt-handler/has-been-interrupted/etc. I introduce a separate lock for setting interrupt handler and interruption, since this is primarily orthogonal. Other attributes (active, for example) are still atomic variables, and while somewhat tied into the state machine logically (e.g. transitioning from Armed to Done only happens when active) they are mostly independent, keeping the state machine simple (and probably faster).
I think it may even be possible to do some things cheaper. In some states, we may not need to protect the writing of `callback_` and `result_`. But we'd need to enforce some ordering so I'm not going to try to tackle that. But that could be some speedup if we can do it cheaply.
Test Plan:
Builds and all existing tests pass.
Reviewed By: rockyliu4@fb.com
Subscribers: yfeldblum, stepan, trunkagent, exa, folly-diffs@, jsedgwick
FB internal diff:
D1807854
Tasks:
6087856
Signature: t1:
1807854:
1422656713:
25b62706cd7952b2dde06dab08074f8030db456b
Nathan Bronson [Thu, 29 Jan 2015 20:02:45 +0000 (12:02 -0800)]
cautionary comment in futexWake
Summary:
Add a description of the fault-after-unlock problem that can
occur when a synchronization object is used to guard its own
destruction.
Test Plan: comment change only
Reviewed By: alikhtarov@fb.com
Subscribers: trunkagent, folly-diffs@
FB internal diff:
D1808446
Signature: t1:
1808446:
1422481173:
83c0369e2277cd5b8cf6377fcd92b132019611a7
Tom Jackson [Thu, 29 Jan 2015 18:56:30 +0000 (10:56 -0800)]
Making 'just()' reference arguments like 'from()'
Summary: That is, for all inputs except r-values.
Test Plan:
Run tests
@override-test-failures
Reviewed By: ajaymenon@fb.com
Subscribers: trunkagent, folly-diffs@
FB internal diff:
D1807789
Signature: t1:
1807789:
1422410689:
442d50ab17f8e3b08e34f33318a4dc7f23b4c6cc
Shijin Kong [Thu, 29 Jan 2015 18:54:53 +0000 (10:54 -0800)]
enable ssl false start with Next Protocol Negotiation (NPN) extension
Summary:
This speeds up TLS handshake and might be a factor of liger perf regression.
The enabling is guarded by an #ifdef. The condition itself is defined in an
openssl patch.
Test Plan: folly unit tests pass. Tried on devices as well and from tcpdump data was sent before the new ticket was received, essentially speeded up the handshake process.
Reviewed By: subodh@fb.com
Subscribers: trunkagent, kmdent, seanc, benyluo, ssl-diffs@, ranjeeth, folly-diffs@
FB internal diff:
D1806856
Tasks:
5284979
Signature: t1:
1806856:
1422494521:
0a048ea9001da13b5d698b5a764d1e66dcbedc99
Tom Jackson [Thu, 29 Jan 2015 18:22:59 +0000 (10:22 -0800)]
indirect(), for making pointers out of refs
Test Plan: Unit tests
Reviewed By: ajaymenon@fb.com
Subscribers: trunkagent, folly-diffs@
FB internal diff:
D1808023
Signature: t1:
1808023:
1422410709:
8db2d73d5b4c0c2eab563643e5fa1557ebfd4730
Sean Cannella [Wed, 28 Jan 2015 23:28:58 +0000 (15:28 -0800)]
Cleanup duplicate include
Summary:
Included climits and limits.h due to non-conflicting changes,
clean this up.
Test Plan: compiled
Reviewed By: kelarini@fb.com
Subscribers: trunkagent, folly-diffs@
FB internal diff:
D1810133
Signature: t1:
1810133:
1422483209:
0826d2198769efed86607de6c5b28ce0bc4ac04b
James Sedgwick [Wed, 28 Jan 2015 21:55:45 +0000 (13:55 -0800)]
fix deprecated Promise::setException()
Summary: should have been using fulfilTry anyways. and fulfilTry needs to take the Try by value so fix that too
Test Plan: unit
Reviewed By: hans@fb.com
Subscribers: fugalh, folly-diffs@, jsedgwick
FB internal diff:
D1808923
Tasks:
6098987
Signature: t1:
1808923:
1422478981:
d4b9727394339c996ebccb7841b94e0c7b2bffb4
Kyle Dent [Wed, 28 Jan 2015 21:47:43 +0000 (13:47 -0800)]
Fixing break in multifeed. CHAR_BIT was previously unfound
Summary: Now CHAR_BIT will be found
Test Plan: ran multifeed and folly
Reviewed By: seanc@fb.com
Subscribers: seanc, folly-diffs@
FB internal diff:
D1810027
Signature: t1:
1810027:
1422480946:
4568c5190e318ff097d33b3d0434593b72f8205e
Khalid El-Arini [Wed, 28 Jan 2015 21:47:44 +0000 (13:47 -0800)]
fix missing header in Range.h
Summary: ^
Test Plan: fbmake
Reviewed By: woo@fb.com
Subscribers: folly-diffs@
FB internal diff:
D1810061
Signature: t1:
1810061:
1422481560:
089c9186834f2bf87ac6d10b71d53784299b7992
Blame Revision:
D1806632
Viswanath Sivakumar [Wed, 28 Jan 2015 20:08:36 +0000 (12:08 -0800)]
Convert TransportInfo SSL fields to shared_ptrs
Summary:
We do a lot of copying of TransportInfo in proxygen, and in most cases
the SSL structs don't change after connection establishment. We could
cut down on memory usage by sharing these huge strings. This is
especially true with SPDY where all streams belonging to a session could
share these fields.
Facebook:
Test Plan: Unit tests, will canary
Reviewed By: afrind@fb.com
Subscribers: fugalh, bmatheny, ssl-diffs@, folly-diffs@, jsedgwick, woo
FB internal diff:
D1807557
Tasks:
5343753
Signature: t1:
1807557:
1422472932:
53038345fca620632097586fb9e410bca8fe748d
Kyle Dent [Wed, 28 Jan 2015 19:33:49 +0000 (11:33 -0800)]
Fixing a -Wshorten-64-32 issues in folly for liger.
Summary: Normally I would use the folly::to<> function, but it would cause a circular dependency, so I just added a static cast
Test Plan: Ran on iOS and ran the folly tests
Reviewed By: seanc@fb.com
Subscribers: lucian, mpawlowski, marcelo, tudorb, aalexandre, seanc, folly-diffs@
FB internal diff:
D1806632
Signature: t1:
1806632:
1422416646:
b8104f18f90eb7457f2f358428f2bd800f8f1db5
James Sedgwick [Wed, 28 Jan 2015 19:01:44 +0000 (11:01 -0800)]
kill a couple unnecessary rethrows
Summary: as above, there were less of these than I expected, nice
Test Plan: unit
Reviewed By: hans@fb.com
Subscribers: trunkagent, folly-diffs@, jsedgwick
FB internal diff:
D1789332
Tasks:
5949939
Signature: t1:
1789332:
1421878033:
d7c2979a77b51a5257b8bcd910ad9296ca1aa7e0
Sean Cannella [Wed, 28 Jan 2015 16:47:51 +0000 (08:47 -0800)]
Fix Conv.h compilation on Android
Summary:
std::to_string doesn't exist on Android so don't use it.
Facebook: Did a sync to fbandroid and confirmed liger compiles with this fix.
Test Plan: existing tests
Reviewed By: ranjeeth@fb.com
Subscribers: trunkagent, folly-diffs@, shikong, kmdent, fma, pgriess
FB internal diff:
D1808037
Signature: t1:
1808037:
1422410556:
d78e0633a1554254b1a1f25bef49a4550a1817c6
James Sedgwick [Wed, 28 Jan 2015 16:05:30 +0000 (08:05 -0800)]
Another stab at waitWithSemaphore -> Future<T>::wait()
Summary:
See
D1785572. Check out the new Future test and the commented portion of wait(Duration) for the fix
The test only fails a few times out of a hundred before the fix, but hasn't failed yet after
Test Plan: futures unit, wait for contbuild
Reviewed By: hans@fb.com
Subscribers: trunkagent, rushix, fbcode-common-diffs@, hero-diffs@, cold-storage-diffs@, adamsyta, zhuohuang, darshan, micha, folly-diffs@, lins, tingy, hannesr, jsedgwick
FB internal diff:
D1803526
Tasks:
5940008,
6059995
Signature: t1:
1803526:
1422309486:
3613c59a708ecac312d241723828763feb2a57aa
Andrei Alexandrescu [Wed, 28 Jan 2015 00:21:22 +0000 (16:21 -0800)]
Add writeFile function to folly
Summary: Reciprocal of readFile
Test Plan: fbmake runtests
Reviewed By: tudorb@fb.com
Subscribers: trunkagent, net-systems@, folly-diffs@
FB internal diff:
D1807551
Signature: t1:
1807551:
1422410565:
f5bda294deb788da9f3881c19bb20cfa1f588c09
Marcin Pawlowski [Wed, 28 Jan 2015 00:01:46 +0000 (16:01 -0800)]
fixing readme and configure script links to double-conv
Summary:
Fixing following the issues raised by nsuke on github
following his diff (https://github.com/facebook/folly/pull/112)
Test Plan: visual inspection, tested build on arch linux
Reviewed By: davejwatson@fb.com
Subscribers: folly-diffs@
FB internal diff:
D1807378
Tasks:
5909189
Signature: t1:
1807378:
1422403093:
ca024f396a27ecd9b304c57643f0107764a38ca1
Claudiu Gheorghe [Mon, 26 Jan 2015 22:59:46 +0000 (14:59 -0800)]
make getFD() a const method on AsyncUDPServerSocket
Summary: no need to be mutable, since it only calls AsyncUDPSocket::getFD() which is a const method
Test Plan: just compiled -- simple change
Reviewed By: afrind@fb.com
Subscribers: trunkagent, doug, folly-diffs@
FB internal diff:
D1802765
Signature: t1:
1802765:
1422307972:
eab6ab4b16407df6e5034cef78c79f45cd9fa46f
Marcin Pawlowski [Mon, 26 Jan 2015 21:57:21 +0000 (13:57 -0800)]
fix folly build under python 3
Summary:
Make python scripts compatible woth both python 3 and python 2.
Added ignore rule for test/glog directory.
Facebook:
While verifying some issues reported on github i noticed that
folly does not build when python 3 is the default (at least on arch
linux). As it turns out it is fairly easy to make our python files
compatible with both python 2 and python 3.
I also added test/glog*/* to gitignore so that it is easier to work
on folly outside of facebook.
Test Plan:
unit tests in fb envirnoment and unit test on arch linux
(python 3.4.2, gcc 4.9.2)
Reviewed By: njormrod@fb.com
Subscribers: trunkagent, folly-diffs@
FB internal diff:
D1801368
Signature: t1:
1801368:
1422294777:
4e7b6b5634e8dccd849194e171c9a342bd1cb8b8
Lucian Grijincu [Mon, 26 Jan 2015 21:43:36 +0000 (13:43 -0800)]
folly: to: make exceptions more informative
Summary: print the value which failed conversion to aid debugging.
Test Plan: run code which throws in to<> and contbuild
Reviewed By: tudorb@fb.com, andrei.alexandrescu@fb.com
Subscribers: trunkagent, folly-diffs@
FB internal diff:
D1786294
Signature: t1:
1786294:
1421795912:
00cc10923990e5aac0a15eedec09deb8e8d470d1
Hannes Roth [Mon, 26 Jan 2015 20:53:42 +0000 (12:53 -0800)]
(Wangle) Then Magic
Summary: All is good now.
Test Plan: Run all the tests.
Reviewed By: hans@fb.com
Subscribers: jsedgwick, trunkagent, fugalh, folly-diffs@
FB internal diff:
D1758272
Signature: t1:
1758272:
1421889405:
a015d30783715e106a1e6667e971f7cf47c8392d
Hannes Roth [Mon, 26 Jan 2015 17:08:49 +0000 (09:08 -0800)]
(Wangle) Don't add an extra value() call for makeFuture(Try)
Summary: Not sure why we'd need that? This avoids a move, I think.
Test Plan:
Run all the tests. Also unbreaks this code, which used to work at some
point.
https://phabricator.fb.com/diffusion/FBCODE/browse/master/taoThriftService/TaoServiceHandler.cpp;
a27bc2ef36cd671d65ae0fd2cc1fb1f823e68ae4$246
Reviewed By: hans@fb.com
Subscribers: trunkagent, folly-diffs@, jsedgwick
FB internal diff:
D1800619
Signature: t1:
1800619:
1422053903:
f9e65a0be3d820a9a9989b3cf5dfaf2a61e2e900
Mark McDuff [Sat, 24 Jan 2015 09:23:20 +0000 (01:23 -0800)]
fix memory leak in AsyncServerSocket
Test Plan: g-unittest
Reviewed By: philipp@fb.com
Subscribers: folly-diffs@
FB internal diff:
D1801665
Signature: t1:
1801665:
1422093104:
eecf86ea8c1ab39dcb3d01442ed66ae45ef3bede
Mark McDuff [Thu, 22 Jan 2015 00:18:25 +0000 (16:18 -0800)]
make AsyncServerSocket bind to same port on ipv4 and ipv6 with port=0
Summary: I'm in unfamiliar territory, so shout if I'm doing something dumb. Perhaps it's a bad assumption that if the ipv4 port is free that the ipv6 port is also free?
Test Plan: g-unittest
Reviewed By: davejwatson@fb.com
Subscribers: trunkagent, ps, bmatheny, folly-diffs@
FB internal diff:
D1795120
Signature: t1:
1795120:
1422034693:
bd315023ab6cd9e9bda12161d05dd781dc401546
Woo Xie [Fri, 23 Jan 2015 18:21:38 +0000 (10:21 -0800)]
specify connection's idle tiemout
Summary: Now all connections are always scheduled with connectionManager's default timeout. This diff enables us to specify the different timeouts for each managed connections.
Test Plan: prospect testing
Reviewed By: davejwatson@fb.com
Subscribers: trunkagent, fugalh, folly-diffs@, jsedgwick
FB internal diff:
D1797193
Tasks:
5343753
Signature: t1:
1797193:
1422034092:
ed67b96efe8af8f8d1355d3f86fb1289daafb178
Dave Watson [Fri, 23 Jan 2015 17:50:35 +0000 (09:50 -0800)]
Finagle interfaces
Summary: Future service interfaces similar to finagle. Service creators for client, filters
Test Plan: Unittests included - also sets up a simple pipeline to test a full stack client/server.
Reviewed By: hans@fb.com
Subscribers: jsedgwick, trunkagent, njormrod, folly-diffs@, doug, fugalh
FB internal diff:
D1573086
Tasks:
5002456
Signature: t1:
1573086:
1421970698:
328453c4a980bb6950fc9aeed6a2b6d9819c20db
Dave Watson [Thu, 22 Jan 2015 20:32:26 +0000 (12:32 -0800)]
Revert "[futures] waitWithSemaphore -> Future<T>::wait()"
Summary:
Subject:
This reverts commit
d8eeb9a12f932b74d268c74ce7ce2610dc14b152.
Test Plan: Watch contbuild?
Reviewed By: njormrod@fb.com
Subscribers: trunkagent, doug, fbcode-common-diffs@, hero-diffs@, cold-storage-diffs@, adamsyta, zhuohuang, darshan, micha, folly-diffs@, lins, tingy, hannesr, jsedgwick
FB internal diff:
D1797163
Tasks:
5940008
Signature: t1:
1797163:
1421959040:
c9d528367fed2de2f7dafdac9416aa01bdb47df9
Andrii Grynenko [Thu, 22 Jan 2015 19:07:08 +0000 (11:07 -0800)]
Fix ASAN failures in OBCClient
Summary:
This also adds a dependency from all folly::Singletons on RequestContext. Better fix would probaly be to switch RequestContext to be managed by folly::Singleton, however that would require us to switch all singletons which use it to be folly::Singletons too.
Facebook:
Making sure we initialize SR singletons when OBCClient singleton is created, so that SR is destoyed after OBCClient.
Test Plan:
fbconfig -r --sanitize=address --platform-all=gcc-4.8.1-glibc-2.17 dragon/
fbmake runtests
Reviewed By: meyering@fb.com, davejwatson@fb.com
Subscribers: trunkagent, folly-diffs@, meyering
FB internal diff:
D1796847
Tasks:
5986816
Signature: t1:
1796847:
1421954531:
e9ec177d5289a33c12fe0947426d89963c8e262c
Adam Simpkins [Fri, 16 Jan 2015 02:35:56 +0000 (18:35 -0800)]
Add additional instantiations in Instantiations.cpp
Summary:
Histogram::getPercentileBucketIdx() and getPercentileEstimate() are
implemented using template methods of HistogramBuckets.
This updates Instantiations.cpp to also instantiate the versions of
these template methods that are required by Histogram<int64_t>. Without
this, anyone using these methods was required to also include
Histogram-defs.h, or otherwise they may get link errors. This makes it
so they no longer need to include Histogram-defs.h
The C++ syntax required is pretty horrendous. We could potentially
avoid this by refactoring the code so that these methods are no longer
templates (and require that the Bucket class provide methods for this
purpose). At the moment adding instantiations seems simpler, and
doesn't change any public APIs.
Test Plan:
Successfully linked code using
Histogram<int64_t>::getPercentileEstimate() without including
Histogram-defs.h
Reviewed By: ldbrandy@fb.com, meyering@fb.com
Subscribers: trunkagent, doug, net-systems@, exa, folly-diffs@
FB internal diff:
D1786346
Signature: t1:
1786346:
1421429734:
da17b7ea326c64a1e158fec3b87dc49c3db3d848
Adam Simpkins [Thu, 15 Jan 2015 00:00:31 +0000 (16:00 -0800)]
add IOBuf::appendToIov()
Summary:
This splits out some code from the existing getIov() method, to support
appending to an existing iovec array, rather than always returning a new
one.
I have a use case where I have multiple IOBuf chains to write at once,
preceded by some header data. appendToIov() makes it easier to populate
a single iovec array with this data, and then perform a single writev()
call.
Test Plan: Updated the unit tests to exercise appendToIov()
Reviewed By: jasmeetbagga@fb.com
Subscribers: trunkagent, doug, exa, net-systems@, folly-diffs@
FB internal diff:
D1783090
Tasks:
Signature: t1:
1783090:
1421450476:
d5c89d6e1adbd2f2239057238e020b302df09f23
Blame Revision:
James Sedgwick [Wed, 21 Jan 2015 21:39:03 +0000 (13:39 -0800)]
getVia() and waitVia()
Summary:
Introduce ProgressableExecutor, which is an Executor that can be driven somehow. Examples include EventBase and ManualExecutor
Then introduce Future<T>::getVia(ProgressableExecutor*) and Future<T>::waitVia(ProgressableExecutor*) that drive the given executor until the Future is complete, with the usual semantics of get and wait respectively
This is a really common pattern in tests and you can see in the various changes to other projects lends sopme nice redness and cleanliness
Some notes:
1. I don't like ProgressableExecutor::makeProgress() that much. Too verbose. Maybe DrivableExecutor::drive()? Something else? Thoughts?
2. I still need to integrate this with some stuff in Zeus (SessionFuture) and Zookeeper (ZookeeperFuture) but I'm going to do that in a separate diff because it's going to be a little more intrusive
3. These APIs take a raw ptr so that they are consistent with via()
4. See inline note on ManualExecutor
5. See inline note in added unit tests
Test Plan: add unit for new API, wait for contbuild
Reviewed By: hans@fb.com
Subscribers: trunkagent, dresende, pzq, tdimson, fbcode-common-diffs@, targeting-diff-backend@, alandau, apollo-diffs@, bmatheny, everstore-dev@, zhuohuang, laser-diffs@, mshneer, folly-diffs@, hannesr, jsedgwick
FB internal diff:
D1789122
Tasks:
5940008
Signature: t1:
1789122:
1421868315:
6ea2fc2702be1dc283c24a46d345fb5da3935b32
James Sedgwick [Wed, 21 Jan 2015 19:41:50 +0000 (11:41 -0800)]
use wait()/get() instead of while(!f.isReady()) { ... }
Summary: as above. nice redness. couple of comments inline though
Test Plan: contbuild
Reviewed By: hans@fb.com
Subscribers: trunkagent, zeus-diffs@, cold-storage-diffs@, targeting-diff-backend@, apollo-diffs@, micha, folly-diffs@, jsedgwick
FB internal diff:
D1787776
Tasks:
5940008
Signature: t1:
1787776:
1421776843:
13772348538a0af27ceb5a363b818ece0cdfffc6
James Sedgwick [Wed, 21 Jan 2015 19:35:42 +0000 (11:35 -0800)]
waitWithSemaphore -> Future<T>::wait()
Summary:
see task. also adjust all callsites to get() or wait() as appropriate. this is a lot better, especially in various tests
Facebook:
cc @rushix, @wez as this was quite nice for docstore and novak, and you might want to be aware of new conventions
Test Plan: futures unit, wait for contbuild
Reviewed By: hans@fb.com
Subscribers: trunkagent, fbcode-common-diffs@, hero-diffs@, cold-storage-diffs@, adamsyta, zhuohuang, darshan, micha, folly-diffs@, lins, tingy, hannesr, jsedgwick, wez, rushix
FB internal diff:
D1785572
Tasks:
5940008
Signature: t1:
1785572:
1421866794:
a879de4d0bc14e96c434f623ed2a74361e25f28c
Dave Watson [Wed, 21 Jan 2015 16:12:33 +0000 (08:12 -0800)]
codecs
Summary:
Start of codec framework. Copied the frame based codecs almost exactly from netty, but made to fit our pipeline management.
BytesToMessageCodec is slightly different: Netty preprocesses all the available data to a List<Message>, while this codec a) Only does one message at a time to avoid queueing issues, and b) doesn't template the message type, and just passes an IOBuf
I'm fighting the type system to get the pipelines to play nice to each other: I'd rather template the message type, but it prevents stacking outgoing handlers on top of it, since you ahve to specify both the input/output type for each handler, even if you only care about the output type. Suggestions to fix? Netty gets around this by lots of dynamic casting to Object type, but we can't do that in C++ since we don't have a base object type
Test Plan: Includes lots of tests
Reviewed By: jsedgwick@fb.com
Subscribers: jsedgwick, doug, fugalh, folly-diffs@
FB internal diff:
D1758189
Tasks:
5002361,
5002316
Signature: t1:
1758189:
1421170225:
6bc8cc6a0bb461a965665bc88f7009033b215da9
projects / folly.git / log