firefly-linux-kernel-4.4.55.git
11 years agostaging: vt6656: baseband.c BBvCalculateParameter pwPhyLen return endian corrected.
Malcolm Priestley [Tue, 20 Aug 2013 21:49:26 +0000 (22:49 +0100)]
staging: vt6656: baseband.c BBvCalculateParameter pwPhyLen return endian corrected.

In rxtx.c many calls to BBvCaculateParameter are not endian
corrected all calls here need to be endian corrected.

Correct the endian in BBvCaculateParameter.

In card.c: CARDvSetRSPINF pwPhyLen points to awLen and is
manually applied to abyData.  Because it is now endian
corrected put_unaligned is needed to correct it.

In rxtx.c remove were endian is corrected.

This allows to merge  BBvCalculateParameter *pwPhyLen,*pbyPhySrv
and *pbyPhySgn to singles structure for tx buffers.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: drm/imx: ipu-dc: signedness bug in ipu_dc_init_sync()
Dan Carpenter [Wed, 21 Aug 2013 08:30:08 +0000 (11:30 +0300)]
staging: drm/imx: ipu-dc: signedness bug in ipu_dc_init_sync()

"map" needs to be signed for the error handling to work.  In the success
case then it holds a small non-negative value.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Acked-by: Marek Vasut <marex@denx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: gdm7240: fix error handling of probe()
Dan Carpenter [Wed, 21 Aug 2013 08:31:18 +0000 (11:31 +0300)]
staging: gdm7240: fix error handling of probe()

The error handling is messy and not in kernel style.  On some paths it
frees "mux_dev" twice.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: pcl812: missing break statement
Dan Carpenter [Wed, 21 Aug 2013 08:28:04 +0000 (11:28 +0300)]
staging: comedi: pcl812: missing break statement

Smatch complains that there is a missing break statement here.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: dt282x: dt282x_ai_insn_read() always fails
Dan Carpenter [Tue, 20 Aug 2013 08:57:35 +0000 (11:57 +0300)]
staging: comedi: dt282x: dt282x_ai_insn_read() always fails

In dt282x_ai_insn_read() we call this macro like:
wait_for(!mux_busy(), comedi_error(dev, "timeout\n"); return -ETIME;);
Because the if statement doesn't have curly braces it means we always
return -ETIME and the function never succeeds.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Ian Abbott <abbotti@mev.co.uk>
Cc: stable <stable@vger.kernel.org> # 2.6.36+
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: usbdux: allocating too much data
Dan Carpenter [Tue, 20 Aug 2013 09:06:19 +0000 (12:06 +0300)]
staging: comedi: usbdux: allocating too much data

We only need to allocate enough space for a pointer.  We allocate the
space for the urbs themselves with the call to usb_alloc_urb() a few
lines later.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: lustre: Fix typo in lustre/include
Masanari Iida [Tue, 20 Aug 2013 12:00:53 +0000 (21:00 +0900)]
staging: lustre: Fix typo in lustre/include

Fix spelling typo in comments within lustre/include/linux.

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: vt6656: rxtx.c dead code TYPE_ATIMDMA/TYPE_BEACONDMA
Malcolm Priestley [Tue, 20 Aug 2013 19:47:49 +0000 (20:47 +0100)]
staging: vt6656: rxtx.c dead code TYPE_ATIMDMA/TYPE_BEACONDMA

Both TYPE_ATIMDMA/TYPE_BEACONDMA are not used in driver for the value of uDMAIdx.

Remove dead code.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: et131x: Remove frame error TODO item
Mark Einon [Tue, 20 Aug 2013 21:42:43 +0000 (22:42 +0100)]
staging: et131x: Remove frame error TODO item

After prolonged testing for a few days of normal use with new et131x
hardware, I've concluded that this was a hardware issue with the older
hardware I had. Removing this item from the TODO.

Signed-off-by: Mark Einon <mark.einon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: olpc_dcon: Removed more completed TODO entries
Jens Frederich [Tue, 20 Aug 2013 13:53:06 +0000 (15:53 +0200)]
Staging: olpc_dcon: Removed more completed TODO entries

1. Console event notifier support: No one I've asked knows what this
all about.
2. Audit code for unnecessary code: This is done.
3. Verify sane i2cAPI usage: This is also done.

Signed-off-by: Jens Frederich <jfrederich@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: tidspbridge: Fix typos in comments
Masanari Iida [Tue, 20 Aug 2013 03:05:39 +0000 (12:05 +0900)]
staging: tidspbridge: Fix typos in comments

Correct spelling typos in comments.

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: usbip: Fix typo in comments within usbip
Masanari Iida [Tue, 20 Aug 2013 03:15:04 +0000 (12:15 +0900)]
staging: usbip: Fix typo in comments within usbip

Correct spelling typo in comments

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dgnc: dpacompat.h: removes trailing whitespace
Lidza Louina [Wed, 21 Aug 2013 15:08:13 +0000 (11:08 -0400)]
staging: dgnc: dpacompat.h: removes trailing whitespace

This patch removes trailing whitespace in
the dpacompat.h file.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dgnc: digi.h: removes trailing whitespace
Lidza Louina [Wed, 21 Aug 2013 15:08:12 +0000 (11:08 -0400)]
staging: dgnc: digi.h: removes trailing whitespace

This patch removes trailing whitespace in
the digi.h file.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dgnc: tty.c: removes trailing whitespace
Lidza Louina [Wed, 21 Aug 2013 15:08:11 +0000 (11:08 -0400)]
staging: dgnc: tty.c: removes trailing whitespace

This patch removes trailing whitespace in
the dgnc_tty.c file.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dgnc: trace.c: removes trailing whitespace
Lidza Louina [Wed, 21 Aug 2013 15:08:10 +0000 (11:08 -0400)]
staging: dgnc: trace.c: removes trailing whitespace

This patch removes trailing whitespace in
the dgnc_trace.c file.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dgnc: sysfs.h: removes trailing whitespace
Lidza Louina [Wed, 21 Aug 2013 15:08:09 +0000 (11:08 -0400)]
staging: dgnc: sysfs.h: removes trailing whitespace

This patch removes trailing whitespace in
the dgnc_sysfs.h file.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dgnc: sysfs.c: removes trailing whitespace
Lidza Louina [Wed, 21 Aug 2013 15:08:08 +0000 (11:08 -0400)]
staging: dgnc: sysfs.c: removes trailing whitespace

This patch removes trailing whitespace in
the sysfs.c file.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dgnc: neo.h: removes trailing whitespace
Lidza Louina [Wed, 21 Aug 2013 15:08:07 +0000 (11:08 -0400)]
staging: dgnc: neo.h: removes trailing whitespace

This patch removes trailing whitespace in
the neo.h file.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dgnc: neo.c: removes trailing whitespace
Lidza Louina [Wed, 21 Aug 2013 15:08:06 +0000 (11:08 -0400)]
staging: dgnc: neo.c: removes trailing whitespace

This patch removes trailing whitespace in
the dgnc_neo.c file.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dgnc: mgmt.c: removes trailing whitespace
Lidza Louina [Wed, 21 Aug 2013 15:08:05 +0000 (11:08 -0400)]
staging: dgnc: mgmt.c: removes trailing whitespace

This patch removes trailing whitespace in
the dgnc_mgmt.c file.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dgnc: kcompat.h: removes trailing whitespace
Lidza Louina [Wed, 21 Aug 2013 15:08:04 +0000 (11:08 -0400)]
staging: dgnc: kcompat.h: removes trailing whitespace

This patch removes trailing whitespace in
the kcompat.h file.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dgnc: driver.h: removes trailing whitespace
Lidza Louina [Wed, 21 Aug 2013 15:08:03 +0000 (11:08 -0400)]
staging: dgnc: driver.h: removes trailing whitespace

This patch removes trailing whitespace in
the driver.h file.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dgnc: driver.c: removes trailing whitespace
Lidza Louina [Wed, 21 Aug 2013 15:08:02 +0000 (11:08 -0400)]
staging: dgnc: driver.c: removes trailing whitespace

This patch removes trailing whitespace in
the dgnc_driver.c file.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dgnc: cls.h: removes trailing whitespace
Lidza Louina [Wed, 21 Aug 2013 15:08:01 +0000 (11:08 -0400)]
staging: dgnc: cls.h: removes trailing whitespace

This patch removes trailing whitespace in
the dgnc_cls.h file.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dgnc: cls.c: removes trailing whitespace
Lidza Louina [Wed, 21 Aug 2013 15:08:00 +0000 (11:08 -0400)]
staging: dgnc: cls.c: removes trailing whitespace

This patch removes trailing whitespace in
the dgnc_cls.c file.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dgnc: add driver to kernel build
Lidza Louina [Wed, 21 Aug 2013 00:56:58 +0000 (20:56 -0400)]
staging: dgnc: add driver to kernel build

This patch adds the dgnc driver to the kernel build process.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dgnc: removes ifdef HAVE_UNLOCKED_IOCTL conditionals
Lidza Louina [Tue, 20 Aug 2013 18:15:36 +0000 (14:15 -0400)]
staging: dgnc: removes ifdef HAVE_UNLOCKED_IOCTL conditionals

This patch removes the HAVE_UNLOCKED_IOCTL conditional
statements from driver.c, mgmt.c and mgmt.h. This was
used to support older kernels. It isn't needed now.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dgnc: driver.c: fixes warning about assigning pointer
Lidza Louina [Tue, 20 Aug 2013 18:15:35 +0000 (14:15 -0400)]
staging: dgnc: driver.c: fixes warning about assigning pointer

This patch fixes a warning associated with assigining
a pointer in the dgnc_mbuf function.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: vt6656: desc.h remove typedef tagSTxDataHead_a_FB to new structure in rxtx.h
Malcolm Priestley [Fri, 16 Aug 2013 22:51:38 +0000 (23:51 +0100)]
staging: vt6656: desc.h remove typedef tagSTxDataHead_a_FB to new structure in rxtx.h

To new structure.
typedef struct tagSTxDataHead_a_FB -> struct vnt_tx_datahead_a_fb

This is only needed by rxtc.c so moved to rxtx.h visible to
vnt_rts* structures which it will eventually form part of
their structure.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: vt6656: desc.h remove typedef tagSTxDataHead_ab to new structure in rxtx.h
Malcolm Priestley [Fri, 16 Aug 2013 22:50:32 +0000 (23:50 +0100)]
staging: vt6656: desc.h remove typedef tagSTxDataHead_ab to new structure in rxtx.h

To new structure.
typedef struct tagSTxDataHead_ab -> struct vnt_tx_datahead_ab

This is only needed by rxtc.c so moved to rxtx.h visible to
vnt_rts* structures which it will eventually form part of
their structure.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: vt6656: desc.h remove typedef tagSTxDataHead_g_FB to new structure in rxtx.h
Malcolm Priestley [Fri, 16 Aug 2013 22:49:15 +0000 (23:49 +0100)]
staging: vt6656: desc.h remove typedef tagSTxDataHead_g_FB to new structure in rxtx.h

To new structure.
typedef struct tagSTxDataHead_g_FB -> struct vnt_tx_datahead_g_fb

This is only needed by rxtc.c so moved to rxtx.h visible to
vnt_rts*/vnt_cts* structures which it will eventually form part of
their structure.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: vt6656: desc.h: remove typedef struct tagSTxDataHead_g to new structure...
Malcolm Priestley [Fri, 16 Aug 2013 22:48:03 +0000 (23:48 +0100)]
staging: vt6656: desc.h: remove typedef struct tagSTxDataHead_g to new structure in rxtx.h

To new structure.
typedef struct tagSTxDataHead_g -> struct vnt_tx_datahead_g

This is only needed by rxtc.c so moved to rxtx.h visible to
vnt_rts*/vnt_cts* structures which it will eventually form part of
their structure.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: vt6656: desc.h remove dead code typedef struct tagSRrvTime_atim.
Malcolm Priestley [Fri, 16 Aug 2013 22:46:49 +0000 (23:46 +0100)]
staging: vt6656: desc.h remove dead code typedef struct tagSRrvTime_atim.

Remove dead structure tagSRrvTime_atim.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: vt6656: desc.h remove typedef SRrvTime_ab to new structure.
Malcolm Priestley [Fri, 16 Aug 2013 22:44:04 +0000 (23:44 +0100)]
staging: vt6656: desc.h remove typedef SRrvTime_ab to new structure.

To new structure.
typedef struct tagSRrvTime_ab -> struct vnt_rrv_time_ab

This is only needed by rxtc.c so moved to rxtx.h and
will eventually form part of the structure of
struct vnt_tx_buffer.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: vt6656: desc.h: Move typedef struct tagSRrvTime_gCTS to new structure in...
Malcolm Priestley [Fri, 16 Aug 2013 22:38:57 +0000 (23:38 +0100)]
staging: vt6656: desc.h: Move typedef struct tagSRrvTime_gCTS to new structure in rxtx.h

To new structure.
typedef struct tagSRrvTime_gCTS -> struct vnt_rrv_time_cts

This is only needed by rxtc.c so moved to rxtx.h and
will eventually form part of the structure of
struct vnt_tx_buffer.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: vt6656: desc.h: Move typedef tagSRrvTime_gRTS to new structure in rxtx.h
Malcolm Priestley [Fri, 16 Aug 2013 20:26:55 +0000 (21:26 +0100)]
staging: vt6656: desc.h: Move typedef tagSRrvTime_gRTS to new structure in rxtx.h

To new structure.
typedef struct tagSRrvTime_gRTS -> struct vnt_rrv_time_rts

This is only needed by rxtc.c so moved to rxtx.h and
will eventually form part of the structure of
struct vnt_tx_buffer.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoimx-drm: ipuv3-crtc: Add MODULE_ALIAS()
Fabio Estevam [Mon, 19 Aug 2013 00:40:06 +0000 (21:40 -0300)]
imx-drm: ipuv3-crtc: Add MODULE_ALIAS()

Add MODULE_ALIAS, so that auto module loading can work.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoimx-drm: parallel-display: Add MODULE_ALIAS()
Fabio Estevam [Mon, 19 Aug 2013 00:40:05 +0000 (21:40 -0300)]
imx-drm: parallel-display: Add MODULE_ALIAS()

Add MODULE_ALIAS, so that auto module loading can work.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoimx-drm: imx-tve: Add MODULE_ALIAS()
Fabio Estevam [Mon, 19 Aug 2013 00:40:04 +0000 (21:40 -0300)]
imx-drm: imx-tve: Add MODULE_ALIAS()

Add MODULE_ALIAS, so that auto module loading can work.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoimx-drm: imx-ldb: Add MODULE_ALIAS()
Fabio Estevam [Mon, 19 Aug 2013 00:40:03 +0000 (21:40 -0300)]
imx-drm: imx-ldb: Add MODULE_ALIAS()

Add MODULE_ALIAS, so that auto module loading can work.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoimx-drm: ipu-di: Check the return value from clk_prepare_enable()
Fabio Estevam [Mon, 19 Aug 2013 00:40:02 +0000 (21:40 -0300)]
imx-drm: ipu-di: Check the return value from clk_prepare_enable()

clk_prepare_enable() may fail, so let's check its return value and propagate it
in the case of error.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: xillybus: Fix typo in comment
Masanari Iida [Mon, 19 Aug 2013 04:33:48 +0000 (13:33 +0900)]
staging: xillybus: Fix typo in comment

Correct spelling typo in comments.

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dgrp: add __init/__exit macros
navin patidar [Mon, 19 Aug 2013 09:16:25 +0000 (14:46 +0530)]
staging: dgrp: add __init/__exit macros

add __init/__exit macros to related init/cleanup functions.

Signed-off-by: navin patidar <navinp@cdac.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: gdm7240: a TTY rewrite according to the latest TTY APIs
Won Kang [Fri, 16 Aug 2013 04:13:44 +0000 (13:13 +0900)]
staging: gdm7240: a TTY rewrite according to the latest TTY APIs

Fixed mis-use of mutex for gdm_table. gdm_table is refered to only
inside tty_install and port destrcut, and usb callbacks use internal
reference which was saved during urb submission

Signed-off-by: Won Kang <wonkang@gctsemi.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: gdm7240: a TTY rewrite according to the latest TTY APIs
Won Kang [Fri, 16 Aug 2013 04:13:43 +0000 (13:13 +0900)]
staging: gdm7240: a TTY rewrite according to the latest TTY APIs

Removed the old style reference countings and termios.
Renamed variables to meaninful ones.

Signed-off-by: Won Kang <wonkang@gctsemi.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: olpc_dcon: Already completed TODO entry removed
Jens Frederich [Sat, 17 Aug 2013 14:20:29 +0000 (16:20 +0200)]
Staging: olpc_dcon: Already completed TODO entry removed

The TODO entry - drop global variables, use a proper olpc_dcon_priv
struct - is already finished. The driver has no global variables.
It uses the private structure 'dcon_priv'.

Signed-off-by: Jens Frederich <jfrederich@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: olpc_dcon: fix typo in olpc_dcon.h
Jens Frederich [Sat, 17 Aug 2013 14:20:54 +0000 (16:20 +0200)]
Staging: olpc_dcon: fix typo in olpc_dcon.h

The backlight brightness register (DCON_REG_BRIGHT) address is 0xa.

Signed-off-by: Jens Frederich <jfrederich@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoMerge tag 'iio-for-3.12b' of git://git.kernel.org/pub/scm/linux/kernel/git/jic23...
Greg Kroah-Hartman [Mon, 19 Aug 2013 22:23:55 +0000 (15:23 -0700)]
Merge tag 'iio-for-3.12b' of git://git./linux/kernel/git/jic23/iio into staging-next

Jonathan writes:

Second round of new drivers, features and cleanups for IIO in the 3.12 cycle.

New driver:

1) tmp006 IR thermopile driver.  This is an unusual temperature sensor
   and was taken in to IIO with the knowledge and agreement of a hwmon
   maintainer.
   It measures remote temperature using infrared emissions.
   I guess taking this may mean we have to fight off submissions of
   devices much more suited to hwmon but such is life and we end up
   doing this from time to time already.

2) twl6030 adc driver.

Cleanups:

1) More devm_* cleanups following on from the introduction of
   devm_iio_device_alloc.  Mostly an heroic effort from
   Sachin Kamat!

2) Introduce devm_iio_trigger_alloc etc to handle trigger
   allocation and deallocation in a managed fashion.  There
   aren't as many instances of triggers as devices, but this
   will allow futher reduction in error patch complexity in
   some of our most complex drivers making it a very good thing.
3) Trivial removal of unused defines in adjd_s311

4) Drop some write_raw_get_fmt callbacks where they were only
   returning the default value.

5) Change mxs-lradc realbits to 12.  Whilst an 18bit register
   is used on the device, in its current mode only 12 bits of
   useful data are returned.  For now the packing is unchanged
   in the buffer and this change mainly effects the input support
   in the driver.

11 years agoiio: dac: max517: Use devm_iio_device_alloc
Sachin Kamat [Mon, 19 Aug 2013 11:38:00 +0000 (12:38 +0100)]
iio: dac: max517: Use devm_iio_device_alloc

Using devm_iio_device_alloc makes code simpler.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Roland Stigge <stigge@antcom.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: dac: ad7303: Use devm_* APIs
Sachin Kamat [Mon, 19 Aug 2013 11:38:00 +0000 (12:38 +0100)]
iio: dac: ad7303: Use devm_* APIs

devm_* APIs are device managed and make code simpler.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: dac: ad5791: Use devm_* APIs
Sachin Kamat [Mon, 19 Aug 2013 11:38:00 +0000 (12:38 +0100)]
iio: dac: ad5791: Use devm_* APIs

devm_* APIs are device managed and make code simpler.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: dac: ad5764: Use devm_* APIs
Sachin Kamat [Mon, 19 Aug 2013 11:38:00 +0000 (12:38 +0100)]
iio: dac: ad5764: Use devm_* APIs

devm_* APIs are device managed and make code simpler.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: dac: ad5755: Use devm_iio_device_alloc
Sachin Kamat [Mon, 19 Aug 2013 11:38:00 +0000 (12:38 +0100)]
iio: dac: ad5755: Use devm_iio_device_alloc

Using devm_iio_device_alloc makes code simpler.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: dac: ad5686: Use devm_* APIs
Sachin Kamat [Mon, 19 Aug 2013 11:38:00 +0000 (12:38 +0100)]
iio: dac: ad5686: Use devm_* APIs

devm_* APIs are device managed and make code simpler.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: dac: ad5624r_spi: Use devm_* APIs
Sachin Kamat [Mon, 19 Aug 2013 11:38:00 +0000 (12:38 +0100)]
iio: dac: ad5624r_spi: Use devm_* APIs

devm_* APIs are device managed and make code simpler.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: dac: ad5504: Use devm_* APIs
Sachin Kamat [Mon, 19 Aug 2013 11:38:00 +0000 (12:38 +0100)]
iio: dac: ad5504: Use devm_* APIs

devm_* APIs are device managed and make code simpler.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: dac: ad5449: Use devm_* APIs
Sachin Kamat [Mon, 19 Aug 2013 11:38:00 +0000 (12:38 +0100)]
iio: dac: ad5449: Use devm_* APIs

devm_* APIs are device managed and make code simpler.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: dac: ad5446: Use devm_* APIs
Sachin Kamat [Mon, 19 Aug 2013 11:38:00 +0000 (12:38 +0100)]
iio: dac: ad5446: Use devm_* APIs

devm_* APIs are device managed and make code simpler.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: dac: ad5421: Use devm_* APIs
Sachin Kamat [Mon, 19 Aug 2013 11:38:00 +0000 (12:38 +0100)]
iio: dac: ad5421: Use devm_* APIs

devm_* APIs are device managed and make code simpler.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: dac: ad5380: Use devm_* APIs
Sachin Kamat [Mon, 19 Aug 2013 11:38:00 +0000 (12:38 +0100)]
iio: dac: ad5380: Use devm_* APIs

devm_* APIs are device managed and make code simpler.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: dac: ad5360: Use devm_* APIs
Sachin Kamat [Mon, 19 Aug 2013 11:38:00 +0000 (12:38 +0100)]
iio: dac: ad5360: Use devm_* APIs

devm_* APIs are device managed and make code simpler.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: dac: ad5064: Use devm_* APIs
Sachin Kamat [Mon, 19 Aug 2013 11:38:00 +0000 (12:38 +0100)]
iio: dac: ad5064: Use devm_* APIs

devm_* APIs are device managed and make code simpler.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: adc: twl6030-gpadc: Use devm_* API family
Oleksandr Kozaruk [Mon, 19 Aug 2013 11:09:00 +0000 (12:09 +0100)]
iio: adc: twl6030-gpadc: Use devm_* API family

Using devm_iio_device_alloc and devm_request_threaded_irq makes
code simpler.

Signed-off-by: Oleksandr Kozaruk <oleksandr.kozaruk@ti.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: adjd_s311: Cleanup unused #defines
Peter Meerwald [Sun, 18 Aug 2013 12:59:00 +0000 (13:59 +0100)]
iio: adjd_s311: Cleanup unused #defines

using word reads, no need for HI/LO register #defines

Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: Remove unnecessary _write_raw_get_fmt() in several hid-sensor drivers
Peter Meerwald [Sun, 18 Aug 2013 13:07:00 +0000 (14:07 +0100)]
iio: Remove unnecessary _write_raw_get_fmt() in several hid-sensor drivers

IIO_VAL_INT_PLUS_MICRO is the default, no need to return it explicitly

Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Acked-by: srinivas pandruvada <srinivas.pandruvada@intel.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: trigger: implement devm_iio_trigger_alloc/devm_iio_triger_free
Jacek Anaszewski [Fri, 16 Aug 2013 13:11:00 +0000 (14:11 +0100)]
iio: trigger: implement devm_iio_trigger_alloc/devm_iio_triger_free

Add a resource managed devm_iio_trigger_alloc()/devm_iio_triger_free()
to automatically clean up triggers allocated by IIO drivers, thus
leading to simplified IIO drivers code.

Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
Signed-off-by: Kyunmin Park <kyungmin.park@samsung.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: twl6030-gpadc: TWL6030, TWL6032 GPADC driver
Oleksandr Kozaruk [Thu, 25 Jul 2013 13:26:00 +0000 (14:26 +0100)]
iio: twl6030-gpadc: TWL6030, TWL6032 GPADC driver

The GPADC is general purpose ADC found on TWL6030, and TWL6032 PMIC,
known also as Phoenix and PhoenixLite.

The TWL6030 and TWL6032 have GPADC with 17 and 19 channels
respectively. Some channels have current source and are used for
measuring voltage drop on resistive load for detecting battery ID
resistance, or measuring voltage drop on NTC resistors for external
temperature measurements. Some channels measure voltage, (i.e. battery
voltage), and have voltage dividers, thus, capable to scale voltage.
Some channels are dedicated for measuring die temperature.

Some channels are calibrated in 2 points, having offsets from ideal
values kept in trim registers. This is used to correct measurements.

The differences between GPADC in TWL6030 and TWL6032:
- 10 bit vs 12 bit ADC;
- 17 vs 19 channels;
- channels have different purpose(i.e. battery voltage
  channel 8 vs channel 18);
- trim values are interpreted differently.

Based on the driver patched from Balaji TK, Graeme Gregory, Ambresh K,
Girish S Ghongdemath.

Signed-off-by: Balaji T K <balajitk@ti.com>
Signed-off-by: Graeme Gregory <gg@slimlogic.co.uk>
Signed-off-by: Oleksandr Kozaruk <oleksandr.kozaruk@ti.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: mxs-lradc: change the realbits to 12
Hector Palacios [Mon, 22 Jul 2013 14:03:00 +0000 (15:03 +0100)]
iio: mxs-lradc: change the realbits to 12

The LRADC virtual channels have an 18 bit field to store the sum of up
to 2^5 accumulated samples. The read_raw function however only operates
over a single sample (12 bit resolution).
In order to use this field for scaling operations, we need it to be the
exact resolution value of the LRADC.
Besides, the driver was using an 18 bit mask (LRADC_CH_VALUE_MASK) to
report touch coordinates to userland. A 12 bit mask should be used instead
or else the touch libraries will expect a coordinates range between 0
and 0x3ffff (18 bits), instead of between 0 and 0xfff (12 bits).

Signed-off-by: Hector Palacios <hector.palacios@digi.com>
Acked-by: Marek Vasut <marex@denx.de>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: gyro: adis16060_core: Use devm_iio_device_alloc
Sachin Kamat [Tue, 13 Aug 2013 06:34:00 +0000 (07:34 +0100)]
iio: gyro: adis16060_core: Use devm_iio_device_alloc

Using devm_iio_device_alloc makes code simpler.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: gyro: st_gyro: Use devm_iio_device_alloc
Sachin Kamat [Tue, 13 Aug 2013 06:34:00 +0000 (07:34 +0100)]
iio: gyro: st_gyro: Use devm_iio_device_alloc

Using devm_iio_device_alloc makes code simpler.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Denis Ciocca <denis.ciocca@st.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: gyro: itg3200_core: Use devm_iio_device_alloc
Sachin Kamat [Tue, 13 Aug 2013 06:34:00 +0000 (07:34 +0100)]
iio: gyro: itg3200_core: Use devm_iio_device_alloc

Using devm_iio_device_alloc makes code simpler.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Christian Strobel <christian.strobel@iis.fraunhofer.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: gyro: adxrs450: Use devm_iio_device_alloc
Sachin Kamat [Tue, 13 Aug 2013 06:34:00 +0000 (07:34 +0100)]
iio: gyro: adxrs450: Use devm_iio_device_alloc

Using devm_iio_device_alloc makes code simpler.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: hid-sensor-gyro-3d: Use devm_iio_device_alloc
Sachin Kamat [Tue, 13 Aug 2013 06:34:00 +0000 (07:34 +0100)]
iio: hid-sensor-gyro-3d: Use devm_iio_device_alloc

Using devm_iio_device_alloc makes code simpler.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Srinivas Pandruvada <srinivas.pandruvada@intel.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: gyro: adis16260: Use devm_iio_device_alloc
Sachin Kamat [Tue, 13 Aug 2013 06:34:00 +0000 (07:34 +0100)]
iio: gyro: adis16260: Use devm_iio_device_alloc

Using devm_iio_device_alloc makes code simpler.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: gyro: adis16136: Use devm_iio_device_alloc
Sachin Kamat [Tue, 13 Aug 2013 06:34:00 +0000 (07:34 +0100)]
iio: gyro: adis16136: Use devm_iio_device_alloc

Using devm_iio_device_alloc makes code simpler.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: gyro: adis16130: Use devm_iio_device_alloc
Sachin Kamat [Tue, 13 Aug 2013 06:34:00 +0000 (07:34 +0100)]
iio: gyro: adis16130: Use devm_iio_device_alloc

Using devm_iio_device_alloc makes code simpler.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: gyro: adis16080: Use devm_iio_device_alloc
Sachin Kamat [Tue, 13 Aug 2013 06:34:00 +0000 (07:34 +0100)]
iio: gyro: adis16080: Use devm_iio_device_alloc

Using devm_iio_device_alloc makes code simpler.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: Restore alphabetic order in Makefile
Peter Meerwald [Thu, 8 Aug 2013 16:39:00 +0000 (17:39 +0100)]
iio: Restore alphabetic order in Makefile

Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: Add tmp006 IR temperature sensor
Peter Meerwald [Thu, 8 Aug 2013 16:39:00 +0000 (17:39 +0100)]
iio: Add tmp006 IR temperature sensor

the TI TMP006 is a non-contact temperature sensor with I2C interface;
it measures the surface temperature of a distance object using a
thermopile to absorb IR energy emitted from the object

the sensor has two channels: IR sensor voltage (16-bit) and reference
temperature of the chip (14-bit); datasheet is here:
http://www.ti.com/lit/ds/symlink/tmp006.pdf

v2 (thanks to Grygorii Strashko, Lars-Peter Clausen, Jonathan Cameron
for review comments):
* power down device on driver remove
* use sign_extend32()
* style cleanup
* add comments what channel raw LSBs mean
* spelling of thermopile

Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>
Cc: Jonathan Cameron <jic23@kernel.org>
Cc: LM Sensors <lm-sensors@lm-sensors.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoandroid/sync: use get_unused_fd_flags(O_CLOEXEC) instead of get_unused_fd()
Yann Droneaud [Thu, 15 Aug 2013 13:10:54 +0000 (15:10 +0200)]
android/sync: use get_unused_fd_flags(O_CLOEXEC) instead of get_unused_fd()

Macro get_unused_fd() is used to allocate a file descriptor with
default flags. Those default flags (0) can be "unsafe":
O_CLOEXEC must be used by default to not leak file descriptor
across exec().

Instead of macro get_unused_fd(), functions anon_inode_getfd()
or get_unused_fd_flags() should be used with flags given by userspace.
If not possible, flags should be set to O_CLOEXEC to provide userspace
with a default safe behavor.

In a further patch, get_unused_fd() will be removed so that
new code start using anon_inode_getfd() or get_unused_fd_flags()
with correct flags.

This patch replaces calls to get_unused_fd() with call to
get_unused_fd_flags(O_CLOEXEC) following advice from Erik Gilling.

Signed-off-by: Yann Droneaud <ydroneaud@opteya.com>
Cc: Erik Gilling <konkers@android.com>
Cc: Colin Cross <ccross@google.com>
Link: http://lkml.kernel.org/r/CACSP8SjXGMk2_kX_+RgzqqQwqKernvF1Wt3K5tw991W5dfAnCA@mail.gmail.com
Link: http://lkml.kernel.org/r/cover.1376327678.git.ydroneaud@opteya.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoandroid/sw_sync: use get_unused_fd_flags(O_CLOEXEC) instead of get_unused_fd()
Yann Droneaud [Thu, 15 Aug 2013 13:10:53 +0000 (15:10 +0200)]
android/sw_sync: use get_unused_fd_flags(O_CLOEXEC) instead of get_unused_fd()

Macro get_unused_fd() is used to allocate a file descriptor with
default flags. Those default flags (0) can be "unsafe":
O_CLOEXEC must be used by default to not leak file descriptor
across exec().

Instead of macro get_unused_fd(), functions anon_inode_getfd()
or get_unused_fd_flags() should be used with flags given by userspace.
If not possible, flags should be set to O_CLOEXEC to provide userspace
with a default safe behavor.

In a further patch, get_unused_fd() will be removed so that
new code start using anon_inode_getfd() or get_unused_fd_flags()
with correct flags.

This patch replaces calls to get_unused_fd() with call to
get_unused_fd_flags(O_CLOEXEC) following advice from Erik Gilling.

Signed-off-by: Yann Droneaud <ydroneaud@opteya.com>
Cc: Erik Gilling <konkers@android.com>
Cc: Colin Cross <ccross@google.com>
Link: http://lkml.kernel.org/r/CACSP8SjZcpcpEtQHzcGYhf-MP7QGo0XpN7-uN7rmD=vNtopG=w@mail.gmail.com
Link: http://lkml.kernel.org/r/cover.1376327678.git.ydroneaud@opteya.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: vt6656: desc.h Move typedef struct tagSCTS* to new structures in rxtx.h
Malcolm Priestley [Thu, 15 Aug 2013 20:27:22 +0000 (21:27 +0100)]
staging: vt6656: desc.h Move typedef struct tagSCTS* to new structures in rxtx.h

The new structures being
typedef struct tagSCTS -> struct vnt_cts
typedef struct tagSCTS_FB -> struct vnt_cts_fb

These are only needed by rxtc.c so moved to rxtx.h and
will eventually form part of the structure of
struct vnt_tx_buffer.

The linux/ieee80211.h in desc.h is no longer needed.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: vt6656: desc.h Remove typedef struct tagSRTS_* to new strutures in rxtx.h
Malcolm Priestley [Thu, 15 Aug 2013 20:23:25 +0000 (21:23 +0100)]
staging: vt6656: desc.h Remove typedef struct tagSRTS_* to new strutures in rxtx.h

The new structures being
typedef struct tagSRTS_g -> struct vnt_rts_g
typedef struct tagSRTS_g_FB -> struct vnt_rts_g_fb
typedef struct tagSRTS_ab -> struct vnt_rts_ab
typedef struct tagSRTS_a_FB -> struct vnt_rts_a_fb

These are only needed by rxtc.c so moved to rxtx.h and
will eventually form part of the structure of
struct vnt_tx_buffer.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: olpc_dcon: more big endian conformity
Jens Frederich [Thu, 15 Aug 2013 19:40:01 +0000 (21:40 +0200)]
Staging: olpc_dcon: more big endian conformity

Using an int which is casted to unsigned char as inbuf is messy.
The code won't work on big endian systems.  The patch should fix
this.

Signed-off-by: Jens Frederich <jfrederich@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: olpc_dcon: replace some magic numbers
Jens Frederich [Thu, 15 Aug 2013 19:34:55 +0000 (21:34 +0200)]
Staging: olpc_dcon: replace some magic numbers

This patch replace some magic numbers. I believe it makes
the driver more readable.

The magic number 0x26 is the XO system embedded controller
(EC) command 'DCON power enable/disable'.

Number 0x41, and 0x42 are special memory controller settings
register.  The 0x41 initialize bit sequence 0x101 means:
enable memory power down function and special SDRAM clock
delay for synchronize SDRAM output and clock signal.

The 0x42 initialize squence 0x101 is wrong.  According to
the specification Bit 8 is reserved, thus not in use.
I removed it.

Signed-off-by: Jens Frederich <jfrederich@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: vt6656: rxtx.h : remove typedef struct tagSBEACON_BUFFER
Malcolm Priestley [Thu, 15 Aug 2013 18:40:08 +0000 (19:40 +0100)]
staging: vt6656: rxtx.h : remove typedef struct tagSBEACON_BUFFER

Replace with struct vnt_beacon_buffer.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: vt6656: rxtx.c : s_bPacketToWirelessUsb remove usbPacketBuf.
Malcolm Priestley [Thu, 15 Aug 2013 18:37:04 +0000 (19:37 +0100)]
staging: vt6656: rxtx.c : s_bPacketToWirelessUsb remove usbPacketBuf.

Move vnt_tx_buffer *pTxBufHead to argument u8 *usbPacketBuf position.

Fix the calling to s_bPacketToWirelessUsb so it attached to
the calling struct vnt_tx_buffer pTX_Buffer.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: vt6656: rxtx.c remove typdef PTX_BUFFER
Malcolm Priestley [Thu, 15 Aug 2013 18:34:37 +0000 (19:34 +0100)]
staging: vt6656: rxtx.c remove typdef PTX_BUFFER

Rename to vnt_tx_buffer.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: ozwpan: Remove extra variable.
Rupesh Gujare [Thu, 15 Aug 2013 11:00:22 +0000 (12:00 +0100)]
staging: ozwpan: Remove extra variable.

We should not use extra variable just to copy pointer value,
renaming parameter name serves pupose & removes extra variable.

Signed-off-by: Rupesh Gujare <rupesh.gujare@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: ozwpan: Remove unneeded variable initializer
Rupesh Gujare [Thu, 15 Aug 2013 11:00:21 +0000 (12:00 +0100)]
staging: ozwpan: Remove unneeded variable initializer

We are assigning value to hport before returning, there is
no need to initialize it.

Signed-off-by: Rupesh Gujare <rupesh.gujare@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dgnc: removes proc code
Lidza Louina [Thu, 15 Aug 2013 14:28:22 +0000 (10:28 -0400)]
staging: dgnc: removes proc code

This patch removes the dgnc_proc.c and dgnc_proc.h files and all
references to proc functions in dgnc_driver.c. This also removes proc.h
from the include headers in driver.c, mgmt.c and sysfs.c and proc.o
from the Makefile.

Drivers now use sysfs instead of proc.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agodrivers/staging/comedi/drivers/das16.c: needs slab.h
Andrew Morton [Tue, 13 Aug 2013 20:55:48 +0000 (13:55 -0700)]
drivers/staging/comedi/drivers/das16.c: needs slab.h

alpha allmodconfig:

drivers/staging/comedi/drivers/das16.c: In function 'das16_detach':
drivers/staging/comedi/drivers/das16.c:1234: error: implicit declaration of function 'kfree'

Cc: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: vt6656: rxtx.c s_uGetRTSCTSDuration return endian u16
Malcolm Priestley [Tue, 13 Aug 2013 19:17:11 +0000 (20:17 +0100)]
staging: vt6656: rxtx.c s_uGetRTSCTSDuration return endian u16

The return value of uGetRTSCTSDuration always needs to be
corrected to a u16 little endian corrected value.

Some places the endian correction is done on the next line

Change uGetRTSCTSDuration return u16 little endian corrected value.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: vt6656: rxtx.c s:_uGetDataDuration simplify structure.
Malcolm Priestley [Tue, 13 Aug 2013 18:59:31 +0000 (19:59 +0100)]
staging: vt6656: rxtx.c s:_uGetDataDuration simplify structure.

A value is only returned when bNeedAck is true.

Only when byDurType == DATADUR_B is different.

Remove switch statement and simplify with if structure.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: vt6656: rxtx.h dead code typedef union tagUTX_BUFFER_CONTAINER
Malcolm Priestley [Tue, 13 Aug 2013 18:52:08 +0000 (19:52 +0100)]
staging: vt6656: rxtx.h dead code typedef union tagUTX_BUFFER_CONTAINER

This is part of the Remote NDIS message format with patch

vt6656: rxtx.c: s_vGetFreeContext use single tx memset.

there is not need for this structure and its members.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: vt6656: rxtx.h always pack BEACON_BUFFER/TX_BUFFER
Malcolm Priestley [Tue, 13 Aug 2013 18:47:08 +0000 (19:47 +0100)]
staging: vt6656: rxtx.h always pack BEACON_BUFFER/TX_BUFFER

All structure members of BEACON_BUFFER/TX_BUFFER should be packed.

Only the first 4 members of these structures are live.

The forth member is referenced at run-time by packed structures.
typedef struct tagSTxBufHead
typedef struct tagSTxShortBufHead
in desc.h

If these structures are not packed the alignment of these members
will be wrong.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: ozwpan: Separate success & failure case for oz_hcd_pd_arrived()
Dan Carpenter [Tue, 13 Aug 2013 17:29:26 +0000 (18:29 +0100)]
staging: ozwpan: Separate success & failure case for oz_hcd_pd_arrived()

This patch separates success & failure block along with fixing
following issues:-

1. The way oz_hcd_pd_arrived() looks now it's easy to think we free "ep" but
actually we do this spaghetti thing of setting it to NULL on success.

2. It is hard to read it because there are unlocks scattered throughout.

3. Currently we set "ep" to NULL on the success path and then test it and or
free it. In current code you have to scroll to the start of the function
to read code.

Original patch was submitted by Dan here :-
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2013-August/040113.html

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Rupesh Gujare <rupesh.gujare@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: ozwpan: Swap arguments of oz_ep_alloc() to match kmalloc()
Rupesh Gujare [Tue, 13 Aug 2013 17:29:25 +0000 (18:29 +0100)]
staging: ozwpan: Swap arguments of oz_ep_alloc() to match kmalloc()

Swap arguments of oz_ep_alloc() to match kmalloc() for better readability.

Signed-off-by: Rupesh Gujare <rupesh.gujare@atmel.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: ozwpan: Remove unneeded initializers
Rupesh Gujare [Tue, 13 Aug 2013 17:29:24 +0000 (18:29 +0100)]
staging: ozwpan: Remove unneeded initializers

Remove variable initialization wherever it is not required.

Signed-off-by: Rupesh Gujare <rupesh.gujare@atmel.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>