Mark Seaborn [Mon, 27 Jan 2014 22:38:14 +0000 (22:38 +0000)]
ARM MC: Fix the initial DWARF CFI unwind info at the start of a function
This brings MC into line with GNU 'as' on ARM, and it brings the ARM
target into line with most other LLVM targets, which declare the
initial CFI state with addInitialFrameState().
Without this, functions generated with .cfi_startproc/endproc on ARM
will tend to cause GDB to abort with:
gdb/dwarf2-frame.c:1132: internal-error: Unknown CFA rule.
I've also tested this by comparing the output of "readelf -w" on the
object files produced by llvm-mc and gas when given the .s file added
here.
This change is part of addressing PR18636.
Differential Revision: http://llvm-reviews.chandlerc.com/D2597
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200255
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Mon, 27 Jan 2014 21:41:54 +0000 (21:41 +0000)]
Fix sext(setcc) -> select_cc using wrong type for setcc.
Also update the comment, since it actually produces a
select (setcc) instead of select_cc.
It was checking and using the setcc result type for the
type of the sext, instead of the type of the compared items.
In my problem case, the sext was to i32 and was used as the setcc type,
but the expected type was i64.
No test since I haven't been able to hit the problem with
this on any in-tree targets.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200249
91177308-0d34-0410-b5e6-
96231b3b80d8
David Peixotto [Mon, 27 Jan 2014 21:39:04 +0000 (21:39 +0000)]
Fix unsupported addressing mode assertion for pld
Summary:
This commit gives an address mode to the PLD instruction. We
were getting an assertion failure in the frame lowering code
because we had code that was doing a pld of a stack allocated
address. The frame lowering was checking the address mode and
then asserting because pld had none defined.
This commit fixes pld for arm mode. There was a previous fix for
thumb mode in a separate commit. The commit for thumb mode
added a test in a separate file because it would otherwise fail
for arm. This commit moves the thumb test back into the prefetch.ll
file and adds the corresponding arm test.
Differential Revision: http://llvm-reviews.chandlerc.com/D2622
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200248
91177308-0d34-0410-b5e6-
96231b3b80d8
Gautam Chakrabarti [Mon, 27 Jan 2014 20:03:35 +0000 (20:03 +0000)]
test commit: add minor comment
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200244
91177308-0d34-0410-b5e6-
96231b3b80d8
Andrea Di Biagio [Mon, 27 Jan 2014 18:45:30 +0000 (18:45 +0000)]
[DAGCombiner] Teach how to fold sext/aext/zext of constant build vectors.
This patch teaches the DAGCombiner how to fold a sext/aext/zext dag node when
the operand in input is a build vector of constants (or UNDEFs).
The inability to fold a sext/zext of a constant build_vector was the root
cause of some pcg bugs affecting vselect expansion on x86-64 with AVX support.
Before this change, the DAGCombiner only knew how to fold a sext/zext/aext of a
ConstantSDNode.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200234
91177308-0d34-0410-b5e6-
96231b3b80d8
Reid Kleckner [Mon, 27 Jan 2014 17:47:11 +0000 (17:47 +0000)]
Silence MSVC warning on 'uint16_t |= bool' with a cast
This isn't C4800, it's C4805. MSVC says this is unsafe, but it
generates correct code.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200229
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Mon, 27 Jan 2014 17:39:38 +0000 (17:39 +0000)]
[CMake] Put *_exports into "Misc" folder.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200228
91177308-0d34-0410-b5e6-
96231b3b80d8
David Majnemer [Mon, 27 Jan 2014 17:20:25 +0000 (17:20 +0000)]
MC: Add support for .cfi_startproc simple
This commit allows LLVM MC to process .cfi_startproc directives when
they are followed by an additional `simple' identifier. This signals to
elide the emission of target specific CFI instructions that would
normally occur initially.
This fixes PR16587.
Differential Revision: http://llvm-reviews.chandlerc.com/D2624
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200227
91177308-0d34-0410-b5e6-
96231b3b80d8
Tobias Grosser [Mon, 27 Jan 2014 13:44:58 +0000 (13:44 +0000)]
Do not reference llvm-gcc from bugpoint
Reiterating: llvm-gcc is dead since a long time.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200220
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 27 Jan 2014 13:11:50 +0000 (13:11 +0000)]
[vectorize] Initial version of respecting PGO in the vectorizer: treat
cold loops as-if they were being optimized for size.
Nothing fancy here. Simply test case included. The nice thing is that we
can now incrementally build on top of this to drive other heuristics.
All of the infrastructure work is done to get the profile information
into this layer.
The remaining work necessary to make this a fully general purpose loop
unroller for very hot loops is to make it a fully general purpose loop
unroller. Things I know of but am not going to have time to benchmark
and fix in the immediate future:
1) Don't disable the entire pass when the target is lacking vector
registers. This really doesn't make any sense any more.
2) Teach the unroller at least and the vectorizer potentially to handle
non-if-converted loops. This is trivial for the unroller but hard for
the vectorizer.
3) Compute the relative hotness of the loop and thread that down to the
various places that make cost tradeoffs (very likely only the
unroller makes sense here, and then only when dealing with loops that
are small enough for unrolling to not completely blow out the LSD).
I'm still dubious how useful hotness information will be. So far, my
experiments show that if we can get the correct logic for determining
when unrolling actually helps performance, the code size impact is
completely unimportant and we can unroll in all cases. But at least
we'll no longer burn code size on cold code.
One somewhat unrelated idea that I've had forever but not had time to
implement: mark all functions which are only reachable via the global
constructors rigging in the module as optsize. This would also decrease
the impact of any more aggressive heuristics here on code size.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200219
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Mon, 27 Jan 2014 13:11:43 +0000 (13:11 +0000)]
ConstantHoisting: We can't insert instructions directly in front of a PHI node.
Insert before the terminating instruction of the dominating block instead.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200218
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Mon, 27 Jan 2014 11:50:13 +0000 (11:50 +0000)]
XCore: Fix typo in function name.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200216
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 27 Jan 2014 11:41:50 +0000 (11:41 +0000)]
[vectorizer] Add an override for the target instruction cost and use it
to stabilize a test that really is trying to test generic behavior and
not a specific target's behavior.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200215
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 27 Jan 2014 11:27:37 +0000 (11:27 +0000)]
[vectorizer] Simplify code to use existing helpers on the Function
object and fewer pointless variables.
Also, add a clarifying comment and a FIXME because the code which
disables *all* vectorization if we can't use implicit floating point
instructions just makes no sense at all.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200214
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 27 Jan 2014 11:12:24 +0000 (11:12 +0000)]
[vectorizer] Teach the loop vectorizer's unroller to only unroll by
powers of two. This is essentially always the correct thing given the
impact on alignment, scaling factors that can be used in addressing
modes, etc. Also, fix the management of the unroll vs. small loop cost
to more accurately model things with this world.
Enhance a test case to actually exercise more of the unroll machinery if
using synthetic constants rather than a specific target model. Before
this change, with the added flags this test will unroll 3 times instead
of either 2 or 4 (the two sensible answers).
While I don't expect this to make a huge difference, if there are lots
of loops sitting right on the edge of hitting the 'small unroll' factor,
they might change behavior. However, I've benchmarked moving the small
loop cost up and down in many various ways and by a huge factor (2x)
without seeing more than 0.2% code size growth. Small adjustments such
as the series that led up here have led to about 1% improvement on some
benchmarks, but it is very close to the noise floor so I mostly checked
that nothing regressed. Let me know if you see bad behavior on other
targets but I don't expect this to be a sufficiently dramatic change to
trigger anything.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200213
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 27 Jan 2014 11:12:19 +0000 (11:12 +0000)]
[vectorizer] Add some flags which are useful for conducting experiments
with the unrolling behavior in the loop vectorizer. No functionality
changed at this point.
These are a bit hack-y, but talking with Hal, there doesn't seem to be
a cleaner way to easily experiment with different thresholds here and he
was also interested in them so I wanted to commit them. Suggestions for
improvement are very welcome here.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200212
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 27 Jan 2014 11:12:14 +0000 (11:12 +0000)]
[vectorizer] Fix a trivial oversight where we always requested the
number of vector registers rather than toggling between vector and
scalar register number based on VF. I don't have a test case as
I spotted this by inspection and on X86 it only makes a difference if
your target is lacking SSE and thus has *no* vector registers.
If someone wants to add a test case for this for ARM or somewhere else
where this is more significant, that would be awesome.
Also made the variable name a bit more sensible while I'm here.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200211
91177308-0d34-0410-b5e6-
96231b3b80d8
Nick Lewycky [Mon, 27 Jan 2014 10:47:44 +0000 (10:47 +0000)]
Fix crasher introduced in r200203 and caught by a libc++ buildbot. Don't assume that getMulExpr returns a SCEVMulExpr, it may have simplified it to something else!
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200210
91177308-0d34-0410-b5e6-
96231b3b80d8
Nick Lewycky [Mon, 27 Jan 2014 10:04:03 +0000 (10:04 +0000)]
Teach SCEV to handle more cases of 'and X, CST', specifically where CST is any number of contiguous 1 bits in a row, with any number of leading and trailing 0 bits.
Unfortunately, this in turn led to some lower quality SCEVs due to some different paths through expression simplification, so add getUDivExactExpr and use it. This fixes all instances of the problems that I found, but we can make that function smarter as necessary.
Merge test "xor-and.ll" into "and-xor.ll" since I needed to update it anyways. Test 'nsw-offset.ll' analyzes a little deeper, %n now gets a scev in terms of %no instead of a SCEVUnknown.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200203
91177308-0d34-0410-b5e6-
96231b3b80d8
Stepan Dyatkovskiy [Mon, 27 Jan 2014 09:43:10 +0000 (09:43 +0000)]
Additional fix for 200201: due to dependence on bitwidth test was moved to X86 directory.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200202
91177308-0d34-0410-b5e6-
96231b3b80d8
Stepan Dyatkovskiy [Mon, 27 Jan 2014 09:18:31 +0000 (09:18 +0000)]
Fix for PR18102.
Issue outcomes from DAGCombiner::MergeConsequtiveStores, more precisely from
mem-ops sequence sorting.
Consider, how MergeConsequtiveStores works for next example:
store i8 1, a[0]
store i8 2, a[1]
store i8 3, a[1] ; a[1] again.
return ; DAG starts here
1. Method will collect all the 3 stores.
2. It sorts them by distance from the base pointer (farthest with highest
index).
3. It takes first consecutive non-overlapping stores and (if possible) replaces
them with a single store instruction.
The point is, we can't determine here which 'store' instruction
would be the second after sorting ('store 2' or 'store 3').
It happens that 'store 3' would be the second, and 'store 2' would be the third.
So after merging we have the next result:
store i16 (1 | 3 << 8), base ; is a[0] but bit-casted to i16
store i8 2, a[1]
So actually we swapped 'store 3' and 'store 2' and got wrong contents in a[1].
Fix: In sort routine just also take into account mem-op sequence number.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200201
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 27 Jan 2014 08:17:58 +0000 (08:17 +0000)]
[vectorizer] Clean up the handling of unvectorized loop unrolling in the
LoopVectorize pass.
The logic here doesn't make much sense. We *only* unrolled if the
unvectorized loop was a reduction loop with a single basic block *and*
small loop body. The reduction part in particular doesn't make much
sense. Instead, if we just fall through to the vectorized unroll logic
it makes more sense of unrolling if there is a vectorized reduction that
could be hacked on by the SLP vectorizer *or* if the loop is small.
This is mostly a cleanup and nothing in the test suite really exercises
this, but I did run benchmarks across this change and saw no really
significant changes.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200198
91177308-0d34-0410-b5e6-
96231b3b80d8
Michel Danzer [Mon, 27 Jan 2014 07:20:51 +0000 (07:20 +0000)]
R600/SI: Add intrinsic for BUFFER_LOAD_DWORD* instructions
Reviewed-by: Tom Stellard <thomas.stellard@amd.com>
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200196
91177308-0d34-0410-b5e6-
96231b3b80d8
Michel Danzer [Mon, 27 Jan 2014 07:20:44 +0000 (07:20 +0000)]
R600/SI: Add intrinsic for S_SENDMSG instruction
Reviewed-by: Tom Stellard <thomas.stellard@amd.com>
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200195
91177308-0d34-0410-b5e6-
96231b3b80d8
Alp Toker [Mon, 27 Jan 2014 05:24:39 +0000 (05:24 +0000)]
Roll back the ConstStringRef change for now
There are a couple of interesting things here that we want to check over
(particularly the expecting asserts in StringRef) and get right for general use
in ADT so hold back on this one. For clang we have a workable templated
solution to use in the meanwhile.
This reverts commit r200187.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200194
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Mon, 27 Jan 2014 04:33:11 +0000 (04:33 +0000)]
Print .mask and .fmask with the target streamer.
Testing this also found the missing '\n' after .frame that this patch also
fixes.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200192
91177308-0d34-0410-b5e6-
96231b3b80d8
Rui Ueyama [Mon, 27 Jan 2014 04:22:24 +0000 (04:22 +0000)]
Rename IMAGE_DLL_CHARACTERISTICS_HIGH_ENTROPY_VA.
editbin.exe and link.exe both accepts /highentropyva option to set this bit, so
doing s/VIRTUAL_ADDRESS/VA/ should make sense.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200191
91177308-0d34-0410-b5e6-
96231b3b80d8
Alp Toker [Mon, 27 Jan 2014 04:07:36 +0000 (04:07 +0000)]
Move true/false StringRef helper to StringExtras
StringRef is a low-level data wrapper that shouldn't know about language
strings like 'true' and 'false' whereas StringExtras is just the place for
higher-level utilities.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200188
91177308-0d34-0410-b5e6-
96231b3b80d8
Alp Toker [Mon, 27 Jan 2014 04:07:17 +0000 (04:07 +0000)]
StringRef: Extend constexpr capabilities and introduce ConstStringRef
(1) Add llvm_expect(), an asserting macro that can be evaluated as a constexpr
expression as well as a runtime assert or compiler hint in release builds. This
technique can be used to construct functions that are both unevaluated and
compiled depending on usage.
(2) Update StringRef using llvm_expect() to preserve runtime assertions while
extending the same checks to static asserts in C++11 builds that support the
feature.
(3) Introduce ConstStringRef, a strong subclass of StringRef that references
compile-time constant strings. It's convertible to, but not from, ordinary
StringRef and thus can be used to add compile-time safety to various interfaces
in LLVM and clang that only accept fixed inputs such as diagnostic format
strings that tend to get misused.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200187
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Mon, 27 Jan 2014 03:53:56 +0000 (03:53 +0000)]
Print .frame via the target streamer.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200186
91177308-0d34-0410-b5e6-
96231b3b80d8
Kevin Qin [Mon, 27 Jan 2014 02:53:54 +0000 (02:53 +0000)]
[AArch64 NEON] Try to generate CONCAT_VECTOR when lowering BUILD_VECTOR or SHUFFLE_VECTOR.
Replace r199791.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200180
91177308-0d34-0410-b5e6-
96231b3b80d8
Kevin Qin [Mon, 27 Jan 2014 02:53:41 +0000 (02:53 +0000)]
Revert r199791.
It's old version which has some bugs. I'll commit lattest patch soon.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200179
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Mon, 27 Jan 2014 01:33:33 +0000 (01:33 +0000)]
Use SwitchSection in MipsAsmPrinter::EmitStartOfAsmFile.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200178
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Mon, 27 Jan 2014 00:47:51 +0000 (00:47 +0000)]
Remove dead code.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200174
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Mon, 27 Jan 2014 00:19:41 +0000 (00:19 +0000)]
Add back spaces I missed in the conversion to emitRawComments.
Sorry about that.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200171
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Mon, 27 Jan 2014 00:16:00 +0000 (00:16 +0000)]
Use emitRawComment instead of EmitRawText.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200170
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Mon, 27 Jan 2014 00:08:17 +0000 (00:08 +0000)]
Add missing file.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200169
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Sun, 26 Jan 2014 23:57:05 +0000 (23:57 +0000)]
Add a XCoreTargetStreamer and port over the simple uses of EmitRawText.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200167
91177308-0d34-0410-b5e6-
96231b3b80d8
Saleem Abdulrasool [Sun, 26 Jan 2014 22:55:02 +0000 (22:55 +0000)]
MC: fix test locations/name
Placed the MC variant diagnostics in the wrong directory accidentally. Move
them into their respective architecture specific directories.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200161
91177308-0d34-0410-b5e6-
96231b3b80d8
Saleem Abdulrasool [Sun, 26 Jan 2014 22:29:50 +0000 (22:29 +0000)]
ARM: improve diagnostics for .word directive
If a complex expression was passed to the .word directive and the first part of
the directive failed to parse, a secondary diagnostic would be produced that
would clutter the error diagnostics. Improve the diagnostics by consuming the
remainder of the statement.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200160
91177308-0d34-0410-b5e6-
96231b3b80d8
Saleem Abdulrasool [Sun, 26 Jan 2014 22:29:43 +0000 (22:29 +0000)]
AsmParser: improve diagnostics for invalid variants
An emitted diagnostic for an invalid relocation variant would place the caret on
the token following the relocation variant indicator or at the end of the line
if there was no following token. This change corrects the placement of the
caret to point to the token.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200159
91177308-0d34-0410-b5e6-
96231b3b80d8
Saleem Abdulrasool [Sun, 26 Jan 2014 22:29:36 +0000 (22:29 +0000)]
MC: whitespace
Fix indentation, remove unnecessary line. NFC.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200158
91177308-0d34-0410-b5e6-
96231b3b80d8
Alp Toker [Sun, 26 Jan 2014 18:44:34 +0000 (18:44 +0000)]
Avoid C++ comment in C sources
lib/Target/X86/Disassembler/X86DisassemblerDecoder.c:1361:7: error: C++ style comments are not allowed in ISO C90
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200153
91177308-0d34-0410-b5e6-
96231b3b80d8
Evan Cheng [Sun, 26 Jan 2014 18:30:13 +0000 (18:30 +0000)]
Follow up of r200095. Code clean up.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200152
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Sun, 26 Jan 2014 12:41:38 +0000 (12:41 +0000)]
[CMake] tablegen(): Use -I <dir> according to the list by include_directories().
For now, local_tds and global_tds are integrated to dependent_tds.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200150
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Sun, 26 Jan 2014 12:41:33 +0000 (12:41 +0000)]
[CMake] Functionalize tblgen().
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200149
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Sun, 26 Jan 2014 08:12:34 +0000 (08:12 +0000)]
Clean up the Legal/Expand logic for SPARC popc.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200141
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Sun, 26 Jan 2014 06:57:13 +0000 (06:57 +0000)]
Implement the missing bits corresponding to .mips_hack_elf_flags.
These were:
* noreorder handling on the target object streamer and asm parser.
* setting the initial flag bits based on the enabled features.
* setting the elf header flag for micromips
It is *really* depressing I am the one doing this instead of someone at
mips actually taking the time to understand the infrastructure.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200138
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Sun, 26 Jan 2014 06:38:58 +0000 (06:38 +0000)]
Pass a MCSubtargetInfo down to the TargetStreamer creation.
With this the target streamers will be able to know the target features that
are in use.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200135
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Sun, 26 Jan 2014 06:18:56 +0000 (06:18 +0000)]
[CMake] configure_lit_site_cfg: ${SHLIBDIR} should point the build tree.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200134
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Sun, 26 Jan 2014 06:09:59 +0000 (06:09 +0000)]
Only generate the popc instruction for SPARC CPUs that implement it.
The popc instruction is defined in the SPARCv9 instruction set
architecture, but it was emulated on CPUs older than Niagara 2.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200131
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Sun, 26 Jan 2014 06:09:54 +0000 (06:09 +0000)]
Fix swapped CASA operands.
Found by SingleSource/UnitTests/AtomicOps.c
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200130
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Sun, 26 Jan 2014 06:06:37 +0000 (06:06 +0000)]
Construct the MCStreamer before constructing the MCTargetStreamer.
This has a few advantages:
* Only targets that use a MCTargetStreamer have to worry about it.
* There is never a MCTargetStreamer without a MCStreamer, so we can use a
reference.
* A MCTargetStreamer can talk to the MCStreamer in its constructor.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200129
91177308-0d34-0410-b5e6-
96231b3b80d8
Venkatraman Govindaraju [Sun, 26 Jan 2014 05:13:44 +0000 (05:13 +0000)]
[Sparc] Add support for parsing DW_CFA_GNU_window_save.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200127
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Sun, 26 Jan 2014 05:06:48 +0000 (05:06 +0000)]
Convert some easy uses of EmitRawText to TargetStreamer methods.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200122
91177308-0d34-0410-b5e6-
96231b3b80d8
Rui Ueyama [Sun, 26 Jan 2014 05:05:23 +0000 (05:05 +0000)]
COFF: Add a missing enum value for high entropy ASLR.
That bit is not documented in the PE/COFF spec published by Microsoft, so we
don't know the official name of it. I named this bit
IMAGE_DLL_CHARACTERISTICS_HIGH_ENTROPY_VIRTUAL_ADDRESS because the bit is
reported as "high entropy virtual address" by dumpbin.exe,
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200121
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sun, 26 Jan 2014 04:59:39 +0000 (04:59 +0000)]
Improve some x86 type constraints.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200120
91177308-0d34-0410-b5e6-
96231b3b80d8
Jiangning Liu [Sun, 26 Jan 2014 04:55:53 +0000 (04:55 +0000)]
Improve pattern match from v1i8 to v1i32 for AArch64 Neon.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200119
91177308-0d34-0410-b5e6-
96231b3b80d8
Rui Ueyama [Sun, 26 Jan 2014 04:50:15 +0000 (04:50 +0000)]
Remove unused typedef.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200118
91177308-0d34-0410-b5e6-
96231b3b80d8
Rui Ueyama [Sun, 26 Jan 2014 04:15:52 +0000 (04:15 +0000)]
llvm-readobj: add support for PE32+ (Windows 64 bit executable).
PE32+ supports 64 bit address space, but the file format remains 32 bit.
So its file format is pretty similar to PE32 (32 bit executable). The
differences compared to PE32 are (1) the lack of "BaseOfData" field and
(2) some of its data members are 64 bit.
In this patch, I added a new member function to get a PE32+ Header object to
COFFObjectFile class and made llvm-readobj to use it.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200117
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Sun, 26 Jan 2014 04:14:50 +0000 (04:14 +0000)]
Remove -print-hack-directives from a test where we already do the right thing.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200116
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Sun, 26 Jan 2014 04:08:47 +0000 (04:08 +0000)]
Move tests that just use llc from test/MC/Mips to test/MC/Codegen.
This is an expanded version of r200064.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200115
91177308-0d34-0410-b5e6-
96231b3b80d8
Jiangning Liu [Sun, 26 Jan 2014 03:27:40 +0000 (03:27 +0000)]
Implement pattern match from v1xx to v1xx for AArch64 Neon.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200113
91177308-0d34-0410-b5e6-
96231b3b80d8
Venkatraman Govindaraju [Sun, 26 Jan 2014 03:21:28 +0000 (03:21 +0000)]
[Sparc] Add support for sparc relocation types in ELF object file.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200112
91177308-0d34-0410-b5e6-
96231b3b80d8
Kevin Qin [Sun, 26 Jan 2014 02:46:15 +0000 (02:46 +0000)]
[AArch64 NEON] Add patterns for concat_vector on v2i32.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200111
91177308-0d34-0410-b5e6-
96231b3b80d8
Kevin Qin [Sun, 26 Jan 2014 02:23:33 +0000 (02:23 +0000)]
[AArch64 NEON] Add test case for vector FP_ROUND.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200110
91177308-0d34-0410-b5e6-
96231b3b80d8
Kevin Qin [Sun, 26 Jan 2014 02:19:35 +0000 (02:19 +0000)]
[AArch64 NEON] Fix pattern match failed on FP_ROUND from v1f128 to v1f64.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200109
91177308-0d34-0410-b5e6-
96231b3b80d8
Venkatraman Govindaraju [Sat, 25 Jan 2014 23:50:21 +0000 (23:50 +0000)]
removing duplicate enum value
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200104
91177308-0d34-0410-b5e6-
96231b3b80d8
Venkatraman Govindaraju [Sat, 25 Jan 2014 23:40:07 +0000 (23:40 +0000)]
Missing ELF relocations for Sparc.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200103
91177308-0d34-0410-b5e6-
96231b3b80d8
Renato Golin [Sat, 25 Jan 2014 23:38:08 +0000 (23:38 +0000)]
Re-enabling MCJIT tests on ARM
After several refactorings on the MCJIT remote communication, things are
finally looking good on Clang-compiled LLVM regarding MCJIT remote tests,
so I'm re-enabling them to see how the self-hosting buildbot behaves over
a longer period.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200102
91177308-0d34-0410-b5e6-
96231b3b80d8
Venkatraman Govindaraju [Sat, 25 Jan 2014 22:54:47 +0000 (22:54 +0000)]
[Sparc] Add sparc to the list of XFAIL architecture. It seems that the llvm-cov test is not supported in big-endian architectures.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200101
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sat, 25 Jan 2014 22:48:43 +0000 (22:48 +0000)]
Set displacementSize to 1 for instrucitons with mod==0x1. Fixes PR17310. Modified from patch by James Courtier-Dutton.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200100
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Sat, 25 Jan 2014 20:16:36 +0000 (20:16 +0000)]
Add a TBAA CodeGen failure test case
I disabled the use of TBAA in CodeGen in r200093. This adds a test case that
demonstrates the problems with inttoptr and TBAA in CodeGen (and, specifically,
the problem that causes LLVM to miscompile itself in Release mode). This test
will currently fail if -use-tbaa-in-sched-mi is enabled.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200097
91177308-0d34-0410-b5e6-
96231b3b80d8
Evan Cheng [Sat, 25 Jan 2014 19:51:19 +0000 (19:51 +0000)]
Clean up hack which is no longer needed after r198617. No functionality change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200095
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Sat, 25 Jan 2014 19:31:44 +0000 (19:31 +0000)]
XFAIL test/CodeGen/SystemZ/alias-01.ll which requires CodeGen TBAA
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200094
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Sat, 25 Jan 2014 19:24:54 +0000 (19:24 +0000)]
Disable the use of TBAA when using AA in CodeGen
There are currently two issues, of which I currently know, that prevent TBAA
from being correctly usable in CodeGen:
1. Stack coloring does not update TBAA when merging allocas. This is easy
enough to fix, but is not the largest problem.
2. CGP inserts ptrtoint/inttoptr pairs when sinking address computations.
Because BasicAA does not handle inttoptr, we'll often miss basic type punning
idioms that we need to catch so we don't miscompile real-world code (like LLVM).
I don't yet have a small test case for this, but this fixes self hosting a
non-asserts build of LLVM on PPC64 when using -enable-aa-sched-mi and -misched=shuffle.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200093
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sat, 25 Jan 2014 17:40:33 +0000 (17:40 +0000)]
Don't use EnforceSmallerThan for EnforceVectorSubVectorTypeIs. EnforceSmallerThan doesn't handle vectors quite right and should really enforce that vectors have the same number of elements. Add explicit checks for vector element count differing in EnforceVectorSubVectorTypeIs instead. This removes some unnecessary type checks in X86GenDAGISel.inc.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200091
91177308-0d34-0410-b5e6-
96231b3b80d8
Mark Seaborn [Sat, 25 Jan 2014 17:38:19 +0000 (17:38 +0000)]
Fix "llvm-objdump -d -r" to show relocations inline for ELF files
This fixes a regression introduced by r182908, which broke
llvm-objdump's ability to display relocations inline in a disassembly
dump for ELF object files.
That change removed a SectionRelocMap from Object/ELF.h, which we
recreate in llvm-objdump.cpp.
I discovered this regression via an out-of-tree test
(test/NaCl/X86/pnacl-hides-sandbox-x86-64.ll) which used llvm-objdump.
Note that the "Unknown" string in the test output on i386 isn't quite
right, but this appears to be a pre-existing bug.
Differential Revision: http://llvm-reviews.chandlerc.com/D2559
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200090
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sat, 25 Jan 2014 17:34:23 +0000 (17:34 +0000)]
Fix typo in commment tyep->type.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200089
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Sat, 25 Jan 2014 17:32:39 +0000 (17:32 +0000)]
Add combiner-aa-only-func (debug only)
This option (which is !NDEBUG only) allows restricting the use of alias
analysis in DAGCombiner to a specific function. This has proved extremely
valuable to isolating bugs related to this feature, and mirrors the
misched-only-func option provided by the new instruction scheduler.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200088
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Sat, 25 Jan 2014 17:32:37 +0000 (17:32 +0000)]
Improve descriptions of combiner-alias-analysis and combiner-global-alias-analysis
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200087
91177308-0d34-0410-b5e6-
96231b3b80d8
Artyom Skrobov [Sat, 25 Jan 2014 16:56:18 +0000 (16:56 +0000)]
Reverting r199886 (Prevent repetitive warnings for unrecognized processors and features)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200083
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Sat, 25 Jan 2014 15:15:16 +0000 (15:15 +0000)]
Added .DS_Store entry in .gitignore for ignoring .DS_Store files in the source
tree generated by OS X.
Patch by Abhay Kadam!
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200079
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Sat, 25 Jan 2014 15:06:56 +0000 (15:06 +0000)]
This reverts commit r200064 and r200051.
r200064 depends on r200051.
r200051 is broken: I tries to replace .mips_hack_elf_flags, which is a good
thing, but what it replaces it with is even worse.
The new emitMipsELFFlags it adds corresponds to no assembly directive, is not
marked as a hack and is not even printed to the .s file.
The patch also introduces more uses of hasRawTextSupport.
The correct way to remove .mips_hack_elf_flags is to have the mips target
streamer handle the default flags (and command line options). That way the
same code path is used for asm and obj. The streamer interface should *really*
correspond to what is printed in the .s file.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200078
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Sat, 25 Jan 2014 10:01:55 +0000 (10:01 +0000)]
[LPM] Conclude my immediate work by making the LoopVectorizer
a FunctionPass. With this change the loop vectorizer no longer is a loop
pass and can readily depend on function analyses. In particular, with
this change we no longer have to form a loop pass manager to run the
loop vectorizer which simplifies the entire pass management of LLVM.
The next step here is to teach the loop vectorizer to leverage profile
information through the profile information providing analysis passes.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200074
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sat, 25 Jan 2014 05:33:48 +0000 (05:33 +0000)]
Use isConcrete and getConcrete instead of using TypeVec directly.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200071
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sat, 25 Jan 2014 05:17:38 +0000 (05:17 +0000)]
Fix EnforceSmallerThan to check !hasVectorTypes on the other type instead of this type to force this type to be scalar.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200070
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Sat, 25 Jan 2014 04:07:24 +0000 (04:07 +0000)]
[LPM] Make LCSSA a utility with a FunctionPass that applies it to all
the loops in a function, and teach LICM to work in the presance of
LCSSA.
Previously, LCSSA was a loop pass. That made passes requiring it also be
loop passes and unable to depend on function analysis passes easily. It
also caused outer loops to have a different "canonical" form from inner
loops during analysis. Instead, we go into LCSSA form and preserve it
through the loop pass manager run.
Note that this has the same problem as LoopSimplify that prevents
enabling its verification -- loop passes which run at the end of the loop
pass manager and don't preserve these are valid, but the subsequent loop
pass runs of outer loops that do preserve this pass trigger too much
verification and fail because the inner loop no longer verifies.
The other problem this exposed is that LICM was completely unable to
handle LCSSA form. It didn't preserve it and it actually would give up
on moving instructions in many cases when they were used by an LCSSA phi
node. I've taught LICM to support detecting LCSSA-form PHI nodes and to
hoist and sink around them. This may actually let LICM fire
significantly more because we put everything into LCSSA form to rotate
the loop before running LICM. =/ Now LICM should handle that fine and
preserve it correctly. The down side is that LICM has to require LCSSA
in order to preserve it. This is just a fact of life for LCSSA. It's
entirely possible we should completely remove LCSSA from the optimizer.
The test updates are essentially accomodating LCSSA phi nodes in the
output of LICM, and the fact that we now completely sink every
instruction in ashr-crash below the loop bodies prior to unrolling.
With this change, LCSSA is computed only three times in the pass
pipeline. One of them could be removed (and potentially a SCEV run and
a separate LoopPassManager entirely!) if we had a LoopPass variant of
InstCombine that ran InstCombine on the loop body but refused to combine
away LCSSA PHI nodes. Currently, this also prevents loop unrolling from
being in the same loop pass manager is rotate, LICM, and unswitch.
There is one thing that I *really* don't like -- preserving LCSSA in
LICM is quite expensive. We end up having to re-run LCSSA twice for some
loops after LICM runs because LICM can undo LCSSA both in the current
loop and the parent loop. I don't really see good solutions to this
other than to completely move away from LCSSA and using tools like
SSAUpdater instead.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200067
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Sat, 25 Jan 2014 02:35:56 +0000 (02:35 +0000)]
Remove an easy use of EmitRawText from PPC.
This makes lib/Target/PowerPC EmitRawText free.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200065
91177308-0d34-0410-b5e6-
96231b3b80d8
Jack Carter [Sat, 25 Jan 2014 02:14:14 +0000 (02:14 +0000)]
[Mips] Move 2 test cases from MC to CodeGen.
No code changes. Just reassignment of test case files.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200064
91177308-0d34-0410-b5e6-
96231b3b80d8
Juergen Ributzka [Sat, 25 Jan 2014 02:02:55 +0000 (02:02 +0000)]
Revert "Revert "Add Constant Hoisting Pass" (r200034)"
This reverts commit r200058 and adds the using directive for
ARMTargetTransformInfo to silence two g++ overload warnings.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200062
91177308-0d34-0410-b5e6-
96231b3b80d8
Reid Kleckner [Sat, 25 Jan 2014 01:24:06 +0000 (01:24 +0000)]
Fix llvm-dis to print the inalloca bit on allocas.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200059
91177308-0d34-0410-b5e6-
96231b3b80d8
Hans Wennborg [Sat, 25 Jan 2014 01:18:18 +0000 (01:18 +0000)]
Revert "Add Constant Hoisting Pass" (r200034)
This commit caused -Woverloaded-virtual warnings. The two new
TargetTransformInfo::getIntImmCost functions were only added to the superclass,
and to the X86 subclass. The other targets were not updated, and the
warning highlighted this by pointing out that e.g. ARMTTI::getIntImmCost was
hiding the two new getIntImmCost variants.
We could pacify the warning by adding "using TargetTransformInfo::getIntImmCost"
to the various subclasses, or turning it off, but I suspect that it's wrong to
leave the functions unimplemnted in those targets. The default implementations
return TCC_Free, which I don't think is right e.g. for ARM.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200058
91177308-0d34-0410-b5e6-
96231b3b80d8
Mark Seaborn [Sat, 25 Jan 2014 00:32:01 +0000 (00:32 +0000)]
llvm-objdump: Some style cleanups to follow LLVM coding style
Rename "ec" to "EC", and rename some iterators.
Then fix whitespace using clang-format-diff.
(As requested in http://llvm-reviews.chandlerc.com/D2559)
Differential Revision: http://llvm-reviews.chandlerc.com/D2594
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200053
91177308-0d34-0410-b5e6-
96231b3b80d8
Jack Carter [Sat, 25 Jan 2014 00:24:07 +0000 (00:24 +0000)]
[Mips] TargetStreamer ELF flag Support for default and commandline options.
This patch uses a common MipsTargetSteamer interface for both
MipsAsmPrinter and MipsAsmParser for recording default and commandline
driven directives that affect ELF header flags.
It has been noted that the .ll tests affected by this patch belong in
test/Codegen/Mips. I will move them in a separate patch.
Also, a number of directives do not get expressed by AsmPrinter in the
resultant .s assembly such as setting the correct ASI. I have noted this
in the tests and they will be addressed in later patches.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200051
91177308-0d34-0410-b5e6-
96231b3b80d8
Aaron Ballman [Fri, 24 Jan 2014 23:40:08 +0000 (23:40 +0000)]
Typo fix.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200050
91177308-0d34-0410-b5e6-
96231b3b80d8
Ana Pazos [Fri, 24 Jan 2014 22:36:53 +0000 (22:36 +0000)]
[AArch64] Removed unused i8 type from FPR8 register class.
The i8 type is not registered with any register class.
This causes a segmentation fault in MachineLICM::getRegisterClassIDAndCost.
The code selects the first type associated with register class FPR8,
which happens to be i8.
It uses this type (i8) to get the representative class pointer, which is 0.
It then uses this pointer to access a field, resulting in segmentation fault.
Since i8 type is not being used for printing any neon instruction
we can safely remove it.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200046
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Fri, 24 Jan 2014 21:52:44 +0000 (21:52 +0000)]
Fix c++03 build.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200042
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Fri, 24 Jan 2014 21:32:21 +0000 (21:32 +0000)]
Make ObjectFile ownership of the MemoryBuffer optional.
This allows llvm-ar to mmap the input files only once.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200040
91177308-0d34-0410-b5e6-
96231b3b80d8
Rui Ueyama [Fri, 24 Jan 2014 20:54:10 +0000 (20:54 +0000)]
Support/COFF: Fix PEHeader struct, and define PE32Header as its alias.
This change does not affect anything because everybody seems to be using
Object/COFF.h instead. But the definition is not for PE32 but for PE32+,
so fix it anyway.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200038
91177308-0d34-0410-b5e6-
96231b3b80d8