Matthias Beyer [Mon, 30 Jun 2014 08:25:21 +0000 (10:25 +0200)]
Staging: bcm: LeakyBucket.c: Removed unneccessary return; statement
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Acked-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Mon, 30 Jun 2014 08:25:20 +0000 (10:25 +0200)]
Staging: bcm: LeakyBucket.c: Outsourced ctrl packet sending
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Acked-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Mon, 30 Jun 2014 08:25:19 +0000 (10:25 +0200)]
Staging: bcm: LeakyBucket.c: Outsourced code chunk into function
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Acked-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Mon, 30 Jun 2014 08:25:18 +0000 (10:25 +0200)]
Staging: bcm: LeakyBucket.c: Shortened lines
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Acked-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Mon, 30 Jun 2014 08:25:17 +0000 (10:25 +0200)]
Staging: bcm: LeakyBucket.c: Replaced member accessing by variable
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Acked-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Mon, 30 Jun 2014 08:20:24 +0000 (10:20 +0200)]
Staging: bcm: InterfaceTx.c: checkpath fix: Blank line after declarations
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Acked-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Mon, 30 Jun 2014 08:20:23 +0000 (10:20 +0200)]
Staging: bcm: InterfaceTx.c: Outsourced code chunk
This patch outsources a chunk of code into an own function and refactors
the variable names inside the new function.
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Acked-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Mon, 30 Jun 2014 08:20:22 +0000 (10:20 +0200)]
Staging: bcm: InterfaceTx.c: Shortened lines + Whitespace cleanup
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Acked-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Mon, 30 Jun 2014 08:10:04 +0000 (10:10 +0200)]
Staging: bcm: InterfaceRx.c: Removed unused variable
This patch removes the `process_done` variable from both
format_eth_hdr_to_stack() and read_bulk_callback() (where it is
declared), as it is not used anywhere (it is set in the
format_eth_hdr_to_stack() function, but afterwards not used).
Acked-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Mon, 30 Jun 2014 08:10:03 +0000 (10:10 +0200)]
Staging: bcm: InterfaceRx.c: Outsourced code chunk
This patch outsources a chunk of code into a function.
Acked-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Mon, 30 Jun 2014 08:10:02 +0000 (10:10 +0200)]
Staging: bcm: InterfaceRx.c: Outsourced control packet handling
Acked-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Mon, 30 Jun 2014 08:10:01 +0000 (10:10 +0200)]
Staging: bcm: InterfaceRx.c: Lines shortened
Acked-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 6 Jul 2014 22:19:48 +0000 (23:19 +0100)]
staging: vt6656: vnt_update_ifs vendor changes to uSIFS/uDIFS
The latest vendor code makes changes to uSIFS and uDIFS.
The orginal codes have been rearranged into a fall through switch
statement.
These reduce the time that device allows to TX packets and
improves throughput.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 6 Jul 2014 22:19:47 +0000 (23:19 +0100)]
staging: vt6656: vnt_set_keymode don't save pairwise key entry.
The device refuses to associate to older access points even though in
the logs it appears to be associated in tkip or ccmp mode.
Clear bit from key_entry_inuse in pairwise key so the entry is over written
by group address.
This doesn't seem to make any difference to newer access points and
is a temporary fix until a better solution is found.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 6 Jul 2014 22:19:46 +0000 (23:19 +0100)]
staging: vt6656: s_nsBulkInUsbIoCompleteRead check that used sk_buff is clean and ready to reuse.
skb_push the headroom and trimmed back to 0
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anton Protopopov [Tue, 1 Jul 2014 17:06:29 +0000 (21:06 +0400)]
staging: vt6655: fixed sparse warnings
This commit fixes a few sparse warnings for missing the 'static' keyword
in array definitions:
drivers/staging//vt6655/rxtx.c:81:22: warning: symbol 'wTimeStampOff' was not declared. Should it be static?
drivers/staging//vt6655/rxtx.c:86:22: warning: symbol 'wFB_Opt0' was not declared. Should it be static?
drivers/staging//vt6655/rxtx.c:90:22: warning: symbol 'wFB_Opt1' was not declared. Should it be static?
Signed-off-by: Anton Protopopov <a.s.protopopov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 5 Jul 2014 18:24:27 +0000 (19:24 +0100)]
stagingL vt6656: implement fall back rates reporting.
The driver reports the rate tried in struct vnt_interrupt_data tsr* variables
which is available in INTnsProcessData via interrupt urb context.
Instead of closing apTD tx context in s_nsBulkOutIoCompleteWrite by setting
in_use to false. Keep the context open and allow vnt_int_report_rate to
close it.
If the tx_retry value is correct it will report back the sucessful RATE tried.
struct vnt_usb_send_context add pkt_no which is index of apTD
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 5 Jul 2014 18:24:26 +0000 (19:24 +0100)]
staging: vt6656: Include re_alloc_skb within lock.
Remove variable re_alloc_skb and merge code within urb->actual_length.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 5 Jul 2014 18:24:25 +0000 (19:24 +0100)]
staging: vt6656: vnt_set_channel remove power setting functions
Power setting is already done in vnt_config and vnt_tx_packet.
Just check that for connection_channel, if invalid return.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 5 Jul 2014 18:24:24 +0000 (19:24 +0100)]
staging: vt6656: vnt_rx_data add track rsr and new_rsr errors
Add rsr and new_rsr error packet error drop.
if NEWRSR_DECRYPTOK fails drop packet altogether.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 5 Jul 2014 18:24:23 +0000 (19:24 +0100)]
staging: vt6656: vnt_tx_packet don't change power when off channel.
The changing channel is so fast when off channel that changing power is pointless.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 5 Jul 2014 18:24:22 +0000 (19:24 +0100)]
staging: vt6656: vnt_rf_setpower rate <= RATE_11M check array bound
decrement channel by one and check array bound.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 5 Jul 2014 18:24:21 +0000 (19:24 +0100)]
staging: vt6656: vnt_rf_set_txpower use power for priv->byCurPwr
The byCurPwr value can change state while in another thread,.
Change to local variable power which is the last set value.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 5 Jul 2014 18:24:20 +0000 (19:24 +0100)]
staging: vt6656: turn radio off after mac registered.
Turn the radio off to save power is the device is unused
on system.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 29 Jun 2014 19:39:55 +0000 (20:39 +0100)]
staging: vt6656: s_nsBulkOutIoCompleteWrite fix bug of 5GHZ a rates idx
On 2GHz band the values of wCurrentRate match the idx rates.
However, on 5GHz they do not because in channel.c vnt_rates_a do not
match idx.
Instead use the info->control.rates[0].idx the value that was tried.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 29 Jun 2014 19:39:54 +0000 (20:39 +0100)]
staging: vt6656: implement get_stats ieee80211_low_level_stats
The driver already report low_level_stats via vnt_interrupt_data.
Allow mac80211 to collect them via vnt_get_stats
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chi Pham [Thu, 3 Jul 2014 13:03:59 +0000 (15:03 +0200)]
staging:
ced1401: Add void declarations in zero-arg functions.
Added explicit void declarations to zero-argument function headers.
The following coccinelle script was used:
@addvoid@
identifier f;
@@
f(
+ void
) { ... }
Signed-off-by: Chi Pham <fempsci@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 10:00:45 +0000 (12:00 +0200)]
staging:
ced1401: remove typedef for CIRCBLK
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 10:00:44 +0000 (12:00 +0200)]
staging:
ced1401: rename FreeCircBlock()
rename camel case function FreeCircBlock() to ced_free_circ_block()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 10:00:43 +0000 (12:00 +0200)]
staging:
ced1401: rename GetCircBlock()
rename camel case function GetCircBlock() to ced_get_circ_block()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 10:00:42 +0000 (12:00 +0200)]
staging:
ced1401: rename SetCircular()
rename camel case function SetCircular() to ced_set_circular()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 10:00:41 +0000 (12:00 +0200)]
staging:
ced1401: rename DbgStopLoop()
rename camel case function DbgStopLoop() to ced_dbg_stop_loop()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 10:00:40 +0000 (12:00 +0200)]
staging:
ced1401: rename DbgGetData()
rename camel case function DbgGetData() to ced_dbg_get_data()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 10:00:39 +0000 (12:00 +0200)]
staging:
ced1401: rename DbgRampAddr()
rename camel case function DbgRampAddr() to ced_dbg_ramp_addr()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 10:00:38 +0000 (12:00 +0200)]
staging:
ced1401: rename DbgRampData()
rename camel case function DbgRampData() to ced_dbg_ramp_data()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 10:00:37 +0000 (12:00 +0200)]
staging:
ced1401: rename DbgPoke()
rename camel case function DbgPoke() to ced_dbg_poke()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 10:00:36 +0000 (12:00 +0200)]
staging:
ced1401: rename DbgPeek()
rename camel case function DbgPeek() to ced_dbg_peek()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 10:00:35 +0000 (12:00 +0200)]
staging:
ced1401: rename DbgCmd1401()
rename camel case function DbgCmd1401() to ced_dbg_cmd()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 10:00:34 +0000 (12:00 +0200)]
staging:
ced1401: rename TransferFlags()
rename camel case function TransferFlags() to ced_transfer_flags()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 10:00:33 +0000 (12:00 +0200)]
staging:
ced1401: rename TypeOf1401()
rename camel case function TypeOf1401() to ced_type_of_1401()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 10:00:32 +0000 (12:00 +0200)]
staging:
ced1401: rename CheckSelfTest()
rename camel case function CheckSelfTest() to ced_check_self_test()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 10:00:31 +0000 (12:00 +0200)]
staging:
ced1401: rename StartSelfTest()
rename camel case function StartSelfTest() to ced_start_self_test()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 10:00:30 +0000 (12:00 +0200)]
staging:
ced1401: rename StateOf1401()
rename camel case function StateOf1401() to ced_state_of_1401()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 10:00:29 +0000 (12:00 +0200)]
staging:
ced1401: remove unused func BlkTransState
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 09:58:16 +0000 (11:58 +0200)]
staging:
ced1401: rename KillIO1401()
rename camel case function KillIO1401() to ced_kill_io()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 09:58:15 +0000 (11:58 +0200)]
staging:
ced1401: rename GetTransfer()
rename camel case function GetTransfer() to ced_get_transfer()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 09:58:14 +0000 (11:58 +0200)]
staging:
ced1401: rename TestEvent()
rename camel case function TestEvent() to ced_test_event()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 09:58:13 +0000 (11:58 +0200)]
staging:
ced1401: rename WaitEvent()
rename camel case function WaitEvent() to ced_wait_event()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 09:58:12 +0000 (11:58 +0200)]
staging:
ced1401: rename SetEvent()
rename camel case function SetEvent() to ced_set_event()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 09:58:11 +0000 (11:58 +0200)]
staging:
ced1401: rename UnsetTransfer()
rename camel case function UnsetTransfer() to ced_unset_transfer()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 09:58:10 +0000 (11:58 +0200)]
staging:
ced1401: rename SetTransfer()
rename camel case function SetTransfer() to ced_set_transfer()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 09:58:09 +0000 (11:58 +0200)]
staging:
ced1401: rename SetArea()
rename camel case function SetArea() to ced_set_area()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 09:58:08 +0000 (11:58 +0200)]
staging:
ced1401: rename ClearArea()
rename camel case function ClearArea() to ced_clear_area()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 09:58:07 +0000 (11:58 +0200)]
staging:
ced1401: rename GetOutBufSpace()
rename camel case function GetOutBufSpace() to ced_get_out_buf_space()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 09:58:06 +0000 (11:58 +0200)]
staging:
ced1401: rename LineCount()
rename camel case function LineCount() to ced_line_count()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 09:58:05 +0000 (11:58 +0200)]
staging:
ced1401: rename Stat1401()
rename camel case function Stat1401() to ced_stat_1401()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 09:58:04 +0000 (11:58 +0200)]
staging:
ced1401: rename GetString()
rename camel case function GetString() to ced_get_string()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 09:58:03 +0000 (11:58 +0200)]
staging:
ced1401: rename Reset1401()
rename camel case function Reset1401() to ced_reset()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 09:58:02 +0000 (11:58 +0200)]
staging:
ced1401: rename QuickCheck()
rename camel case function QuickCheck() to ced_quick_check() and make it
static
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 09:58:01 +0000 (11:58 +0200)]
staging:
ced1401: make ced_is_1401() static
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 09:58:00 +0000 (11:58 +0200)]
staging:
ced1401: rename Is1401()
rename camel case function Is1401() to ced_is_1401()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 09:57:59 +0000 (11:57 +0200)]
staging:
ced1401: rename InSelfTest()
rename camel case function InSelfTest() to ced_in_self_test()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 09:57:58 +0000 (11:57 +0200)]
staging:
ced1401: rename ReadWrite_Cancel()
rename camel case function ReadWrite_Cancel() to ced_read_write_cancel()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 09:57:57 +0000 (11:57 +0200)]
staging:
ced1401: rename Get1401State()
rename camel case function Get1401State() to ced_get_state()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 09:57:56 +0000 (11:57 +0200)]
staging:
ced1401: rename SendChar()
rename camel case function SendChar() to ced_send_char()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 09:57:55 +0000 (11:57 +0200)]
staging:
ced1401: rename SendString()
rename camel case function SendString() to ced_send_string()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 09:57:54 +0000 (11:57 +0200)]
staging:
ced1401: rename PutChars()
rename camel case function PutChars() to ced_put_chars()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 09:57:53 +0000 (11:57 +0200)]
staging:
ced1401: rename FlushInBuff()
rename camel case function FlushInBuff() to ced_flush_in_buff()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 09:57:52 +0000 (11:57 +0200)]
staging:
ced1401: rename FlushOutBuff()
rename camel case function FlushOutBuff() to ced_flush_out_buff()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 09:57:51 +0000 (11:57 +0200)]
staging:
ced1401: rename Allowi()
rename camel case function Allowi() to ced_allowi()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 09:57:50 +0000 (11:57 +0200)]
staging:
ced1401: rename Handle1401Esc()
rename camel case function Handle1401Esc() to ced_handle_esc()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 09:57:49 +0000 (11:57 +0200)]
staging:
ced1401: rename ReadDMAInfo()
rename camel case function ReadDMAInfo() to ced_read_dma_info()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 09:57:48 +0000 (11:57 +0200)]
staging:
ced1401: rename ReadHuff()
rename camel case function ReadHuff() to ced_read_huff()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 09:57:47 +0000 (11:57 +0200)]
staging:
ced1401: rename ReadWord()
rename camel case function ReadWord() to ced_read_word()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 09:57:46 +0000 (11:57 +0200)]
staging:
ced1401: rename ReadChar()
rename camel case function ReadChar() to ced_read_char()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 09:57:45 +0000 (11:57 +0200)]
staging:
ced1401: rename ReadWriteMem()
rename camel case function ReadWriteMem() to ced_read_write_mem()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 09:57:44 +0000 (11:57 +0200)]
staging:
ced1401: rename StageChunk()
rename camel case function StageChunk() to ced_stage_chunk()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 09:57:43 +0000 (11:57 +0200)]
staging:
ced1401: rename CopyUserSpace()
rename camel case function CopyUserSpace() to ced_copy_user_space()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 09:57:42 +0000 (11:57 +0200)]
staging:
ced1401: rename SendChars()
rename camel case function SendChars() to ced_send_chars()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Mon, 30 Jun 2014 09:57:41 +0000 (11:57 +0200)]
staging:
ced1401: rename CanAcceptIoRequests()
rename camel case function CanAcceptIoRequests() to can_accept_io_requests()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabian Frederick [Tue, 1 Jul 2014 08:11:23 +0000 (10:11 +0200)]
staging: rtl8723au: Remove unnecessary null test before kfree
Fix checkpatch warning:
WARNING: kfree(NULL) is safe this check is probably not required
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: linux-wireless@vger.kernel.org
Signed-off-by: Fabian Frederick <fabf@skynet.be>
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 1 Jul 2014 08:11:22 +0000 (10:11 +0200)]
staging: rtl8723au: Simplify _BlockWrite() based on saner rtl8723au_writeN()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 1 Jul 2014 10:07:00 +0000 (12:07 +0200)]
staging: rtl8723au: Sanitize USB read/write functions
The original Realtek provided functions suffered badly from clutter to
accommodate broken operating systems. Lets try this lean and clean
version instead.
v2: Do not use the stack for data passed to usb_control_msg(). This
requires reintroducing the mutex used in the old function. In
addition, get rid of the no longer used 'usb_vendor_req_buf'.
Note that rtl8723au_writeN() remains unlocked, so it can be used
for bulk block transfers without having to retake the mutex for
every write().
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 1 Jul 2014 08:11:20 +0000 (10:11 +0200)]
staging: rtl8723au: Remove never set struct rtw_adapter->bNotifyChannelChange
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 1 Jul 2014 08:11:19 +0000 (10:11 +0200)]
staging: rtl8723au: pwrctrl_priv->ps_flag is never set
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 1 Jul 2014 08:11:18 +0000 (10:11 +0200)]
staging: rtl8723au: pnp_bstop_trx is never set
In addition remove unused pnp_current_pwr_state
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 1 Jul 2014 08:11:17 +0000 (10:11 +0200)]
staging: rtl8723au: Remove unused variables from struct pwrctrl_priv
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 1 Jul 2014 08:11:16 +0000 (10:11 +0200)]
staging: rtl8723au: Remove unused pwrctrl_priv->brfoffbyhw
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 1 Jul 2014 08:11:15 +0000 (10:11 +0200)]
staging: rtl8723au: Fold power_saving_wk_hdl() into rtw_drvextra_cmd_hdl23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 1 Jul 2014 08:11:14 +0000 (10:11 +0200)]
staging: rtl8723au: Clean up rtw_pm_set_ips23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jerry Stralko [Tue, 1 Jul 2014 11:13:18 +0000 (07:13 -0400)]
staging: android: logger: fixed checkpatch.pl warnings.
Signed-off-by: Jerry Stralko <gerb.stralko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chen Gang [Mon, 7 Jul 2014 08:49:24 +0000 (16:49 +0800)]
drivers: staging: android: ion: Kconfig: Let it also depend on HAS_DMA
ION need HAS_DMA (e.g. need DMA_SHARED_BUFFER), so it has to depend on
HAS_DMA, or can not pass compiling with allmodconfig under score which
NO_DMA. And the related error:
CC drivers/staging/android/ion/ion_cma_heap.o
drivers/staging/android/ion/ion_cma_heap.c: In function 'ion_cma_mmap':
drivers/staging/android/ion/ion_cma_heap.c:168:2: error: implicit declaration of function 'dma_mmap_coherent' [-Werror=implicit-function-declaration]
return dma_mmap_coherent(dev, vma, info->cpu_addr, info->handle,
^
cc1: some warnings being treated as errors
make[4]: *** [drivers/staging/android/ion/ion_cma_heap.o] Error 1
make[3]: *** [drivers/staging/android/ion] Error 2
make[2]: *** [drivers/staging/android] Error 2
make[1]: *** [drivers/staging] Error 2
make: *** [drivers] Error 2
Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tair Rzayev [Tue, 3 Jun 2014 19:27:21 +0000 (22:27 +0300)]
staging: android: binder.c: binder_ioctl() cleanup
binder_ioctl() is quite huge and checkpatch dirty - mostly because of
the amount of code for the BINDER_WRITE_READ and BINDER_SET_CONTEXT_MGR.
Moved that code into the new binder_ioctl_write_read() and
binder_ioctl_set_ctx_mgr()
Signed-off-by: Tair Rzayev <tair.rzayev@gmail.com>
Cc: Arve Hjønnevåg <arve@android.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Vinayak Menon [Mon, 2 Jun 2014 12:47:59 +0000 (18:17 +0530)]
staging: binder: add vm_fault handler
An issue was observed when a userspace task exits.
The page which hits error here is the zero page.
In binder mmap, the whole of vma is not mapped.
On a task crash, when debuggerd reads the binder regions,
the unmapped areas fall to do_anonymous_page in handle_pte_fault,
due to the absence of a vm_fault handler. This results in
zero page being mapped. Later in zap_pte_range, vm_normal_page
returns zero page in the case of VM_MIXEDMAP and it results in the
error.
BUG: Bad page map in process mediaserver pte:
9dff379f pmd:
9bfbd831
page:
c0ed8e60 count:1 mapcount:-1 mapping: (null) index:0x0
page flags: 0x404(referenced|reserved)
addr:
40c3f000 vm_flags:
10220051 anon_vma: (null) mapping:
d9fe0764 index:fd
vma->vm_ops->fault: (null)
vma->vm_file->f_op->mmap: binder_mmap+0x0/0x274
CPU: 0 PID: 1463 Comm: mediaserver Tainted: G W 3.10.17+ #1
[<
c001549c>] (unwind_backtrace+0x0/0x11c) from [<
c001200c>] (show_stack+0x10/0x14)
[<
c001200c>] (show_stack+0x10/0x14) from [<
c0103d78>] (print_bad_pte+0x158/0x190)
[<
c0103d78>] (print_bad_pte+0x158/0x190) from [<
c01055f0>] (unmap_single_vma+0x2e4/0x598)
[<
c01055f0>] (unmap_single_vma+0x2e4/0x598) from [<
c010618c>] (unmap_vmas+0x34/0x50)
[<
c010618c>] (unmap_vmas+0x34/0x50) from [<
c010a9e4>] (exit_mmap+0xc8/0x1e8)
[<
c010a9e4>] (exit_mmap+0xc8/0x1e8) from [<
c00520f0>] (mmput+0x54/0xd0)
[<
c00520f0>] (mmput+0x54/0xd0) from [<
c005972c>] (do_exit+0x360/0x990)
[<
c005972c>] (do_exit+0x360/0x990) from [<
c0059ef0>] (do_group_exit+0x84/0xc0)
[<
c0059ef0>] (do_group_exit+0x84/0xc0) from [<
c0066de0>] (get_signal_to_deliver+0x4d4/0x548)
[<
c0066de0>] (get_signal_to_deliver+0x4d4/0x548) from [<
c0011500>] (do_signal+0xa8/0x3b8)
Add a vm_fault handler which returns VM_FAULT_SIGBUS, and prevents the
wrong fallback to do_anonymous_page.
Signed-off-by: Vinayak Menon <vinayakm.list@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Erik Arfvidson [Tue, 8 Jul 2014 17:21:30 +0000 (13:21 -0400)]
staging: unisys: remove all proc entries from virtpci
This patch removes all proc entries from virtpci
Signed-off-by: Erik Arfvidson <erik.arfvidson@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ken Cox [Thu, 3 Jul 2014 15:02:18 +0000 (10:02 -0500)]
Staging: unisys: Fix noderef sparse warnings in vbusdeviceinfo.h
vbuschannel_devinfo_to_string() was declared with the devinfo argument
as a pointer to __iomem space. No callers of this function need the
__iomem space, so I removed that constraint.
Same thing goes for vbuschannel_sanitize_buffer(). It doesn't need to
operate on I/O space.
Signed-off-by: Ken Cox <jkc@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ken Cox [Thu, 3 Jul 2014 15:02:17 +0000 (10:02 -0500)]
Staging: unisys: Remove ultra_vbus_init_channel function
The function ultra_vbus_init_channel() is never called since
previous server code was removed. Remove the dead code.
Signed-off-by: Ken Cox <jkc@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ken Cox [Thu, 3 Jul 2014 15:02:16 +0000 (10:02 -0500)]
Staging: unisys: Remove isServer arg from init_vbus_channel()
The init_vbus_channel() function is never called with the isServer
argument equal to TRUE, so just get rid of the argument altogether.
This also means that the code in the function that would be executed
in the server case can be removed since it is never executed.
Signed-off-by: Ken Cox <jkc@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ken Cox [Thu, 3 Jul 2014 15:02:15 +0000 (10:02 -0500)]
Staging: unisys: use Linux coding convention for function names
Change function names to conform to Linux kernel coding convention.
ULTRA_VBUS_init_channel() --> ultra_vbus_init_channel()
VBUSCHANNEL_devInfoToStringBuffer() --> vbuschannel_devinfo_to_string()
VBUSCHANNEL_sanitize_buffer() --> vbuschannel_sanitize_buffer()
VBUSCHANNEL_itoa() --> vbuschannel_itoa()
Signed-off-by: Ken Cox <jkc@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ken Cox [Mon, 30 Jun 2014 13:06:33 +0000 (08:06 -0500)]
Staging:unisys: Add Kconfig dependency on UNISYS_VISORUTIL to UNISYS_CHANNELSTUB
The visorchannelstub module references the variable unisys_spar_platform
which is declared in the visorutil module. Add the proper dependency to
Kconfig to ensure that visorutil is enabled when building visorchannelstub.
This address the build error:
drivers/built-in.o: In function `channel_mod_init':
chanstub.c:(.init.text+0xbe24): undefined reference to `unisys_spar_platform'
Reported by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Ken Cox <jkc@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>