navin patidar [Thu, 10 Jul 2014 03:42:27 +0000 (09:12 +0530)]
staging: rtl8188eu: Remove unused functions rtw_cbuf_[full, empty, push, pop]()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:42:26 +0000 (09:12 +0530)]
staging: rtl8188eu: Remove unused function rtw_cbuf_alloc()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:42:25 +0000 (09:12 +0530)]
staging: rtl8188eu: Use msecs_to_jiffies() instead of rtw_ms_to_systime()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:42:24 +0000 (09:12 +0530)]
staging: rtl8188eu: use jiffies_to_msecs() instead of rtw_systime_to_ms()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:42:23 +0000 (09:12 +0530)]
staging: rtl8188eu: rtw_efuse.c: Remove unused functions
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:42:22 +0000 (09:12 +0530)]
staging: rtl8188eu: Remove unused function HalDetectPwrDownMode88E()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:42:21 +0000 (09:12 +0530)]
staging: rtl8188eu: Remove unused functions rtw_efuse_map_[read, write]()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:42:20 +0000 (09:12 +0530)]
staging: rtl8188eu: rtw_efuse.c : Remove unused functions
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:42:19 +0000 (09:12 +0530)]
staging: rtl8188eu: Remove function efuse_GetMaxSize()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:42:18 +0000 (09:12 +0530)]
staging: rtl8188eu: Remove unused function efuse_GetCurrentSize()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:42:17 +0000 (09:12 +0530)]
staging: rtl8188eu: Remove function rtw_alloc_etherdev()
rtw_alloc_etherdev() is used in rtw_init_netdev() but never gets called
because old_padapter is never NULL.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:42:16 +0000 (09:12 +0530)]
staging: rtl8188eu: Remove unused function rtw_change_ifname()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:42:15 +0000 (09:12 +0530)]
staging: rtl8188eu: Remove dummy function rtw_free_cmd_priv()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:42:14 +0000 (09:12 +0530)]
staging: rtl8188eu: Remove cmd_seq from struct cmd_priv
Value stored in cmd_seq isn't used by driver.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:42:13 +0000 (09:12 +0530)]
staging: rtl8188eu: rtw_cmd.h: Remove unused structures
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:42:12 +0000 (09:12 +0530)]
staging: rtl8188eu: Remove command _Set_H2C_MSG and its handler
_Set_H2C_MSG command is never issued by driver and its handler is a
dummy function.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:42:11 +0000 (09:12 +0530)]
staging: rtl8188eu: Remove command _LedBlink and its handler
_LedBlink command is never issued by driver and its handler is a
dummy function.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:42:10 +0000 (09:12 +0530)]
staging: rtl8188eu: Remove command _SetChannelSwitch and its handler
_SetChannelSwitch command is never issued by driver and its handler is a
dummy function.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:42:09 +0000 (09:12 +0530)]
staging: rtl8188eu: Remove command _TDLS and its handler
_TDLS command is never issued by driver and its handler is a
dummy function.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:42:08 +0000 (09:12 +0530)]
staging: rtl8188eu: rtw_cmd.h: Remove unused structures
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:42:07 +0000 (09:12 +0530)]
staging: rtl8188eu: rtw_[cmd, mlme_ext].h: Remove unused command codes
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:42:06 +0000 (09:12 +0530)]
staging: rtl8188eu: Remove function rtw_setdatarate_cmd()
rtw_setdatarate_cmd() enqueue _SetDataRate command but there is not
handler mapped in wlancmds[] to handle this command.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:42:05 +0000 (09:12 +0530)]
staging: rtl8188eu: Remove function rtw_getbbrfreg_cmdrsp_callback()
rtw_getbbrfreg_cmdrsp_callback() is a callback for _Read_BBREG and _Read_RFREG
commands but these commands are never issued by driver.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:42:04 +0000 (09:12 +0530)]
staging: rtl8188eu: Remove members cmd_[allocated,]_buf from struct cmd_priv
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:42:03 +0000 (09:12 +0530)]
staging: rtl8188eu: Remove unused members rsp_[allocated, ]_buf from struct cmd_priv
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:42:02 +0000 (09:12 +0530)]
staging: rtl8188eu: Remove unused member cmd_done_cnt from struct cmd_priv
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:42:01 +0000 (09:12 +0530)]
staging: rtl8188eu: Remove unused member cmd_issued_cnt from struct cmd_priv
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:42:00 +0000 (09:12 +0530)]
staging: rtl8188eu: Remove unused member rsp_cnt from struct cmd_priv
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:41:59 +0000 (09:11 +0530)]
staging: rtl8188eu: Rename _rtw_dequeue_cmd() to rtw_dequeue_cmd()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:41:58 +0000 (09:11 +0530)]
staging: rtl8188eu: Rename _rtw_free_cmd_priv() to rtw_free_cmd_priv()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:41:57 +0000 (09:11 +0530)]
staging: rtl8188eu: Rename _rtw_init_cmd_priv() to rtw_init_cmd_priv()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:41:56 +0000 (09:11 +0530)]
staging: rtl8188eu: Remove wrapper function power_saving_wk_hdl()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:41:55 +0000 (09:11 +0530)]
staging: rtl8188eu: Remove header file cmd_osdep.h
cmd_osdep.h is not required.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:41:54 +0000 (09:11 +0530)]
staging: rtl8188eu: rtw_cmd.h: Remove struct Tx_Beacon_param
struct Tx_Beacon_param has only one member.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:41:53 +0000 (09:11 +0530)]
staging: rtl8188eu: rtw_cmd.h: Remove struct [join, create]bss_parm
These two structures have only one member.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:41:52 +0000 (09:11 +0530)]
staging: rtl8188eu: Remove unused function rtw_cmd_clr_isr()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:41:51 +0000 (09:11 +0530)]
staging: rtl8188eu: rtw_cmd.h: Remove unused structures
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:41:50 +0000 (09:11 +0530)]
staging: rtl8188eu: rtw_cmd.h: Remove unused macros
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:41:49 +0000 (09:11 +0530)]
staging: rtl8188eu: rtw_cmd.h: Remove unused function declaration
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:41:48 +0000 (09:11 +0530)]
staging: rtl8188eu: Remove unused function rtw_createbss_cmd_ex()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:41:47 +0000 (09:11 +0530)]
staging: rtl8188eu: Remove unused function rtw_setstandby_cmd()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:41:46 +0000 (09:11 +0530)]
staging: rtl8188eu: Remove unused function rtw_setassocsta_cmd()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:41:45 +0000 (09:11 +0530)]
staging: rtl8188eu: Remove dummy function rtw_tdls_cmd()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:41:44 +0000 (09:11 +0530)]
staging: rtl8188eu: Remove unused function rtw_set_csa_cmd()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:41:43 +0000 (09:11 +0530)]
staging: rtl8188eu: Remove unused function rtw_set_ch_cmd()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:41:42 +0000 (09:11 +0530)]
staging: rtl8188eu: Remove unused function rtw_setrttbl_cmd()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:41:41 +0000 (09:11 +0530)]
staging: rtl8188eu: Remove unused function rtw_[set, get]rfreg_cmd()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:41:40 +0000 (09:11 +0530)]
staging: rtl8188eu: Remove unused function rtw_getbbreg_cmd()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:41:39 +0000 (09:11 +0530)]
staging: rtl8188eu: Remove unused function rtw_setbbreg_cmd()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:41:38 +0000 (09:11 +0530)]
staging: rtl8188eu: Remove unused function rtw_setphy_cmd()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:41:37 +0000 (09:11 +0530)]
staging: rtl8188eu: Remove unused function rtw_setbasicrate_cmd()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:41:36 +0000 (09:11 +0530)]
staging: rtl8188eu: Remove unused function rtw_c2h_wk_cmd()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:41:35 +0000 (09:11 +0530)]
staging: rtl8188eu: Remove unused function rtw_getrttbl_cmd()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:41:34 +0000 (09:11 +0530)]
staging: rtl8188eu: rtw_cmd.h: Remove unused macro and structure
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:41:33 +0000 (09:11 +0530)]
staging: rtl8188eu: Remove unused function rtw_hal_c2h_id_filter_ccx()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:41:32 +0000 (09:11 +0530)]
staging: rtl8188eu: Remove dummy function rtw_hal_c2h_handler()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:41:31 +0000 (09:11 +0530)]
staging: rtl8188eu: Remove unused function c2h_evt_clear()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:41:30 +0000 (09:11 +0530)]
staging: rtl8188eu: Remove unused function c2h_evt_read()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:41:29 +0000 (09:11 +0530)]
staging: rtl8188eu: Remove function c2h_evt_hdl()
c2h_evt_hdl() calls a dummy function rtw_hal_c2h_handler() to handle events,
so no use of keeping it.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:41:28 +0000 (09:11 +0530)]
staging: rtl8188eu: Remove struct evt_priv and its uses
c2h_wk (work_struct) is naver scheduled to handle events,
so no use of keeping event data.
And also function rtw_hal_c2h_handler() responsible for handling c2h events,
is a dummy function.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:41:27 +0000 (09:11 +0530)]
staging: rtl8188eu: Remove P2P support
We've already removed non-standard ioctl handlers used by driver
to support P2P mode.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:41:26 +0000 (09:11 +0530)]
staging: rtl8188eu: Remove mp( mesh point) mode support
We've already removed non-standard ioctl handlers, used by driver
to support mp mode.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:41:25 +0000 (09:11 +0530)]
staging: rtl8188eu: Remove usb_osintf.h header file.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:41:24 +0000 (09:11 +0530)]
staging: rtl8188eu: Remove files rtw_mp_ioctl.[c,h]
files are not required after removal of private ioctl handlers.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 10 Jul 2014 03:41:23 +0000 (09:11 +0530)]
staging: rtl8188eu: Remove WEXT_PRIV private ioctl handlers
Remove WEXT_PRIV (non-standard) ioctl handlers.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Andy Shevchenko [Thu, 10 Jul 2014 03:41:22 +0000 (09:11 +0530)]
staging: rtl8188eu: re-use hex_to_bin() instead of custom code
hex_to_bin could be used to convert hexdecimal digit to its binary
representation.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Andy Shevchenko [Thu, 10 Jul 2014 03:41:21 +0000 (09:11 +0530)]
staging: rtl8188eu: substitute custom hex2bin()
Instead of using custom code to convert hexdecinal strings to their binary
represantation let's use kernel's library function.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Andy Shevchenko [Thu, 10 Jul 2014 03:41:20 +0000 (09:11 +0530)]
staging: rtl8188eu: re-use mac_pton() helper
The helper mac_pton() validates and converts MAC address from string format to
a number. Originally code uses simple code to do that. With mac_pton() the
driver now validates input as well.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James A Shackleford [Wed, 9 Jul 2014 19:10:47 +0000 (15:10 -0400)]
staging: rtl8712: remove #define _workitem struct work_struct
_workitem is just a #define for work_struct. Remove the #define and
use struct work_struct directly instead.
Signed-off-by: James A Shackleford <shack@linux.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James A Shackleford [Wed, 9 Jul 2014 19:10:46 +0000 (15:10 -0400)]
staging: rtl8712: remove wrapper function _set_workitem()
The inline function _set_workitem() simply wraps schedule_work(). Removed.
Signed-off-by: James A Shackleford <shack@linux.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James A Shackleford [Wed, 9 Jul 2014 19:10:45 +0000 (15:10 -0400)]
staging: rtl8712: remove wrapper function _init_workitem()
The inline function _init_workitem() is just a wrapper around INIT_WORK().
Oddly, this wrapper accepts 3 parameters while INIT_WORK() only accepts 2.
The third parameter is unused.
Signed-off-by: James A Shackleford <shack@linux.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Joe Perches [Tue, 8 Jul 2014 00:08:25 +0000 (17:08 -0700)]
MAINTAINERS: update staging removals and movements
3 sections have been deleted by various commits. The other, echo, has
been moved to drivers/misc.
The nominal maintainers of the echo subsystem haven't been modifying the
code or acking/signing patches for several years, so don't keep the
section either.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Pawel Lebioda [Wed, 9 Jul 2014 15:59:29 +0000 (17:59 +0200)]
staging: bcm: add missing blank lines after declarations
Fix "Missing blank line after declaration" warnings reported by
checkpatch.pl.
Signed-off-by: Pawel Lebioda <pawel.lebioda89@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Eli Billauer [Sat, 5 Jul 2014 09:45:09 +0000 (12:45 +0300)]
staging: xillybus: Register's address offset notation update
In iowrite32() calls, the address of registers was expressed as e.g.
&ep->registers[fpga_msg_ctrl_reg]. This changes to the more common format
e.g. ep->registers + fpga_msg_ctrl_reg.
There is no functional change.
Signed-off-by: Eli Billauer <eli.billauer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Eli Billauer [Sat, 5 Jul 2014 09:45:08 +0000 (12:45 +0300)]
staging: xillybus: Reorganizing xilly_setupchannels()
Duplicate code in this function was moved into a new function,
xilly_get_dma_buffers().
There is no change in functionality.
Signed-off-by: Eli Billauer <eli.billauer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Eli Billauer [Sat, 5 Jul 2014 09:45:07 +0000 (12:45 +0300)]
staging: xillybus: Add sanity check in interrupt handler
Data arriving from the hardware is verified prior to its use. The lack of
this check has never been reported to cause a problem, but it's necessary
nevertheless.
Signed-off-by: Eli Billauer <eli.billauer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tobias Klauser [Tue, 8 Jul 2014 07:11:56 +0000 (09:11 +0200)]
staging: et131x: Use net_device_stats from struct net_device
Instead of using an own copy of struct net_device_stats in struct
et131x_adapter, use stats from struct net_device.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dan Carpenter [Tue, 8 Jul 2014 10:54:23 +0000 (13:54 +0300)]
staging: rtl8188eu: use GFP_ATOMIC under spinlock
We're holding a spinlock here so we can't do sleeping allocations.
The call tree is:
rtw_sta_flush() <-- takes spin_lock_bh(&pstapriv->asoc_list_lock);
--> ap_free_sta()
--> rtw_clearstakey_cmd()
Originally these calls were rtw_zmalloc() and then we switched them to
kzalloc() in
fadbe0cd5292 ('staging: rtl8188eu:Remove rtw_zmalloc(),
wrapper for kzalloc()') and that made the bugs show up for my static
checker. The original code was buggy as well but my static checker
couldn't parse it.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anton Protopopov [Wed, 9 Jul 2014 05:12:37 +0000 (09:12 +0400)]
Staging: comedi: check the return value of kobject_set_name
Added a check of the return value of the kobject_set_name function.
Signed-off-by: Anton Protopopov <a.s.protopopov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Andrey Utkin [Tue, 8 Jul 2014 14:02:42 +0000 (17:02 +0300)]
staging: ft1000-usb: check for errors in card_send_command
kmalloc() result check was lacking. Fixing that required also
changing card_send_command() return type from void to int, and
checking its return code everywhere.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=78561
Reported-by: Maksymilian Arciemowicz <max@cert.cx>
Signed-off-by: Andrey Utkin <andrey.krieger.utkin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Fri, 4 Jul 2014 17:19:57 +0000 (22:49 +0530)]
staging: goldfish: Introduce the use of managed interfaces
This patch introduces the use of managed interfaces like devm_kzalloc,
devm_ioremap, dmam_alloc_coherent, devm_request_irq and does away with
the calls to functions to free the allocated memory in the probe and
remove functions. Also, the labels are removed in the probe function.
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Pawel Lebioda [Sat, 5 Jul 2014 20:30:56 +0000 (22:30 +0200)]
staging: nvec: remove unneccessary 'out of memory' message
Fix the following warning reported by checkpatch.pl:
WARNING: Possible unnecessary 'out of memory' message
811: FILE: drivers/staging/nvec/nvec.c:811
Signed-off-by: Pawel Lebioda <pawel.lebioda89@gmail.com>
Acked-by: Marc Dietrich <marvin24@gmx.de>
Reviewed-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Pawel Lebioda [Sat, 5 Jul 2014 20:30:55 +0000 (22:30 +0200)]
staging: nvec: remove unnecessary 'else' after 'return' statement
Fix the following warning reported by checkpatch.pl:
WARNING: else is not generally useful after a break or return
235: FILE: drivers/staging/nvec/nvec.c:235
Signed-off-by: Pawel Lebioda <pawel.lebioda89@gmail.com>
Acked-by: Marc Dietrich <marvin24@gmx.de>
Reviewed-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Pawel Lebioda [Thu, 3 Jul 2014 19:15:57 +0000 (21:15 +0200)]
staging: nvec: insert blank lines after declarations
This patch fixes coding style warnings reported by checkpatch.pl:
"Missing a blank line after declarations".
Signed-off-by: Pawel Lebioda <pawel.lebioda89@gmail.com>
Acked-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Thu, 3 Jul 2014 10:13:39 +0000 (19:13 +0900)]
staging: dgnc: remove redundant memset call
The brd is allocated by kzalloc() in dgnc_found_board()
so do not need to set 0 to member variable.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Thu, 3 Jul 2014 10:13:06 +0000 (19:13 +0900)]
staging: dgnc: removes unreachable code
dgnc_tty_ioctl() cannot reach the end of function.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Thu, 3 Jul 2014 10:12:31 +0000 (19:12 +0900)]
staging: dgnc: Fix unsigned value for less than zero
The "un->un_open_count" is unsigned variable, so it cannot
be less than zero.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Thu, 3 Jul 2014 10:12:01 +0000 (19:12 +0900)]
staging: dgnc: remove redundant null check for kfree()
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Wed, 9 Jul 2014 07:29:58 +0000 (16:29 +0900)]
staging: dgap: remove redundant NULL check in dgap_tty_init()
The brd is already checked by earlier function in dgap_init_one().
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Wed, 9 Jul 2014 07:29:33 +0000 (16:29 +0900)]
staging: dgap: use kzalloc instead of kmalloc/memset
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Fri, 4 Jul 2014 10:29:55 +0000 (19:29 +0900)]
staging: dgap: remove unused waitqueues
dgap_dl_wait and kme_wait are not used in dgap.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Fri, 4 Jul 2014 10:29:11 +0000 (19:29 +0900)]
staging: dgap: remove unneccessary dgap_init_pci() function
The dgap_init_pci() calls only pci_register_driver().
It doesn't need to make a function for that.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Wed, 2 Jul 2014 07:07:16 +0000 (16:07 +0900)]
staging: dgap: Adds a blank line after declaration
clean up checkpatch.pl warning:
WARNING: Missing a blank line after declarations
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Wed, 2 Jul 2014 07:06:37 +0000 (16:06 +0900)]
staging: dgap: remove "return" statement in void function
clean up checkpatch warning:
WARNING: void function return statements are not generally useful
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Wed, 2 Jul 2014 07:06:04 +0000 (16:06 +0900)]
staging: dgap: fixed "foo* bar should be foo * bar" in dgap.c
clean up checkpatch.pl error:
ERROR: "foo* bar" should be "foo *bar"
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matt Kurz [Tue, 1 Jul 2014 19:59:54 +0000 (05:59 +1000)]
staging: wlan-ng/prism2fw.c: Add blank line after declarations
Fix checkpatch.pl warnings due to missing blank line after declarations
Signed-off-by: Matt Kurz <matt@ninezulu.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tobias Klauser [Tue, 8 Jul 2014 06:37:00 +0000 (08:37 +0200)]
staging: wlan-ng: Use net_device_stats from struct net_device
Instead of using an own copy of struct net_device_stats in struct
wlandevice, use stats from struct net_device. Also remove the thus
unnecessary .ndo_get_stats function, as it would now just return
netdev->stats, which is the default in dev_get_stats().
Furthermore, convert prefix increment of stats counters to the more
common postfix increment idiom.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tobias Klauser [Tue, 8 Jul 2014 08:00:56 +0000 (10:00 +0200)]
staging: gdm72xx: Remove unnecessary memset of netdev private data
The memory for struct net_device private data is allocated using
kzalloc/vzalloc in alloc_netdev_mqs, thus there is no need to zero it
again in the driver.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tobias Klauser [Tue, 8 Jul 2014 06:47:47 +0000 (08:47 +0200)]
staging: gdm72xx: Use net_device_stats from struct net_device
Instead of using an own copy of struct net_device_stats in struct nic,
use stats from struct net_device. Also remove the thus unnecessary
.ndo_get_stats function, as it would now just return netdev->stats,
which is the default in dev_get_stats().
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ben Chan [Wed, 2 Jul 2014 08:26:48 +0000 (01:26 -0700)]
staging: gdm72xx: add help text to Kconfig
The descriptions are provided by GCT Semiconductor, Inc.
Signed-off-by: Ben Chan <benchan@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
projects / firefly-linux-kernel-4.4.55.git / log