Karthik Bhat [Thu, 27 Mar 2014 12:08:23 +0000 (12:08 +0000)]
All new elements except the last one initialized to NULL. Ideally, once parsing is complete, all elements should be non-NULL.
To safe-guard BitcodeReader, this patch adds null check for all access to these list.
Patch by Dinesh Dwivedi!
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204920
91177308-0d34-0410-b5e6-
96231b3b80d8
Matheus Almeida [Thu, 27 Mar 2014 12:02:48 +0000 (12:02 +0000)]
[mips] Remove unused private field.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204919
91177308-0d34-0410-b5e6-
96231b3b80d8
Matheus Almeida [Thu, 27 Mar 2014 11:52:20 +0000 (11:52 +0000)]
[mips] NaCl should now use the custom MipsELFStreamer (recently added) in spite
of MCELFStreamer.
This is so that changes to MipsELFStreamer will automatically propagate through
its subclasses.
No functional changes (MipsELFStreamer has the same functionality of MCELFStreamer
at the moment).
Differential Revision: http://llvm-reviews.chandlerc.com/D3130
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204918
91177308-0d34-0410-b5e6-
96231b3b80d8
Matheus Almeida [Thu, 27 Mar 2014 11:39:03 +0000 (11:39 +0000)]
[mips] Implement custom MCELFStreamer.
This allows us to insert some hooks before emitting data into an actual object file.
For example, we can capture the register usage for a translation unit by overriding
the EmitInstruction method. The register usage information is needed to generate
.reginfo and .Mips.options ELF sections.
No functional changes.
Differential Revision: http://llvm-reviews.chandlerc.com/D3129
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204917
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Thu, 27 Mar 2014 11:38:28 +0000 (11:38 +0000)]
Untabify.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204916
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Thu, 27 Mar 2014 11:33:11 +0000 (11:33 +0000)]
SmallVector<3> may be used here.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204915
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Thu, 27 Mar 2014 11:32:41 +0000 (11:32 +0000)]
IRTests/InstructionsTest.cpp: Avoid initializer list.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204914
91177308-0d34-0410-b5e6-
96231b3b80d8
Erik Verbruggen [Thu, 27 Mar 2014 11:16:05 +0000 (11:16 +0000)]
InstCombine: merge constants in both operands of icmp.
Transform:
icmp X+Cst2, Cst
into:
icmp X, Cst-Cst2
when Cst-Cst2 does not overflow, and the add has nsw.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204912
91177308-0d34-0410-b5e6-
96231b3b80d8
Daniel Sanders [Thu, 27 Mar 2014 10:46:12 +0000 (10:46 +0000)]
[mips] Stop caching the result of hasMips64(), isABI_O32(), isABI_N32(), and isABI_N64() from MipsSubTarget in MipsTargetLowering
Summary:
The short name is quite convenient so provide an accessor for them instead.
No functional change
Depends on D3177
Reviewers: matheusalmeida
Reviewed By: matheusalmeida
Differential Revision: http://llvm-reviews.chandlerc.com/D3178
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204911
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Thu, 27 Mar 2014 09:56:23 +0000 (09:56 +0000)]
[cleanup] Run clang-format over these routines to remove formatting
differences from subsequent diffs, and ease review. Going to be
performing some major surgery to simplify this stuff.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204908
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Thu, 27 Mar 2014 09:53:31 +0000 (09:53 +0000)]
[cleanup] Modernize doxygen comments for the BumpPtrAllocator and
rewrite some of them to be more clear.
The terminology being used in our allocators is making me really sad. We
call things slab allocators that aren't at all slab allocators. It is
quite confusing.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204907
91177308-0d34-0410-b5e6-
96231b3b80d8
Elena Demikhovsky [Thu, 27 Mar 2014 09:45:08 +0000 (09:45 +0000)]
AVX-512: Implemented masking for integer arithmetic & logic instructions.
By Robert Khasanov rob.khasanov@gmail.com
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204906
91177308-0d34-0410-b5e6-
96231b3b80d8
Timur Iskhodzhanov [Thu, 27 Mar 2014 08:52:14 +0000 (08:52 +0000)]
Add a PR reference
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204904
91177308-0d34-0410-b5e6-
96231b3b80d8
Timur Iskhodzhanov [Thu, 27 Mar 2014 08:46:44 +0000 (08:46 +0000)]
Make the recent COFF debug info tests more readable
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204902
91177308-0d34-0410-b5e6-
96231b3b80d8
Stepan Dyatkovskiy [Thu, 27 Mar 2014 08:38:18 +0000 (08:38 +0000)]
Rejected r204899 and r204900 due to remaining test failures on cmake-llvm-x86_64-linux buildbot.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204901
91177308-0d34-0410-b5e6-
96231b3b80d8
Stepan Dyatkovskiy [Thu, 27 Mar 2014 08:20:26 +0000 (08:20 +0000)]
Fixed test for r204899 (pr18931 fix)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204900
91177308-0d34-0410-b5e6-
96231b3b80d8
Stepan Dyatkovskiy [Thu, 27 Mar 2014 07:49:39 +0000 (07:49 +0000)]
Fix for pr18931: Crash using integrated assembler with immediate arithmetic
Fix description:
Expressions like 'cmp r0, #(l1 - l2) >> 3' could not be evaluated on asm parsing stage,
since it is impossible to resolve labels on this stage. In the end of stage we still have
expression (MCExpr).
Then, when we want to encode it, we expect it to be an immediate, but it still an expression.
Patch introduces a Fixup (MCFixup instance), that is processed after main encoding stage.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204899
91177308-0d34-0410-b5e6-
96231b3b80d8
Jiangning Liu [Thu, 27 Mar 2014 07:42:58 +0000 (07:42 +0000)]
ARM: raise error message when complex SO expressions can't really be
solved as a constant at compilation time.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204898
91177308-0d34-0410-b5e6-
96231b3b80d8
Lang Hames [Thu, 27 Mar 2014 02:58:32 +0000 (02:58 +0000)]
Add missing #include <cassert> to MCSymbolizer.h.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204894
91177308-0d34-0410-b5e6-
96231b3b80d8
Lang Hames [Thu, 27 Mar 2014 02:49:18 +0000 (02:49 +0000)]
Assert that MCSymbolizer is constructed with a valid (or at least non-null)
RelocationInfo argument.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204893
91177308-0d34-0410-b5e6-
96231b3b80d8
Lang Hames [Thu, 27 Mar 2014 02:42:52 +0000 (02:42 +0000)]
Move MCSymbolizer's constructor into header. It's trivial - there's no need for
it to be out-of-line.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204892
91177308-0d34-0410-b5e6-
96231b3b80d8
Lang Hames [Thu, 27 Mar 2014 02:39:01 +0000 (02:39 +0000)]
Update MCSymbolizer and its subclasses' constructors to reflect the fact that
they take ownership of the RelocationInfo they're constructed with.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204891
91177308-0d34-0410-b5e6-
96231b3b80d8
Reid Kleckner [Thu, 27 Mar 2014 01:38:48 +0000 (01:38 +0000)]
inalloca: *Really* fix the docs
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204890
91177308-0d34-0410-b5e6-
96231b3b80d8
Reid Kleckner [Thu, 27 Mar 2014 01:34:51 +0000 (01:34 +0000)]
Remove unneeded stale type.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204889
91177308-0d34-0410-b5e6-
96231b3b80d8
Reid Kleckner [Thu, 27 Mar 2014 01:32:22 +0000 (01:32 +0000)]
inalloca: Fix incorrect example IR and remove LangRef warning
The LangRef warning wasn't formatting the way I intended it to anyway.
Surprisingly inalloca appears to work, even when optimizations are
enabled. We generate very bad code for it, but we can self-host and run
lots of big tests.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204888
91177308-0d34-0410-b5e6-
96231b3b80d8
Lang Hames [Thu, 27 Mar 2014 01:05:49 +0000 (01:05 +0000)]
Remove forward declaration for Target class - Target is already defined here.
No functional change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204885
91177308-0d34-0410-b5e6-
96231b3b80d8
Quentin Colombet [Thu, 27 Mar 2014 00:52:16 +0000 (00:52 +0000)]
[X86][Vectorizer Cost Model] Correct vectorization cost model for v2i64->v2f64
and v4i64->v4f64.
The new costs match what we did for SSE2 and reflect the reality of our codegen.
<rdar://problem/
16381225>
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204884
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Thu, 27 Mar 2014 00:28:24 +0000 (00:28 +0000)]
Correctly propagates st_size.
This also finally removes a bogus call to AliasedSymbol.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204883
91177308-0d34-0410-b5e6-
96231b3b80d8
Jim Grosbach [Thu, 27 Mar 2014 00:20:42 +0000 (00:20 +0000)]
add 'requires asserts' to test that needs it
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204882
91177308-0d34-0410-b5e6-
96231b3b80d8
Justin Bogner [Thu, 27 Mar 2014 00:06:36 +0000 (00:06 +0000)]
llvm-cov: When reading strings in gcov data, skip leading zeros
It seems that gcov, when faced with a string that is apparently zero
length, just keeps reading words until it finds a length it likes
better. I'm not really sure why this is, but it's simple enough to
make llvm-cov follow suit.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204881
91177308-0d34-0410-b5e6-
96231b3b80d8
Jim Grosbach [Thu, 27 Mar 2014 00:04:11 +0000 (00:04 +0000)]
X86: Correct vectorization cost model for v8f32->v8i8.
Fix the cost model to reflect the reality of our codegen.
rdar://
16370633
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204880
91177308-0d34-0410-b5e6-
96231b3b80d8
Nick Lewycky [Wed, 26 Mar 2014 23:45:15 +0000 (23:45 +0000)]
Treat lifetime.start'd memory like we treat freshly alloca'd memory. Patch by Björn Steinbrink!
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204876
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Wed, 26 Mar 2014 23:10:28 +0000 (23:10 +0000)]
Reorder arguments on test command line to make it easier to cut and
paste.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204875
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Wed, 26 Mar 2014 22:58:37 +0000 (22:58 +0000)]
[PowerPC] Generate VSX permutations for v2[fi]64 vectors
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204873
91177308-0d34-0410-b5e6-
96231b3b80d8
Justin Bogner [Wed, 26 Mar 2014 22:51:39 +0000 (22:51 +0000)]
llvm-cov: Move XFAIL after the body of the test
llvm-cov tests are sensitive to line number changes, so putting this
at the end will limit churn when we fix the XFAIL.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204871
91177308-0d34-0410-b5e6-
96231b3b80d8
Justin Bogner [Wed, 26 Mar 2014 22:36:48 +0000 (22:36 +0000)]
llvm-cov: Disable test on big endian machines
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204868
91177308-0d34-0410-b5e6-
96231b3b80d8
Reid Kleckner [Wed, 26 Mar 2014 22:26:35 +0000 (22:26 +0000)]
CloneFunction: Clone all attributes, including the CC
Summary:
Tested with a unit test because we don't appear to have any transforms
that use this other than ASan, I think.
Fixes PR17935.
Reviewers: nicholas
CC: llvm-commits
Differential Revision: http://llvm-reviews.chandlerc.com/D3194
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204866
91177308-0d34-0410-b5e6-
96231b3b80d8
Ekaterina Romanova [Wed, 26 Mar 2014 22:15:28 +0000 (22:15 +0000)]
This is a fix for PR# 19051. I noticed code gen differences due to code motion when running tests with and without the debug info at O2. The problem is in branch folding. A loop wanted to skip the debug info, but actually it didn't do so.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204865
91177308-0d34-0410-b5e6-
96231b3b80d8
Manman Ren [Wed, 26 Mar 2014 22:14:09 +0000 (22:14 +0000)]
Add comments. Addressing review comments from Evan on r204690.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204864
91177308-0d34-0410-b5e6-
96231b3b80d8
Justin Bogner [Wed, 26 Mar 2014 22:03:06 +0000 (22:03 +0000)]
llvm-cov: Handle functions with no line number
Functions may in an instrumented binary but not in the original source
when they're inserted by the compiler or the runtime. These functions
aren't meaningful to the user, so teach llvm-cov to skip over them
instead of crashing.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204863
91177308-0d34-0410-b5e6-
96231b3b80d8
Kevin Enderby [Wed, 26 Mar 2014 21:54:11 +0000 (21:54 +0000)]
Fix a problem with the ARM assembler incorrectly matching a
vector list parameter that is using all lanes "{d0[], d2[]}" but can
match and instruction with a ”{d0, d2}" parameter.
I’m finishing up a fix for proper checking of the unsupported
alignments on vld/vst instructions and ran into this. Thus I don’t
have a test case at this time. And adding all code that will
demonstrate the bug would obscure the very simple one line fix.
So if you would indulge me on not having a test case at this
time I’ll instead offer up a detailed explanation of what is
going on in this commit message.
This instruction:
vld2.8 {d0[], d2[]}, [r4:64]
is not legal as the alignment can only be 16 when the size is 8.
Per this documentation:
A8.8.325 VLD2 (single 2-element structure to all lanes)
<align> The alignment. It can be one of:
16 2-byte alignment, available only if <size> is 8, encoded as a = 1.
32 4-byte alignment, available only if <size> is 16, encoded as a = 1.
64 8-byte alignment, available only if <size> is 32, encoded as a = 1.
omitted Standard alignment, see Unaligned data access on page A3-108.
So when code is added to the llvm integrated assembler to not match
that instruction because of the alignment it then goes on to try to match
other instructions and comes across this:
vld2.8 {d0, d2}, [r4:64]
and and matches it. This is because of the method
ARMOperand::isVecListDPairSpaced() is missing the check of the Kind.
In this case the Kind is k_VectorListAllLanes . While the name of the method
may suggest that this is OK it really should check that the Kind is
k_VectorList.
As the method ARMOperand::isDoubleSpacedVectorAllLanes() is what was
used to match {d0[], d2[]} and correctly checks the Kind:
bool isDoubleSpacedVectorAllLanes() const {
return Kind == k_VectorListAllLanes && VectorList.isDoubleSpaced;
}
where the original ARMOperand::isVecListDPairSpaced() does not check
the Kind:
bool isVecListDPairSpaced() const {
if (isSingleSpacedVectorList()) return false;
return (ARMMCRegisterClasses[ARM::DPairSpcRegClassID]
.contains(VectorList.RegNum));
}
Jim Grosbach has reviewed the change and said: Yep, that sounds right. …
And by "right" I mean, "wow, that's a nasty latent bug I'm really, really
glad to see fixed." :)
rdar://
16436683
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204861
91177308-0d34-0410-b5e6-
96231b3b80d8
Eli Bendersky [Wed, 26 Mar 2014 21:46:24 +0000 (21:46 +0000)]
Add a unit test for Invoke iteration, similar to the one for Call
The tests are refactored to use the same fixture.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204860
91177308-0d34-0410-b5e6-
96231b3b80d8
Arnold Schwaighofer [Wed, 26 Mar 2014 21:30:19 +0000 (21:30 +0000)]
PR15967 Fix in basicaa for faulty returning no alias.
This commit consist of two parts.
The first part fix the PR15967. The wrong conclusion was made when the MaxLookup
limit was reached. The fix introduce a out parameter (MaxLookupReached) to
DecomposeGEPExpression that the function aliasGEP can act upon.
The second part is introducing the constant MaxLookupSearchDepth to make sure
that DecomposeGEPExpression and GetUnderlyingObject use the same search depth.
This is a small cleanup to clarify the original algorithm.
Patch by Karl-Johan Karlsson!
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204859
91177308-0d34-0410-b5e6-
96231b3b80d8
Lang Hames [Wed, 26 Mar 2014 21:21:53 +0000 (21:21 +0000)]
Simplify PBQP graph removeAdjEdgeId implementation.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204857
91177308-0d34-0410-b5e6-
96231b3b80d8
Eli Bendersky [Wed, 26 Mar 2014 21:11:34 +0000 (21:11 +0000)]
Fix bot breakage in InstructionsTest.
Makes sure the Call dies before the Function
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204856
91177308-0d34-0410-b5e6-
96231b3b80d8
Eli Bendersky [Wed, 26 Mar 2014 20:41:15 +0000 (20:41 +0000)]
Fix problem with r204836
In CallInst, op_end() points at the callee, which we don't want to iterate over
when just iterating over arguments. Now take this into account when returning
a iterator_range from arg_operands. Similar reasoning for InvokeInst.
Also adds a unit test to verify this actually works as expected.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204851
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Wed, 26 Mar 2014 19:39:09 +0000 (19:39 +0000)]
[PowerPC] VSX loads and stores support unaligned access
I've not yet updated PPCTTI because I'm not sure what the actual relative cost
is compared to the aligned uses.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204848
91177308-0d34-0410-b5e6-
96231b3b80d8
Kevin Enderby [Wed, 26 Mar 2014 19:35:40 +0000 (19:35 +0000)]
Fix the ARM VST4 (single 4-element structure from one lane)
size 16 double-spaced registers instruction printing.
This:
vld4.16 {d17[1], d19[1], d21[1], d23[1]}, [r7]!
was being printed as:
vld4.16 {d17[1], d18[1], d19[1], d20[1]}, [r7]!
rdar://
16435096
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204847
91177308-0d34-0410-b5e6-
96231b3b80d8
Lang Hames [Wed, 26 Mar 2014 19:22:51 +0000 (19:22 +0000)]
Remove PBQP-cost dimension sanity assertion in PBQP::Graph::addConstructedEdge.
We're already effectively checking sanity for that in PBQP::Graph::addEdge.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204844
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Wed, 26 Mar 2014 19:13:54 +0000 (19:13 +0000)]
[PowerPC] Use v2f64 <-> v2i64 VSX conversion instructions
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204843
91177308-0d34-0410-b5e6-
96231b3b80d8
Lang Hames [Wed, 26 Mar 2014 18:58:00 +0000 (18:58 +0000)]
Change the PBQP graph adjacency list structure from std::set to std::vector.
The edge data structure (EdgeEntry) now holds the indices of its entries in the
adjacency lists of the nodes it connects. This trades a little ugliness for
faster insertion/removal, which is now O(1) with a cheap constant factor. All
of this is implementation detail within the PBQP graph, the external API remains
unchanged.
Individual register allocations are likely to change, since the adjacency lists
will now be ordered differently (or rather, will now be unordered). This
shouldn't affect the average quality of allocations however.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204841
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Wed, 26 Mar 2014 18:31:06 +0000 (18:31 +0000)]
R600: Add a testcase for sext_in_reg I missed.
This sext_inreg i32 in i64 case was already handled, but not enabled.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204840
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Wed, 26 Mar 2014 18:26:36 +0000 (18:26 +0000)]
[PowerPC] Remove some dead VSX v4f32 store patterns
These patterns are dead (because v4f32 stores are currently promoted to v4i32
and stored using Altivec instructions), and also are likely not correct
(because they'd store the vector elements in the opposite order from that
assumed by the rest of the Altivec code).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204839
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Wed, 26 Mar 2014 18:26:30 +0000 (18:26 +0000)]
[PowerPC] Use VSX vector load/stores for v2[fi]64
These instructions have access to the complete VSX register file. In addition,
they "swap" the order of the elements so that element 0 (the scalar part) comes
first in memory and element 1 follows at a higher address.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204838
91177308-0d34-0410-b5e6-
96231b3b80d8
Juergen Ributzka [Wed, 26 Mar 2014 18:19:27 +0000 (18:19 +0000)]
[MCJIT] Check if there have been errors during RuntimeDyld execution.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204837
91177308-0d34-0410-b5e6-
96231b3b80d8
Eli Bendersky [Wed, 26 Mar 2014 18:18:02 +0000 (18:18 +0000)]
Enable range-for iteration over call/invoke arguments.
Similar to r204835
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204836
91177308-0d34-0410-b5e6-
96231b3b80d8
Eli Bendersky [Wed, 26 Mar 2014 18:04:27 +0000 (18:04 +0000)]
Add args() iteartor adapter to Function, for range-for loops.
This patch is in similar vein to what done earlier to Module::globals/aliases
etc. It allows to iterate over function arguments like this:
for (Argument Arg : F.args()) {
...
}
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204835
91177308-0d34-0410-b5e6-
96231b3b80d8
Jim Grosbach [Wed, 26 Mar 2014 17:27:01 +0000 (17:27 +0000)]
Fix for incorrect address sinking in the presence of potential overflows.
In some cases it is possible for CGP to attempt to reuse a base address from
another basic block. In those cases we have to be sure that all the address
math was either done at the same bit width, or that none of it overflowed
before it was extended.
Patch by Louis Gerbarg <lgg@apple.com>
rdar://
16307442
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204833
91177308-0d34-0410-b5e6-
96231b3b80d8
Hans Wennborg [Wed, 26 Mar 2014 16:30:54 +0000 (16:30 +0000)]
Revert "X86 memcpy lowering: use "rep movs" even when esi is used as base pointer" (r204174)
> For functions where esi is used as base pointer, we would previously fall ba
> from lowering memcpy with "rep movs" because that clobbers esi.
>
> With this patch, we just store esi in another physical register, and restore
> it afterwards. This adds a little bit of register preassure, but the more
> efficient memcpy should be worth it.
>
> Differential Revision: http://llvm-reviews.chandlerc.com/D2968
This didn't work. I was ending up with code like this:
lea edi,[esi+38h]
mov ecx,0Fh
mov edx,esi
mov esi,ebx
rep movs dword ptr es:[edi],dword ptr [esi]
lea ecx,[esi+74h] <-- Ooops, we're now using esi before restoring it from edx.
add ebx,3Ch
mov esi,edx
I guess if we want to do this we need stronger glue or something, or doing the expansion
much later.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204829
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Wed, 26 Mar 2014 16:12:58 +0000 (16:12 +0000)]
[PowerPC] Add v2i64 as a legal VSX type
v2i64 needs to be a legal VSX type because it is the SetCC result type from
v2f64 comparisons. We need to expand all non-arithmetic v2i64 operations.
This fixes the lowering for v2f64 VSELECT.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204828
91177308-0d34-0410-b5e6-
96231b3b80d8
Matheus Almeida [Wed, 26 Mar 2014 16:09:43 +0000 (16:09 +0000)]
[mips] Use TwoOperandAliasConstraint for ArithLogicR instructions.
This enables TableGen to generate an additional two operand matcher
for our ArithLogicR class of instructions (constituted by 3 register operands).
E.g.: and $1, $2 <=> and $1, $1, $2
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204826
91177308-0d34-0410-b5e6-
96231b3b80d8
Matheus Almeida [Wed, 26 Mar 2014 15:44:18 +0000 (15:44 +0000)]
[mips] Add support to the '.dword' directive.
The '.dword' directive accepts a list of expressions and emits
them in 8-byte chunks in successive locations.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204822
91177308-0d34-0410-b5e6-
96231b3b80d8
Joerg Sonnenberger [Wed, 26 Mar 2014 15:30:21 +0000 (15:30 +0000)]
Clarify that select is only non-branching on the IR-level, it often ends
up as jump table or other forms of branches on the machine level.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204819
91177308-0d34-0410-b5e6-
96231b3b80d8
Matheus Almeida [Wed, 26 Mar 2014 15:24:36 +0000 (15:24 +0000)]
[mips] Rename function in MipsAsmParser.
parseDirectiveWord is a generic function that parses an expression which
means there's no need for it to have such an specific name. Renaming it to
parseDataDirective so that it can also be used to handle .dword directives[1].
[1]To be added in a follow up commit.
No functional changes.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204818
91177308-0d34-0410-b5e6-
96231b3b80d8
Matheus Almeida [Wed, 26 Mar 2014 15:14:32 +0000 (15:14 +0000)]
[mips] Add support to '.set mips64'.
The '.set mips64' directive enables the feature Mips:FeatureMips64
from assembly. Note that it doesn't modify the ELF header as opposed
to the use of -mips64 from the command-line. The reason for this
is that we want to be as compatible as possible with existing assemblers
like GAS.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204817
91177308-0d34-0410-b5e6-
96231b3b80d8
Christian Pirker [Wed, 26 Mar 2014 14:57:32 +0000 (14:57 +0000)]
AArch64_BE Elf support for MC-JIT runtime dynamic linker
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204816
91177308-0d34-0410-b5e6-
96231b3b80d8
Matheus Almeida [Wed, 26 Mar 2014 14:52:22 +0000 (14:52 +0000)]
[mips] Add support to '.set mips64r2'.
The '.set mips64r2' directive enables the feature Mips:FeatureMips64r2
from assembly. Note that it doesn't modify the ELF header as opposed
to the use of -mips64r2 from the command-line. The reason for this
is that we want to be as compatible as possible with existing assemblers
like GAS.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204815
91177308-0d34-0410-b5e6-
96231b3b80d8
Christian Pirker [Wed, 26 Mar 2014 14:51:22 +0000 (14:51 +0000)]
AArch64_BE function argument passing for ARM ABI
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204814
91177308-0d34-0410-b5e6-
96231b3b80d8
Tim Northover [Wed, 26 Mar 2014 14:39:31 +0000 (14:39 +0000)]
ARM: add intrinsics for the v8 ldaex/stlex
We've already got versions without the barriers, so this just adds IR-level
support for generating the new v8 ones.
rdar://problem/
16227836
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204813
91177308-0d34-0410-b5e6-
96231b3b80d8
Joerg Sonnenberger [Wed, 26 Mar 2014 14:35:21 +0000 (14:35 +0000)]
Clarify llvm.clear_cache description.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204812
91177308-0d34-0410-b5e6-
96231b3b80d8
Matheus Almeida [Wed, 26 Mar 2014 14:26:27 +0000 (14:26 +0000)]
[mips] Hoist common functionality into a new function.
Given that we support multiple directives that enable a particular feature
(e.g. '.set mips16'), it's best to hoist that code into a new function
so that we don't repeat the same pattern w.r.t parsing and handling error cases.
No functional changes.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204811
91177308-0d34-0410-b5e6-
96231b3b80d8
Renato Golin [Wed, 26 Mar 2014 14:01:32 +0000 (14:01 +0000)]
Change @llvm.clear_cache default to call rt-lib
After some discussion on IRC, emitting a call to the library function seems
like a better default, since it will move from a compiler internal error to
a linker error, that the user can work around until LLVM is fixed.
I'm also adding a note on the responsibility of the user to confirm that
the cache was cleared on platforms where nothing is done.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204806
91177308-0d34-0410-b5e6-
96231b3b80d8
Daniel Sanders [Wed, 26 Mar 2014 13:59:42 +0000 (13:59 +0000)]
[mips] The decision to use MO_GOT_PAGE and MO_GOT_OFST depends on the ABI being N32 or N64 not the arch being MIPS64
Summary: No functional change (in supported use cases)
Reviewers: matheusalmeida
Reviewed By: matheusalmeida
Differential Revision: http://llvm-reviews.chandlerc.com/D3177
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204805
91177308-0d34-0410-b5e6-
96231b3b80d8
Cameron McInally [Wed, 26 Mar 2014 13:50:50 +0000 (13:50 +0000)]
Fix AVX512 Gather and Scatter execution domains.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204804
91177308-0d34-0410-b5e6-
96231b3b80d8
Matheus Almeida [Wed, 26 Mar 2014 13:40:29 +0000 (13:40 +0000)]
[mips] Add support for '.option pic2'.
The directive '.option pic2' enables PIC from assembly source.
At the moment none of the macros/directives check the PIC bit
but that's going to be fixed relatively soon. For example, the
expansion of macros like 'la' depend on the relocation model.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204803
91177308-0d34-0410-b5e6-
96231b3b80d8
Renato Golin [Wed, 26 Mar 2014 12:52:28 +0000 (12:52 +0000)]
Add @llvm.clear_cache builtin
Implementing the LLVM part of the call to __builtin___clear_cache
which translates into an intrinsic @llvm.clear_cache and is lowered
by each target, either to a call to __clear_cache or nothing at all
incase the caches are unified.
Updating LangRef and adding some tests for the implemented architectures.
Other archs will have to implement the method in case this builtin
has to be compiled for it, since the default behaviour is to bail
unimplemented.
A Clang patch is required for the builtin to be lowered into the
llvm intrinsic. This will be done next.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204802
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Wed, 26 Mar 2014 12:49:28 +0000 (12:49 +0000)]
[PowerPC] Lower VSELECT using xxsel when VSX is available
With VSX there is a real vector select instruction, and so we should use it.
Note that VSELECT will still scalarize for v2f64 because the corresponding
SetCC result type (v2i64) is not currently a legal type.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204801
91177308-0d34-0410-b5e6-
96231b3b80d8
Daniel Sanders [Wed, 26 Mar 2014 11:46:34 +0000 (11:46 +0000)]
[mips] Add tests for t0-t3 for N32/N64
These are aliases of t4-t7 and are provided for compatibility with both the
original ABI documentation (using t4-t7) and GNU As (using t0-t3)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204797
91177308-0d34-0410-b5e6-
96231b3b80d8
Daniel Sanders [Wed, 26 Mar 2014 11:39:07 +0000 (11:39 +0000)]
[mips] The register names depend on the ABI being N32/N64 rather than the arch being mips64
Summary: Added test cases for O32 and N32 on MIPS64.
Reviewers: matheusalmeida
Reviewed By: matheusalmeida
Differential Revision: http://llvm-reviews.chandlerc.com/D3175
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204796
91177308-0d34-0410-b5e6-
96231b3b80d8
Timur Iskhodzhanov [Wed, 26 Mar 2014 11:24:36 +0000 (11:24 +0000)]
Follow-up to r204790: don't try to emit line tables if there are no functions with DI in the TU
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204795
91177308-0d34-0410-b5e6-
96231b3b80d8
Daniel Sanders [Wed, 26 Mar 2014 11:05:24 +0000 (11:05 +0000)]
[mips] $s8 is an alias for $fp in all ABI's, not just N32/N64.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204793
91177308-0d34-0410-b5e6-
96231b3b80d8
Daniel Sanders [Wed, 26 Mar 2014 10:54:30 +0000 (10:54 +0000)]
[mips] Move the CHECK lines in mips*-register-names.s to make it more obvious which CHECK matches with which insn
This reveals a small mistake in mips-register-names.s ($sp is tested twice and
$s8 is not tested) which will be fixed in a follow-up commit.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204792
91177308-0d34-0410-b5e6-
96231b3b80d8
Timur Iskhodzhanov [Wed, 26 Mar 2014 09:51:45 +0000 (09:51 +0000)]
Add tests for r204790
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204791
91177308-0d34-0410-b5e6-
96231b3b80d8
Timur Iskhodzhanov [Wed, 26 Mar 2014 09:50:36 +0000 (09:50 +0000)]
Fix PR19239 - Add support for generating debug info for functions without lexical scopes and/or debug info at all
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204790
91177308-0d34-0410-b5e6-
96231b3b80d8
Timur Iskhodzhanov [Wed, 26 Mar 2014 08:45:02 +0000 (08:45 +0000)]
Use -LABEL checks in the COFF debug info tests
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204788
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Wed, 26 Mar 2014 06:14:40 +0000 (06:14 +0000)]
Revert "Prevent alias from pointing to weak aliases."
This reverts commit r204781.
I will follow up to with msan folks to see what is what they
were trying to do with aliases to weak aliases.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204784
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Wed, 26 Mar 2014 04:55:40 +0000 (04:55 +0000)]
[PowerPC] Generate logical vector VSX instructions
These instructions are essentially the same as their Altivec counterparts, but
have access to the larger VSX register file.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204782
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Wed, 26 Mar 2014 04:48:47 +0000 (04:48 +0000)]
Prevent alias from pointing to weak aliases.
Aliases are just another name for a position in a file. As such, the
regular symbol resolutions are not applied. For example, given
define void @my_func() {
ret void
}
@my_alias = alias weak void ()* @my_func
@my_alias2 = alias void ()* @my_alias
We produce without this patch:
.weak my_alias
my_alias = my_func
.globl my_alias2
my_alias2 = my_alias
That is, in the resulting ELF file my_alias, my_func and my_alias are
just 3 names pointing to offset 0 of .text. That is *not* the
semantics of IR linking. For example, linking in a
@my_alias = alias void ()* @other_func
would require the strong my_alias to override the weak one and
my_alias2 would end up pointing to other_func.
There is no way to represent that with aliases being just another
name, so the best solution seems to be to just disallow it, converting
a miscompile into an error.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204781
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Wed, 26 Mar 2014 03:05:10 +0000 (03:05 +0000)]
DebugInfo: Add fission-related sections to COFF
Allows this test to pass on COFF platforms so we don't need to restrict
this test to a single target anymore.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204780
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Wed, 26 Mar 2014 00:16:43 +0000 (00:16 +0000)]
Correctly detect if a symbol uses a reserved section index or not.
The logic was incorrect for variables, causing them to end up in the wrong
section if the section had an index >= 0xff00.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204771
91177308-0d34-0410-b5e6-
96231b3b80d8
Quentin Colombet [Wed, 26 Mar 2014 00:10:22 +0000 (00:10 +0000)]
[X86] Add broadcast instructions to the table used by ExeDepsFix pass.
Adds the different broadcast instructions to the ReplaceableInstrsAVX2 table.
That way the ExeDepsFix pass can take better decisions when AVX2 broadcasts are
across domain (int <-> float).
In particular, prior to this patch we were generating:
vpbroadcastd LCPI1_0(%rip), %ymm2
vpand %ymm2, %ymm0, %ymm0
vmaxps %ymm1, %ymm0, %ymm0 ## <- domain change penalty
Now, we generate the following nice sequence where everything is in the float
domain:
vbroadcastss LCPI1_0(%rip), %ymm2
vandps %ymm2, %ymm0, %ymm0
vmaxps %ymm1, %ymm0, %ymm0
<rdar://problem/
16354675>
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204770
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Tue, 25 Mar 2014 23:44:25 +0000 (23:44 +0000)]
Create .symtab_shndxr only when needed.
We need .symtab_shndxr if and only if a symbol references a section with an
index >= 0xff00.
The old code was trying to figure out if the section was needed ahead of time,
making it a fairly dependent on the code actually writing the table. It was
also somewhat conservative and would create the section in cases where it was
not needed.
If I remember correctly, the old structure was there so that the sections were
created in the same order gas creates them. That was valuable when MC's support
for ELF was new and we tested with elf-dump.py.
This patch refactors the symbol table creation to another class and makes it
obvious that .symtab_shndxr is really only created when we are about to output
a reference to a section index >= 0xff00.
While here, also improve the tests to use macros. One file is one section
short of needing .symtab_shndxr, the second one has just the right number.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204769
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Tue, 25 Mar 2014 23:29:21 +0000 (23:29 +0000)]
[PowerPC] Select between VSX A-type and M-type FMA instructions just before RA
The VSX instruction set has two types of FMA instructions: A-type (where the
addend is taken from the output register) and M-type (where one of the product
operands is taken from the output register). This adds a small pass that runs
just after MI scheduling (and, thus, just before register allocation) that
mutates A-type instructions (that are created during isel) into M-type
instructions when:
1. This will eliminate an otherwise-necessary copy of the addend
2. One of the product operands is killed by the instruction
The "right" moment to make this decision is in between scheduling and register
allocation, because only there do we know whether or not one of the product
operands is killed by any particular instruction. Unfortunately, this also
makes the implementation somewhat complicated, because the MIs are not in SSA
form and we need to preserve the LiveIntervals analysis.
As a simple example, if we have:
%vreg5<def> = COPY %vreg9; VSLRC:%vreg5,%vreg9
%vreg5<def,tied1> = XSMADDADP %vreg5<tied0>, %vreg17, %vreg16,
%RM<imp-use>; VSLRC:%vreg5,%vreg17,%vreg16
...
%vreg9<def,tied1> = XSMADDADP %vreg9<tied0>, %vreg17, %vreg19,
%RM<imp-use>; VSLRC:%vreg9,%vreg17,%vreg19
...
We can eliminate the copy by changing from the A-type to the
M-type instruction. This means:
%vreg5<def,tied1> = XSMADDADP %vreg5<tied0>, %vreg17, %vreg16,
%RM<imp-use>; VSLRC:%vreg5,%vreg17,%vreg16
is replaced by:
%vreg16<def,tied1> = XSMADDMDP %vreg16<tied0>, %vreg18, %vreg9,
%RM<imp-use>; VSLRC:%vreg16,%vreg18,%vreg9
and we remove: %vreg5<def> = COPY %vreg9; VSLRC:%vreg5,%vreg9
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204768
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Tue, 25 Mar 2014 23:16:44 +0000 (23:16 +0000)]
llvm/test/DebugInfo/empty.ll: Suppress crash for targeting pecoff while investigating.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204766
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Tue, 25 Mar 2014 22:43:53 +0000 (22:43 +0000)]
Use Endian.h to simplify this code a bit.
While at it, factor some logic into FragmentWriter. This will allow more code
to be factored out of the fairly large ELFObjectWriter.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204765
91177308-0d34-0410-b5e6-
96231b3b80d8
Meador Inge [Tue, 25 Mar 2014 21:45:41 +0000 (21:45 +0000)]
[configure/make] Propagate names of build host tools when making BuildTools
When cross-compiling LLVM itself the configure/make scripts get confused when
creating the needed build host tools. For example, building and configuring
like:
CC_FOR_BUILD='i686-pc-linux-gnu-gcc' CXX_FOR_BUILD='i686-pc-linux-gnu-g++'
CXX='i686-mingw32-g++' CC='i686-mingw32-gcc' LD='i686-mingw32-ld' /scratch
/meadori/llvm-trunk/src/trunk/configure --host=i686-mingw32
CC_FOR_BUILD='i686-pc-linux-gnu-gcc' CXX_FOR_BUILD='i686-pc-linux-gnu-g++'
CXX='i686-mingw32-g++' CC='i686-mingw32-gcc' LD='i686-mingw32-ld' make
causes the following build break:
checking whether the C compiler works... configure: error: cannot run C
compiled programs.
If you meant to cross compile, use `--host'.
See `config.log' for more details.
The 'config.log' shows that i686-mingw32-gcc is being used to create
executables for the build host.
This patch fixes the problem by propogating the names of the build host
tools via BUILD_* when configuring/making BuildTools.
Original patch by Ekaterina Sanina.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204760
91177308-0d34-0410-b5e6-
96231b3b80d8
Juergen Ributzka [Tue, 25 Mar 2014 21:21:10 +0000 (21:21 +0000)]
[Constant Hoisting] Make the constant candidate map local to the collectConstantCandidates method.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204758
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Tue, 25 Mar 2014 19:26:43 +0000 (19:26 +0000)]
[PowerPC] Correct commutable indices for VSX FMA instructions
Although the first two operands are the ones that can be swapped, the tied
input operand is listed before them, so we need to adjust for that.
I have a test case for this, but it goes along with an upcoming commit (so it
will come soon).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204748
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Tue, 25 Mar 2014 18:55:11 +0000 (18:55 +0000)]
[PowerPC] Add a TableGen relation for A-type and M-type VSX FMA instructions
TableGen will create a lookup table for the A-type FMA instructions providing
their corresponding M-form opcodes. This will be used by upcoming commits.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204746
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Tue, 25 Mar 2014 18:18:27 +0000 (18:18 +0000)]
R600: Move computeMaskedBitsForTargetNode out of AMDILISelLowering.cpp
Remove handling of select_cc, since it makes no sense to be there. This
now does nothing, but I'll be adding some handling of other target nodes
soon.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204743
91177308-0d34-0410-b5e6-
96231b3b80d8