Jes Sorensen [Tue, 15 Apr 2014 17:44:39 +0000 (19:44 +0200)]
staging: rtl8723au: Clean up namespace clashes with rtl8188eu driver
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:38 +0000 (19:44 +0200)]
staging: rtl8188eu: os_intfs.c: Mark a couple of variables static
Mark these variables local to avoid namespace clash with other RTL
drivers.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:37 +0000 (19:44 +0200)]
staging: rtl8188eu: usb_intf.c: No point processing an empty table
In addition, this would globally disable HT if one device in the
system would mark it unsupported. If any device ended up requiring
this, it should be handled on a per-instance basis.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:36 +0000 (19:44 +0200)]
staging: rtl8723au: os_intfs.c: Declare a couple of local variables static
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:35 +0000 (19:44 +0200)]
staging: rtl8723au: init_channel_set(): Restructure variable names
Shorten variable names allowing for fewer broken lines due to the
large number of indents.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:34 +0000 (19:44 +0200)]
staging: rtl8723au: mgmt_dispatcher23a(): Use struct ieee80211_mgmt
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:33 +0000 (19:44 +0200)]
staging: rtl8723au: OnAuth23a(): ieee80211.h-ify
Switch to using struct ieee80211_mgmt to obtain offsets. Again a
bizarre +4 offset was applied for the IE scan which doesn't make
sense, since this offset wasn't applied for the auth struct elements.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:32 +0000 (19:44 +0200)]
staging: rtl8723au: OnAuth23aClient23a(): Clean up using struct ieee80211_mgmt
Use 80211_mgmt to determine offsets within the received frame. This
also removes a suspicious offset adjustment:
offset = ieee80211_has_protected(hdr->frame_control) ? 4: 0;
which didn't make any sense, since it was only applied to determining
the auth, sequence number, and status, but wasn't applied to the
location of the IEs.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:31 +0000 (19:44 +0200)]
staging: rtl8723au: OnAssocRsp23a() use ieee80211_mgmt to obtain DA
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:30 +0000 (19:44 +0200)]
staging: rtl8723au: OnAction23a_back23a(): Use struct ieee8011_mgmt to parse action frames
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:29 +0000 (19:44 +0200)]
staging: rtl8723au: OnAction23a(): Use struct ieee80211_mgmt instead of hardcoded offsets
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:28 +0000 (19:44 +0200)]
staging: rtl8723au: update_TSF() remove unused argument and move to rtw_mlme_ext.c
This is only called from rtw_mlme_ext.c, so move it that and declare
it static.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:27 +0000 (19:44 +0200)]
staging: rtl8723au: clean up update_TSF()
Clean up and simplify update_TSF() using proper Linux functions and
move it to rtw_mlme_ext.c which is the only user of it.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:26 +0000 (19:44 +0200)]
staging: rtl8723au: OnBeacon23a() tidy up code
Clean up the excessive if() levels at the end, and use struct
ieee80211_mgmt to calculate pointers passed on to check_assoc_AP23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:25 +0000 (19:44 +0200)]
staging: rtl8723au: rtw_mlme.c: remove commented out debug code
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:24 +0000 (19:44 +0200)]
staging: rtl8723au: Remove buggy function _rtw_report_sec_ie()
This function was extremely buggy calling kmalloc(GFP_KERNEL) while
holding a spin lock and then potentially overflowing the buffer it had
allocated.
Since the generated output wasn't used for anything, simply rip the
whole thing out.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:23 +0000 (19:44 +0200)]
staging: rtl8723au: OnProbeReq23a(): is_valid_p2p_probereq is always false
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:22 +0000 (19:44 +0200)]
staging: rtl8723au: OnProbeReq23a(): Use struct ieee80211_mgmt
Simplify parsing of probe request frame
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:21 +0000 (19:44 +0200)]
staging: rtl8723au: OnAssocReq23a(): use ieee80211_mgmt to calculate offset
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:20 +0000 (19:44 +0200)]
staging: rtl8723au: ioctl_cfg80211.c: Use eth_{zero,broadcast},addr()
Use kernel provided macros instead of own hacks.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:19 +0000 (19:44 +0200)]
staging: rtl8723au: Remove some unused ieee80211 structs
These are duplicated from the kernel headers and not used anymore
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:18 +0000 (19:44 +0200)]
staging: rtl8723au: Remove unused ieee880211_is_empty_essid()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:17 +0000 (19:44 +0200)]
staging: rtl8723au: Remove unused dump_wpsie23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:16 +0000 (19:44 +0200)]
staging: rtl8723au: Remove struct rtw_ieee802_11_elems and related code
This removes the double content tracking of data from IE elements. The
relevant code to validate IEs is moved to rtw_mlme_ext.c as this is
the only place where it is used.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:15 +0000 (19:44 +0200)]
staging: rtl8723au: OnAssocReq23a(): Use cfg80211_find_ie() to locate HT caps
Use cfg80211 interface to search for HT capabilities.
This was the last user of struct rtw_ieee802_11_elems, which can now
be removed.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:14 +0000 (19:44 +0200)]
staging: rtl8723au: OnAssocReq23a(): Don't check for presence of BSSID twice
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:13 +0000 (19:44 +0200)]
staging: rtl8723au: OnAssocReq23a(): Simplify parsing crypto info from the IE
This reduces the dependency of rtw_ieee802_11_parse_elems23a() which
is only used in this function. Follow-on patches will remove the
remaining dependencies and get rid of the function.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:12 +0000 (19:44 +0200)]
staging: rtl8723au: update_bcn_vendor_spec_ie(): Go easy on those brackets
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:11 +0000 (19:44 +0200)]
staging: rtl8723au: Remove multiple duplicate defines of the WPA OUI
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:10 +0000 (19:44 +0200)]
staging: rtl8723au: Remove unused for_each_ie() and dump_ies23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:09 +0000 (19:44 +0200)]
staging: rtl8723au: Remove obsolete rtw_get_wpa{2,}_ie23a() functions
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:08 +0000 (19:44 +0200)]
staging: rtl8723au: rtw_cfg80211_set_wpa_ie(): Remove unused variable 'pos'
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:07 +0000 (19:44 +0200)]
staging: rtl8723au: rtw_cfg80211_set_wpa_ie(): Use cfg80211_ API
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:06 +0000 (19:44 +0200)]
staging: rtl8723au: rtw_check_bcn_info23a(): Use cfg80211 to find WPA info
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:05 +0000 (19:44 +0200)]
staging: rtl8723au: rtw_check_bcn_info23a(): Remove excessive brackets
Remove excessive brackets and some general cleanups
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:04 +0000 (19:44 +0200)]
staging: rtl8723au: rtw_get_cipher_info(): Convert to use cfg80211_* API
Use cfg80211_find_ie() and cfg80211_find_vendor_ie() rather than own
hacks.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:03 +0000 (19:44 +0200)]
staging: rtl8723au: Use const * for parsing wpa IEs
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:02 +0000 (19:44 +0200)]
staging: rtl8723au: start_bss_network(): Use cfg80211_find_ie()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:01 +0000 (19:44 +0200)]
staging: rtl8723au: update_sta_support_rate23a(): Use cfg80211_find_ie()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:00 +0000 (19:44 +0200)]
staging: rtl8723au: rtw_check_bcn_info23a(): Clean up code obfuscation
There is no point doing a double check of the IE, either we found an
WLAN_EID_SSID or we didn't.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:59 +0000 (19:43 +0200)]
staging: rtl8723au: rtw_check_bcn_info23a(): Use cfg80211_find_ie()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:58 +0000 (19:43 +0200)]
staging: rtl8723au: Make rtw_check_bcn_info23() take a ieee80211_mgmt pointer
Clean up the code by passing a struct ieee80211_mgmt pointer instead
of a raw frame pointer. In addition check we receive a beacon frame,
anything else here is an error.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:57 +0000 (19:43 +0200)]
staging: rtl8723au: OnBeacon23a(): Use ieee80211_mgmt to calculate ie location
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:56 +0000 (19:43 +0200)]
staging: rtl8723au: OnBeacon23a(): Use struct ieee80211_mgmt
We always receive a struct ieee80211_mgmt frame here, using just
ieee80211_hdr doesn't make sense.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:55 +0000 (19:43 +0200)]
staging: rtl8723au: rtw_get_cur_max_rate23a(): use cfg80211_find_ie()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:54 +0000 (19:43 +0200)]
staging: rtl8723au: rtw_update_protection23a(): Use cfg80211_find_ie()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:53 +0000 (19:43 +0200)]
staging: rtl8723au: Make mlme_handlers and action_handlers return int
In addition, make them all static and move the prototypes to
rtw_mlme_ext.c.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:52 +0000 (19:43 +0200)]
staging: rtl8723au: OnAssocReq23a(): Clean up and use more ieee80211.h
This converts it to use struct ieee80211_mgmt and cfg80211_find_ie().
In addition fix a potential buffer overrun in the last loop searching
through list WLAN_EID_VENDOR_SPECIFIC elements.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:51 +0000 (19:43 +0200)]
staging: rtl8723au: issue_probersp23a(): various cleanups
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:50 +0000 (19:43 +0200)]
staging: rtl8723au: issue_asocrsp23a(): Use cfg80211_find_ie() and cleanups
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:49 +0000 (19:43 +0200)]
staging: rtl8723au: issue_assocreq23a(): General cleanups and use cfg80211_find_ie()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:48 +0000 (19:43 +0200)]
staging: rtl8723au: issue_action_BSSCoexistPacket(): Clean + use cfg80211_find_ie()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:47 +0000 (19:43 +0200)]
staging: rtl8723au: collect_bss_info23a(): Convert to use cfg80211_fine_ie()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:46 +0000 (19:43 +0200)]
staging: rtl8723au: process_80211d() use cfg80211_find_ie()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:45 +0000 (19:43 +0200)]
staging: rtl8723au: OnAction23_back23a() Use ieee80211_mgmt and bug fixes
This converts OnAction23a_back23a() to using struct ieee80211_mgmt to
parse the response packet. In addition this revealed a bug which has
been fixed:
case WLAN_ACTION_ADDBA_RESP: /* ADDBA response */
status = get_unaligned_le16(&frame_body[3]);
tid = ((frame_body[5] >> 2) & 0x7);
The above masks the tid to 3 bits, however per ieee80211.h, the tid is
in fact 4 bits wide, as defined by IEEE80211_ADDBA_PARAM_TID_MASK (0x3c)
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:44 +0000 (19:43 +0200)]
staging: rtl8723au: OnDisassoc23(): Use ieee80211_mgmt
Use proper kernel ieee80211.h defined headers to parse the response.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:43 +0000 (19:43 +0200)]
staging: rtl8723au: OnDeAuth23a() use ieee80211 header defines
Use the proper ieee80211.h structs to parse the response instead of
hard coded offsets.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:42 +0000 (19:43 +0200)]
staging: rtl8723au: OnAssocRsp23a() use ieee80211 header defines
Use the proper ieee80211.h structs to parse the response instead of
hard coded offsets.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:41 +0000 (19:43 +0200)]
staging: rtl8723au: OnAuth23aClient23a() Use cfg80211_find_ie()
Use cfg80211_find_ie() and tidy up the code
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:40 +0000 (19:43 +0200)]
staging: rtl8723au: OnAuth23() Use cfg80211_find_ie()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:39 +0000 (19:43 +0200)]
staging: rtl8723au: OnProbeReq23a() Use cfg80211_find_ie()
Switch to using cfg80211_find_ie() and tidy of the code.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:38 +0000 (19:43 +0200)]
staging: rtl8723au: rtw_update_ht_ie23a(): use cfg80211_find_ie()
Switch to using cfg80211_find_ie() and remove commented out code.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:37 +0000 (19:43 +0200)]
staging: rtl8723au: rtw_restructure_ht_ie23a(): use cfg80211_find_ie()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:36 +0000 (19:43 +0200)]
staging: rtl8723au: Remove another stack of unused P2P related #defines
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:35 +0000 (19:43 +0200)]
staging: rtl8723au: Remove P2P/WiFiDirect/WiFiDisplay code
Discussing with Johannes Berg and Larry Finger, we have concluded that
this code really should be handled through wpa_supplicant, and not in
the kernel.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:34 +0000 (19:43 +0200)]
staging: rtl8723au: Remove obsolete local defines matching WLAN_EID_*
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:33 +0000 (19:43 +0200)]
staging: rtl8723au: Fixup last users to use the kernel's WLAN_EID_* definitions
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:32 +0000 (19:43 +0200)]
staging: rtl8723au: rtw_recv.c: Use the kernel's WLAN_EID_* definitions
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:31 +0000 (19:43 +0200)]
staging: rtl8723au: rtw_xmit.c: Use the kernel's WLAN_EID_* definitions
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:30 +0000 (19:43 +0200)]
staging: rtl8723au: rtl8723a_cmd.c: Use the kernel's WLAN_EID_* definitions
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:29 +0000 (19:43 +0200)]
staging: rtl8723au: rtw_wlan_util.c: Use the kernel's WLAN_EID_* definitions
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:28 +0000 (19:43 +0200)]
staging: rtl8723au: rtw_ieee80211.c: Use the kernel's WLAN_EID_* definitions
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:27 +0000 (19:43 +0200)]
staging: rtl8723au: rtw_p2p.c: Use the kernel's WLAN_EID_* definitions
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:26 +0000 (19:43 +0200)]
staging: rtl8723au: rtw_ap.c: Use the kernel's WLAN_EID_* definitions
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:25 +0000 (19:43 +0200)]
staging: rtl8723au: rtw_mlme.c: Use the kernel's WLAN_EID_* definitions
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:24 +0000 (19:43 +0200)]
staging: rtl8723au: rtw_mlme_ext.c: Use the kernel's WLAN_EID_* definitions
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:23 +0000 (19:43 +0200)]
staging: rtl8723au: make source * argument const
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:22 +0000 (19:43 +0200)]
staging: rtl8723au: rtw_security.h - remove some unused macros
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:21 +0000 (19:43 +0200)]
staging: rtl8723au: Remove duplicate #defines for WLAN_EID_VENDOR_SPECIFIC
Lets not keep one local copy ... no lets keep two ... no lets keep three!
Rip them all out and use the kernel provided one.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:20 +0000 (19:43 +0200)]
staging: rtl8723au: Fix buffer overflow in rtw_get_wfd_ie()
Add bounds checking to not allow WFD Information Elements larger than
128, and make sure we use the correct buffer size MAX_WFD_IE_LEN
instea of hardcoding the size.
This also simplifies rtw_get_wfd_ie() by using the cfg80211
infrastructure.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Mon, 14 Apr 2014 20:42:43 +0000 (16:42 -0400)]
staging: dgap: remove uchar typedef and replace use with u8
This patch removes the uchar typedef in dgap.h
and changes all uses of it to u8.
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Fri, 28 Mar 2014 13:30:15 +0000 (09:30 -0400)]
staging: dgap: rename and fixup dgap_wait_for_xxx functions
This patch renames and changes the dgap_wait_for_bios and
dgap_wait_for_fep functions from boolean functions to return
zero on success and a negative error code on error.
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Tue, 25 Mar 2014 20:38:17 +0000 (16:38 -0400)]
staging: dgap: fix/change a pr_info
This patch just fixes a pr_info. brd->state is not proper
at this point in time.
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Tue, 25 Mar 2014 20:38:16 +0000 (16:38 -0400)]
staging: dgap: remove volatiles from dgap.h
This patch fixes checkpatch warnings about using volatiles in dgap.h
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Tue, 25 Mar 2014 20:38:15 +0000 (16:38 -0400)]
staging: dgap: Macros with complex values should be enclosed in parenthesis
This patch fixes a checkpatch warning
"Macros with complex values should be enclosed in parenthesis"
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Tue, 25 Mar 2014 20:38:14 +0000 (16:38 -0400)]
staging: dgap: Only read config file dgap.conf once
The config file is currently read for each board found.
It only needs to be read one time. The buffer it is read
into can now be freed immediately after it is parsed
instead of at driver unload time.
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Tue, 25 Mar 2014 20:38:13 +0000 (16:38 -0400)]
staging: dgap: Removes excessive empty lines from dgap.h
This patch removes excessive empty lines from dgap.h
not previously caught.
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Fri, 21 Mar 2014 14:41:14 +0000 (10:41 -0400)]
staging: dgap: remove some unused code in dgap.h
This patch removes some unused code in dgap.h
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Fri, 21 Mar 2014 14:41:13 +0000 (10:41 -0400)]
staging: dgap: Fix several 80+ line warnings in dgap.h
This patch fixes several 80+ char line warnings as reported
by checkpatch in dgap.h
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Fri, 21 Mar 2014 14:41:12 +0000 (10:41 -0400)]
staging: dgap: fix some whitespace warnings in dgap.h
This patch fixes some whitespace warnings as reported
by checkpatch in dgap.h.
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Fri, 21 Mar 2014 14:41:11 +0000 (10:41 -0400)]
staging: dgap: Remove some unneeded comments
This patch removes some unneeded comments from dgap.c
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Fri, 21 Mar 2014 14:41:10 +0000 (10:41 -0400)]
staging: dgap: Remove some unused code in dgap.c
This patch removes some unused code in dgap.c.
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Einon [Thu, 10 Apr 2014 12:35:00 +0000 (13:35 +0100)]
staging: rtl8821ae: Fix rtl8821ae/hw.h pointer declaration style
Fix all occurences of the checkpatch error:
ERROR: "foo* bar" should be "foo *bar"
Signed-off-by: Mark Einon <mark.einon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Einon [Thu, 10 Apr 2014 12:34:59 +0000 (13:34 +0100)]
staging: rtl8821ae: Remove FSF mailing address from rtl8821ae/hw.h header
Fix checkpatch check:
CHECK: Do not include the paragraph about writing to the Free Software
Foundation's mailing address from the sample GPL notice. The FSF has
changed addresses in the past, and may do so again. Linux already
includes a copy of the GPL.
Signed-off-by: Mark Einon <mark.einon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Einon [Thu, 10 Apr 2014 12:34:58 +0000 (13:34 +0100)]
staging: rtl8821ae: Fix whitespace in rtl8821ae/hw.h
Fix checkpatch warnings, lines over 80 chars using tabs where possible.
Signed-off-by: Mark Einon <mark.einon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Welling [Thu, 10 Apr 2014 02:26:45 +0000 (21:26 -0500)]
Staging: iio: Switch from msleep to usleep range per timers-howto.txt
Signed-off-by: Michael Welling <mwelling@ieee.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Welling [Thu, 10 Apr 2014 02:26:44 +0000 (21:26 -0500)]
Staging: iio: Remove quoted string split across lines warnings
Signed-off-by: Michael Welling <mwelling@ieee.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Welling [Thu, 10 Apr 2014 02:26:43 +0000 (21:26 -0500)]
Staging: iio: Removes unwanted space before semicolon
Signed-off-by: Michael Welling <mwelling@ieee.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Joel Porquet [Wed, 9 Apr 2014 18:09:45 +0000 (20:09 +0200)]
staging: iio: fix coding style
As suggested by checkpatch.pl, use dev_info() instead of
printk(KERN_INFO ...) to print message.
Signed-off-by: Joel Porquet <joel@porquet.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luis Ortega [Wed, 9 Apr 2014 11:56:09 +0000 (13:56 +0200)]
Staging: bcm: Qos: fixed braces' coding style
Fixed badly placed and unnecessary braces.
PS: Performed as task 10 of the Eudyptula Challenge.
Signed-off-by: Luis Ortega <luiorpe1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
projects / firefly-linux-kernel-4.4.55.git / log