Ebru Akagunduz [Thu, 2 Oct 2014 20:32:07 +0000 (23:32 +0300)]
staging: emxx_udc: Use min_t instead of min
Use min_t instead of min function in emxx_udc.c
Fix checkpatch.pl warnings:
WARNING: min() should probably be min_t(u32, iBufSize, ep->ep.maxpacket)
WARNING: min() should probably be min_t(u32, data_size, ep->ep.maxpacket)
WARNING: min() should probably be min_t(u16, udc->ctrl.wLength, sizeof(status_data))
Changes in v2:
- Fixed min function call as min_t
Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ebru Akagunduz [Thu, 2 Oct 2014 20:32:06 +0000 (23:32 +0300)]
staging: emxx_udc: Fix replace printk(KERN_DEBUG ..) with dev_dbg
This patch fixes "Prefer [subsystem eg: netdev]_dbg([subsystem]dev,
... then dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG"
checkpatch.pl warning in emxx_udc.c
Changes in v2:
- Fixed dev_debug function call as dev_dbg
Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Yeliz Taneroglu [Thu, 2 Oct 2014 19:02:20 +0000 (22:02 +0300)]
staging: media: Fixed else after return or break warning
The following patch fixes the checkpatch.pl warning:
drivers/staging/media/omap4iss/iss_csi2.c:811 warning: else is not generally useful after a break or return
Signed-off-by: Yeliz Taneroglu <yeliztaneroglu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Yeliz Taneroglu [Thu, 2 Oct 2014 19:09:47 +0000 (22:09 +0300)]
staging: media: omap4iss: Fixed else after return or break warning
The following patch fixes the checkpatch.pl warning:
drivers/staging/media/omap4iss/iss_ipipe.c:184 warning: else is not generally useful after a break or return
Signed-off-by: Yeliz Taneroglu <yeliztaneroglu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sarah Khan [Thu, 2 Oct 2014 19:41:35 +0000 (01:11 +0530)]
staging: rtl8712: Fixed else not required after return
WARNING: Else generally not required after return
checkpatch.pl warning in hal_init.c
Fixed by removing else
Signed-off-by: Sarah Khan <sarahjmi07@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Melike Yurtoglu [Tue, 30 Sep 2014 19:25:11 +0000 (22:25 +0300)]
staging: rtl8712: Fix missing blank line warning
Fixes "Missing a blank line after declarations" checkpatch.pl warning in
usb_ops_linux.c
Signed-off-by: Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Feyza Yavuz [Wed, 1 Oct 2014 18:29:52 +0000 (21:29 +0300)]
staging: rtl8192e: rtl8192e: Remove spaces before the semicolons
Patch the following checkpatch.pl warnings
drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c:232: warning:
space prohibited before semicolon
drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c:236: warning:
space prohibited before semicolon
Signed-off-by: Feyza Yavuz <feyzaayavuz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Feyza Yavuz [Wed, 1 Oct 2014 18:29:51 +0000 (21:29 +0300)]
staging: rtl8192e: rtl8192e: Remove unnecessary return statements
Patch the following checkpatch.pl warnings
drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c:304: warning:
void function return statements are not generally useful
drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c:83: warning:
void function return statements are not generally useful
Signed-off-by: Feyza Yavuz <feyzaayavuz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Melike Yurtoglu [Tue, 30 Sep 2014 21:21:54 +0000 (00:21 +0300)]
staging: rtl8192e: Remove unneeded void return
Fixes "void function return statements are not generally
useful"checkpatch.pl warning
Signed-off-by: Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Melike Yurtoglu [Tue, 30 Sep 2014 19:08:18 +0000 (22:08 +0300)]
staging: rtl8192e: Fix void function return statements style
Fixes "void function return statements are not generally
useful"checkpatch.pl warning in rtl819x_HTProc.c
Signed-off-by: Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Yeliz Taneroglu [Tue, 30 Sep 2014 18:35:59 +0000 (21:35 +0300)]
staging: rtl8712: Fix unnecessary parentheses style warning
This fixes the following checkpatch.pl warning:
drivers/staging/rtl8712/rtl871x_recv.c:634 warning: Unnecessary parentheses - maybe == should be = ?
Signed-off-by: Yeliz Taneroglu <yeliztaneroglu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Melike Yurtoglu [Tue, 30 Sep 2014 17:43:16 +0000 (20:43 +0300)]
staging: rtl8192e: Fix unnecessary space before function pointer arguments
This patch fixes these warning messages found by checkpatch.pl:
WARNING: Unnecessary space before function pointer arguments
Signed-off-by: Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Melike Yurtoglu [Tue, 30 Sep 2014 17:43:15 +0000 (20:43 +0300)]
staging: rtl8192e: Array was made static const char * const
This patch fixes checkpatch.pl error in file rtllib.h
WARNING: static const char * array should probably be static
const char * const
Signed-off-by: Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gulsah Kose [Tue, 30 Sep 2014 17:32:08 +0000 (20:32 +0300)]
staging: ft1000: ft1000-usb: Removed unnecessary else statement.
This patch fixes "else is not generally useful after a break or return"
checkpatch.pl warning in ft1000_download.c
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gulsah Kose [Tue, 30 Sep 2014 17:32:07 +0000 (20:32 +0300)]
staging: ft1000: ft1000-usb: Removed unnecessary else statement.
This patch fixes "else is not generally useful after a break or return"
checkpatch.pl warning in ft1000_hw.c
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gulsah Kose [Tue, 30 Sep 2014 17:32:06 +0000 (20:32 +0300)]
staging: ft1000: ft1000-usb: Removed unnecessary parentheses.
This patch fixes "Unnecessary parentheses" checkpatch.pl warning in
ft1000_hw.c
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gulsah Kose [Tue, 30 Sep 2014 17:32:05 +0000 (20:32 +0300)]
staging: ft1000: ft1000-usb: Added new line after declarations.
This patch fixes "Missing a blank line after declarations" checkpatch.pl
warning in ft1000_hw.c
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Esra Altintas [Mon, 29 Sep 2014 18:55:06 +0000 (21:55 +0300)]
staging: vt6655: Fixed C99 // comment errors in wpactl.c
The following patch fixes the checkpatch.pl warning:
ERROR: do not use C99 // comments
Signed-off-by: Esra Altintas <es.altintas@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Melike Yurtoglu [Tue, 30 Sep 2014 22:24:01 +0000 (01:24 +0300)]
staging: speakup: Fixed warning <linux/serial.h> instead of <asm/serial.h>
This patch fixes warning: 'use <linux/serial.h> instead <asm/serial.h>'
found by checkpatch
Signed-off-by: Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Melike Yurtoglu [Tue, 30 Sep 2014 22:36:29 +0000 (01:36 +0300)]
staging: speakup: Fix missing blank line warning
Fixes "Missing a blank line after declarations" checkpatch.pl warning
in varhandlers.c
Signed-off-by: Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Roxana Blaj [Thu, 2 Oct 2014 15:20:35 +0000 (18:20 +0300)]
staging: rts5208: remove unnecessary else
This fixes the checkpatch.pl warning:
WARNING: else is not generally useful after a break or return
Signed-off-by: Roxana Blaj <roxanagabriela10@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Roxana Blaj [Thu, 2 Oct 2014 15:20:34 +0000 (18:20 +0300)]
staging: rts5208: remove unnecessary else
This fixes the checkpatch.pl warning:
WARNING: else is not generally useful after a break or return
Signed-off-by: Roxana Blaj <roxanagabriela10@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Melike Yurtoglu [Tue, 30 Sep 2014 21:31:06 +0000 (00:31 +0300)]
staging: rts5208: Remove unneeded void return
Fixes "void function return statements are not generally
useful"checkpatch.pl warning
Signed-off-by: Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Melike Yurtoglu [Mon, 29 Sep 2014 18:28:02 +0000 (21:28 +0300)]
staging: rts5208: Fix missing blank line warning.
Fixes "Missing a blank line after declarations" checkpatch.pl warning in
rtsx_scsi.c
Signed-off-by: Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Vaishali Thakkar [Thu, 2 Oct 2014 10:29:19 +0000 (15:59 +0530)]
Staging: iio: adc: Update Kconfig entries adding module name information
This patch fixes the following checkpatch.pl warning:
WARNING: please write a paragraph that describes the config symbol fully
Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Vaishali Thakkar [Thu, 2 Oct 2014 05:50:20 +0000 (11:20 +0530)]
Staging: iio: adc: Add missing blank line
This fixes following checkpatch.pl warningi:
WARNING: Missing a blank line after declarations
Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Roberta Dobrescu [Wed, 1 Oct 2014 23:35:38 +0000 (02:35 +0300)]
staging: iio: resolver: Annotate Kconfig entries with module name information
This fixes the following checkpatch.pl warning:
WARNING: please write a paragraph that describes the config symbol fully
Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gulsah Kose [Tue, 30 Sep 2014 21:09:11 +0000 (00:09 +0300)]
staging: iio: addac: Combined seperated strings.
This patch fixes "quoted string split across lines" checkpatch.pl
warning in adt7316.c
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gulsah Kose [Tue, 30 Sep 2014 21:09:10 +0000 (00:09 +0300)]
staging: iio: accel: Removed unnecessary else expression.
This patch fixes "else is not generally useful after a break or return"
checkpatch.pl warning in adis16220_core.c
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Darshana Padmadas [Tue, 30 Sep 2014 17:34:59 +0000 (23:04 +0530)]
Staging: iio: meter: Remove space before start of line
This patch removes spaces before start of the line reported by checkpatch.pl
Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Darshana Padmadas [Tue, 30 Sep 2014 17:34:58 +0000 (23:04 +0530)]
Staging: iio: meter: Delete white spaces to make line shorter
Found using checkpatch warning.
Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Darshana Padmadas [Tue, 30 Sep 2014 14:52:56 +0000 (20:22 +0530)]
Staging: iio: meter: Add blank line after declarations
This patch adds a blank line after declarations found by checkpatch warning.
Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Darshana Padmadas [Tue, 30 Sep 2014 14:52:57 +0000 (20:22 +0530)]
Staging: iio: meter: Add blank line after declarations.
This patch adds a blank line after declarations to fix checkpatch warning.
Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Darshana Padmadas [Tue, 30 Sep 2014 14:52:58 +0000 (20:22 +0530)]
Staging: iio: meter: Add a blank line after declarations
Patch fixes warning and adds a blank line after declarations
Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Roxana Blaj [Tue, 30 Sep 2014 09:36:29 +0000 (12:36 +0300)]
staging: iio: addac: remove unnecessary else
This fixes the checkpatch.pl warning:
WARNING: else is not generally useful after a break or return
Signed-off-by: Roxana Blaj <roxanagabriela10@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gulsah Kose [Tue, 30 Sep 2014 19:12:23 +0000 (22:12 +0300)]
staging: octeon: Combined seperate strings.
This patch fixes "quoted string split across lines" checkpatch.pl
warning in ethernet-rx.c
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gulsah Kose [Tue, 30 Sep 2014 19:12:22 +0000 (22:12 +0300)]
staging: octeon: Combined seperate strings.
This patch fixes "quoted string split across lines" checkpatch.pl
warning in ethernet-rgmii.c
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Wed, 1 Oct 2014 09:09:51 +0000 (14:39 +0530)]
Staging: lustre: lnet: selftest: Made a function static.
The following patch makes a function static as it was not used by other
files.
The patch fixes the warning:
WARNING: symbol 'brw_fill_bulk' was not declared. Should it be
static?
The above warning was reported by sparse.
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Wed, 1 Oct 2014 09:09:02 +0000 (14:39 +0530)]
Staging: lustre: lnet: selftest: Made a function static.
The following patch makes a function static as it was not used by other
files.
The patch fixes the warning:
WARNING: symbol 'brw_check_page' was not declared. Should it be static?
The above warning was reported by sparse.
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Wed, 1 Oct 2014 09:08:17 +0000 (14:38 +0530)]
Staging: lustre: lnet: selftest: Made a function static.
The following patch makes a function static as it was not used by other
files.
The patch fixes the warning:
WARNING: symbol 'brw_fill_page' was not declared. Should it be static?
The above warning was reported by sparse.
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Wed, 1 Oct 2014 09:07:36 +0000 (14:37 +0530)]
Staging: lustre: lnet: selftest: Made a function static.
The following patch makes a function static as it is not used by other
files.
The patch fixes the following warning:
WARNING: symbol brw_inject_one_error was not declared. Should it be
static?
The above warning was reported by sparse.
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Wed, 1 Oct 2014 09:06:27 +0000 (14:36 +0530)]
Staging: lustre: lnet: selftest: Made a function static.
The following patch makes a function static as it was not used by other
files.
The patch fixes the following warning:
WARNING: symbol brw_client_init was not declared. Should it be static?
The above warning was reported by sparse.
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Wed, 1 Oct 2014 08:09:28 +0000 (13:39 +0530)]
Staging: lustre: lnet: selftest: Made a function static.
The following patch makes a function static as it was not used by other
files and not declared in the same file.
It fixes the following warning:
WARNING: symbol 'lstcon_init_acceptor_service' was not declared. Should
it be static?
The above warning was given by sparse.
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gulsah Kose [Tue, 30 Sep 2014 18:59:20 +0000 (21:59 +0300)]
staging: lustre: include: linux: libcfs: linux: Removed line continuations.
This patch fixes "Avoid unnecessary line continuations" checkpatch.pl
warning in linux-time.h
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gulsah Kose [Tue, 30 Sep 2014 18:59:21 +0000 (21:59 +0300)]
staging: lustre: include: linux: libcfs: Removed unnecessary else expression.
This patch fixes "else is not generally useful after a break or return"
checkpatch.pl warning libcfs.h
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gulsah Kose [Tue, 30 Sep 2014 18:59:19 +0000 (21:59 +0300)]
staging: lustre: include: linux: libcfs: linux: Used "linux" instead of "asm".
This patch fixes "Use #include <linux/uaccess.h> instead of
<asm/uaccess.h"> checkpatch.pl warning in libcfs.h
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tapasweni Pathak [Mon, 29 Sep 2014 10:33:12 +0000 (16:03 +0530)]
staging: lustre: lustre: obdclass: linux: include <linux/*.h> instead of <asm/*.h>
This patch fixes checpatch.pl warning in linux-module.c file.
WARNING: Use #include <linux/io.h> instead of <asm/io.h>
WARNING: Use #include <linux/poll.h> instead of <asm/poll.h>
WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tapasweni Pathak [Mon, 29 Sep 2014 10:32:46 +0000 (16:02 +0530)]
staging: lustre: lnet: lnet: Remove space between function name and open paranthesis '('
This patch fixes checpatch.pl warning in api-ni.c file.
WARNING: space prohibited between function name and open parenthesis '('
Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tapasweni Pathak [Mon, 29 Sep 2014 10:32:23 +0000 (16:02 +0530)]
staging: lustre: lnet: lnet: Remove unnecessary else after return
This patch fixes checpatch.pl warning in acceptor.c file.
WARNING: else is not generally useful after a break or return
Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tapasweni Pathak [Mon, 29 Sep 2014 10:31:59 +0000 (16:01 +0530)]
staging: lustre: include: linux: libcfs: Remove spaces at the start of a line
This patch fixes checpatch.pl warning in file libcfs_cpu.h
WARNING: please, no spaces at the start of a line
Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tapasweni Pathak [Mon, 29 Sep 2014 10:31:39 +0000 (16:01 +0530)]
staging: lustre: include: linux: libcfs: Remove intialization of static to 0
This patch fixes checpatch.pl error in file libcfs_time.h
ERROR: do not initialise statics to 0 or NULL
Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tapasweni Pathak [Mon, 29 Sep 2014 10:31:14 +0000 (16:01 +0530)]
staging: lustre: include: linux: libcfs: use __packed instead of __attribute__((packed))
This patch fixes checpatch.pl warning in libcfs_debug.h file.
WARNING: __packed is preferred over __attribute__((packed))
Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Tue, 30 Sep 2014 16:08:51 +0000 (12:08 -0400)]
staging: unisys: Fix CamelCase in uislib_force_channel_interrupt()
Fix CamelCase names:
busNo => bus_no
devNo => dev_no
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Tue, 30 Sep 2014 16:08:50 +0000 (12:08 -0400)]
staging: unisys: Fix CamelCase in uislib_disable_channel_interrupts()
Fix CamelCase names:
busNo => bus_no
devNo => dev_no
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Tue, 30 Sep 2014 16:08:49 +0000 (12:08 -0400)]
staging: unisys: Fix CamelCase in uislib_enable_channel_interrupts()
Fix CamelCase names:
busNo => bus_no
devNo => dev_no
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Tue, 30 Sep 2014 16:08:48 +0000 (12:08 -0400)]
staging: unisys: Fix CamelCase in Issue_VMCALL_FATAL_BYE_BYE()
Fix Camelcase name:
Issue_VMCALL_FATAL_BYE_BYE => issue_vmcall_fatal
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Tue, 30 Sep 2014 16:08:47 +0000 (12:08 -0400)]
staging: unisys: Fix CamelCase in Issue_VMCALL_CHANNEL_MISMATCH()
Fix CamelCase names:
Issue_VMCALL_CHANNEL_MISMATCH => issue_vmcall_channel_mismatch
ChannelName => chname
ItemName => item_name
SourceLineNumber => line_no
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Tue, 30 Sep 2014 16:08:46 +0000 (12:08 -0400)]
staging: unisys: Fix CamelCase in Issue_VMCALL_UPDATE_PHYSICAL_TIME()
Fix CamelCase names:
Issue_VMCALL_UPDATE_PHYSICAL_TIME => issue_vmcall_update_physical_time
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Tue, 30 Sep 2014 16:08:45 +0000 (12:08 -0400)]
staging: unisys: fix CamelCase in Issue_VMCALL_MEASUREMENT_DO_NOTHING()
Fix CamelCase names:
Issue_VMCALL_MEASUREMENT_DO_NOTHING =>
issue_vmcall_measurement_do_nothing
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Tue, 30 Sep 2014 16:08:44 +0000 (12:08 -0400)]
staging: unisys: fix Issue_VMCALL_QUERY_GUEST_VIRTUAL_TIME_OFFSET()
Fix CamelCase names:
Issue_VMCALL_QUERY_GUEST_VIRTUAL_TIME_OFFSET =>
issue_vmcall_query_guest_virtual_time_offset
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Tue, 30 Sep 2014 16:08:43 +0000 (12:08 -0400)]
staging: unisys: Fix CamelCase in Issue_VMCALL_IO_VISORSERIAL_ADDR()
Fix CamelCase names:
Issue_VMCALL_IO_VISORSERIAL_ADDR => issue_vmcall_io_visorserial_addr
DiagChannelAddress => channel_addr
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Tue, 30 Sep 2014 16:08:42 +0000 (12:08 -0400)]
staging: unisys: Fix CamelCase Issue_VMCALL_IO_DIAG_ADDR()
Fix CamelCase names:
Issue_VMCALL_IO_DIAG_ADDR => issue_vmcall_io_diag_addr
DiagChannelAddress => diag_channel_addr
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Tue, 30 Sep 2014 16:08:41 +0000 (12:08 -0400)]
staging: unisys: Fix CamelCase in Issue_VMCALL_IO_CONTROLVM_ADDR()
Fix CamelCase names:
Issue_VMCALL_IO_CONTROLVM_ADDR => issue_vmcall_io_controlvm_addr
ControlAddress => control_addr
ControlBytes => control_bytes
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Tue, 30 Sep 2014 16:08:27 +0000 (12:08 -0400)]
staging: unisys: fix CamelCase in uisctrl_register_req_handler
Fix CamelCase names:
chipset_driverInfo => chipset_driver_info
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Tue, 30 Sep 2014 16:08:17 +0000 (12:08 -0400)]
staging: unisys: get rid of typedef for EVENT_PC
Just switch EVENT_PC over to enum event_pc.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Tue, 30 Sep 2014 16:08:16 +0000 (12:08 -0400)]
staging: unisys: get rid of typedef for DRIVER_PC
Simply switch DRIVER_PC to enum driver_pc.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Tue, 30 Sep 2014 16:08:15 +0000 (12:08 -0400)]
staging: unisys: remove doubled blank lines in guestlinuxdebug.h
Take out those doubled blank lines in guestlinuxdebug.h.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Tue, 30 Sep 2014 16:08:14 +0000 (12:08 -0400)]
staging: unisys: fix CamelCase in bus_device_info_init()
Fix CamelCase names:
BusDeviceInfo_Init => bus_device_info_init
pBusDeviceInfo => bus_device_info_ptr
deviceType => dev_type
driverName => driver_name
verTag => ver_tag
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Tue, 30 Sep 2014 16:08:13 +0000 (12:08 -0400)]
staging: unisys: fix copyright symbol in vbushelper.h
The copyright character in vbushelper.h isn't UTF-8 - swap it out for a
good, old-fashioned (C).
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Tue, 30 Sep 2014 16:08:12 +0000 (12:08 -0400)]
staging: unisys: fix line spacing in uniklog.h
Take out the doubled blank lines in uniklog.h, too.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Tue, 30 Sep 2014 16:08:11 +0000 (12:08 -0400)]
staging: unisys: remove excess blank lines in uisthread.h
Take out those doubled blank lines in uisthread.h.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Tue, 30 Sep 2014 16:08:10 +0000 (12:08 -0400)]
staging: unisys: fix up CamelCase in struct init_chipset_guestpart
Fix up CamelCase names:
busCount => bus_count
switch_count => switch_count
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Tue, 30 Sep 2014 16:08:09 +0000 (12:08 -0400)]
staging: unisys: clean up CamelCase names in struct add_virt_guestpart
Clean up CamelCase names:
busNo => bus_no
deviceNo => device_no
devInstGuid => instance_uuid
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Tue, 30 Sep 2014 16:08:08 +0000 (12:08 -0400)]
staging: unisys: fix CamelCase in struct del_vbus_guestpart
Fix up CamelCase names:
busNo => bus_no
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Tue, 30 Sep 2014 16:08:06 +0000 (12:08 -0400)]
staging: unisys: fix CamelCase definitions in struct io_msgs
Clean up CamelCase names:
extPort => ext_port
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Tue, 30 Sep 2014 16:08:05 +0000 (12:08 -0400)]
staging: unisys: fix CamelCase names in del_virt_iopart
Clean up CamelCase names:
busNo => bus_no
devNo => dev_no
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Tue, 30 Sep 2014 16:08:04 +0000 (12:08 -0400)]
staging: unisys: fix CamelCase in del_vdisk_iopart
Fix CamelCase names:
busNo => bus_no
devNo => dev_no
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Tue, 30 Sep 2014 16:08:03 +0000 (12:08 -0400)]
staging: unisys: fix CamelCase names in struct add_vdisk_iopart
Fix CamelCase names:
busNo => bus_no
devNo => dev_no
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Tue, 30 Sep 2014 16:08:02 +0000 (12:08 -0400)]
staging: unisys: clean up CamelCase in struct add_virt_iopart
Clean up CamelCase names:
guestHandle => guest_handle
recvBusInterruptHandle => recv_bus_irq_handle
useG2GCopy => use_g2g_copy
Filler => filler
busNo => bus_no
dev_no => dev_no
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Tue, 30 Sep 2014 16:08:01 +0000 (12:08 -0400)]
staging: unisys: fix CamelCase struct name NetworkPolicy
Clean up CamelCase name:
NetworkPolicy => network_policy
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Tue, 30 Sep 2014 16:08:00 +0000 (12:08 -0400)]
staging: unisys: clean up CamelCase in DEDICATED_SWITCH() macro
Clean up CamelCase names:
pSwitch => s
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Tue, 30 Sep 2014 16:07:58 +0000 (12:07 -0400)]
staging: unisys: fix CamelCase in struct device_info
Clean up CamelCase names:
channelAddr => channel_addr
channelBytes => channel_bytes
channelTypeGuid => channel_uuid
devInstGuid => instance_uuid
busNo => bus_no
devNo => dev_no
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Tue, 30 Sep 2014 16:07:55 +0000 (12:07 -0400)]
staging: unisys: remove uisqueue_send_int_if_needed()
This function is not used anywhere, so remove it.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Tue, 30 Sep 2014 16:07:54 +0000 (12:07 -0400)]
staging: unisys: fix CamelCase in uisqueue_put_cmdrsp_with_lock_client
Clean up CamelCase names:
issueInterruptIfEmpty => issue_irq_if_empty
interruptHandle => irq_handle
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Tue, 30 Sep 2014 16:07:53 +0000 (12:07 -0400)]
staging: unisys: Clean up CamelCase in send_int_if_needed()
Clean up CamelCase names:
issueInterruptIfEmpty => issue_irq_if_empty
interruptHandle => irq_handle
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Tue, 30 Sep 2014 16:07:52 +0000 (12:07 -0400)]
staging: unisys: fix CamelCase names in struct uisqueue_info
Clean up CamelCase names:
Reserved1 => reserved1
Reserved2 => reserved2
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Tue, 30 Sep 2014 16:07:51 +0000 (12:07 -0400)]
staging: unisys: fix camelcase function uisqueue_InterlockedOr()
Clean up CamelCase names:
uisqueue_InterlockedOr => uisqueue_interlocked_or
Target => tgt
Set => set
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Tue, 30 Sep 2014 16:07:50 +0000 (12:07 -0400)]
staging: unisys: remove timskmodutils.h
Remove the entire timskmodutils.h file as it had a lot of checkpatch.pl
strict warnings and checks, and nearly all of the functions were not used
anywhere.
The unisys_spar_platform variable was moved to timskmod.h. References to the
removed timskmodutils.h were switched to timskmod.h instead. The unused
visor_seq_file_new_buffer() and visor_seq_file_done_buffer() functions defined
in timskmodutils.h were implemented in visorkmodutils.c, so these were removed
as well.
This patch will generate a warning about updating MAINTAINERS, but there does
not seem to be any need for that.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Tue, 30 Sep 2014 16:07:49 +0000 (12:07 -0400)]
staging: unisys: fix spacing in timskmod.h macro
Adds in some missing spaces in the max macro in timskmod.h.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Tue, 30 Sep 2014 16:07:48 +0000 (12:07 -0400)]
staging: unisys: remove stray blank line in timskmod.h
Just cleaning up the extra blank line from here.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Tue, 30 Sep 2014 16:07:47 +0000 (12:07 -0400)]
staging: unisys: remove unused locking functions in timskmod.h
Delete a block of unused locking functions from timskmod.h. These
functions generated a lot of checkpatch warnings and were not being used
anyhow.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Tue, 30 Sep 2014 16:07:46 +0000 (12:07 -0400)]
staging: unisys: remove typedef for PERIODIC_WORK
In periodic_work.h, remove the typedef PERIODIC_WORK and replace it with
struct periodic_work, and update functions used to manipulate the
structure to use the new name. The functions used to manipulate the
PERIODIC_WORK type are updated to use the fixed name, corrected for
clarity, and changed to not use periodic_work as the parameter's name.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Tue, 30 Sep 2014 16:07:45 +0000 (12:07 -0400)]
staging: unisys: delete extra blank lines in periodic_work.h
Remove the extra blank lines from before the first comment.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chen Gang [Thu, 2 Oct 2014 14:58:33 +0000 (22:58 +0800)]
drivers/staging/unisys: Let all IOMEM related modules depend on HAS_IOMEM
UNISYS_UISLIB, UNISYS_VISORCHIPSET, and UNISYS_VISORUTIL need HAS_IOMEM,
so depend on it. One of related error (with allmodconfig under um):
CC [M] drivers/staging/unisys/uislib/uislib.o
In file included from drivers/staging/unisys/uislib/uislib.c:34:0:
drivers/staging/unisys/include/uisutils.h: In function ‘dbg_ioremap_cache’:
drivers/staging/unisys/include/uisutils.h:88:2: error: implicit declaration of function ‘ioremap_cache’ [-Werror=implicit-function-declaration]
new = ioremap_cache(addr, size);
^
drivers/staging/unisys/include/uisutils.h:88:6: warning: assignment makes pointer from integer without a cast [enabled by default]
new = ioremap_cache(addr, size);
^
drivers/staging/unisys/include/uisutils.h: In function ‘dbg_ioremap’:
drivers/staging/unisys/include/uisutils.h:99:2: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration]
new = ioremap(addr, size);
^
drivers/staging/unisys/include/uisutils.h:99:6: warning: assignment makes pointer from integer without a cast [enabled by default]
new = ioremap(addr, size);
^
drivers/staging/unisys/include/uisutils.h: In function ‘dbg_iounmap’:
drivers/staging/unisys/include/uisutils.h:108:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
iounmap(addr);
^
Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Melike Yurtoglu [Thu, 2 Oct 2014 08:13:53 +0000 (11:13 +0300)]
staging: unisys: common-spar: Fix missing blank line warning
Fixes "Missing a blank line after declarations" checkpatch.pl warning
Signed-off-by: Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mahati Chamarthy [Mon, 29 Sep 2014 10:19:25 +0000 (15:49 +0530)]
Staging: unisys: Add missing blank line
This fixes the following checkpatch.pl warning:
WARNING: Missing a blank line after declarations
Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ebru Akagunduz [Wed, 1 Oct 2014 20:04:48 +0000 (23:04 +0300)]
staging: dgnc: Fix do not add new typedefs
This patch fixes "do not add new typedefs"
checkpatch.pl warning in dgnc_types.h
Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Yeliz Taneroglu [Tue, 30 Sep 2014 14:36:57 +0000 (17:36 +0300)]
staging: dgnc: Fix no spaces at the start of a line in dpacompat.h
The following patch the checkpatch.pl warning:
drivers/staging/dgnc/dpacompat.h:27 warning: please, no spaces at the start of a line
Signed-off-by: Yeliz Taneroglu <yeliztaneroglu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mahati Chamarthy [Mon, 29 Sep 2014 08:42:28 +0000 (14:12 +0530)]
Staging: dgnc: Add missing blank line
This fixes the following checkpatch.pl warning:
WARNING: Missing a blank line after declarations
Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mahati Chamarthy [Mon, 29 Sep 2014 08:40:41 +0000 (14:10 +0530)]
Staging: dgnc: Remove unnecessary braces
This fixes the following checkpatch.pl warnings:
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
projects / firefly-linux-kernel-4.4.55.git / log