H Hartley Sweeten [Fri, 30 Nov 2012 01:16:27 +0000 (18:16 -0700)]
staging: comedi: addi_apci_2032: absorb i_APCI2032_Reset()
This is the only 'reset' function used by the driver, remove it
from the boardinfo and absorb the code from hwdrv_apci2032.c into
the driver.
Rename the CamelCase function i_ADDI_Reset() to apci2032_reset().
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 30 Nov 2012 01:16:10 +0000 (18:16 -0700)]
staging: comedi: addi_apci_2032: remove unnecessary include
This include is no longer needed.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 30 Nov 2012 01:15:45 +0000 (18:15 -0700)]
staging: comedi: addi_apci_2032: remove eeprom support code
Reading the eeprom on the board supported by this driver is not
necessary. All the information required is in the boardinfo.
Remove the eeprom support code since it's not really interesting
or useful.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 30 Nov 2012 01:15:28 +0000 (18:15 -0700)]
staging: comedi: addi_apci_2032: board does not have analog inputs
The board supported by this driver does not have analog inputs. Remove
the subdevice init for it.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 30 Nov 2012 01:15:05 +0000 (18:15 -0700)]
staging: comedi: addi_apci_2032: board does not have analog outputs
The board supported by this driver does not have analog outputs. Remove
the subdevice init for it.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 30 Nov 2012 01:14:48 +0000 (18:14 -0700)]
staging: comedi: addi_apci_2032: board does not have digital inputs
The board supported by this driver does not have digital inputs. Remove
the subdevice init for it.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 30 Nov 2012 01:14:31 +0000 (18:14 -0700)]
staging: comedi: addi_apci_2032: board does not have ttl i/o
The board supported by this driver does not have ttl i/o. Remove the
subdevice init for it.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 30 Nov 2012 01:14:13 +0000 (18:14 -0700)]
staging: comedi: addi_apci_2032: separate from addi_common.c
This driver is for a simple 32 channel digital output board. Using the
addi-data "common" code introduces a lot of bloat.
Copy the code in addi_common.c to this driver and remove the #include
that caused addi_common.c to be compiled with this driver. This will
allow removing the bloat.
Rename the attach_pci and detach functions so they have namespace
associated with this driver.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Larry Finger [Tue, 27 Nov 2012 18:08:44 +0000 (12:08 -0600)]
staging: r8712u: Fix possible buffer overrun
In routine r8712_report_sec_ie(), the code could set the length
of the buffer to 256; however, that value is one larger than the
corresponding memory allocation.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shan Wei [Wed, 28 Nov 2012 02:54:31 +0000 (10:54 +0800)]
staging: gdm72xx: use %pI4 format to print IPv4 address and remove last usage of NIP6
commit
cf4ca4874fc45 removed the definition of NIPQUAD and NIPQUAD_FMT,
and NIP6 also is out of date.
commit
2874762b31d8d replace deprecated NIPQUAD marco to C code, but we can use %pI4 to
print IPv4 address more simply. And remove constant condition judge.
Because DEBUG_SDU is not defined in gdm_wimax.h, no error message when compiling.
Signed-off-by: Shan Wei <davidshan@tencent.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
YAMANE Toshiaki [Wed, 28 Nov 2012 13:21:07 +0000 (22:21 +0900)]
staging/rtl8187se: Fix spacing coding style in ieee80211/ieee80211_rx.c
The following warnings fixed.
- WARNING: please, no spaces at the start of a line
- WARNING: please, no space before tabs
Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
YAMANE Toshiaki [Wed, 28 Nov 2012 13:20:53 +0000 (22:20 +0900)]
staging/rtl8187se: Fix spacing coding style in ieee80211/ieee80211_rx.c
The following warnings fixed.
- WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
YAMANE Toshiaki [Wed, 28 Nov 2012 13:20:40 +0000 (22:20 +0900)]
staging/rtl8187se: Use netdev_ printks in ieee80211/ieee80211_rx.c
The following warnings fixed.
- WARNING: Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ...
- WARNING: Prefer netdev_warn(netdev, ... then dev_warn(dev, ... then pr_warn(... to printk(KERN_WARNING ...
- WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
YAMANE Toshiaki [Wed, 28 Nov 2012 13:20:27 +0000 (22:20 +0900)]
staging/rtl8187se: Fix spacing coding style in ieee80211/ieee80211_rx.c
The following errors fixed.
- ERROR: "foo* bar" should be "foo *bar"
Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
YAMANE Toshiaki [Wed, 28 Nov 2012 13:20:13 +0000 (22:20 +0900)]
staging/rtl8187se: Fix spacing coding style in ieee80211/ieee80211_rx.c
The following warnings fixed.
- ERROR: space required before the open parenthesis '('
- ERROR: that open brace { should be on the previous line
- ERROR: space required before the open brace '{'
- ERROR: else should follow close brace '}'
- ERROR: space prohibited before that close parenthesis ')'
Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
YAMANE Toshiaki [Wed, 28 Nov 2012 13:19:59 +0000 (22:19 +0900)]
staging/rtl8187se: Fix spacing coding style in ieee80211/ieee80211_rx.c
The following warnings fixed.
-- ERROR: space required after that ',' (ctx:VxV)
-- ERROR: spaces required around that '&&' (ctx:VxV)
-- ERROR: space prohibited before that '++' (ctx:WxO)
-- ERROR: spaces required around that '?' (ctx:VxV)
-- ERROR: spaces required around that ':' (ctx:VxV)
-- ERROR: spaces required around that '!=' (ctx:VxW)
-- ERROR: need consistent spacing around '-' (ctx:WxV)
-- ERROR: spaces required around that '=' (ctx:VxW)
-- ERROR: spaces required around that '||' (ctx:ExV)
Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
YAMANE Toshiaki [Wed, 28 Nov 2012 13:19:05 +0000 (22:19 +0900)]
staging/rtl8187se: Fix spacing coding style in ieee80211/ieee80211_rx.c
The following warnings fixed.
- WARNING: suspect code indent for conditional statements
Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
YAMANE Toshiaki [Wed, 28 Nov 2012 13:15:50 +0000 (22:15 +0900)]
staging/rtl8187se: Fix include file issue in ieee80211/ieee80211_rx.c
The following warning fixed.
- WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
YAMANE Toshiaki [Tue, 27 Nov 2012 12:10:14 +0000 (21:10 +0900)]
staging/rtl8187se: Use netdev_ printks in ieee80211/ieee80211_softmac_wx.c
The following warning fixed.
- WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
YAMANE Toshiaki [Tue, 27 Nov 2012 12:10:00 +0000 (21:10 +0900)]
staging/rtl8187se: Fix spacing coding style in ieee80211/ieee80211_softmac_wx.c
The following wanings fixed.
- WARNING: please, no spaces at the start of a line
Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
YAMANE Toshiaki [Tue, 27 Nov 2012 12:09:46 +0000 (21:09 +0900)]
staging/rtl8187se: Fix spacing coding style in ieee80211/ieee80211_softmac_wx.c
The following errors fixed.
- ERROR: spaces required around that '=' (ctx:VxV)
Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
YAMANE Toshiaki [Tue, 27 Nov 2012 12:09:31 +0000 (21:09 +0900)]
staging/rtl8187se: Fix spacing coding style in ieee80211/ieee80211_softmac_wx.c
The following wanings fixed.
- WARNING: braces {} are not necessary for any arm of this statement
Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
YAMANE Toshiaki [Tue, 27 Nov 2012 12:09:16 +0000 (21:09 +0900)]
staging/rtl8187se: Fix spacing coding style in ieee80211/ieee80211_softmac_wx.c
The following errors fixed.
- ERROR: space prohibited after that ',' (ctx:WxW)
Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
YAMANE Toshiaki [Tue, 27 Nov 2012 12:09:02 +0000 (21:09 +0900)]
staging/rtl8187se: Fix spacing coding style in ieee80211/ieee80211_softmac_wx.c
The following warnings fixed.
- WARNING: suspect code indent for conditional statements
Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
YAMANE Toshiaki [Tue, 27 Nov 2012 12:08:47 +0000 (21:08 +0900)]
staging/rtl8187se: Fix spacing coding style in ieee80211/ieee80211_softmac_wx.c
The following errors fixed.
- ERROR: space required before the open brace '{'
- ERROR: space required before the open parenthesis '('
- ERROR: space prohibited before that close parenthesis ')'
- ERROR: space required after that close brace '}'
Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
YAMANE Toshiaki [Tue, 27 Nov 2012 12:07:45 +0000 (21:07 +0900)]
staging/rtl8187se: Fix spacing coding style in ieee80211/ieee80211_softmac_wx.c
The following errors fixed.
- ERROR: space prohibited after that '&' (ctx:WxW)
Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ben Chan [Tue, 27 Nov 2012 04:18:45 +0000 (20:18 -0800)]
staging: gdm72xx: fix unused variable warning in gdm_usb_send
This patch fixes an unused variable warning in gdm_usb_send
(when CONFIG_WIMAX_GDM72XX_K_MODE=n), which was introduced in
commit
1a276b80466bbd195cf94ec7178f68f2ab351467 (staging:
gdm72xx: protect access of rx / tx structs).
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Ben Chan <benchan@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Peter Hurley [Tue, 27 Nov 2012 14:30:45 +0000 (09:30 -0500)]
staging/fwserial: Fix build breakage when !CONFIG_BUG
Use WARN() as intended.
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Tue, 27 Nov 2012 00:34:29 +0000 (17:34 -0700)]
staging: comedi: remove unnecessary '#define __NO_VERSION__'
This define is no longer required for multi-file modules.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Tue, 27 Nov 2012 00:34:11 +0000 (17:34 -0700)]
staging: comedi: remove unnecessary '#define _GNU_SOURCE'
This define is not needed.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 24 Nov 2012 14:56:09 +0000 (14:56 +0000)]
staging: vt6656: wpa_set_keys remove fcpfkernel
Only TRUE is ever called, remove FALSE code.
Since copy_from_user has been removed, the unlock..lock spin locks have been removed.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 24 Nov 2012 14:53:07 +0000 (14:53 +0000)]
staging: vt6656: send SIOCGIWSCAN at end of all scanning events.
wpa supplicant can become confused if the scanning has ended on
active scanning.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 24 Nov 2012 14:50:00 +0000 (14:50 +0000)]
staging: vt6656: extend wireless definitions to v22
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 24 Nov 2012 14:47:11 +0000 (14:47 +0000)]
staging: vt6656: remove redundant IWEVCUSTOM events.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 24 Nov 2012 14:44:29 +0000 (14:44 +0000)]
staging: vt6656: cleanup of device_ioctl/net_device_stats
Also remove IOCTL_CMD_TEST.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 24 Nov 2012 14:40:57 +0000 (14:40 +0000)]
staging: vt6656: dead code remove ioctl.c/h
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 24 Nov 2012 14:36:12 +0000 (14:36 +0000)]
staging: vt6656: dead code removal : wpactl.c/h
Relates to redundant viawget, a proprietary version of wpa supplicant.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 24 Nov 2012 14:24:24 +0000 (14:24 +0000)]
staging: vt6656: remove wpahdr from driver.
wpahdr relates to redundant viawget, a proprietary version of wpa supplicant.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 24 Nov 2012 14:22:08 +0000 (14:22 +0000)]
staging: vt6656: move move all commands to iw_handler.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 24 Nov 2012 14:19:34 +0000 (14:19 +0000)]
staging: vt6656: fix headers and add cfg80211.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Masanari Iida [Thu, 22 Nov 2012 15:47:54 +0000 (00:47 +0900)]
staging:
ced1401: Fix typo in staging/
ced1401
Correct spelling typo in comments within staging/
ced1401
Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matt Phillips [Mon, 26 Nov 2012 05:53:21 +0000 (23:53 -0600)]
staging: comedi: ni_tio.h fixed coding style issue with pointer variables
Fixed coding style issues with pointers
Signed-off-by: Matt Phillips <mathewrphillips@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ben Chan [Sun, 25 Nov 2012 03:35:36 +0000 (19:35 -0800)]
staging: gdm72xx: protect access of rx / tx structs
This patch applies spinlock to protect access to rx / tx structs in
certain call sites, which fixes the following crash in gdm_suspend.
It also fixes usb_set_intfdata() in gdm_usb_probe to avoid setting an
already freed phy_dev.
<5>[ 4996.815018] [<
7f0074b0>] (gdm_suspend+0x1c/0x2b4 [gdmwm]) from [<
803020a4>] (usb_suspend_both+0x80/0x1a0)
<5>[ 4996.815055] [<
803020a4>] (usb_suspend_both+0x80/0x1a0) from [<
80302c84>] (usb_runtime_suspend+0x38/0x64)
<5>[ 4996.815089] [<
80302c84>] (usb_runtime_suspend+0x38/0x64) from [<
802becc0>] (__rpm_callback+0x48/0x78)
<5>[ 4996.815118] [<
802becc0>] (__rpm_callback+0x48/0x78) from [<
802bf8dc>] (rpm_suspend+0x394/0x5ec)
<5>[ 4996.815145] [<
802bf8dc>] (rpm_suspend+0x394/0x5ec) from [<
802c0550>] (pm_runtime_work+0x8c/0xa4)
<5>[ 4996.815177] [<
802c0550>] (pm_runtime_work+0x8c/0xa4) from [<
800456cc>] (process_one_work+0x264/0x438)
<5>[ 4996.815209] [<
800456cc>] (process_one_work+0x264/0x438) from [<
80045acc>] (worker_thread+0x22c/0x3b8)
<5>[ 4996.815239] [<
80045acc>] (worker_thread+0x22c/0x3b8) from [<
8004a43c>] (kthread+0x9c/0xa8)
<5>[ 4996.815270] [<
8004a43c>] (kthread+0x9c/0xa8) from [<
8000f160>] (kernel_thread_exit+0x0/0x8)
<0>[ 4996.815295] Code:
e92d4000 e8bd4000 e2800020 eb4ab9a1 (
e5905000)
Signed-off-by: Ben Chan <benchan@chromium.org>
Signed-off-by: Sameer Nanda <snanda@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Devendra Naga [Sat, 24 Nov 2012 10:01:06 +0000 (05:01 -0500)]
staging: ft1000: remove assigments of ret and initialise it in beginning
as ret is every time assigned to EINVAL in fail cases, initialise it at
the beginning.
Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:25 +0000 (20:49 +0100)]
staging: line6: drop unused dumprequest code
The line6 drive no longer requests MIDI dumps from the device so
dumprequest.c is not needed.
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:24 +0000 (20:49 +0100)]
staging: line6: drop dump requests from pod startup
The pod startup procedure dumps model data. This is no longer useful
since the sysfs attrs which expose this information to userspace have
been removed. The dump request wasn't been processed anymore.
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:23 +0000 (20:49 +0100)]
staging: line6: drop dump requests from variax startup
The variax startup procedure dumps model data. This is no longer useful
since the sysfs attrs which expose this information to userspace have
been removed. The dump request wasn't been processed anymore.
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:22 +0000 (20:49 +0100)]
staging: line6: drop variax model_data field
The sysfs attrs to access the model dump have been removed so it's safe
to drop the model_data field. The next step will be to simplify the
startup process since we no longer need to fetch this data via dump
requests, but that will be done in a later patch.
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:21 +0000 (20:49 +0100)]
staging: line6: drop unused pod atomic_flags field
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:20 +0000 (20:49 +0100)]
staging: line6: drop pod prog_data buffers
The driver no longer keeps state of MIDI-accessible device parameters.
Drop the buffers but be careful to keep the device startup procedure
working even though we no longer store the contents of the dump request.
The startup procedure will be simplified in a later patch.
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:19 +0000 (20:49 +0100)]
staging: line6: drop MIDI parameter sysfs attrs
Both pod.c and variax.c expose the device's MIDI parameters as sysfs
attrs. Knowledge of MIDI constants should be in userspace, not in the
driver. Drop the sysfs attrs and let userspace interpret parameters it
cares about instead.
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:18 +0000 (20:49 +0100)]
staging: line6: drop amp/effects dump request triggers
Since the driver no longer needs to keep state of device parameters it
is no longer necessary to refresh state when messages that affect other
parameters are sent. Drop the code to trigger a dump when amp/effects
are changed.
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:17 +0000 (20:49 +0100)]
staging: line6: drop CONFIG_LINE6_USB_RAW
Now that both pod.c and variax.c have removed their raw sysfs attrs, the
CONFIG_LINE6_USB_RAW config option can be dropped. The drivers are
being stripped down to just PCM and MIDI I/O so there is less state and
filtering. Therefore it's no longer necessary to have a special sysfs
attr to bypass the filtering ("raw").
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:16 +0000 (20:49 +0100)]
staging: line6: drop variax raw sysfs attrs
Note that VARIAX_SYSEX_ACTIVATE was never used so drop it along with the
other VARIAX_SYSEX_* constants which are now unused.
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:15 +0000 (20:49 +0100)]
staging: line6: drop variax guitar sysfs attr
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:14 +0000 (20:49 +0100)]
staging: line6: drop variax active sysfs attr
The get_string() function has no other callers so remove it too.
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:13 +0000 (20:49 +0100)]
staging: line6: drop variax dump sysfs attr
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:12 +0000 (20:49 +0100)]
staging: line6: drop variax bank sysfs attr
The get_string() function is no longer used so drop it too.
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:11 +0000 (20:49 +0100)]
staging: line6: drop variax name sysfs attr
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:10 +0000 (20:49 +0100)]
staging: line6: drop variax tone sysfs attr
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:09 +0000 (20:49 +0100)]
staging: line6: drop variax volume sysfs attr
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:08 +0000 (20:49 +0100)]
staging: line6: drop variax model sysfs attr
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:07 +0000 (20:49 +0100)]
staging: line6: drop tuner param filtering
The pod_set_system_param_int() helper function is only used to set the
monitor level. Previously it was also used to control the tuner and has
special checks. These checks can now be dropped, along with the tuner
constants.
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:06 +0000 (20:49 +0100)]
staging: line6: drop pod.c raw sysfs attr
The raw sysfs attr transmits MIDI messages with less filtering. This
was a useful debugging tool while the staging driver still had a lot of
state and filtering. It is not useful anymore since the filtering is
being dropped.
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:05 +0000 (20:49 +0100)]
staging: line6: drop midi_postprocess flag
It is no longer necessary to trigger on MIDI transmit messages that will
change the state of the device since:
1. We've dropped the midi_postprocess sysfs attr in a previous commit so
it is not possible to activate this feature anymore.
2. The other sysfs attrs that could inspect the state after a dump
request have been dropped.
Therefore we can safely remove this dead code.
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:04 +0000 (20:49 +0100)]
staging: line6: drop midi_mask_transmit
The midi_mask_transmit sysfs attribute selects the MIDI channels on
which to transmit messages. If ALSA wants to transmit a message that
does not match an allowed channel, the message will be dropped. This
driver feature is not really used and applications don't know how to
take advantage of it. Therefore we drop it and rely on applications or
MIDI sequencers to select the channels used for communication.
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:03 +0000 (20:49 +0100)]
staging: line6: drop midi_mask_receive
The midi_mask_receive sysfs attribute selects the MIDI channels on which
to receive messages. There is no need to do this at the driver level,
instead the MIDI application endpoints decide which channels to use.
Other drivers don't implement midi_mask_receive so applications cannot
make use of this feature. Therefore we drop it as part of the effort to
clean up the staging driver.
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:02 +0000 (20:49 +0100)]
staging: line6: drop midi_postprocess sysfs attr
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:01 +0000 (20:49 +0100)]
staging: line6: drop finish sysfs attr
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:00 +0000 (20:49 +0100)]
staging: line6: drop tuner_pitch sysfs attr
Dropping this final tuner sysfs attr also leaves the
POD_GET_SYSTEM_PARAM() macro, pod_get_system_param_string(), and
pod_get_system_param_int() unused. Remove them immediately to avoid
compiler warnings.
POD_monitor_level is now the only SYSEX value that needs to be watched
by the driver since the ALSA volume control should reflect the current
monitor volume level used by the device. Therefore, drop the switch
statement entirely and just check for POD_monitor_level, ignoring
unknown system parameter changes.
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:48:59 +0000 (20:48 +0100)]
staging: line6: drop tuner_mute sysfs attr
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:48:58 +0000 (20:48 +0100)]
staging: line6: drop tuner_note sysfs attr
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:48:57 +0000 (20:48 +0100)]
staging: line6: drop tuner_freq sysfs attr
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:48:56 +0000 (20:48 +0100)]
staging: line6: drop routing sysfs attr
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:48:55 +0000 (20:48 +0100)]
staging: line6: drop store_effects_setup sysfs attr
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:48:54 +0000 (20:48 +0100)]
staging: line6: drop store_channel sysfs attr
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:48:53 +0000 (20:48 +0100)]
staging: line6: drop store_amp_setup sysfs attr
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:48:52 +0000 (20:48 +0100)]
staging: line6: drop retrieve_effects_setup sysfs attr
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:48:51 +0000 (20:48 +0100)]
staging: line6: drop retrieve_channel sysfs attr
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:48:50 +0000 (20:48 +0100)]
staging: line6: drop retrieve_amp_setup sysfs attr
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:48:49 +0000 (20:48 +0100)]
staging: line6: drop name_buf sysfs attr
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:48:48 +0000 (20:48 +0100)]
staging: line6: drop name sysfs attr
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:48:47 +0000 (20:48 +0100)]
staging: line6: change monitor_level type ValueWait -> int
The monitor_level sysfs attr has been dropped and we never need to wait
on the monitor_level value to change. Switch to a plain int and drop
the wait queue.
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:48:46 +0000 (20:48 +0100)]
staging: line6: drop monitor_level sysfs attr
The monitor level can be adjusted using an ALSA volume control.
Therefore the sysfs attribute is unnecessary. Note that we leave the
monitor_level driver variable so that the ALSA volume control still
works.
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:48:45 +0000 (20:48 +0100)]
staging: line6: drop dump_buf sysfs attr
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:48:44 +0000 (20:48 +0100)]
staging: line6: drop dump sysfs attr
Once further sysfs attrs have been removed it will also be possible to
drop prog_data and other pieces which we keep for now.
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:48:43 +0000 (20:48 +0100)]
staging: line6: drop dirty sysfs attr
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:48:42 +0000 (20:48 +0100)]
staging: line6: drop unused param_dirty bitmap
The param_dirty bitmap tracks which parameters have been modified since
saving a preset. The bitmap is never used though so we can drop this
deadcode.
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:48:41 +0000 (20:48 +0100)]
staging: line6: drop clip sysfs attr
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stefan Hajnoczi [Thu, 22 Nov 2012 19:48:40 +0000 (20:48 +0100)]
staging: line6: drop channel sysfs attr
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Mon, 26 Nov 2012 00:29:03 +0000 (19:29 -0500)]
Staging: bcm: Remove typedef for _U_MIBS_IP_ADDRESS and call directly.
This patch removes typedef for _U_MIBS_IP_ADDRESS, and
changes the name of the union to bcm_mibs_ip_addr.
In addition, any calls to typedef U_MIBS_IP_ADDRESS are
changed to call the union directly.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Mon, 26 Nov 2012 00:29:02 +0000 (19:29 -0500)]
Staging: bcm: Remove typedef for _S_MIBS_HOST_INFO and call directly.
This patch removes typedef for _S_MIBS_HOST_INFO, and
changes the name of the struct to bcm_mibs_host_info.
In addition, any calls to typedef S_MIBS_HOST_INFO are
changed to call the struct directly.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Mon, 26 Nov 2012 00:29:01 +0000 (19:29 -0500)]
Staging: bcm: Remove typedef for _S_MIBS_CLASSIFIER_RULE and call directly.
This patch removes typedef for _S_MIBS_CLASSIFIER_RULE, and
changes the name of the struct to bcm_mibs_classifier_rule.
In addition, any calls to typedef S_MIBS_CLASSIFIER_RULE are
changed to call the struct directly.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Mon, 26 Nov 2012 00:29:00 +0000 (19:29 -0500)]
Staging: bcm: Remove typedef for _S_MIBS_PHS_RULE and call directly.
This patch removes typedef for _S_MIBS_PHS_RULE,
and changes the name of the struct to bcm_mibs_phs_rule.
In addition, any calls to typedef S_MIBS_PHS_RULE are
changed to call the struct directly.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Mon, 26 Nov 2012 00:28:59 +0000 (19:28 -0500)]
Staging: bcm: Remove typedef for _S_MIBS_EXTSERVICEFLOW_PARAMETERS and call directly.
This patch removes typedef for _S_MIBS_EXTSERVICEFLOW_PARAMETERS,
and changes the name of the struct to bcm_mibs_parameters. In
addition, any calls to typedef S_MIBS_EXTSERVICEFLOW_PARAMETERS
are changed to call the struct directly.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Mon, 26 Nov 2012 00:28:58 +0000 (19:28 -0500)]
Staging: bcm: Remove typedef for _S_MIBS_SERVICEFLOW_TABLE and call directly.
This patch removes typedef for _S_MIBS_SERVICEFLOW_TABLE,
and changes the name of the struct to bcm_mibs_table.
In addition, any calls to typedef S_MIBS_SERVICEFLOW_TABLE
are changed to call the struct directly.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Mon, 26 Nov 2012 00:28:57 +0000 (19:28 -0500)]
Staging: bcm: Remove typedef for _S_MIBS_DROPPED_APP_CNTRL_MESSAGES and call directly.
This patch removes typedef for
_S_MIBS_DROPPED_APP_CNTRL_MESSAGES, and
changes the name of the struct to
bcm_mibs_dropped_cntrl_msg.
In addition, any calls to typedef
S_MIBS_DROPPED_APP_CNTRL_MESSAGES
are changed to call the struct directly.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Mon, 26 Nov 2012 00:28:56 +0000 (19:28 -0500)]
Staging: bcm: Remove typedef for _S_MIBS_HOST_STATS_MIBS and call directly.
This patch removes typedef for _S_MIBS_HOST_STATS_MIBS,
and changes the name of the struct to bcm_host_stats_mibs.
In addition, any calls to typedefs S_MIBS_HOST_STATS_MIBS
are changed to call the struct directly.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Mon, 26 Nov 2012 00:28:55 +0000 (19:28 -0500)]
Staging: bcm: Replace LARGE_INTEGER with u64 in HostMIBSInterface.h
This patch replaces "LARGE_INTEGER" with "u64"
in HostMIBSInterface.h
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Mon, 26 Nov 2012 00:28:54 +0000 (19:28 -0500)]
Staging: bcm: Replace BOOLEAN with bool in HostMIBSInterface.h
This patch replaces "BOOLEAN" with "bool"
in HostMIBSInterface.h
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>