Jakob Stoklund Olesen [Thu, 9 Aug 2012 22:49:46 +0000 (22:49 +0000)]
Partition use lists so defs always come before uses.
This makes it possible to speed up def_iterator by stopping at the first
use. This makes def_empty() and getUniqueVRegDef() much faster when
there are many uses.
In a +Asserts build, LiveVariables is 100x faster in one case because
getVRegDef() has an assertion that would scan to the end of a
def_iterator chain.
Spill weight calculation is significantly faster (300x in one case)
because isTriviallyReMaterializable() calls MRI->isConstantPhysReg(%RIP)
which calls def_empty(%RIP).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161634
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Thu, 9 Aug 2012 22:49:42 +0000 (22:49 +0000)]
Don't use pointer-pointers for the register use lists.
Use a more conventional doubly linked list where the Prev pointers form
a cycle. This means it is no longer necessary to adjust the Prev
pointers when reallocating the VRegInfo array.
The test changes are required because the register allocation hint is
using the use-list order to break ties.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161633
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Thu, 9 Aug 2012 22:49:37 +0000 (22:49 +0000)]
Move use list management into MachineRegisterInfo.
Register MachineOperands are kept in linked lists accessible via MRI's
reg_iterator interfaces. The linked list management was handled partly
by MachineOperand methods, partly by MRI methods.
Move all of the list management into MRI, delete
MO::AddRegOperandToRegInfo() and MO::RemoveRegOperandFromRegInfo().
Be more explicit about handling the cases where an MRI pointer isn't
available.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161632
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Thu, 9 Aug 2012 22:10:21 +0000 (22:10 +0000)]
Remove getARMRegisterNumbering and replace with calls into
the register info for getEncodingValue. This builds on the
small patch of yesterday to set HWEncoding in the register
file.
One (deprecated) use was turned into a hard number to avoid
needing register info in the old JIT.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161628
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Thu, 9 Aug 2012 22:08:26 +0000 (22:08 +0000)]
Fix a future TwoAddressInstructionPass crash.
No test case, the crash only happens when the default use list order is
changed.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161627
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Thu, 9 Aug 2012 22:08:24 +0000 (22:08 +0000)]
Don't modify MO while use_iterator is still pointing to it.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161626
91177308-0d34-0410-b5e6-
96231b3b80d8
Chad Rosier [Thu, 9 Aug 2012 22:04:55 +0000 (22:04 +0000)]
[ms-inline asm] Extend the MC AsmParser API to match MCInsts (but not emit).
This new API will be used by clang to parse ms-style inline asms.
One goal of this project is to use this style of inline asm for targets other
then x86. Therefore, this API needs to be implemented for non-x86 targets at
some point in the future.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161624
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Thu, 9 Aug 2012 20:26:41 +0000 (20:26 +0000)]
Teach the LLVM test makefile to run the extra Clang tools' test suites
as part of check-all.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161610
91177308-0d34-0410-b5e6-
96231b3b80d8
Jack Carter [Thu, 9 Aug 2012 19:43:18 +0000 (19:43 +0000)]
Another 32 to 64 bit sign extension bug.
The fields in the td definition were switched.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161607
91177308-0d34-0410-b5e6-
96231b3b80d8
Arnold Schwaighofer [Thu, 9 Aug 2012 15:25:52 +0000 (15:25 +0000)]
Patch to implement UMLAL/SMLAL instructions for the ARM architecture
This patch corrects the definition of umlal/smlal instructions and adds support
for matching them to the ARM dag combiner.
Bug 12213
Patch by Yin Ma!
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161581
91177308-0d34-0410-b5e6-
96231b3b80d8
Nadav Rotem [Thu, 9 Aug 2012 01:56:44 +0000 (01:56 +0000)]
Fix the legalization of ExtLoad on ARM. ExpandUnalignedLoad did not properly
handle the cases where the memory value type was illegal.
PR 13111.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161565
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Thu, 9 Aug 2012 01:39:32 +0000 (01:39 +0000)]
This field isn't used anymore, use it with HWEncoding instead.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161564
91177308-0d34-0410-b5e6-
96231b3b80d8
Victor Oliveira [Thu, 9 Aug 2012 01:13:59 +0000 (01:13 +0000)]
Support for experimental targets
Added LLVM_EXPERIMENTAL_TARGETS_TO_BUILD in CMake and --enable-experimental-targets in configure.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161561
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Beaumont-Gay [Thu, 9 Aug 2012 00:30:39 +0000 (00:30 +0000)]
MachineRegisterInfo was already a friend of MachineOperand, and GCC complains
about repeated friending.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161553
91177308-0d34-0410-b5e6-
96231b3b80d8
Jim Grosbach [Wed, 8 Aug 2012 23:56:06 +0000 (23:56 +0000)]
Move [SU]LEB128 encoding to a utility header.
These functions are very generic. There's no reason for them to
be tied to MCObjectWriter.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161545
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Wed, 8 Aug 2012 23:44:07 +0000 (23:44 +0000)]
Move getNextOperandForReg() into MachineRegisterInfo.
MRI provides iterators for traversing the use-def chains. They should
not be accessible from anywhere else.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161543
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Wed, 8 Aug 2012 23:44:04 +0000 (23:44 +0000)]
Don't use getNextOperandForReg().
This way of using getNextOperandForReg() was unlikely to work as
intended. We don't give any guarantees about the order of operands in
the use-def chains, so looking only at operands following a given
operand in the chain doesn't make sense.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161542
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Wed, 8 Aug 2012 23:44:01 +0000 (23:44 +0000)]
Don't use getNextOperandForReg() in RAFast.
That particular optimization was probably premature anyway.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161541
91177308-0d34-0410-b5e6-
96231b3b80d8
Owen Anderson [Wed, 8 Aug 2012 23:31:14 +0000 (23:31 +0000)]
Allow legalization of target-specific SDNodes, provided that the target itself provide a legalization hook for them.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161536
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Wed, 8 Aug 2012 22:12:01 +0000 (22:12 +0000)]
Deal with irreducible control flow when building traces.
We filter out MachineLoop back-edges during the trace-building PO
traversals, but it is possible to have CFG cycles that aren't natural
loops, and MachineLoopInfo doesn't include such cycles.
Use a standard visited set to detect such CFG cycles, and completely
ignore them when picking traces.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161532
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Wed, 8 Aug 2012 22:03:50 +0000 (22:03 +0000)]
Remove some coding violations. No functionality change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161530
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Wed, 8 Aug 2012 22:01:55 +0000 (22:01 +0000)]
Cache a commonly used reference.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161529
91177308-0d34-0410-b5e6-
96231b3b80d8
Bob Wilson [Wed, 8 Aug 2012 20:31:37 +0000 (20:31 +0000)]
Add test triples to fix win32 failures. Revert workaround from r161292.
I don't have a win32 system to test, so hopefully I got them all fixed here.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161519
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Wed, 8 Aug 2012 18:37:39 +0000 (18:37 +0000)]
Remove OpenBSD defines:
- The defines are in stddint.h, which is #include'd already.
- The block wasn't used anyway, since it was _OpenBSD_, and not __OpenBSD__
Patch by David Hill!
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161515
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Wed, 8 Aug 2012 18:24:23 +0000 (18:24 +0000)]
Heed -stress-early-ifcvt.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161513
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Wed, 8 Aug 2012 18:19:58 +0000 (18:19 +0000)]
Get the MispredictPenalty from MCSchedModel.
Thanks, Andy!
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161507
91177308-0d34-0410-b5e6-
96231b3b80d8
Sebastian Pop [Wed, 8 Aug 2012 18:04:45 +0000 (18:04 +0000)]
revert my previous patch
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161505
91177308-0d34-0410-b5e6-
96231b3b80d8
Sebastian Pop [Wed, 8 Aug 2012 17:45:43 +0000 (17:45 +0000)]
enable Hexagon target from cmake
This patch allows us to use cmake to specify a cross compiler for Hexagon.
In particular, the patch adds a missing case for the target Hexagon in
cmake/config-ix.cmake, and it moves LLVM_DEFAULT_TARGET_TRIPLE and TARGET_TRIPLE
variables from cmake/config-ix.cmake to the toplevel CMakeLists.txt to make them
available at configure time. Here is the command line that I have used to test
my patches:
$ cmake -G Ninja -D BUILD_SHARED_LIBS:BOOL=ON -D LLVM_TARGETS_TO_BUILD:STRING=Hexagon -D TARGET_TRIPLE:STRING=hexagon-unknown-linux-gnu -D LLVM_DEFAULT_TARGET_TRIPLE:STRING=hexagon-unknown-linux-gnu -D LLVM_TARGET_ARCH:STRING=hexagon-unknown-linux-gnu -D LLVM_ENABLE_PIC:BOOL=OFF ..
$ ninja check
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161504
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Wed, 8 Aug 2012 14:51:03 +0000 (14:51 +0000)]
Typedefs and indentation fixes from the Andy Zhang/PAX macro argument patch.
Committing it first as it makes the "real" patch a lot easier to read.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161491
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Wed, 8 Aug 2012 13:27:04 +0000 (13:27 +0000)]
llvm/test/MC/COFF/seh.s: Fixup corresponding to r161487.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161489
91177308-0d34-0410-b5e6-
96231b3b80d8
Anton Korobeynikov [Wed, 8 Aug 2012 12:46:46 +0000 (12:46 +0000)]
Fix for .pdata and .xdata section attributes on COFF.
Patch by kai@redstar.de !
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161487
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Wed, 8 Aug 2012 08:21:24 +0000 (08:21 +0000)]
Sphinxify the CommandLine document.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161479
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Wed, 8 Aug 2012 06:42:30 +0000 (06:42 +0000)]
Move header so that it can be picked up by other .rst files.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161478
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Wed, 8 Aug 2012 06:30:30 +0000 (06:30 +0000)]
Add `.pushsection', `.popsection', and `.previous' directives to Darwin ASM.
There are situations where inline ASM may want to change the section -- for
instance, to create a variable in the .data section. However, it cannot do this
without (potentially) restoring to the wrong section. E.g.:
asm volatile (".section __DATA, __data\n\t"
".globl _fnord\n\t"
"_fnord: .quad 1f\n\t"
".text\n\t"
"1:" :::);
This may be wrong if this is inlined into a function that has a "section"
attribute. The user should use `.pushsection' and `.popsection' here instead.
The addition of `.previous' is added for completeness.
<rdar://problem/
12048387>
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161477
91177308-0d34-0410-b5e6-
96231b3b80d8
Andrew Trick [Wed, 8 Aug 2012 02:44:16 +0000 (02:44 +0000)]
Added MispredictPenalty to SchedMachineModel.
This replaces an existing subtarget hook on ARM and allows standard
CodeGen passes to potentially use the property.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161471
91177308-0d34-0410-b5e6-
96231b3b80d8
Andrew Trick [Wed, 8 Aug 2012 02:44:11 +0000 (02:44 +0000)]
Minor cleanup of defaultDefLatency API
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161470
91177308-0d34-0410-b5e6-
96231b3b80d8
Andrew Trick [Wed, 8 Aug 2012 02:44:08 +0000 (02:44 +0000)]
whitespace
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161469
91177308-0d34-0410-b5e6-
96231b3b80d8
Eli Friedman [Wed, 8 Aug 2012 02:17:32 +0000 (02:17 +0000)]
isAllocLikeFn is allowed to return true for functions which read memory; make
sure we account for that correctly in DeadStoreElimination. Fixes a regression
from r158919. PR13547.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161468
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Wed, 8 Aug 2012 01:10:31 +0000 (01:10 +0000)]
Revert "Fix a quadratic algorithm in MachineBranchProbabilityInfo."
It caused an assertion failure when compiling consumer-typeset.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161463
91177308-0d34-0410-b5e6-
96231b3b80d8
Manman Ren [Wed, 8 Aug 2012 00:51:41 +0000 (00:51 +0000)]
X86: enable CSE between CMP and SUB
We perform the following:
1> Use SUB instead of CMP for i8,i16,i32 and i64 in ISel lowering.
2> Modify MachineCSE to correctly handle implicit defs.
3> Convert SUB back to CMP if possible at peephole.
Removed pattern matching of (a>b) ? (a-b):0 and like, since they are handled
by peephole now.
rdar://
11873276
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161462
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Wed, 8 Aug 2012 00:40:47 +0000 (00:40 +0000)]
Don't scan physreg use-def chains looking for a PIC base.
We can't rematerialize a PIC base after register allocation anyway, and
scanning physreg use-def chains is very expensive in a function with
many calls.
<rdar://problem/
12047515>
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161461
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Wed, 8 Aug 2012 00:20:37 +0000 (00:20 +0000)]
Fix a quadratic algorithm in MachineBranchProbabilityInfo.
The getSumForBlock function was quadratic in the number of successors
because getSuccWeight would perform a linear search for an already known
iterator.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161460
91177308-0d34-0410-b5e6-
96231b3b80d8
Dan Gohman [Wed, 8 Aug 2012 00:00:26 +0000 (00:00 +0000)]
Avoid recomputing the unique exit blocks and their insert points when doing
multiple scalar promotions on a single loop. This also has the effect of
preserving the order of stores sunk out of loops, which is aesthetically
pleasing, and it happens to fix the testcase in PR13542, though it doesn't
fix the underlying problem.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161459
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Tue, 7 Aug 2012 22:47:06 +0000 (22:47 +0000)]
Skip tied operand pairs that already have the same register.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161454
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Tue, 7 Aug 2012 22:37:05 +0000 (22:37 +0000)]
Add SelectionDAG::getTargetIndex.
This adds support for TargetIndex operands during isel. The meaning of
these (index, offset, flags) operands is entirely defined by the target.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161453
91177308-0d34-0410-b5e6-
96231b3b80d8
Bob Wilson [Tue, 7 Aug 2012 22:35:16 +0000 (22:35 +0000)]
Fix a serious typo in InstCombine's optimization of comparisons.
An unsigned value converted to floating-point will always be greater than
a negative constant. Unfortunately InstCombine reversed the check so that
unsigned values were being optimized to always be greater than all positive
floating-point constants. <rdar://problem/
12029145>
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161452
91177308-0d34-0410-b5e6-
96231b3b80d8
Evan Cheng [Tue, 7 Aug 2012 22:21:00 +0000 (22:21 +0000)]
X86 cmp lowering is looking past truncate on the condition node. It should only
do so when the high bits are known zero. This caused a subtle miscompilation.
rdar://
12027825
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161451
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Tue, 7 Aug 2012 20:59:05 +0000 (20:59 +0000)]
For non-Darwin platforms, we want to generate stack protectors only for
character arrays. This is in line with what GCC does.
<rdar://problem/
10529227>
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161446
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Tue, 7 Aug 2012 18:56:39 +0000 (18:56 +0000)]
Add a new kind of MachineOperand: MO_TargetIndex.
A target index operand looks a lot like a constant pool reference, but
it is completely target-defined. It contains the 8-bit TargetFlags, a
32-bit index, and a 64-bit offset. It is preserved by all code generator
passes.
TargetIndex operands can be used to carry target-specific information in
cases where immediate operands won't suffice.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161441
91177308-0d34-0410-b5e6-
96231b3b80d8
Andrew Kaylor [Tue, 7 Aug 2012 18:33:00 +0000 (18:33 +0000)]
Enable lazy compilation in MCJIT
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161438
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Tue, 7 Aug 2012 18:32:57 +0000 (18:32 +0000)]
Fix a couple of typos.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161437
91177308-0d34-0410-b5e6-
96231b3b80d8
Eli Friedman [Tue, 7 Aug 2012 18:06:01 +0000 (18:06 +0000)]
Remove empty directory.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161434
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Tue, 7 Aug 2012 18:02:19 +0000 (18:02 +0000)]
Add trace accessor methods, implement primitive if-conversion heuristic.
Compare the critical paths of the two traces through an if-conversion
candidate. If the difference is larger than the branch brediction
penalty, reject the if-conversion. If would never pay.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161433
91177308-0d34-0410-b5e6-
96231b3b80d8
Jim Grosbach [Tue, 7 Aug 2012 17:53:14 +0000 (17:53 +0000)]
Tidy up a bit.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161430
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Tue, 7 Aug 2012 17:30:46 +0000 (17:30 +0000)]
The dominance computation already has logic for computing if an edge dominates
a use or a BB, but it is inline in the handling of the invoke instruction.
This patch refactors it so that it can be used in other cases. For example, in
define i32 @f(i32 %x) {
bb0:
%cmp = icmp eq i32 %x, 0
br i1 %cmp, label %bb2, label %bb1
bb1:
br label %bb2
bb2:
%cond = phi i32 [ %x, %bb0 ], [ 0, %bb1 ]
%foo = add i32 %cond, %x
ret i32 %foo
}
GVN should be able to replace %x with 0 in any use that is dominated by the
true edge out of bb0. In the above example the only such use is the one in
the phi.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161429
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Tue, 7 Aug 2012 17:04:20 +0000 (17:04 +0000)]
Add a comment about mftb vs. mfspr on PPC.
Thanks to Alex Rosenberg for the suggestion.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161428
91177308-0d34-0410-b5e6-
96231b3b80d8
Alexey Samsonov [Tue, 7 Aug 2012 11:46:57 +0000 (11:46 +0000)]
Fix the representation of debug line table in DebugInfo LLVM library,
and "instruction address -> file/line" lookup.
Instead of plain collection of rows, debug line table for compilation unit is now
treated as the number of row ranges, describing sequences (series of contiguous machine
instructions). The sequences are not always listed in the order of increasing
address, so previously used std::lower_bound() sometimes produced wrong results.
Now the instruction address lookup consists of two stages: finding the correct
sequence, and searching for address in range of rows for this sequence.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161414
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Tue, 7 Aug 2012 11:13:19 +0000 (11:13 +0000)]
PR13095: Give an inline cost bonus to functions using byval arguments.
We give a bonus for every argument because the argument setup is not needed
anymore when the function is inlined. With this patch we interpret byval
arguments as a compact representation of many arguments. The byval argument
setup is implemented in the backend as an inline memcpy, so to model the
cost as accurately as possible we take the number of pointer-sized elements
in the byval argument and give a bonus of 2 instructions for every one of
those. The bonus is capped at 8 elements, which is the number of stores
at which the x86 backend switches from an expanded inline memcpy to a real
memcpy. It would be better to use the real memcpy threshold from the backend,
but it's not available via TargetData.
This change brings the performance of c-ray in line with gcc 4.7. The included
test case tries to reproduce the c-ray problem to catch regressions for this
benchmark early, its performance is dominated by the inline decision of a
specific call.
This only has a small impact on most code, more on x86 and arm than on x86_64
due to the way the ABI works. When building LLVM for x86 it gives a small
inline cost boost to virtually any function using StringRef or STL allocators,
but only a 0.01% increase in overall binary size. The size of gcc compiled by
clang actually shrunk by a couple bytes with this patch applied, but not
significantly.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161413
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Tue, 7 Aug 2012 10:59:59 +0000 (10:59 +0000)]
Fix PR13412, a nasty miscompile due to the interleaved
instsimplify+inline strategy.
The crux of the problem is that instsimplify was reasonably relying on
an invariant that is true within any single function, but is no longer
true mid-inline the way we use it. This invariant is that an argument
pointer != a local (alloca) pointer.
The fix is really light weight though, and allows instsimplify to be
resiliant to these situations: when checking the relation ships to
function arguments, ensure that the argumets come from the same
function. If they come from different functions, then none of these
assumptions hold. All credit to Benjamin Kramer for coming up with this
clever solution to the problem.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161410
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Tue, 7 Aug 2012 09:45:24 +0000 (09:45 +0000)]
Add a much more conservative strategy for aligning branch targets.
Previously, MBP essentially aligned every branch target it could. This
bloats code quite a bit, especially non-looping code which has no real
reason to prefer aligned branch targets so heavily.
As Andy said in review, it's still a bit odd to do this without a real
cost model, but this at least has much more plausible heuristics.
Fixes PR13265.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161409
91177308-0d34-0410-b5e6-
96231b3b80d8
Manman Ren [Tue, 7 Aug 2012 06:16:46 +0000 (06:16 +0000)]
MachineCSE: Update the heuristics for isProfitableToCSE.
If the result of a common subexpression is used at all uses of the candidate
expression, CSE should not increase the live range of the common subexpression.
rdar://
11393714 and rdar://
11819721
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161396
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Tue, 7 Aug 2012 05:51:59 +0000 (05:51 +0000)]
Revert r161371. Removing the 'const' before Type is a "good thing".
--- Reverse-merging r161371 into '.':
U include/llvm/Target/TargetData.h
U lib/Target/TargetData.cpp
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161394
91177308-0d34-0410-b5e6-
96231b3b80d8
Jack Carter [Tue, 7 Aug 2012 00:35:22 +0000 (00:35 +0000)]
The define for 64 bit sign extension neglected to
initialize fields of the class that it used.
The result was nonsense code.
Before:
0000000000000000 <foo>:
0:
00441100 0x441100
4:
03e00008 jr ra
8:
00000000 nop
After:
0000000000000000 <foo>:
0:
00041000 sll v0,a0,0x0
4:
03e00008 jr ra
8:
00000000 nop
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161377
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Tue, 7 Aug 2012 00:26:35 +0000 (00:26 +0000)]
Constify the Type parameter to some methods (which are const anyway).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161371
91177308-0d34-0410-b5e6-
96231b3b80d8
Andrew Trick [Tue, 7 Aug 2012 00:25:30 +0000 (00:25 +0000)]
Allow x86 subtargets to use the GenericModel defined in X86Schedule.td.
This allows codegen passes to query properties like
InstrItins->SchedModel->IssueWidth. It also ensure's that
computeOperandLatency returns the X86 defaults for loads and "high
latency ops". This should have no significant impact on existing
schedulers because X86 defaults happen to be the same as global
defaults.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161370
91177308-0d34-0410-b5e6-
96231b3b80d8
Jack Carter [Tue, 7 Aug 2012 00:01:14 +0000 (00:01 +0000)]
Mips relocation R_MIPS_64 relocates a 64 bit double word.
I hit this in a very large program (spirit.cpp), but
have not figured out how to make a small make check
test for it.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161366
91177308-0d34-0410-b5e6-
96231b3b80d8
Jack Carter [Mon, 6 Aug 2012 23:29:06 +0000 (23:29 +0000)]
The Mips64InstrInfo.td definitions DynAlloc64 LEA_ADDiu64
were using a class defined for 32 bit instructions and
thus the instruction was for addiu instead of daddiu.
This was corrected by adding the instruction opcode as a
field in the base class to be filled in by the defs.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161359
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Mon, 6 Aug 2012 22:52:45 +0000 (22:52 +0000)]
Reduce indentation by early exiting.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161356
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Mon, 6 Aug 2012 22:34:51 +0000 (22:34 +0000)]
Fix typo.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161354
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Mon, 6 Aug 2012 21:34:54 +0000 (21:34 +0000)]
Add a way to grab the target options from the LTO command line.
When the command line target options were removed from the LLVM libraries, LTO
lost its ability to specify things like `-disable-fp-elim'. Add this back by
adding the command line variables to the `lto' project.
<rdar://problem/
12038729>
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161353
91177308-0d34-0410-b5e6-
96231b3b80d8
Jack Carter [Mon, 6 Aug 2012 21:26:03 +0000 (21:26 +0000)]
Mips relocations R_MIPS_HIGHER and R_MIPS_HIGHEST.
These 2 relocations gain access to the
highest and the second highest 16 bits
of a 64 bit object.
R_MIPS_HIGHER %higher(A+S)
The %higher(x) function is [ (((long long) x + 0x80008000LL) >> 32) & 0xffff ].
R_MIPS_HIGHEST %highest(A+S)
The %highest(x) function is [ (((long long) x + 0x800080008000LL) >> 48) & 0xffff ].
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161348
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Mon, 6 Aug 2012 21:21:44 +0000 (21:21 +0000)]
MFTB on PPC64 should really be encoded using MFSPR.
The MFTB instruction itself is being phased out, and its functionality
is provided by MFSPR. According to the ISA docs, using MFSPR works on all known
chips except for the 601 (which did not have a timebase register anyway)
and the POWER3.
Thanks to Adhemerval Zanella for pointing this out!
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161346
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Mon, 6 Aug 2012 20:52:18 +0000 (20:52 +0000)]
Add support for the OpenBSD for Bitrig.
Patch by David Hill.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161344
91177308-0d34-0410-b5e6-
96231b3b80d8
Simon Atanasyan [Mon, 6 Aug 2012 19:47:47 +0000 (19:47 +0000)]
Fix MIPS DSP Rev1 intrinsics memory properties.
The patch reviewed by Akira Hatanaka.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161332
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Mon, 6 Aug 2012 18:48:43 +0000 (18:48 +0000)]
Put up warning signs around MO::getNextOperandForReg().
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161329
91177308-0d34-0410-b5e6-
96231b3b80d8
Roman Divacky [Mon, 6 Aug 2012 18:14:18 +0000 (18:14 +0000)]
Remove empty overrides of processFunctionBeforeFrameFinalized().
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161328
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Mon, 6 Aug 2012 06:22:36 +0000 (06:22 +0000)]
Implement proper handling for pcmpistri/pcmpestri intrinsics. Requires custom handling in DAGISelToDAG due to limitations in TableGen's implicit def handling. Fixes PR11305.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161318
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sun, 5 Aug 2012 09:06:28 +0000 (09:06 +0000)]
Update test to check for r161305
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161307
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sun, 5 Aug 2012 00:36:57 +0000 (00:36 +0000)]
Remove custom inserter for MWAIT. It doesn't do anything that couldn't be represented in a pattern.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161306
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sun, 5 Aug 2012 00:17:48 +0000 (00:17 +0000)]
Use a COPY node instead of an explicit MOVA opcode in the custom insterter for pcmpestrm/pcmpistrm. Allows the register allocator to handle it better and prevent wasted identity moves.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161305
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Sat, 4 Aug 2012 14:10:46 +0000 (14:10 +0000)]
Add readcyclecounter lowering on PPC64.
On PPC64, this can be done with a simple TableGen pattern.
To enable this, I've added the (otherwise missing) readcyclecounter
SDNode definition to TargetSelectionDAG.td.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161302
91177308-0d34-0410-b5e6-
96231b3b80d8
Anton Korobeynikov [Sat, 4 Aug 2012 13:25:58 +0000 (13:25 +0000)]
Skip impdef regs during eabi save/restore list emission to workaround PR11902
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161301
91177308-0d34-0410-b5e6-
96231b3b80d8
Anton Korobeynikov [Sat, 4 Aug 2012 13:22:14 +0000 (13:22 +0000)]
Recognize vst1.64 / vld1.64 with 3 and 4 regs as load from / store to stack stuff
(this corresponds by spilling/reloading regs in DTriple / DQuad reg classes).
No testcase, found by inspection.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161300
91177308-0d34-0410-b5e6-
96231b3b80d8
Anton Korobeynikov [Sat, 4 Aug 2012 13:16:12 +0000 (13:16 +0000)]
Add stack spill / reload instructions for DTriple and DQuad register classes, which
were missed for no reason. This fixes PR13377
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161299
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Sat, 4 Aug 2012 10:31:40 +0000 (10:31 +0000)]
Remove extraneous ';'.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161298
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Sat, 4 Aug 2012 09:52:39 +0000 (09:52 +0000)]
Update cmake build.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161297
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Sat, 4 Aug 2012 09:47:02 +0000 (09:47 +0000)]
Postpone the deletion of the old name in StructType::setName to allow using a slice of the old name.
Fixes PR13522. Add a rudimentary unit test to exercise the behavior.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161296
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Sat, 4 Aug 2012 02:14:44 +0000 (02:14 +0000)]
[CMake] add_lit_target: Remove comments about add_dependencies. It is not a bug in cmake that add_custom_target(DEPENDS) would not accept targets but file-level dependencies.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161295
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Sat, 4 Aug 2012 01:29:37 +0000 (01:29 +0000)]
llc: Try to suppress failures since r161262 .
FIXME: Fix several tests on i686-win32 due to lacking of many libraries.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161292
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Sat, 4 Aug 2012 00:04:03 +0000 (00:04 +0000)]
Delete a dead variable.
TwoAddressInstructionPass doesn't remat any more.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161285
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Fri, 3 Aug 2012 23:57:58 +0000 (23:57 +0000)]
TwoAddressInstructionPass refactoring: Extract another method.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161284
91177308-0d34-0410-b5e6-
96231b3b80d8
Bob Wilson [Fri, 3 Aug 2012 23:29:17 +0000 (23:29 +0000)]
Refactor and check "onlyReadsMemory" before optimizing builtins.
This patch is mostly just refactoring a bunch of copy-and-pasted code, but
it also adds a check that the call instructions are readnone or readonly.
That check was already present for sin, cos, sqrt, log2, and exp2 calls, but
it was missing for the rest of the builtins being handled in this code.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161282
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Fri, 3 Aug 2012 23:25:45 +0000 (23:25 +0000)]
TwoAddressInstructionPass refactoring: Extract a method.
No functional change intended, except replacing a DenseMap with a
SmallDenseMap which should behave identically.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161281
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Fri, 3 Aug 2012 22:58:34 +0000 (22:58 +0000)]
Begin adding support for updating LiveIntervals in TwoAddressInstructionPass.
This is far from complete, and only changes behavior when the
-early-live-intervals flag is passed to llc.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161273
91177308-0d34-0410-b5e6-
96231b3b80d8
Akira Hatanaka [Fri, 3 Aug 2012 22:57:02 +0000 (22:57 +0000)]
1. Redo mips16 instructions to avoid multiple opcodes for same instruction.
Change these to patterns.
2. Add another 16 instructions.
Patch by Reed Kotler.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161272
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Fri, 3 Aug 2012 22:12:54 +0000 (22:12 +0000)]
Add an experimental -early-live-intervals option.
This option runs LiveIntervals before TwoAddressInstructionPass which
will eventually learn to exploit and update the analysis.
Eventually, LiveIntervals will run before PHIElimination, and we can get
rid of LiveVariables.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161270
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Fri, 3 Aug 2012 22:12:51 +0000 (22:12 +0000)]
Delete merged physreg copies in joinReservedPhysReg().
Previously, the identity copy would survive through register allocation
before it was removed by the rewriter.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161269
91177308-0d34-0410-b5e6-
96231b3b80d8
Bob Wilson [Fri, 3 Aug 2012 21:26:24 +0000 (21:26 +0000)]
Try to reduce the compile time impact of r161232.
The previous change caused fast isel to not attempt handling any calls to
builtin functions. That included things like "printf" and caused some
noticable regressions in compile time. I wanted to avoid having fast isel
keep a separate list of functions that had to be kept in sync with what the
code in SelectionDAGBuilder.cpp was handling. I've resolved that here by
moving the list into TargetLibraryInfo. This is somewhat redundant in
SelectionDAGBuilder but it will ensure that we keep things consistent.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161263
91177308-0d34-0410-b5e6-
96231b3b80d8
Bob Wilson [Fri, 3 Aug 2012 21:26:18 +0000 (21:26 +0000)]
Fix memcmp code-gen to honor -fno-builtin.
I noticed that SelectionDAGBuilder::visitCall was missing a check for memcmp
in TargetLibraryInfo, so that it would use custom code for memcmp calls even
with -fno-builtin. I also had to add a new -disable-simplify-libcalls option
to llc so that I could write a test for this.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161262
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Fri, 3 Aug 2012 20:59:32 +0000 (20:59 +0000)]
Completely eliminate VNInfo flags.
The 'unused' state of a value number can be represented as an invalid
def SlotIndex. This also exposed code that shouldn't have been looking
at unused value VNInfos.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@161258
91177308-0d34-0410-b5e6-
96231b3b80d8