firefly-linux-kernel-4.4.55.git
14 years agostaging: brcm80211: remove unnecessary cflag, LINUX
nohee ko [Sat, 9 Oct 2010 17:41:05 +0000 (10:41 -0700)]
staging: brcm80211: remove unnecessary cflag, LINUX

remove unnecessary cflag, LINUX

Signed-off-by: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: brcm80211: remove unnecessary cflag, CONFIG_CFG80211
nohee ko [Sat, 9 Oct 2010 17:39:49 +0000 (10:39 -0700)]
staging: brcm80211: remove unnecessary cflag, CONFIG_CFG80211

remove unnecessary cflag, CONFIG_CFG80211

Signed-off-by: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: brcm80211: remove unnecessary cflag, BCMWPA2
nohee ko [Sat, 9 Oct 2010 17:38:21 +0000 (10:38 -0700)]
staging: brcm80211: remove unnecessary cflag, BCMWPA2

remove unnecessary cflag, BCMWPA2.
BCMDRIVER is already not used.

Signed-off-by: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: brcm80211: remove duplicated file, bcmutils.c
nohee ko [Sat, 9 Oct 2010 17:34:38 +0000 (10:34 -0700)]
staging: brcm80211: remove duplicated file, bcmutils.c

Remove duplicated file, bcmutils.c under brcm80211/brcmfmac.
brcm80211/util/bcmutils.c will be shared between softmac
& fullmac. Makefile, and some other files are also modified
accordingly

Signed-off-by: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: tidspbridge: add memory consistency to TODO list
Arnd Bergmann [Sat, 9 Oct 2010 14:43:24 +0000 (16:43 +0200)]
staging: tidspbridge: add memory consistency to TODO list

This driver uses ioremap on regular memory to get an uncached mapping,
which causes problems on ARMv6 and higher due to aliasing with the
cached linar kernel mapping.

Make sure this gets fixed before the driver graduates from staging.

Cc: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: brcm80211: make interface name buffer smaller
Dan Carpenter [Sat, 9 Oct 2010 11:54:06 +0000 (13:54 +0200)]
Staging: brcm80211: make interface name buffer smaller

In the original code the interface name was IFNAMSIZ + 1, but that
caused problems in dhd_ifname2idx() which does:
strncmp(dhd->iflist[i]->name, name, IFNAMSIZ)

The wl_event_msg_t struct can only store 16 character names as well.

And thirdly there is a potential buffer overflow in dhd_op_if() because
if->net->name is IFNAMSIZ and we do:
strcpy(ifp->net->name, ifp->name);

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: phison: fix problem caused by libata change
Greg Kroah-Hartman [Sat, 9 Oct 2010 20:26:12 +0000 (13:26 -0700)]
Staging: phison: fix problem caused by libata change

The libata core changed this function so it needed to call a different
one.

See https://bugzilla.kernel.org/show_bug.cgi?id=19872 for details.

Reported-by: Heinz Wiesinger <HMWiesinger@gmx.at>
Tested-by: Heinz Wiesinger <HMWiesinger@gmx.at>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: brcm80211: Purge unused wlc_id_name
Brett Rudley [Fri, 8 Oct 2010 22:56:50 +0000 (15:56 -0700)]
staging: brcm80211: Purge unused wlc_id_name

Purge unused wlc_id_name_entry

Signed-off-by: Brett Rudley <brudley@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: brcm80211: Purge unused packet engine
Brett Rudley [Sat, 9 Oct 2010 00:35:02 +0000 (17:35 -0700)]
staging: brcm80211: Purge unused packet engine

We're not using the packet engine anymore - goodbye.

Signed-off-by: Brett Rudley <brudley@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: brcm80211: bug fix- dual band problem
nohee ko [Sat, 9 Oct 2010 01:44:29 +0000 (18:44 -0700)]
staging: brcm80211: bug fix- dual band problem

Bug fix for dual band problem. In particular it had an issue
to connect to 5G band AP.

Signed-off-by: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: speakup: serialio: Fixed errors in file
Tracey Dent [Fri, 8 Oct 2010 21:46:37 +0000 (17:46 -0400)]
Staging: speakup: serialio: Fixed errors in file

On line 40 printk() needed an KERN_* facility level, so I gave it
INFO. Also, fixed a C99 comment error.

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: brcm80211: Coalesce osl_dma_alloc_consistent between fullmac and softmac
Brett Rudley [Fri, 8 Oct 2010 20:57:13 +0000 (13:57 -0700)]
staging: brcm80211: Coalesce osl_dma_alloc_consistent between fullmac and softmac

Combine dma_alloc routine for full and softmac

Signed-off-by: Brett Rudley <brudley@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: brcm80211: Purge unused memlist debugging
Brett Rudley [Fri, 8 Oct 2010 20:55:20 +0000 (13:55 -0700)]
staging: brcm80211: Purge unused memlist debugging

Purge unused memlist debugging

Signed-off-by: Brett Rudley <brudley@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: brcm80211: remove BCMATTACHFN macro
Greg Kroah-Hartman [Fri, 8 Oct 2010 21:28:21 +0000 (14:28 -0700)]
Staging: brcm80211: remove BCMATTACHFN macro

It's not doing anything and is a bit silly.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: brcm80211: remove BCMATTACHDATA macro
Greg Kroah-Hartman [Fri, 8 Oct 2010 21:11:20 +0000 (14:11 -0700)]
Staging: brcm80211: remove BCMATTACHDATA macro

It's not even used for anything, not to mention, it is pretty silly.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: brcm80211: brcmfmac: fix some comparison warnings
Greg Kroah-Hartman [Fri, 8 Oct 2010 19:37:39 +0000 (12:37 -0700)]
Staging: brcm80211: brcmfmac: fix some comparison warnings

Use min_t() instead of min() in some places to make the
comparison explicit and resolve some compiler warnings.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: brcm80211: sys: fix some comparison warnings
Greg Kroah-Hartman [Fri, 8 Oct 2010 19:28:02 +0000 (12:28 -0700)]
Staging: brcm80211: sys: fix some comparison warnings

Use min_t() instead of min() in some places to make the
comparison explicit and resolve some compiler warnings.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: brcm80211: sys: wlc_ampdu: fix some comparison warnings
Greg Kroah-Hartman [Fri, 8 Oct 2010 19:25:23 +0000 (12:25 -0700)]
Staging: brcm80211: sys: wlc_ampdu: fix some comparison warnings

Use min_t() instead of min() in some places to make the comparison
explicit and resolve some compiler warnings.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: brcm80211: phy: wlc_phy_n: fix some comparison warnings
Greg Kroah-Hartman [Fri, 8 Oct 2010 19:16:08 +0000 (12:16 -0700)]
Staging: brcm80211: phy: wlc_phy_n: fix some comparison warnings

Use min_t() instead of min() in some places to make the comparison
explicit and resolve some compiler warnings.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.d
14 years agoStaging: brcm80211: hnddma.c: fix compiler warning
Greg Kroah-Hartman [Fri, 8 Oct 2010 19:07:33 +0000 (12:07 -0700)]
Staging: brcm80211: hnddma.c: fix compiler warning

Change the field types of dma_info_t to make comparing values easier
(and correct.)  No need to keep rxbufsize as a u16, it can be an
unsigned int to make things easier.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: brcm80211: remove VALID_MASK macro
Greg Kroah-Hartman [Fri, 8 Oct 2010 19:01:30 +0000 (12:01 -0700)]
Staging: brcm80211: remove VALID_MASK macro

No one is using it.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: brcm80211: remove ROUNDUP macro
Greg Kroah-Hartman [Fri, 8 Oct 2010 18:59:06 +0000 (11:59 -0700)]
Staging: brcm80211: remove ROUNDUP macro

And use the kernel provided 'roundup' instead.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: brcm80211: remove ISALIGNED macro
Greg Kroah-Hartman [Fri, 8 Oct 2010 18:55:40 +0000 (11:55 -0700)]
Staging: brcm80211: remove ISALIGNED macro

And use the kernel provided IS_ALIGNED one instead.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: brcm80211: remove unused ALIGN_ADDR() macro
Greg Kroah-Hartman [Fri, 8 Oct 2010 18:52:16 +0000 (11:52 -0700)]
Staging: brcm80211: remove unused ALIGN_ADDR() macro

It's not used (and there's a kernel provided one if it's ever needed in
the future), so remove it.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: brcm80211: remove ARRAYSIZE macro
Greg Kroah-Hartman [Fri, 8 Oct 2010 18:47:11 +0000 (11:47 -0700)]
Staging: brcm80211: remove ARRAYSIZE macro

Use the real 'ARRAY_SIZE' definition instead.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: brcm80211: remove OFFSETOF macro
Greg Kroah-Hartman [Fri, 8 Oct 2010 18:44:45 +0000 (11:44 -0700)]
Staging: brcm80211: remove OFFSETOF macro

Use the real 'offsetof' definition instead.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: brcm80211: remove broken MAX() implementation
Greg Kroah-Hartman [Fri, 8 Oct 2010 18:39:43 +0000 (11:39 -0700)]
Staging: brcm80211: remove broken MAX() implementation

Use the kernel-provided version, this one is broken.

Note, there are more compiler warnings now, that's due to different
types being compared, which shows how the original macro was wrong in at
least one way.  They need to be fixed up.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: brcm80211: remove broken MIN() implementation
Greg Kroah-Hartman [Fri, 8 Oct 2010 18:34:59 +0000 (11:34 -0700)]
Staging: brcm80211: remove broken MIN() implementation

Use the kernel-provided version, this one is broken.

Note, there are more compiler warnings now, that's due to different
types being compared, which shows how the original macro was wrong in at
least one way.  They need to be fixed up.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: brcm80211: util: remove unneeded usage of uintptr
Greg Kroah-Hartman [Fri, 8 Oct 2010 18:20:01 +0000 (11:20 -0700)]
Staging: brcm80211: util: remove unneeded usage of uintptr

Double casting is pretty pointless, don't do that.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: brcm80211: remove unused typedefs in typedefs.h
Greg Kroah-Hartman [Fri, 8 Oct 2010 18:13:11 +0000 (11:13 -0700)]
Staging: brcm80211: remove unused typedefs in typedefs.h

uint is already defined somewhere else, so just remove this version
of it.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: brcm80211: s/int32/s32/
Greg Kroah-Hartman [Fri, 8 Oct 2010 18:11:13 +0000 (11:11 -0700)]
Staging: brcm80211: s/int32/s32/

Use the kernel types, don't invent your own.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: brcm80211: s/uint32/u32/
Greg Kroah-Hartman [Fri, 8 Oct 2010 18:05:47 +0000 (11:05 -0700)]
Staging: brcm80211: s/uint32/u32/

Use the kernel types, don't invent your own.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: bcm: silence off by one warning
Dan Carpenter [Fri, 8 Oct 2010 13:49:04 +0000 (15:49 +0200)]
Staging: bcm: silence off by one warning

"status" is used as an index into the Adapter->PackInfo[] array, which
has NO_OF_QUEUES elements.

This code actually works OK.  The SearchSfid() function always returns
a valid index or it returns NO_OF_QUEUES + 1.  But it looks sloppy and
it makes the static checkers complain.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: bcm: remove unneeded NULL check
Dan Carpenter [Fri, 8 Oct 2010 12:57:44 +0000 (14:57 +0200)]
Staging: bcm: remove unneeded NULL check

The error handling here is wrong.  If psIntfAdapter were NULL then we
would have a NULL dereference in the debug output on the error path.
But this function is only called from usbbcm_device_probe() when
psIntfAdapter is non-NULL.

Since the check isn't needed and I removed it instead of fixing it.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: bcm: return -EFAULT on copy_to_user() errors
Dan Carpenter [Fri, 8 Oct 2010 12:56:58 +0000 (14:56 +0200)]
Staging: bcm: return -EFAULT on copy_to_user() errors

bcm/InterfaceDld.c had a couple places which returned the number of
bytes remaining instead of -EFAULT.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: bcm: dereferencing before checking
Dan Carpenter [Fri, 8 Oct 2010 12:56:35 +0000 (14:56 +0200)]
Staging: bcm: dereferencing before checking

I moved the check to see if "Adapter" was null in front of the
dereference.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: bcm: mocro expansion bug
Dan Carpenter [Fri, 8 Oct 2010 12:56:04 +0000 (14:56 +0200)]
Staging: bcm: mocro expansion bug

The WIMAX_MAX_MTU macro is used in drivers/staging/bcm/CmHost.c like
this:

    if (Adapter->PackInfo[uiSearchRuleIndex].uiMaxBucketSize < WIMAX_MAX_MTU * 8)

The multiplication by eight has precedence over the addition so the
macro needs parenthesis to work.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: bcm: make major and minor signed
Dan Carpenter [Fri, 8 Oct 2010 12:54:33 +0000 (14:54 +0200)]
Staging: bcm: make major and minor signed

We assume that major is signed in register_control_device_interface().

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: bcm: return -EFAULT on copy_to_user() failures
Dan Carpenter [Fri, 8 Oct 2010 12:53:48 +0000 (14:53 +0200)]
Staging: bcm: return -EFAULT on copy_to_user() failures

There were a number of places in the bcm_char_ioctl() which returned the
number of bytes remaining to be copied instead of returning -EFAULT.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: speakup: devsynth: file_operations should be const
Tracey Dent [Fri, 8 Oct 2010 10:14:44 +0000 (06:14 -0400)]
Staging: speakup: devsynth: file_operations should be const

Fixed file_operation struct, so that it is const.

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: speakup: keyhelp: Coding style fix
Tracey Dent [Fri, 8 Oct 2010 10:14:45 +0000 (06:14 -0400)]
Staging: speakup: keyhelp: Coding style fix

Put { on previous line, on line 34. Checkpatch.pl caught this.

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: speakup: Makefile: Makefile clean up
Tracey Dent [Fri, 8 Oct 2010 10:14:43 +0000 (06:14 -0400)]
Staging: speakup: Makefile: Makefile clean up

Replaced <modules>-objs with <modules>-y in Makefile.

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: batman-adv: Makefile: replace the use of <module>-objs with <module>-y
Tracey Dent [Fri, 8 Oct 2010 00:01:22 +0000 (20:01 -0400)]
Staging: batman-adv: Makefile: replace the use of <module>-objs with <module>-y

Changed <module>-objs to <module>-y n Makefile.

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: bcm: Makefile: replace the use of <module>-objs with <module>-y
Tracey Dent [Fri, 8 Oct 2010 00:01:23 +0000 (20:01 -0400)]
Staging: bcm: Makefile: replace the use of <module>-objs with <module>-y

Changed <module>-objs to <module>-y in Makefile.

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: Makefile: replace the use of <module>-objs with <module>-y
Tracey Dent [Fri, 8 Oct 2010 00:01:24 +0000 (20:01 -0400)]
Staging: comedi: Makefile: replace the use of <module>-objs with <module>-y

Changed <module>-objs to <module>-y in Makefile.

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: crystalhd: Makefile: replace the use of <module>-objs with <module>-y
Tracey Dent [Fri, 8 Oct 2010 00:01:25 +0000 (20:01 -0400)]
Staging: crystalhd: Makefile: replace the use of <module>-objs with <module>-y

Changed <module>-objs to <module>-y in Makefile.

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: cx25821: Makefile: replace the use of <module>-objs with <module>-y
Tracey Dent [Fri, 8 Oct 2010 00:01:26 +0000 (20:01 -0400)]
Staging: cx25821: Makefile: replace the use of <module>-objs with <module>-y

Changed <module>-objs to <module>-y in Makefile.

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: easycap: Makefile: replace the use of <module>-objs with <module>-y
Tracey Dent [Fri, 8 Oct 2010 00:01:28 +0000 (20:01 -0400)]
Staging: easycap: Makefile: replace the use of <module>-objs with <module>-y

Changed <module>-objs to <module>-y in Makefile.

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: cxt1e1: Makefile: replace the use of <module>-objs with <module>-y
Tracey Dent [Fri, 8 Oct 2010 00:01:27 +0000 (20:01 -0400)]
Staging: cxt1e1: Makefile: replace the use of <module>-objs with <module>-y

Changed <module>-objs to <module>-y in Makefile.

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: go7007: Makefile: makefile cleanup
Tracey Dent [Fri, 8 Oct 2010 00:01:29 +0000 (20:01 -0400)]
Staging: go7007: Makefile: makefile cleanup

Changed <module>-objs to <module>-y in Makefile. Also, Replace EXTRA_CFLAGS with ccflags-y

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: ft1000:ft1000-pcmia: Makefile: replace the use of <module>-objs with <module>-y
Tracey Dent [Fri, 8 Oct 2010 00:01:31 +0000 (20:01 -0400)]
Staging: ft1000:ft1000-pcmia: Makefile: replace the use of <module>-objs with <module>-y

Changed <module>-objs to <module>-y in Makefile.

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: et131x: Makefile: replace the use of <module>-objs with <module>-y
Tracey Dent [Fri, 8 Oct 2010 00:01:30 +0000 (20:01 -0400)]
Staging: et131x: Makefile: replace the use of <module>-objs with <module>-y

Changed <module>-objs to <module>-y in Makefile.

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: ft1000: ft1000-usb: Makefile: replace the use of <module>-objs with <module>-y
Tracey Dent [Fri, 8 Oct 2010 00:01:32 +0000 (20:01 -0400)]
Staging: ft1000: ft1000-usb: Makefile: replace the use of <module>-objs with <module>-y

Changed <module>-objs to <module>-y in Makefile.

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: Makefile: replace the use of <module>-objs with <module>-y
Tracey Dent [Fri, 8 Oct 2010 00:01:33 +0000 (20:01 -0400)]
Staging: hv: Makefile: replace the use of <module>-objs with <module>-y

Changed <module>-objs to <module>-y in Makefile.

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: intel_sst: Makefile: replace the use of <module>-objs with <module>-y
Tracey Dent [Fri, 8 Oct 2010 00:01:34 +0000 (20:01 -0400)]
Staging: intel_sst: Makefile: replace the use of <module>-objs with <module>-y

Changed <module>-objs to <module>-y in Makefile.

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: line6: Makefile: replace the use of <module>-objs with <module>-y
Tracey Dent [Fri, 8 Oct 2010 00:01:36 +0000 (20:01 -0400)]
Staging: line6: Makefile: replace the use of <module>-objs with <module>-y

Changed <module>-objs to <module>-y in Makefile.

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: octeon: Makefile: replace the use of <module>-objs with <module>-y
Tracey Dent [Fri, 8 Oct 2010 00:01:37 +0000 (20:01 -0400)]
Staging: octeon: Makefile: replace the use of <module>-objs with <module>-y

Changed <module>-objs to <module>-y in Makefile.

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: rt2870: Makefile: replace the use of <module>-objs with <module>-y
Tracey Dent [Fri, 8 Oct 2010 00:01:39 +0000 (20:01 -0400)]
Staging: rt2870: Makefile: replace the use of <module>-objs with <module>-y

Changed <module>-objs to <module>-y in Makefile.

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: rt2860: Makefile: replace the use of <module>-objs with <module>-y
Tracey Dent [Fri, 8 Oct 2010 00:01:38 +0000 (20:01 -0400)]
Staging: rt2860: Makefile: replace the use of <module>-objs with <module>-y

Changed <module>-objs to <module>-y in Makefile.

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: rtl8187se: Makefile: replace the use of <module>-objs with <module>-y
Tracey Dent [Fri, 8 Oct 2010 00:01:40 +0000 (20:01 -0400)]
Staging: rtl8187se: Makefile: replace the use of <module>-objs with <module>-y

Changed <module>-objs to <module>-y in Makefile.

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: rtl8712: Makefile: replace the use of <module>-objs with <module>-y
Tracey Dent [Fri, 8 Oct 2010 00:01:42 +0000 (20:01 -0400)]
Staging: rtl8712: Makefile: replace the use of <module>-objs with <module>-y

Changed <module>-objs to <module>-y in Makefile.

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: sbe-2t3e3: Makefile: replace the use of <module>-objs with <module>-y
Tracey Dent [Fri, 8 Oct 2010 00:01:43 +0000 (20:01 -0400)]
Staging: sbe-2t3e3: Makefile: replace the use of <module>-objs with <module>-y

Changed <module>-objs to <module>-y in Makefile.

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: smbfs: Makefile: Makefile clean up
Tracey Dent [Fri, 8 Oct 2010 00:01:44 +0000 (20:01 -0400)]
Staging: smbfs: Makefile: Makefile clean up

Changed <module>-objs to <module>-y in Makefile.
Also Replace EXTRA_CFLAGS with ccflags-y.

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: keucr: Makefile: Makefile clean up
Tracey Dent [Fri, 8 Oct 2010 00:01:35 +0000 (20:01 -0400)]
Staging: keucr: Makefile: Makefile clean up

Changed <module>-objs to <module>-y in Makefile.
Also, Replace EXTRA_CFLAGS with ccflags-y.

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: solo6x10: Makefile: replace the use of <module>-objs with <module>-y
Tracey Dent [Fri, 8 Oct 2010 00:01:45 +0000 (20:01 -0400)]
Staging: solo6x10: Makefile: replace the use of <module>-objs with <module>-y

Changed <module>-objs to <module>-y in Makefile.

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: wlan-ng: Makefile: replace the use of <module>-objs with <module>-y
Tracey Dent [Fri, 8 Oct 2010 00:01:51 +0000 (20:01 -0400)]
Staging: wlan-ng: Makefile: replace the use of <module>-objs with <module>-y

Changed <module>-objs to <module>-y in Makefile.

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: rtl8192u: Makefile: replace the use of <module>-objs with <module>-y
Tracey Dent [Fri, 8 Oct 2010 00:01:41 +0000 (20:01 -0400)]
Staging: rtl8192u: Makefile: replace the use of <module>-objs with <module>-y

Changed <module>-objs to <module>-y in Makefile.

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: usbip: Makefile: replace the use of <module>-objs with <module>-y
Tracey Dent [Fri, 8 Oct 2010 00:01:49 +0000 (20:01 -0400)]
Staging: usbip: Makefile: replace the use of <module>-objs with <module>-y

Changed <module>-objs to <module>-y in Makefile.

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: zram: Makefile: replace the use of <module>-objs with <module>-y
Tracey Dent [Fri, 8 Oct 2010 00:01:53 +0000 (20:01 -0400)]
Staging: zram: Makefile: replace the use of <module>-objs with <module>-y

Changed <module>-objs to <module>-y in Makefile.

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: xgifb: Makefile: replace the use of <module>-objs with <module>-y
Tracey Dent [Fri, 8 Oct 2010 00:01:52 +0000 (20:01 -0400)]
Staging: xgifb: Makefile: replace the use of <module>-objs with <module>-y

Changed <module>-objs to <module>-y in Makefile.

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: tm6000: Makefile: replace the use of <module>-objs with <module>-y
Tracey Dent [Fri, 8 Oct 2010 00:01:48 +0000 (20:01 -0400)]
Staging: tm6000: Makefile: replace the use of <module>-objs with <module>-y

Changed <module>-objs to <module>-y in Makefile.

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: winbond: Makefile: replace the use of <module>-objs with <module>-y
Tracey Dent [Fri, 8 Oct 2010 00:01:50 +0000 (20:01 -0400)]
Staging: winbond: Makefile: replace the use of <module>-objs with <module>-y

Changed <module>-objs to <module>-y in Makefile.

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: tidspbridge: Makefile: replace the use of <module>-objs with <module>-y
Tracey Dent [Fri, 8 Oct 2010 00:01:46 +0000 (20:01 -0400)]
Staging: tidspbridge: Makefile: replace the use of <module>-objs with <module>-y

Changed <module>-objs to <module>-y in Makefile.

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: autofs: Makefile: replace the use of <module>-objs with <module>-y
Tracey Dent [Fri, 8 Oct 2010 00:01:21 +0000 (20:01 -0400)]
Staging: autofs: Makefile: replace the use of <module>-objs with <module>-y

Changed Makefile <module>-objs to <module>-y lines.

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: iio: update example application.
Jonathan Cameron [Fri, 8 Oct 2010 11:14:14 +0000 (12:14 +0100)]
staging: iio: update example application.

The application is now considerably more generic and should cope
with all devices in tree.  The process function will need to be
extended to handle other type values as needed.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: iio: adc add numbers to naming of all adc channels as needed to associate...
Jonathan Cameron [Fri, 8 Oct 2010 11:14:13 +0000 (12:14 +0100)]
staging: iio: adc add numbers to naming of all adc channels as needed to associate events with them.

Given event codes are associated by number not name, all adc channels
including those with names need to have numbers.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: iio: events update documentation to match new abi.
Jonathan Cameron [Fri, 8 Oct 2010 11:14:12 +0000 (12:14 +0100)]
staging: iio: events update documentation to match new abi.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: iio: light remove empty light.h file
Jonathan Cameron [Fri, 8 Oct 2010 11:14:11 +0000 (12:14 +0100)]
staging: iio: light remove empty light.h file

We can put this back when there is something to put in it!

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: iio: tsl2563 event attribute name updates
Jonathan Cameron [Fri, 8 Oct 2010 11:14:10 +0000 (12:14 +0100)]
staging: iio: tsl2563 event attribute name updates

Patch also renames the two raw channels to add numbers
so that we know to which channel the event code applies.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: iio: accel remove deprecated and misleading event macros.
Jonathan Cameron [Fri, 8 Oct 2010 11:14:09 +0000 (12:14 +0100)]
staging: iio: accel remove deprecated and misleading event macros.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: iio: sca3000 event attribute name updates
Jonathan Cameron [Fri, 8 Oct 2010 11:14:08 +0000 (12:14 +0100)]
staging: iio: sca3000 event attribute name updates

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: iio: lis3l02dq event attribute renames
Jonathan Cameron [Fri, 8 Oct 2010 11:14:07 +0000 (12:14 +0100)]
staging: iio: lis3l02dq event attribute renames

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: iio: events move buffer codes so they do not clash with new scheme
Jonathan Cameron [Fri, 8 Oct 2010 11:14:06 +0000 (12:14 +0100)]
staging: iio: events move buffer codes so they do not clash with new scheme

We could blugeon these more into the scheme I guess, but does it make sense
to do so?

Also remove all remain vestiges of old scheme.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: iio: tsl2563 move to new event numbering scheme and remove old definitions
Jonathan Cameron [Fri, 8 Oct 2010 11:14:05 +0000 (12:14 +0100)]
staging: iio: tsl2563 move to new event numbering scheme and remove old definitions

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: iio: accel remove old event codes
Jonathan Cameron [Fri, 8 Oct 2010 11:14:04 +0000 (12:14 +0100)]
staging: iio: accel remove old event codes

Signed-off-by: Joanthan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: iio: sca3000 move to new event code scheme and add combined orientations
Jonathan Cameron [Fri, 8 Oct 2010 11:14:03 +0000 (12:14 +0100)]
staging: iio: sca3000 move to new event code scheme and add combined orientations

The combined orientations allow handling of typical motion and free fall
detectors to be handled as threshold events just applied to a number of
axes via boolean operations.  So freefall is when x, y and z magnitudes
are all below a threshold for a particular period.  Motion detectors
are typically whether x or y or z are above a particular value.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: iio: lis3l02dq move to new event code scheme
Jonathan Cameron [Fri, 8 Oct 2010 11:14:02 +0000 (12:14 +0100)]
staging: iio: lis3l02dq move to new event code scheme

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: iio: adc events update to new numbering system
Jonathan Cameron [Fri, 8 Oct 2010 11:14:01 +0000 (12:14 +0100)]
staging: iio: adc events update to new numbering system

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: iio: events define macros for new event code system
Jonathan Cameron [Fri, 8 Oct 2010 11:14:00 +0000 (12:14 +0100)]
staging: iio: events define macros for new event code system

These are step one of moving to a systematic numbering for event
codes.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: brcm80211: Use proper BRCM_FULLMAC #ifdefs
Brett Rudley [Fri, 8 Oct 2010 03:31:46 +0000 (20:31 -0700)]
staging: brcm80211: Use proper BRCM_FULLMAC #ifdefs

Make it obvious that DHD_USE_STATIC_BUF is only used as part of FULLMAC build

Signed-off-by: Brett Rudley <brudley@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: iio: light: Adding driver for ISL29018 ALS
Rhyland Klein [Thu, 7 Oct 2010 22:48:09 +0000 (15:48 -0700)]
staging: iio: light: Adding driver for ISL29018 ALS

adding support for the ISL 29018 ambient light and proximity sensor.

Addressed comments from reviews by Jonathan Cameron and Joe Perches
  * Removed some excess dbg prints that only printed function name
  * Renamed some properties to make them more descriptive
  * Added a property to list available adc resolutions
  * Defined arrays for resolutions/ranges as static const
  * Change loops initialization to memset for extensibility.
    * used sizeof() instead of ARRAY_SIZE() to be safer
  * Added a property to list available adc ranges
  * Fixed warnings and property names.

Signed-off-by: Rhyland Klein <rklein@nvidia.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: brcm80211: Remove dead code from siutils.c
Henry Ptasinski [Fri, 8 Oct 2010 02:52:11 +0000 (19:52 -0700)]
staging: brcm80211: Remove dead code from siutils.c

Removed lots of unused functions from siutils.c

Signed-off-by: Henry Ptasinski <henryp@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: brcm80211: Remove dead code from bcmwifi.c
Henry Ptasinski [Fri, 8 Oct 2010 02:52:10 +0000 (19:52 -0700)]
staging: brcm80211: Remove dead code from bcmwifi.c

Removed unused functions wf_chspec_ntoa() and wf_chspec_aton().

Signed-off-by: Henry Ptasinski <henryp@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: brcm80211: Remove dead code from linux_osl.c.
Henry Ptasinski [Fri, 8 Oct 2010 02:52:09 +0000 (19:52 -0700)]
staging: brcm80211: Remove dead code from linux_osl.c.

Removed several completely unused functions:
osl_malloc_failed
osl_pcmcia_attr
osl_pcmcia_read_attr
osl_pcmcia_write_attr
osl_pktdup
and related macros

Signed-off-by: Henry Ptasinski <henryp@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: brcm80211: Remove unnecessary hndtcam.h
Henry Ptasinski [Fri, 8 Oct 2010 02:52:08 +0000 (19:52 -0700)]
staging: brcm80211: Remove unnecessary hndtcam.h

The header file is unnecessary.  Delete it and don't include it.

Signed-off-by: Henry Ptasinski <henryp@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: brcm80211: Remove unnecessary bitfuncs.h
Henry Ptasinski [Fri, 8 Oct 2010 02:52:07 +0000 (19:52 -0700)]
staging: brcm80211: Remove unnecessary bitfuncs.h

This header file is no longer included anywhere.

Signed-off-by: Henry Ptasinski <henryp@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: brcm80211: Don't include bitfuncs.h
Henry Ptasinski [Fri, 8 Oct 2010 02:52:06 +0000 (19:52 -0700)]
staging: brcm80211: Don't include bitfuncs.h

Remove include of bitfuncs.h, as it's completely uncessary for these files.

Signed-off-by: Henry Ptasinski <henryp@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: brcm80211: Use linux/bitops.h instead of bitfuncs.h
Henry Ptasinski [Fri, 8 Oct 2010 02:52:05 +0000 (19:52 -0700)]
staging: brcm80211: Use linux/bitops.h instead of bitfuncs.h

Use ffs() from linux/bitops.h, instead of the locally defined find_msbit().

Signed-off-by: Henry Ptasinski <henryp@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: brcm80211: Remove dead code from aiutils.c
Henry Ptasinski [Fri, 8 Oct 2010 02:52:04 +0000 (19:52 -0700)]
staging: brcm80211: Remove dead code from aiutils.c

Removed unused function ai_view().

Signed-off-by: Henry Ptasinski <henryp@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: speakup: fix speakup core to build properly
Greg Kroah-Hartman [Fri, 8 Oct 2010 02:30:49 +0000 (19:30 -0700)]
Staging: speakup: fix speakup core to build properly

The vc_data structure changed to move the tty structure off to the port,
so change the code to handle this.  Now the code will build properly,
and hopefully work as well.

Cc: William Hubbs <w.d.hubbs@gmail.com>
Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>