Richard Sandiford [Tue, 14 May 2013 09:49:11 +0000 (09:49 +0000)]
[SystemZ] Add extra testscases for r181773
Forgot to svn add these...
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181774
91177308-0d34-0410-b5e6-
96231b3b80d8
Richard Sandiford [Tue, 14 May 2013 09:47:26 +0000 (09:47 +0000)]
[SystemZ] Rework handling of constant PC-relative operands
The GNU assembler treats things like:
brasl %r14, 100
in the same way as:
brasl %r14, .+100
rather than as a branch to absolute address 100. We implemented this in
LLVM by creating an immediate operand rather than the usual expr operand,
and by handling immediate operands specially in the code emitter.
This was undesirable for (at least) three reasons:
- the specialness of immediate operands was exposed to the backend MC code,
rather than being limited to the assembler parser.
- in disassembly, an immediate operand really is an absolute address.
(Note that this means reassembling printed disassembly can't recreate
the original code.)
- it would interfere with any assembly manipulation that we might
try in future. E.g. operations like branch shortening can change
the relative position of instructions, but any code that updates
sym+offset addresses wouldn't update an immediate "100" operand
in the same way as an explicit ".+100" operand.
This patch changes the implementation so that the assembler creates
a "." label for immediate PC-relative operands, so that the operand
to the MCInst is always the absolute address. The patch also adds
some error checking of the offset.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181773
91177308-0d34-0410-b5e6-
96231b3b80d8
Richard Sandiford [Tue, 14 May 2013 09:38:07 +0000 (09:38 +0000)]
[SystemZ] Remove bogus isAsmParserOnly
Marking instructions as isAsmParserOnly stops them from being disassembled.
However, in cases where separate asm and codegen versions exist, we actually
want to disassemble to the asm ones.
No functional change intended.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181772
91177308-0d34-0410-b5e6-
96231b3b80d8
Richard Sandiford [Tue, 14 May 2013 09:36:44 +0000 (09:36 +0000)]
[SystemZ] Match operands to fields by name rather than by order
The SystemZ port currently relies on the order of the instruction operands
matching the order of the instruction field lists. This isn't desirable
for disassembly, where the two are matched only by name. E.g. the R1 and R2
fields of an RR instruction should have corresponding R1 and R2 operands.
The main complication is that addresses are compound operands,
and as far as I know there is no mechanism to allow individual
suboperands to be selected by name in "let Inst{...} = ..." assignments.
Luckily it doesn't really matter though. The SystemZ instruction
encoding groups all address fields together in a predictable order,
so it's just as valid to see the entire compound address operand as
a single field. That's the approach taken in this patch.
Matching by name in turn means that the operands to COPY SIGN and
CONVERT TO FIXED instructions can be given in natural order.
(It was easier to do this at the same time as the rename,
since otherwise the intermediate step was too confusing.)
No functional change intended.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181771
91177308-0d34-0410-b5e6-
96231b3b80d8
Richard Sandiford [Tue, 14 May 2013 09:28:21 +0000 (09:28 +0000)]
[SystemZ] Match operands to fields by name rather than by order
The SystemZ port currently relies on the order of the instruction operands
matching the order of the instruction field lists. This isn't desirable
for disassembly, where the two are matched only by name. E.g. the R1 and R2
fields of an RR instruction should have corresponding R1 and R2 operands.
The main complication is that addresses are compound operands,
and as far as I know there is no mechanism to allow individual
suboperands to be selected by name in "let Inst{...} = ..." assignments.
Luckily it doesn't really matter though. The SystemZ instruction
encoding groups all address fields together in a predictable order,
so it's just as valid to see the entire compound address operand as
a single field. That's the approach taken in this patch.
Matching by name in turn means that the operands to COPY SIGN and
CONVERT TO FIXED instructions can be given in natural order.
(It was easier to do this at the same time as the rename,
since otherwise the intermediate step was too confusing.)
No functional change intended.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181769
91177308-0d34-0410-b5e6-
96231b3b80d8
Michael Gottesman [Tue, 14 May 2013 06:40:10 +0000 (06:40 +0000)]
Removed trailing whitespace.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181760
91177308-0d34-0410-b5e6-
96231b3b80d8
Reed Kotler [Tue, 14 May 2013 06:00:01 +0000 (06:00 +0000)]
Fix typo.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181759
91177308-0d34-0410-b5e6-
96231b3b80d8
Reed Kotler [Tue, 14 May 2013 02:13:45 +0000 (02:13 +0000)]
Removed an unnamed namespace and forgot to make two of the functions inside
"static".
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181754
91177308-0d34-0410-b5e6-
96231b3b80d8
Reed Kotler [Tue, 14 May 2013 02:00:24 +0000 (02:00 +0000)]
This is the first of three patches which creates stubs used for
Mips16/32 floating point interoperability.
When Mips16 code calls external functions that would normally have some
of its parameters or return values passed in floating point registers,
it needs (Mips32) helper functions to do this because while in Mips16 mode
there is no ability to access the floating point registers.
In Pic mode, this is done with a set of predefined functions in libc.
This case is already handled in llvm for Mips16.
In static relocation mode, for efficiency reasons, the compiler generates
stubs that the linker will use if it turns out that the external function
is a Mips32 function. (If it's Mips16, then it does not need the helper
stubs).
These stubs are identically named and the linker knows about these tricks
and will not create multiple copies and will delete them if they are not
needed.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181753
91177308-0d34-0410-b5e6-
96231b3b80d8
Akira Hatanaka [Tue, 14 May 2013 01:42:44 +0000 (01:42 +0000)]
StackColoring: don't clear an instruction's mem operand if the underlying
object is a PseudoSourceValue and PseudoSourceValue::isConstant returns true (i.e.,
points to memory that has a constant value).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181751
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Tue, 14 May 2013 00:35:19 +0000 (00:35 +0000)]
Assert that DIEEntries are constructed with non-null DIEs
This just brings a crash a little further forward from DWARF emission to
DIE construction to make errors easier to diagnose.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181748
91177308-0d34-0410-b5e6-
96231b3b80d8
Arnold Schwaighofer [Tue, 14 May 2013 00:21:18 +0000 (00:21 +0000)]
LoopVectorize: Handle loops with multiple forward inductions
We used to give up if we saw two integer inductions. After this patch, we base
further induction variables on the chosen one like we do in the reverse
induction and pointer induction case.
Fixes PR15720.
radar://
13851975
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181746
91177308-0d34-0410-b5e6-
96231b3b80d8
Michael Gottesman [Tue, 14 May 2013 00:08:09 +0000 (00:08 +0000)]
[objc-arc-opts] Added debug statements when we set and unset whether a pointer is known positive.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181745
91177308-0d34-0410-b5e6-
96231b3b80d8
Michael Gottesman [Mon, 13 May 2013 23:49:42 +0000 (23:49 +0000)]
[objc-arc-opts] In the presense of an alloca unconditionally remove RR pairs if and only if we are both KnownSafeBU/KnownSafeTD rather than just either or.
In the presense of a block being initialized, the frontend will emit the
objc_retain on the original pointer and the release on the pointer loaded from
the alloca. The optimizer will through the provenance analysis realize that the
two are related (albiet different), but since we only require KnownSafe in one
direction, will match the inner retain on the original pointer with the guard
release on the original pointer. This is fixed by ensuring that in the presense
of allocas we only unconditionally remove pointers if both our retain and our
release are KnownSafe (i.e. we are KnownSafe in both directions) since we must
deal with the possibility that the frontend will emit what (to the optimizer)
appears to be unbalanced retain/releases.
An example of the miscompile is:
%A = alloca
retain(%x)
retain(%x) <--- Inner Retain
store %x, %A
%y = load %A
... DO STUFF ...
release(%y)
call void @use(%x)
release(%x) <--- Guarding Release
getting optimized to:
%A = alloca
retain(%x)
store %x, %A
%y = load %A
... DO STUFF ...
release(%y)
call void @use(%x)
rdar://
13750319
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181743
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Beaumont-Gay [Mon, 13 May 2013 21:10:49 +0000 (21:10 +0000)]
Move a couple more statistics inside '#ifndef NDEBUG'.
Suppresses an unused-variable warning in -Asserts builds.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181733
91177308-0d34-0410-b5e6-
96231b3b80d8
Jack Carter [Mon, 13 May 2013 20:26:46 +0000 (20:26 +0000)]
Mips assembler: Assembler macro ADDIU $rs,imm
This patch adds alias for addiu instruction which enables following syntax:
addiu $rs,imm
The macro is translated as:
addiu $rs,$rs,imm
Contributer: Vladimir Medic
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181729
91177308-0d34-0410-b5e6-
96231b3b80d8
Michael Gottesman [Mon, 13 May 2013 19:40:39 +0000 (19:40 +0000)]
[objc-arc-opts] Add comment to BBState making it clear that get{TopDown,BottomUp}PtrState will create a new PtrState object if it does not find a PtrState for Arg.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181726
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Schmidt [Mon, 13 May 2013 19:40:36 +0000 (19:40 +0000)]
Fix goofy commentary in PPCTargetObjectFile.cpp.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181725
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Schmidt [Mon, 13 May 2013 19:34:37 +0000 (19:34 +0000)]
PPC64: Constant initializers with dynamic relocations go in .data.rel.ro.
This fixes warning messages observed in the oggenc application test in
projects/test-suite. Special handling is needed for the 64-bit
PowerPC SVR4 ABI when a constant is initialized with a pointer to a
function in a shared library. Because a function address is
implemented as the address of a function descriptor, the use of copy
relocations can lead to problems with initialization. GNU ld
therefore replaces copy relocations with dynamic relocations to be
resolved by the dynamic linker. This means the constant cannot reside
in the read-only data section, but instead belongs in .data.rel.ro,
which is designed for constants containing dynamic relocations.
The implementation creates a class PPC64LinuxTargetObjectFile
inheriting from TargetLoweringObjectFileELF, which behaves like its
parent except to place constants of this sort into .data.rel.ro.
The test case is reduced from the oggenc application.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181723
91177308-0d34-0410-b5e6-
96231b3b80d8
Bob Wilson [Mon, 13 May 2013 19:02:31 +0000 (19:02 +0000)]
Remove redundant variable introduced by r181682.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181721
91177308-0d34-0410-b5e6-
96231b3b80d8
Michael Gottesman [Mon, 13 May 2013 18:29:07 +0000 (18:29 +0000)]
[objc-arc] Move the before optimization statistics gathering phase out of OptimizeIndividualCalls.
This makes the statistics gathering completely independent of the actual
optimization occuring, preventing any sort of bleeding over from occuring.
Additionally, it simplifies a switch statement in the non-statistic gathering case.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181719
91177308-0d34-0410-b5e6-
96231b3b80d8
Akira Hatanaka [Mon, 13 May 2013 18:23:35 +0000 (18:23 +0000)]
[mips] Add option -mno-ldc1-sdc1.
This option is used when the user wants to avoid emitting double precision FP
loads and stores. Double precision FP loads and stores are expanded to single
precision instructions after register allocation.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181718
91177308-0d34-0410-b5e6-
96231b3b80d8
Shuxin Yang [Mon, 13 May 2013 18:03:12 +0000 (18:03 +0000)]
Fix a bug that APFloat::fusedMultiplyAdd() mistakenly evaluate "14.5f * -14.5f + 225.0f" to 225.0f.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181715
91177308-0d34-0410-b5e6-
96231b3b80d8
Akira Hatanaka [Mon, 13 May 2013 17:57:42 +0000 (17:57 +0000)]
[mips] Define a helper function which creates an instruction with the same
operands as the prototype instruction but with a different opcode.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181714
91177308-0d34-0410-b5e6-
96231b3b80d8
Akira Hatanaka [Mon, 13 May 2013 17:43:19 +0000 (17:43 +0000)]
[mips] Rename functions. No functionality changes.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181713
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Mon, 13 May 2013 14:34:48 +0000 (14:34 +0000)]
Remove unused fields and arguments.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181706
91177308-0d34-0410-b5e6-
96231b3b80d8
Mihai Popa [Mon, 13 May 2013 14:10:04 +0000 (14:10 +0000)]
The purpose of the patch is to fix the syntax of ARM mrc and mrc2 instructions when they are used to write to the APSR. In this case, the destination operand should be APSR_nzcv, and the encoding of the target should be 0b1111 (same as for PC). In pre-UAL syntax, this form used the PC register as a textual target. This is still allowed for backward compatibility.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181705
91177308-0d34-0410-b5e6-
96231b3b80d8
Lang Hames [Mon, 13 May 2013 10:21:19 +0000 (10:21 +0000)]
Correctly preserve the input chain for potential tailcall nodes whose
return values are bitcasts.
The chain had previously been being clobbered with the entry node to
the dag, which sometimes caused other code in the function to be
erroneously deleted when tailcall optimization kicked in.
<rdar://problem/
13827621>
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181696
91177308-0d34-0410-b5e6-
96231b3b80d8
Duncan Sands [Mon, 13 May 2013 07:50:47 +0000 (07:50 +0000)]
Suppress GCC compiler warnings in release builds about variables that are only
read in asserts.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181689
91177308-0d34-0410-b5e6-
96231b3b80d8
Nadav Rotem [Mon, 13 May 2013 05:13:13 +0000 (05:13 +0000)]
SLPVectorizer: Swap LHS and RHS. No functionality change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181684
91177308-0d34-0410-b5e6-
96231b3b80d8
Hao Liu [Mon, 13 May 2013 02:07:05 +0000 (02:07 +0000)]
Fix PR15950 A bug in DAG Combiner about undef mask
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181682
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Mon, 13 May 2013 01:16:13 +0000 (01:16 +0000)]
Remove the MachineMove class.
It was just a less powerful and more confusing version of
MCCFIInstruction. A side effect is that, since MCCFIInstruction uses
dwarf register numbers, calls to getDwarfRegNum are pushed out, which
should allow further simplifications.
I left the MachineModuleInfo::addFrameMove interface unchanged since
this patch was already fairly big.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181680
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Mon, 13 May 2013 00:18:24 +0000 (00:18 +0000)]
XFAIL this test for mingw too.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181678
91177308-0d34-0410-b5e6-
96231b3b80d8
Nadav Rotem [Sun, 12 May 2013 22:58:45 +0000 (22:58 +0000)]
SLPVectorizer: Fix a bug in the code that generates extracts for values with multiple users.
The external user does not have to be in lane #0. We have to save the lane for each scalar so that we know which vector lane to extract.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181674
91177308-0d34-0410-b5e6-
96231b3b80d8
Nadav Rotem [Sun, 12 May 2013 22:55:57 +0000 (22:55 +0000)]
SLPVectorizer: Clear the map that maps between scalars to vectors after each round of vectorization.
Testcase in the next commit.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181673
91177308-0d34-0410-b5e6-
96231b3b80d8
David Majnemer [Sun, 12 May 2013 00:07:05 +0000 (00:07 +0000)]
InstCombine: Flip the order of two urem transforms
There are two transforms in visitUrem that conflict with each other.
*) One, if a divisor is a power of two, subtracts one from the divisor
and turns it into a bitwise-and.
*) The other unwraps both operands if they are surrounded by zext
instructions.
Flipping the order allows the subtraction to go beneath the sign
extension.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181668
91177308-0d34-0410-b5e6-
96231b3b80d8
Arnold Schwaighofer [Sat, 11 May 2013 23:04:28 +0000 (23:04 +0000)]
LoopVectorize: Use the widest induction variable type
Use the widest induction type encountered for the cannonical induction variable.
We used to turn the following loop into an empty loop because we used i8 as
induction variable type and truncated 1024 to 0 as trip count.
int a[1024];
void fail() {
int reverse_induction = 1023;
unsigned char forward_induction = 0;
while ((reverse_induction) >= 0) {
forward_induction++;
a[reverse_induction] = forward_induction;
--reverse_induction;
}
}
radar://
13862901
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181667
91177308-0d34-0410-b5e6-
96231b3b80d8
Arnold Schwaighofer [Sat, 11 May 2013 23:04:26 +0000 (23:04 +0000)]
LoopVectorize: Use variable instead of repeated function call
No functionality change intended.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181666
91177308-0d34-0410-b5e6-
96231b3b80d8
Arnold Schwaighofer [Sat, 11 May 2013 23:04:24 +0000 (23:04 +0000)]
LoopVectorize: Use IRBuilder interface in more places
No functionality change intended.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181665
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Sat, 11 May 2013 19:14:10 +0000 (19:14 +0000)]
Correct parameter name in doc comment to match declaration.
(review feedback on r181632 from Dmitri)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181664
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Sat, 11 May 2013 18:24:28 +0000 (18:24 +0000)]
StringRefize some debug accel table bits.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181663
91177308-0d34-0410-b5e6-
96231b3b80d8
David Majnemer [Sat, 11 May 2013 09:01:28 +0000 (09:01 +0000)]
InstCombine: Turn urem to bitwise-and more often
Use isKnownToBeAPowerOfTwo in visitUrem so that we may more aggressively
fold away urem instructions.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181661
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Sat, 11 May 2013 02:38:11 +0000 (02:38 +0000)]
Change getFrameMoves to return a const reference.
To add a frame now there is a dedicated addFrameMove which also takes
care of constructing the move itself.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181657
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Sat, 11 May 2013 02:24:41 +0000 (02:24 +0000)]
Remove more dead code.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181656
91177308-0d34-0410-b5e6-
96231b3b80d8
Reed Kotler [Sat, 11 May 2013 01:02:20 +0000 (01:02 +0000)]
Add -mtriple=mipsel-linux-gnu to the test so that the compiler does
not think it can support small data sections.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181654
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Fri, 10 May 2013 23:34:51 +0000 (23:34 +0000)]
Remove dead code.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181649
91177308-0d34-0410-b5e6-
96231b3b80d8
Nadav Rotem [Fri, 10 May 2013 22:59:33 +0000 (22:59 +0000)]
SLPVectorizer: Add support for trees with external users.
For example:
bar() {
int a = A[i];
int b = A[i+1];
B[i] = a;
B[i+1] = b;
foo(a); <--- a is used outside the vectorized expression.
}
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181648
91177308-0d34-0410-b5e6-
96231b3b80d8
Nadav Rotem [Fri, 10 May 2013 22:56:18 +0000 (22:56 +0000)]
Add a debug print
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181647
91177308-0d34-0410-b5e6-
96231b3b80d8
Nadav Rotem [Fri, 10 May 2013 22:55:44 +0000 (22:55 +0000)]
Add an additional testcase for PR15882.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181646
91177308-0d34-0410-b5e6-
96231b3b80d8
Reed Kotler [Fri, 10 May 2013 22:25:39 +0000 (22:25 +0000)]
Checkin in of first of several patches to finish implementation of
mips16/mips32 floating point interoperability.
This patch fixes returns from mips16 functions so that if the function
was in fact called by a mips32 hard float routine, then values
that would have been returned in floating point registers are so returned.
Mips16 mode has no floating point instructions so there is no way to
load values into floating point registers.
This is needed when returning float, double, single complex, double complex
in the Mips ABI.
Helper functions in libc for mips16 are available to do this.
For efficiency purposes, these helper functions have a different calling
convention from normal Mips calls.
Registers v0,v1,a0,a1 are used to pass parameters instead of
a0,a1,a2,a3.
This is because v0,v1,a0,a1 are the natural registers used to return
floating point values in soft float. These values can then be moved
to the appropriate floating point registers with no extra cost.
The only register that is modified is ra in this call.
The helper functions make sure that the return values are in the floating
point registers that they would be in if soft float was not in effect
(which it is for mips16, though the soft float is implemented using a mips32
library that uses hard float).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181641
91177308-0d34-0410-b5e6-
96231b3b80d8
Jordan Rose [Fri, 10 May 2013 22:17:10 +0000 (22:17 +0000)]
Micro-optimization: don't shift an entire bitcode record over to get the code.
Previously, BitstreamCursor read an abbreviated record by splatting the
whole thing into a data vector, then extracting and removing the /first/
element. Now, it reads the first element--the record code--separately from
the actual field values.
No (intended) functionality change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181639
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Fri, 10 May 2013 22:14:39 +0000 (22:14 +0000)]
Give the test from r181632 a target triple.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181637
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Fri, 10 May 2013 21:52:07 +0000 (21:52 +0000)]
PR14492: Debug Info: Support for values of non-integer non-type template parameters.
This is only tested for global variables at the moment (& includes tests
for the unnamed parameter case, since apparently this entire function
was completely untested previously)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181632
91177308-0d34-0410-b5e6-
96231b3b80d8
Jyotsna Verma [Fri, 10 May 2013 21:44:02 +0000 (21:44 +0000)]
Fix unused variable error.
Earlier, this variable was used in an assert and was causing failure on
darwin.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181630
91177308-0d34-0410-b5e6-
96231b3b80d8
Jyotsna Verma [Fri, 10 May 2013 20:58:11 +0000 (20:58 +0000)]
Hexagon: Fix switch statements in GetDotOldOp and IsNewifyStore.
No functionality change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181628
91177308-0d34-0410-b5e6-
96231b3b80d8
Jyotsna Verma [Fri, 10 May 2013 20:27:34 +0000 (20:27 +0000)]
Hexagon: Fix switch cases in HexagonVLIWPacketizer.cpp.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181624
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Fri, 10 May 2013 18:31:42 +0000 (18:31 +0000)]
Fix the R600 build.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181621
91177308-0d34-0410-b5e6-
96231b3b80d8
Chad Rosier [Fri, 10 May 2013 18:24:17 +0000 (18:24 +0000)]
[ms-inline asm] Fix a crasher when we fail on a direct match.
The issue was that the MatchingInlineAsm and VariantID args to the
MatchInstructionImpl function weren't being set properly. Specifically, when
parsing intel syntax, the parser thought it was parsing inline assembly in the
at&t dialect; that will never be the case.
The crash was caused when the emitter tried to emit the instruction, but the
operands weren't set. When parsing inline assembly we only set the opcode, not
the operands, which is used to lookup the instruction descriptor.
rdar://
13854391 and PR15945
Also, this commit reverts r176036. Now that we're correctly parsing the intel
syntax the pushad/popad don't match properly. I've reimplemented that fix using
a MnemonicAlias.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181620
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Fri, 10 May 2013 18:16:59 +0000 (18:16 +0000)]
Remove unused argument.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181618
91177308-0d34-0410-b5e6-
96231b3b80d8
Andrew Kaylor [Fri, 10 May 2013 17:58:41 +0000 (17:58 +0000)]
Fix MCJITCAPITest.cpp unit test on Windows.
MCJIT on Windows requires an explicit target triple with "-elf" appended to generate objects in ELF format. The common test framework was setting up this triple, but it wasn't passed to the C API in the test.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181614
91177308-0d34-0410-b5e6-
96231b3b80d8
Alexander Kornienko [Fri, 10 May 2013 17:15:51 +0000 (17:15 +0000)]
Better output for long help strings for command-line options.
Summary:
This patch allows using \n inside long help strings for command-line
options, so that all lines are equally indented. This is not a perfect solution,
as we don't (and probably don't want to) know about terminal width, but it
allows to format long help strings somehow readable without manually padding
them with spaces. A motivating example is -help output from clang-format (source
code in tools/clang-format/ClangFormat.cpp, see cl options offset, length,
style, and dump-config).
Reviewers: atrick, alexfh
Reviewed By: alexfh
CC: llvm-commits, rafael
Differential Revision: http://llvm-reviews.chandlerc.com/D779
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181608
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Fri, 10 May 2013 16:53:12 +0000 (16:53 +0000)]
Remove unused function.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181606
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Fri, 10 May 2013 16:26:37 +0000 (16:26 +0000)]
InstCombine: Don't claim to be able to evaluate any shl in a zexted type.
The shift amount may be larger than the type leading to undefined behavior.
Limit the transform to constant shift amounts. While there update the bits to
clear in the result which may enable additional optimizations.
PR15959.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181604
91177308-0d34-0410-b5e6-
96231b3b80d8
Logan Chien [Fri, 10 May 2013 16:17:24 +0000 (16:17 +0000)]
Implement AsmParser for ARM unwind directives.
This commit implements the AsmParser for fnstart, fnend,
cantunwind, personality, handlerdata, pad, setfp, save, and
vsave directives.
This commit fixes some minor issue in the ARMELFStreamer:
* The switch back to corresponding section after the .fnend
directive.
* Emit the unwind opcode while processing .fnend directive
if there is no .handlerdata directive.
* Emit the unwind opcode to .ARM.extab while processing
.handlerdata even if .personality directive does not exist.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181603
91177308-0d34-0410-b5e6-
96231b3b80d8
Aaron Ballman [Fri, 10 May 2013 14:42:16 +0000 (14:42 +0000)]
XFAILing this test on Win32 to unbreak the build bots.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181600
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Fri, 10 May 2013 14:09:52 +0000 (14:09 +0000)]
DAGCombiner: Generate a correct constant for vector types when folding (xor (and)) into (and (not)).
PR15948.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181597
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Fri, 10 May 2013 09:16:52 +0000 (09:16 +0000)]
InstCombine: Verify the type before transforming uitofp into select.
PR15952.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181586
91177308-0d34-0410-b5e6-
96231b3b80d8
Tom Stellard [Fri, 10 May 2013 02:09:45 +0000 (02:09 +0000)]
R600: Remove AMDILPeeopholeOptimizer and replace optimizations with tablegen patterns
The BFE optimization was the only one we were actually using, and it was
emitting an intrinsic that we don't support.
https://bugs.freedesktop.org/show_bug.cgi?id=64201
Reviewed-by: Christian König <christian.koenig@amd.com>
NOTE: This is a candidate for the 3.3 branch.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181580
91177308-0d34-0410-b5e6-
96231b3b80d8
Tom Stellard [Fri, 10 May 2013 02:09:39 +0000 (02:09 +0000)]
R600: Expand SUB for v2i32/v4i32
Patch by: Aaron Watry
Reviewed-by: Tom Stellard <thomas.stellard@amd.com>
Signed-off-by: Aaron Watry <awatry@gmail.com>
NOTE: This is a candidate for the 3.3 branch.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181579
91177308-0d34-0410-b5e6-
96231b3b80d8
Tom Stellard [Fri, 10 May 2013 02:09:34 +0000 (02:09 +0000)]
R600: Expand MUL for v4i32/v2i32
Fixes piglit test for OpenCL builtin mul24, and allows mad24 to run.
Patch by: Aaron Watry
Reviewed-by: Tom Stellard <thomas.stellard@amd.com>
Signed-off-by: Aaron Watry <awatry@gmail.com>
NOTE: This is a candidate for the 3.3 branch.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181578
91177308-0d34-0410-b5e6-
96231b3b80d8
Tom Stellard [Fri, 10 May 2013 02:09:29 +0000 (02:09 +0000)]
R600: Expand SRA for v4i32/v2i32
v2: Add v4i32 test
Patch by: Aaron Watry
Reviewed-by: Tom Stellard <thomas.stellard@amd.com>
Signed-off-by: Aaron Watry <awatry@gmail.com>
NOTE: This is a candidate for the 3.3 branch.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181577
91177308-0d34-0410-b5e6-
96231b3b80d8
Tom Stellard [Fri, 10 May 2013 02:09:24 +0000 (02:09 +0000)]
R600: Expand vselect for v4i32 and v2i32
v2: Add vselect v4i32 test
Patch by: Aaron Watry
Reviewed-by: Tom Stellard <thomas.stellard@amd.com>
Signed-off-by: Aaron Watry <awatry@gmail.com>
NOTE: This is a candidate for the 3.3 branch.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181576
91177308-0d34-0410-b5e6-
96231b3b80d8
Chad Rosier [Thu, 9 May 2013 23:48:53 +0000 (23:48 +0000)]
[x86AsmParser] It's valid to stop parsing an operand at an immediate.
rdar://
13854369 and PR15944
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181564
91177308-0d34-0410-b5e6-
96231b3b80d8
Owen Anderson [Thu, 9 May 2013 22:27:13 +0000 (22:27 +0000)]
Teach SelectionDAG to constant fold all-constant FMA nodes the same way that it constant folds FADD, FMUL, etc.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181555
91177308-0d34-0410-b5e6-
96231b3b80d8
Dmitri Gribenko [Thu, 9 May 2013 21:16:18 +0000 (21:16 +0000)]
Fix a documentation warning: \bried -> \brief
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181551
91177308-0d34-0410-b5e6-
96231b3b80d8
Dmitri Gribenko [Thu, 9 May 2013 21:15:03 +0000 (21:15 +0000)]
Documentation warning: \param, not \parm
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181549
91177308-0d34-0410-b5e6-
96231b3b80d8
Jordan Rose [Thu, 9 May 2013 21:07:43 +0000 (21:07 +0000)]
Rewrite assert to avoid warning when the record element type is byte-sized.
BitstreamWriter asserts that when blob data is written from the record
element vector, each element fits in a byte. However, if the record
elements are specified as a SmallVector of 'char', this causes a warning
from -Wtautological-constant-out-of-range-compare. Fix this by using
llvm::isUInt<8> instead of a plain comparison against 256.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181545
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Thu, 9 May 2013 20:10:38 +0000 (20:10 +0000)]
Generate a compact unwind encoding in the face of a stack alignment push.
We generate a `push' of a random register (%rax) if the stack needs to be
aligned by the size of that register. However, this could mess up compact unwind
generation. In particular, we want to still generate compact unwind in the
presence of this monstrosity.
Check if the push of of the %rax/%eax register. If it is and it's marked with
the `FrameSetup' flag, then we can generate a compact unwind encoding for the
function only if the push is the last FrameSetup instruction.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181540
91177308-0d34-0410-b5e6-
96231b3b80d8
Jyotsna Verma [Thu, 9 May 2013 19:16:07 +0000 (19:16 +0000)]
Hexagon: Remove switch cases from GetDotNewPredOp and isPostIncrement functions.
No functionality change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181535
91177308-0d34-0410-b5e6-
96231b3b80d8
Shuxin Yang [Thu, 9 May 2013 18:34:27 +0000 (18:34 +0000)]
[GVN] Split critical-edge on the fly, instead of postpone edge-splitting to next
iteration.
This on step toward non-iterative GVN. My local hack suggests that getting rid
of iteration will speedup GVN by 30%+ on a medium sized input (2k LOC, C++).
I cannot explain why not 2x or more at this moment.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181532
91177308-0d34-0410-b5e6-
96231b3b80d8
Jyotsna Verma [Thu, 9 May 2013 18:25:44 +0000 (18:25 +0000)]
Hexagon: Use relation map for getMatchingCondBranchOpcode() and
getInvertedPredicatedOpcode() functions instead of switch cases.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181530
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Thu, 9 May 2013 18:21:45 +0000 (18:21 +0000)]
Simplify the code a bit.
The compact unwind registers were defined in two different
places. It's better just to place them in the function that uses them
and specify that this is a 64-bit or 32-bit machine.
No functionality change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181529
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Thu, 9 May 2013 17:22:59 +0000 (17:22 +0000)]
Don't replace an alias in llvm.used with its target.
When we replace an internal alias with its target, be careful not to
replace the entry in llvm.used (and llvm.compiler_used).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181524
91177308-0d34-0410-b5e6-
96231b3b80d8
Richard Osborne [Thu, 9 May 2013 16:43:42 +0000 (16:43 +0000)]
[XCore] Fix handling of functions where only the LR is spilled.
Previously we only checked if the LR required saving if the frame size was
non zero. However because the caller reserves 1 word for the callee to use
that doesn't count towards our frame size it is possible for the LR to need
saving and for the frame size to be 0.
We didn't hit when the LR needed saving because of a function calls because
the 1 word of stack we must allocate for our callee means the frame size
is always non zero in this case. However we can hit this case if the LR is
clobbered in inline asm.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181520
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Thu, 9 May 2013 16:32:32 +0000 (16:32 +0000)]
InstCombine: Don't just copy known bits from the first operand of an srem.
That's obviously wrong. Conservatively restrict it to the sign bit, which
matches the original intention of this analysis. Fixes PR15940.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181518
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Thu, 9 May 2013 15:10:36 +0000 (15:10 +0000)]
Avoid runtime type checks.
In most cases the relocation type implies the object word size and
endianness.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181515
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Thu, 9 May 2013 13:48:26 +0000 (13:48 +0000)]
libDebugInfo depends on libObject nowadays.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181510
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Thu, 9 May 2013 13:13:28 +0000 (13:13 +0000)]
Introduce convenience typedefs for the 4 ELF object types.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181509
91177308-0d34-0410-b5e6-
96231b3b80d8
Kai Nacke [Thu, 9 May 2013 12:32:36 +0000 (12:32 +0000)]
Test commit.
Add one of my contributions to CREDITS.TXT.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181508
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Thu, 9 May 2013 03:39:05 +0000 (03:39 +0000)]
Change getRelocationAdditionalInfo to be ELF only.
It was only implemented for ELF where it collected the Addend, so this
patch also renames it to getRelocationAddend.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181502
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Thu, 9 May 2013 00:42:33 +0000 (00:42 +0000)]
Revert "Make sure debug info contains linkage names (DW_AT_MIPS_linkage_name)"
temporarily while investigating gdb.cp/templates.exp.
This reverts commit r181471.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181496
91177308-0d34-0410-b5e6-
96231b3b80d8
Arnold Schwaighofer [Thu, 9 May 2013 00:32:18 +0000 (00:32 +0000)]
LoopVectorizer: Don't assert on the absence of induction variables
A computable loop exit count does not imply the presence of an induction
variable. Scalar evolution can return a value for an infinite loop.
Fixes PR15926.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181495
91177308-0d34-0410-b5e6-
96231b3b80d8
Dmitri Gribenko [Wed, 8 May 2013 22:28:48 +0000 (22:28 +0000)]
Use correct parameter names in comments [-Wdocumentation]
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181478
91177308-0d34-0410-b5e6-
96231b3b80d8
Daniel Malea [Wed, 8 May 2013 21:55:31 +0000 (21:55 +0000)]
Revert 181475 as the DebugIR tests are breaking (automake) buildbots that re-use build dirs
- the temporaries "-debug.ll" files generated by DebugIR pass are considered tests, even though they are not
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181476
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Wed, 8 May 2013 21:23:22 +0000 (21:23 +0000)]
Make sure debug info contains linkage names (DW_AT_MIPS_linkage_name)
for constructors and destructors since the original declaration given
by the AT_specification both won't and can't.
Patch by Yacine Belkadi, I've cleaned up the testcases.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181471
91177308-0d34-0410-b5e6-
96231b3b80d8
Daniel Malea [Wed, 8 May 2013 21:03:00 +0000 (21:03 +0000)]
DebugIR tests -- lit tests for the line number transform
- simple one-function case
- function-calling case
- external function calling case
- exception throwing case
- vector case
Note: these tests are somewhat coupled to the current format of debug metadata.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181469
91177308-0d34-0410-b5e6-
96231b3b80d8
Daniel Malea [Wed, 8 May 2013 20:44:14 +0000 (20:44 +0000)]
Add DebugIR pass -- emits IR file and replace source lines with IR lines in MD
- requires existing debug information to be present
- fixes up file name and line number information in metadata
- emits a "<orig_filename>-debug.ll" succinct IR file (without !dbg metadata
or debug intrinsics) that can be read by a debugger
- initialize pass in opt tool to enable the "-debug-ir" flag
- lit tests to follow
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181467
91177308-0d34-0410-b5e6-
96231b3b80d8
Daniel Malea [Wed, 8 May 2013 20:38:31 +0000 (20:38 +0000)]
Pull up AssemblyWriter interface into header to allow subclassing
- made all functions virtual so that subclasses can specialize them
- add printInstructionLine so that subclasses can choose whether or not to
print the newline character (without having to implement printBasicBlock()
- added a second constructor to AssemblyWriter that does not require a
SlotTracker, as required in order to keep the SlotTracker helper class outside
AsmWriter.h and buried in the implementation.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181466
91177308-0d34-0410-b5e6-
96231b3b80d8
Daniel Malea [Wed, 8 May 2013 20:29:10 +0000 (20:29 +0000)]
Add line tracking support to FormattedStream
- previously formatted_raw_ostream tracked columns, now it tracks lines too
- used by (upcoming) DebugIR pass to know the line number to connect to each IR
instruction
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181463
91177308-0d34-0410-b5e6-
96231b3b80d8
Akira Hatanaka [Wed, 8 May 2013 19:38:04 +0000 (19:38 +0000)]
[mips] Add instruction selection pattern for (seteq $LHS, 0).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181459
91177308-0d34-0410-b5e6-
96231b3b80d8