oota-llvm.git
10 years agoIntegrated assbemler, macros: added 'vararg' argument qualifier support.
Stepan Dyatkovskiy [Wed, 23 Apr 2014 06:56:28 +0000 (06:56 +0000)]
Integrated assbemler, macros: added 'vararg' argument qualifier support.
Note, currently we have no 'vararg' support for darwin macros.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206951 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[ARM64] Enable feature predicates for NEON / FP / CRYPTO.
Kevin Qin [Wed, 23 Apr 2014 06:22:48 +0000 (06:22 +0000)]
[ARM64] Enable feature predicates for NEON / FP / CRYPTO.

AArch64 has feature predicates for NEON, FP and CRYPTO instructions.
This allows the compiler to generate code without using FP, NEON
or CRYPTO instructions.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206949 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[LCG] Hoist the logic for forming a new SCC from the top of the DFSStack
Chandler Carruth [Wed, 23 Apr 2014 06:09:03 +0000 (06:09 +0000)]
[LCG] Hoist the logic for forming a new SCC from the top of the DFSStack
into a helper function. I plan to re-use it for doing incremental
DFS-based updates to the SCCs when we mutate the call graph.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206948 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[LCG] Switch the Callee sets to be DenseMaps pointing to the index into
Chandler Carruth [Wed, 23 Apr 2014 04:00:17 +0000 (04:00 +0000)]
[LCG] Switch the Callee sets to be DenseMaps pointing to the index into
the Callee list. This is going to be quite important to prevent removal
from going quadratic. No functionality changed at this point, this is
one of the refactoring patches I've broken out of my initial work toward
mutation updates of the call graph.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206938 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoFix test/CodeGen/arm.ll
Reid Kleckner [Wed, 23 Apr 2014 01:09:29 +0000 (01:09 +0000)]
Fix test/CodeGen/arm.ll

The 'CHECK: add' line was occasionally matching against the filename,
breaking the subsequent CHECK-NOT.  Also use CHECK-LABEL.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206936 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoRequisite reformatting for previous commit.
David Blaikie [Tue, 22 Apr 2014 23:09:36 +0000 (23:09 +0000)]
Requisite reformatting for previous commit.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206927 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoPush memory ownership of DwarfUnits into clients of DwarfFile.
David Blaikie [Tue, 22 Apr 2014 22:39:41 +0000 (22:39 +0000)]
Push memory ownership of DwarfUnits into clients of DwarfFile.

This prompted me to push references through most of DwarfDebug. Sorry
for the churn.

Honestly it's a bit silly that we're passing around units all over the
place like that anyway and I think it's mostly due to the DIE attribute
adding utility functions being utilities in DwarfUnit. I should have
another go at moving them out of DwarfUnit...

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206925 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[docs] Add a note to docs/README.txt
Sean Silva [Tue, 22 Apr 2014 21:47:53 +0000 (21:47 +0000)]
[docs] Add a note to docs/README.txt

Added note to docs/README.txt on how to check the reachibility of
external links in the documentation.

Patch by Dan Liew!

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206924 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoChange the prototype for MCContext::FatalError() so it can be called
Kevin Enderby [Tue, 22 Apr 2014 21:42:18 +0000 (21:42 +0000)]
Change the prototype for MCContext::FatalError() so it can be called
from places like MCCodeEmitter() in the MC backend when the
MCContext is const.

I was going to use this in my change for r206669 but Jim convinced
me to use an assert there. But this still is a good tweak.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206923 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoUse std::unique_ptr to handle ownership of DwarfUnits in DwarfFile.
David Blaikie [Tue, 22 Apr 2014 21:27:37 +0000 (21:27 +0000)]
Use std::unique_ptr to handle ownership of DwarfUnits in DwarfFile.

So Chandler - how about those range algorithms? (would really love a
dereferencing range adapter for this sort of stuff)

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206921 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoWhitespace
Rui Ueyama [Tue, 22 Apr 2014 19:52:05 +0000 (19:52 +0000)]
Whitespace

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206919 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoNo need to check condition after grow()
Rui Ueyama [Tue, 22 Apr 2014 19:47:26 +0000 (19:47 +0000)]
No need to check condition after grow()

r206916 was not logically the same as the previous code because the
goto statements did not create loop. This should be the same as the
previous code.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206918 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoFollow aliases when determining if a symbol is thumb.
Rafael Espindola [Tue, 22 Apr 2014 19:11:07 +0000 (19:11 +0000)]
Follow aliases when determining if a symbol is thumb.

This fixes pr19484.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206917 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoReplace loops using goto with plain while loops
Rui Ueyama [Tue, 22 Apr 2014 19:07:14 +0000 (19:07 +0000)]
Replace loops using goto with plain while loops

Goto statements jumping into previous inner blocks are pretty confusing
to read even though in this case they are valid. No reason to not use
while loops there.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206916 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[Constant Hoisting] Materialize the constant before the cloned cast instruction.
Juergen Ributzka [Tue, 22 Apr 2014 18:06:58 +0000 (18:06 +0000)]
[Constant Hoisting] Materialize the constant before the cloned cast instruction.

In the case where the constant comes from a cloned cast instruction, the
materialization code has to go before the cloned cast instruction.

This commit fixes the method that finds the materialization insertion point
by making it aware of this case.

This fixes <rdar://problem/15532441>

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206913 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[Constant Hoisting] Print the instructions in the correct order for debugging. No...
Juergen Ributzka [Tue, 22 Apr 2014 18:06:51 +0000 (18:06 +0000)]
[Constant Hoisting] Print the instructions in the correct order for debugging. No functional change.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206912 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoFix DataLayout::operator==().
Rafael Espindola [Tue, 22 Apr 2014 17:47:03 +0000 (17:47 +0000)]
Fix DataLayout::operator==().

Patch by Maks Naumov!

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206911 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoFix the assembler to print a better relocatable expression error
Kevin Enderby [Tue, 22 Apr 2014 17:27:29 +0000 (17:27 +0000)]
Fix the assembler to print a better relocatable expression error
diagnostic that includes location information.

Currently if one has this assembly:

.quad (0x1234 + (4 * SOME_VALUE))

where SOME_VALUE is undefined ones gets the less than
useful error message with no location information:

% clang -c x.s
clang -cc1as: fatal error: error in backend: expected relocatable expression

With this fix one now gets a more useful error message
with location information:

% clang -c x.s
x.s:5:8: error: expected relocatable expression
 .quad (0x1234 + (4 * SOME_VALUE))
       ^

To do this I plumbed the SMLoc through the MCObjectStreamer
EmitValue() and EmitValueImpl() interfaces so it could be used
when creating the MCFixup.

rdar://12391022

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206906 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoSimplify address pool index assignment.
David Blaikie [Tue, 22 Apr 2014 17:21:40 +0000 (17:21 +0000)]
Simplify address pool index assignment.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206905 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoR600: Emit error instead of unreachable on function call
Matt Arsenault [Tue, 22 Apr 2014 16:42:00 +0000 (16:42 +0000)]
R600: Emit error instead of unreachable on function call

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206904 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoR600/SI: Reorganize SIInstructions.td
Tom Stellard [Tue, 22 Apr 2014 16:33:57 +0000 (16:33 +0000)]
R600/SI: Reorganize SIInstructions.td

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206902 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoAVX-512: store and truncstore for i1 values
Elena Demikhovsky [Tue, 22 Apr 2014 14:13:10 +0000 (14:13 +0000)]
AVX-512: store and truncstore for i1 values

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206897 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoRemove DOS CRLF.
NAKAMURA Takumi [Tue, 22 Apr 2014 13:35:50 +0000 (13:35 +0000)]
Remove DOS CRLF.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206894 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoAArch64/ARM64: more testing from AArch64 to ARM64
Tim Northover [Tue, 22 Apr 2014 12:45:47 +0000 (12:45 +0000)]
AArch64/ARM64: more testing from AArch64 to ARM64

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206889 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoAArch64/ARM64: make use of ANDS and BICS instructions for comparisons.
Tim Northover [Tue, 22 Apr 2014 12:45:42 +0000 (12:45 +0000)]
AArch64/ARM64: make use of ANDS and BICS instructions for comparisons.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206888 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoAArch64/ARM64: add extra testing from AArch64 to ARM64
Tim Northover [Tue, 22 Apr 2014 12:45:32 +0000 (12:45 +0000)]
AArch64/ARM64: add extra testing from AArch64 to ARM64

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206887 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[X86] Require HasBMI2 for the new BZHI tablegen patterns.
Lang Hames [Tue, 22 Apr 2014 12:04:53 +0000 (12:04 +0000)]
[X86] Require HasBMI2 for the new BZHI tablegen patterns.

Evidently tablegen doesn't infer this from the HasBMI2 predicate on the BZHI
instructions. This should fix the recent bot failures.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206885 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[AVX512] Implemented integer conversions up/down with masking.
Robert Khasanov [Tue, 22 Apr 2014 11:36:19 +0000 (11:36 +0000)]
[AVX512] Implemented integer conversions up/down with masking.
Added encoding tests.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206884 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[asan] Support outline instrumentation for wide types and delete dead code, patch...
Kostya Serebryany [Tue, 22 Apr 2014 11:19:45 +0000 (11:19 +0000)]
[asan] Support outline instrumentation for wide types and delete dead code, patch by Yuri Gribov

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206883 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[X86] Remove Tablegen def of X86bzhi SDNode: It's not needed as of r206879.
Lang Hames [Tue, 22 Apr 2014 10:50:46 +0000 (10:50 +0000)]
[X86] Remove Tablegen def of X86bzhi SDNode: It's not needed as of r206879.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206880 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[X86] Use tablegen instead of DAG combines to match BZHI instructions, as
Lang Hames [Tue, 22 Apr 2014 10:41:56 +0000 (10:41 +0000)]
[X86] Use tablegen instead of DAG combines to match BZHI instructions, as
suggested by Ben Kramer in review of r206738.

Thanks again Ben!

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206879 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[mips] Clang-format MipsAsmParser.
Matheus Almeida [Tue, 22 Apr 2014 10:15:54 +0000 (10:15 +0000)]
[mips] Clang-format MipsAsmParser.

No functional changes.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206878 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoAArch64/ARM64: enable various AArch64 tests on ARM64.
Tim Northover [Tue, 22 Apr 2014 10:10:26 +0000 (10:10 +0000)]
AArch64/ARM64: enable various AArch64 tests on ARM64.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206877 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoAArch64/ARM64: add patterns for scalar_to_vector/extract pairs
Tim Northover [Tue, 22 Apr 2014 10:10:18 +0000 (10:10 +0000)]
AArch64/ARM64: add patterns for scalar_to_vector/extract pairs

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206876 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoAArch64/ARM64: mark fmul intrinsic as commutative.
Tim Northover [Tue, 22 Apr 2014 10:10:14 +0000 (10:10 +0000)]
AArch64/ARM64: mark fmul intrinsic as commutative.

This gives DAG patterns matching indexed patterns where either side is an
indexed vector.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206875 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoARM: disable emission of __XYZvfp in soft-float environment.
Tim Northover [Tue, 22 Apr 2014 10:10:09 +0000 (10:10 +0000)]
ARM: disable emission of __XYZvfp in soft-float environment.

The point of these calls is to allow Thumb-1 code to make use of the VFP unit
to perform its operations. This is not desirable with -msoft-float, since most
of the reasons you'd want that apply equally to the runtime library.

rdar://problem/13766161

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206874 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoFix an infinite loop bug in DAG Combine about keeping transfering between ANY_EXTEND...
Hao Liu [Tue, 22 Apr 2014 09:57:06 +0000 (09:57 +0000)]
Fix an infinite loop bug in DAG Combine about keeping transfering between ANY_EXTEND and SIGN_EXTEND.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206873 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[X86] Don't use BZHI for short masks (>=32 bits). Thanks to Ben Kramer for the
Lang Hames [Tue, 22 Apr 2014 07:40:34 +0000 (07:40 +0000)]
[X86] Don't use BZHI for short masks (>=32 bits). Thanks to Ben Kramer for the
review.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206869 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoRevert "Use value semantics to manage DbgVariables rather than dynamic allocation...
David Blaikie [Tue, 22 Apr 2014 05:41:06 +0000 (05:41 +0000)]
Revert "Use value semantics to manage DbgVariables rather than dynamic allocation/pointers."

This reverts commit r206780.

This commit was regressing gdb.opt/inline-locals.exp in the GDB 7.5 test
suite. Reverting until I can fix the issue.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206867 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoUse unique_ptr to manage ParsedBinariesAndObjects in LLVMSymbolizer
David Blaikie [Tue, 22 Apr 2014 05:26:14 +0000 (05:26 +0000)]
Use unique_ptr to manage ParsedBinariesAndObjects in LLVMSymbolizer

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206866 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoR600: Change how vector truncating stores are packed.
Matt Arsenault [Tue, 22 Apr 2014 04:11:14 +0000 (04:11 +0000)]
R600: Change how vector truncating stores are packed.

Don't introduce new operations on an illegal sub 32-bit type.
Do the operations on a 32-bit value, and then use a truncating store.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206864 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoR600: Make sign_extend_inreg legal.
Matt Arsenault [Tue, 22 Apr 2014 03:49:30 +0000 (03:49 +0000)]
R600: Make sign_extend_inreg legal.

Don't know why I didn't just do this in the first place.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206862 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[AArch64] Enable global merge pass.
Jiangning Liu [Tue, 22 Apr 2014 03:33:26 +0000 (03:33 +0000)]
[AArch64] Enable global merge pass.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206861 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoblockfreq: Skip irreducible backedges inside functions
Duncan P. N. Exon Smith [Tue, 22 Apr 2014 03:31:53 +0000 (03:31 +0000)]
blockfreq: Skip irreducible backedges inside functions

The branch that skips irreducible backedges was only active when
propagating mass at the top-level.  In particular, when propagating mass
through a loop recognized by `LoopInfo` with irreducible control flow
inside, irreducible backedges would not be skipped.

Not sure where that idea came from, but the result was that mass was
lost until after loop exit.  Added a testcase that covers this case.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206860 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoblockfreq: Rename PackagedLoops => Loops
Duncan P. N. Exon Smith [Tue, 22 Apr 2014 03:31:50 +0000 (03:31 +0000)]
blockfreq: Rename PackagedLoops => Loops

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206859 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoblockfreq: Use a pointer for ContainingLoop too
Duncan P. N. Exon Smith [Tue, 22 Apr 2014 03:31:44 +0000 (03:31 +0000)]
blockfreq: Use a pointer for ContainingLoop too

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206858 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoblockfreq: Use pointers to loops instead of an index
Duncan P. N. Exon Smith [Tue, 22 Apr 2014 03:31:37 +0000 (03:31 +0000)]
blockfreq: Use pointers to loops instead of an index

Store pointers directly to loops inside the nodes.  This could have been
done without changing the type stored in `std::vector<>`.  However,
rather than computing the number of loops before constructing them
(which `LoopInfo` doesn't provide directly), I've switched to a
`vector<unique_ptr<LoopData>>`.

This adds some heap overhead, but the number of loops is typically
small.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206857 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoblockfreq: Implement clear() explicitly
Duncan P. N. Exon Smith [Tue, 22 Apr 2014 03:31:34 +0000 (03:31 +0000)]
blockfreq: Implement clear() explicitly

This was implicitly with copy assignment before, which fails to actually
clear `std::vector<>`'s heap storage.  Move assignment would work, but
since MSVC can't imply those anyway, explicitly `clear()`-ing members
makes more sense.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206856 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoblockfreq: Rename PackagedLoopData => LoopData
Duncan P. N. Exon Smith [Tue, 22 Apr 2014 03:31:31 +0000 (03:31 +0000)]
blockfreq: Rename PackagedLoopData => LoopData

No functionality change.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206855 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoblockfreq: Move PackagedLoopData above WorkingData
Duncan P. N. Exon Smith [Tue, 22 Apr 2014 03:31:25 +0000 (03:31 +0000)]
blockfreq: Move PackagedLoopData above WorkingData

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206854 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoblockfreq: Remove "dead" comment
Duncan P. N. Exon Smith [Tue, 22 Apr 2014 03:31:23 +0000 (03:31 +0000)]
blockfreq: Remove "dead" comment

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206853 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[Modules] Fix potential ODR violations by sinking the DEBUG_TYPE
Chandler Carruth [Tue, 22 Apr 2014 03:10:36 +0000 (03:10 +0000)]
[Modules] Fix potential ODR violations by sinking the DEBUG_TYPE
definition below all of the header #include lines, tools edition.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206848 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[Modules] Fix potential ODR violations by sinking the DEBUG_TYPE
Chandler Carruth [Tue, 22 Apr 2014 03:07:47 +0000 (03:07 +0000)]
[Modules] Fix potential ODR violations by sinking the DEBUG_TYPE
definition below all of the header #include lines, lib/Support edition.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206847 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[Modules] Fix potential ODR violations by sinking the DEBUG_TYPE
Chandler Carruth [Tue, 22 Apr 2014 03:06:00 +0000 (03:06 +0000)]
[Modules] Fix potential ODR violations by sinking the DEBUG_TYPE
definition below all of the header #include lines, TableGen edition.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206846 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[Modules] Fix potential ODR violations by sinking the DEBUG_TYPE
Chandler Carruth [Tue, 22 Apr 2014 03:04:17 +0000 (03:04 +0000)]
[Modules] Fix potential ODR violations by sinking the DEBUG_TYPE
definition below all the header #include lines. This updates most of the
miscellaneous other lib/... directories. A few left though.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206845 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[Modules] Fix potential ODR violations by sinking the DEBUG_TYPE
Chandler Carruth [Tue, 22 Apr 2014 02:55:47 +0000 (02:55 +0000)]
[Modules] Fix potential ODR violations by sinking the DEBUG_TYPE
definition below all of the header #include lines, lib/Transforms/...
edition.

This one is tricky for two reasons. We again have a couple of passes
that define something else before the includes as well. I've sunk their
name macros with the DEBUG_TYPE.

Also, InstCombine contains headers that need DEBUG_TYPE, so now those
headers #define and #undef DEBUG_TYPE around their code, leaving them
well formed modular headers. Fixing these headers was a large motivation
for all of these changes, as "leaky" macros of this form are hard on the
modules implementation.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206844 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[Modules] Fix potential ODR violations by sinking the DEBUG_TYPE
Chandler Carruth [Tue, 22 Apr 2014 02:48:03 +0000 (02:48 +0000)]
[Modules] Fix potential ODR violations by sinking the DEBUG_TYPE
definition below all the header #include lines, lib/Analysis/...
edition.

This one has a bit extra as there were *other* #define's before #include
lines in addition to DEBUG_TYPE. I've sunk all of them as a block.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206843 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[Modules] Fix potential ODR violations by sinking the DEBUG_TYPE
Chandler Carruth [Tue, 22 Apr 2014 02:41:26 +0000 (02:41 +0000)]
[Modules] Fix potential ODR violations by sinking the DEBUG_TYPE
definition below all of the header #include lines, lib/Target/...
edition.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206842 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[cleanup] Fix two headers where we included a standard library header
Chandler Carruth [Tue, 22 Apr 2014 02:28:45 +0000 (02:28 +0000)]
[cleanup] Fix two headers where we included a standard library header
after including the generated code from tablegen.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206841 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[cleanup] Fix another place where we were including the tablegen'ed code
Chandler Carruth [Tue, 22 Apr 2014 02:25:17 +0000 (02:25 +0000)]
[cleanup] Fix another place where we were including the tablegen'ed code
of a '.inc' file before including actual headers. In this case we had
both duplicated a header's include and were including a standard header.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206840 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoThis reverts r206828 until David has time to figure out that is going on.
Quentin Colombet [Tue, 22 Apr 2014 02:17:11 +0000 (02:17 +0000)]
This reverts r206828 until David has time to figure out that is going on.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206839 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[cleanup] Lift using directives, DEBUG_TYPE definitions, and even some
Chandler Carruth [Tue, 22 Apr 2014 02:03:14 +0000 (02:03 +0000)]
[cleanup] Lift using directives, DEBUG_TYPE definitions, and even some
system headers above the includes of generated '.inc' files that
actually contain code. In a few targets this was already done pretty
consistently, but it wasn't done *really* consistently anywhere. It is
strictly cleaner IMO and necessary in a bunch of places where the
DEBUG_TYPE is referenced from the generated code. Consistency with the
necessary places trumps. Hopefully the build bots are OK with the
movement of intrin.h...

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206838 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[Modules] Remove potential ODR violations by sinking the DEBUG_TYPE
Chandler Carruth [Tue, 22 Apr 2014 02:02:50 +0000 (02:02 +0000)]
[Modules] Remove potential ODR violations by sinking the DEBUG_TYPE
define below all header includes in the lib/CodeGen/... tree. While the
current modules implementation doesn't check for this kind of ODR
violation yet, it is likely to grow support for it in the future. It
also removes one layer of macro pollution across all the included
headers.

Other sub-trees will follow.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206837 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[CodeGenPrepare] Use APInt to check the value of the immediate in a and
Quentin Colombet [Tue, 22 Apr 2014 01:20:34 +0000 (01:20 +0000)]
[CodeGenPrepare] Use APInt to check the value of the immediate in a and
while checking candidate for bit field extract.
Otherwise the value may not fit in uint64_t and this will trigger an
assertion.

This fixes PR19503.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206834 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[Modules] Followup to r206822 to add a DEBUG_TYPE which is used on ARM
Chandler Carruth [Mon, 21 Apr 2014 23:58:10 +0000 (23:58 +0000)]
[Modules] Followup to r206822 to add a DEBUG_TYPE which is used on ARM
and PPC, but not x86.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206830 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoUse unique_ptr to handle ownership of Value*s in Cloning unit tests.
David Blaikie [Mon, 21 Apr 2014 23:47:47 +0000 (23:47 +0000)]
Use unique_ptr to handle ownership of Value*s in Cloning unit tests.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206828 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoFix wrong iterator type
Rui Ueyama [Mon, 21 Apr 2014 23:00:42 +0000 (23:00 +0000)]
Fix wrong iterator type

ELFEntityIterator does not implement RandomAccessIterator. It does
not even implement BidirectionalIterator.

This patch fixes LLD build issue when compiled with MSVC2013 with
debug: MSVC's find_if checks if the start iterator is before the end
iterator in the sense of operator< if it declares implementing
RandomAccessIterator. If a class does not have operator<, it fails
to compile.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206825 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoSimplify DFAPacketizerEmitter State copy/move semantics to use compiler defaults.
David Blaikie [Mon, 21 Apr 2014 22:58:00 +0000 (22:58 +0000)]
Simplify DFAPacketizerEmitter State copy/move semantics to use compiler defaults.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206824 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[Modules] Make Support/Debug.h modular. This requires it to not change
Chandler Carruth [Mon, 21 Apr 2014 22:55:11 +0000 (22:55 +0000)]
[Modules] Make Support/Debug.h modular. This requires it to not change
behavior based on other files defining DEBUG_TYPE, which means it cannot
define DEBUG_TYPE at all. This is actually better IMO as it forces folks
to define relevant DEBUG_TYPEs for their files. However, it requires all
files that currently use DEBUG(...) to define a DEBUG_TYPE if they don't
already. I've updated all such files in LLVM and will do the same for
other upstream projects.

This still leaves one important change in how LLVM uses the DEBUG_TYPE
macro going forward: we need to only define the macro *after* header
files have been #include-ed. Previously, this wasn't possible because
Debug.h required the macro to be pre-defined. This commit removes that.
By defining DEBUG_TYPE after the includes two things are fixed:

- Header files that need to provide a DEBUG_TYPE for some inline code
  can do so by defining the macro before their inline code and undef-ing
  it afterward so the macro does not escape.

- We no longer have rampant ODR violations due to including headers with
  different DEBUG_TYPE definitions. This may be mostly an academic
  violation today, but with modules these types of violations are easy
  to check for and potentially very relevant.

Where necessary to suppor headers with DEBUG_TYPE, I have moved the
definitions below the includes in this commit. I plan to move the rest
of the DEBUG_TYPE macros in LLVM in subsequent commits; this one is big
enough.

The comments in Debug.h, which were hilariously out of date already,
have been updated to reflect the recommended practice going forward.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206822 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoFix builds that use an stl missing std::set::emplace
David Blaikie [Mon, 21 Apr 2014 22:46:09 +0000 (22:46 +0000)]
Fix builds that use an stl missing std::set::emplace

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206821 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoStore State objects by value in TableGen's DFAPacketizerEmitter
David Blaikie [Mon, 21 Apr 2014 22:35:11 +0000 (22:35 +0000)]
Store State objects by value in TableGen's DFAPacketizerEmitter

Removes some extra manual dynamic memory allocation/management. It does
get a bit quirky having to make State's members mutable and
pointers/references to const rather than non-const, but that's a
necessary workaround to dealing with the std::set elements.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206807 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoSet default value of HasExtractBitsInsn to false
Yi Jiang [Mon, 21 Apr 2014 22:22:44 +0000 (22:22 +0000)]
Set default value of HasExtractBitsInsn to false

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206803 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoARM64: Refactor away a few redundant helpers.
Jim Grosbach [Mon, 21 Apr 2014 22:13:57 +0000 (22:13 +0000)]
ARM64: Refactor away a few redundant helpers.

The comment claimed that the register class information wasn't available
in the assembly parser, but that's not really true. It's just annoying to
get to. Replace the helper functions with references to the auto-generated
information.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206802 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoSimplify a vpermil* with constant mask.
Rafael Espindola [Mon, 21 Apr 2014 22:06:04 +0000 (22:06 +0000)]
Simplify a vpermil* with constant mask.

With a constant mask a vpermil* is just a shufflevector. This patch implements
that simplification. This allows us to produce denser code. It should also
allow more folding down the line.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206801 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoUse Regex objects by value (rather than 'new'ed) in CodeGenSchedule.
David Blaikie [Mon, 21 Apr 2014 21:49:08 +0000 (21:49 +0000)]
Use Regex objects by value (rather than 'new'ed) in CodeGenSchedule.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206800 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoARM64: Improve diagnostics for malformed reg+reg addressing mode.
Jim Grosbach [Mon, 21 Apr 2014 21:45:57 +0000 (21:45 +0000)]
ARM64: Improve diagnostics for malformed reg+reg addressing mode.

Make sure only general purpose registers are valid for offset regs and
that 32-bit regs are only valid for sxtw and uxtw extends.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206799 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoMove helper functions earlier in the file.
Jim Grosbach [Mon, 21 Apr 2014 21:45:53 +0000 (21:45 +0000)]
Move helper functions earlier in the file.

No functional change.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206798 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoARM64: Extended addressing mode source reg is 64-bit.
Jim Grosbach [Mon, 21 Apr 2014 21:45:44 +0000 (21:45 +0000)]
ARM64: Extended addressing mode source reg is 64-bit.

The canonical form for the extended addressing mode (e.g.,
"[x1, w2, uxtw #3]" is for the MCInst to have the second register be the
full 64-bit GPR64 register class. The instruction printer cleans up
the output for display to show the 32-bit register instead, per the
specification.

This simplifies 205893 now that the aliasing is handled in the printer
in 206495 so that the codegen path and the disassembler path give the
same MCInst form.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206797 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoUse unique_ptr to manage ownership of GCOVFunctions, Blocks, and Edges.
David Blaikie [Mon, 21 Apr 2014 21:40:16 +0000 (21:40 +0000)]
Use unique_ptr to manage ownership of GCOVFunctions, Blocks, and Edges.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206796 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoRemove seemingly-unneeded artificial dependency
Hal Finkel [Mon, 21 Apr 2014 21:30:25 +0000 (21:30 +0000)]
Remove seemingly-unneeded artificial dependency

The rationale for this artificial dependency seems to have been lost to the
ravages of time, it is covered by no regression tests, and has no impact on
test-suite performance numbers on either x86 or PPC.

For the test suite, on both x86 and PPC, I ran the test suite 10 times (both as
a baseline and with this change), and found no statistically-significant
changes.  For PPC, I used a P7 box. For x86, I used an Intel Xeon E5430. Both
with -O3 -mcpu=native.

This was discussed on-list back in January, but I've not had a chance to run
the performance tests until today.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206795 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoSimplify destruction of Modules in LLVContextImpl.
David Blaikie [Mon, 21 Apr 2014 21:27:19 +0000 (21:27 +0000)]
Simplify destruction of Modules in LLVContextImpl.

This avoids copying the container by simply deleting until empty.

While I'd rather move to a stricter ownership semantic (unique_ptr),
SmallPtrSet can't cope with unique_ptr and the ownership semantics here
are a bit incestuous (Module sort of owns itself, but sort of doesn't
(if the LLVMContext is destroyed before the Module, then it deregisters
itself from the context... )).

Ideally Modules would be given to the context, or possibly an
emplace-like function to construct them there. Modules then shouldn't be
destroyed by LLVM API clients, but by interacting with the owner
(LLVMContext) directly (but even then, passing a Module* to LLVMContext
doesn't provide an easy way to destroy the Module, since the set would
be over unique_ptrs and you'd need a heterogenous lookup function which
SmallPtrSet doesn't have either).

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206794 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoHandle _GLOBAL_OFFSET_TABLE_ in 64 bit mode.
Rafael Espindola [Mon, 21 Apr 2014 21:15:45 +0000 (21:15 +0000)]
Handle _GLOBAL_OFFSET_TABLE_ in 64 bit mode.

With this MC is able to handle _GLOBAL_OFFSET_TABLE_ in 64 bit mode, which is
needed for medium and large code models.

This fixes pr19470.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206793 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoclang-format this function.
Rafael Espindola [Mon, 21 Apr 2014 21:00:58 +0000 (21:00 +0000)]
clang-format this function.

No functionality change, it will just make the next patch easier to read.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206792 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoUse unique_ptr to handle GlobalOpt's Evaluator members
David Blaikie [Mon, 21 Apr 2014 20:49:36 +0000 (20:49 +0000)]
Use unique_ptr to handle GlobalOpt's Evaluator members

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206790 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoFix PR7272 in -tailcallelim instead of the inliner
Reid Kleckner [Mon, 21 Apr 2014 20:48:47 +0000 (20:48 +0000)]
Fix PR7272 in -tailcallelim instead of the inliner

The -tailcallelim pass should be checking if byval or inalloca args can
be captured before marking calls as tail calls.  This was the real root
cause of PR7272.

With a better fix in place, revert the inliner change from r105255.  The
test case it introduced still passes and has been moved to
test/Transforms/Inline/byval-tail-call.ll.

Reviewers: chandlerc

Differential Revision: http://reviews.llvm.org/D3403

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206789 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoSimplify expression that was explicitly naming an operator overload in a call.
David Blaikie [Mon, 21 Apr 2014 20:43:51 +0000 (20:43 +0000)]
Simplify expression that was explicitly naming an operator overload in a call.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206788 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoUse unique_ptr to handle ownership of GCOVFunctions in GCOVProfiler.
David Blaikie [Mon, 21 Apr 2014 20:41:55 +0000 (20:41 +0000)]
Use unique_ptr to handle ownership of GCOVFunctions in GCOVProfiler.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206786 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoUse unique_ptr to handle ownership of UserValues in LiveDebugVariablesImpl
David Blaikie [Mon, 21 Apr 2014 20:37:07 +0000 (20:37 +0000)]
Use unique_ptr to handle ownership of UserValues in LiveDebugVariablesImpl

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206785 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoUse unique_ptr to manage objects owned by the ScheduleDAGMI.
David Blaikie [Mon, 21 Apr 2014 20:32:32 +0000 (20:32 +0000)]
Use unique_ptr to manage objects owned by the ScheduleDAGMI.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206784 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoUse value semantics to manage DbgVariables rather than dynamic allocation/pointers.
David Blaikie [Mon, 21 Apr 2014 20:13:09 +0000 (20:13 +0000)]
Use value semantics to manage DbgVariables rather than dynamic allocation/pointers.

Requires switching some vectors to lists to maintain pointer validity.
These could be changed to forward_lists (singly linked) with a bit more
work - I've left comments to that effect.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206780 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoRename X86insrtps to the proper instruction name.
Filipe Cabecinhas [Mon, 21 Apr 2014 20:07:29 +0000 (20:07 +0000)]
Rename X86insrtps to the proper instruction name.

Summary:
The INSERTPS pattern fragment was called insrtps (mising 'e'), which
would make it harder to grep for the patterns related to this instruction.
Renaming it to use the proper instruction name.

Reviewers: nadav

CC: llvm-commits
Differential Revision: http://reviews.llvm.org/D3443

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206779 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[Modules] Consolidate the DEBUG_TYPE defines in NVPTX to the top of the
Chandler Carruth [Mon, 21 Apr 2014 19:53:55 +0000 (19:53 +0000)]
[Modules] Consolidate the DEBUG_TYPE defines in NVPTX to the top of the
cpp file rather than in the header and then again in the cpp file.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206778 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[Modules] Sink all the DEBUG_TYPE defines for InstCombine out of the
Chandler Carruth [Mon, 21 Apr 2014 19:51:41 +0000 (19:51 +0000)]
[Modules] Sink all the DEBUG_TYPE defines for InstCombine out of the
header files and into the cpp files.

These files will require more touches as the header files actually use
DEBUG(). Eventually, I'll have to introduce a matched #define and #undef
of DEBUG_TYPE for the header files, but that comes as step N of many to
clean all of this up.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206777 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[Modules] Sink the DEBUG_TYPE macro out of LegalizeTypes.h and into the
Chandler Carruth [Mon, 21 Apr 2014 19:43:07 +0000 (19:43 +0000)]
[Modules] Sink the DEBUG_TYPE macro out of LegalizeTypes.h and into the
various .cpp files. This macro is inherently non-modular, and it wasn't
even needed in this header file.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206775 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoARM64: Combine shifts and uses from different basic block to bit-extract instruction
Yi Jiang [Mon, 21 Apr 2014 19:34:27 +0000 (19:34 +0000)]
ARM64: Combine shifts and uses from different basic block to bit-extract instruction

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206774 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoRevert "[rtdyld,c++11] Range'ify symbol table walking."
Jim Grosbach [Mon, 21 Apr 2014 19:23:59 +0000 (19:23 +0000)]
Revert "[rtdyld,c++11] Range'ify symbol table walking."

Tentative revert for
http://lab.llvm.org:8011/builders/llvm-mips-linux/builds/8305.

This reverts commit c2a58efff07294fca724f89500538f2ddbcd12ff.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206773 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoFix unnecessary line break
Matt Arsenault [Mon, 21 Apr 2014 18:39:13 +0000 (18:39 +0000)]
Fix unnecessary line break

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206772 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoblockfreq: Some cleanup of UnsignedFloat
Duncan P. N. Exon Smith [Mon, 21 Apr 2014 18:31:58 +0000 (18:31 +0000)]
blockfreq: Some cleanup of UnsignedFloat

Change `PositiveFloat` to `UnsignedFloat`, and fix some of the comments
to indicate that it's disappearing eventually.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206771 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[rtdyld,c++11] Range'ify symbol table walking.
Jim Grosbach [Mon, 21 Apr 2014 18:10:31 +0000 (18:10 +0000)]
[rtdyld,c++11] Range'ify symbol table walking.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206769 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoTidy up. Remove extraneous typedef.
Jim Grosbach [Mon, 21 Apr 2014 18:10:29 +0000 (18:10 +0000)]
Tidy up. Remove extraneous typedef.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206768 91177308-0d34-0410-b5e6-96231b3b80d8