firefly-linux-kernel-4.4.55.git
9 years agostaging: most: remove multiple blank lines
Christian Gromm [Wed, 21 Oct 2015 15:50:39 +0000 (17:50 +0200)]
staging: most: remove multiple blank lines

This patch removes the usage of multiple blank lines from driver modules.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: IB/ipath: remove sched.h header
Geliang Tang [Sun, 18 Oct 2015 13:57:09 +0000 (21:57 +0800)]
staging: IB/ipath: remove sched.h header

sched.h header in ipath_*.c is now unnecessary, since I have added
sched.h in ipath_kernel.h. So remove it.

Signed-off-by: Geliang Tang <geliangtang@163.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: IB/ipath: use TASK_COMM_LEN in ipath_portdata
Geliang Tang [Sun, 18 Oct 2015 13:57:08 +0000 (21:57 +0800)]
staging: IB/ipath: use TASK_COMM_LEN in ipath_portdata

Use comm[TASK_COMM_LEN] instead of comm[16] in ipath_kernel.h.
And add sched.h header in it.

Signed-off-by: Geliang Tang <geliangtang@163.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: sm750fb: use direct call to hw_sm750_output_setMode
Mike Rapoport [Fri, 23 Oct 2015 14:55:11 +0000 (17:55 +0300)]
staging: sm750fb: use direct call to hw_sm750_output_setMode

The proc_setMode method in lynx_output always uses the same
implementation and there is no point to use redirection rather than
direct function call.

Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: sm750fb: replace lynx_crtc methods with function calls
Mike Rapoport [Fri, 23 Oct 2015 14:55:10 +0000 (17:55 +0300)]
staging: sm750fb: replace lynx_crtc methods with function calls

The methods in lynx_crtc always use the same implementation and there is
no point to use redirection rather than direct function call.

Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: sm750fb: remove unused methods from lynx_share
Mike Rapoport [Fri, 23 Oct 2015 14:55:09 +0000 (17:55 +0300)]
staging: sm750fb: remove unused methods from lynx_share

The suspend and resume methods in lynx_share are not implemented and
never set. Remove them.

Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: sm750fb: remove ancient kernel support
Mike Rapoport [Fri, 23 Oct 2015 14:55:08 +0000 (17:55 +0300)]
staging: sm750fb: remove ancient kernel support

Remove the code that should be compiled for ancient kernel versions
together with controlling '#if LINUX_VERSION_CODE' conditionals

Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: sm750fb: remove defintion of offsetof
Mike Rapoport [Fri, 23 Oct 2015 14:55:07 +0000 (17:55 +0300)]
staging: sm750fb: remove defintion of offsetof

There is no need to redefine offsetof

Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: sm750fb: remove unused pllcalparam typedef
Mike Rapoport [Thu, 22 Oct 2015 06:38:41 +0000 (09:38 +0300)]
staging: sm750fb: remove unused pllcalparam typedef

The pllcalparam type is not used and can be removed.

Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: sm750fb: simplify PLL divisors calculations
Mike Rapoport [Thu, 22 Oct 2015 06:38:40 +0000 (09:38 +0300)]
staging: sm750fb: simplify PLL divisors calculations

The calcPllValues currently uses arrays of PLL parametres that contain
possible PLL control register field values and redundant data that is
calculated according to those values. The usage of these arrays can be
replaced with simple arithmetics.

Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: sm750fb: remove '#if 1' conditionals
Mike Rapoport [Thu, 22 Oct 2015 06:38:39 +0000 (09:38 +0300)]
staging: sm750fb: remove '#if 1' conditionals

The code enclosed in '#if 1' anyway gets compiled. Removing useless
conditionals.

Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: sm750fb: Replace uint32_t with u32
Amitoj Kaur Chawla [Sun, 18 Oct 2015 15:57:57 +0000 (21:27 +0530)]
staging: sm750fb: Replace uint32_t with u32

Replace uint32_t with u32 consistent with Linux kernel coding
practice.
Problem found using checkpatch.pl

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: sm750fb: Replace include <asm/*.h> with include <linux/*.h>
Amitoj Kaur Chawla [Sun, 18 Oct 2015 13:55:10 +0000 (19:25 +0530)]
staging: sm750fb: Replace include <asm/*.h> with include <linux/*.h>

Problem found using checkpatch.pl
WARNING: Use #include <linux/io.h> instead of <asm/io.h>
WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: gdm724x: remove multiple blank lines
Ioana Ciornei [Sun, 18 Oct 2015 12:51:52 +0000 (15:51 +0300)]
staging: gdm724x: remove multiple blank lines

This patch removes multiple blank lines in order to follow linux
kernel coding style.

Signed-off-by: Ioana Ciornei <ciorneiioana@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: gdm724x: correct kzalloc/kmalloc sizeof argument
Ioana Ciornei [Sun, 18 Oct 2015 12:51:51 +0000 (15:51 +0300)]
staging: gdm724x: correct kzalloc/kmalloc sizeof argument

This patch converts sizeof(TYPE) to sizeof(VAR) when used as
a kzalloc/kmaloc argument.

Signed-off-by: Ioana Ciornei <ciorneiioana@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: gdm724x: add spaces around binary operators
Ioana Ciornei [Sun, 18 Oct 2015 12:51:50 +0000 (15:51 +0300)]
staging: gdm724x: add spaces around binary operators

This patch add spaces around binary operators in order
to follow kernel coding style.

Signed-off-by: Ioana Ciornei <ciorneiioana@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostating: gdm724x: remove explicit NULL comparison
Ioana Ciornei [Sun, 18 Oct 2015 12:51:49 +0000 (15:51 +0300)]
stating: gdm724x: remove explicit NULL comparison

This patch converts explicit NULL comparison to its shorter
equivalent form.
Done with coccinelle semantic patch:

@@
expression e;
@@

- e == NULL
+ !e

Signed-off-by: Ioana Ciornei <ciorneiioana@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: gdm724x: properly indent to match open paranthesis
Ioana Ciornei [Sun, 18 Oct 2015 12:51:48 +0000 (15:51 +0300)]
staging: gdm724x: properly indent to match open paranthesis

Indent parameters and arguments passed to function calls to match
open paranthesis

Signed-off-by: Ioana Ciornei <ciorneiioana@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: rdma: Replace kmalloc with kmalloc_array
Cristina Moraru [Wed, 21 Oct 2015 17:00:51 +0000 (20:00 +0300)]
staging: rdma: Replace kmalloc with kmalloc_array

Replace kmalloc with specialized function kmalloc_array
when the size is a multiplication of:
number_of_elements * size_of_element

Signed-off-by: Cristina Moraru <cristina.moraru09@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: lustre: lnet :socklnd Braces not necessary
Nilesh Kokane [Fri, 23 Oct 2015 05:54:04 +0000 (11:24 +0530)]
staging: lustre: lnet :socklnd Braces not necessary

Braces not needed for single statement block

Signed-off-by: Nilesh Kokane <Nilesh.Kokane05@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: lustre: lnet :socklnd return statement in void function not useful
Nilesh Kokane [Fri, 23 Oct 2015 05:32:20 +0000 (11:02 +0530)]
Staging: lustre: lnet :socklnd return statement in void function not useful

Return function in void function is not needed.

Signed-off-by: Nilesh Kokane <Nilesh.Kokane05@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: lustre: lov_obd: fixed a brace coding style issue
Nilesh Kokane [Thu, 22 Oct 2015 17:12:43 +0000 (22:42 +0530)]
Staging: lustre: lov_obd: fixed a brace coding style issue

Fixed a coding style issue.

Signed-off-by: Nilesh kokane <Nilesh.Kokane05@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: lustre: o2iblnd: fix misleading indentation
Luis de Bethencourt [Wed, 21 Oct 2015 17:40:40 +0000 (18:40 +0100)]
staging: lustre: o2iblnd: fix misleading indentation

The code is correct, the indentation is misleading. Only the the return rc
is part of the conditional statement if rc != 0.

Fix a smatch warning:
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:2157
kiblnd_hdev_setup_mrs() warn: curly braces intended?

Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: lustre: Use C99 initializers for struct netstrfns
James Simmons [Thu, 22 Oct 2015 01:52:49 +0000 (21:52 -0400)]
staging: lustre: Use C99 initializers for struct netstrfns

Update struct netstrfns to use C99 initializers.

Remove old LND types from the netstrfns table, as they are
long obsolete and shouldn't be needed even for interop anymore.

Signed-off-by: James Simmons <uja.ornl@yahoo.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6210
Reviewed-on: http://review.whamcloud.com/15088
Reviewed-by: frank zago <fzago@cray.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: lustre: remove last entry of libcfs_netstrfns[]
Frederic Saunier [Thu, 22 Oct 2015 01:52:48 +0000 (21:52 -0400)]
staging: lustre: remove last entry of libcfs_netstrfns[]

Currently NID string handling test for the last entry,
and last entry has .nf_type == (__u32) -1. If we ask
for a non existent LND we hit the last entry which then
calls a strlen on a NULL which causes a error. We can
avoid this problem if we just remove the last entry
since it is not used for anything except as a last
entry marker.

Signed-off-by: Frederic Saunier <frederic.saunier@atos.net>
Signed-off-by: James Simmons <uja.ornl@yahoo.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6501
Reviewed-on: http://review.whamcloud.com/15424
Reviewed-by: frank zago <fzago@cray.com>
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: lustre: provide separate buffers for libcfs_*2str()
Dmitry Eremin [Thu, 22 Oct 2015 01:52:47 +0000 (21:52 -0400)]
staging: lustre: provide separate buffers for libcfs_*2str()

Provide duplicates with separate buffers for libcfs_*2str() functions.

Replace libcfs_nid2str() with libcfs_nid2str_r() function in critical
places.

Provide buffer size for nf_addr2str functions.

Use __u32 as nf_type always

Signed-off-by: Dmitry Eremin <dmitry.eremin@intel.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6070
Reviewed-on: http://review.whamcloud.com/13185
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: lustre: add in NID range management for libcfs
Joshua Walgenbach [Thu, 22 Oct 2015 01:52:46 +0000 (21:52 -0400)]
staging: lustre: add in NID range management for libcfs

This is a partial backport of the NID range management
added in for nodemap. We only backport the libcfs related
parts here.

Signed-off-by: Joshua Walgenbach <jjw@iu.edu>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3527
Reviewed-on: http://review.whamcloud.com/8057
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Andrew Perepechko <andrew_perepechko@xyratex.com>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: Ken Hornstein <kenh@cmf.nrl.navy.mil>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: lustre: Avoid nid range related forward declarations in nidstring.c
James Simmons [Thu, 22 Oct 2015 01:52:45 +0000 (21:52 -0400)]
staging: lustre: Avoid nid range related forward declarations in nidstring.c

Since forward declarations are frowned on upstream we move
the NID range handling to near the start of the nidstring.c
file.

Signed-off-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-on: http://review.whamcloud.com/15086
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6245
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: lustre: move cfs_ip_addr_* function from kernel libcfs to LNet
James Simmons [Thu, 22 Oct 2015 01:52:44 +0000 (21:52 -0400)]
staging: lustre: move cfs_ip_addr_* function from kernel libcfs to LNet

Both of cfs_ip_addr_parse and cfs_ip_addr_match which are located in
libcfs kernel module are used only for LNet so move this into the
nidstring handling code where it belongs. Also create user land
versions of these functions in the libcfs user land library.

Signed-off-by: James Simmons <uja.ornl@yahoo.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6245
Reviewed-on: http://review.whamcloud.com/15085
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: frank zago <fzago@cray.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: lustre: move struct netstrfns to nidstr.h
James Simmons [Thu, 22 Oct 2015 01:52:43 +0000 (21:52 -0400)]
staging: lustre: move struct netstrfns to nidstr.h

The reason struct netstrfns exist in nidstrings.c
was to avoid forward decleration errors. The best
way to handle this instead is to move this structure
to a header file. Since this structure is used in
the userland utilities as well so we place it in
nidstr.h which is exposed to userland.

Signed-off-by: James Simmons <uja.ornl@yahoo.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6245
Reviewed-on: http://review.whamcloud.com/15083
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: lustre: remove cfs_ip_addr_free wrapper
James Simmons [Thu, 22 Oct 2015 01:52:42 +0000 (21:52 -0400)]
staging: lustre: remove cfs_ip_addr_free wrapper

No need to have a one line wrapper in libcfs that only
is used to delete a list which is only done once in the
LNet layer.

Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: lustre: remove libcfs_init_string function
James Simmons [Thu, 22 Oct 2015 01:52:41 +0000 (21:52 -0400)]
staging: lustre: remove libcfs_init_string function

All the function libcfs_init_string did was initialize
a spinlock. We can initialize the spinlock statically
instead.

Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: lustre: move nidstring handling to LNet layer
James Simmons [Thu, 22 Oct 2015 01:52:40 +0000 (21:52 -0400)]
staging: lustre: move nidstring handling to LNet layer

Moved the source file nidstring.c from libcfs to lnet
since that is the only place it is used. With the
move of nidstring to lnet some functions in libcfs
need to be exported. In later patches those functions
that are only used by LNet also will be moved to the
LNet layer. Also add in missing MAX_NUMERIC_VALUE
defination.

Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: lustre: add a service that prints a nidlist
Gregoire Pichon [Thu, 22 Oct 2015 01:52:39 +0000 (21:52 -0400)]
staging: lustre: add a service that prints a nidlist

The libcfs already provides services to parse a string into a nidlist
and to match a nid into a nidlist. This patch implements a service
that prints a nidlist into a buffer.

This is required for instance to print the nosquash_nids parameter
of the MDT procfs component.

Additionally, this patch fixes a bug in return code of
parse_addrange() routine, so that parsing of nids including
a * character works fine ('*@elan' for instance).

Signed-off-by: Gregoire Pichon <gregoire.pichon@bull.net>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-1778
Reviewed-on: http://review.whamcloud.com/9221
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Liang Zhen <liang.zhen@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: James Simmons <uja.ornl@yahoo.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: lustre: remove unused OBD_SLAB_ALLOC* and OBD_SLAB_FREE* macros
Mike Rapoport [Tue, 20 Oct 2015 09:39:53 +0000 (12:39 +0300)]
staging: lustre: remove unused OBD_SLAB_ALLOC* and OBD_SLAB_FREE* macros

The OBD_SLAB_ALLOC* and OBD_SLAB_FREE* macros are not used and can be
removed.

Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: lustre: replace OBD_SLAB_FREE with kmem_cache_free
Mike Rapoport [Tue, 20 Oct 2015 09:39:52 +0000 (12:39 +0300)]
staging: lustre: replace OBD_SLAB_FREE with kmem_cache_free

Use kmem_cache_free directly instead of wrapping macro.

Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: lustre: replace OBD_SLAB_FREE_PTR with kmem_cache_free
Mike Rapoport [Tue, 20 Oct 2015 09:39:51 +0000 (12:39 +0300)]
staging: lustre: replace OBD_SLAB_FREE_PTR with kmem_cache_free

Use kmem_cache_free directly instead of wrapping macro.

Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: lustre: replace OBD_SLAB_ALLOC_GFP with kmem_cache_alloc
Mike Rapoport [Tue, 20 Oct 2015 09:39:50 +0000 (12:39 +0300)]
staging: lustre: replace OBD_SLAB_ALLOC_GFP with kmem_cache_alloc

Use kmem_cache_free directly instead of wrapping macro.

Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: lustre: replace OBD_SLAB_ALLOC_PTR_GFP with kmem_cache_alloc
Mike Rapoport [Tue, 20 Oct 2015 09:39:49 +0000 (12:39 +0300)]
staging: lustre: replace OBD_SLAB_ALLOC_PTR_GFP with kmem_cache_alloc

The OBD_SLAB_ALLOC_PTR_GFP macro expands to call to kmem_cache_alloc,
which may be used directly.

Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: lustre: replace OBD_SLAB_ALLOC_PTR with kmem_cache_alloc
Mike Rapoport [Tue, 20 Oct 2015 09:39:48 +0000 (12:39 +0300)]
staging: lustre: replace OBD_SLAB_ALLOC_PTR with kmem_cache_alloc

The OBD_SLAB_ALLOC_PTR macro expands to call to kmem_cache_alloc,
which may be used directly.

Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: lustre: remove unused OBDO_{ALLOC, FREE} macros
Mike Rapoport [Tue, 20 Oct 2015 09:39:47 +0000 (12:39 +0300)]
staging: lustre: remove unused OBDO_{ALLOC, FREE} macros

The OBDO_ALLOC and OBDO_FREE macros are not used and can be removed.

Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: lustre: replace OBDO_FREE with kmem_cache_free
Mike Rapoport [Tue, 20 Oct 2015 09:39:46 +0000 (12:39 +0300)]
staging: lustre: replace OBDO_FREE with kmem_cache_free

Use kmem_cache_free directly instead of wrapping macro.

Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: lustre: replace OBDO_ALLOC with kmem_cache_alloc
Mike Rapoport [Tue, 20 Oct 2015 09:39:45 +0000 (12:39 +0300)]
staging: lustre: replace OBDO_ALLOC with kmem_cache_alloc

Use direct call to kmem_cache_alloc instead of wrapping macro

Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: lustre: remove unused OBD_SLAB_CPT_ALLOC* macros
Mike Rapoport [Tue, 20 Oct 2015 09:39:44 +0000 (12:39 +0300)]
staging: lustre: remove unused OBD_SLAB_CPT_ALLOC* macros

The OBD_SLAB_CPT_ALLOC* macros are not used and can be removed

Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: lustre: kernel style neating (block comments)
Sanne Wouda [Mon, 19 Oct 2015 11:56:51 +0000 (13:56 +0200)]
staging: lustre: kernel style neating (block comments)

Fix lustre/ptlrpc/client.c block comments following the Coding Style
preferred format for multi-line and single-line comments:

        /*
         * This is the preferred style for multi-line
         * comments in the Linux kernel source code.
         * Please use it consistently.
         *
         * Description:  A column of asterisks on the left side,
         * with beginning and ending almost-blank lines.
         */

Included some minor textual fixes to get some comments on a single line.

Signed-off-by: Sanne Wouda <snnw@gruttepier.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: lustre: interval_tree: Remove multiple assignments
Shivani Bhardwaj [Sun, 18 Oct 2015 18:47:13 +0000 (00:17 +0530)]
Staging: lustre: interval_tree: Remove multiple assignments

Remove multiple assignments by factorizing them.
Fix checkpatch CHECK: multiple assignments should be avoided

Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: lustre: make sptlrpc_flavor_has_bulk return boolean
Geliang Tang [Sun, 18 Oct 2015 14:35:31 +0000 (22:35 +0800)]
staging: lustre: make sptlrpc_flavor_has_bulk return boolean

This patch makes sptlrpc_flavor_has_bulk return boolean, since
this function only uses either one or zero as its return value.

Signed-off-by: Geliang Tang <geliangtang@163.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: lustre: lproc_osc: Add check on a variable
Shivani Bhardwaj [Sun, 18 Oct 2015 13:20:30 +0000 (18:50 +0530)]
Staging: lustre: lproc_osc: Add check on a variable

Variable rc is not tested for negative values and hence a check should
be included. Also, a check for variable val should be introduced.

Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: lustre: Replace aligned packed with packed
Cristina Moraru [Sun, 18 Oct 2015 10:31:57 +0000 (13:31 +0300)]
staging: lustre: Replace aligned packed with packed

Replace __aligned__((packed)) with __packed in order to follow
the best practices and to fix checkpatch.pl warning:
'WARNING: __packed is preferred over __attribute__((packed))'

Signed-off-by: Cristina Moraru <cristina.moraru09@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: mt29f_spinand: Remove redundant cast on 'retval'
Eva Rachel Retuya [Thu, 22 Oct 2015 17:09:56 +0000 (01:09 +0800)]
Staging: mt29f_spinand: Remove redundant cast on 'retval'

Remove the unneeded cast to 'int' since 'retval' is originally declared as
'int'.

Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: mt29f_spinand: Use preferred kernel types
Eva Rachel Retuya [Fri, 23 Oct 2015 16:13:19 +0000 (00:13 +0800)]
Staging: mt29f_spinand: Use preferred kernel types

Replace remaining instances of 'uint8_t' with 'u8' for consistency since
'u8' and 'u16' are already being used in other parts of the code.

Replace also 'uint32_t' with 'u32' on the header file.
Checkpatch pointed out this issue.

CHECK: Prefer kernel type 'u8' over 'uint8_t'
CHECK: Prefer kernel type 'u32' over 'uint32_t'

Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: mt29f_spinand: Remove multiple blank lines
Eva Rachel Retuya [Thu, 22 Oct 2015 17:07:40 +0000 (01:07 +0800)]
Staging: mt29f_spinand: Remove multiple blank lines

Remove excess blank line in-between two function declarations.
Issue found by checkpatch.

CHECK: Please don't use multiple blank lines

Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: mt29f_spinand: Remove blank line before '}' and after '{' braces
Eva Rachel Retuya [Thu, 22 Oct 2015 17:07:39 +0000 (01:07 +0800)]
Staging: mt29f_spinand: Remove blank line before '}' and after '{' braces

Remove unneeded blank lines preceding/following '}' and '{' braces, as
pointed out by checkpatch.

This patch addresses the following checkpatch checks:

CHECK: Blank lines aren't necessary before a close brace '}'
CHECK: Blank lines aren't necessary after an open brace '{'

Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: mt29f_spinand: Add blank line after function declaration
Eva Rachel Retuya [Thu, 22 Oct 2015 17:07:38 +0000 (01:07 +0800)]
Staging: mt29f_spinand: Add blank line after function declaration

Add missing blank line in-between function declarations.
Issue found by checkpatch.

CHECK: Please use a blank line after function/struct/union/enum
declarations

Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: rtl8192u: Eliminate use of MSECS macro
Shraddha Barke [Wed, 21 Oct 2015 14:49:18 +0000 (20:19 +0530)]
Staging: rtl8192u: Eliminate use of MSECS macro

Use msecs_to_jiffies instead of driver specific macro
MSECS. This is done using Coccinelle and semantic
patch used for this is as follows:

@@expression t;@@

- MSECS(t)
+ msecs_to_jiffies(t)

Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: rtl8192u: simplify conditional
Luis de Bethencourt [Sat, 17 Oct 2015 10:39:25 +0000 (11:39 +0100)]
staging: rtl8192u: simplify conditional

The code can be much cleaner and readable by simplifying the conditional
statement.

Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: isr_bh_routine: remove unused variable nic
Glen Lee [Fri, 23 Oct 2015 05:28:17 +0000 (14:28 +0900)]
staging: wilc1000: isr_bh_routine: remove unused variable nic

This patch removes unused variable nic.

Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: fix trivial typos
Geliang Tang [Sun, 18 Oct 2015 15:31:11 +0000 (23:31 +0800)]
staging: wilc1000: fix trivial typos

s/regsiter/register/

Signed-off-by: Geliang Tang <geliangtang@163.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: init_irq: change argument and use netdev private wilc
Glen Lee [Tue, 20 Oct 2015 08:14:03 +0000 (17:14 +0900)]
staging: wilc1000: init_irq: change argument and use netdev private wilc

This patch changes function argument type wilc with net_device and use
netdev private data member wilc instead of p_nic.

Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: start_ap: use netdev private data wilc
Glen Lee [Tue, 20 Oct 2015 08:14:02 +0000 (17:14 +0900)]
staging: wilc1000: start_ap: use netdev private data wilc

Use netdev private data member wilc instead of global variable g_linux_wlan.

Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: wilc_mgmt_frame_register: use netdev private wilc
Glen Lee [Tue, 20 Oct 2015 08:14:01 +0000 (17:14 +0900)]
staging: wilc1000: wilc_mgmt_frame_register: use netdev private wilc

Use netdev private data member wilc instead of global variable g_linux_wlan.

Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: del_key: use netdev private wilc instead of g_linux_wlan
Glen Lee [Tue, 20 Oct 2015 08:14:00 +0000 (17:14 +0900)]
staging: wilc1000: del_key: use netdev private wilc instead of g_linux_wlan

Use netdev private data member wilc instead of global variable g_linux_wlan.

Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: add_key: use netdev private wilc instead of g_linux_wlan
Glen Lee [Tue, 20 Oct 2015 08:13:59 +0000 (17:13 +0900)]
staging: wilc1000: add_key: use netdev private wilc instead of g_linux_wlan

Use netdev private data member wilc instead of global variable g_linux_wlan.

Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: CfgConnectResult: use netdev private wilc
Glen Lee [Tue, 20 Oct 2015 08:13:58 +0000 (17:13 +0900)]
staging: wilc1000: CfgConnectResult: use netdev private wilc

Use netdev private data member wilc instead of global variable g_linux_wlan.

Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: wilc1000_wlan_deinit: change argument and use wilc
Glen Lee [Tue, 20 Oct 2015 08:13:57 +0000 (17:13 +0900)]
staging: wilc1000: wilc1000_wlan_deinit: change argument and use wilc

This patch changes function argument wilc with net_device and use nic->wilc
instead of global variable g_linux_wlan. The null check codes should be placed
before it is used so move it.

Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: chage_virtual_intf: use netdev private wilc
Glen Lee [Tue, 20 Oct 2015 08:13:56 +0000 (17:13 +0900)]
staging: wilc1000: chage_virtual_intf: use netdev private wilc

Use netdev private data member wilc instead of global variable g_linux_wlan.

Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: mac_close: use netdev private wilc instead of g_linux_wlan
Glen Lee [Tue, 20 Oct 2015 08:13:55 +0000 (17:13 +0900)]
staging: wilc1000: mac_close: use netdev private wilc instead of g_linux_wlan

Use netdev private data member wilc instead of global variable g_linux_wlan.

Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: mac_open: use netdev private wilc
Glen Lee [Tue, 20 Oct 2015 08:13:54 +0000 (17:13 +0900)]
staging: wilc1000: mac_open: use netdev private wilc

Use netdev private data member wilc instead of global variable g_linux_wlan.

Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: wlan_init_locks: change parameter and use wilc
Glen Lee [Tue, 20 Oct 2015 08:13:53 +0000 (17:13 +0900)]
staging: wilc1000: wlan_init_locks: change parameter and use wilc

This patch changes function parameter type wilc with net_device and use netdev
private data member wilc instead of global variable g_linux_wlan.

Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: wilc1000_wlan_init: use netdev private wilc
Glen Lee [Tue, 20 Oct 2015 08:13:52 +0000 (17:13 +0900)]
staging: wilc1000: wilc1000_wlan_init: use netdev private wilc

This patch use netdev private data member wilc instead of global variable
g_linux_wlan.

Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: add wilc to netdev private data structure
Glen Lee [Tue, 20 Oct 2015 08:13:51 +0000 (17:13 +0900)]
staging: wilc1000: add wilc to netdev private data structure

This patch add wilc to struct perInterface_wlan_t which is netdev private
data to access wilc via netdev_priv function. Assign wilc to nic->wilc.
The global variable g_linux_wlan will be replaced with netdev private data
member wilc step by step.

Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: fix the bug on copying bssid
Tony Cho [Tue, 20 Oct 2015 08:10:46 +0000 (17:10 +0900)]
staging: wilc1000: fix the bug on copying bssid

This patch reverts the commit, d79fd35b8c5d927695b48fa35aa586919818cce9.

The WID_JOIN_REQ_EXTENDED among WIDs needs two parameters for the request to
be sent to the firmware, which are the SA and the BSSID. For this case, both
is the same bssid in the handle_connect function. So, it's required to be
copied twice.

Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: assign pointer of g_linux_wlan to sdio device data
Tony Cho [Tue, 20 Oct 2015 05:26:56 +0000 (14:26 +0900)]
staging: wilc1000: assign pointer of g_linux_wlan to sdio device data

This patch assigns wl pointer to sdio device data. The global variable
g_linux_wlan will be removed finally.

Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: introduce struct wilc_sdio for sdio data
Tony Cho [Tue, 20 Oct 2015 05:26:55 +0000 (14:26 +0900)]
staging: wilc1000: introduce struct wilc_sdio for sdio data

This patch introduces struct wilc_sdio for sdio driver data. The wilc_sdio is
allocated and set as driver data when the sdio is probed and deallocated when
the sdio is removed.

Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: remove COMPLEMENT_BOOT
Tony Cho [Tue, 20 Oct 2015 05:26:54 +0000 (14:26 +0900)]
staging: wilc1000: remove COMPLEMENT_BOOT

This patch removes a preprocessor definition, COMPLEMENT_BOOT which is not used
anymore. This is just workaround to avoid weird issue, which is that 11b core
is not ready after the power is givin to the chip. However, this issue happened
only in the unstable hardware a long time ago and no more seen. In addition,
this patch removes _fail_threads_ statement to avoid the build warning after
removing COMPLEMENT_BOOT conditionals.

Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: rename wilc_firmware in the struct wilc
Tony Cho [Tue, 20 Oct 2015 05:26:53 +0000 (14:26 +0900)]
staging: wilc1000: rename wilc_firmware in the struct wilc

This patch renames wilc_firmware in the struct wilc to the firmware. In
addition, null assignments to the wl->firmware after release_firmware
are removed because it is not necessary.

Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: move clean up codes into wl_wlan_cleanup function
Tony Cho [Tue, 20 Oct 2015 05:26:52 +0000 (14:26 +0900)]
staging: wilc1000: move clean up codes into wl_wlan_cleanup function

This patch moves clean up codes from exit_wilc_driver into the wl_wlan_cleanup
newly introduced in this patch. In addition, it is called by linux_sdio_remove
function.

Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: rename wilc_netdev in the struct wilc_vif
Tony Cho [Tue, 20 Oct 2015 05:26:51 +0000 (14:26 +0900)]
staging: wilc1000: rename wilc_netdev in the struct wilc_vif

This patch renames wilc_netdev in the struct wilc_vif to the ndev.

Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: rename drvHandler in the struct wilc_vif
Tony Cho [Tue, 20 Oct 2015 05:26:50 +0000 (14:26 +0900)]
staging: wilc1000: rename drvHandler in the struct wilc_vif

This patch renames drvHandler in the struct wilc_vif to the hif_drv.

Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: rename aBSSID in the sturct wilc_vif
Tony Cho [Tue, 20 Oct 2015 05:26:49 +0000 (14:26 +0900)]
staging: wilc1000: rename aBSSID in the sturct wilc_vif

This patch renames aBSSID in the struct wilc_vif to the bssid.

Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: rename aSrcAddress in the struct wilc_vif
Tony Cho [Tue, 20 Oct 2015 05:26:48 +0000 (14:26 +0900)]
staging: wilc1000: rename aSrcAddress in the struct wilc_vif

This patch renames aSrcAddress in the struct wilc_vif to the src_addr.

Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: rename strInterfaceInfo in the sturct wilc
Tony Cho [Tue, 20 Oct 2015 05:26:47 +0000 (14:26 +0900)]
staging: wilc1000: rename strInterfaceInfo in the sturct wilc

This patch renames strInterfaceInfo in the struct wilc to the vif. In
addition, unnecessary print statements around it are removed in this patch.

Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: rename u8NoIfcs in the struct wilc
Tony Cho [Tue, 20 Oct 2015 05:26:46 +0000 (14:26 +0900)]
staging: wilc1000: rename u8NoIfcs in the struct wilc

This patch renames u8NoIfcs of the struct wilc to the vif_num to avoid
CamelCase naming convention.

Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: change the type of wilc1000_initialized
Tony Cho [Tue, 20 Oct 2015 05:26:45 +0000 (14:26 +0900)]
staging: wilc1000: change the type of wilc1000_initialized

This patch changes the type of wilc1000_initialized in the struc wilc from int
to bool and also renames it to the initialized. In addition, unnecessary
wilc1000_initialized codes are removed in this patch.

Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: fixes comparison to NULL could be written
Leo Kim [Mon, 19 Oct 2015 09:26:13 +0000 (18:26 +0900)]
staging: wilc1000: fixes comparison to NULL could be written

This patch fixes the checks reported by checkpatch.pl
for comparison to NULL could be written.

Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: fixes alignment should match open parenthesis
Leo Kim [Mon, 19 Oct 2015 09:26:12 +0000 (18:26 +0900)]
staging: wilc1000: fixes alignment should match open parenthesis

This patch fixes the checks reported by checkpatch.pl
for alignment should match open parenthesis.

Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: fixes unnecessary variable replacement
Leo Kim [Mon, 19 Oct 2015 09:26:11 +0000 (18:26 +0900)]
staging: wilc1000: fixes unnecessary variable replacement

This patch removes an unnecessary variable use for the errors and
returns errors directly without a result variable.

Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: move variable FALSE_FRMWR_CHANNEL
Leo Kim [Mon, 19 Oct 2015 09:26:10 +0000 (18:26 +0900)]
staging: wilc1000: move variable FALSE_FRMWR_CHANNEL

This patch moves the variable 'FALSE_FRMWR_CHANNEL' to where local definitions
are.

Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: move variable clients_count
Leo Kim [Mon, 19 Oct 2015 09:26:09 +0000 (18:26 +0900)]
staging: wilc1000: move variable clients_count

This patch moves static variable clients_count to around where the local
variables are togther.

Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: rename variable s32Error
Leo Kim [Mon, 19 Oct 2015 09:26:08 +0000 (18:26 +0900)]
staging: wilc1000: rename variable s32Error

This patch renames variable s32Error to result
to avoid CamelCase naming convention.

Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: IB/hfi1: use TASK_COMM_LEN in hfi1_ctxtdata
Geliang Tang [Fri, 9 Oct 2015 05:04:26 +0000 (22:04 -0700)]
staging: IB/hfi1: use TASK_COMM_LEN in hfi1_ctxtdata

Use comm[TASK_COMM_LEN] instead of comm[16].

Signed-off-by: Geliang Tang <geliangtang@163.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: r8188eu: Add _enter_critical_mutex() error handling
Alexey Khoroshilov [Sat, 17 Oct 2015 21:33:09 +0000 (00:33 +0300)]
staging: r8188eu: Add _enter_critical_mutex() error handling

_enter_critical_mutex() is a simple call to mutex_lock_interruptible(),
but there is no error handling code for it.

The patch removes wrapper _enter_critical_mutex() and
adds error handling for mutex_lock_interruptible().

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: octeon-ethernet: move cvm_oct_xaui_open()
Aaro Koskinen [Sat, 17 Oct 2015 19:28:56 +0000 (22:28 +0300)]
staging: octeon-ethernet: move cvm_oct_xaui_open()

cvm_oct_xaui_open() is trivial and does not need a dedicated file.
Move it to the main file.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: octeon-ethernet: drop poll_now parameter from cvm_oct_common_open
Aaro Koskinen [Sat, 17 Oct 2015 19:28:55 +0000 (22:28 +0300)]
staging: octeon-ethernet: drop poll_now parameter from cvm_oct_common_open

Drop redundant poll_now parameter from cvm_oct_common_open.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: octeon-ethernet: rgmii: poll link status on open
Aaro Koskinen [Sat, 17 Oct 2015 19:28:54 +0000 (22:28 +0300)]
staging: octeon-ethernet: rgmii: poll link status on open

Get the initial link status already on open instead of postponing
it to the periodic poll task. This unifies the behaviour with
other interfaces types.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: fsl-mc: Added serialization to mc_send_command()
J. German Rivera [Sat, 17 Oct 2015 20:33:15 +0000 (15:33 -0500)]
staging: fsl-mc: Added serialization to mc_send_command()

When the same portal is used to call mc_send_command() from two
different threads or a thread and an interrupt handler, serialization
is required, as the MC only supports one outstanding command per MC
portal. Thus, a new command should not be sent to the MC until the
last command sent has been responded by the MC.

Signed-off-by: J. German Rivera <German.Rivera@freescale.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: fsl-mc:Added support for atomic portals
J. German Rivera [Sat, 17 Oct 2015 20:33:14 +0000 (15:33 -0500)]
staging: fsl-mc:Added support for atomic portals

Refactored mc_send_command() to support two flavors of polling:
- preemptible (for non-atomic portals), which was already supported.
  It calls usleep_range() between polling iterations.
- non-preemptible (for atomic portals), which is needed when
  mc_send_command() is called with interrupts disabled.
  It calls udelay() between polling iterations.

Signed-off-by: J. German Rivera <German.Rivera@freescale.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: fsl-mc: refactored mc_send_command()
J. German Rivera [Sat, 17 Oct 2015 20:33:13 +0000 (15:33 -0500)]
staging: fsl-mc: refactored mc_send_command()

Moved wait logic in mc_send_command() to its own function

Signed-off-by: J. German Rivera <German.Rivera@freescale.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: fsl-mc: changed timeout units for MC cmd completion
J. German Rivera [Sat, 17 Oct 2015 20:33:12 +0000 (15:33 -0500)]
staging: fsl-mc: changed timeout units for MC cmd completion

Changed units for the timeout to wait for completion
of MC command, from jiffies to milliseconds.

Signed-off-by: J. German Rivera <German.Rivera@freescale.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: fsl-mc: Added missing initializer in fsl_mc_bus_driver
J. German Rivera [Sat, 17 Oct 2015 16:18:24 +0000 (11:18 -0500)]
staging: fsl-mc: Added missing initializer in fsl_mc_bus_driver

owner needs to be initialized as THIS_MOUDLE.

Signed-off-by: J. German Rivera <German.Rivera@freescale.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>