Chris Lattner [Wed, 28 May 2008 04:06:52 +0000 (04:06 +0000)]
loads should get chains. THis helps but does not solve CodeGen/Generic/2003-05-27-phifcmpd.ll
on ia64.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51633
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Wed, 28 May 2008 04:00:06 +0000 (04:00 +0000)]
Fix 2006-04-28-Sign-extend-bool.ll for ia64.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51632
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Wed, 28 May 2008 03:59:32 +0000 (03:59 +0000)]
reindent.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51631
91177308-0d34-0410-b5e6-
96231b3b80d8
Dan Gohman [Wed, 28 May 2008 01:50:19 +0000 (01:50 +0000)]
Fix the encoding for two more "rm" instructions that were using MRMSrcReg.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51630
91177308-0d34-0410-b5e6-
96231b3b80d8
Mon P Wang [Wed, 28 May 2008 00:42:27 +0000 (00:42 +0000)]
Fixed X86 encoding error CVTPS2PD and CVTPD2PS when the source operand
is a memory location
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51626
91177308-0d34-0410-b5e6-
96231b3b80d8
Nate Begeman [Wed, 28 May 2008 00:24:25 +0000 (00:24 +0000)]
Don't attempt to create VZEXT_LOAD out of an extload. This an issue where the
code generator would do something like this:
f64 = load f32 <anyext>, f32mem
v2f64 = insertelt undef, %0, 0
v2f64 = insertelt %1, 0.0, 1
into
v2f64 = vzext_load f32mem
which on x86 is movsd, when you really wanted a cvtss2sd/movsd pair.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51624
91177308-0d34-0410-b5e6-
96231b3b80d8
Nick Kledzik [Wed, 28 May 2008 00:06:14 +0000 (00:06 +0000)]
use space insted of tabs
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51623
91177308-0d34-0410-b5e6-
96231b3b80d8
Nick Kledzik [Tue, 27 May 2008 22:07:08 +0000 (22:07 +0000)]
fix infinite recursion if a global's initializer references the global
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51617
91177308-0d34-0410-b5e6-
96231b3b80d8
Gabor Greif [Tue, 27 May 2008 21:29:38 +0000 (21:29 +0000)]
Make Use::init() private, it breaks invariants, clients should assign or use set().
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51615
91177308-0d34-0410-b5e6-
96231b3b80d8
Dan Gohman [Tue, 27 May 2008 20:55:29 +0000 (20:55 +0000)]
Use Function::getEntryBlock instead of Function::begin, for clarity.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51613
91177308-0d34-0410-b5e6-
96231b3b80d8
Dan Gohman [Tue, 27 May 2008 20:47:30 +0000 (20:47 +0000)]
Print debug output when any edge becomes executable, including
the first visited edge.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51612
91177308-0d34-0410-b5e6-
96231b3b80d8
Devang Patel [Tue, 27 May 2008 20:42:44 +0000 (20:42 +0000)]
Add instcombine after global optimizations.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51611
91177308-0d34-0410-b5e6-
96231b3b80d8
Dan Gohman [Tue, 27 May 2008 20:41:18 +0000 (20:41 +0000)]
Fix a word-o and add an explicit keyword.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51610
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Tue, 27 May 2008 20:40:52 +0000 (20:40 +0000)]
Incorporated feedback: Check that the implicitly defined operands aren't used
before deleting the instruction.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51609
91177308-0d34-0410-b5e6-
96231b3b80d8
Dan Gohman [Tue, 27 May 2008 20:29:07 +0000 (20:29 +0000)]
Tidy up whitespace in ConstantRange::print output.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51606
91177308-0d34-0410-b5e6-
96231b3b80d8
Devang Patel [Tue, 27 May 2008 20:18:45 +0000 (20:18 +0000)]
Use IPSCCPPass instead of IPConstantPropagationPass.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51605
91177308-0d34-0410-b5e6-
96231b3b80d8
Dan Gohman [Tue, 27 May 2008 17:55:57 +0000 (17:55 +0000)]
Specify a target so that this tests tests what it's intended to test.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51600
91177308-0d34-0410-b5e6-
96231b3b80d8
Dan Gohman [Tue, 27 May 2008 17:44:23 +0000 (17:44 +0000)]
Make this test independent of the target-triple; the stack alignment
is specifically what this test depends on.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51599
91177308-0d34-0410-b5e6-
96231b3b80d8
Gabor Greif [Tue, 27 May 2008 17:26:02 +0000 (17:26 +0000)]
back out last commit: The .cpp file for a module should include its corresponding header first, even if redundant.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51598
91177308-0d34-0410-b5e6-
96231b3b80d8
Matthijs Kooijman [Tue, 27 May 2008 12:41:24 +0000 (12:41 +0000)]
Use an explicit llvm:: prefix in the STATISTIC macro, so STATISTIC can still be
used when "using namespace llvm" is not in effect.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51592
91177308-0d34-0410-b5e6-
96231b3b80d8
Duncan Sands [Tue, 27 May 2008 11:50:51 +0000 (11:50 +0000)]
Fix some constructs that gcc-4.4 warns about.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51591
91177308-0d34-0410-b5e6-
96231b3b80d8
Gabor Greif [Tue, 27 May 2008 11:06:03 +0000 (11:06 +0000)]
prune unneeded #includes
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51590
91177308-0d34-0410-b5e6-
96231b3b80d8
Gabor Greif [Tue, 27 May 2008 11:03:29 +0000 (11:03 +0000)]
remove unneeded reinterpret_casts
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51589
91177308-0d34-0410-b5e6-
96231b3b80d8
Gabor Greif [Tue, 27 May 2008 10:48:39 +0000 (10:48 +0000)]
We have the correct headers included to know that BB isa Value. No reinterpret_cast necessary.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51588
91177308-0d34-0410-b5e6-
96231b3b80d8
Owen Anderson [Tue, 27 May 2008 04:27:27 +0000 (04:27 +0000)]
Remove ADCE from the optimization pipeline.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51581
91177308-0d34-0410-b5e6-
96231b3b80d8
Nick Lewycky [Tue, 27 May 2008 00:59:05 +0000 (00:59 +0000)]
InequalityGraph::node() can create new nodes, invalidating iterators across
the set of nodes. Fix makeEqual to handle this by creating the new node first
then iterating across them second.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51573
91177308-0d34-0410-b5e6-
96231b3b80d8
Nick Lewycky [Mon, 26 May 2008 22:49:36 +0000 (22:49 +0000)]
Grammaro.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51572
91177308-0d34-0410-b5e6-
96231b3b80d8
Gabor Greif [Mon, 26 May 2008 21:33:52 +0000 (21:33 +0000)]
eliminate calls to deprecated Use::init() interface
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51570
91177308-0d34-0410-b5e6-
96231b3b80d8
Nick Lewycky [Mon, 26 May 2008 20:23:33 +0000 (20:23 +0000)]
Whoops -- forgot PR reference on this test.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51569
91177308-0d34-0410-b5e6-
96231b3b80d8
Nick Lewycky [Mon, 26 May 2008 20:18:56 +0000 (20:18 +0000)]
The Linux ABI emits an extra "movl %esp, %ebp" in function prologue and
sometimes a "mov %ebp, %esp" in the epilogue.
Force these tests that rely on counting 'mov' to use i686-apple-darwin8.8.0
where they were written.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51568
91177308-0d34-0410-b5e6-
96231b3b80d8
Duncan Sands [Mon, 26 May 2008 19:58:59 +0000 (19:58 +0000)]
Factor code to copy global value attributes like
the section or the visibility from one global
value to another: copyAttributesFrom. This is
particularly useful for duplicating functions:
previously this was done by explicitly copying
each attribute in turn at each place where a
new function was created out of an old one, with
the result that obscure attributes were regularly
forgotten (like the collector or the section).
Hopefully now everything is uniform and nothing
is forgotten.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51567
91177308-0d34-0410-b5e6-
96231b3b80d8
Owen Anderson [Mon, 26 May 2008 10:07:43 +0000 (10:07 +0000)]
Use a DenseMap instead of an std::map, speeding up the testcase in PR2368 by about a third.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51565
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Mon, 26 May 2008 05:49:49 +0000 (05:49 +0000)]
The enabling of remat in 2-address conversion breaks this test:
Running /Users/void/llvm/llvm.src/test/CodeGen/X86/dg.exp ...
FAIL: /Users/void/llvm/llvm.src/test/CodeGen/X86/2007-11-30-LoadFolding-Bug.ll
Failed with exit(1) at line 1
while running: llvm-as < /Users/void/llvm/llvm.src/test/CodeGen/X86/2007-11-30-LoadFolding-Bug.ll | llc -march=x86 -mattr=+sse2 -stats |& grep {1 .*folded into instructions}
child process exited abnormally
Make this conditional for now.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51563
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Mon, 26 May 2008 05:18:34 +0000 (05:18 +0000)]
A problem that's exposed when machine LICM is enabled. Consider this code:
LBB1_3: # bb
...
xorl %ebp, %ebp
subl (%ebx), %ebp
...
incl %ecx
cmpl %edi, %ecx
jl LBB1_3 # bb
Whe using machine LICM, LLVM converts it into:
xorl %esi, %esi
LBB1_3: # bb
...
movl %esi, %ebp
subl (%ebx), %ebp
...
incl %ecx
cmpl %edi, %ecx
jl LBB1_3 # bb
Two address conversion inserts the copy instruction. However, it's cheaper to
rematerialize it, and remat helps reduce register pressure.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51562
91177308-0d34-0410-b5e6-
96231b3b80d8
Nick Lewycky [Mon, 26 May 2008 01:27:08 +0000 (01:27 +0000)]
Use {} instead of "" in RUN lines.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51561
91177308-0d34-0410-b5e6-
96231b3b80d8
Nick Lewycky [Sun, 25 May 2008 23:43:32 +0000 (23:43 +0000)]
Don't treat values as signed when looking at loop steppings in HowForToNonZero.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51560
91177308-0d34-0410-b5e6-
96231b3b80d8
Nick Lewycky [Sun, 25 May 2008 20:56:15 +0000 (20:56 +0000)]
"ret (constexpr)" can't be folded into a Constant. Add a method to
Analysis/ConstantFolding to fold ConstantExpr's, then make instcombine use it
to try to use targetdata to fold constant expressions on void instructions.
Also extend the icmp(inttoptr, inttoptr) folding to handle the case where
int size != ptr size.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51559
91177308-0d34-0410-b5e6-
96231b3b80d8
Owen Anderson [Sat, 24 May 2008 05:42:29 +0000 (05:42 +0000)]
Create archives with the same permissions are ar.
Patch by Mikael Lepistö.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51540
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Sat, 24 May 2008 05:11:48 +0000 (05:11 +0000)]
Fix win32 when no bison is around, PR2331, patch by 'hume'.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51539
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Sat, 24 May 2008 04:58:48 +0000 (04:58 +0000)]
Add FreeBSD/PPC support, patch by Marcel Moolenaar!
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51538
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Sat, 24 May 2008 04:06:28 +0000 (04:06 +0000)]
Fix a serious brain-o. Obviously no-one reviewed my patch :(
This fixes PR2359
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51536
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Sat, 24 May 2008 03:59:33 +0000 (03:59 +0000)]
Fix PR2358 by resolving calls with undef arguments to overdefined.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51535
91177308-0d34-0410-b5e6-
96231b3b80d8
Evan Cheng [Sat, 24 May 2008 02:56:30 +0000 (02:56 +0000)]
Eliminate x86.sse2.punpckh.qdq and x86.sse2.punpckl.qdq.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51533
91177308-0d34-0410-b5e6-
96231b3b80d8
Evan Cheng [Sat, 24 May 2008 02:14:05 +0000 (02:14 +0000)]
Eliminate x86.sse2.movs.d, x86.sse2.shuf.pd, x86.sse2.unpckh.pd, and x86.sse2.unpckl.pd intrinsics. These will be lowered into shuffles.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51531
91177308-0d34-0410-b5e6-
96231b3b80d8
Duncan Sands [Sat, 24 May 2008 01:00:52 +0000 (01:00 +0000)]
Tweak how ConstantFP80Ty constants are output
so that gcc doesn't warn about them.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51529
91177308-0d34-0410-b5e6-
96231b3b80d8
Dale Johannesen [Sat, 24 May 2008 00:10:20 +0000 (00:10 +0000)]
Put initialized const weak objects into correct
sections on ppc32 darwin. g++.dg/abi/key2.C
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51527
91177308-0d34-0410-b5e6-
96231b3b80d8
Evan Cheng [Sat, 24 May 2008 00:10:13 +0000 (00:10 +0000)]
This is done.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51526
91177308-0d34-0410-b5e6-
96231b3b80d8
Evan Cheng [Sat, 24 May 2008 00:10:02 +0000 (00:10 +0000)]
New loadl_pd and loadh_pd tests.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51525
91177308-0d34-0410-b5e6-
96231b3b80d8
Evan Cheng [Sat, 24 May 2008 00:08:39 +0000 (00:08 +0000)]
Autoupgrade x86.sse2.loadh.pd and x86.sse2.loadl.pd.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51523
91177308-0d34-0410-b5e6-
96231b3b80d8
Evan Cheng [Sat, 24 May 2008 00:07:29 +0000 (00:07 +0000)]
Remove x86.sse2.loadh.pd and x86.sse2.loadl.pd. These will be lowered into load and shuffle instructions.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51522
91177308-0d34-0410-b5e6-
96231b3b80d8
Evan Cheng [Sat, 24 May 2008 00:07:06 +0000 (00:07 +0000)]
Remove x86.sse2.loadh.pd and x86.sse2.loadl.pd. These will be lowered into load and shuffle instructions.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51521
91177308-0d34-0410-b5e6-
96231b3b80d8
Dale Johannesen [Fri, 23 May 2008 23:13:41 +0000 (23:13 +0000)]
Document common linkage.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51517
91177308-0d34-0410-b5e6-
96231b3b80d8
Evan Cheng [Fri, 23 May 2008 23:00:04 +0000 (23:00 +0000)]
Revert 51440 as it breaks a bunch of PIC tests.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51513
91177308-0d34-0410-b5e6-
96231b3b80d8
Dan Gohman [Fri, 23 May 2008 22:50:26 +0000 (22:50 +0000)]
label is a first-class type.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51512
91177308-0d34-0410-b5e6-
96231b3b80d8
Dan Gohman [Fri, 23 May 2008 22:47:52 +0000 (22:47 +0000)]
It turns out there are only 3 non-first-class type kinds left now, so
it's simpler for isFirstClassType to use a negative test.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51511
91177308-0d34-0410-b5e6-
96231b3b80d8
Dan Gohman [Fri, 23 May 2008 22:27:01 +0000 (22:27 +0000)]
Remove a bogus svn:mime-type property.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51510
91177308-0d34-0410-b5e6-
96231b3b80d8
Dan Gohman [Fri, 23 May 2008 21:53:15 +0000 (21:53 +0000)]
Update the description of first-class types to reflect that
structs and arrays are now first-class. And fix a sentance
fragment in the insertvalue description. Thanks to Chris
for pointing these out!
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51506
91177308-0d34-0410-b5e6-
96231b3b80d8
Dan Gohman [Fri, 23 May 2008 21:40:55 +0000 (21:40 +0000)]
Don't silently truncate array extents to 32 bits.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51505
91177308-0d34-0410-b5e6-
96231b3b80d8
Dale Johannesen [Fri, 23 May 2008 21:33:27 +0000 (21:33 +0000)]
Add a missed CommonLinkage check.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51503
91177308-0d34-0410-b5e6-
96231b3b80d8
Evan Cheng [Fri, 23 May 2008 21:23:16 +0000 (21:23 +0000)]
Use movlps / movhps to modify low / high half of 16-byet memory location.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51501
91177308-0d34-0410-b5e6-
96231b3b80d8
Dan Gohman [Fri, 23 May 2008 21:15:35 +0000 (21:15 +0000)]
Remove lingering references to .llx and .tr in the tests.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51500
91177308-0d34-0410-b5e6-
96231b3b80d8
Dan Gohman [Fri, 23 May 2008 21:05:58 +0000 (21:05 +0000)]
Tidy up BasicBlock::getFirstNonPHI, and change a bunch of places to
use it instead of duplicating its functionality.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51499
91177308-0d34-0410-b5e6-
96231b3b80d8
Dan Gohman [Fri, 23 May 2008 20:40:06 +0000 (20:40 +0000)]
Add #includes to make some dependencies explicit.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51496
91177308-0d34-0410-b5e6-
96231b3b80d8
Dan Gohman [Fri, 23 May 2008 18:23:11 +0000 (18:23 +0000)]
Issue errors in several situations instead of aborting.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51493
91177308-0d34-0410-b5e6-
96231b3b80d8
Dan Gohman [Fri, 23 May 2008 18:05:39 +0000 (18:05 +0000)]
Elaborate on the entry on integer vector multiplication by constants.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51491
91177308-0d34-0410-b5e6-
96231b3b80d8
Evan Cheng [Fri, 23 May 2008 18:00:18 +0000 (18:00 +0000)]
Fix a duplicated pattern.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51490
91177308-0d34-0410-b5e6-
96231b3b80d8
Dan Gohman [Fri, 23 May 2008 17:49:40 +0000 (17:49 +0000)]
Use PMULDQ for v2i64 multiplies when SSE4.1 is available. And add
load-folding table entries for PMULDQ and PMULLD.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51489
91177308-0d34-0410-b5e6-
96231b3b80d8
Evan Cheng [Fri, 23 May 2008 17:28:11 +0000 (17:28 +0000)]
New entry.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51487
91177308-0d34-0410-b5e6-
96231b3b80d8
Dale Johannesen [Fri, 23 May 2008 17:19:02 +0000 (17:19 +0000)]
Rewrite a loop to avoid using iterators pointing to
elements that have been erased. Based on a patch
by Nicolas Capens.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51485
91177308-0d34-0410-b5e6-
96231b3b80d8
Dan Gohman [Fri, 23 May 2008 17:11:55 +0000 (17:11 +0000)]
Fix the spelling of the va_arg keyword.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51484
91177308-0d34-0410-b5e6-
96231b3b80d8
Dan Gohman [Fri, 23 May 2008 16:57:00 +0000 (16:57 +0000)]
Fix another isFirstClassType that now needs to be isSingleValueType.
This fixes recent CBE regressions.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51483
91177308-0d34-0410-b5e6-
96231b3b80d8
Matthijs Kooijman [Fri, 23 May 2008 16:17:48 +0000 (16:17 +0000)]
Replace some weird usage of UserOp1 introduced in r49492 by a plain if.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51482
91177308-0d34-0410-b5e6-
96231b3b80d8
Matthijs Kooijman [Fri, 23 May 2008 11:45:18 +0000 (11:45 +0000)]
Restructure the testing documentation.
I've tried to make the distinction between the DejaGNU tests and the test-suite
more clear, added a small section about generating output from the test-suite,
removed some duplication and fixed some wordings. Most of the changes are text
movements, however.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51480
91177308-0d34-0410-b5e6-
96231b3b80d8
Matthijs Kooijman [Fri, 23 May 2008 09:09:41 +0000 (09:09 +0000)]
Restucture a part of the SimplifyCFG pass and include a testcase.
The SimplifyCFG pass looks at basic blocks that contain only phi nodes,
followed by an unconditional branch. In a lot of cases, such a block (BB) can
be merged into their successor (Succ).
This merging is performed by TryToSimplifyUncondBranchFromEmptyBlock. It does
this by taking all phi nodes in the succesor block Succ and expanding them to
include the predecessors of BB. Furthermore, any phi nodes in BB are moved to
Succ and expanded to include the predecessors of Succ as well.
Before attempting this merge, CanPropagatePredecessorsForPHIs checks to see if
all phi nodes can be properly merged. All functional changes are made to
this function, only comments were updated in
TryToSimplifyUncondBranchFromEmptyBlock.
In the original code, CanPropagatePredecessorsForPHIs looks quite convoluted
and more like stack of checks added to handle different kinds of situations
than a comprehensive check. In particular the first check in the function did
some value checking for the case that BB and Succ have a common predecessor,
while the last check in the function simply rejected all cases where BB and
Succ have a common predecessor. The first check was still useful in the case
that BB did not contain any phi nodes at all, though, so it was not completely
useless.
Now, CanPropagatePredecessorsForPHIs is restructured to to look a lot more
similar to the code that actually performs the merge. Both functions now look
at the same phi nodes in about the same order. Any conflicts (phi nodes with
different values for the same source) that could arise from merging or moving
phi nodes are detected. If no conflicts are found, the merge can happen.
Apart from only restructuring the checks, two main changes in functionality
happened.
Firstly, the old code rejected blocks with common predecessors in most cases.
The new code performs some extra checks so common predecessors can be handled
in a lot of cases. Wherever common predecessors still pose problems, the
blocks are left untouched.
Secondly, the old code rejected the merge when values (phi nodes) from BB were
used in any other place than Succ. However, it does not seem that there is any
situation that would require this check. Even more, this can be proven.
Consider that BB is a block containing of a single phi node "%a" and a branch
to Succ. Now, since the definition of %a will dominate all of its uses, BB
will dominate all blocks that use %a. Furthermore, since the branch from BB to
Succ is unconditional, Succ will also dominate all uses of %a.
Now, assume that one predecessor of Succ is not dominated by BB (and thus not
dominated by Succ). Since at least one use of %a (but in reality all of them)
is reachable from Succ, you could end up at a use of %a without passing
through it's definition in BB (by coming from X through Succ). This is a
contradiction, meaning that our original assumption is wrong. Thus, all
predecessors of Succ must also be dominated by BB (and thus also by Succ).
This means that moving the phi node %a from BB to Succ does not pose any
problems when the two blocks are merged, and any use checks are not needed.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51478
91177308-0d34-0410-b5e6-
96231b3b80d8
Matthijs Kooijman [Fri, 23 May 2008 07:57:02 +0000 (07:57 +0000)]
Indent fix.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51477
91177308-0d34-0410-b5e6-
96231b3b80d8
Nick Lewycky [Fri, 23 May 2008 04:54:45 +0000 (04:54 +0000)]
Constant integer vectors may also be negated.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51476
91177308-0d34-0410-b5e6-
96231b3b80d8
Nick Lewycky [Fri, 23 May 2008 04:39:38 +0000 (04:39 +0000)]
Typo.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51475
91177308-0d34-0410-b5e6-
96231b3b80d8
Nick Lewycky [Fri, 23 May 2008 04:34:58 +0000 (04:34 +0000)]
Revert X + X --> X * 2 optz'n which pessimizes heavily on x86.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51474
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Lattner [Fri, 23 May 2008 04:29:53 +0000 (04:29 +0000)]
we compile multiply-by-constant into horrible code. Doesn't sse4 have some
instruction for doing this?
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51473
91177308-0d34-0410-b5e6-
96231b3b80d8
Nick Lewycky [Fri, 23 May 2008 04:14:51 +0000 (04:14 +0000)]
Implement X + X for vectors.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51472
91177308-0d34-0410-b5e6-
96231b3b80d8
Nick Lewycky [Fri, 23 May 2008 03:26:47 +0000 (03:26 +0000)]
Fix a recently added optimization to not crash on vectors.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51471
91177308-0d34-0410-b5e6-
96231b3b80d8
Dan Gohman [Fri, 23 May 2008 02:28:01 +0000 (02:28 +0000)]
Generalize the new code in instcombine's ComputeNumSignBits for handling
and/or to handle more cases (such as this add-sitofp.ll testcase), and
port it to selectiondag's ComputeNumSignBits.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51469
91177308-0d34-0410-b5e6-
96231b3b80d8
Dan Gohman [Fri, 23 May 2008 01:55:30 +0000 (01:55 +0000)]
Make structs and arrays first-class types, and add assembly
and bitcode support for the extractvalue and insertvalue
instructions and constant expressions.
Note that this does not yet include CodeGen support.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51468
91177308-0d34-0410-b5e6-
96231b3b80d8
Dan Gohman [Fri, 23 May 2008 01:52:21 +0000 (01:52 +0000)]
Use isSingleValueType instead of isFirstClassType to
exclude struct and array types.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51467
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Fri, 23 May 2008 01:29:08 +0000 (01:29 +0000)]
Remove warnings about comparison between signed and unsigned expressions.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51465
91177308-0d34-0410-b5e6-
96231b3b80d8
Dale Johannesen [Fri, 23 May 2008 01:01:31 +0000 (01:01 +0000)]
Allow for switch with no cases. Was causing fault
in gcc.dg/pr27531-1.c.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51464
91177308-0d34-0410-b5e6-
96231b3b80d8
Evan Cheng [Fri, 23 May 2008 00:37:07 +0000 (00:37 +0000)]
Bug: rcpps can only folds a load if the address is 16-byte aligned. Fixed many 'ps' load folding patterns in X86InstrSSE.td which are missing the proper alignment checks.
Also fixed some 80 col. violations.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51462
91177308-0d34-0410-b5e6-
96231b3b80d8
Dan Gohman [Fri, 23 May 2008 00:36:11 +0000 (00:36 +0000)]
Add more IR support for the new extractvalue and insertvalue
instructions.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51461
91177308-0d34-0410-b5e6-
96231b3b80d8
Dan Gohman [Fri, 23 May 2008 00:34:04 +0000 (00:34 +0000)]
Use isSingleValueType instead of isFirstClassType to
exclude struct and array types.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51460
91177308-0d34-0410-b5e6-
96231b3b80d8
Dan Gohman [Fri, 23 May 2008 00:17:26 +0000 (00:17 +0000)]
Use isSingleValueType instead of isFirstClassType to
exclude struct and array types.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51459
91177308-0d34-0410-b5e6-
96231b3b80d8
Dale Johannesen [Fri, 23 May 2008 00:16:59 +0000 (00:16 +0000)]
Put const weak stuff in appropriate section on Darwin.
g++.dg/abi/key2.C
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51458
91177308-0d34-0410-b5e6-
96231b3b80d8
Dale Johannesen [Fri, 23 May 2008 00:15:10 +0000 (00:15 +0000)]
Make LTO expect common and weak to be represented differently.
Reading .bc files from before that change will no longer work.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51457
91177308-0d34-0410-b5e6-
96231b3b80d8
Dan Gohman [Fri, 23 May 2008 00:12:03 +0000 (00:12 +0000)]
Use isSingleValueType instead of isFirstClassType to
exclude struct and array types.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51456
91177308-0d34-0410-b5e6-
96231b3b80d8
Evan Cheng [Thu, 22 May 2008 23:55:24 +0000 (23:55 +0000)]
X86CodeEmitter should not set PIC style to None at initialization time. This will break codegen if relocation model is changed to PIC_ later.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51455
91177308-0d34-0410-b5e6-
96231b3b80d8
Dan Gohman [Thu, 22 May 2008 23:43:22 +0000 (23:43 +0000)]
Use isSingleValueType instead of isFirstClassType to
exclude struct and array types.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51452
91177308-0d34-0410-b5e6-
96231b3b80d8
Dan Gohman [Thu, 22 May 2008 22:45:03 +0000 (22:45 +0000)]
Add a polygen grammar definition for LLVM assembly language.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51449
91177308-0d34-0410-b5e6-
96231b3b80d8
Dan Gohman [Thu, 22 May 2008 22:30:09 +0000 (22:30 +0000)]
Recognize the "default" keyword, which is documented in LangRef.html
and supported in the grammar, in the lexer.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51448
91177308-0d34-0410-b5e6-
96231b3b80d8
Evan Cheng [Thu, 22 May 2008 21:19:19 +0000 (21:19 +0000)]
Add a couple of test cases.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51441
91177308-0d34-0410-b5e6-
96231b3b80d8
David Greene [Thu, 22 May 2008 21:16:33 +0000 (21:16 +0000)]
When rewriting defs and uses after spilling, don't set the weight of a
live interval to infinity if the instruction being rewritten is an
original remat def instruction. We were only checking against the clone
of the remat def which doesn't actually appear in the IR at all.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51440
91177308-0d34-0410-b5e6-
96231b3b80d8
David Greene [Thu, 22 May 2008 21:12:21 +0000 (21:12 +0000)]
Don't attempt to update SpillSlotToUsesMap for stack slots that aren't
generated by the spiller.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51439
91177308-0d34-0410-b5e6-
96231b3b80d8