Colin LeMahieu [Tue, 3 Nov 2015 00:21:19 +0000 (00:21 +0000)]
[Hexagon] Fixing mistaken case fallthrough.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251867
91177308-0d34-0410-b5e6-
96231b3b80d8
Teresa Johnson [Tue, 3 Nov 2015 00:14:15 +0000 (00:14 +0000)]
Restore "Support for ThinLTO function importing and symbol linking."
This restores commit r251837, with the new library dependence added to
llvm-link/Makefile to address bot failures.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251866
91177308-0d34-0410-b5e6-
96231b3b80d8
Kevin Enderby [Mon, 2 Nov 2015 23:42:05 +0000 (23:42 +0000)]
Allow llvm-nm’s single letter command line flags to be grouped.
Which is needed if we want to replace darwin’s nm(1) with llvm-nm
as there are many uses of grouped flags. The added test case is
one specific case that is in real use.
rdar://
23337419
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251864
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Mon, 2 Nov 2015 23:30:48 +0000 (23:30 +0000)]
AMDGPU: Stop assuming vreg for build_vector
This was causing a variety of test failures when v2i64
is added as a legal type.
SIFixSGPRCopies should correctly handle the case of vector inputs
to a scalar reg_sequence, so this isn't necessary anymore. This
was hiding some deficiencies in how reg_sequence is handled later,
but this shouldn't be a problem anymore since the register class
copy of a reg_sequence is now done before the reg_sequence.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251860
91177308-0d34-0410-b5e6-
96231b3b80d8
Derek Schuff [Mon, 2 Nov 2015 23:23:16 +0000 (23:23 +0000)]
[WebAssembly] Make WebAssemblyCodeGen depend on WebAssemblyAsmPrinter
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251859
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Mon, 2 Nov 2015 23:23:02 +0000 (23:23 +0000)]
AMDGPU: Error on graphics shaders with HSA
I've found myself pointlessly debugging problems from running
graphics tests with an HSA triple a few times, so stop this from
happening again.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251858
91177308-0d34-0410-b5e6-
96231b3b80d8
Sanjay Patel [Mon, 2 Nov 2015 23:22:49 +0000 (23:22 +0000)]
[CGP] widen switch condition and case constants to target's register width (2nd try)
This is a redo of r251849 except the tests have been split into arch-specific folders
to hopefully make the bots happy.
This is a follow-up from the discussion in D12965. The block-at-a-time limitation of
SelectionDAG also came up in D13297.
Without the InstCombine change from D12965, I don't expect this patch to make any
difference in the real world because InstCombine does not shrink cases like this in
visitSwitchInst(). But we need to have this CGP safety harness in place before
proceeding with any shrinkage in D12965, so we won't generate extra extends for compares.
I've opted for IR regression tests in the patch because that seems like a clearer way to
test the transform, but PowerPC CodeGen for an i16 widening test is shown below. x86
will need more work to solve: https://llvm.org/bugs/show_bug.cgi?id=22473
Before:
BB#0:
mr 4, 3
extsh. 3, 4
ble 0, .LBB0_5
BB#1:
cmpwi 3, 99
bgt 0, .LBB0_9
BB#2:
rlwinm 4, 4, 0, 16, 31 <--- 32-bit mask/extend
li 3, 0
cmplwi 4, 1
beqlr 0
BB#3:
cmplwi 4, 10
bne 0, .LBB0_12
BB#4:
li 3, 1
blr
.LBB0_5:
rlwinm 3, 4, 0, 16, 31 <--- 32-bit mask/extend
cmplwi 3, 65436
beq 0, .LBB0_13
BB#6:
cmplwi 3, 65526
beq 0, .LBB0_15
BB#7:
cmplwi 3, 65535
bne 0, .LBB0_12
BB#8:
li 3, 4
blr
.LBB0_9:
rlwinm 3, 4, 0, 16, 31 <--- 32-bit mask/extend
cmplwi 3, 100
beq 0, .LBB0_14
...
After:
BB#0:
rlwinm 4, 3, 0, 16, 31 <--- mask/extend to 32-bit and then use that for comparisons
cmpwi 4, 999
ble 0, .LBB0_5
BB#1:
lis 3, 0
ori 3, 3, 65525
cmpw 4, 3
bgt 0, .LBB0_9
BB#2:
cmplwi 4, 1000
beq 0, .LBB0_14
BB#3:
cmplwi 4, 65436
bne 0, .LBB0_13
BB#4:
li 3, 6
blr
.LBB0_5:
li 3, 0
cmplwi 4, 1
beqlr 0
BB#6:
cmplwi 4, 10
beq 0, .LBB0_12
BB#7:
cmplwi 4, 100
bne 0, .LBB0_13
BB#8:
li 3, 2
blr
.LBB0_9:
cmplwi 4, 65526
beq 0, .LBB0_15
BB#10:
cmplwi 4, 65535
bne 0, .LBB0_13
...
Differential Revision: http://reviews.llvm.org/D13532
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251857
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Mon, 2 Nov 2015 23:15:46 +0000 (23:15 +0000)]
AMDGPU: Un XFAIL a test
This should probably be merged with one of the other private memory
tests, but it fails on r600.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251856
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Mon, 2 Nov 2015 23:15:42 +0000 (23:15 +0000)]
AMDGPU: Distribute SGPR->VGPR copies of REG_SEQUENCE
Make the REG_SEQUENCE be a VGPR, and do the register class
copy first.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251855
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Mon, 2 Nov 2015 23:10:52 +0000 (23:10 +0000)]
Fix the build I just broke
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251854
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Mon, 2 Nov 2015 23:09:38 +0000 (23:09 +0000)]
Orc: Drop some else-after-return, reflow a few spots, and avoid use of pointee types
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251853
91177308-0d34-0410-b5e6-
96231b3b80d8
Davide Italiano [Mon, 2 Nov 2015 23:07:14 +0000 (23:07 +0000)]
[SimplifyLibCalls] Remove variables that are not used. NFC.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251852
91177308-0d34-0410-b5e6-
96231b3b80d8
Sanjay Patel [Mon, 2 Nov 2015 23:05:20 +0000 (23:05 +0000)]
revert r251849; need to move tests to arch-specific folders
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251851
91177308-0d34-0410-b5e6-
96231b3b80d8
Cong Hou [Mon, 2 Nov 2015 22:53:48 +0000 (22:53 +0000)]
Add a flag vectorizer-maximize-bandwidth in loop vectorizer to enable using larger vectorization factor.
To be able to maximize the bandwidth during vectorization, this patch provides a new flag vectorizer-maximize-bandwidth. When it is turned on, the vectorizer will determine the vectorization factor (VF) using the smallest instead of widest type in the loop. To avoid increasing register pressure too much, estimates of the register usage for different VFs are calculated so that we only choose a VF when its register usage doesn't exceed the number of available registers.
This is the second attempt to submit this patch. The first attempt got a test failure on ARM. This patch is updated to try to fix the failure (more specifically, by handling the case when VF=1).
Differential revision: http://reviews.llvm.org/D8943
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251850
91177308-0d34-0410-b5e6-
96231b3b80d8
Sanjay Patel [Mon, 2 Nov 2015 22:46:24 +0000 (22:46 +0000)]
[CGP] widen switch condition and case constants to target's register width
This is a follow-up from the discussion in D12965. The block-at-a-time limitation of
SelectionDAG also came up in D13297.
Without the InstCombine change from D12965, I don't expect this patch to make any
difference in the real world because InstCombine does not shrink cases like this in
visitSwitchInst(). But we need to have this CGP safety harness in place before
proceeding with any shrinkage in D12965, so we won't generate extra extends for compares.
I've opted for IR regression tests in the patch because that seems like a clearer way to
test the transform, but PowerPC CodeGen for an i16 widening test is shown below. x86
will need more work to solve: https://llvm.org/bugs/show_bug.cgi?id=22473
Before:
BB#0:
mr 4, 3
extsh. 3, 4
ble 0, .LBB0_5
BB#1:
cmpwi 3, 99
bgt 0, .LBB0_9
BB#2:
rlwinm 4, 4, 0, 16, 31 <--- 32-bit mask/extend
li 3, 0
cmplwi 4, 1
beqlr 0
BB#3:
cmplwi 4, 10
bne 0, .LBB0_12
BB#4:
li 3, 1
blr
.LBB0_5:
rlwinm 3, 4, 0, 16, 31 <--- 32-bit mask/extend
cmplwi 3, 65436
beq 0, .LBB0_13
BB#6:
cmplwi 3, 65526
beq 0, .LBB0_15
BB#7:
cmplwi 3, 65535
bne 0, .LBB0_12
BB#8:
li 3, 4
blr
.LBB0_9:
rlwinm 3, 4, 0, 16, 31 <--- 32-bit mask/extend
cmplwi 3, 100
beq 0, .LBB0_14
...
After:
BB#0:
rlwinm 4, 3, 0, 16, 31 <--- mask/extend to 32-bit and then use that for comparisons
cmpwi 4, 999
ble 0, .LBB0_5
BB#1:
lis 3, 0
ori 3, 3, 65525
cmpw 4, 3
bgt 0, .LBB0_9
BB#2:
cmplwi 4, 1000
beq 0, .LBB0_14
BB#3:
cmplwi 4, 65436
bne 0, .LBB0_13
BB#4:
li 3, 6
blr
.LBB0_5:
li 3, 0
cmplwi 4, 1
beqlr 0
BB#6:
cmplwi 4, 10
beq 0, .LBB0_12
BB#7:
cmplwi 4, 100
bne 0, .LBB0_13
BB#8:
li 3, 2
blr
.LBB0_9:
cmplwi 4, 65526
beq 0, .LBB0_15
BB#10:
cmplwi 4, 65535
bne 0, .LBB0_13
...
Differential Revision: http://reviews.llvm.org/D13532
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251849
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Schmidt [Mon, 2 Nov 2015 22:43:57 +0000 (22:43 +0000)]
[PPC64LE] Properly initialize instr-info in PPCVSXSwapRemoval pass
Replace some hacky code with the proper way to get at this data.
No functional change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251848
91177308-0d34-0410-b5e6-
96231b3b80d8
Sanjay Patel [Mon, 2 Nov 2015 22:34:55 +0000 (22:34 +0000)]
don't repeat function names in comments; NFC
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251846
91177308-0d34-0410-b5e6-
96231b3b80d8
Davide Italiano [Mon, 2 Nov 2015 22:33:26 +0000 (22:33 +0000)]
[SimplifyLibCalls] Merge two if statements. NFC.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251845
91177308-0d34-0410-b5e6-
96231b3b80d8
Teresa Johnson [Mon, 2 Nov 2015 22:17:32 +0000 (22:17 +0000)]
Revert "Support for ThinLTO function importing and symbol linking."
This reverts commit r251837, due to a number of bot failures of the form:
/home/grosser/buildslave/perf-x86_64-penryn-O3-polly-fast/llvm.obj/tools/llvm-link/Release+Asserts/llvm-link.o:llvm-link.cpp:function
loadIndex(llvm::LLVMContext&, llvm::Module const*): error: undefined
reference to
'llvm::object::FunctionIndexObjectFile::create(llvm::MemoryBufferRef,
llvm::LLVMContext&, llvm::Module const*, bool)'
/home/grosser/buildslave/perf-x86_64-penryn-O3-polly-fast/llvm.obj/tools/llvm-link/Release+Asserts/llvm-link.o:llvm-link.cpp:function
loadIndex(llvm::LLVMContext&, llvm::Module const*): error: undefined
reference to 'llvm::object::FunctionIndexObjectFile::takeIndex()'
I'm not sure why these are happening - I added Object to the requred
libraries in tools/llvm-link/LLVMBuild.txt and the LLVM_LINK_COMPONENTS
in tools/llvm-link/CMakeLists.txt. Confirmed for my build that these
symbols come out of libLLVMObject.a. What am I missing?
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251841
91177308-0d34-0410-b5e6-
96231b3b80d8
Chen Li [Mon, 2 Nov 2015 22:00:15 +0000 (22:00 +0000)]
[IndVarSimplify] Rewrite loop exit values with their initial values from loop preheader
Summary:
This patch adds support to check if a loop has loop invariant conditions which lead to loop exits. If so, we know that if the exit path is taken, it is at the first loop iteration. If there is an induction variable used in that exit path whose value has not been updated, it will keep its initial value passing from loop preheader. We can therefore rewrite the exit value with
its initial value. This will help remove phis created by LCSSA and enable other optimizations like loop unswitch.
Reviewers: sanjoy
Subscribers: llvm-commits
Differential Revision: http://reviews.llvm.org/D13974
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251839
91177308-0d34-0410-b5e6-
96231b3b80d8
Teresa Johnson [Mon, 2 Nov 2015 21:39:10 +0000 (21:39 +0000)]
Support for ThinLTO function importing and symbol linking.
Summary:
Support for necessary linkage changes and symbol renaming during
ThinLTO function importing.
Also includes llvm-link support for manually importing functions
and associated llvm-link based tests.
Note that this does not include support for intelligently importing
metadata, which is currently imported duplicate times. That support will
be in the follow-on patch, and currently is ignored by the tests.
Reviewers: dexonsmith, joker.eph, davidxl
Subscribers: tobiasvk, tejohnson, llvm-commits
Differential Revision: http://reviews.llvm.org/D13515
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251837
91177308-0d34-0410-b5e6-
96231b3b80d8
Tim Northover [Mon, 2 Nov 2015 21:26:58 +0000 (21:26 +0000)]
MachO: support tvOS and watchOS version min commands in llvm-objdump
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251834
91177308-0d34-0410-b5e6-
96231b3b80d8
Cong Hou [Mon, 2 Nov 2015 21:24:00 +0000 (21:24 +0000)]
In MachineBlockPlacement, filter cold blocks off the loop chain when profile data is available.
In the current BB placement algorithm, a loop chain always contains all loop blocks. This has a drawback that cold blocks in the loop may be inserted on a hot function path, hence increasing branch cost and also reducing icache locality.
Consider a simple example shown below:
A
|
B⇆C
|
D
When B->C is quite cold, the best BB-layout should be A,B,D,C. But the current implementation produces A,C,B,D.
This patch filters those cold blocks off from the loop chain by comparing the ratio:
LoopBBFreq / LoopFreq
to 20%: if it is less than 20%, we don't include this BB to the loop chain. Here LoopFreq is the frequency of the loop when we reduce the loop into a single node. In general we have more cold blocks when the loop has few iterations. And vice versa.
Differential revision: http://reviews.llvm.org/D11662
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251833
91177308-0d34-0410-b5e6-
96231b3b80d8
Reid Kleckner [Mon, 2 Nov 2015 20:49:29 +0000 (20:49 +0000)]
[Support] Assert that reported key+data lenghts match reality
This found a bug in Clang's PTH implementation.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251829
91177308-0d34-0410-b5e6-
96231b3b80d8
Teresa Johnson [Mon, 2 Nov 2015 20:43:33 +0000 (20:43 +0000)]
Fix use-after-free in function index merging code.
This was flagged by ASAN when using a test case I will be committing
along with D13515.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251827
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Mon, 2 Nov 2015 20:05:54 +0000 (20:05 +0000)]
Revert parts accidentally included in r251823
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251826
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Mon, 2 Nov 2015 20:01:13 +0000 (20:01 +0000)]
StringRef-ify DiagnosticInfoSampleProfile::Filename
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251823
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Mon, 2 Nov 2015 19:13:59 +0000 (19:13 +0000)]
ELF can handle some relocations of the form -sym + constant.
Remove code that was assuming that this would never work.
Thanks to Colin LeMahie for finding and diagnosing the bug.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251818
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Mon, 2 Nov 2015 19:03:18 +0000 (19:03 +0000)]
Convert tabs to spaces.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251817
91177308-0d34-0410-b5e6-
96231b3b80d8
James Y Knight [Mon, 2 Nov 2015 18:48:08 +0000 (18:48 +0000)]
Fix two issues in MergeConsecutiveStores:
1) PR25154. This is basically a repeat of PR18102, which was fixed in
r200201, and broken again by r234430. The latter changed which of the
store nodes was merged into from the first to the last. Thus, we now
also need to prefer merging a later store at a given address into the
target node, instead of an earlier one.
2) While investigating that, I also realized I'd introduced a bug in
r236850. There, I removed a check for alignment -- not realizing that
nothing except the alignment check was ensuring that none of the stores
were overlapping! This is a really bogus way to ensure there's no
aliased stores.
A better solution to both of these issues is likely to always use the
code added in the 'if (UseAA)' branches which rearrange the chain based
on a more principled analysis. I'll look into whether that can be used
always, but in the interest of getting things back to working, I think a
minimal change makes sense.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251816
91177308-0d34-0410-b5e6-
96231b3b80d8
Tim Northover [Mon, 2 Nov 2015 18:33:35 +0000 (18:33 +0000)]
MachO: improve load command tests slightly
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251815
91177308-0d34-0410-b5e6-
96231b3b80d8
Tim Northover [Mon, 2 Nov 2015 18:21:07 +0000 (18:21 +0000)]
WatchOS: update default CPU for triple after t2dsp -> dsp rename
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251814
91177308-0d34-0410-b5e6-
96231b3b80d8
Teresa Johnson [Mon, 2 Nov 2015 18:02:11 +0000 (18:02 +0000)]
Clang format a few prior patches (NFC)
I had clang formatted my earlier patches using the wrong style.
Reformatted with the LLVM style.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251812
91177308-0d34-0410-b5e6-
96231b3b80d8
Tim Northover [Mon, 2 Nov 2015 18:00:00 +0000 (18:00 +0000)]
TvOS: add missing support for some libcalls.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251811
91177308-0d34-0410-b5e6-
96231b3b80d8
Artur Pilipenko [Mon, 2 Nov 2015 17:53:51 +0000 (17:53 +0000)]
Preserve load alignment and dereferenceable metadata during some transformations
Reviewed By: hfinkel
Differential Revision: http://reviews.llvm.org/D13953
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251809
91177308-0d34-0410-b5e6-
96231b3b80d8
Matthias Braun [Mon, 2 Nov 2015 16:13:46 +0000 (16:13 +0000)]
lit: Add '-a' option to display commands+output of all tests
The existing -v option only displays commands and outputs for failed
tests, the newly introduced -a displays it for all executed tests.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251806
91177308-0d34-0410-b5e6-
96231b3b80d8
Silviu Baranga [Mon, 2 Nov 2015 15:29:49 +0000 (15:29 +0000)]
Add missing override statements in ScalarEvolution.h. NFC
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251805
91177308-0d34-0410-b5e6-
96231b3b80d8
Pawel Bylica [Mon, 2 Nov 2015 14:57:24 +0000 (14:57 +0000)]
Use static instead of anonymous namespace for helper functions. NFC.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251801
91177308-0d34-0410-b5e6-
96231b3b80d8
Silviu Baranga [Mon, 2 Nov 2015 14:41:02 +0000 (14:41 +0000)]
[SCEV][LV] Add SCEV Predicates and use them to re-implement stride versioning
Summary:
SCEV Predicates represent conditions that typically cannot be derived from
static analysis, but can be used to reduce SCEV expressions to forms which are
usable for different optimizers.
ScalarEvolution now has the rewriteUsingPredicate method which can simplify a
SCEV expression using a SCEVPredicateSet. The normal workflow of a pass using
SCEVPredicates would be to hold a SCEVPredicateSet and every time assumptions
need to be made a new SCEV Predicate would be created and added to the set.
Each time after calling getSCEV, the user will call the rewriteUsingPredicate
method.
We add two types of predicates
SCEVPredicateSet - implements a set of predicates
SCEVEqualPredicate - tests for equality between two SCEV expressions
We use the SCEVEqualPredicate to re-implement stride versioning. Every time we
version a stride, we will add a SCEVEqualPredicate to the context.
Instead of adding specific stride checks, LoopVectorize now adds a more
generic SCEV check.
We only need to add support for this in the LoopVectorizer since this is the
only pass that will do stride versioning.
Reviewers: mzolotukhin, anemet, hfinkel, sanjoy
Subscribers: sanjoy, hfinkel, rengolin, jmolloy, llvm-commits
Differential Revision: http://reviews.llvm.org/D13595
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251800
91177308-0d34-0410-b5e6-
96231b3b80d8
Nemanja Ivanovic [Mon, 2 Nov 2015 14:01:11 +0000 (14:01 +0000)]
Fix for bootstrap bug introduced in r244921
This revision has introduced an issue that only affects bootstrapped compiler
when it is printing the ASM. It turns out that the new code path taken due to
legalizing a scalar_to_vector of i64 -> v2i64 exposes a missing check in a
micro optimization to change a load followed by a scalar_to_vector into a
load and splat instruction on PPC.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251798
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Mon, 2 Nov 2015 13:30:46 +0000 (13:30 +0000)]
This doesn't need a object::Archive::child_iterator.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251796
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Mon, 2 Nov 2015 13:17:11 +0000 (13:17 +0000)]
Avoid implicitly constructing a Archive::child_iterator.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251794
91177308-0d34-0410-b5e6-
96231b3b80d8
James Molloy [Mon, 2 Nov 2015 09:54:00 +0000 (09:54 +0000)]
[PatternMatch] Switch to use ValueTracking::matchSelectPattern
Instead of rolling our own min/max matching code (which is notoriously
hard to get completely right), use ValueTracking's instead.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251785
91177308-0d34-0410-b5e6-
96231b3b80d8
Pawel Bylica [Mon, 2 Nov 2015 09:49:17 +0000 (09:49 +0000)]
[Support] Extend sys::path with user_cache_directory function.
Summary:
The new function sys::path::user_cache_directory tries to discover
a directory suitable for cache storage for current system user.
On Windows and Darwin it returns a path to system-specific user cache directory.
On Linux it follows XDG Base Directory Specification, what is:
- use non-empty $XDG_CACHE_HOME env var,
- use $HOME/.cache.
Reviewers: chapuni, aaron.ballman, rafael
Subscribers: rafael, aaron.ballman, llvm-commits
Differential Revision: http://reviews.llvm.org/D13801
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251784
91177308-0d34-0410-b5e6-
96231b3b80d8
Igor Breger [Mon, 2 Nov 2015 07:39:36 +0000 (07:39 +0000)]
AVX512: Implemented encoding and intrinsics for VBROADCASTI32x2 and VBROADCASTF32x2 instructions.
Differential Revision: http://reviews.llvm.org/D14216
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251781
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Mon, 2 Nov 2015 07:24:40 +0000 (07:24 +0000)]
[X86] Remove assertions that check for valid scale values on scatter/gather intrinsics. Nothing upstream prevented illegal values from getting here.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251780
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Mon, 2 Nov 2015 07:24:37 +0000 (07:24 +0000)]
[X86] Don't pass a scale value of 0 to scatter/gather intrinsics. This causes the code emitter to throw an assertion if we try to encode it. Need to add a check to fail isel for this, but for now avoid testing it.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251779
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Mon, 2 Nov 2015 07:24:34 +0000 (07:24 +0000)]
[X86] Fold 'if' followed by just an llvm_unreachable into an assert.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251778
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Mon, 2 Nov 2015 07:24:32 +0000 (07:24 +0000)]
[X86] Use isa instead of dyn_cast in a bool context. NFC
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251777
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Mon, 2 Nov 2015 07:24:30 +0000 (07:24 +0000)]
[X86] Remove some llvm_unreachables after switches that already have an unreachable in their default case.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251776
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Mon, 2 Nov 2015 07:24:27 +0000 (07:24 +0000)]
[X86] Remove a 'break' after an llvm_unreachable.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251775
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Mon, 2 Nov 2015 07:24:25 +0000 (07:24 +0000)]
[X86] Use cast instead of dyn_cast and a null check marked unreachable.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251774
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Mon, 2 Nov 2015 05:24:28 +0000 (05:24 +0000)]
Fix a -Wpessimizing-move warning.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251773
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Mon, 2 Nov 2015 05:24:22 +0000 (05:24 +0000)]
[X86] Use MVT instead of EVT when the type is known to be simple. NFC
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251772
91177308-0d34-0410-b5e6-
96231b3b80d8
Xinliang David Li [Mon, 2 Nov 2015 05:08:23 +0000 (05:08 +0000)]
[PGO] Value profiling (index format) code cleanup and testing
1. Added a set of public interfaces in InstrProfRecord
class to access (read/write) value profile data.
2. Changed IndexedProfile reader and writer code to
use the newly defined interfaces and hide implementation
details.
3. Added a couple of unittests for value profiling:
- Test new interfaces to get and set value profile data
- Test value profile data merging with various scenarios.
No functional change is expected. The new interfaces will also
make it possible to change on-disk format of value prof data
to be more compact (to be submitted).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251771
91177308-0d34-0410-b5e6-
96231b3b80d8
Sanjoy Das [Mon, 2 Nov 2015 02:06:01 +0000 (02:06 +0000)]
[SCEV] Fix PR25369
Have `getConstantEvolutionLoopExitValue` work correctly with multiple
entry loops.
As far as I can tell, `getConstantEvolutionLoopExitValue` never did the
right thing for multiple entry loops; and before r249712 it would
silently return an incorrect answer. r249712 changed SCEV to fail an
assert on a multiple entry loop, and this change fixes the underlying
issue.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251770
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Mon, 2 Nov 2015 01:38:12 +0000 (01:38 +0000)]
Untabify.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251769
91177308-0d34-0410-b5e6-
96231b3b80d8
Davide Italiano [Sun, 1 Nov 2015 17:00:13 +0000 (17:00 +0000)]
[LibraryInfo] Point to FreeBSD HEAD repo and not to a dolphin branch.
The latter might go away (anytime soon).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251765
91177308-0d34-0410-b5e6-
96231b3b80d8
Elena Demikhovsky [Sun, 1 Nov 2015 11:45:47 +0000 (11:45 +0000)]
AVX-512: Optimized SIMD truncate operations for AVX512F set.
Optimized <8 x i32> to <8 x i16>
<4 x i64> to < 4 x i32>
<16 x i16> to <16 x i8>
All these oprtrations use now AVX512F set (KNL). Before this change it was implemented with AVX2 set.
Differential Revision: http://reviews.llvm.org/D14108
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251764
91177308-0d34-0410-b5e6-
96231b3b80d8
Saleem Abdulrasool [Sun, 1 Nov 2015 01:26:15 +0000 (01:26 +0000)]
RuntimeDyld: add COFF i386 support
This adds support for COFF I386. This is sufficient for code execution in a
32-bit JIT, though, imported symbols need to custom lowered for the redirection.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251761
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Sun, 1 Nov 2015 00:14:59 +0000 (00:14 +0000)]
Make a few definitions static. NFC.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251759
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Sun, 1 Nov 2015 00:10:37 +0000 (00:10 +0000)]
Use Child instead of child_iterator in the archive writer.
We never need to pass end(). This will also remove some complication
once we start adding error checking.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251758
91177308-0d34-0410-b5e6-
96231b3b80d8
Davide Italiano [Sun, 1 Nov 2015 00:09:16 +0000 (00:09 +0000)]
Simplify a check. NFC.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251757
91177308-0d34-0410-b5e6-
96231b3b80d8
Sanjoy Das [Sat, 31 Oct 2015 23:21:40 +0000 (23:21 +0000)]
[SCEV] Don't create SCEV expressions that break LCSSA
Prevent `createNodeFromSelectLikePHI` from creating SCEV expressions
that break LCSSA.
A better fix for the same issue is to teach SCEVExpander to not break
LCSSA by inserting PHI nodes at appropriate places. That's planned for
the future.
Fixes PR25360.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251756
91177308-0d34-0410-b5e6-
96231b3b80d8
Sanjoy Das [Sat, 31 Oct 2015 23:21:32 +0000 (23:21 +0000)]
[SCEV] Use auto and range for; NFC
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251755
91177308-0d34-0410-b5e6-
96231b3b80d8
Davide Italiano [Sat, 31 Oct 2015 23:17:45 +0000 (23:17 +0000)]
[SimplifyLibCalls] Factor out other common code.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251754
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Sat, 31 Oct 2015 22:25:59 +0000 (22:25 +0000)]
This can take a const reference. NFC.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251753
91177308-0d34-0410-b5e6-
96231b3b80d8
Diego Novillo [Sat, 31 Oct 2015 21:53:58 +0000 (21:53 +0000)]
SamplePGO - Count sample records in embedded profiles when computing coverage.
The initial coverage checking code for sample records failed to count
records inside inlined profiles. This change fixes the oversight.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251752
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sat, 31 Oct 2015 21:44:52 +0000 (21:44 +0000)]
[X86] Replace getScalarType with getVectorElementType when the type is already known to be a vector. This should result in slightly less code. NFC
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251751
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Sat, 31 Oct 2015 21:44:42 +0000 (21:44 +0000)]
Don't store a Child to the first regular member.
This is a bit ugly, but has a few advantages:
* Archive is now easy to copy since there is no Archive -> Child -> Archive
loop.
* It makes it clear that we already checked for errors when finding the Child
data.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251750
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Sat, 31 Oct 2015 21:16:01 +0000 (21:16 +0000)]
Delete dead code.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251749
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Sat, 31 Oct 2015 21:03:29 +0000 (21:03 +0000)]
Simplify handling of archive Symbol tables.
We only need to store a StringRef.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251748
91177308-0d34-0410-b5e6-
96231b3b80d8
Davide Italiano [Sat, 31 Oct 2015 20:59:32 +0000 (20:59 +0000)]
[SimplifyLibCalls] Add test to ensure transform is not executed if fast-math
attribute is not present.
During my refactor in r251595 I changed the behavior of optimizeSqrt(),
skipping the transformation if the function wasn't marked with unsafe-fp-math
attribute. This fixed a bug, as confirmed by Sanjay (before the optimization
was silently executed anyway), although it wasn't my primary aim.
This commit adds a test to ensure the code doesn't break again.
Reported by: Marcello Maggioni
Discussed with: Sanjay Patel
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251747
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Sat, 31 Oct 2015 20:06:13 +0000 (20:06 +0000)]
Simplify the handling of the archive string table.
We only need to store a StringRef
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251746
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sat, 31 Oct 2015 18:14:17 +0000 (18:14 +0000)]
[X86] Convert to MVT instead of calling EVT functions since we already know the type is simple. NFC
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251745
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sat, 31 Oct 2015 18:14:15 +0000 (18:14 +0000)]
[X86] Call getScalarSizeInBits() instead of getScalarType().getScalarSizeInBits(). NFC
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251744
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sat, 31 Oct 2015 17:28:02 +0000 (17:28 +0000)]
[X86] Remove two const references to the return value of a constructor and just use normal object creation syntax. NFC
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251743
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sat, 31 Oct 2015 17:27:59 +0000 (17:27 +0000)]
[X86] Replace EVT with MVT in some more places. NFC
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251742
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sat, 31 Oct 2015 17:27:56 +0000 (17:27 +0000)]
[X86] Fix indentation of case statements in switch. NFC
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251741
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sat, 31 Oct 2015 17:27:52 +0000 (17:27 +0000)]
[X86] Reduce math for index calculation for inserting and extracting subvectors and elements by exploiting the fact that all supported vector types have a power 2 number of elements.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251740
91177308-0d34-0410-b5e6-
96231b3b80d8
Davide Italiano [Sat, 31 Oct 2015 08:28:10 +0000 (08:28 +0000)]
[SimplifyLibCalls] Remove dead code.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251737
91177308-0d34-0410-b5e6-
96231b3b80d8
Michael Gottesman [Sat, 31 Oct 2015 05:23:53 +0000 (05:23 +0000)]
Add a unittest for SmallDenseMap that tests assigning a SmallDenseMap when it is not small.
This complements CopyConstructorNotSmallTest. If we are testing the copy
constructor in such a way, we should also probably test assignment in the same
way.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251736
91177308-0d34-0410-b5e6-
96231b3b80d8
Lang Hames [Sat, 31 Oct 2015 00:55:32 +0000 (00:55 +0000)]
Add a sys::OwningMemoryBlock class, which is a sys::MemoryBlock that owns its
underlying memory, and will automatically release it on destruction.
Use this to tidy up the orc::IndirectStubsInfo class.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251731
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Sat, 31 Oct 2015 00:28:37 +0000 (00:28 +0000)]
[FunctionAttrs] Inline the prototype attribute inference to an existing
loop over the SCC.
The separate function wasn't really adding much, NFC.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251728
91177308-0d34-0410-b5e6-
96231b3b80d8
Justin Bogner [Fri, 30 Oct 2015 23:28:12 +0000 (23:28 +0000)]
[PM] Port StripDeadPrototypes to the new pass manager
This is a really straightforward port. Also adds a test for the pass,
since it only seemed to be tested tangentially before.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251726
91177308-0d34-0410-b5e6-
96231b3b80d8
Justin Bogner [Fri, 30 Oct 2015 23:13:18 +0000 (23:13 +0000)]
[PM] Port ADCE to the new pass manager
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251725
91177308-0d34-0410-b5e6-
96231b3b80d8
Justin Bogner [Fri, 30 Oct 2015 23:02:38 +0000 (23:02 +0000)]
Whitespace. NFC
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251724
91177308-0d34-0410-b5e6-
96231b3b80d8
Justin Bogner [Fri, 30 Oct 2015 22:58:15 +0000 (22:58 +0000)]
PM: Print the IR unit's name in debug output. NFC
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251723
91177308-0d34-0410-b5e6-
96231b3b80d8
Kevin Enderby [Fri, 30 Oct 2015 19:55:32 +0000 (19:55 +0000)]
Implemented the code to make llvm-nm’s -g option work.
While llvm-nm parses the -g option and has help that describes it as:
-extern-only - Show only external symbols
There is no code in the program to use the boolean valve it sets from the
command line.
rdar://
23261095
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251718
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Fri, 30 Oct 2015 16:48:08 +0000 (16:48 +0000)]
[FunctionAttrs] Separate another chunk of the logic for functionattrs
from its pass harness by providing a lambda to query for AA results.
This allows the legacy pass to easily provide a lambda that uses the
special helpers to construct function AA results from a legacy CGSCC
pass. With the new pass manager (the next patch) the lambda just
directly wraps the intuitive query API.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251715
91177308-0d34-0410-b5e6-
96231b3b80d8
JF Bastien [Fri, 30 Oct 2015 16:41:21 +0000 (16:41 +0000)]
[WebAssembly] Fix import statement
Summary:
Imports should be generated like (param i32 f32...) not (param i32) (param f32) ...
Author: binji
Reviewers: jfb
Subscribers: jfb, dschuff
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251714
91177308-0d34-0410-b5e6-
96231b3b80d8
Tim Northover [Fri, 30 Oct 2015 16:29:44 +0000 (16:29 +0000)]
ARM: add extra test for watchOS ABI
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251705
91177308-0d34-0410-b5e6-
96231b3b80d8
Silviu Baranga [Fri, 30 Oct 2015 15:02:28 +0000 (15:02 +0000)]
[SCEV] Generalize the SCEV algorithm for creating expressions for PHI nodes
Summary:
When forming expressions for phi nodes having an incoming value from
outside the loop A and a value coming from the previous iteration B
we were forming an AddRec if:
- B was an AddRec
- the value A was equal to the value for B at iteration -1 (or equal
to the value of B shifted by one iteration, at iteration 0)
In this case, we were computing the expression to be the expression of
B, shifted by one iteration.
This changes generalizes the logic above by removing the restriction that
B needs to be an AddRec. For this we introduce two expression rewriters
that allow us to
- shift an expression by one iteration
- get the value of an expression at iteration 0
This allows us to get SCEV expressions for PHI nodes when these expressions
are not AddRecExprs.
Reviewers: sanjoy
Subscribers: llvm-commits, sanjoy
Differential Revision: http://reviews.llvm.org/D14175
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251700
91177308-0d34-0410-b5e6-
96231b3b80d8
Dehao Chen [Fri, 30 Oct 2015 05:07:15 +0000 (05:07 +0000)]
Recommit r251680 (also need to update clang test)
Update the discriminator assignment algorithm
* If a scope has already been assigned a discriminator, do not reassign a nested discriminator for it.
* If the file and line both match, even if the column does not match, we should assign a new discriminator for the stmt.
original code:
; #1 int foo(int i) {
; #2 if (i == 3 || i == 5) return 100; else return 99;
; #3 }
; i == 3: discriminator 0
; i == 5: discriminator 2
; return 100: discriminator 1
; return 99: discriminator 3
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251689
91177308-0d34-0410-b5e6-
96231b3b80d8
Dehao Chen [Fri, 30 Oct 2015 04:48:24 +0000 (04:48 +0000)]
Remove oneline.ll test.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251688
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Fri, 30 Oct 2015 04:31:18 +0000 (04:31 +0000)]
[X86] Use is128BitVector/is256BitVector/is512BitVector in place of getSizeInBits == in some places. NFC
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251687
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Fri, 30 Oct 2015 04:31:14 +0000 (04:31 +0000)]
[X86] Minor formatting fixes. NFC.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251686
91177308-0d34-0410-b5e6-
96231b3b80d8
Dehao Chen [Fri, 30 Oct 2015 04:29:05 +0000 (04:29 +0000)]
Revert r251680:
Update the discriminator assignment algorithm
* If a scope has already been assigned a discriminator, do not reassign a nested discriminator for it.
* If the file and line both match, even if the column does not match, we should assign a new discriminator for the stmt.
original code:
; #1 int foo(int i) {
; #2 if (i == 3 || i == 5) return 100; else return 99;
; #3 }
; i == 3: discriminator 0
; i == 5: discriminator 2
; return 100: discriminator 1
; return 99: discriminator 3
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251685
91177308-0d34-0410-b5e6-
96231b3b80d8
Lang Hames [Fri, 30 Oct 2015 03:20:21 +0000 (03:20 +0000)]
[Orc] Expose the compile callback API through the C bindings.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251683
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Fri, 30 Oct 2015 03:19:12 +0000 (03:19 +0000)]
[X86] Use MVT instead of EVT in some places. NFC
Prior to this the compiled code probably had extra checks for extended types that won't ever execute.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251682
91177308-0d34-0410-b5e6-
96231b3b80d8