Chandler Carruth [Tue, 16 Sep 2014 00:24:42 +0000 (00:24 +0000)]
[x86] As a follow-up to r217819, don't check for VSELECT legality now
that we don't use VSELECT and directly emit an addsub synthetic node.
Also remove a stale comment referencing VSELECT.
The test case is updated to use 'core2' which only has SSE3, not SSE4.1,
and it still passes. Previously it would not because we lacked
sufficient blend support to legalize the VSELECT.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217849
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Tue, 16 Sep 2014 00:15:20 +0000 (00:15 +0000)]
[x86] Add the beginnings of a proper DAG combine to match ADDSUBPS and
ADDSUBPD nodes out of blends of adds and subs.
This allows us to actually form these instructions with SSE3 rather than
only forming them when we had both SSE3 for the ADDSUB instructions and
SSE4.1 for the blend instructions. ;] Kind-of important.
I've adjusted the CPU requirements on one of the tests to demonstrate
this kicking in nicely for an SSE3 cpu configuration.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217848
91177308-0d34-0410-b5e6-
96231b3b80d8
Juergen Ributzka [Mon, 15 Sep 2014 23:47:57 +0000 (23:47 +0000)]
[FastISel][AArch64] Add missing test case for previous commit.
This adds the missing test case for the previous commit:
Allow handling of vectors during return lowering for little endian machines.
Sorry for the noise.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217847
91177308-0d34-0410-b5e6-
96231b3b80d8
Juergen Ributzka [Mon, 15 Sep 2014 23:40:10 +0000 (23:40 +0000)]
[FastISel][AArch64] Allow handling of vectors during return lowering for little endian machines.
Allow handling of vectors during return lowering at least for little endian machines.
This was restricted in r208200 to fix it for big endian machines (according to
the comment), but it also disabled it for little endian too.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217846
91177308-0d34-0410-b5e6-
96231b3b80d8
Juergen Ributzka [Mon, 15 Sep 2014 23:20:17 +0000 (23:20 +0000)]
[FastISel][AArch64] Update function and variable names to follow the coding standard. NFC.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217845
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Mon, 15 Sep 2014 22:41:25 +0000 (22:41 +0000)]
DebugInfo: Add comment describing the need to disable address pool usage in skeleton units.
Post commit review from Eric Christopher.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217842
91177308-0d34-0410-b5e6-
96231b3b80d8
Juergen Ributzka [Mon, 15 Sep 2014 22:33:11 +0000 (22:33 +0000)]
[FastISel][AArch64] Make AArch64FastISel class final. NFC.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217840
91177308-0d34-0410-b5e6-
96231b3b80d8
Juergen Ributzka [Mon, 15 Sep 2014 22:33:06 +0000 (22:33 +0000)]
[FastISel][AArch64] Lower sin/cos/pow to runtime lib calls.
Also lower sin/cos/pow to runtime lib calls.
This fixes rdar://problem/
18343468.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217839
91177308-0d34-0410-b5e6-
96231b3b80d8
Justin Bogner [Mon, 15 Sep 2014 22:23:29 +0000 (22:23 +0000)]
llvm-cov: Make debug output more consistent
This changes the debug output of the llvm-cov tool to consistently
write to stderr, and moves the highlighting output closer to where
it's relevant.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217838
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Mon, 15 Sep 2014 22:20:31 +0000 (22:20 +0000)]
Fix indenting caused by clang-format+spuriously indented access specifier in r216925
Caught in post-commit review by Justin Bogner.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217837
91177308-0d34-0410-b5e6-
96231b3b80d8
Justin Bogner [Mon, 15 Sep 2014 22:12:28 +0000 (22:12 +0000)]
llvm-cov: Fix an issue with showing regions but not counts
In r217746, though it was supposed to be NFC, I broke llvm-cov's
handling of showing regions without showing counts. This should've
shown up in the existing tests, except they were checking debug output
that was displayed regardless of what was actually output. I've moved
the relevant debug output to a more appropriate place so that the
tests catch this kind of thing.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217835
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Mon, 15 Sep 2014 22:11:07 +0000 (22:11 +0000)]
Add back tests for empty function in SPARC and PowerPC.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217834
91177308-0d34-0410-b5e6-
96231b3b80d8
Juergen Ributzka [Mon, 15 Sep 2014 22:07:49 +0000 (22:07 +0000)]
[FastISel][AArch64] Add lowering support for frem.
This lowers frem to a runtime libcall inside fast-isel.
The test case also checks the CallLoweringInfo bug that was exposed by this
change.
This fixes rdar://problem/
18342783.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217833
91177308-0d34-0410-b5e6-
96231b3b80d8
Juergen Ributzka [Mon, 15 Sep 2014 22:07:44 +0000 (22:07 +0000)]
[FastISel] Fix a bug in FastISel::CallLoweringInfo.
This fixes a bug in FastISel::CallLoweringInfo, where the number of
arguments was obtained from the argument vector before it had been
initialized.
Test case follows in another commit.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217832
91177308-0d34-0410-b5e6-
96231b3b80d8
Sanjay Patel [Mon, 15 Sep 2014 21:52:51 +0000 (21:52 +0000)]
Replace repeated null checks with an assert. NFC.
Without a vector to hold the created ops, these
functions don't have any use.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217831
91177308-0d34-0410-b5e6-
96231b3b80d8
Nick Kledzik [Mon, 15 Sep 2014 21:51:49 +0000 (21:51 +0000)]
[Support] add decodeSLEB128()
We already have routines to encode SLEB128 as well as encode/decode ULEB128.
This last function fills out the matrix. I'll need this for some llvm-objdump
work I am doing.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217830
91177308-0d34-0410-b5e6-
96231b3b80d8
Juergen Ributzka [Mon, 15 Sep 2014 21:27:56 +0000 (21:27 +0000)]
[FastISel][AArch64] Refactor selectAddSub, selectLogicalOp, and SelectShift. NFC.
Small refactor to tidy up the code a little.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217827
91177308-0d34-0410-b5e6-
96231b3b80d8
Juergen Ributzka [Mon, 15 Sep 2014 21:27:54 +0000 (21:27 +0000)]
[FastISel][AArch64] Refactor code to use isTypeSupported. NFC.
Gets rid of isLoadStoreTypeLegal and replace it with isTypeSupported.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217826
91177308-0d34-0410-b5e6-
96231b3b80d8
Jingyue Wu [Mon, 15 Sep 2014 20:48:13 +0000 (20:48 +0000)]
Remove dead code in SimplifyCFG
Summary: UsedByBranch is always true according to how BonusInst is defined.
Test Plan:
Passes check-all, and also verified
if (BonusInst && !UsedByBranch) {
...
}
is never entered during check-all.
Reviewers: resistor, nadav, jingyue
Reviewed By: jingyue
Subscribers: llvm-commits, eliben, meheff
Differential Revision: http://reviews.llvm.org/D5324
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217824
91177308-0d34-0410-b5e6-
96231b3b80d8
Juergen Ributzka [Mon, 15 Sep 2014 20:47:16 +0000 (20:47 +0000)]
[FastISel][AArch64] Improve floating-point compare support.
Add support for the last two missing fcmp condition codes: UEQ and ONE.
This fixes rdar://problem/
18341575.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217823
91177308-0d34-0410-b5e6-
96231b3b80d8
Juergen Ributzka [Mon, 15 Sep 2014 20:47:13 +0000 (20:47 +0000)]
[FastISel] Move optimizeCmpPredicate to FastISel base class. NFC.
Make the optimizeCmpPredicate function available to all targets.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217822
91177308-0d34-0410-b5e6-
96231b3b80d8
Reed Kotler [Mon, 15 Sep 2014 20:30:25 +0000 (20:30 +0000)]
Add mips32 r1 to the list of supported targets for Mips fast-isel
Summary:
Expand list of supported targets for Mips to include mips32 r1.
Previously it only include r2. More patches are coming where there is
a difference but in the current patches as pushed upstream, r1 and r2
are equivalent.
Test Plan:
simplestorefp1.ll
add new build bots at mips to test this flavor at both -O0 and -O2
Reviewers: dsanders
Reviewed By: dsanders
Differential Revision: http://reviews.llvm.org/D5306
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217821
91177308-0d34-0410-b5e6-
96231b3b80d8
David Majnemer [Mon, 15 Sep 2014 20:28:38 +0000 (20:28 +0000)]
Fix the build for MSVC, it doesn't support extended sizeof
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217820
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 15 Sep 2014 20:09:47 +0000 (20:09 +0000)]
[x86] Start fixing our emission of ADDSUBPS and ADDSUBPD instructions by
introducing a synthetic X86 ISD node representing this generic
operation.
The relevant patterns for mapping these nodes into the concrete
instructions are also added, and a gnarly bit of C++ code in the
target-specific DAG combiner is replaced with simple code emitting this
primitive.
The next step is to generically combine blends of adds and subs into
this node so that we can drop the reliance on an SSE4.1 ISD node
(BLENDI) when matching an SSE3 feature (ADDSUB).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217819
91177308-0d34-0410-b5e6-
96231b3b80d8
Sanjay Patel [Mon, 15 Sep 2014 19:47:44 +0000 (19:47 +0000)]
Replace dead links to "Hacker's Delight" with general references. NFC.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217814
91177308-0d34-0410-b5e6-
96231b3b80d8
David Majnemer [Mon, 15 Sep 2014 19:42:42 +0000 (19:42 +0000)]
MC: Add support for BigObj
Teach WinCOFFObjectWriter how to write -mbig-obj style object files;
these object files allow for more sections inside an object file.
Our support for BigObj is notably different from binutils and cl: we
implicitly upgrade object files to BigObj instead of asking the user to
compile the same file *again* but with another flag. This matches up
with how LLVM treats ELF variants.
This was tested by forcing LLVM to always emit BigObj files and running
the entire test suite. A specific test has also been added.
I've lowered the maximum number of sections in a normal COFF file,
VS "14" CTP 3 supports no more than 65279 sections. This is important
otherwise we might not switch to BigObj quickly enough, leaving us with
a COFF file that we couldn't link.
yaml2obj support is all that remains to implement.
Differential Revision: http://reviews.llvm.org/D5349
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217812
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Mon, 15 Sep 2014 19:25:55 +0000 (19:25 +0000)]
Add return that was lost somehow in my last commit.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217810
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Mon, 15 Sep 2014 19:20:52 +0000 (19:20 +0000)]
Remove ancient hack that was emulating move semantics with reference counting.
No functionality change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217808
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Mon, 15 Sep 2014 19:00:31 +0000 (19:00 +0000)]
llvm/test/CodeGen/X86/peephole-fold-movsd.ll: Relax an expression for win32.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217806
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Mon, 15 Sep 2014 18:54:41 +0000 (18:54 +0000)]
Add a triple to fix the bots.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217805
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Mon, 15 Sep 2014 18:39:24 +0000 (18:39 +0000)]
Fix memory leak in error paths in YAMLTraits by using unique_ptr
There's some other cleanup that could happen here, but this is at least
the mechanical transformation to unique_ptr.
Derived from a patch by Anton Yartsev.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217803
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Mon, 15 Sep 2014 18:32:58 +0000 (18:32 +0000)]
Fix a lot of confusion around inserting nops on empty functions.
On MachO, and MachO only, we cannot have a truly empty function since that
breaks the linker logic for atomizing the section.
When we are emitting a frame pointer, the presence of an unreachable will
create a cfi instruction pointing past the last instruction. This is perfectly
fine. The FDE information encodes the pc range it applies to. If some tool
cannot handle this, we should explicitly say which bug we are working around
and only work around it when it is actually relevant (not for ELF for example).
Given the unreachable we could omit the .cfi_def_cfa_register, but then
again, we could also omit the entire function prologue if we wanted to.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217801
91177308-0d34-0410-b5e6-
96231b3b80d8
Quentin Colombet [Mon, 15 Sep 2014 18:26:58 +0000 (18:26 +0000)]
[CodeGenPrepare][AddressingModeMatcher] Fix a think-o for the sext(zext) -> zext promotion
introduced in r217629.
We were returning the old sext instead of the new zext as the promoted instruction!
Thanks Joerg Sonnenberger for the test case.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217800
91177308-0d34-0410-b5e6-
96231b3b80d8
Akira Hatanaka [Mon, 15 Sep 2014 18:23:52 +0000 (18:23 +0000)]
[X86] Fix a bug in X86's peephole optimization.
Peephole optimization was folding MOVSDrm, which is a zero-extending double
precision floating point load, into ADDPDrr, which is a SIMD add of two packed
double precision floating point values.
(before)
%vreg21<def> = MOVSDrm <fi#0>, 1, %noreg, 0, %noreg; mem:LD8[%7](align=16)(tbaa=<badref>) VR128:%vreg21
%vreg23<def,tied1> = ADDPDrr %vreg20<tied0>, %vreg21; VR128:%vreg23,%vreg20,%vreg21
(after)
%vreg23<def,tied1> = ADDPDrm %vreg20<tied0>, <fi#0>, 1, %noreg, 0, %noreg; mem:LD8[%7](align=16)(tbaa=<badref>) VR128:%vreg23,%vreg20
X86InstrInfo::foldMemoryOperandImpl already had the logic that prevented this
from happening. However the check wasn't being conducted for loads from stack
objects. This commit factors out the logic into a new function and uses it for
checking loads from stack slots are not zero-extending loads.
rdar://problem/
18236850
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217799
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Mon, 15 Sep 2014 17:56:56 +0000 (17:56 +0000)]
CHECK-LABELize test
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217797
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Mon, 15 Sep 2014 17:56:51 +0000 (17:56 +0000)]
Use dyn_cast<> instead of isa<> and cast<>
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217796
91177308-0d34-0410-b5e6-
96231b3b80d8
Lang Hames [Mon, 15 Sep 2014 17:50:22 +0000 (17:50 +0000)]
[MCJIT] Start Stringref-izing the ExecutionEngine interface.
More methods to follow.
Using StringRef allows us the EE interface to work with more string types
without forcing construction of std::strings.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217794
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Mon, 15 Sep 2014 17:15:02 +0000 (17:15 +0000)]
R600/SI: Prefer selecting more e64 instruction forms.
Add some more tests to make sure better operand
choices are still made. Leave some cases that seem
to have no reason to ever be e64 alone.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217789
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Mon, 15 Sep 2014 17:04:54 +0000 (17:04 +0000)]
R600/SI: Make sure double vector fmul is tested
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217787
91177308-0d34-0410-b5e6-
96231b3b80d8
Ed Maste [Mon, 15 Sep 2014 16:57:12 +0000 (16:57 +0000)]
Add unit test for r217454
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217786
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Mon, 15 Sep 2014 16:48:01 +0000 (16:48 +0000)]
R600/SI: Add some mubuf testcases.
I noticed some odd looking cases where addr64 wasn't set
when storing to a pointer in an SGPR. This seems to be intentional,
and partially tested already.
The documentation seems to describe addr64 in terms of which registers
addressing modifiers come from, but I would expect to always need
addr64 when using 64-bit pointers. If no offset is applied,
it makes sense to not need to worry about doing a 64-bit add
for the final address. A small immediate offset can be applied,
so is it OK to not have addr64 set if a carry is necessary when adding
the base pointer in the resource to the offset?
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217785
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Mon, 15 Sep 2014 16:13:33 +0000 (16:13 +0000)]
Spell out the template args for compilers having issues with the injected class
name.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217780
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Mon, 15 Sep 2014 15:44:14 +0000 (15:44 +0000)]
Use IntrusiveRefCntPtr to manage the lifetime of BitCodeAbbrevs.
This doesn't change the interface or gives additional safety but removes
a ton of retain/release boilerplate.
No functionality change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217778
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Mon, 15 Sep 2014 15:41:53 +0000 (15:41 +0000)]
R600/SI: Add preliminary support for flat address space
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217777
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Mon, 15 Sep 2014 15:41:44 +0000 (15:41 +0000)]
R600/SI: Fix promote alloca pass breaking addrspacecast
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217776
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Mon, 15 Sep 2014 15:41:43 +0000 (15:41 +0000)]
R600/SI: Enable named operand table for MTBUF
There is already code trying to use it for getting
the offset.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217775
91177308-0d34-0410-b5e6-
96231b3b80d8
Toma Tabacu [Mon, 15 Sep 2014 15:33:01 +0000 (15:33 +0000)]
[mips] Use early exit in MipsAsmParser::matchCPURegisterName(). NFC.
Patch by Vasileios Kalintiris.
Differential Revision: http://reviews.llvm.org/D5270
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217774
91177308-0d34-0410-b5e6-
96231b3b80d8
Toma Tabacu [Mon, 15 Sep 2014 14:47:46 +0000 (14:47 +0000)]
[mips] Marked the DADDiu instruction aliases as MIPS III.
Patch by Vasileios Kalintiris.
Differential Revision: http://reviews.llvm.org/D5239
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217770
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 15 Sep 2014 12:40:54 +0000 (12:40 +0000)]
[x86] Begin emitting PBLENDW instructions for integer blend operations
when SSE4.1 is available.
This removes a ton of domain crossing from blend code paths that were
ending up in the floating point code path.
This is just the tip of the iceberg though. The real switch is for
integer blend lowering to more actively rely on this instruction being
available so we don't hit shufps at all any longer. =] That will come in
a follow-up patch.
Another place where we need better support is for using PBLENDVB when
doing so avoids the need to have two complementary PSHUFB masks.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217767
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 15 Sep 2014 11:40:20 +0000 (11:40 +0000)]
[x86] Add an explicit SSE3 run to this test and flesh out a bunch of
missing specific checks.
While there is a lot of redundancy here where all-but-one mode use the
same code generation, I'd rather have each variant spelled out and
checked so that readers aren't misled by an omission in the test suite.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217765
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 15 Sep 2014 11:26:25 +0000 (11:26 +0000)]
[x86] Teach the x86 DAG combiner to form UNPCKLPS and UNPCKHPS
instructions from the relevant shuffle patterns.
This is the last tweak I'm aware of to generate essentially perfect
v4f32 and v2f64 shuffles with the new vector shuffle lowering up through
SSE4.1. I'm sure I've missed some and it'd be nice to check since v4f32
is amenable to exhaustive exploration, but this is all of the tricks I'm
aware of.
With AVX there is a new trick to use the VPERMILPS instruction, that's
coming up in a subsequent patch.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217761
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 15 Sep 2014 11:15:23 +0000 (11:15 +0000)]
[x86] Teach the x86 DAG combiner to form MOVSLDUP and MOVSHDUP
instructions when it finds an appropriate pattern.
These are lovely instructions, and its a shame to not use them. =] They
are fast, and can hand loads folded into their operands, etc.
I've also plumbed the comment shuffle decoding through the various
layers so that the test cases are printed nicely.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217758
91177308-0d34-0410-b5e6-
96231b3b80d8
Frederic Riss [Mon, 15 Sep 2014 10:38:13 +0000 (10:38 +0000)]
Fix a non-virtual destructor warning introduced in r217747.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217756
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 15 Sep 2014 10:35:41 +0000 (10:35 +0000)]
[x86] Undo a flawed transform I added to form UNPCK instructions when
AVX is available, and generally tidy up things surrounding UNPCK
formation.
Originally, I was thinking that the only advantage of PSHUFD over UNPCK
instruction variants was its free copy, and otherwise we should use the
shorter encoding UNPCK instructions. This isn't right though, there is
a larger advantage of being able to fold a load into the operand of
a PSHUFD. For UNPCK, the operand *must* be in a register so it can be
the second input.
This removes the UNPCK formation in the target-specific DAG combine for
v4i32 shuffles. It also lifts the v8 and v16 cases out of the
AVX-specific check as they are potentially replacing multiple
instructions with a single instruction and so should always be valuable.
The floating point checks are simplified accordingly.
This also adjusts the formation of PSHUFD instructions to attempt to
match the shuffle mask to one which would fit an UNPCK instruction
variant. This was originally motivated to allow it to match the UNPCK
instructions in the combiner, but clearly won't now.
Eventually, we should add a MachineCombiner pass that can form UNPCK
instructions post-RA when the operand is known to be in a register and
thus there is no loss.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217755
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 15 Sep 2014 09:02:37 +0000 (09:02 +0000)]
[x86] Teach the new vector shuffle lowering to use 'punpcklwd' and
'punpckhwd' instructions when suitable rather than falling back to the
generic algorithm.
While we could canonicalize to these patterns late in the process, that
wouldn't help when the freedom to use them is only visible during
initial lowering when undef lanes are well understood. This, it turns
out, is very important for matching the shuffle patterns that are used
to lower sign extension. Fixes a small but relevant regression in
gcc-loops with the new lowering.
When I changed this I noticed that several 'pshufd' lowerings became
unpck variants. This is bad because it removes the ability to freely
copy in the same instruction. I've adjusted the widening test to handle
undef lanes correctly and now those will correctly continue to use
'pshufd' to lower. However, this caused a bunch of churn in the test
cases. No functional change, just churn.
Both of these changes are part of addressing a general weakness in the
new lowering -- it doesn't sufficiently leverage undef lanes. I've at
least a couple of patches that will help there at least in an academic
sense.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217752
91177308-0d34-0410-b5e6-
96231b3b80d8
Frederic Riss [Mon, 15 Sep 2014 08:23:07 +0000 (08:23 +0000)]
Fix ambiguous typedef introduced in r217747.
Use fully qualified name inside a typedef from llvm::iterator_range<...> to
iterator_range. This is reported (rightly I think) by GCC as an
ambiguous name redefinition. Hope this fixes the buildbots.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217751
91177308-0d34-0410-b5e6-
96231b3b80d8
David Majnemer [Mon, 15 Sep 2014 08:15:28 +0000 (08:15 +0000)]
InstSimplify: Simplify trivial and/or of icmps
Some ICmpInsts when anded/ored with another ICmpInst trivially reduces
to true or false depending on whether or not all integers or no integers
satisfy the intersected/unioned range.
This sort of trivial looking code can come about when InstCombine
performs a range reduction-type operation on sdiv and the like.
This fixes PR20916.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217750
91177308-0d34-0410-b5e6-
96231b3b80d8
Frederic Riss [Mon, 15 Sep 2014 07:50:42 +0000 (07:50 +0000)]
Fix DebugInfo replaceAllUsesWith.
Summary:
replaceAllUsesWith had been modified to allow a DbgNode value to be
replaced by itself. In that case a new node is created by copying the
current DbgNode and the copy is used as replacement value.
When that copying happens, the value stored in this->DbgNode at the end
of RAUW would be a reference to the Node that has just been deleted.
This doesn't produce any bug right now, because the DI node on which we
call RAUW won't be used again.
Reviewers: dblaikie, echristo, aprantl
Subscribers: llvm-commits
Differential Revision: http://reviews.llvm.org/D5326
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217749
91177308-0d34-0410-b5e6-
96231b3b80d8
Frederic Riss [Mon, 15 Sep 2014 07:50:36 +0000 (07:50 +0000)]
Move replaceAllUsesWith() from DIType to DIDescriptor.
RAUW was only used on DIType to merge declarations and full definitions
of types. In order to support the same functionality for functions and
global variables, move the function up type DI type hierarchy to the
common parent of DIType, DISubprogram and DIVariable which is
DIDescriptor.
This functionality will be exercized when we add the code to emit
imported declarations for forward declared function/variables.
Reviewers: echristo, dblaikie, aprantl
Subscribers: llvm-commits
Differential Revision: http://reviews.llvm.org/D5325
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217748
91177308-0d34-0410-b5e6-
96231b3b80d8
Frederic Riss [Mon, 15 Sep 2014 07:50:27 +0000 (07:50 +0000)]
Introduce the DWARFUnitSection abstraction.
A DWARFUnitSection is the collection of Units that have been extracted from
the same debug section.
By embeding a reference to their DWARFUnitSection in each unit, the DIEs
will be able to resolve inter-unit references by interrogating their Unit's
DWARFUnitSection.
This is a minimal patch where the DWARFUnitSection is-a SmallVector of Units,
thus exposing exactly the same interface as before. Followup-up patches might
change from inheritance to composition in order to expose only the wanted
DWARFUnitSection abstraction.
Differential Revision: http://reviews.llvm.org/D5310
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217747
91177308-0d34-0410-b5e6-
96231b3b80d8
Justin Bogner [Mon, 15 Sep 2014 03:41:04 +0000 (03:41 +0000)]
llvm-cov: Clean up some redundancy in the view API (NFC)
This removes the need to pass a starting and ending line when creating
a SourceCoverageView, since these are easy to determine.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217746
91177308-0d34-0410-b5e6-
96231b3b80d8
Justin Bogner [Mon, 15 Sep 2014 03:41:01 +0000 (03:41 +0000)]
llvm-cov: Simplify CounterMappingRegion, pushing logic to its user
A single function in SourceCoverageDataManager was the only user of
some of the comparisons in CounterMappingRegion, and at this point we
know that only one file is relevant. This lets us use slightly simpler
logic directly in the client.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217745
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Sun, 14 Sep 2014 23:43:33 +0000 (23:43 +0000)]
[x86] Teach the new vector shuffle lowering to use BLENDPS and BLENDPD.
These are super simple. They even take precedence over crazy
instructions like INSERTPS because they have very high throughput on
modern x86 chips.
I still have to teach the integer shuffle variants about this to avoid
so many domain crossings. However, due to the particular instructions
available, that's a touch more complex and so a separate patch.
Also, the backend doesn't seem to realize it can commute blend
instructions by negating the mask. That would help remove a number of
copies here. Suggestions on how to do this welcome, it's an area I'm
less familiar with.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217744
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Sun, 14 Sep 2014 23:39:01 +0000 (23:39 +0000)]
llvm/test/CodeGen/X86/vec_shuffle-38.ll: Add explicit -mtriple=x86_64-unknown to avoid incompatibility of win32.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217742
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Sun, 14 Sep 2014 23:28:12 +0000 (23:28 +0000)]
[x86] Add an SSE41 mode to this test. Nothing interesting here, its the
same as SSE3.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217741
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Sun, 14 Sep 2014 23:19:37 +0000 (23:19 +0000)]
[x86] Switch this test to use an ALL prefix with special SSE2 and SSE3
variants where significant.
This will make it more obvious what is happening when we start using
blends in SSE41.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217740
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Sun, 14 Sep 2014 23:15:52 +0000 (23:15 +0000)]
[x86] Add some test cases where we should emit blendpd in SSE4.1. No
actual change yet though.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217739
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Sun, 14 Sep 2014 22:41:37 +0000 (22:41 +0000)]
[x86] Teach the vector combiner that picks a canonical shuffle from to
support transforming the forms from the new vector shuffle lowering to
use 'movddup' when appropriate.
A bunch of the cases where we actually form 'movddup' don't actually
show up in the test results because something even later than DAG
legalization maps them back to 'unpcklpd'. If this shows back up as
a performance problem, I'll probably chase it down, but it is at least
an encoded size loss. =/
To make this work, also always do this canonicalizing step for floating
point vectors where the baseline shuffle instructions don't provide any
free copies of their inputs. This also causes us to canonicalize
unpck[hl]pd into mov{hl,lh}ps (resp.) which is a nice encoding space
win.
There is one test which is "regressed" by this: extractelement-load.
There, the test case where the optimization it is testing *fails*, the
exact instruction pattern which results is slightly different. This
should probably be fixed by having the appropriate extract formed
earlier in the DAG, but that would defeat the purpose of the test.... If
this test case is critically important for anyone, please let me know
and I'll try to work on it. The prior behavior was actually contrary to
the comment in the test case and seems likely to have been an accident.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217738
91177308-0d34-0410-b5e6-
96231b3b80d8
Yaron Keren [Sun, 14 Sep 2014 20:36:28 +0000 (20:36 +0000)]
In DwarfEHPrepare, after all passes are run, RewindFunction may be a dangling
pointer to a dead function. To make sure it's valid, doFinalization nullptrs
RewindFunction just like the constructor and so it will be found on next run.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217737
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Sun, 14 Sep 2014 18:32:05 +0000 (18:32 +0000)]
R600/SI: Fix broken check lines
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217736
91177308-0d34-0410-b5e6-
96231b3b80d8
James Molloy [Sun, 14 Sep 2014 18:24:26 +0000 (18:24 +0000)]
[A57FPLoadBalancing] Modify r217689 - actually we do need to check defs
... Just make sure we check uses first so we see the kill first. It
turns out ignoring defs gives some pretty nasty runtime failures.
I'm certain this is the fix but I'm still reducing a testcase.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217735
91177308-0d34-0410-b5e6-
96231b3b80d8
Juergen Ributzka [Sat, 13 Sep 2014 23:46:28 +0000 (23:46 +0000)]
[FastISel][AArch64] Add support for non-native types for logical ops.
Extend the logical ops selection to also support non-native types such as i1,
i8, and i16.
Fixes rdar://problem/
18330589.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217732
91177308-0d34-0410-b5e6-
96231b3b80d8
Nick Lewycky [Sat, 13 Sep 2014 21:46:00 +0000 (21:46 +0000)]
Add control of function merging to the PMBuilder.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217731
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Sat, 13 Sep 2014 19:58:27 +0000 (19:58 +0000)]
Fix typo
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217730
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Sat, 13 Sep 2014 12:38:49 +0000 (12:38 +0000)]
Simplify code. No functionality change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217726
91177308-0d34-0410-b5e6-
96231b3b80d8
Chad Rosier [Sat, 13 Sep 2014 03:23:23 +0000 (03:23 +0000)]
[AArch64] Update test case to pass with post-RA MI scheduler.
Check that the post RA scheduler is being skipped, regardless of
whether it's the top-down list latency scheduler or the post-RA
MI scheduler.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217725
91177308-0d34-0410-b5e6-
96231b3b80d8
Nick Kledzik [Sat, 13 Sep 2014 00:18:40 +0000 (00:18 +0000)]
[llvm-objdump] Use PRIX64 with format()
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217724
91177308-0d34-0410-b5e6-
96231b3b80d8
Nick Kledzik [Fri, 12 Sep 2014 22:46:01 +0000 (22:46 +0000)]
Stop suppress error messages in test case to see why one buildbot is failing
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217715
91177308-0d34-0410-b5e6-
96231b3b80d8
Chad Rosier [Fri, 12 Sep 2014 22:17:28 +0000 (22:17 +0000)]
[AArch64] Don't enable the post-RA MI scheduler at OptNone.
Hopefully, this will appease the bots.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217712
91177308-0d34-0410-b5e6-
96231b3b80d8
Owen Anderson [Fri, 12 Sep 2014 22:16:11 +0000 (22:16 +0000)]
Allow targets to custom legalize vector insertion and extraction.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217711
91177308-0d34-0410-b5e6-
96231b3b80d8
Nick Kledzik [Fri, 12 Sep 2014 21:34:15 +0000 (21:34 +0000)]
[llvm-objdump] support -rebase option for mach-o to dump rebasing info
Similar to my previous -exports-trie option, the -rebase option dumps info from
the LC_DYLD_INFO load command. The rebasing info is a list of the the locations
that dyld needs to adjust if a mach-o image is not loaded at its preferred
address. Since ASLR is now the default, images almost never load at their
preferred address, and thus need to be rebased by dyld.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217709
91177308-0d34-0410-b5e6-
96231b3b80d8
Justin Bogner [Fri, 12 Sep 2014 21:22:55 +0000 (21:22 +0000)]
llvm-profdata: Avoid undefined behaviour when reading raw profiles
The raw profiles that are generated in compiler-rt always add padding
so that each profile is aligned, so we can simply treat files that
don't have this property as malformed.
Caught by Alexey's new ubsan bot. Thanks!
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217708
91177308-0d34-0410-b5e6-
96231b3b80d8
Owen Anderson [Fri, 12 Sep 2014 21:17:55 +0000 (21:17 +0000)]
Remove an unnecessary restriction. MIsNeedChainEdge() should be checked even when scheduler AliasAnalysis is not
enabled. A good chunk of the MIsNeedChainEdge() is logic that is valid and should be applied even for targets
that are not using for alias analysis.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217706
91177308-0d34-0410-b5e6-
96231b3b80d8
Yaron Keren [Fri, 12 Sep 2014 20:29:17 +0000 (20:29 +0000)]
The MCAssembler.h include isn't used.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217705
91177308-0d34-0410-b5e6-
96231b3b80d8
Ehsan Akhgari [Fri, 12 Sep 2014 19:42:53 +0000 (19:42 +0000)]
Add an overload of getLastArgNoClaim taking two OptSpecifiers.
Summary: This will be used in clang.
Test Plan: Will be tested on the clang side.
Reviewers: hansw
Subscribers: llvm-commits
Differential Revision: http://reviews.llvm.org/D5337
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217702
91177308-0d34-0410-b5e6-
96231b3b80d8
Chad Rosier [Fri, 12 Sep 2014 17:55:16 +0000 (17:55 +0000)]
FileCheckize. NFC.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217698
91177308-0d34-0410-b5e6-
96231b3b80d8
JF Bastien [Fri, 12 Sep 2014 17:54:17 +0000 (17:54 +0000)]
Add support for le64.
Summary:
le64 is a generic little-endian 64-bit processor, mimicking le32.
Depends on D5318.
Test Plan: make check-all
Reviewers: dschuff
Subscribers: llvm-commits
Differential Revision: http://reviews.llvm.org/D5319
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217697
91177308-0d34-0410-b5e6-
96231b3b80d8
Chad Rosier [Fri, 12 Sep 2014 17:40:39 +0000 (17:40 +0000)]
[AArch64] Enable post-RA MI scheduler.
Phabricator Revision: http://reviews.llvm.org/D5278
Patch by Sanjin Sijaric!
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217693
91177308-0d34-0410-b5e6-
96231b3b80d8
James Molloy [Fri, 12 Sep 2014 16:55:32 +0000 (16:55 +0000)]
[A57FPLoadBalancing] Remove support for vector types
Vector MUL/MLAs have tied operands, which gives us extra constraints
that we currently can't handle. Instead of silently doing the wrong
thing, remove support to be readded later properly.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217690
91177308-0d34-0410-b5e6-
96231b3b80d8
James Molloy [Fri, 12 Sep 2014 16:55:26 +0000 (16:55 +0000)]
[A57FPLoadBalancing] Ignore <def>s when checking if a chain may be killed.
Defs are seen before uses, so a def without the kill flag doesn't necessarily
mean that the register is not killed on that instruction. It may be killed
in a later use operand.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217689
91177308-0d34-0410-b5e6-
96231b3b80d8
Jordan Rose [Fri, 12 Sep 2014 16:46:05 +0000 (16:46 +0000)]
[lit] Parse all strings as UTF-8 rather than ASCII.
As far as I can tell UTF-8 has been supported since the beginning of Python's
codec support, and it's the de facto standard for text these days, at least
for primarily-English text. This allows us to put Unicode into lit RUN lines.
rdar://problem/
18311663
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217688
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Fri, 12 Sep 2014 15:12:32 +0000 (15:12 +0000)]
Move sys::fs::AccessMode out of @brief in the function. [-Wdocumentation]
FIXME: Annotate sys::fs::AccessMode.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217685
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Fri, 12 Sep 2014 15:12:21 +0000 (15:12 +0000)]
sys::fs::access(): Fix @param [-Wdocumentation]
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217684
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Fri, 12 Sep 2014 15:10:56 +0000 (15:10 +0000)]
llvm/test/CodeGen/X86/vec_ctbits.ll: Add explicit -mtriple=x86_64-unknown. It was incompatible to Win32 x64.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217683
91177308-0d34-0410-b5e6-
96231b3b80d8
James Molloy [Fri, 12 Sep 2014 14:35:17 +0000 (14:35 +0000)]
[A57LoadBalancing] unique_ptr-ify.
Thanks to David Blakie for the in-depth review!
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217682
91177308-0d34-0410-b5e6-
96231b3b80d8
Zoran Jovanovic [Fri, 12 Sep 2014 14:29:54 +0000 (14:29 +0000)]
[mips][microMIPS] Implement JRADDIUSP instruction
Differential Revision: http://reviews.llvm.org/D5046
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217681
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Schmidt [Fri, 12 Sep 2014 14:26:36 +0000 (14:26 +0000)]
Address comments on r217622
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217680
91177308-0d34-0410-b5e6-
96231b3b80d8
Zoran Jovanovic [Fri, 12 Sep 2014 13:51:58 +0000 (13:51 +0000)]
[mips][microMIPS] Implement BGEZALS and BLTZALS instructions
Differential Revision: http://reviews.llvm.org/D5004
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217678
91177308-0d34-0410-b5e6-
96231b3b80d8
Zoran Jovanovic [Fri, 12 Sep 2014 13:43:41 +0000 (13:43 +0000)]
[mips][microMIPS] Implement JALS and JALRS instructions.
Differential Revision: http://reviews.llvm.org/D5003
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217676
91177308-0d34-0410-b5e6-
96231b3b80d8
Zoran Jovanovic [Fri, 12 Sep 2014 13:33:33 +0000 (13:33 +0000)]
[mips][microMIPS] Implement TLBP, TLBR, TLBWI and TLBWR instructions
Differential Revision: http://reviews.llvm.org/D5211
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217675
91177308-0d34-0410-b5e6-
96231b3b80d8