Staging: rtl8192u: r819xU_firmware_img.c Fixed checkpatch.pl ERRORs

Fixed a lot of errors of the type "ERROR: space required after that ',' (ctx:VxV)"

Added tabs at the beginning of line.

Signed-off-by: Chaitanya Hazarey <c@24.io>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: rtl8188eu: use time_before/time_after and change type of ips_deny_time

To be future-proof and for better readability the time comparisons are
modified to use time_before/_after() instead of plain, error-prone math.
To suppress compiler warnings the type of ips_deny_time was changed.

Signed-off-by: Manuel Schölling <manuel.schoelling@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: rtl8821ae: add static for local symbols in rtl_btc.c

This commit fixes the sparse warning:

    "warning: symbol 'X' was not declared. Should it be static?"

Where the X is one of the following

    rtl_btc_operation

Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: rtl8821ae: deal with unused functions in halbtcoutsrc.c

This commit fixes the compiler -Wunused-function warning. Several
functions had to be removed.

Removed symbols

    halbtc_is_hw_mailbox_exist
    halbtc_set_macreg
    halbtc_get_macreg
    halbtc_under_ips

Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: rtl8821ae: add static for local symbols in halbtcoutsrc.c

This commit fixes the sparse warning:

    "warning: symbol 'X' was not declared. Should it be static?"

Where the X is one of the following:

    bt_profile_string
    bt_spec_string
    bt_link_role_string
    h2c_state_string
    io_state_string
    btc_dbg_buf
    halbtc_is_bt_coexist_available
    halbtc_is_wifi_busy
    halbtc_dbg_init
    halbtc_is_hw_mailbox_exist
    halbtc_is_bt40
    halbtc_legacy
    halbtc_get_wifi_bw
    halbtc_get_wifi_central_chnl
    halbtc_leave_lps
    halbtc_enter_lps
    halbtc_normal_lps
    halbtc_leave_low_power
    halbtc_nomal_low_power
    halbtc_disable_low_power
    halbtc_aggregation_check
    halbtc_get_bt_patch_version
    halbtc_get_wifi_rssi
    halbtc_get
    halbtc_set
    halbtc_display_coex_statistics
    halbtc_display_bt_link_info
    halbtc_display_bt_fw_info
    halbtc_display_fw_pwr_mode_cmd
    halbtc_read_1byte
    halbtc_read_2byte
    halbtc_read_4byte
    halbtc_write_1byte
    halbtc_bitmask_write_1byte
    halbtc_write_2byte
    halbtc_write_4byte
    halbtc_set_macreg
    halbtc_get_macreg
    halbtc_set_bbreg
    halbtc_get_bbreg
    halbtc_set_rfreg
    halbtc_get_rfreg
    halbtc_fill_h2c_cmd
    halbtc_display_dbg_msg
    halbtc_under_ips

Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: rtl8821ae: deal with unused functions in halbtc8723b2ant.c

This commit fixes the compiler -Wunused-function warning. It was enough
to put #define around them to supress this warning. One was a special
case because it's usage was commented-out therefore, as I did not want
to remove it completely, I disabled it with #if 0

Conditionally compiled symbols

    halbtc8723b2ant_monitor_bt_enable_disable
    halbtc8723b2ant_set_bt_auto_report
    halbtc8723b2ant_bt_auto_report

Disabled symbols

    halbtc8723b2ant_adc_backoff
    halbtc8723b2ant_set_adc_backoff

Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: rtl8821ae: add static for local symbols in halbtc8723b2ant.c

This commit fixes the sparse warning:

    "warning: symbol 'X' was not declared. Should it be static?"

Where the X is one of the following:

    glbt_info_src_8723b_2ant
    glcoex_ver_date_8723b_2ant
    glcoex_ver_8723b_2ant
    halbtc8723b2ant_bt_rssi_state
    halbtc8723b2ant_wifi_rssi_state
    halbtc8723b2ant_monitor_bt_enable_disable
    halbtc8723b2ant_monitor_bt_ctr
    halbtc8723b2ant_query_bt_info
    halbtc8723b2ant_is_wifi_status_changed
    halbtc8723b2ant_update_bt_link_info
    halbtc8723b2ant_action_algorithm
    halbtc8723b2ant_need_to_dec_bt_pwr
    halbtc8723b2ant_set_fw_dac_swing_level
    halbtc8723b2ant_set_fw_dec_bt_pwr
    halbtc8723b2ant_dec_bt_pwr
    halbtc8723b2ant_set_bt_auto_report
    halbtc8723b2ant_bt_auto_report
    halbtc8723b2ant_fw_dac_swing_lvl
    halbtc8723b2ant_set_sw_rf_rx_lpf_corner
    halbtc8723b2ant_rf_shrink
    halbtc8723b2ant_set_sw_penalty_txrate_adaptive
    halbtc8723b2ant_low_penalty_ra
    halbtc8723b2ant_set_dac_swing_reg
    halbtc8723b2ant_set_sw_fulltime_dac_swing
    halbtc8723b2ant_dac_swing
    halbtc8723b2ant_set_adc_backoff
    halbtc8723b2ant_adc_backoff
    halbtc8723b2ant_set_agc_table
    halbtc8723b2ant_agc_table
    halbtc8723b2ant_set_coex_table
    halbtc8723b2ant_coex_table
    halbtc8723b2ant_coex_table_with_type
    halbtc8723b2ant_set_fw_ignore_wlan_act
    halbtc8723b2ant_ignore_wlan_act
    halbtc8723b2ant_set_fw_ps_tdma
    halbtc8723b2ant_sw_mechanism1
    halbtc8723b2ant_sw_mechanism2
    halbtc8723b2ant_set_ant_path
    halbtc8723b2ant_ps_tdma
    halbtc8723b2ant_coex_alloff
    halbtc8723b2ant_init_coex_dm
    halbtc8723b2ant_action_bt_inquiry
    halbtc8723b2ant_is_common_action
    halbtc8723b2ant_tdma_duration_adjust
    halbtc8723b2ant_action_sco
    halbtc8723b2ant_action_hid
    halbtc8723b2ant_action_a2dp
    halbtc8723b2ant_action_a2dp_pan_hs
    halbtc8723b2ant_action_pan_edr
    halbtc8723b2ant_action_pan_hs
    halbtc8723b2ant_action_pan_edr_a2dp
    halbtc8723b2ant_action_pan_edr_hid
    halbtc8723b2ant_action_hid_a2dp_pan_edr
    halbtc8723b2ant_action_hid_a2dp
    halbtc8723b2ant_run_coexist_mechanism
    halbtc8723b2ant_wifioff_hwcfg

Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: rtl8821ae: deal with unused functions in halbtc8723b1ant.c

This commit fixes the compiler -Wunused-function warning. Most of the
unused functions were removed however for a few of them it was enough
to put #define around them.

Removed symbols:

    halbtc8723b1ant_rf_shrink
    halbtc8723b1ant_dac_swing
    halbtc8723b1ant_adc_backoff
    halbtc8723b1ant_agc_table
    halbtc8723b1ant_coex_alloff
    halbtc8723b1ant_ps_tdma_type_by_wifi_rssi
    halbtc8723b1ant_set_sw_rf_rx_lpf_corner
    halbtc8723b1ant_set_sw_full_time_dac_swing
    halbtc8723b1ant_set_adc_backoff
    halbtc8723b1ant_set_agc_table
    halbtc8723b1ant_set_dac_swing_reg

Conditionally compiled symbols:

    halbtc8723b1ant_bt_auto_report
    halbtc8723b1ant_set_bt_auto_report
    halbtc8723b1ant_action_wifi_only
    halbtc8723b1ant_monitor_bt_enable_disable

Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: rtl8821ae: add static for local symbols in halbtc8723b1ant.c

This commit fixes the sparse warning:

    "warning: symbol 'X' was not declared. Should it be static?"

Where the X is one of the following:

    glbt_info_src_8723b_2ant
    glcoex_ver_date_8723b_2ant
    glcoex_ver_8723b_2ant
    halbtc8723b2ant_bt_rssi_state
    halbtc8723b2ant_wifi_rssi_state
    halbtc8723b2ant_monitor_bt_enable_disable
    halbtc8723b2ant_monitor_bt_ctr
    halbtc8723b2ant_query_bt_info
    halbtc8723b2ant_is_wifi_status_changed
    halbtc8723b2ant_update_bt_link_info
    halbtc8723b2ant_action_algorithm
    halbtc8723b2ant_need_to_dec_bt_pwr
    halbtc8723b2ant_set_fw_dac_swing_level
    halbtc8723b2ant_set_fw_dec_bt_pwr
    halbtc8723b2ant_dec_bt_pwr
    halbtc8723b2ant_set_bt_auto_report
    halbtc8723b2ant_bt_auto_report
    halbtc8723b2ant_fw_dac_swing_lvl
    halbtc8723b2ant_set_sw_rf_rx_lpf_corner
    halbtc8723b2ant_rf_shrink
    halbtc8723b2ant_set_sw_penalty_txrate_adaptive
    halbtc8723b2ant_low_penalty_ra
    halbtc8723b2ant_set_dac_swing_reg
    halbtc8723b2ant_set_sw_fulltime_dac_swing
    halbtc8723b2ant_dac_swing
    halbtc8723b2ant_set_adc_backoff
    halbtc8723b2ant_adc_backoff
    halbtc8723b2ant_set_agc_table
    halbtc8723b2ant_agc_table
    halbtc8723b2ant_set_coex_table
    halbtc8723b2ant_coex_table
    halbtc8723b2ant_coex_table_with_type
    halbtc8723b2ant_set_fw_ignore_wlan_act
    halbtc8723b2ant_ignore_wlan_act
    halbtc8723b2ant_set_fw_ps_tdma
    halbtc8723b2ant_sw_mechanism1
    halbtc8723b2ant_sw_mechanism2
    halbtc8723b2ant_set_ant_path
    halbtc8723b2ant_ps_tdma
    halbtc8723b2ant_coex_alloff
    halbtc8723b2ant_init_coex_dm
    halbtc8723b2ant_action_bt_inquiry
    halbtc8723b2ant_is_common_action
    halbtc8723b2ant_tdma_duration_adjust
    halbtc8723b2ant_action_sco
    halbtc8723b2ant_action_hid
    halbtc8723b2ant_action_a2dp
    halbtc8723b2ant_action_a2dp_pan_hs
    halbtc8723b2ant_action_pan_edr
    halbtc8723b2ant_action_pan_hs
    halbtc8723b2ant_action_pan_edr_a2dp
    halbtc8723b2ant_action_pan_edr_hid
    halbtc8723b2ant_action_hid_a2dp_pan_edr
    halbtc8723b2ant_action_hid_a2dp
    halbtc8723b2ant_run_coexist_mechanism
    halbtc8723b2ant_wifioff_hwcfg

Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: android: describe use of memory barrier on sync.c

Added comments describing the purpose of using write memory
barrier in the context of sync_timeline_destory.

Signed-off-by: Niv Yehezkel <executerx@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Staging: dgap: Fixed iomem accesses in dgap.c

I changed dereferences from iomem into the adequate ioread function.

Signed-off-by: Pascal COMBES <pascom@orange.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: Convert __FUNCTION__ to __func__

Use the normal mechanism for emitting a function name.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: rtl8712: remove _malloc()

This patch removes all usage of _malloc() and the function itself. Most
uses are straightforward replacements by kmalloc(..., GFP_ATOMIC),
because this was the definition of _malloc(). In a few places it
was possible to use kzalloc() or memdup_user.

A further improvement would be to replace GFP_ATOMIC with GFP_KERNEL
where possible.

Verified by compilation only.

Initial replacement done by running a Coccinelle script along the lines
of:

@@
type T;
expression E;
identifier V;
@@
- V = (T) _malloc(E);
+ V = kmalloc(E, GFP_ATOMIC);

@@
expression E, E1;
@@
- E1 = _malloc(E);
+ E1 = kmalloc(E, GFP_ATOMIC);

Signed-off-by: Vitaly Osipov <vitaly.osipov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: slicoss: clean up use of dev_err

First, don't print pci device information or driver prefixes, this
is already printed by dev_err. Next, don't report error messages
via dev_err when the failing function already reports all errors
via dev_err.

Signed-off-by: David Matlack <matlackdavid@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: slicoss: remove private netdev list

Remove the private linked list of netdev structs. This list isn't
being used anyway.

This patch has no noticable effect.

Signed-off-by: David Matlack <matlackdavid@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: lustre: Fixed warnings about using 0 as NULL ptr

Fixed a bunch of warnings pointed out by sparse about using 0 to
represent a NULL pointer.

Signed-off-by: Greg DeAngelis <gdeangel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging/mt29f_spinand: Terminate of match table

Failure to terminate this match table can lead to boot failures
depending on where the compiler places the match table.

Cc: Kamlakant Patel <kamlakant.patel@broadcom.com>
Cc: Mona Anonuevo <manonuevo@micron.com>
Cc: linux-mtd@lists.infradead.org
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: panel: (coding style) Multiple assignments

Style-only modifications to comply with checkpatch.pl --strict --file.
. Breaks down compound assignments.

Signed-off-by: Dominique van den Broeck <domdevlin@free.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: vt6656: CARDvCalculateOFDMRParameter fix indentation rsv_time

In patch
staging: vt6656 camel case clean up CARDvCalculateOFDMRParameter
rsv_time is indented incorrectly.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: vt6656: camel case and clean up CARDvSetBSSMode

camel case changes
pDevice -> priv

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: vt6656: camel case clean up CARDbRadioPowerOn

camel case changes
pDevice -> priv
bResult -> ret

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: vt6656: camel case clean up CARDbRadioPowerOff

camel case changes
pDevice -> priv
bResult -> ret

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: vt6656: camel case clean up CARDvUpdateNextTBTT

camel case changes
pDevice -> priv
qwTSF -> tsf
wBeaconInterval -> beacon_interval
pbyData -> data

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: vt6656: camel case and clean up CARDvSetFirstNextTBTT

camel case changes
pDevice -> priv
wBeaconInterval -> beacon_interval
qwNextTBTT -> next_tbtt
pbyData -> data

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: vt6656: CARDqGetNextTBTT remove camel case

qwTSF -> tsf
wBeaconInterval -> beacon_interval
uBeaconInterval -> beacon_int

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: vt6656: CARDbClearCurrentTSF remove camel case

pDevice -> priv

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: vt6656: CARDbGetCurrentTSF remove camel case

pDevice -> priv
pqwCurrTSF -> current_tsf

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: vt6656: camel case and clean up CARDvAdjustTSF

camel case changes
pDevice -> priv
byRxRate -> rx_rate
qwBSSTimestamp -> time_stamp
qwLocalTSF -> local_tsf
qwTSFOffset -> tsf_offset
pbyData -> data

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: vt6656: CARDqGetTSFOffset remove camel case

camel case changes
byRxRate -> rx_rate
qwTSF1 -> tsf1
qwTSF2 -> tsf2
qwTSFOffset -> tsf_offset
wRxBcnTSFOffst -> rx_bcn_offset

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: vt6656: camel case and cleanup CARDbyGetPktType

camel case changes
pDevice -> priv

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: vt6656: camel case clean up CARDbIsOFDMinBasicRate

camel case change
pDevice -> priv

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: vt6656: Convert remaining locks to spin_lock_irqsave.

Convert all remaining locks to spin_lock_irqsave and
spin_unlock_irqrestore

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Merge tag 'iio-for-3.16c' of git://git./linux/kernel/git/jic23/iio into staging-next

Jonathan writes:

Third round of new stuff for IIO in the 3.16 cycle.

This (rather late) set consists only of fixes to patches earlier in the
cycle or minor fixes for other problems (such as randconfig build issues
picked up by Arnd).  I've included the general minor fixes here as it is
very late in the current cycle and they can all wait for the merge window.

* Recent change to hid-sensors introduced a possible infinite loop due to a
  typo. In the same series, a report interval unit read was added but in the
  case where the hardware doesn't support it a value of 0 would lead to some
  nasty issues.  The patch sets it to the specified default of msecs.
* Anon inodes were used by IIO without being explicitly selected.  This has
  been true for a long time so it clearly only effects rather unusual
  configurations (rand configs)
* at91 requires the input subsytem but this wasn't explicity in the Kconfig.
* A couple of parts supported by the max1363 driver were using the wrong
  iio_chan_spec arrays and hence would missreport their bit depths.  This has
  been there a long time and was never right so isn't a regression.

fix format string missmatch in staging/iio/Documentation/iio_utils.h

spotted by cppcheck

Signed-off-by: Toralf Förster <toralf.foerster@gmx.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>

iio:adc:max1363 incorrect resolutions for max11604, max11605, max11610 and max11611.

Cc: Stable@vger.kernel.org>
Reported-by: Erik Habbinga <Erik.Habbinga@schneider-electric.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Acked-by: Hartmut Knaack <knaack.h@gmx.de>

Revert "staging: r8188eu: Add support for Dlink DWA-121 802.11n Wireless N 150 Pico Adapter"

This reverts commit 599a2c02a784934b9bf0725920c1bc235b9b28ce.

Larry writes:
This patch should be dropped. The 0x2001:0x3308 device is an
RTL8188CU, not RTL8188EU. As a result, it is already in the USB
device tables.

Cc: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Kim Nylund <kim@pratsam.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Staging: bcm: Shortened prototype for GetNextTargetBufferLocation()

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Staging: bcm: Shortened lines in SearchClsid()

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Staging: bcm: Shortened lines in deleteSFBySfid()

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Staging: bcm: Shortened lines in CopyIpAddrToClassifier()

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Staging: bcm: Replaced member accessing by variable

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Staging: bcm: Shortened lines and replaced member accessing in CopyIpAddrToClassifier()

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Staging: bcm: Shortened lines in CopyClassifierRuleToSF()

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Staging: bcm: Replaced member accessing with variable

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Staging: bcm: Shortened lines in DeleteClassifierRuleFromSF()

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Staging: bcm: Shortened line in DeleteAllClassifiersForSF()

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Staging: bcm: Shortened lines in CopyToAdapter()

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Staging: bcm: Replaced struct member accessing with variable

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Staging: bcm: Outsourced PHS rule applying

This patch outsources the big PHS-rule-applying code chunk into a
function.

It also replaces member accessing by using variables.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Staging: bcm: Shortened some lines in DumpCmControlPacker()

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Staging: bcm: Replaced long member-accessing

This patch replaces long object->member.member foo by variable useage.
Increases the reading experience a lot by introducing only one variable
(as it decreases the whoa-wall-of-text experience).

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Staging: bcm: Shortened lines in RestoreSFParam()

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Staging: bcm: Shortened lines in StoreSFParam()

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Staging: bcm: Shortened lines in StoreCmControlResponseMessage()

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Staging: bcm: Shortened lines in RestoreCmControlResponseMessage()

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Staging: bcm: Shortened lines in SetupTargetDsxBuffers()

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Staging: bcm: Shortenend lines in GetNextTargetBufferLocation()

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Staging: bcm: Shortened line

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Staging: bcm: Simplified by using variables

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Staging: bcm: Outsourced restoring of endianess for ip adresses

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Staging: bcm: Shortened lines in get_dsx_sf_data_to_application()

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Staging: bcm: Shortened lines in OverrideServiceFlowParams()

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Staging: bcm: Shortened code by using variable

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: gdm72xx: code cleanup

Checkpatch.pl cleanup

Thanks again to Greg KH and Dan Carpenter for the patience :)

Signed-off-by: Davide Gianforte <davide@gengisdave.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: ion: WARN when the handle kmap_cnt is going to wrap around

There are certain client bugs (double unmap, for example) that can cause
the handle->kmap_cnt (an unsigned int) to wrap around from zero. This
causes problems when the handle is destroyed because we have:

        while (handle->kmap_cnt)
                ion_handle_kmap_put(handle);

which takes a long time to complete when kmap_cnt starts at ~0 and can
result in a watchdog timeout.

WARN and bail when kmap_cnt is about to wrap around from zero.

Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>
Acked-by: Colin Cross <ccross@android.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging/olpc_dcon: fix checkpatch warnings

WARNING: Missing a blank line after declarations

Signed-off-by: Nicolas Joseph <nicolas.joseph@homecomputing.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: vt6656: camel case cleanup CARDbAddBasicRate

camel case changes
pDevice -> priv
wRateIdx -> rate_idx

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: vt6656: camel case clean up CARDvUpdateBasicTopRate

Camel case changes
pDevice -> priv
byTopOFDM -> top_ofdm
byTopCCK -> top_cck

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: vt6656: camel case cleanup vUpdateIFS

camel case changes
pDevice -> priv
byMaxMin -> max_min
byData -> data
pItemRates -> item_rates

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: vt6656: camel case cleanup CARDvSetRSPINF

camel case changes
pDevice -> priv
byBBType -> bb_type

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: vt6656: camel case clean up CARDvCalculateOFDMRParameter

Camel case changes
wRate -> rate
byBBType -> bb_type
pbyTxRate -> tx_rate
pbyRsvTime -> rsv_time

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: vt6656: camel case clean up MACvWriteBeaconInterval

camel case changes
pDevice -> priv
wInterval -> interval
pbyData -> data

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: vt6656: camel case clean up MACvDisableBarkerPreambleMd

camel case changes
pDevice -> priv
phyData -> data

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: vt6656: camel case clean up MACvEnableBarkerPreambleMd

Camel case changes
pDevice -> priv
pbyData -> data

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: vt6656: camel case clean up MACvDisableProtectMD

camel case changes
pDevice -> priv
pbyData -> data

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: vt6656: camel case clean up MACvEnableProtectMD

Camel case changes
pDevice -> priv
pbyData -> data

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: vt6656: camel case clean up MACvWriteBSSIDAddress

camel case changes
pDevice -> priv
pbyEtherAddr -> addr

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: vt6656: MACvWriteBSSIDAddress remove pbyData

Remove pbyData and point directly to pbyEtherAddr

The size is always ETH_ALEN (6)

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: vt6656: camel case cleanup MACvWriteWord

camel case changes
pDevice -> priv
byRegOfs -> reg_ofs
wData -> word
pbyData -> data

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: vt6656: camel case clean up MACvRegBitsOn

camel case changes
pDevice -> priv
byRegOfs -> reg_ofs
byBits -> bits
pbyData -> data

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: vt6656: camel case cleanup MACvRegBitsOff

camel case changes
pDevice -> priv
byRegOfs -> reg_ofs
byBits -> bits
pbyData -> data

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: vt6656: camel case clean up MACvDisableKeyEntry

Camel case changes
pDevice -> priv
uEntryIdx -> entry_idx

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: vt6656: MACvDisableKeyEntry fix sizeof uEntryIdx to u8

Remove byData and change all callers to u8.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: vt6656: camel case clean up MACvSetBBType

Camel case changes
pDevice -> priv
byType -> type
pbyData -> data

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: vt6656: remove camel case MACbShutdown

Camel case changes
pDevice -> priv

signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: vt6656: remove camel case MACvWriteMultiAddr

Camel case changes.
pDevice -> priv

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Staging: xgifb: Fixed a code-style warning

Added a blank line after declarations to fix the following warning issued by checkpatch.pl:

drivers/staging/xgifb/vb_init.c:800: WARNING: Missing a blank line after declarations

Signed-off-by: Chaitanya Hazarey <c@24.io>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Staging: rtl8192u: Remove old WIRELESS_EXT support

Remove support for building against ancient WIRELESS_EXT versions,
only leaving support for the current version: 22

Signed-off-by: Joel Pelaez Jorge <joelpelaez@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: dgap: Change GFP_ATOMICs to GFP_KERNEL

We don't need to use GFP_ATOMIC at driver load time
so use GFP_KERNEL instead.

Signed-off-by: Mark Hounschell <markh@compro.net>
Tested-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: dgap: Simplify get_altpin and get_useintr functions

Simplify dgap_config_get_useintr and dgap_config_get_altpin
changing the case statement to an if statement.

Signed-off-by: Mark Hounschell <markh@compro.net>
Tested-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: dgap: Replace double negative conditionals

This patch replaces double negativeconditionals

Signed-off-by: Mark Hounschell <markh@compro.net>
Tested-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: dgap: Remove more extra white space and tabs

Removes more extra white space and tabs

Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: dgap: Remove unnecessary initialization of variables in declarations

Removes unnecessary initialization of variables in declarations

Signed-off-by: Mark Hounschell <markh@compro.net>
Tested-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: usbip: use kcalloc instead of kzalloc for array allocations

The advantage of kcalloc is, that will prevent integer overflows which could
result from the multiplication of number of elements and size and it is also
a bit nicer to read.

Signed-off-by: Djordje Zekovic <dj@zeko.me>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

devres: Add devm_get_free_pages API

devm_get_free_pages() and devm_free_pages() are the managed counterparts
for __get_free_pages() and free_pages().

Signed-off-by: Eli Billauer <eli.billauer@gmail.com>
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: r8712u: Remove useless return variables

This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.

Verified by compilation only.

The coccinelle script that find and fixes this issue is:
// <smpl>
@@
type T;
constant C;
identifier ret;
@@
- T ret = C;
... when != ret
- return ret;
+ return C;
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: gdm72xx: return values cleanup

Return values cleanup

Signed-off-by: Davide Gianforte <davide@gengisdave.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: ft1000: Remove useless return variables

This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.

Verified by compilation only.

The coccinelle script that find and fixes this issue is:
// <smpl>
@@
type T;
constant C;
identifier ret;
@@
- T ret = C;
... when != ret
- return ret;
+ return C;
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: rts5208: Use pci_device_id rather than DEFINE_PCI_DEVICE_TABLE

This patch enhances kernel style usage for the rts5208 driver.
We should prefer `struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet
kernel coding style guidelines. This issue was reported by checkpatch.

Signed-off-by: Benoit Taine <benoit.taine@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: rtl8192e: make return of 0 explicit

Delete unnecessary use of a local variable to immediately return 0.

A simplified version of the semantic patch that fixes this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r exists@
local idexpression ret;
expression e;
position p;
@@

-ret = 0;
... when != ret = e
return
- ret
+ 0
  ;
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>