Nadav Rotem [Thu, 18 Oct 2012 17:31:49 +0000 (17:31 +0000)]
When looking for a vector representation of a scalar, do a single lookup. Also, cache the result of the broadcast instruction.
No functionality change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166191
91177308-0d34-0410-b5e6-
96231b3b80d8
Chad Rosier [Thu, 18 Oct 2012 15:49:34 +0000 (15:49 +0000)]
[ms-inline asm] Move most of the AsmParsing logic in clang back into the MC
layer. Add the ParseMSInlineAsm() function, which is the new interface to
clang. Also expose the new MCAsmParserSemaCallback interface, which is used
by the back-end to do name lookup in Sema. Finally, remove the now defunct
APIs introduced in r165946.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166183
91177308-0d34-0410-b5e6-
96231b3b80d8
Ulrich Weigand [Thu, 18 Oct 2012 13:16:11 +0000 (13:16 +0000)]
This patch fixes failures in the SingleSource/Regression/C/uint64_to_float
test case on PowerPC caused by rounding errors when converting from a 64-bit
integer to a single-precision floating point. The reason for this are
double-rounding effects, since on PowerPC we have to convert to an
intermediate double-precision value first, which gets rounded to the
final single-precision result.
The patch fixes the problem by preparing the 64-bit integer so that the
first conversion step to double-precision will always be exact, and the
final rounding step will result in the correctly-rounded single-precision
result. The generated code sequence is equivalent to what GCC would generate.
When -enable-unsafe-fp-math is in effect, that extra effort is omitted
and we accept possible rounding errors (just like GCC does as well).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166178
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Thu, 18 Oct 2012 09:56:08 +0000 (09:56 +0000)]
Refactor insert and extract of sub-integers into static helpers that
operate purely on values. Sink the alloca loading and storing logic into
the rewrite routines that are specific to alloca-integer-rewrite
driving. This is just a refactoring here, but the subsequent step will
be to reuse the insertion and extraction logic when rewriting integer
loads and stores that have been split and decomposed into narrower loads
and stores.
No functionality changed other than different names for instructions.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166176
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Thu, 18 Oct 2012 09:56:06 +0000 (09:56 +0000)]
This FIXME was fixed some time ago. =]
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166175
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Thu, 18 Oct 2012 08:05:46 +0000 (08:05 +0000)]
Introduce a BarrierNoop pass, a hack designed to allow *some* control
over the implicitly-formed-and-nesting CGSCC pass manager and function
pass managers, especially when using them on the opt commandline or
using extension points in the module builder. The '-barrier' opt flag
(or the pass itself) will create a no-op module pass in the pipeline,
resetting the pass manager stack, and allowing the creation of a new
pipeline of function passes or CGSCC passes to be created that is
independent from any previous pipelines.
For example, this can be used to test running two CGSCC passes in
independent CGSCC pass managers as opposed to in the same CGSCC pass
manager. It also allows us to introduce a further hack into the
PassManagerBuilder to separate the O0 pipeline extension passes from the
always-inliner's CGSCC pass manager, which they likely do not want to
participate in... At the very least none of the Sanitizer passes want
this behavior.
This fixes a bug with ASan at O0 currently, and I'll commit the ASan
test which covers this pass. I'm happy to add a test case that this pass
exists and works, but not sure how much time folks would like me to
spend adding test cases for the details of its behavior of partition
pass managers.... The whole thing is just vile, and mostly intended to
unblock ASan, so I'm hoping to rip this all out in a brave new pass
manager world.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166172
91177308-0d34-0410-b5e6-
96231b3b80d8
Nadav Rotem [Thu, 18 Oct 2012 06:09:21 +0000 (06:09 +0000)]
remove unused variable to fix a warning.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166170
91177308-0d34-0410-b5e6-
96231b3b80d8
Nadav Rotem [Thu, 18 Oct 2012 05:46:16 +0000 (05:46 +0000)]
Add a small example which shows a vectorizable loop with a non-pow-of-two count
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166169
91177308-0d34-0410-b5e6-
96231b3b80d8
Bob Wilson [Thu, 18 Oct 2012 05:43:52 +0000 (05:43 +0000)]
Temporarily revert the TargetTransform changes.
The TargetTransform changes are breaking LTO bootstraps of clang. I am
working with Nadav to figure out the problem, but I am reverting it for now
to get our buildbots working.
This reverts svn commits: 165665 165669 165670 165786 165787 165997
and I have also reverted clang svn 165741
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166168
91177308-0d34-0410-b5e6-
96231b3b80d8
Nadav Rotem [Thu, 18 Oct 2012 05:33:02 +0000 (05:33 +0000)]
Remove the use of dominators and AA.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166167
91177308-0d34-0410-b5e6-
96231b3b80d8
Nadav Rotem [Thu, 18 Oct 2012 05:29:12 +0000 (05:29 +0000)]
Vectorizer: Add support for loops with an unknown count. For example:
for (i=0; i<n; i++){
a[i] = b[i+1] + c[i+3];
}
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166165
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Wed, 17 Oct 2012 23:56:05 +0000 (23:56 +0000)]
Revert r166157 because some tests fail...
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166159
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Wed, 17 Oct 2012 23:54:19 +0000 (23:54 +0000)]
Check that the operand of the GEP is not the GEP itself. This occurred during an LTO build of LLVM.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166157
91177308-0d34-0410-b5e6-
96231b3b80d8
Michael Liao [Wed, 17 Oct 2012 23:45:54 +0000 (23:45 +0000)]
Revert part of r166049 back and enable test case in r166125.
- Folding (trunc (concat ... X )) to (concat ... (trunc X) ...) is valid
when '...' are all 'undef's.
- r166125 relies on this transformation.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166155
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Wed, 17 Oct 2012 23:40:15 +0000 (23:40 +0000)]
LoopVectorize.cpp: Fix a warning. [-Wunused-variable]
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166153
91177308-0d34-0410-b5e6-
96231b3b80d8
Michael Liao [Wed, 17 Oct 2012 23:08:19 +0000 (23:08 +0000)]
Disable extract-concat test case temporarily
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166141
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakub Staszak [Wed, 17 Oct 2012 23:06:37 +0000 (23:06 +0000)]
Remove redundant SetInsertPoint call.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166138
91177308-0d34-0410-b5e6-
96231b3b80d8
Michael Liao [Wed, 17 Oct 2012 22:41:15 +0000 (22:41 +0000)]
Revert r166049
- In general, it's unsafe for this transformation.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166135
91177308-0d34-0410-b5e6-
96231b3b80d8
Reed Kotler [Wed, 17 Oct 2012 22:29:54 +0000 (22:29 +0000)]
Add conditional branch instructions and their patterns.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166134
91177308-0d34-0410-b5e6-
96231b3b80d8
Roman Divacky [Wed, 17 Oct 2012 21:07:35 +0000 (21:07 +0000)]
Fix some typos and wrong indenting.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166128
91177308-0d34-0410-b5e6-
96231b3b80d8
Michael Liao [Wed, 17 Oct 2012 20:48:33 +0000 (20:48 +0000)]
Teach DAG combine to fold (extract_subvec (concat v1, ..) i) to v_i
- If the extracted vector has the same type of all vectored being concatenated
together, it should be simplified directly into v_i, where i is the index of
the element being extracted.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166125
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Wed, 17 Oct 2012 20:26:33 +0000 (20:26 +0000)]
Switch MRI::UsedPhysRegs to a register unit bit vector.
This is a more compact, less redundant representation, and it avoids
scanning long lists of aliases for ARM D-registers, for example.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166124
91177308-0d34-0410-b5e6-
96231b3b80d8
Nadav Rotem [Wed, 17 Oct 2012 19:49:21 +0000 (19:49 +0000)]
Update the release notes about how to enable the loop vectorizer.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166123
91177308-0d34-0410-b5e6-
96231b3b80d8
Evan Cheng [Wed, 17 Oct 2012 19:39:36 +0000 (19:39 +0000)]
Add a really faster pre-RA scheduler (-pre-RA-sched=linearize). It doesn't use
any scheduling heuristics nor does it build up any scheduling data structure
that other heuristics use. It essentially linearize by doing a DFA walk but
it does handle glues correctly.
IMPORTANT: it probably can't handle all the physical register dependencies so
it's not suitable for x86. It also doesn't deal with dbg_value nodes right now
so it's definitely is still WIP.
rdar://
12474515
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166122
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Wed, 17 Oct 2012 18:44:18 +0000 (18:44 +0000)]
Merge MRI::isPhysRegOrOverlapUsed() into isPhysRegUsed().
All callers of these functions really want the isPhysRegOrOverlapUsed()
functionality which also checks aliases. For historical reasons, targets
without register aliases were calling isPhysRegUsed() instead.
Change isPhysRegUsed() to also check aliases, and switch all
isPhysRegOrOverlapUsed() callers to isPhysRegUsed().
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166117
91177308-0d34-0410-b5e6-
96231b3b80d8
Nadav Rotem [Wed, 17 Oct 2012 18:35:21 +0000 (18:35 +0000)]
Update the release notes about the store-merge dag optimization.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166116
91177308-0d34-0410-b5e6-
96231b3b80d8
Nadav Rotem [Wed, 17 Oct 2012 18:33:50 +0000 (18:33 +0000)]
Update the release notes about the new TargetTransformInfo API changes.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166115
91177308-0d34-0410-b5e6-
96231b3b80d8
Nadav Rotem [Wed, 17 Oct 2012 18:30:09 +0000 (18:30 +0000)]
Update the release notes about the new loop vectorizer.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166113
91177308-0d34-0410-b5e6-
96231b3b80d8
Nadav Rotem [Wed, 17 Oct 2012 18:25:06 +0000 (18:25 +0000)]
Add a loop vectorizer.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166112
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Wed, 17 Oct 2012 17:52:35 +0000 (17:52 +0000)]
Check for empty YMM use-def lists in X86VZeroUpper.
The previous MRI.isPhysRegUsed(YMM0) would also return true when the
function contains a call to a function that may clobber YMM0. That's
most of them.
Checking the use-def chains allows us to skip functions that don't
explicitly mention YMM registers.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166110
91177308-0d34-0410-b5e6-
96231b3b80d8
Anton Korobeynikov [Wed, 17 Oct 2012 17:37:11 +0000 (17:37 +0000)]
Fix fallout from RegInfo => FrameLowering refactoring on MSP430.
Patch by Job Noorman!
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166108
91177308-0d34-0410-b5e6-
96231b3b80d8
Andrew Trick [Wed, 17 Oct 2012 17:27:10 +0000 (17:27 +0000)]
misched: Better handling of invalid latencies in the machine model
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166107
91177308-0d34-0410-b5e6-
96231b3b80d8
Sean Silva [Wed, 17 Oct 2012 16:36:27 +0000 (16:36 +0000)]
docs: Add link to integrated assembler HowTo
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166106
91177308-0d34-0410-b5e6-
96231b3b80d8
Daniel Dunbar [Wed, 17 Oct 2012 16:30:54 +0000 (16:30 +0000)]
Support: Don't remove special files on signals.
- Similar to Path::eraseFromDisk(), we don't want LLVM to remove things like
/dev/null, even if it has the permission.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166105
91177308-0d34-0410-b5e6-
96231b3b80d8
Kostya Serebryany [Wed, 17 Oct 2012 13:40:06 +0000 (13:40 +0000)]
[asan] better debug diagnostics in asan compiler module
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166102
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Wed, 17 Oct 2012 09:23:48 +0000 (09:23 +0000)]
This just in, it is a *bad idea* to use 'udiv' on an offset of
a pointer. A very bad idea. Let's not do that. Fixes PR14105.
Note that this wasn't *that* glaring of an oversight. Originally, these
routines were only called on offsets within an alloca, which are
intrinsically positive. But over the evolution of the pass, they ended
up being called for arbitrary offsets, and things went downhill...
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166095
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Wed, 17 Oct 2012 08:08:06 +0000 (08:08 +0000)]
Marked this variable as 'used' so that LTO doesn't get rid of it.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166092
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Wed, 17 Oct 2012 07:22:16 +0000 (07:22 +0000)]
Fix a really annoying "bug" introduced in r165941. The change from that
revision makes no sense. We cannot use the address space of the *post
indexed* type to conclude anything about a *pre indexed* pointer type's
size. More importantly, this index can never be over a pointer. We are
indexing over arrays and vectors here.
Of course, I have no test case here. Neither did the original patch. =/
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166091
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Wed, 17 Oct 2012 05:15:58 +0000 (05:15 +0000)]
Remove LLVM_DELETED_FUNCTION from destructors that override non-deleted base class destructors. This isn't legal by the C++11 standard and clang now checks for it. Curiously gcc didn't catch this, possibly because of the template usage.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166089
91177308-0d34-0410-b5e6-
96231b3b80d8
Michael Liao [Wed, 17 Oct 2012 03:59:18 +0000 (03:59 +0000)]
Check SSSE3 instead of SSE4.1
- All shuffle insns required, especially PSHUB, are added in SSSE3.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166086
91177308-0d34-0410-b5e6-
96231b3b80d8
Michael Liao [Wed, 17 Oct 2012 02:22:27 +0000 (02:22 +0000)]
Fix setjmp on models with non-Small code model nor non-Static relocation model
- MBB address is only valid as an immediate value in Small & Static
code/relocation models. On other models, LEA is needed to load IP address of
the restore MBB.
- A minor fix of MBB in MC lowering is added as well to enable target
relocation flag being propagated into MC.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166084
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Wed, 17 Oct 2012 01:37:59 +0000 (01:37 +0000)]
Use a SparseSet instead of a BitVector for UsedInInstr in RAFast.
This is just as fast, and it makes it possible to avoid leaking the
UsedPhysRegs BitVector implementation through
MachineRegisterInfo::addPhysRegsUsed().
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166083
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Tue, 16 Oct 2012 23:46:25 +0000 (23:46 +0000)]
Use a typedef to reduce some typing and reformat code accordingly.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166077
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Tue, 16 Oct 2012 23:46:23 +0000 (23:46 +0000)]
Variable name cleanup.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166076
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Tue, 16 Oct 2012 23:46:21 +0000 (23:46 +0000)]
Formatting and 80-col.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166075
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Tue, 16 Oct 2012 23:46:19 +0000 (23:46 +0000)]
Spacing.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166074
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Tue, 16 Oct 2012 22:51:58 +0000 (22:51 +0000)]
Avoid rematerializing a redef immediately after the old def.
PR14098 contains an example where we would rematerialize a MOV8ri
immediately after the original instruction:
%vreg7:sub_8bit<def> = MOV8ri 9; GR32_ABCD:%vreg7
%vreg22:sub_8bit<def> = MOV8ri 9; GR32_ABCD:%vreg7
Besides being pointless, it is also wrong since the original instruction
only redefines part of the register, and the value read by the new
instruction is wrong.
The problem was the LiveRangeEdit::allUsesAvailableAt() didn't
special-case OrigIdx == UseIdx and found the wrong SSA value.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166068
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Tue, 16 Oct 2012 22:51:55 +0000 (22:51 +0000)]
Revert r166046 "Switch back to the old coalescer for now to fix the 32 bit bit"
A fix for PR14098, including the test case is in the next commit.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166067
91177308-0d34-0410-b5e6-
96231b3b80d8
Michael Gottesman [Tue, 16 Oct 2012 21:29:38 +0000 (21:29 +0000)]
[InstCombine] Teach InstCombine how to handle an obfuscated splat.
An obfuscated splat is where the frontend poorly generates code for a splat
using several different shuffles to create the splat, i.e.,
%A = load <4 x float>* %in_ptr, align 16
%B = shufflevector <4 x float> %A, <4 x float> undef, <4 x i32> <i32 0, i32 0, i32 undef, i32 undef>
%C = shufflevector <4 x float> %B, <4 x float> %A, <4 x i32> <i32 0, i32 1, i32 4, i32 undef>
%D = shufflevector <4 x float> %C, <4 x float> %A, <4 x i32> <i32 0, i32 1, i32 2, i32 4>
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166061
91177308-0d34-0410-b5e6-
96231b3b80d8
Chad Rosier [Tue, 16 Oct 2012 20:16:20 +0000 (20:16 +0000)]
[ms-inline asm] Add the helper function, isParseringInlineAsm(). To be used in a future commit.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166054
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakub Staszak [Tue, 16 Oct 2012 19:52:32 +0000 (19:52 +0000)]
Simplify code. No functionality change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166053
91177308-0d34-0410-b5e6-
96231b3b80d8
Michael Liao [Tue, 16 Oct 2012 19:49:51 +0000 (19:49 +0000)]
Check .rela instead of ELF64 for the compensation vaue resetting
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166051
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakub Staszak [Tue, 16 Oct 2012 19:39:40 +0000 (19:39 +0000)]
80-col fixup.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166050
91177308-0d34-0410-b5e6-
96231b3b80d8
Michael Liao [Tue, 16 Oct 2012 19:38:35 +0000 (19:38 +0000)]
Teach DAG combine to fold (trunc (fptoXi x)) to (fptoXi x)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166049
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Tue, 16 Oct 2012 19:34:06 +0000 (19:34 +0000)]
Switch back to the old coalescer for now to fix the 32 bit bit
llvm+clang+compiler-rt bootstrap.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166046
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakub Staszak [Tue, 16 Oct 2012 19:32:31 +0000 (19:32 +0000)]
Simplify potentially quadratic behavior while erasing elements from std::vector.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166045
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Tue, 16 Oct 2012 18:20:09 +0000 (18:20 +0000)]
And now we can call the other 'get' method from this one and not duplicate the code.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166037
91177308-0d34-0410-b5e6-
96231b3b80d8
Michael Liao [Tue, 16 Oct 2012 18:14:11 +0000 (18:14 +0000)]
Support v8f32 to v8i8/vi816 conversion through custom lowering
- Add custom FP_TO_SINT on v8i16 (and v8i8 which is legalized as v8i16 due to
vector element-wise widening) to reduce DAG combiner and its overhead added
in X86 backend.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166036
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Tue, 16 Oct 2012 18:06:06 +0000 (18:06 +0000)]
Use the appropriate Attributes::get method to create an Attributes object.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166035
91177308-0d34-0410-b5e6-
96231b3b80d8
Owen Anderson [Tue, 16 Oct 2012 17:10:33 +0000 (17:10 +0000)]
Speculative fix the mask constants to be of type uintptr_t. I don't know of any case where the old form was incorrect, but I'm more confident that such cases don't exist in this version.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166031
91177308-0d34-0410-b5e6-
96231b3b80d8
Dmitri Gribenko [Tue, 16 Oct 2012 15:37:50 +0000 (15:37 +0000)]
Fix function parameter spelling in comments. Caught by -Wdocumentation.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166024
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Schmidt [Tue, 16 Oct 2012 13:30:53 +0000 (13:30 +0000)]
This patch addresses PR13949.
For the PowerPC 64-bit ELF Linux ABI, aggregates of size less than 8
bytes are to be passed in the low-order bits ("right-adjusted") of the
doubleword register or memory slot assigned to them. A previous patch
addressed this for aggregates passed in registers. However, small
aggregates passed in the overflow portion of the parameter save area are
still being passed left-adjusted.
The fix is made in PPCTargetLowering::LowerCall_Darwin_Or_64SVR4 on the
caller side, and in PPCTargetLowering::LowerFormalArguments_64SVR4 on
the callee side. The main fix on the callee side simply extends
existing logic for 1- and 2-byte objects to 1- through 7-byte objects,
and correcting a constant left over from 32-bit code. There is also a
fix to a bogus calculation of the offset to the following argument in
the parameter save area.
On the caller side, again a constant left over from 32-bit code is
fixed. Additionally, some code for 1, 2, and 4-byte objects is
duplicated to handle the 3, 5, 6, and 7-byte objects for SVR4 only. The
LowerCall_Darwin_Or_64SVR4 logic is getting fairly convoluted trying to
handle both ABIs, and I propose to separate this into two functions in a
future patch, at which time the duplication can be removed.
The patch adds a new test (structsinmem.ll) to demonstrate correct
passing of structures of all seven sizes. Eight dummy parameters are
used to force these structures to be in the overflow portion of the
parameter save area.
As a side effect, this corrects the case when aggregates passed in
registers are saved into the first eight doublewords of the parameter
save area: Previously they were stored left-justified, and now are
properly stored right-justified. This requires changing the expected
output of existing test case structsinregs.ll.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166022
91177308-0d34-0410-b5e6-
96231b3b80d8
Stepan Dyatkovskiy [Tue, 16 Oct 2012 07:16:47 +0000 (07:16 +0000)]
Issue:
Stack is formed improperly for long structures passed as byval arguments for
EABI mode.
If we took AAPCS reference, we can found the next statements:
A: "If the argument requires double-word alignment (8-byte), the NCRN (Next
Core Register Number) is rounded up to the next even register number." (5.5
Parameter Passing, Stage C, C.3).
B: "The alignment of an aggregate shall be the alignment of its most-aligned
component." (4.3 Composite Types, 4.3.1 Aggregates).
So if we have structure with doubles (9 double fields) and 3 Core unused
registers (r1, r2, r3): caller should use r2 and r3 registers only.
Currently r1,r2,r3 set is used, but it is invalid.
Callee VA routine should also use r2 and r3 regs only. All is ok here. This
behaviour is guessed by rounding up SP address with ADD+BFC operations.
Fix:
Main fix is in ARMTargetLowering::HandleByVal. If we detected AAPCS mode and
8 byte alignment, we waste odd registers then.
P.S.:
I also improved LDRB_POST_IMM regression test. Since ldrb instruction will
not generated by current regression test after this patch.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166018
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Tue, 16 Oct 2012 06:28:34 +0000 (06:28 +0000)]
Reapply r165661, Patch by Shuxin Yang <shuxin.llvm@gmail.com>.
Original message:
The attached is the fix to radar://
11663049. The optimization can be outlined by following rules:
(select (x != c), e, c) -> select (x != c), e, x),
(select (x == c), c, e) -> select (x == c), x, e)
where the <c> is an integer constant.
The reason for this change is that : on x86, conditional-move-from-constant needs two instructions;
however, conditional-move-from-register need only one instruction.
While the LowerSELECT() sounds to be the most convenient place for this optimization, it turns out to be a bad place. The reason is that by replacing the constant <c> with a symbolic value, it obscure some instruction-combining opportunities which would otherwise be very easy to spot. For that reason, I have to postpone the change to last instruction-combining phase.
The change passes the test of "make check-all -C <build-root/test" and "make -C project/test-suite/SingleSource".
Original message since r165661:
My previous change has a bug: I negated the condition code of a CMOV, and go ahead creating a new CMOV using the *ORIGINAL* condition code.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166017
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Tue, 16 Oct 2012 06:10:45 +0000 (06:10 +0000)]
Cleanup whitespace.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166016
91177308-0d34-0410-b5e6-
96231b3b80d8
Owen Anderson [Tue, 16 Oct 2012 06:04:27 +0000 (06:04 +0000)]
Fix a bug in the set(I,E)/reset(I,E) methods that I recently added. The boundary condition for checking if I and E were in the same word were incorrect, and, beyond that, the mask computation was not using a wide enough constant.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166015
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Tue, 16 Oct 2012 06:01:50 +0000 (06:01 +0000)]
Move X86MCInstLower class definition into implementation file. It's not needed outside.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166014
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Tue, 16 Oct 2012 06:01:44 +0000 (06:01 +0000)]
Cleanup whitespace.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166013
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Tue, 16 Oct 2012 05:57:28 +0000 (05:57 +0000)]
Have AttributesImpl defriend the Attributes class.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166012
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Tue, 16 Oct 2012 05:55:09 +0000 (05:55 +0000)]
Have AttrBuilder defriend the Attributes class.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166011
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Tue, 16 Oct 2012 05:23:31 +0000 (05:23 +0000)]
Use the Attributes::get method which takes an AttrVal value directly to simplify the code a bit. No functionality change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166009
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Tue, 16 Oct 2012 05:22:28 +0000 (05:22 +0000)]
Put simple c'tors inline.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166008
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Tue, 16 Oct 2012 05:20:51 +0000 (05:20 +0000)]
Pass in the context to the Attributes::get method.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166007
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Tue, 16 Oct 2012 02:21:30 +0000 (02:21 +0000)]
Fix filename in file header.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166004
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Tue, 16 Oct 2012 01:13:06 +0000 (01:13 +0000)]
Fix the cpu name and add -verify-machineinstrs.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166003
91177308-0d34-0410-b5e6-
96231b3b80d8
Andrew Trick [Tue, 16 Oct 2012 00:22:51 +0000 (00:22 +0000)]
misched: Added handleMove support for updating all kill flags, not just for allocatable regs.
This is a medium term workaround until we have a more robust solution
in the form of a register liveness utility for postRA passes.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166001
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Tue, 16 Oct 2012 00:05:06 +0000 (00:05 +0000)]
Remove unused BitVectors from getAllocatableSet().
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@165999
91177308-0d34-0410-b5e6-
96231b3b80d8
Nadav Rotem [Mon, 15 Oct 2012 22:50:02 +0000 (22:50 +0000)]
LTO also needs to initialize the TargetTransform infrastructure.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@165997
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Mon, 15 Oct 2012 22:41:03 +0000 (22:41 +0000)]
Remove RegisterClassInfo::isReserved() and isAllocatable().
Clients can use the equivalent functions in MRI.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@165990
91177308-0d34-0410-b5e6-
96231b3b80d8
Michael Liao [Mon, 15 Oct 2012 22:39:43 +0000 (22:39 +0000)]
Add __builtin_setjmp/_longjmp supprt in X86 backend
- Besides used in SjLj exception handling, __builtin_setjmp/__longjmp is also
used as a light-weight replacement of setjmp/longjmp which are used to
implementation continuation, user-level threading, and etc. The support added
in this patch ONLY addresses this usage and is NOT intended to support SjLj
exception handling as zero-cost DWARF exception handling is used by default
in X86.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@165989
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Mon, 15 Oct 2012 22:14:34 +0000 (22:14 +0000)]
Remove LIS::isAllocatable() and isReserved() helpers.
All callers can simply use the corresponding MRI functions.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@165985
91177308-0d34-0410-b5e6-
96231b3b80d8
Owen Anderson [Mon, 15 Oct 2012 22:05:27 +0000 (22:05 +0000)]
Add range-based set()/reset() to BitVector. These allow fast setting/resetting of ranges of bits, particularly useful when dealing with very large BitVector's.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@165984
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Mon, 15 Oct 2012 21:57:41 +0000 (21:57 +0000)]
Switch most getReservedRegs() clients to the MRI equivalent.
Using the cached bit vector in MRI avoids comstantly allocating and
recomputing the reserved register bit vector.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@165983
91177308-0d34-0410-b5e6-
96231b3b80d8
Jakob Stoklund Olesen [Mon, 15 Oct 2012 21:33:06 +0000 (21:33 +0000)]
Freeze the reserved registers as soon as isel is complete.
Also provide an MRI::getReservedRegs() function to access the frozen
register set, and isReserved() and isAllocatable() methods to test
individual registers.
The various implementations of TRI::getReservedRegs() are quite
complicated, and many passes need to look at the reserved register set.
This patch makes it possible for these passes to use the cached copy in
MRI, avoiding a lot of malloc traffic and repeated calculations.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@165982
91177308-0d34-0410-b5e6-
96231b3b80d8
Jim Grosbach [Mon, 15 Oct 2012 21:23:40 +0000 (21:23 +0000)]
ARM: v1i64 and v2i64 VBSL intrinsic support.
rdar://
12502028
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@165981
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Mon, 15 Oct 2012 21:11:46 +0000 (21:11 +0000)]
Add dependency on llvm-bcanalyzer from tests to the CMake build.
This fixes a CMake build break introduced by r165739.
Thanks Jan Voung for the quick suggestion/fix.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@165978
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Mon, 15 Oct 2012 20:35:56 +0000 (20:35 +0000)]
Move the Attributes::Builder outside of the Attributes class and into its own class named AttrBuilder. No functionality change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@165960
91177308-0d34-0410-b5e6-
96231b3b80d8
Andrew Trick [Mon, 15 Oct 2012 20:33:14 +0000 (20:33 +0000)]
Check output of the misched unit tests
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@165959
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Mon, 15 Oct 2012 19:58:25 +0000 (19:58 +0000)]
Add comments.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@165958
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Mon, 15 Oct 2012 19:25:43 +0000 (19:25 +0000)]
Add a cpu to try to fix the atom builder.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@165956
91177308-0d34-0410-b5e6-
96231b3b80d8
Chad Rosier [Mon, 15 Oct 2012 19:08:18 +0000 (19:08 +0000)]
[ms-inline asm] If we parsed a statement and the opcode is valid, then it's an instruction.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@165955
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Mon, 15 Oct 2012 19:00:10 +0000 (19:00 +0000)]
Add testcase for pr14088.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@165954
91177308-0d34-0410-b5e6-
96231b3b80d8
Andrew Trick [Mon, 15 Oct 2012 18:21:08 +0000 (18:21 +0000)]
misched tests: add a triple to speculatively fix windows builders.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@165952
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Mon, 15 Oct 2012 18:21:07 +0000 (18:21 +0000)]
Make sure we iterate over newly created instructions. Fixes pr13625. Testcase to
follow in one sec.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@165951
91177308-0d34-0410-b5e6-
96231b3b80d8
Andrew Trick [Mon, 15 Oct 2012 18:02:27 +0000 (18:02 +0000)]
misched: ILP scheduler for experimental heuristics.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@165950
91177308-0d34-0410-b5e6-
96231b3b80d8
Chad Rosier [Mon, 15 Oct 2012 17:26:38 +0000 (17:26 +0000)]
[ms-inline asm] Update the end loc for ParseIntelMemOperand.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@165947
91177308-0d34-0410-b5e6-
96231b3b80d8
Chad Rosier [Mon, 15 Oct 2012 17:19:13 +0000 (17:19 +0000)]
[ms-inline asm] Add a few new APIs to the AsmParser class in support of MS-Style
inline assembly. For the time being, these will be called directly by clang.
However, in the near future I expect these to be sunk back into the MC layer
and more basic APIs (e.g., getClobbers(), getConstraints(), etc.) will be called
by clang.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@165946
91177308-0d34-0410-b5e6-
96231b3b80d8
Chad Rosier [Mon, 15 Oct 2012 16:50:34 +0000 (16:50 +0000)]
[ms-inline asm] Use incoming argument rather than hard coding to false.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@165945
91177308-0d34-0410-b5e6-
96231b3b80d8
Jan Wen Voung [Mon, 15 Oct 2012 16:47:58 +0000 (16:47 +0000)]
Fix a typo in bitcode docs, from 165814.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@165944
91177308-0d34-0410-b5e6-
96231b3b80d8
Micah Villmow [Mon, 15 Oct 2012 16:24:29 +0000 (16:24 +0000)]
Resubmit the changes to llvm core to update the functions to support different pointer sizes on a per address space basis.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@165941
91177308-0d34-0410-b5e6-
96231b3b80d8