Nick Lewycky [Tue, 15 Apr 2014 07:22:52 +0000 (07:22 +0000)]
Break PseudoSourceValue out of the Value hierarchy. It is now the root of its own tree containing FixedStackPseudoSourceValue (which you can use isa/dyn_cast on) and MipsCallEntry (which you can't). Anything that needs to use either a PseudoSourceValue* and Value* is strongly encouraged to use a MachinePointerInfo instead.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206255
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Tue, 15 Apr 2014 07:20:03 +0000 (07:20 +0000)]
[C++11] More 'nullptr' conversion. In some cases just using a boolean check instead of comparing to nullptr.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206254
91177308-0d34-0410-b5e6-
96231b3b80d8
Nick Lewycky [Tue, 15 Apr 2014 07:08:40 +0000 (07:08 +0000)]
Add a DenseMapInfo specialization for PointerUnion. In tree user to land shortly.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206253
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Tue, 15 Apr 2014 06:32:26 +0000 (06:32 +0000)]
[C++11] More 'nullptr' conversion. In some cases just using a boolean check instead of comparing to nullptr.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206252
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Tue, 15 Apr 2014 06:29:04 +0000 (06:29 +0000)]
[Allocator] Constrain the Deallocate templated overloads to only apply
to types which we can compute the size of. The comparison with zero
isn't actually interesting here, it's mostly about putting sizeof into
a sfinae context.
This is particular important for Deallocate as otherwise the void*
overload can quickly become ambiguous.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206251
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Tue, 15 Apr 2014 06:17:44 +0000 (06:17 +0000)]
Use unique_ptr to manage TypePromotionActions owned by TypePromotionTransaction.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206250
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Tue, 15 Apr 2014 06:07:26 +0000 (06:07 +0000)]
Use unique_ptr to manage ownership of GCFunctionInfos in GCStrategy
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206249
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Tue, 15 Apr 2014 05:53:26 +0000 (05:53 +0000)]
Use unique_ptr for the result of Registry entries.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206248
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Tue, 15 Apr 2014 05:34:49 +0000 (05:34 +0000)]
Use unique_ptr to manage ownership of GCStrategy objects in GCMetadata
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206246
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Tue, 15 Apr 2014 05:25:03 +0000 (05:25 +0000)]
Use unique_ptr for section/segment ownership in WinCOFFObjectWriter
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206245
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Tue, 15 Apr 2014 05:15:19 +0000 (05:15 +0000)]
Use unique_ptr to own MCFunctions within MCModule.
MCModule's ctor had to be moved out of line so the definition of
MCFunction was available. (ctor requires the dtor of members (in case
the ctor throws) which required access to the dtor of MCFunction)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206244
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Tue, 15 Apr 2014 04:59:12 +0000 (04:59 +0000)]
[C++11] More 'nullptr' conversion. In some cases just using a boolean check instead of comparing to nullptr.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206243
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Tue, 15 Apr 2014 04:56:29 +0000 (04:56 +0000)]
Use std::unique_ptr to manage MCBasicBlocks in MCFunction.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206242
91177308-0d34-0410-b5e6-
96231b3b80d8
Lang Hames [Tue, 15 Apr 2014 04:40:56 +0000 (04:40 +0000)]
[MC] Require an MCContext when constructing an MCDisassembler.
This patch re-introduces the MCContext member that was removed from
MCDisassembler in r206063, and requires that an MCContext be passed in at
MCDisassembler construction time. (Previously the MCContext member had been
initialized in an ad-hoc fashion after construction). The MCCContext member
can be used by MCDisassembler sub-classes to construct constant or
target-specific MCExprs.
This patch updates disassemblers for in-tree targets, and provides the
MCRegisterInfo instance that some disassemblers were using through the
MCContext (previously those backends were constructing their own
MCRegisterInfo instances).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206241
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Tue, 15 Apr 2014 04:12:21 +0000 (04:12 +0000)]
X86JITInfo: [x86] Use X86CompilationCallback_SSE() along;
*not* Subtarget->hasSSE1()
*but* __SSE__, the flag that LLVM libraries are compiled
The callback calls internal LLVM JIT libraries. It may be built with -msse (or above).
FIXME: JIT may use "host" instead of "generic" by default.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206240
91177308-0d34-0410-b5e6-
96231b3b80d8
Jim Grosbach [Tue, 15 Apr 2014 02:14:09 +0000 (02:14 +0000)]
[ARM64,C++11]: Range'ify the dead-register-definition pass.
Range-based for loops. No functional change intended.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206239
91177308-0d34-0410-b5e6-
96231b3b80d8
Jim Grosbach [Tue, 15 Apr 2014 02:14:06 +0000 (02:14 +0000)]
Add iterator_range for MachineInstr defs.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206238
91177308-0d34-0410-b5e6-
96231b3b80d8
Quentin Colombet [Tue, 15 Apr 2014 01:17:45 +0000 (01:17 +0000)]
[MC] Emit an error if cfi_startproc is used before a symbol is defined.
Currently, we bind those directives with the last symbol, so if none
has been defined, this would lead to a crash of the compiler.
<rdar://problem/
15939159>
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206236
91177308-0d34-0410-b5e6-
96231b3b80d8
Quentin Colombet [Tue, 15 Apr 2014 01:15:32 +0000 (01:15 +0000)]
[Register Coalescer] Add a test case for 206060.
<rdar://problem/
16582185>
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206235
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Tue, 15 Apr 2014 00:47:47 +0000 (00:47 +0000)]
[Allocator] Add Deallocate support to the AllocatorBase CRTP class,
along with templated overloads much like we have for Allocate. These
will facilitate switching the Deallocate interface of all the Allocator
classes to accept the size by pre-filling it from the type size where we
can do so. I plan to convert several uses to the template variants in
subsequent patches prior to adding the Size parameter.
No functionality changed, WIP.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206230
91177308-0d34-0410-b5e6-
96231b3b80d8
Quentin Colombet [Tue, 15 Apr 2014 00:28:39 +0000 (00:28 +0000)]
[ARM64][MC] Set the default CPU string to generic.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206228
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Tue, 15 Apr 2014 00:22:53 +0000 (00:22 +0000)]
[Allocator] Hack around the fact that GCC can't compile the
static_assert added in r206225. I'm looking into a proper fix, but
wanted the bots back.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206226
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Tue, 15 Apr 2014 00:19:41 +0000 (00:19 +0000)]
[Allocator] Factor the Allocate template overloads into a base class
rather than defining them (differently!) in both allocators. This also
serves as a basis for documenting and even enforcing some of the
LLVM-style "allocator" concept methods which must exist with various
signatures.
I plan on extending and changing the signatures of these to further
simplify our allocator model in subsequent commits, so I wanted to
factor things as best as I could first. Notably, I'm working to add the
'Size' to the deallocation method of all allocators. This has several
implications not the least of which are faster deallocation times on
certain allocation libraries (tcmalloc). It also will allow the JIT
allocator to fully model the existing allocation interfaces and allow
sanitizer poisoning of deallocated regions. The list of advantages goes
on. =] But by factoring things first I'll be able to make this easier by
first introducing template helpers for the deallocation path.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206225
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Mon, 14 Apr 2014 22:45:02 +0000 (22:45 +0000)]
Use std::unique_ptr for DIE children
Got bored, removed some manual memory management.
Pushed references (rather than pointers) through a few APIs rather than
replacing *x with x.get().
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206222
91177308-0d34-0410-b5e6-
96231b3b80d8
Jim Grosbach [Mon, 14 Apr 2014 22:23:30 +0000 (22:23 +0000)]
X86: Nuke one more CPU autodetect blurb.
Missed one in r206094. This brings MC and TargetMachine back into sync.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206220
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Mon, 14 Apr 2014 22:23:06 +0000 (22:23 +0000)]
Change argument order and add explanatory comment to r206130
Changes requested in code review by Eric Christopher of r206130.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206219
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Mon, 14 Apr 2014 22:21:22 +0000 (22:21 +0000)]
Use FrameSetup on frame instructions for the Mips port.
I can't seem to get a testcase to show a difference here, but it's
part of the unconditional-br.ll line table weirdness.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206218
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Mon, 14 Apr 2014 21:58:19 +0000 (21:58 +0000)]
[CMake] Reformat, if(MSVC)...else()...endif()
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206215
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Mon, 14 Apr 2014 21:50:37 +0000 (21:50 +0000)]
Revert "Revert r206045, "Fix shift by constants for vector.""
Fix cases where the Value itself is used, and not the constant value.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206214
91177308-0d34-0410-b5e6-
96231b3b80d8
Quentin Colombet [Mon, 14 Apr 2014 21:25:53 +0000 (21:25 +0000)]
[ARM64][MC] Set the default CPU to cyclone when initilizating the MC layer.
This matches that ARM64Subtarget does for now.
This is related to <rdar://problem/
16573920>
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206211
91177308-0d34-0410-b5e6-
96231b3b80d8
Adrian Prantl [Mon, 14 Apr 2014 21:16:04 +0000 (21:16 +0000)]
Re-apply r206096 after investigating the gdb buildbot failure.
Thanks to dblaikie for updating the testcase!
Debug info: (bugfix) C++ C/Dtors can be compiled to multiple functions,
therefore, their declaration cannot have one DW_AT_linkage_name.
The specific instances however can and should have that attribute.
This patch reorders the code in DwarfUnit::getOrCreateSubprogramDIE()
to emit linkage names for C/Dtors.
rdar://problem/
16362674.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206210
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 14 Apr 2014 21:12:15 +0000 (21:12 +0000)]
[cleanup] Run clang-format over most of YAMLParser.h to fix a bunch of
small formatting inconsistencies with the rest of LLVM and even this
file. I looked at all the changes and they seemed like just better
formatting.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206209
91177308-0d34-0410-b5e6-
96231b3b80d8
Louis Gerbarg [Mon, 14 Apr 2014 21:05:05 +0000 (21:05 +0000)]
Fix for codegen bug that could cause illegal cmn instruction generation
In rare cases the dead definition elimination pass code can cause illegal cmn
instructions when it replaces dead registers on instructions that use
unmaterialized frame indexes. This patch disables the dead definition
optimization for instructions which include frame index operands.
rdar://
16438284
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206208
91177308-0d34-0410-b5e6-
96231b3b80d8
Louis Gerbarg [Mon, 14 Apr 2014 21:05:02 +0000 (21:05 +0000)]
Add a flag to disable the ARM64DeadRegisterDefinitionsPass
This patch adds a -arm64-dead-def-elimination flag so that it is possible to
disable dead definition elimination. Includes test case.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206207
91177308-0d34-0410-b5e6-
96231b3b80d8
James Molloy [Mon, 14 Apr 2014 17:38:00 +0000 (17:38 +0000)]
[ARM64] Port over missing subtarget features, and CPU definitions from AArch64.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206198
91177308-0d34-0410-b5e6-
96231b3b80d8
James Molloy [Mon, 14 Apr 2014 17:37:53 +0000 (17:37 +0000)]
[ARM64] Add big endian target arm64_be.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206197
91177308-0d34-0410-b5e6-
96231b3b80d8
Kaelyn Takata [Mon, 14 Apr 2014 17:26:50 +0000 (17:26 +0000)]
Replace two calls to object::symbol_iterator::increment(), which had
been removed in r200442.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206196
91177308-0d34-0410-b5e6-
96231b3b80d8
Kaelyn Takata [Mon, 14 Apr 2014 17:21:50 +0000 (17:21 +0000)]
Remove a variable from r206192 that is only used in an assert.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206195
91177308-0d34-0410-b5e6-
96231b3b80d8
Akira Hatanaka [Mon, 14 Apr 2014 16:56:19 +0000 (16:56 +0000)]
Fix a bug in which BranchProbabilityInfo wasn't setting branch weights of basic blocks inside loops correctly.
Previously, BranchProbabilityInfo::calcLoopBranchHeuristics would determine the weights of basic blocks inside loops even when it didn't have enough information to estimate the branch probabilities correctly. This patch fixes the function to exit early if it doesn't see any exit edges or back edges and let the later heuristics determine the weights.
This fixes PR18705 and <rdar://problem/
15991090>.
Differential Revision: http://reviews.llvm.org/D3363
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206194
91177308-0d34-0410-b5e6-
96231b3b80d8
Richard Trieu [Mon, 14 Apr 2014 16:53:50 +0000 (16:53 +0000)]
Fix 2008-03-05-SxtInRegBug.ll so that the CHECK-NOT will not match the filename.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206193
91177308-0d34-0410-b5e6-
96231b3b80d8
Kaelyn Takata [Mon, 14 Apr 2014 16:50:22 +0000 (16:50 +0000)]
Fix up MCFixup::getAccessVariant to handle unary expressions.
This allows correct relocations to be generated for a symbolic
address that is being adjusted by a negative constant. Since r204294,
such expressions have triggered undefined behavior when LLVM was built
without assertions.
Credit goes to Rafael for this patch; I'm submitting it on his behalf
as he is on vacation this week.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206192
91177308-0d34-0410-b5e6-
96231b3b80d8
Saleem Abdulrasool [Mon, 14 Apr 2014 16:38:25 +0000 (16:38 +0000)]
tools: fix heap-buffer-overrun detected via ASAN
Once the auxiliary fields relating to the filename have been inspected, any
following auxiliary fields need not be visited as they have been consumed (the
following fields comprise the filepath as a single unit).
Adjust the test to catch this even if ASAN is not enabled.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206190
91177308-0d34-0410-b5e6-
96231b3b80d8
Daniel Sanders [Mon, 14 Apr 2014 16:24:12 +0000 (16:24 +0000)]
[mips] Fix fcopysign for MIPS-IV and add the test.
Summary:
This was another incorrect use of hasMips64() vs isGP64bit().
Depends on D3344
Reviewers: matheusalmeida, vmedic
Reviewed By: vmedic
Differential Revision: http://reviews.llvm.org/D3347
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206187
91177308-0d34-0410-b5e6-
96231b3b80d8
Daniel Sanders [Mon, 14 Apr 2014 16:00:28 +0000 (16:00 +0000)]
[mips] MIPS-IV is broadly the same as MIPS64 so duplicate all -mcpu=mips64 tests with -mcpu=mips4 as a starting point
Summary:
Two exceptions to this:
test/CodeGen/Mips/octeon.ll
test/CodeGen/Mips/octeon_popcnt.ll
these test extensions to MIPS64
One test is altered for MIPS-IV:
test/CodeGen/Mips/mips64countleading.ll
Tests dclo/dclz which were added in MIPS64. The MIPS-IV version tests
that dclo/dclz are not emitted.
Four tests fail and are not in this patch:
test/CodeGen/Mips/abicalls.ll
test/CodeGen/Mips/fcopysign-f32-f64.ll
test/CodeGen/Mips/fcopysign.ll
test/CodeGen/Mips/stack-alignment.ll
Depends on D3343
Reviewers: matheusalmeida, vmedic
Reviewed By: vmedic
Differential Revision: http://reviews.llvm.org/D3344
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206185
91177308-0d34-0410-b5e6-
96231b3b80d8
Daniel Sanders [Mon, 14 Apr 2014 15:44:42 +0000 (15:44 +0000)]
[mips] Fix more incorrect uses of HasMips64 and isMips64()
Summary:
- Conditional moves acting on 64-bit GPR's should require MIPS-IV rather than MIPS64
- ISD::MUL, and ISD::MULH[US] should be lowered on all 64-bit ISA's
Patch by David Chisnall
His work was sponsored by: DARPA, AFRL
I've added additional testcases to cover as much of the codegen changes
affecting MIPS-IV as I can. Where I've been unable to find an existing
MIPS64 testcase that can be re-used for MIPS-IV (mainly tests covering
ISD::GlobalAddress and similar), I at least agree that MIPS-IV should
behave like MIPS64. Further testcases that are fixed by this patch will follow
in my next commit. The testcases from that commit that fail for MIPS-IV without
this patch are:
LLVM :: CodeGen/Mips/2010-07-20-Switch.ll
LLVM :: CodeGen/Mips/cmov.ll
LLVM :: CodeGen/Mips/eh-dwarf-cfa.ll
LLVM :: CodeGen/Mips/largeimmprinting.ll
LLVM :: CodeGen/Mips/longbranch.ll
LLVM :: CodeGen/Mips/mips64-f128.ll
LLVM :: CodeGen/Mips/mips64directive.ll
LLVM :: CodeGen/Mips/mips64ext.ll
LLVM :: CodeGen/Mips/mips64fpldst.ll
LLVM :: CodeGen/Mips/mips64intldst.ll
LLVM :: CodeGen/Mips/mips64load-store-left-right.ll
LLVM :: CodeGen/Mips/sint-fp-store_pattern.ll
Reviewers: dsanders
Reviewed By: dsanders
CC: matheusalmeida
Differential Revision: http://reviews.llvm.org/D3343
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206183
91177308-0d34-0410-b5e6-
96231b3b80d8
James Molloy [Mon, 14 Apr 2014 13:54:16 +0000 (13:54 +0000)]
Teach llvm-lto to respect the given RelocModel.
Patch by Nick Tomlinson!
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206177
91177308-0d34-0410-b5e6-
96231b3b80d8
Tim Northover [Mon, 14 Apr 2014 13:18:48 +0000 (13:18 +0000)]
ARM64: specify full triple in tests to pacify Windows.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206175
91177308-0d34-0410-b5e6-
96231b3b80d8
Tim Northover [Mon, 14 Apr 2014 13:18:40 +0000 (13:18 +0000)]
AArch64: add newline to end of test files.
Should be no other change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206174
91177308-0d34-0410-b5e6-
96231b3b80d8
Tim Northover [Mon, 14 Apr 2014 12:59:52 +0000 (12:59 +0000)]
ARM64: remove buggy REV16 pattern.
The 32-bit pattern is still valid: 0123 -> 3210 -> 1032.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206172
91177308-0d34-0410-b5e6-
96231b3b80d8
Tim Northover [Mon, 14 Apr 2014 12:51:06 +0000 (12:51 +0000)]
AArch64/ARM64: enable directcond.ll test on ARM64.
Code change is because optimizeCompareInstr didn't know how to pull the
condition code out of FCSEL instructions.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206171
91177308-0d34-0410-b5e6-
96231b3b80d8
Tim Northover [Mon, 14 Apr 2014 12:51:02 +0000 (12:51 +0000)]
ARM64: add patterns for csXYZ with reversed operands.
AArch64 tests for this, and it's obviously a good idea. Have to invert the
condition code, of course.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206170
91177308-0d34-0410-b5e6-
96231b3b80d8
Tim Northover [Mon, 14 Apr 2014 12:50:58 +0000 (12:50 +0000)]
ARM64: enable more regression tests from AArch64
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206169
91177308-0d34-0410-b5e6-
96231b3b80d8
Tim Northover [Mon, 14 Apr 2014 12:50:50 +0000 (12:50 +0000)]
ARM64: add support for AArch64's addsub_ext.ll
There was one definite issue in ARM64 (the off-by-1 check for whether
a shift could be folded in) and one difference that is probably
correct: ARM64 didn't fold nodes with multiple uses into the
arithmetic operations unless optimising for code size.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206168
91177308-0d34-0410-b5e6-
96231b3b80d8
Tim Northover [Mon, 14 Apr 2014 12:50:47 +0000 (12:50 +0000)]
ARM64: optimise (cmp x, (sub 0, y)) to (cmn x, y).
This transformation is only valid when being used for an EQ or NE
comparison since the flags change otherwise.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206167
91177308-0d34-0410-b5e6-
96231b3b80d8
Tim Northover [Mon, 14 Apr 2014 12:50:41 +0000 (12:50 +0000)]
ARM64: start porting regression test suite from AArch64
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206166
91177308-0d34-0410-b5e6-
96231b3b80d8
Arnaud A. de Grandmaison [Mon, 14 Apr 2014 12:36:48 +0000 (12:36 +0000)]
Display the name of the project failing the url check in the release script
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206164
91177308-0d34-0410-b5e6-
96231b3b80d8
Richard Osborne [Mon, 14 Apr 2014 12:30:35 +0000 (12:30 +0000)]
[XCore] Don't create invalid MKMSK instructions inside loadImmediate().
Summary:
Previously loadImmediate() would produce MKMSK instructions with invalid
immediate values such as mkmsk r0, 9. Fix this by checking the mask size
is valid.
Reviewers: robertlytton
Reviewed By: robertlytton
CC: llvm-commits
Differential Revision: http://reviews.llvm.org/D3289
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206163
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Mon, 14 Apr 2014 07:03:13 +0000 (07:03 +0000)]
Whitespace.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206154
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Mon, 14 Apr 2014 07:02:57 +0000 (07:02 +0000)]
Revert r206045, "Fix shift by constants for vector."
It broke some builders, at least, i686.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206153
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 14 Apr 2014 06:42:56 +0000 (06:42 +0000)]
[Allocator] Hoist the external helper function into a namespace scope
declaration. GCC 4.7 appears to get hopelessly confused by declaring
this function within a member function of a class template. Go figure.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206152
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 14 Apr 2014 06:22:03 +0000 (06:22 +0000)]
[cleanup] Normalize YAMLParser.h's doxygen markers with '\foo' instead
of '@foo'. The slash variant is prefered in LLVM and the file was
already using a mixture. =/
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206151
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Mon, 14 Apr 2014 05:59:09 +0000 (05:59 +0000)]
Don't assert in BasicTTI::getMemoryOpCost for non-simple types
BasicTTI::getMemoryOpCost must explicitly check for non-simple types; setting
AllowUnknown=true with TLI->getSimpleValueType is not sufficient because, for
example, non-power-of-two vector types return non-simple EVTs (not MVT::Other).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206150
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 14 Apr 2014 05:11:27 +0000 (05:11 +0000)]
[Allocator] Make the underlying allocator a template instead of an
abstract interface. The only user of this functionality is the JIT
memory manager and it is quite happy to have a custom type here. This
removes a virtual function call and a lot of unnecessary abstraction
from the common case where this is just a *very* thin vaneer around
a call to malloc.
Hopefully still no functionality changed here. =]
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206149
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 14 Apr 2014 04:46:30 +0000 (04:46 +0000)]
Fix the compile from r206147 in release builds by moving a variable
declaration outside of #ifndef NDEBUG -- its used elsewhere. Sorry for
the noise.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206148
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 14 Apr 2014 03:55:11 +0000 (03:55 +0000)]
[Allocator] Switch the BumpPtrAllocator to use a vector of pointers to
slabs rather than embedding a singly linked list in the slabs
themselves. This has a few advantages:
- Better utilization of the slab's memory by not wasting 16-bytes at the
front.
- Simpler allocation strategy by not having a struct packed at the
front.
- Avoids paging every allocated slab in just to traverse them for
deallocating or dumping stats.
The latter is the really nice part. Folks have complained from time to
time bitterly that tearing down a BumpPtrAllocator, even if it doesn't
run any destructors, pages in all of the memory allocated. Now it won't.
=]
Also resolves a FIXME with the scaling of the slab sizes. The scaling
now disregards specially sized slabs for allocations larger than the
threshold.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206147
91177308-0d34-0410-b5e6-
96231b3b80d8
Saleem Abdulrasool [Mon, 14 Apr 2014 02:37:28 +0000 (02:37 +0000)]
tools: simplify symbol handling in objdump
Rather than switching behaviour on whether a previous symbol has an auxiliary
symbol record for the next count of elements, simply iterate over the auxiliary
symbols right after processing the current symbol entry. This makes the
behaviour much simpler to follow and similar to llvm-readobj and yaml2obj.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206146
91177308-0d34-0410-b5e6-
96231b3b80d8
Saleem Abdulrasool [Mon, 14 Apr 2014 02:37:23 +0000 (02:37 +0000)]
tools: address possible non-null terminated filenames
If a filename is a multiple of 18 characters, there will be no null-terminator.
This will result in an invalid access by the constructed StringRef. Add a test
case to exercise this and fix that handling. Address this same vulnerability in
llvm-readobj as well.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206145
91177308-0d34-0410-b5e6-
96231b3b80d8
Serge Pavlov [Mon, 14 Apr 2014 02:20:19 +0000 (02:20 +0000)]
Use APInt arithmetic, fixed typo. Thanks to Benjamin Kramer for noticing that.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206144
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Mon, 14 Apr 2014 01:11:34 +0000 (01:11 +0000)]
Add back some typecasts I accidentally lost in r206142.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206143
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Mon, 14 Apr 2014 00:51:57 +0000 (00:51 +0000)]
[C++11] More 'nullptr' conversion. In some cases just using a boolean check instead of comparing to nullptr.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206142
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Sun, 13 Apr 2014 23:02:40 +0000 (23:02 +0000)]
[PowerPC] [Constant Hoisting] Enable constant hoisting on PPC
Implements the various TTI functions to enable constant hoisting on PPC. The
only significant test-suite change is this:
MultiSource/Benchmarks/VersaBench/bmm/bmm - 20% speedup
(which essentially reverses the slowdown from r206120).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206141
91177308-0d34-0410-b5e6-
96231b3b80d8
Saleem Abdulrasool [Sun, 13 Apr 2014 22:54:15 +0000 (22:54 +0000)]
tools: remove duplication of coff_aux_file
Now that COFF::coff_aux_file is defined, use that rather than redefining the
type locally.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206140
91177308-0d34-0410-b5e6-
96231b3b80d8
Saleem Abdulrasool [Sun, 13 Apr 2014 22:54:11 +0000 (22:54 +0000)]
tools: avoid a string duplication
The auxiliary file records are contiguous and only contain the filename.
Construct a StringRef directly rather than copying to a temporary buffer.
Suggested by majnemer on IRC!
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206139
91177308-0d34-0410-b5e6-
96231b3b80d8
Saleem Abdulrasool [Sun, 13 Apr 2014 20:47:55 +0000 (20:47 +0000)]
MC: check machine magic when applying offset adjustments
The values for the relocation type can (and do) overlap across various
architectures. When performing an adjustment of the emitted relocation in the
final object file, check that the file magic matches the target for which the
relocation type is valid (e.g. a I386 relocation is only applied to an X86
object file, and an AMD64 relocation is only applied to an X86_64 object file).
This was noticed while adding support for ARM WinCOFF object file emission.
A test case for this is not really possible as the values for REL32 do not
overlap on I386 and AMD64, which is why this was never noticed in practice. The
ARM WinCOFF emission is not yet ready to merge into the tree.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206138
91177308-0d34-0410-b5e6-
96231b3b80d8
Serge Pavlov [Sun, 13 Apr 2014 18:23:41 +0000 (18:23 +0000)]
Recognize test for overflow in integer multiplication.
If multiplication involves zero-extended arguments and the result is
compared as in the patterns:
%mul32 = trunc i64 %mul64 to i32
%zext = zext i32 %mul32 to i64
%overflow = icmp ne i64 %mul64, %zext
or
%overflow = icmp ugt i64 %mul64 , 0xffffffff
then the multiplication may be replaced by call to umul.with.overflow.
This change fixes PR4917 and PR4918.
Differential Revision: http://llvm-reviews.chandlerc.com/D2814
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206137
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Sun, 13 Apr 2014 17:10:58 +0000 (17:10 +0000)]
[PowerPC] Fix rlwimi isel when mask is not constant
We had been using the known-zero values of the operand of the or to construct
the mask for an rlwimi; this is not quite correct, but fine when the mask is
constant. When the mask is constant, then the known zeros of the operand must
be a superset of the zeros in the mask. However, when the mask is not a
constant, then there might be bits in the operand that are not known to be zero
that, at runtime, might be zero in the mask. Therefore, we check that any bits
not known to be zero *are* known to be one in the mask. Otherwise, we can't
fold the mask with the or and shift.
This was revealed as a miscompile of
MultiSource/Benchmarks/BitBench/drop3/drop3 when I started experimenting with
constant hoisting.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206136
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Sun, 13 Apr 2014 06:39:55 +0000 (06:39 +0000)]
Fix instruction debug info location during legalization
I found this from a particular GDB test suite case of inlining
(something similar is provided as a test case) but came across a few
other related cases (other callers of the same functions, and one other
instance of the same coding mistake in a separate function).
I'm not sure what the best way to test this is (let alone to cover the
other cases I discovered), so hopefully this sufficies - open to ideas.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206130
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sun, 13 Apr 2014 04:57:38 +0000 (04:57 +0000)]
[C++11] More 'nullptr' conversion or in some cases just using a boolean check instead of comparing to nullptr.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206129
91177308-0d34-0410-b5e6-
96231b3b80d8
Lang Hames [Sun, 13 Apr 2014 04:09:16 +0000 (04:09 +0000)]
[X86] unique_ptr'ify one of X86GenericDisassembler's members.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206127
91177308-0d34-0410-b5e6-
96231b3b80d8
Saleem Abdulrasool [Sun, 13 Apr 2014 03:11:08 +0000 (03:11 +0000)]
tools: teach objdump about FILE aux records
Add support for file auxiliary symbol entries in COFF symbol tables. A COFF
symbol table with a FILE entry is followed by sizeof(__FILE__) / 18 auxiliary
symbol records which contain the filename. Read them and form the original
filename that the record contains. Then display the name in the output.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206126
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Sat, 12 Apr 2014 21:52:38 +0000 (21:52 +0000)]
[PowerPC] Implement some additional TLI callbacks
Add implementations of:
bool isLegalICmpImmediate(int64_t Imm) const
bool isLegalAddImmediate(int64_t Imm) const
bool isTruncateFree(Type *Ty1, Type *Ty2) const
bool isTruncateFree(EVT VT1, EVT VT2) const
bool shouldConvertConstantLoadToIntImm(const APInt &Imm, Type *Ty) const
Unfortunately, this regresses counter-register-based loop formation because
some of the loops now end up in forms were SE cannot compute loop counts.
However, nevertheless, the test-suite results favor committing:
SingleSource/Benchmarks/BenchmarkGame/puzzle: 26% speedup
MultiSource/Benchmarks/FreeBench/analyzer/analyzer: 21% speedup
MultiSource/Benchmarks/MiBench/automotive-susan/automotive-susan: 20% speedup
SingleSource/Benchmarks/Polybench/linear-algebra/kernels/trisolv/trisolv: 19% speedup
SingleSource/Benchmarks/Polybench/linear-algebra/kernels/gesummv/gesummv: 15% speedup
MultiSource/Benchmarks/FreeBench/pcompress2/pcompress2: 2% speedup
MultiSource/Benchmarks/VersaBench/bmm/bmm: 26% slowdown
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206120
91177308-0d34-0410-b5e6-
96231b3b80d8
Joerg Sonnenberger [Sat, 12 Apr 2014 21:13:41 +0000 (21:13 +0000)]
Fix test syntax to work with non-bash /bin/sh.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206119
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Sat, 12 Apr 2014 18:45:24 +0000 (18:45 +0000)]
Spell the specialization namespace correctly.
Not sure why clang didn't diagnose this (GCC does).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206117
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Sat, 12 Apr 2014 18:39:57 +0000 (18:39 +0000)]
Make helper static and place random global into the llvm namespace.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206116
91177308-0d34-0410-b5e6-
96231b3b80d8
Saleem Abdulrasool [Sat, 12 Apr 2014 18:04:27 +0000 (18:04 +0000)]
tools: remove unnecessary copy of array_lengthof
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206115
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Sat, 12 Apr 2014 16:15:53 +0000 (16:15 +0000)]
Retire llvm::array_endof in favor of non-member std::end.
While there make array_lengthof constexpr if we have support for it.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206112
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Sat, 12 Apr 2014 14:26:59 +0000 (14:26 +0000)]
Move MDBuilder's methods out of line.
Making them inline was a historical accident, they're neither hot nor
templated.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206109
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Sat, 12 Apr 2014 05:35:59 +0000 (05:35 +0000)]
PR13337: Omit DW_TAG_restrict_type when compiling for DWARF2
DWARF3 introduced DW_TAG_restrict_type, so avoid using it in prior
versions.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206105
91177308-0d34-0410-b5e6-
96231b3b80d8
Richard Trieu [Sat, 12 Apr 2014 04:47:04 +0000 (04:47 +0000)]
Add extra checks to mvn.ll test to prevent the "f1" check from matching
on a directory name instead of the function name.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206104
91177308-0d34-0410-b5e6-
96231b3b80d8
Adrian Prantl [Sat, 12 Apr 2014 04:25:02 +0000 (04:25 +0000)]
Revert "Debug info: (bugfix) C++ C/Dtors can be compiled to multiple functions,"
This reverts commit 206096 while I investigate why this broke the gdb
buildbot.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206103
91177308-0d34-0410-b5e6-
96231b3b80d8
Juergen Ributzka [Sat, 12 Apr 2014 02:53:51 +0000 (02:53 +0000)]
[ARM64] Never hoist the shift value of a shift instruction.
There is no need to check if we want to hoist the immediate value of an
shift instruction. Simply return TCC_Free right away.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206101
91177308-0d34-0410-b5e6-
96231b3b80d8
Juergen Ributzka [Sat, 12 Apr 2014 02:36:28 +0000 (02:36 +0000)]
[ARM64] Fix the cost model for cheap large constants.
Originally the cost model would give up for large constants and just return the
maximum cost. This is not what we want for constant hoisting, because some of
these constants are large in bitwidth, but are still cheap to materialize.
This commit fixes the cost model to either return TCC_Free if the cost cannot be
determined, or accurately calculate the cost even for large constants
(bitwidth > 128).
This fixes <rdar://problem/
16591573>.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206100
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Sat, 12 Apr 2014 02:24:04 +0000 (02:24 +0000)]
Use dwarf::Tag rather than unsigned for DIE::Tag to make debugging easier.
Nice to be able to just print out the Tag and have the debugger print
dwarf::DW_TAG_subprogram or whatever, rather than an int.
It's a bit finicky (for example DIDescriptor::getTag still returns
unsigned) because some places still handle real dwarf tags + our fake
tags (one day we'll remove the fake tags, hopefully).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206098
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Sat, 12 Apr 2014 02:09:17 +0000 (02:09 +0000)]
Remove documentation for a deleted pass.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206097
91177308-0d34-0410-b5e6-
96231b3b80d8
Adrian Prantl [Sat, 12 Apr 2014 01:44:42 +0000 (01:44 +0000)]
Debug info: (bugfix) C++ C/Dtors can be compiled to multiple functions,
therefore, their declaration cannot have one DW_AT_linkage_name.
The specific instances however can and should have that attribute.
This patch reorders the code in DwarfUnit::getOrCreateSubprogramDIE()
to emit linkage names for C/Dtors.
rdar://problem/
16362674.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206096
91177308-0d34-0410-b5e6-
96231b3b80d8
Jim Grosbach [Sat, 12 Apr 2014 01:34:31 +0000 (01:34 +0000)]
llc: Add support for -mcpu=native.
When -mcpu=native is passed, autodetect the host CPU and pass that
as the CPU name to the TargetMachine factory method.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206095
91177308-0d34-0410-b5e6-
96231b3b80d8
Jim Grosbach [Sat, 12 Apr 2014 01:34:29 +0000 (01:34 +0000)]
X86: Remove TargetMachine CPU auto-detection.
This logic is properly in the realm of whatever is creating the
TargetMachine. This makes plain 'llc foo.ll' consistent across
heterogenous machines.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206094
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Sat, 12 Apr 2014 01:26:00 +0000 (01:26 +0000)]
Reenable use of TBAA during CodeGen
We had disabled use of TBAA during CodeGen (even when otherwise using AA)
because the ptrtoint/inttoptr used by CGP for address sinking caused BasicAA to
miss basic type punning that it should catch (and, thus, we'd fail to override
TBAA when we should).
However, when AA is in use during CodeGen, CGP now uses normal GEPs and
bitcasts, instead of ptrtoint/inttoptr, when doing address sinking. As a
result, BasicAA should be able to make us do the right thing in the face of
type-punning, and it seems safe to enable use of TBAA again. self-hosting seems
fine on PPC64/Linux on the P7, with TBAA enabled and -misched=shuffle.
Note: We still don't update TBAA when merging stack slots, although because
BasicAA should now catch all such cases, this is no longer a blocking issue.
Nevertheless, I plan to commit code to deal with this properly in the near
future.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206093
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Sat, 12 Apr 2014 00:59:48 +0000 (00:59 +0000)]
Add the ability to use GEPs for address sinking in CGP
The current memory-instruction optimization logic in CGP, which sinks parts of
the address computation that can be adsorbed by the addressing mode, does this
by explicitly converting the relevant part of the address computation into
IR-level integer operations (making use of ptrtoint and inttoptr). For most
targets this is currently not a problem, but for targets wishing to make use of
IR-level aliasing analysis during CodeGen, the use of ptrtoint/inttoptr is a
problem for two reasons:
1. BasicAA becomes less powerful in the face of the ptrtoint/inttoptr
2. In cases where type-punning was used, and BasicAA was used
to override TBAA, BasicAA may no longer do so. (this had forced us to disable
all use of TBAA in CodeGen; something which we can now enable again)
This (use of GEPs instead of ptrtoint/inttoptr) is not currently enabled by
default (except for those targets that use AA during CodeGen), and so aside
from some PowerPC subtargets and SystemZ, there should be no change in
behavior. We may be able to switch completely away from the ptrtoint/inttoptr
sinking on all targets, but further testing is required.
I've doubled-up on a number of existing tests that are sensitive to the
address sinking behavior (including some store-merging tests that are
sensitive to the order of the resulting ADD operations at the SDAG level).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206092
91177308-0d34-0410-b5e6-
96231b3b80d8
Chad Rosier [Sat, 12 Apr 2014 00:14:23 +0000 (00:14 +0000)]
[AArch64] Implement the isLegalAddressingMode and getScalingFactorCost APIs.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206089
91177308-0d34-0410-b5e6-
96231b3b80d8