Kaelyn Takata [Mon, 14 Apr 2014 16:50:22 +0000 (16:50 +0000)]
Fix up MCFixup::getAccessVariant to handle unary expressions.
This allows correct relocations to be generated for a symbolic
address that is being adjusted by a negative constant. Since r204294,
such expressions have triggered undefined behavior when LLVM was built
without assertions.
Credit goes to Rafael for this patch; I'm submitting it on his behalf
as he is on vacation this week.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206192
91177308-0d34-0410-b5e6-
96231b3b80d8
Saleem Abdulrasool [Mon, 14 Apr 2014 16:38:25 +0000 (16:38 +0000)]
tools: fix heap-buffer-overrun detected via ASAN
Once the auxiliary fields relating to the filename have been inspected, any
following auxiliary fields need not be visited as they have been consumed (the
following fields comprise the filepath as a single unit).
Adjust the test to catch this even if ASAN is not enabled.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206190
91177308-0d34-0410-b5e6-
96231b3b80d8
Daniel Sanders [Mon, 14 Apr 2014 16:24:12 +0000 (16:24 +0000)]
[mips] Fix fcopysign for MIPS-IV and add the test.
Summary:
This was another incorrect use of hasMips64() vs isGP64bit().
Depends on D3344
Reviewers: matheusalmeida, vmedic
Reviewed By: vmedic
Differential Revision: http://reviews.llvm.org/D3347
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206187
91177308-0d34-0410-b5e6-
96231b3b80d8
Daniel Sanders [Mon, 14 Apr 2014 16:00:28 +0000 (16:00 +0000)]
[mips] MIPS-IV is broadly the same as MIPS64 so duplicate all -mcpu=mips64 tests with -mcpu=mips4 as a starting point
Summary:
Two exceptions to this:
test/CodeGen/Mips/octeon.ll
test/CodeGen/Mips/octeon_popcnt.ll
these test extensions to MIPS64
One test is altered for MIPS-IV:
test/CodeGen/Mips/mips64countleading.ll
Tests dclo/dclz which were added in MIPS64. The MIPS-IV version tests
that dclo/dclz are not emitted.
Four tests fail and are not in this patch:
test/CodeGen/Mips/abicalls.ll
test/CodeGen/Mips/fcopysign-f32-f64.ll
test/CodeGen/Mips/fcopysign.ll
test/CodeGen/Mips/stack-alignment.ll
Depends on D3343
Reviewers: matheusalmeida, vmedic
Reviewed By: vmedic
Differential Revision: http://reviews.llvm.org/D3344
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206185
91177308-0d34-0410-b5e6-
96231b3b80d8
Daniel Sanders [Mon, 14 Apr 2014 15:44:42 +0000 (15:44 +0000)]
[mips] Fix more incorrect uses of HasMips64 and isMips64()
Summary:
- Conditional moves acting on 64-bit GPR's should require MIPS-IV rather than MIPS64
- ISD::MUL, and ISD::MULH[US] should be lowered on all 64-bit ISA's
Patch by David Chisnall
His work was sponsored by: DARPA, AFRL
I've added additional testcases to cover as much of the codegen changes
affecting MIPS-IV as I can. Where I've been unable to find an existing
MIPS64 testcase that can be re-used for MIPS-IV (mainly tests covering
ISD::GlobalAddress and similar), I at least agree that MIPS-IV should
behave like MIPS64. Further testcases that are fixed by this patch will follow
in my next commit. The testcases from that commit that fail for MIPS-IV without
this patch are:
LLVM :: CodeGen/Mips/2010-07-20-Switch.ll
LLVM :: CodeGen/Mips/cmov.ll
LLVM :: CodeGen/Mips/eh-dwarf-cfa.ll
LLVM :: CodeGen/Mips/largeimmprinting.ll
LLVM :: CodeGen/Mips/longbranch.ll
LLVM :: CodeGen/Mips/mips64-f128.ll
LLVM :: CodeGen/Mips/mips64directive.ll
LLVM :: CodeGen/Mips/mips64ext.ll
LLVM :: CodeGen/Mips/mips64fpldst.ll
LLVM :: CodeGen/Mips/mips64intldst.ll
LLVM :: CodeGen/Mips/mips64load-store-left-right.ll
LLVM :: CodeGen/Mips/sint-fp-store_pattern.ll
Reviewers: dsanders
Reviewed By: dsanders
CC: matheusalmeida
Differential Revision: http://reviews.llvm.org/D3343
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206183
91177308-0d34-0410-b5e6-
96231b3b80d8
James Molloy [Mon, 14 Apr 2014 13:54:16 +0000 (13:54 +0000)]
Teach llvm-lto to respect the given RelocModel.
Patch by Nick Tomlinson!
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206177
91177308-0d34-0410-b5e6-
96231b3b80d8
Tim Northover [Mon, 14 Apr 2014 13:18:48 +0000 (13:18 +0000)]
ARM64: specify full triple in tests to pacify Windows.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206175
91177308-0d34-0410-b5e6-
96231b3b80d8
Tim Northover [Mon, 14 Apr 2014 13:18:40 +0000 (13:18 +0000)]
AArch64: add newline to end of test files.
Should be no other change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206174
91177308-0d34-0410-b5e6-
96231b3b80d8
Tim Northover [Mon, 14 Apr 2014 12:59:52 +0000 (12:59 +0000)]
ARM64: remove buggy REV16 pattern.
The 32-bit pattern is still valid: 0123 -> 3210 -> 1032.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206172
91177308-0d34-0410-b5e6-
96231b3b80d8
Tim Northover [Mon, 14 Apr 2014 12:51:06 +0000 (12:51 +0000)]
AArch64/ARM64: enable directcond.ll test on ARM64.
Code change is because optimizeCompareInstr didn't know how to pull the
condition code out of FCSEL instructions.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206171
91177308-0d34-0410-b5e6-
96231b3b80d8
Tim Northover [Mon, 14 Apr 2014 12:51:02 +0000 (12:51 +0000)]
ARM64: add patterns for csXYZ with reversed operands.
AArch64 tests for this, and it's obviously a good idea. Have to invert the
condition code, of course.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206170
91177308-0d34-0410-b5e6-
96231b3b80d8
Tim Northover [Mon, 14 Apr 2014 12:50:58 +0000 (12:50 +0000)]
ARM64: enable more regression tests from AArch64
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206169
91177308-0d34-0410-b5e6-
96231b3b80d8
Tim Northover [Mon, 14 Apr 2014 12:50:50 +0000 (12:50 +0000)]
ARM64: add support for AArch64's addsub_ext.ll
There was one definite issue in ARM64 (the off-by-1 check for whether
a shift could be folded in) and one difference that is probably
correct: ARM64 didn't fold nodes with multiple uses into the
arithmetic operations unless optimising for code size.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206168
91177308-0d34-0410-b5e6-
96231b3b80d8
Tim Northover [Mon, 14 Apr 2014 12:50:47 +0000 (12:50 +0000)]
ARM64: optimise (cmp x, (sub 0, y)) to (cmn x, y).
This transformation is only valid when being used for an EQ or NE
comparison since the flags change otherwise.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206167
91177308-0d34-0410-b5e6-
96231b3b80d8
Tim Northover [Mon, 14 Apr 2014 12:50:41 +0000 (12:50 +0000)]
ARM64: start porting regression test suite from AArch64
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206166
91177308-0d34-0410-b5e6-
96231b3b80d8
Arnaud A. de Grandmaison [Mon, 14 Apr 2014 12:36:48 +0000 (12:36 +0000)]
Display the name of the project failing the url check in the release script
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206164
91177308-0d34-0410-b5e6-
96231b3b80d8
Richard Osborne [Mon, 14 Apr 2014 12:30:35 +0000 (12:30 +0000)]
[XCore] Don't create invalid MKMSK instructions inside loadImmediate().
Summary:
Previously loadImmediate() would produce MKMSK instructions with invalid
immediate values such as mkmsk r0, 9. Fix this by checking the mask size
is valid.
Reviewers: robertlytton
Reviewed By: robertlytton
CC: llvm-commits
Differential Revision: http://reviews.llvm.org/D3289
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206163
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Mon, 14 Apr 2014 07:03:13 +0000 (07:03 +0000)]
Whitespace.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206154
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Mon, 14 Apr 2014 07:02:57 +0000 (07:02 +0000)]
Revert r206045, "Fix shift by constants for vector."
It broke some builders, at least, i686.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206153
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 14 Apr 2014 06:42:56 +0000 (06:42 +0000)]
[Allocator] Hoist the external helper function into a namespace scope
declaration. GCC 4.7 appears to get hopelessly confused by declaring
this function within a member function of a class template. Go figure.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206152
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 14 Apr 2014 06:22:03 +0000 (06:22 +0000)]
[cleanup] Normalize YAMLParser.h's doxygen markers with '\foo' instead
of '@foo'. The slash variant is prefered in LLVM and the file was
already using a mixture. =/
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206151
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Mon, 14 Apr 2014 05:59:09 +0000 (05:59 +0000)]
Don't assert in BasicTTI::getMemoryOpCost for non-simple types
BasicTTI::getMemoryOpCost must explicitly check for non-simple types; setting
AllowUnknown=true with TLI->getSimpleValueType is not sufficient because, for
example, non-power-of-two vector types return non-simple EVTs (not MVT::Other).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206150
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 14 Apr 2014 05:11:27 +0000 (05:11 +0000)]
[Allocator] Make the underlying allocator a template instead of an
abstract interface. The only user of this functionality is the JIT
memory manager and it is quite happy to have a custom type here. This
removes a virtual function call and a lot of unnecessary abstraction
from the common case where this is just a *very* thin vaneer around
a call to malloc.
Hopefully still no functionality changed here. =]
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206149
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 14 Apr 2014 04:46:30 +0000 (04:46 +0000)]
Fix the compile from r206147 in release builds by moving a variable
declaration outside of #ifndef NDEBUG -- its used elsewhere. Sorry for
the noise.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206148
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 14 Apr 2014 03:55:11 +0000 (03:55 +0000)]
[Allocator] Switch the BumpPtrAllocator to use a vector of pointers to
slabs rather than embedding a singly linked list in the slabs
themselves. This has a few advantages:
- Better utilization of the slab's memory by not wasting 16-bytes at the
front.
- Simpler allocation strategy by not having a struct packed at the
front.
- Avoids paging every allocated slab in just to traverse them for
deallocating or dumping stats.
The latter is the really nice part. Folks have complained from time to
time bitterly that tearing down a BumpPtrAllocator, even if it doesn't
run any destructors, pages in all of the memory allocated. Now it won't.
=]
Also resolves a FIXME with the scaling of the slab sizes. The scaling
now disregards specially sized slabs for allocations larger than the
threshold.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206147
91177308-0d34-0410-b5e6-
96231b3b80d8
Saleem Abdulrasool [Mon, 14 Apr 2014 02:37:28 +0000 (02:37 +0000)]
tools: simplify symbol handling in objdump
Rather than switching behaviour on whether a previous symbol has an auxiliary
symbol record for the next count of elements, simply iterate over the auxiliary
symbols right after processing the current symbol entry. This makes the
behaviour much simpler to follow and similar to llvm-readobj and yaml2obj.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206146
91177308-0d34-0410-b5e6-
96231b3b80d8
Saleem Abdulrasool [Mon, 14 Apr 2014 02:37:23 +0000 (02:37 +0000)]
tools: address possible non-null terminated filenames
If a filename is a multiple of 18 characters, there will be no null-terminator.
This will result in an invalid access by the constructed StringRef. Add a test
case to exercise this and fix that handling. Address this same vulnerability in
llvm-readobj as well.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206145
91177308-0d34-0410-b5e6-
96231b3b80d8
Serge Pavlov [Mon, 14 Apr 2014 02:20:19 +0000 (02:20 +0000)]
Use APInt arithmetic, fixed typo. Thanks to Benjamin Kramer for noticing that.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206144
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Mon, 14 Apr 2014 01:11:34 +0000 (01:11 +0000)]
Add back some typecasts I accidentally lost in r206142.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206143
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Mon, 14 Apr 2014 00:51:57 +0000 (00:51 +0000)]
[C++11] More 'nullptr' conversion. In some cases just using a boolean check instead of comparing to nullptr.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206142
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Sun, 13 Apr 2014 23:02:40 +0000 (23:02 +0000)]
[PowerPC] [Constant Hoisting] Enable constant hoisting on PPC
Implements the various TTI functions to enable constant hoisting on PPC. The
only significant test-suite change is this:
MultiSource/Benchmarks/VersaBench/bmm/bmm - 20% speedup
(which essentially reverses the slowdown from r206120).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206141
91177308-0d34-0410-b5e6-
96231b3b80d8
Saleem Abdulrasool [Sun, 13 Apr 2014 22:54:15 +0000 (22:54 +0000)]
tools: remove duplication of coff_aux_file
Now that COFF::coff_aux_file is defined, use that rather than redefining the
type locally.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206140
91177308-0d34-0410-b5e6-
96231b3b80d8
Saleem Abdulrasool [Sun, 13 Apr 2014 22:54:11 +0000 (22:54 +0000)]
tools: avoid a string duplication
The auxiliary file records are contiguous and only contain the filename.
Construct a StringRef directly rather than copying to a temporary buffer.
Suggested by majnemer on IRC!
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206139
91177308-0d34-0410-b5e6-
96231b3b80d8
Saleem Abdulrasool [Sun, 13 Apr 2014 20:47:55 +0000 (20:47 +0000)]
MC: check machine magic when applying offset adjustments
The values for the relocation type can (and do) overlap across various
architectures. When performing an adjustment of the emitted relocation in the
final object file, check that the file magic matches the target for which the
relocation type is valid (e.g. a I386 relocation is only applied to an X86
object file, and an AMD64 relocation is only applied to an X86_64 object file).
This was noticed while adding support for ARM WinCOFF object file emission.
A test case for this is not really possible as the values for REL32 do not
overlap on I386 and AMD64, which is why this was never noticed in practice. The
ARM WinCOFF emission is not yet ready to merge into the tree.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206138
91177308-0d34-0410-b5e6-
96231b3b80d8
Serge Pavlov [Sun, 13 Apr 2014 18:23:41 +0000 (18:23 +0000)]
Recognize test for overflow in integer multiplication.
If multiplication involves zero-extended arguments and the result is
compared as in the patterns:
%mul32 = trunc i64 %mul64 to i32
%zext = zext i32 %mul32 to i64
%overflow = icmp ne i64 %mul64, %zext
or
%overflow = icmp ugt i64 %mul64 , 0xffffffff
then the multiplication may be replaced by call to umul.with.overflow.
This change fixes PR4917 and PR4918.
Differential Revision: http://llvm-reviews.chandlerc.com/D2814
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206137
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Sun, 13 Apr 2014 17:10:58 +0000 (17:10 +0000)]
[PowerPC] Fix rlwimi isel when mask is not constant
We had been using the known-zero values of the operand of the or to construct
the mask for an rlwimi; this is not quite correct, but fine when the mask is
constant. When the mask is constant, then the known zeros of the operand must
be a superset of the zeros in the mask. However, when the mask is not a
constant, then there might be bits in the operand that are not known to be zero
that, at runtime, might be zero in the mask. Therefore, we check that any bits
not known to be zero *are* known to be one in the mask. Otherwise, we can't
fold the mask with the or and shift.
This was revealed as a miscompile of
MultiSource/Benchmarks/BitBench/drop3/drop3 when I started experimenting with
constant hoisting.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206136
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Sun, 13 Apr 2014 06:39:55 +0000 (06:39 +0000)]
Fix instruction debug info location during legalization
I found this from a particular GDB test suite case of inlining
(something similar is provided as a test case) but came across a few
other related cases (other callers of the same functions, and one other
instance of the same coding mistake in a separate function).
I'm not sure what the best way to test this is (let alone to cover the
other cases I discovered), so hopefully this sufficies - open to ideas.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206130
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sun, 13 Apr 2014 04:57:38 +0000 (04:57 +0000)]
[C++11] More 'nullptr' conversion or in some cases just using a boolean check instead of comparing to nullptr.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206129
91177308-0d34-0410-b5e6-
96231b3b80d8
Lang Hames [Sun, 13 Apr 2014 04:09:16 +0000 (04:09 +0000)]
[X86] unique_ptr'ify one of X86GenericDisassembler's members.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206127
91177308-0d34-0410-b5e6-
96231b3b80d8
Saleem Abdulrasool [Sun, 13 Apr 2014 03:11:08 +0000 (03:11 +0000)]
tools: teach objdump about FILE aux records
Add support for file auxiliary symbol entries in COFF symbol tables. A COFF
symbol table with a FILE entry is followed by sizeof(__FILE__) / 18 auxiliary
symbol records which contain the filename. Read them and form the original
filename that the record contains. Then display the name in the output.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206126
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Sat, 12 Apr 2014 21:52:38 +0000 (21:52 +0000)]
[PowerPC] Implement some additional TLI callbacks
Add implementations of:
bool isLegalICmpImmediate(int64_t Imm) const
bool isLegalAddImmediate(int64_t Imm) const
bool isTruncateFree(Type *Ty1, Type *Ty2) const
bool isTruncateFree(EVT VT1, EVT VT2) const
bool shouldConvertConstantLoadToIntImm(const APInt &Imm, Type *Ty) const
Unfortunately, this regresses counter-register-based loop formation because
some of the loops now end up in forms were SE cannot compute loop counts.
However, nevertheless, the test-suite results favor committing:
SingleSource/Benchmarks/BenchmarkGame/puzzle: 26% speedup
MultiSource/Benchmarks/FreeBench/analyzer/analyzer: 21% speedup
MultiSource/Benchmarks/MiBench/automotive-susan/automotive-susan: 20% speedup
SingleSource/Benchmarks/Polybench/linear-algebra/kernels/trisolv/trisolv: 19% speedup
SingleSource/Benchmarks/Polybench/linear-algebra/kernels/gesummv/gesummv: 15% speedup
MultiSource/Benchmarks/FreeBench/pcompress2/pcompress2: 2% speedup
MultiSource/Benchmarks/VersaBench/bmm/bmm: 26% slowdown
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206120
91177308-0d34-0410-b5e6-
96231b3b80d8
Joerg Sonnenberger [Sat, 12 Apr 2014 21:13:41 +0000 (21:13 +0000)]
Fix test syntax to work with non-bash /bin/sh.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206119
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Sat, 12 Apr 2014 18:45:24 +0000 (18:45 +0000)]
Spell the specialization namespace correctly.
Not sure why clang didn't diagnose this (GCC does).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206117
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Sat, 12 Apr 2014 18:39:57 +0000 (18:39 +0000)]
Make helper static and place random global into the llvm namespace.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206116
91177308-0d34-0410-b5e6-
96231b3b80d8
Saleem Abdulrasool [Sat, 12 Apr 2014 18:04:27 +0000 (18:04 +0000)]
tools: remove unnecessary copy of array_lengthof
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206115
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Sat, 12 Apr 2014 16:15:53 +0000 (16:15 +0000)]
Retire llvm::array_endof in favor of non-member std::end.
While there make array_lengthof constexpr if we have support for it.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206112
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Sat, 12 Apr 2014 14:26:59 +0000 (14:26 +0000)]
Move MDBuilder's methods out of line.
Making them inline was a historical accident, they're neither hot nor
templated.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206109
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Sat, 12 Apr 2014 05:35:59 +0000 (05:35 +0000)]
PR13337: Omit DW_TAG_restrict_type when compiling for DWARF2
DWARF3 introduced DW_TAG_restrict_type, so avoid using it in prior
versions.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206105
91177308-0d34-0410-b5e6-
96231b3b80d8
Richard Trieu [Sat, 12 Apr 2014 04:47:04 +0000 (04:47 +0000)]
Add extra checks to mvn.ll test to prevent the "f1" check from matching
on a directory name instead of the function name.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206104
91177308-0d34-0410-b5e6-
96231b3b80d8
Adrian Prantl [Sat, 12 Apr 2014 04:25:02 +0000 (04:25 +0000)]
Revert "Debug info: (bugfix) C++ C/Dtors can be compiled to multiple functions,"
This reverts commit 206096 while I investigate why this broke the gdb
buildbot.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206103
91177308-0d34-0410-b5e6-
96231b3b80d8
Juergen Ributzka [Sat, 12 Apr 2014 02:53:51 +0000 (02:53 +0000)]
[ARM64] Never hoist the shift value of a shift instruction.
There is no need to check if we want to hoist the immediate value of an
shift instruction. Simply return TCC_Free right away.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206101
91177308-0d34-0410-b5e6-
96231b3b80d8
Juergen Ributzka [Sat, 12 Apr 2014 02:36:28 +0000 (02:36 +0000)]
[ARM64] Fix the cost model for cheap large constants.
Originally the cost model would give up for large constants and just return the
maximum cost. This is not what we want for constant hoisting, because some of
these constants are large in bitwidth, but are still cheap to materialize.
This commit fixes the cost model to either return TCC_Free if the cost cannot be
determined, or accurately calculate the cost even for large constants
(bitwidth > 128).
This fixes <rdar://problem/
16591573>.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206100
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Sat, 12 Apr 2014 02:24:04 +0000 (02:24 +0000)]
Use dwarf::Tag rather than unsigned for DIE::Tag to make debugging easier.
Nice to be able to just print out the Tag and have the debugger print
dwarf::DW_TAG_subprogram or whatever, rather than an int.
It's a bit finicky (for example DIDescriptor::getTag still returns
unsigned) because some places still handle real dwarf tags + our fake
tags (one day we'll remove the fake tags, hopefully).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206098
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Sat, 12 Apr 2014 02:09:17 +0000 (02:09 +0000)]
Remove documentation for a deleted pass.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206097
91177308-0d34-0410-b5e6-
96231b3b80d8
Adrian Prantl [Sat, 12 Apr 2014 01:44:42 +0000 (01:44 +0000)]
Debug info: (bugfix) C++ C/Dtors can be compiled to multiple functions,
therefore, their declaration cannot have one DW_AT_linkage_name.
The specific instances however can and should have that attribute.
This patch reorders the code in DwarfUnit::getOrCreateSubprogramDIE()
to emit linkage names for C/Dtors.
rdar://problem/
16362674.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206096
91177308-0d34-0410-b5e6-
96231b3b80d8
Jim Grosbach [Sat, 12 Apr 2014 01:34:31 +0000 (01:34 +0000)]
llc: Add support for -mcpu=native.
When -mcpu=native is passed, autodetect the host CPU and pass that
as the CPU name to the TargetMachine factory method.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206095
91177308-0d34-0410-b5e6-
96231b3b80d8
Jim Grosbach [Sat, 12 Apr 2014 01:34:29 +0000 (01:34 +0000)]
X86: Remove TargetMachine CPU auto-detection.
This logic is properly in the realm of whatever is creating the
TargetMachine. This makes plain 'llc foo.ll' consistent across
heterogenous machines.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206094
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Sat, 12 Apr 2014 01:26:00 +0000 (01:26 +0000)]
Reenable use of TBAA during CodeGen
We had disabled use of TBAA during CodeGen (even when otherwise using AA)
because the ptrtoint/inttoptr used by CGP for address sinking caused BasicAA to
miss basic type punning that it should catch (and, thus, we'd fail to override
TBAA when we should).
However, when AA is in use during CodeGen, CGP now uses normal GEPs and
bitcasts, instead of ptrtoint/inttoptr, when doing address sinking. As a
result, BasicAA should be able to make us do the right thing in the face of
type-punning, and it seems safe to enable use of TBAA again. self-hosting seems
fine on PPC64/Linux on the P7, with TBAA enabled and -misched=shuffle.
Note: We still don't update TBAA when merging stack slots, although because
BasicAA should now catch all such cases, this is no longer a blocking issue.
Nevertheless, I plan to commit code to deal with this properly in the near
future.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206093
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Sat, 12 Apr 2014 00:59:48 +0000 (00:59 +0000)]
Add the ability to use GEPs for address sinking in CGP
The current memory-instruction optimization logic in CGP, which sinks parts of
the address computation that can be adsorbed by the addressing mode, does this
by explicitly converting the relevant part of the address computation into
IR-level integer operations (making use of ptrtoint and inttoptr). For most
targets this is currently not a problem, but for targets wishing to make use of
IR-level aliasing analysis during CodeGen, the use of ptrtoint/inttoptr is a
problem for two reasons:
1. BasicAA becomes less powerful in the face of the ptrtoint/inttoptr
2. In cases where type-punning was used, and BasicAA was used
to override TBAA, BasicAA may no longer do so. (this had forced us to disable
all use of TBAA in CodeGen; something which we can now enable again)
This (use of GEPs instead of ptrtoint/inttoptr) is not currently enabled by
default (except for those targets that use AA during CodeGen), and so aside
from some PowerPC subtargets and SystemZ, there should be no change in
behavior. We may be able to switch completely away from the ptrtoint/inttoptr
sinking on all targets, but further testing is required.
I've doubled-up on a number of existing tests that are sensitive to the
address sinking behavior (including some store-merging tests that are
sensitive to the order of the resulting ADD operations at the SDAG level).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206092
91177308-0d34-0410-b5e6-
96231b3b80d8
Chad Rosier [Sat, 12 Apr 2014 00:14:23 +0000 (00:14 +0000)]
[AArch64] Implement the isLegalAddressingMode and getScalingFactorCost APIs.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206089
91177308-0d34-0410-b5e6-
96231b3b80d8
Duncan P. N. Exon Smith [Fri, 11 Apr 2014 23:21:07 +0000 (23:21 +0000)]
blockfreq: Document BlockFrequencyInfo terminology
Documents terminology used in the forthcoming rewrite of
BlockFrequencyInfo.
<rdar://problem/
14292693>
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206086
91177308-0d34-0410-b5e6-
96231b3b80d8
Duncan P. N. Exon Smith [Fri, 11 Apr 2014 23:21:04 +0000 (23:21 +0000)]
blockfreq: Rename BlockProbInfoT to BranchProbabilityInfoT
No functionality change.
<rdar://problem/
14292693>
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206085
91177308-0d34-0410-b5e6-
96231b3b80d8
Duncan P. N. Exon Smith [Fri, 11 Apr 2014 23:21:02 +0000 (23:21 +0000)]
blockfreq: Remove unnecessary template parameters
Moves redundant template parameters into an implementation detail of
BlockFrequencyInfoImpl.
No functionality change.
<rdar://problem/
14292693>
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206084
91177308-0d34-0410-b5e6-
96231b3b80d8
Duncan P. N. Exon Smith [Fri, 11 Apr 2014 23:20:58 +0000 (23:20 +0000)]
blockfreq: Rename BlockFrequencyImpl to BlockFrequencyInfoImpl
This is a shared implementation class for BlockFrequencyInfo and
MachineBlockFrequencyInfo, not for BlockFrequency, a related (but
distinct) class.
No functionality change.
<rdar://problem/
14292693>
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206083
91177308-0d34-0410-b5e6-
96231b3b80d8
Duncan P. N. Exon Smith [Fri, 11 Apr 2014 23:20:52 +0000 (23:20 +0000)]
blockfreq: Use getSuccessorIndex()
No functionality change.
<rdar://problem/
14292693>
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206082
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Fri, 11 Apr 2014 22:49:14 +0000 (22:49 +0000)]
Pull out a named variable for the cached section names to aid readability.
Based on a code review suggestion from Eric Christopher in r205990
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206080
91177308-0d34-0410-b5e6-
96231b3b80d8
Louis Gerbarg [Fri, 11 Apr 2014 22:27:58 +0000 (22:27 +0000)]
Add ARM64 CLS patterns
This patch adds patterns to generate the cls instruction ARM64. Includes tests
for 64 bit and 32 bit operands.
rdar://
15611957
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206079
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Fri, 11 Apr 2014 22:11:50 +0000 (22:11 +0000)]
Format fixes for r205990
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206078
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Fri, 11 Apr 2014 21:58:11 +0000 (21:58 +0000)]
Make doxygen comment match the declaration.
Found by -Wdocumentation.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206076
91177308-0d34-0410-b5e6-
96231b3b80d8
Quentin Colombet [Fri, 11 Apr 2014 21:51:09 +0000 (21:51 +0000)]
[RegAllocGreedy][Last Chance Recoloring] Change the name of the exhaustive search option.
fexhaustive-register-search => exhaustive-register-search
'f' is a Clang thing!
This is related to PR18747.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206075
91177308-0d34-0410-b5e6-
96231b3b80d8
Quentin Colombet [Fri, 11 Apr 2014 21:39:44 +0000 (21:39 +0000)]
[RegAllocGreedy][Last Chance Recoloring] Addition of
-fexhaustive-register-search option to allow an exhaustive search during last
chance recoloring.
This is related to PR18747
Patch by MAYUR PANDEY <mayur.p@samsung.com>.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206072
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Fri, 11 Apr 2014 20:59:54 +0000 (20:59 +0000)]
R600: Check if a sextload should be used for parameter loads.
Through some oddity where truncate (sextload x) isn't folded into
an anyextload for vectors, the sextload remains if the
vector isn't immediately scalarized. This keeps the expected
zextload instructions in the kernel-args test when small type
vectors aren't scalarized.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206070
91177308-0d34-0410-b5e6-
96231b3b80d8
Lang Hames [Fri, 11 Apr 2014 20:07:58 +0000 (20:07 +0000)]
Remove redundant symbolization support from MCDisassembler interface.
MCDisassembler has an MCSymbolizer member that is meant to take care of
symbolizing during disassembly, but it also has several methods that enable the
disassembler to do symbolization internally (i.e. without an attached symbolizer
object). There is no need for this duplication, but ARM64 had been making use of
it. This patch moves the ARM64 symbolization logic out of ARM64Disassembler and
into an ARM64ExternalSymbolizer class, and removes the duplicated MCSymbolizer
functionality from the MCDisassembler interface. Symbolization will now be
done exclusively through MCSymbolizers.
There should be no impact on disassembly for any platform, but this allows us to
tidy up the MCDisassembler interface and simplify the process of (and invariants
related to) disassembler setup.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206063
91177308-0d34-0410-b5e6-
96231b3b80d8
Quentin Colombet [Fri, 11 Apr 2014 19:45:07 +0000 (19:45 +0000)]
[Register Coalescer] Fix wrong live-range information with rematerialization.
When rematerializing an instruction that defines a super register that would be
used by a physical subregisters we use the related physical super register for
the definition.
To keep the live-range information accurate, all the defined subregisters must be
marked as dead def, otherwise the register allocation may miss some
interferences.
Working on a reduced test-case!
<rdar://problem/
16582185>
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206060
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Fri, 11 Apr 2014 19:25:18 +0000 (19:25 +0000)]
R600/SI: Refactor SOPC classes slightly.
Better match what is done for VOPC to eventually
prefer selecting these.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206048
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Fri, 11 Apr 2014 19:18:01 +0000 (19:18 +0000)]
Don't lose the thumb bit by using relocations with sections.
This fixes a regression from r205076.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206047
91177308-0d34-0410-b5e6-
96231b3b80d8
Adrian Prantl [Fri, 11 Apr 2014 18:08:37 +0000 (18:08 +0000)]
Add some CHECKs to this testcase.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206046
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Fri, 11 Apr 2014 17:57:53 +0000 (17:57 +0000)]
Fix shift by constants for vector.
ashr <N x iM>, <N x iM> M -> undef
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206045
91177308-0d34-0410-b5e6-
96231b3b80d8
Adrian Prantl [Fri, 11 Apr 2014 17:49:47 +0000 (17:49 +0000)]
Debug info: Store the DIVariable in DebugLocEntry also for constants,
so DwarfDebug::emitDebugLocEntry can emit them with the correct signedness.
rdar://problem/
15928306
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206042
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Fri, 11 Apr 2014 17:47:30 +0000 (17:47 +0000)]
Move ExtractVectorElements to SelectionDAG.
This seems generally useful, and makes sense to
go along with SplitVector.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206041
91177308-0d34-0410-b5e6-
96231b3b80d8
Tom Stellard [Fri, 11 Apr 2014 16:12:01 +0000 (16:12 +0000)]
SelectionDAG: Use helper function to improve legalization of ISD::MUL
The TargetLowering::expandMUL() helper contains lowering code extracted
from the DAGTypeLegalizer and allows the SelectionDAGLegalizer to expand more
ISD::MUL patterns without having to use a library call.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206037
91177308-0d34-0410-b5e6-
96231b3b80d8
Tom Stellard [Fri, 11 Apr 2014 16:11:58 +0000 (16:11 +0000)]
SelectionDAG: Factor ISD::MUL lowering code out of DAGTypeLegalizer
This code has been moved to a new function in the TargetLowering
class called expandMUL(). The purpose of this is to be able
to share lowering code between the SelectionDAGLegalize and
DAGTypeLegalizer classes.
No functionality changed intended.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206036
91177308-0d34-0410-b5e6-
96231b3b80d8
Daniel Sanders [Fri, 11 Apr 2014 15:33:36 +0000 (15:33 +0000)]
Revert: r205182 - llvm/test/MC/Mips/mips64r2/valid-xfail.s: This REQUIRES asserts. Seems it doesn't fail with -Asserts.
This was most likely caused by an uninitialized value and the relevant code was re-written in r205292. Reverting to see if it still fails on any of the buildbots.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206033
91177308-0d34-0410-b5e6-
96231b3b80d8
Diego Novillo [Fri, 11 Apr 2014 13:55:56 +0000 (13:55 +0000)]
Fix use-after-free bug caught by address sanitizer:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/2959
The location string is returned as a std::string, not a StringRef.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206032
91177308-0d34-0410-b5e6-
96231b3b80d8
Simon Atanasyan [Fri, 11 Apr 2014 04:13:39 +0000 (04:13 +0000)]
[yaml2obj][ELF] ELF Relocations Support.
The patch implements support for both relocation record formats: Elf_Rel
and Elf_Rela. It is possible to define relocation against symbol only.
Relocations against sections will be implemented later. Now yaml2obj
recognizes X86_64, MIPS and Hexagon relocation types.
Example of relocation section specification:
Sections:
- Name: .text
Type: SHT_PROGBITS
Content: "
0000000000000000"
AddressAlign: 16
Flags: [SHF_ALLOC]
- Name: .rel.text
Type: SHT_REL
Info: .text
AddressAlign: 4
Relocations:
- Offset: 0x1
Symbol: glob1
Type: R_MIPS_32
- Offset: 0x2
Symbol: glob2
Type: R_MIPS_CALL16
The patch reviewed by Michael Spencer, Sean Silva, Shankar Easwaran.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206017
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Fri, 11 Apr 2014 01:50:01 +0000 (01:50 +0000)]
Implement depth_first and inverse_depth_first range factory functions.
Also updated as many loops as I could find using df_begin/idf_begin -
strangely I found no uses of idf_begin. Is that just used out of tree?
Also a few places couldn't use df_begin because either they used the
member functions of the depth first iterators or had specific ordering
constraints (I added a comment in the latter case).
Based on a patch by Jim Grosbach. (Jim - you just had iterator_range<T>
where you needed iterator_range<idf_iterator<T>>)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206016
91177308-0d34-0410-b5e6-
96231b3b80d8
Jim Grosbach [Fri, 11 Apr 2014 01:13:16 +0000 (01:13 +0000)]
[c++11] Range'ify use list loops in InstrEmitter.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206015
91177308-0d34-0410-b5e6-
96231b3b80d8
Jim Grosbach [Fri, 11 Apr 2014 01:13:13 +0000 (01:13 +0000)]
[c++11] Range'ify use list loops in DAGCombiner.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206014
91177308-0d34-0410-b5e6-
96231b3b80d8
Jim Grosbach [Fri, 11 Apr 2014 01:13:10 +0000 (01:13 +0000)]
[ARM64,C++11] Range'ify use-lists iterators in address type promotion.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206013
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Fri, 11 Apr 2014 00:43:52 +0000 (00:43 +0000)]
Use value types instead of 'new'd objects to store dwarf labels for asm files
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206009
91177308-0d34-0410-b5e6-
96231b3b80d8
Jim Grosbach [Fri, 11 Apr 2014 00:27:22 +0000 (00:27 +0000)]
[ARM64,C++11]: Range'ify use-list iterators in DAGToDAG.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206007
91177308-0d34-0410-b5e6-
96231b3b80d8
Jim Grosbach [Fri, 11 Apr 2014 00:27:19 +0000 (00:27 +0000)]
[ARM64,C++11]: More range-based loop simplification.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206006
91177308-0d34-0410-b5e6-
96231b3b80d8
Jim Grosbach [Fri, 11 Apr 2014 00:27:17 +0000 (00:27 +0000)]
SDNode: Add uses() iterator_range convenience methods.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206005
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Thu, 10 Apr 2014 23:55:11 +0000 (23:55 +0000)]
Remove lazy-initialization of section caches in MCContext
This seems to have been a cargo-culted habit from the very first such
cache which didn't have any specific justification (but might've been a
layering constraint at the time).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206003
91177308-0d34-0410-b5e6-
96231b3b80d8
Reid Kleckner [Thu, 10 Apr 2014 22:58:43 +0000 (22:58 +0000)]
Move the segmented stack switch to a function attribute
This removes the -segmented-stacks command line flag in favor of a
per-function "split-stack" attribute.
Patch by Luqman Aden and Alex Crichton!
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@205997
91177308-0d34-0410-b5e6-
96231b3b80d8
Josh Magee [Thu, 10 Apr 2014 22:47:27 +0000 (22:47 +0000)]
[stack protector] Refactor and clean-up test. No functionality change.
Refactored stack-protector.ll to use new-style function attributes everywhere
and eliminated unnecessary attributes.
This cleanup is in preparation for an upcoming test change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@205996
91177308-0d34-0410-b5e6-
96231b3b80d8
Louis Gerbarg [Thu, 10 Apr 2014 22:25:51 +0000 (22:25 +0000)]
Test commit.
Update contact information in CREDITS.TXT.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@205995
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Thu, 10 Apr 2014 22:03:48 +0000 (22:03 +0000)]
Simplify make_range by using move semantics
Move the iterators into the range the same way the range's ctor moves
them into the members.
Also remove some redundant top level parens in the return statement.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@205993
91177308-0d34-0410-b5e6-
96231b3b80d8
Jim Grosbach [Thu, 10 Apr 2014 22:00:18 +0000 (22:00 +0000)]
[ARM64,C++11]: Range'ify loops in InstrInfo.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@205992
91177308-0d34-0410-b5e6-
96231b3b80d8
Kaelyn Takata [Thu, 10 Apr 2014 21:55:58 +0000 (21:55 +0000)]
Remove the use of "%e" as it is not a valid expansion like "%t".
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@205991
91177308-0d34-0410-b5e6-
96231b3b80d8