oota-llvm.git
13 years agoFix comment.
Bill Wendling [Tue, 14 Dec 2010 22:26:49 +0000 (22:26 +0000)]
Fix comment.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121797 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoMulticlassify the LDR/STR encoding patterns. The only functionality difference
Bill Wendling [Tue, 14 Dec 2010 22:10:49 +0000 (22:10 +0000)]
Multiclassify the LDR/STR encoding patterns. The only functionality difference
is the addition of the FoldableAsLoad & Rematerializable flags to some of the
load instructions. ARM has these flags set for them.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121794 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoFix a minor bug in two-address pass. It was missing a commute opportunity.
Evan Cheng [Tue, 14 Dec 2010 21:34:53 +0000 (21:34 +0000)]
Fix a minor bug in two-address pass. It was missing a commute opportunity.
regB = move RCX
regA = op regB, regC
RAX  = move regA
where both regB and regC are killed. If regB is constrainted to non-compatible
physical registers but regC is not constrainted at all, then it's better to
commute the instruction.
       movl    %edi, %eax
       shlq    $32, %rcx
       leaq    (%rcx,%rax), %rax
=>
       movl    %edi, %eax
       shlq    $32, %rcx
       orq     %rcx, %rax
rdar://8762995

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121793 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agotrailing whitespace
Jim Grosbach [Tue, 14 Dec 2010 21:28:29 +0000 (21:28 +0000)]
trailing whitespace

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121792 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoMove debugging code entirely within DEBUG(). Silences an unused variable
Matt Beaumont-Gay [Tue, 14 Dec 2010 21:14:55 +0000 (21:14 +0000)]
Move debugging code entirely within DEBUG(). Silences an unused variable
warning in the opt build.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121791 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoRefactor a bit for legibility.
Jim Grosbach [Tue, 14 Dec 2010 21:10:47 +0000 (21:10 +0000)]
Refactor a bit for legibility.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121790 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agotrailing whitespace.
Jim Grosbach [Tue, 14 Dec 2010 20:46:39 +0000 (20:46 +0000)]
trailing whitespace.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121789 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoMake sure to propagate the predicate operands for LEApcrel to ADR.
Jim Grosbach [Tue, 14 Dec 2010 20:45:47 +0000 (20:45 +0000)]
Make sure to propagate the predicate operands for LEApcrel to ADR.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121788 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoFix a small bug (typo?) in the fixup for Thumb1 CBZ/CBNZ instructions.
Owen Anderson [Tue, 14 Dec 2010 19:42:53 +0000 (19:42 +0000)]
Fix a small bug (typo?) in the fixup for Thumb1 CBZ/CBNZ instructions.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121784 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoAdd LiveIntervalUnion print methods, RegAllocGreedy::trySplit debug spew.
Jakob Stoklund Olesen [Tue, 14 Dec 2010 19:38:49 +0000 (19:38 +0000)]
Add LiveIntervalUnion print methods, RegAllocGreedy::trySplit debug spew.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121783 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoUse TRI::printReg instead of AbstractRegisterDescription when printing
Jakob Stoklund Olesen [Tue, 14 Dec 2010 18:53:47 +0000 (18:53 +0000)]
Use TRI::printReg instead of AbstractRegisterDescription when printing
LiveIntervalUnions.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121781 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoAdd TargetRegisterInfo::printReg() to pretty-print registers.
Jakob Stoklund Olesen [Tue, 14 Dec 2010 18:53:39 +0000 (18:53 +0000)]
Add TargetRegisterInfo::printReg() to pretty-print registers.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121780 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoARM Fixups relative to thumb functions need to have the low bit of the value
Jim Grosbach [Tue, 14 Dec 2010 18:46:57 +0000 (18:46 +0000)]
ARM Fixups relative to thumb functions need to have the low bit of the value
set for interworking to work properly. rdar://8755956

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121778 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoQ.seenAllInterferences() must be called after Q.collectInterferingVRegs().
Jakob Stoklund Olesen [Tue, 14 Dec 2010 17:47:36 +0000 (17:47 +0000)]
Q.seenAllInterferences() must be called after Q.collectInterferingVRegs().

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121774 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoMC/ARM: Fix-up fixup offset for fixup_arm_branch target specific fixup.
Daniel Dunbar [Tue, 14 Dec 2010 17:37:16 +0000 (17:37 +0000)]
MC/ARM: Fix-up fixup offset for fixup_arm_branch target specific fixup.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121772 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoTrailing whitespace
Jim Grosbach [Tue, 14 Dec 2010 16:25:15 +0000 (16:25 +0000)]
Trailing whitespace

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121769 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoUse the integer scheduling intrinsic for integer loads and stores.
Bill Wendling [Tue, 14 Dec 2010 12:33:05 +0000 (12:33 +0000)]
Use the integer scheduling intrinsic for integer loads and stores.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121765 91177308-0d34-0410-b5e6-96231b3b80d8

13 years ago - Insert new instructions before DomBlock's terminator,
Chris Lattner [Tue, 14 Dec 2010 08:46:09 +0000 (08:46 +0000)]
 - Insert new instructions before DomBlock's terminator,
   which is simpler than finding a place to insert in BB.
 - Don't perform the 'if condition hoisting' xform on certain
   i1 PHIs, as it interferes with switch formation.

This re-fixes "example 7", without breaking the world hopefully.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121764 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agofix two significant issues with FoldTwoEntryPHINode:
Chris Lattner [Tue, 14 Dec 2010 08:01:53 +0000 (08:01 +0000)]
fix two significant issues with FoldTwoEntryPHINode:

first, it can kick in on blocks whose conditions have been
folded to a constant, even though one of the edges will be
trivially folded.

second, it doesn't clean up the "if diamond" that it just
eliminated away.  This is a problem because other simplifycfg
xforms kick in depending on the order of block visitation,
causing pointless work.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121762 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoremove the instsimplify logic I added in r121754. It is apparently
Chris Lattner [Tue, 14 Dec 2010 07:53:03 +0000 (07:53 +0000)]
remove the instsimplify logic I added in r121754.  It is apparently
breaking the selfhost builds, though I can't fathom how.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121761 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoclean up logic, convert std::set to SmallPtrSet, handle the case
Chris Lattner [Tue, 14 Dec 2010 07:41:39 +0000 (07:41 +0000)]
clean up logic, convert std::set to SmallPtrSet, handle the case
when all 2-entry phis are simplified away.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121760 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agotidy up a bit, move DEBUG down to when we commit to doing the transform so we
Chris Lattner [Tue, 14 Dec 2010 07:23:10 +0000 (07:23 +0000)]
tidy up a bit, move DEBUG down to when we commit to doing the transform so we
don't print it unless the xform happens.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121758 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agouse SimplifyInstruction instead of reimplementing part of it.
Chris Lattner [Tue, 14 Dec 2010 07:20:29 +0000 (07:20 +0000)]
use SimplifyInstruction instead of reimplementing part of it.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121757 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agosimplify GetIfCondition by using getSinglePredecessor.
Chris Lattner [Tue, 14 Dec 2010 07:15:21 +0000 (07:15 +0000)]
simplify GetIfCondition by using getSinglePredecessor.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121756 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agouse AddPredecessorToBlock in 3 places instead of a manual loop.
Chris Lattner [Tue, 14 Dec 2010 07:09:42 +0000 (07:09 +0000)]
use AddPredecessorToBlock in 3 places instead of a manual loop.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121755 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agomake FoldTwoEntryPHINode use instsimplify a bit, make
Chris Lattner [Tue, 14 Dec 2010 07:00:00 +0000 (07:00 +0000)]
make FoldTwoEntryPHINode use instsimplify a bit, make
GetIfCondition faster by avoiding pred_iterator.  No
really interesting change.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121754 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoremove the dead (and terrible) llvm::RemoveSuccessor function.
Chris Lattner [Tue, 14 Dec 2010 06:51:55 +0000 (06:51 +0000)]
remove the dead (and terrible) llvm::RemoveSuccessor function.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121753 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoimprove DEBUG's a bit, switch to eraseFromParent() to simplify
Chris Lattner [Tue, 14 Dec 2010 06:17:25 +0000 (06:17 +0000)]
improve DEBUG's a bit, switch to eraseFromParent() to simplify
code a bit, switch from constant folding to instsimplify.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121751 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agofix yet anohter broken line
Chris Lattner [Tue, 14 Dec 2010 06:09:07 +0000 (06:09 +0000)]
fix yet anohter broken line

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121750 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoreapply my recent change that disables a piece of the switch formation
Chris Lattner [Tue, 14 Dec 2010 05:57:30 +0000 (05:57 +0000)]
reapply my recent change that disables a piece of the switch formation
work, but fixes 400.perlbmk.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121749 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoThe tLDR et al instructions were emitting either a reg/reg or reg/imm
Bill Wendling [Tue, 14 Dec 2010 03:36:38 +0000 (03:36 +0000)]
The tLDR et al instructions were emitting either a reg/reg or reg/imm
instruction based on the t_addrmode_s# mode and what it returned. There is some
obvious badness to this. In particular, it's hard to do MC-encoding when the
instruction may change out from underneath you after the t_addrmode_s# variable
is finally resolved.

The solution is to revert a long-ago change that merged the reg/reg and reg/imm
versions. There is the addition of several new addressing modes. They no longer
have extraneous operands associated with them. I.e., if it's reg/reg we don't
have to have a dummy zero immediate tacked on to the SDNode.

There are some obvious cleanups here, which will happen shortly.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121747 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agobfi A, (and B, C1), C2) -> bfi A, B, C2 iff C1 & C2 == C1. rdar://8458663
Evan Cheng [Tue, 14 Dec 2010 03:22:07 +0000 (03:22 +0000)]
bfi A, (and B, C1), C2) -> bfi A, B, C2 iff C1 & C2 == C1. rdar://8458663

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121746 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agofix fixme case typo :-)
Jason W Kim [Tue, 14 Dec 2010 01:42:38 +0000 (01:42 +0000)]
fix fixme case typo :-)

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121743 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoRemove unused vector.
Jakob Stoklund Olesen [Tue, 14 Dec 2010 00:58:47 +0000 (00:58 +0000)]
Remove unused vector.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121741 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoAdd IntervalMap to the Programmer's Manual.
Jakob Stoklund Olesen [Tue, 14 Dec 2010 00:55:51 +0000 (00:55 +0000)]
Add IntervalMap to the Programmer's Manual.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121740 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoRemove debugging code.
Jakob Stoklund Olesen [Tue, 14 Dec 2010 00:37:52 +0000 (00:37 +0000)]
Remove debugging code.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121738 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoTry reassigning all virtual register interferences, not just those with lower
Jakob Stoklund Olesen [Tue, 14 Dec 2010 00:37:49 +0000 (00:37 +0000)]
Try reassigning all virtual register interferences, not just those with lower
spill weight. Filter out fixed registers instead.

Add support for reassigning an interference that was assigned to an alias.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121737 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoAdd stub for RAGreedy::trySplit.
Jakob Stoklund Olesen [Tue, 14 Dec 2010 00:37:44 +0000 (00:37 +0000)]
Add stub for RAGreedy::trySplit.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121736 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoSecond attempt at make Thumb2 LEAs pseudos. This time, perform the lowering much...
Owen Anderson [Tue, 14 Dec 2010 00:36:49 +0000 (00:36 +0000)]
Second attempt at make Thumb2 LEAs pseudos.  This time, perform the lowering much later, which makes the entire
process cleaner.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121735 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoFix recent buildbot breakage by pulling SimplifyCFG back to its state as of r121694...
Owen Anderson [Mon, 13 Dec 2010 23:49:28 +0000 (23:49 +0000)]
Fix recent buildbot breakage by pulling SimplifyCFG back to its state as of r121694, the most recent state
where I'm confident there were no crashes or miscompilations.  XFAIL the test added since then for now.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121733 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoFirst cut of ARM/MC/ELF PIC relocations.
Jason W Kim [Mon, 13 Dec 2010 23:16:07 +0000 (23:16 +0000)]
First cut of ARM/MC/ELF PIC relocations.
Test has fixme, to move to .s -> .o test when AsmParser works better.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121732 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoRemove the rest of the *_sfp Neon instruction patterns.
Bob Wilson [Mon, 13 Dec 2010 23:02:37 +0000 (23:02 +0000)]
Remove the rest of the *_sfp Neon instruction patterns.
Use the same COPY_TO_REGCLASS approach as for the 2-register *_sfp instructions.
This change made a big difference in the code generated for the
CodeGen/Thumb2/cross-rc-coalescing-2.ll test: The coalescer is still doing
a fine job, but some instructions that were previously moved outside the loop
are not moved now.  It's using fewer VFP registers now, which is generally
a good thing, so I think the estimates for register pressure changed and that
affected the LICM behavior.  Since that isn't obviously wrong, I've just
changed the test file.  This completes the work for Radar 8711675.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121730 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoSimplify N2VSPat, removing some unnecessary type arguments.
Bob Wilson [Mon, 13 Dec 2010 23:02:31 +0000 (23:02 +0000)]
Simplify N2VSPat, removing some unnecessary type arguments.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121729 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agotemporarily disable part of my previous patch, which causes an iterator invalidation...
Chris Lattner [Mon, 13 Dec 2010 23:02:19 +0000 (23:02 +0000)]
temporarily disable part of my previous patch, which causes an iterator invalidation issue, causing a crash on some versions of perlbmk.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121728 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoUpdate a comment.
Dan Gohman [Mon, 13 Dec 2010 22:53:18 +0000 (22:53 +0000)]
Update a comment.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121727 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoRevert r121721, which broke buildbots.
Owen Anderson [Mon, 13 Dec 2010 22:51:08 +0000 (22:51 +0000)]
Revert r121721, which broke buildbots.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121726 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoReapply r121520, PartialAlias implementation for BasicAA, now that
Dan Gohman [Mon, 13 Dec 2010 22:50:24 +0000 (22:50 +0000)]
Reapply r121520, PartialAlias implementation for BasicAA, now that
memdep is updated to handle it.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121725 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoUpdate memdep to handle PartialAlias as MayAlias.
Dan Gohman [Mon, 13 Dec 2010 22:47:57 +0000 (22:47 +0000)]
Update memdep to handle PartialAlias as MayAlias.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121723 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoMake Thumb2 LEA-like instruction into pseudos, which map down to ADR. Provide correc...
Owen Anderson [Mon, 13 Dec 2010 22:29:52 +0000 (22:29 +0000)]
Make Thumb2 LEA-like instruction into pseudos, which map down to ADR.  Provide correct fixups for Thumb2 ADR,
which is _of course_ different from ARM ADR fixups, or any other Thumb2 fixup.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121721 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoDelete a line that I forgot to revert previously.
Bob Wilson [Mon, 13 Dec 2010 22:05:55 +0000 (22:05 +0000)]
Delete a line that I forgot to revert previously.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121719 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoUse COPY_TO_REGCLASS instead of pseudo instructions for Neon FP patterns.
Bob Wilson [Mon, 13 Dec 2010 21:58:05 +0000 (21:58 +0000)]
Use COPY_TO_REGCLASS instead of pseudo instructions for Neon FP patterns.
Jakob Olesen suggested that we can avoid the need for separate pseudo
instructions here by using COPY_TO_REGCLASS in the patterns.  The pattern
gets pretty ugly but it seems to work well.  Partial fix for Radar 8711675.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121718 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoUse pseudo instructions for 2-register Neon instructions for scalar FP.
Bob Wilson [Mon, 13 Dec 2010 21:05:52 +0000 (21:05 +0000)]
Use pseudo instructions for 2-register Neon instructions for scalar FP.
Partial fix for Radar 8711675.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121716 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoRemove unused instruction class arguments.
Bob Wilson [Mon, 13 Dec 2010 21:05:44 +0000 (21:05 +0000)]
Remove unused instruction class arguments.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121715 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoGeneralize BFI isel lowering a bit.
Evan Cheng [Mon, 13 Dec 2010 20:32:54 +0000 (20:32 +0000)]
Generalize BFI isel lowering a bit.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121714 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoadd some DEBUG's.
Chris Lattner [Mon, 13 Dec 2010 19:55:30 +0000 (19:55 +0000)]
add some DEBUG's.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121711 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoIn Thumb2, direct branches can be encoded as either a "short" conditional branch...
Owen Anderson [Mon, 13 Dec 2010 19:31:11 +0000 (19:31 +0000)]
In Thumb2, direct branches can be encoded as either a "short" conditional branch with a null predicate, or
as a "long" direct branch.  While the mnemonics are the same, they encode the branch offset differently, and
the Darwin assembler appears to prefer the "long" form for direct branches.  Thus, in the name of bitwise
equivalence, provide encoding and fixup support for it.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121710 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoUse 32-bit types for 32-bit values.
Jim Grosbach [Mon, 13 Dec 2010 19:25:46 +0000 (19:25 +0000)]
Use 32-bit types for 32-bit values.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121709 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoTrailing whitespace.
Jim Grosbach [Mon, 13 Dec 2010 19:18:13 +0000 (19:18 +0000)]
Trailing whitespace.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121708 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoFix sort predicate. qsort(3)'s predicate semantics differ from std::sort's. Fixes...
Benjamin Kramer [Mon, 13 Dec 2010 18:20:38 +0000 (18:20 +0000)]
Fix sort predicate. qsort(3)'s predicate semantics differ from std::sort's. Fixes PR 8780.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121705 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agorename test
Chris Lattner [Mon, 13 Dec 2010 08:39:40 +0000 (08:39 +0000)]
rename test

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121697 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoAdd a couple dag combines to transform mulhi/mullo into a wider multiply
Chris Lattner [Mon, 13 Dec 2010 08:39:01 +0000 (08:39 +0000)]
Add a couple dag combines to transform mulhi/mullo into a wider multiply
when the wider type is legal.  This allows us to compile:

define zeroext i16 @test1(i16 zeroext %x) nounwind {
entry:
%div = udiv i16 %x, 33
ret i16 %div
}

into:

test1:                                  # @test1
movzwl 4(%esp), %eax
imull $63551, %eax, %eax      # imm = 0xF83F
shrl $21, %eax
ret

instead of:

test1:                                  # @test1
        movw    $-1985, %ax             # imm = 0xFFFFFFFFFFFFF83F
        mulw    4(%esp)
        andl    $65504, %edx            # imm = 0xFFE0
        movl    %edx, %eax
        shrl    $5, %eax
        ret

Implementing rdar://8760399 and example #4 from:
http://blog.regehr.org/archives/320

We should implement the same thing for [su]mul_hilo, but I don't
have immediate plans to do this.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121696 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoreinstate my patch: the miscompile was caused by an inverted branch in the
Chris Lattner [Mon, 13 Dec 2010 08:12:19 +0000 (08:12 +0000)]
reinstate my patch: the miscompile was caused by an inverted branch in the
'and' case.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121695 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoCompletely disable the optimization I added in r121680 until
Chris Lattner [Mon, 13 Dec 2010 07:41:29 +0000 (07:41 +0000)]
Completely disable the optimization I added in r121680 until
I can track down a miscompile.  This should bring the buildbots
back to life

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121693 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoremove the verbose-asm "constant pool double" comments that we were printing
Chris Lattner [Mon, 13 Dec 2010 07:35:47 +0000 (07:35 +0000)]
remove the verbose-asm "constant pool double" comments that we were printing
for each constant pool entry.  Using WriteTypeSymbolic here takes time
proportional to the size of the module, for each constant pool entry.

This speeds up -verbose-asm llc on 252.eon (a random testcase at my disposal)
from 4.4s to 2.137s.  llc takes 2.11s with asm-verbose off, so this is now a
pretty reasonable cost for verbose comments.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121691 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoMake simplifycfg reprocess newly formed "br (cond1 | cond2)" conditions
Chris Lattner [Mon, 13 Dec 2010 07:00:06 +0000 (07:00 +0000)]
Make simplifycfg reprocess newly formed "br (cond1 | cond2)" conditions
when simplifying, allowing them to be eagerly turned into switches.  This
is the last step required to get "Example 7" from this blog post:
http://blog.regehr.org/archives/320

On X86, we now generate this machine code, which (to my eye) seems better
than the ICC generated code:

_crud:                                  ## @crud
## BB#0:                                ## %entry
cmpb $33, %dil
jb LBB0_4
## BB#1:                                ## %switch.early.test
addb $-34, %dil
cmpb $58, %dil
ja LBB0_3
## BB#2:                                ## %switch.early.test
movzbl %dil, %eax
movabsq $288230376537592865, %rcx ## imm = 0x400000017001421
btq %rax, %rcx
jb LBB0_4
LBB0_3:                                 ## %lor.rhs
xorl %eax, %eax
ret
LBB0_4:                                 ## %lor.end
movl $1, %eax
ret

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121690 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agomake this logic a bit simpler.
Chris Lattner [Mon, 13 Dec 2010 06:36:51 +0000 (06:36 +0000)]
make this logic a bit simpler.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121689 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agosplit all the guts of SimplifyCFGOpt::run out into one function
Chris Lattner [Mon, 13 Dec 2010 06:25:44 +0000 (06:25 +0000)]
split all the guts of SimplifyCFGOpt::run out into one function
per terminator kind.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121688 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agofix a bug in r121680 that upset the various buildbots.
Chris Lattner [Mon, 13 Dec 2010 05:34:18 +0000 (05:34 +0000)]
fix a bug in r121680 that upset the various buildbots.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121687 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agorefactor the speculative execution logic to be factored into the cond branch code...
Chris Lattner [Mon, 13 Dec 2010 05:26:52 +0000 (05:26 +0000)]
refactor the speculative execution logic to be factored into the cond branch code instead of
doing a cfg search for every block simplified.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121686 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agosimplify a bunch of code.
Chris Lattner [Mon, 13 Dec 2010 05:20:28 +0000 (05:20 +0000)]
simplify a bunch of code.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121685 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agomove HoistThenElseCodeToIf up to a more logical and efficient-to-handle place.
Chris Lattner [Mon, 13 Dec 2010 05:15:29 +0000 (05:15 +0000)]
move HoistThenElseCodeToIf up to a more logical and efficient-to-handle place.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121684 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agomove 'MergeBlocksIntoPredecessor' call earlier. Use
Chris Lattner [Mon, 13 Dec 2010 05:10:48 +0000 (05:10 +0000)]
move 'MergeBlocksIntoPredecessor' call earlier.  Use
getSinglePredecessor to simplify code.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121683 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agomake these tests a bit less fragile
Chris Lattner [Mon, 13 Dec 2010 05:10:30 +0000 (05:10 +0000)]
make these tests a bit less fragile

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121682 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agofactor new code out to a SimplifyBranchOnICmpChain helper function.
Chris Lattner [Mon, 13 Dec 2010 05:03:41 +0000 (05:03 +0000)]
factor new code out to a SimplifyBranchOnICmpChain helper function.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121681 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoenhance the "change or icmp's into switch" xform to handle one value in an
Chris Lattner [Mon, 13 Dec 2010 04:50:38 +0000 (04:50 +0000)]
enhance the "change or icmp's into switch" xform to handle one value in an
'or sequence' that it doesn't understand.  This allows us to optimize
something insane like this:

int crud (unsigned char c, unsigned x)
 {
   if(((((((((( (int) c <= 32 ||
                    (int) c == 46) || (int) c == 44)
                  || (int) c == 58) || (int) c == 59) || (int) c == 60)
               || (int) c == 62) || (int) c == 34) || (int) c == 92)
            || (int) c == 39) != 0)
     foo();
 }

into:

define i32 @crud(i8 zeroext %c, i32 %x) nounwind ssp noredzone {
entry:
  %cmp = icmp ult i8 %c, 33
  br i1 %cmp, label %if.then, label %switch.early.test

switch.early.test:                                ; preds = %entry
  switch i8 %c, label %if.end [
    i8 39, label %if.then
    i8 44, label %if.then
    i8 58, label %if.then
    i8 59, label %if.then
    i8 60, label %if.then
    i8 62, label %if.then
    i8 46, label %if.then
    i8 92, label %if.then
    i8 34, label %if.then
  ]

by pulling the < comparison out ahead of the newly formed switch.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121680 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agomerge two tests
Chris Lattner [Mon, 13 Dec 2010 04:45:56 +0000 (04:45 +0000)]
merge two tests

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121679 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agomerge two very similar functions into one that has a bool argument.
Chris Lattner [Mon, 13 Dec 2010 04:26:26 +0000 (04:26 +0000)]
merge two very similar functions into one that has a bool argument.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121678 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoDisable auto-detection of AVX support since AVX codegen support is not ready.
Evan Cheng [Mon, 13 Dec 2010 04:23:53 +0000 (04:23 +0000)]
Disable auto-detection of AVX support since AVX codegen support is not ready.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121677 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agodon't bother handling non-canonical icmp's
Chris Lattner [Mon, 13 Dec 2010 04:18:32 +0000 (04:18 +0000)]
don't bother handling non-canonical icmp's

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121676 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoinline a function, making the result much simpler.
Chris Lattner [Mon, 13 Dec 2010 04:15:19 +0000 (04:15 +0000)]
inline a function, making the result much simpler.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121675 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoFix my previous patch to handle a degenerate case that the llvm-gcc
Chris Lattner [Mon, 13 Dec 2010 03:43:57 +0000 (03:43 +0000)]
Fix my previous patch to handle a degenerate case that the llvm-gcc
bootstrap buildbot tripped over.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121674 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoconvert some methods to be static functions
Chris Lattner [Mon, 13 Dec 2010 03:30:12 +0000 (03:30 +0000)]
convert some methods to be static functions

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121673 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agozap two more std::sorts.
Chris Lattner [Mon, 13 Dec 2010 03:24:30 +0000 (03:24 +0000)]
zap two more std::sorts.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121672 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agofix a fairly serious oversight with switch formation from
Chris Lattner [Mon, 13 Dec 2010 03:18:54 +0000 (03:18 +0000)]
fix a fairly serious oversight with switch formation from
or'd conditions.  Previously we'd compile something like this:

int crud (unsigned char c) {
   return c == 62 || c == 34 || c == 92;
}

into:

  switch i8 %c, label %lor.rhs [
    i8 62, label %lor.end
    i8 34, label %lor.end
  ]

lor.rhs:                                          ; preds = %entry
  %cmp8 = icmp eq i8 %c, 92
  br label %lor.end

lor.end:                                          ; preds = %entry, %entry, %lor.rhs
  %0 = phi i1 [ true, %entry ], [ %cmp8, %lor.rhs ], [ true, %entry ]
  %lor.ext = zext i1 %0 to i32
  ret i32 %lor.ext

which failed to merge the compare-with-92 into the switch.  With this patch
we simplify this all the way to:

  switch i8 %c, label %lor.rhs [
    i8 62, label %lor.end
    i8 34, label %lor.end
    i8 92, label %lor.end
  ]

lor.rhs:                                          ; preds = %entry
  br label %lor.end

lor.end:                                          ; preds = %entry, %entry, %entry, %lor.rhs
  %0 = phi i1 [ true, %entry ], [ false, %lor.rhs ], [ true, %entry ], [ true, %entry ]
  %lor.ext = zext i1 %0 to i32
  ret i32 %lor.ext

which is much better for codegen's switch lowering stuff.  This kicks in 33 times
on 176.gcc (for example) cutting 103 instructions off the generated code.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121671 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agosimplify code and reduce indentation
Chris Lattner [Mon, 13 Dec 2010 02:38:13 +0000 (02:38 +0000)]
simplify code and reduce indentation

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121670 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoconvert an std::sort to array_pod_sort.
Chris Lattner [Mon, 13 Dec 2010 02:00:58 +0000 (02:00 +0000)]
convert an std::sort to array_pod_sort.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121669 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agomove the "br (X == 0 | X == 1), T, F" -> switch optimization to a new
Chris Lattner [Mon, 13 Dec 2010 01:57:34 +0000 (01:57 +0000)]
move the "br (X == 0 | X == 1), T, F" -> switch optimization to a new
location in simplifycfg.  In the old days, SimplifyCFG was never run on
the entry block, so we had to scan over all preds of the BB passed into
simplifycfg to do this xform, now we can just check blocks ending with
a condbranch.  This avoids a scan over all preds of every simplified
block, which should be a significant compile-time perf win on functions
with lots of edges.  No functionality change.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121668 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoreduce indentation and generally simplify code, no functionality change.
Chris Lattner [Mon, 13 Dec 2010 01:47:07 +0000 (01:47 +0000)]
reduce indentation and generally simplify code, no functionality change.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121667 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoAdd support for using the `!if' operator when initializing variables:
Bill Wendling [Mon, 13 Dec 2010 01:46:19 +0000 (01:46 +0000)]
Add support for using the `!if' operator when initializing variables:

  class A<bit a, bits<3> x, bits<3> y> {
    bits<3> z;
    let z = !if(a, x, y);
  }

The variable z will get the value of x when 'a' is 1 and 'y' when a is '0'.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121666 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agouse getFirstNonPHIOrDbg to simplify this code.
Chris Lattner [Mon, 13 Dec 2010 01:28:06 +0000 (01:28 +0000)]
use getFirstNonPHIOrDbg to simplify this code.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121664 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoreduce indentation by using continue, no functionality change.
Chris Lattner [Mon, 13 Dec 2010 01:11:17 +0000 (01:11 +0000)]
reduce indentation by using continue, no functionality change.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121662 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoMove <map> include out of .h and into .cpp.
Bill Wendling [Mon, 13 Dec 2010 01:05:54 +0000 (01:05 +0000)]
Move <map> include out of .h and into .cpp.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121661 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoMerge DEBUG statements.
Bill Wendling [Mon, 13 Dec 2010 01:03:49 +0000 (01:03 +0000)]
Merge DEBUG statements.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121660 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoeliminate the Records global variable, patch by Garrison Venn!
Chris Lattner [Mon, 13 Dec 2010 00:23:57 +0000 (00:23 +0000)]
eliminate the Records global variable, patch by Garrison Venn!

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121659 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoclean up RecordKeeper::getAllDerivedDefinitions, patch by Garrison Venn!
Chris Lattner [Mon, 13 Dec 2010 00:20:52 +0000 (00:20 +0000)]
clean up RecordKeeper::getAllDerivedDefinitions, patch by Garrison Venn!

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121658 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agofurther fixes.
Chris Lattner [Mon, 13 Dec 2010 00:17:12 +0000 (00:17 +0000)]
further fixes.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121657 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoadd a note
Chris Lattner [Mon, 13 Dec 2010 00:15:25 +0000 (00:15 +0000)]
add a note

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121656 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoMissed some ADDI <-> ADDIK conversions in 121649.
Wesley Peck [Sun, 12 Dec 2010 22:53:14 +0000 (22:53 +0000)]
Missed some ADDI <-> ADDIK conversions in 121649.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121652 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoReverting commit to LLVMLibDeps that was inadvertently done in 121649.
Wesley Peck [Sun, 12 Dec 2010 22:28:51 +0000 (22:28 +0000)]
Reverting commit to LLVMLibDeps that was inadvertently done in 121649.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121651 91177308-0d34-0410-b5e6-96231b3b80d8

13 years agoMBlaze delay slot filler was not capable of using ADDK and variants to fill delay...
Wesley Peck [Sun, 12 Dec 2010 22:22:49 +0000 (22:22 +0000)]
MBlaze delay slot filler was not capable of using ADDK and variants to fill delay slots. This broke several test cases when 121649 was committed. This fixes the regression.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121650 91177308-0d34-0410-b5e6-96231b3b80d8