oota-llvm.git
17 years agoRemoved ReadVal from SerializeTrait<T>, and also removed it from
Ted Kremenek [Thu, 1 Nov 2007 22:23:34 +0000 (22:23 +0000)]
Removed ReadVal from SerializeTrait<T>, and also removed it from
Deserializer.

There were issues with Visual C++ barfing when instantiating
SerializeTrait<T> when "T" was an abstract class AND
SerializeTrait<T>::ReadVal was *never* called:

template <typename T>
struct SerializeTrait {
 <SNIP>
  static inline T ReadVal(Deserializer& D) { T::ReadVal(D); }
 <SNIP>
};

Visual C++ would complain about "T" being an abstract class, even
though ReadVal was never instantiated (although one of the other
member functions were).

Removing this from the trait is not a big deal.  It was used hardly
ever, and users who want "read-by-value" deserialization can simply
call the appropriate methods directly instead of relying on
trait-based-dispatch.  The trait dispatch for
serialization/deserialization is simply sugar in many cases (like this
one).

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43624 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoExecutive summary: getTypeSize -> getTypeStoreSize / getABITypeSize.
Duncan Sands [Thu, 1 Nov 2007 20:53:16 +0000 (20:53 +0000)]
Executive summary: getTypeSize -> getTypeStoreSize / getABITypeSize.
The meaning of getTypeSize was not clear - clarifying it is important
now that we have x86 long double and arbitrary precision integers.
The issue with long double is that it requires 80 bits, and this is
not a multiple of its alignment.  This gives a primitive type for
which getTypeSize differed from getABITypeSize.  For arbitrary precision
integers it is even worse: there is the minimum number of bits needed to
hold the type (eg: 36 for an i36), the maximum number of bits that will
be overwriten when storing the type (40 bits for i36) and the ABI size
(i.e. the storage size rounded up to a multiple of the alignment; 64 bits
for i36).

This patch removes getTypeSize (not really - it is still there but
deprecated to allow for a gradual transition).  Instead there is:

(1) getTypeSizeInBits - a number of bits that suffices to hold all
values of the type.  For a primitive type, this is the minimum number
of bits.  For an i36 this is 36 bits.  For x86 long double it is 80.
This corresponds to gcc's TYPE_PRECISION.

(2) getTypeStoreSizeInBits - the maximum number of bits that is
written when storing the type (or read when reading it).  For an
i36 this is 40 bits, for an x86 long double it is 80 bits.  This
is the size alias analysis is interested in (getTypeStoreSize
returns the number of bytes).  There doesn't seem to be anything
corresponding to this in gcc.

(3) getABITypeSizeInBits - this is getTypeStoreSizeInBits rounded
up to a multiple of the alignment.  For an i36 this is 64, for an
x86 long double this is 96 or 128 depending on the OS.  This is the
spacing between consecutive elements when you form an array out of
this type (getABITypeSize returns the number of bytes).  This is
TYPE_SIZE in gcc.

Since successive elements in a SequentialType (arrays, pointers
and vectors) need to be aligned, the spacing between them will be
given by getABITypeSize.  This means that the size of an array
is the length times the getABITypeSize.  It also means that GEP
computations need to use getABITypeSize when computing offsets.
Furthermore, if an alloca allocates several elements at once then
these too need to be aligned, so the size of the alloca has to be
the number of elements multiplied by getABITypeSize.  Logically
speaking this doesn't have to be the case when allocating just
one element, but it is simpler to also use getABITypeSize in this
case.  So alloca's and mallocs should use getABITypeSize.  Finally,
since gcc's only notion of size is that given by getABITypeSize, if
you want to output assembler etc the same as gcc then getABITypeSize
is the size you want.

Since a store will overwrite no more than getTypeStoreSize bytes,
and a read will read no more than that many bytes, this is the
notion of size appropriate for alias analysis calculations.

In this patch I have corrected all type size uses except some of
those in ScalarReplAggregates, lib/Codegen, lib/Target (the hard
cases).  I will get around to auditing these too at some point,
but I could do with some help.

Finally, I made one change which I think wise but others might
consider pointless and suboptimal: in an unpacked struct the
amount of space allocated for a field is now given by the ABI
size rather than getTypeStoreSize.  I did this because every
other place that reserves memory for a type (eg: alloca) now
uses getABITypeSize, and I didn't want to make an exception
for unpacked structs, i.e. I did it to make things more uniform.
This only effects structs containing long doubles and arbitrary
precision integers.  If someone wants to pack these types more
tightly they can always use a packed struct.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43620 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoDon't barf on empty basic blocks. Do not rely on assert
Duncan Sands [Thu, 1 Nov 2007 10:50:26 +0000 (10:50 +0000)]
Don't barf on empty basic blocks.  Do not rely on assert
doing something - this needs to work for release builds
too.  I chose to just abort rather than following the
fancy logic of abortIfBroken, because (1) it is a pain
to do otherwise, and (2) nothing is going to work if the
module is this broken.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43611 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoSilence a warning saying that the variables always resolve to "true" in an
Bill Wendling [Thu, 1 Nov 2007 09:38:19 +0000 (09:38 +0000)]
Silence a warning saying that the variables always resolve to "true" in an
expression.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43610 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoSilence, accersed warning
Bill Wendling [Thu, 1 Nov 2007 08:51:44 +0000 (08:51 +0000)]
Silence, accersed warning

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43609 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoGet rid of compilation warning during release builds
Bill Wendling [Thu, 1 Nov 2007 08:24:40 +0000 (08:24 +0000)]
Get rid of compilation warning during release builds

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43608 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoAdd the start of chapter 6, still much to go.
Chris Lattner [Thu, 1 Nov 2007 06:49:54 +0000 (06:49 +0000)]
Add the start of chapter 6, still much to go.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43607 91177308-0d34-0410-b5e6-96231b3b80d8

17 years ago- Coalesce extract_subreg when both intervals are relatively small.
Evan Cheng [Thu, 1 Nov 2007 06:22:48 +0000 (06:22 +0000)]
- Coalesce extract_subreg when both intervals are relatively small.
- Some code clean up.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43606 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoFix test/Transforms/DeadStoreElimination/PartialStore.ll, which had been
Owen Anderson [Thu, 1 Nov 2007 05:29:16 +0000 (05:29 +0000)]
Fix test/Transforms/DeadStoreElimination/PartialStore.ll, which had been
silently failing because of an incorrect run line for some time.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43605 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoremove verifier command line option: this should be part of the API, not
Chris Lattner [Thu, 1 Nov 2007 04:43:13 +0000 (04:43 +0000)]
remove verifier command line option: this should be part of the API, not
a command line optn.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43603 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoadd a broken gcc version, thanks to P. Durante for pointing this out.
Chris Lattner [Thu, 1 Nov 2007 04:20:16 +0000 (04:20 +0000)]
add a broken gcc version, thanks to P. Durante for pointing this out.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43602 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoNow with less tabs!
Owen Anderson [Thu, 1 Nov 2007 03:54:23 +0000 (03:54 +0000)]
Now with less tabs!

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43601 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoTest that expand_vector_elt(v2i64) works in 32-bit mode.
Dale Johannesen [Thu, 1 Nov 2007 02:38:24 +0000 (02:38 +0000)]
Test that expand_vector_elt(v2i64) works in 32-bit mode.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43598 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoFix InstCombine/2007-10-31-StringCrash.ll by removing an obvious
Chris Lattner [Thu, 1 Nov 2007 02:30:35 +0000 (02:30 +0000)]
Fix InstCombine/2007-10-31-StringCrash.ll by removing an obvious
(in hindsight) infinite recursion.  Simplify the code.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43597 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoFix InstCombine/2007-10-31-RangeCrash.ll
Chris Lattner [Thu, 1 Nov 2007 02:18:41 +0000 (02:18 +0000)]
Fix InstCombine/2007-10-31-RangeCrash.ll

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43596 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoRewrote backpatcher. Backpatcher now stores the "has final pointer"
Ted Kremenek [Thu, 1 Nov 2007 00:57:37 +0000 (00:57 +0000)]
Rewrote backpatcher.  Backpatcher now stores the "has final pointer"
flag in the **key** of the backpatch map, as opposed to the mapped
value which contains either the final pointer, or a pointer to a chain
of pointers that need to be backpatched.  The bit flag was moved to
the key because we were erroneously assuming that the backpatched
pointers would be at an alignment of >= 2 bytes, which obviously
doesn't work for character strings.  Now we just steal the bit from the key.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43595 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoAdded typedef "value_type" to DenseMap (similar typedef appears in std::map).
Ted Kremenek [Thu, 1 Nov 2007 00:54:57 +0000 (00:54 +0000)]
Added typedef "value_type" to DenseMap (similar typedef appears in std::map).

Added method FindAndConstruct() to DenseMap, which does the same thing as
operator[], except that it refers value_type& (a reference to both the
key and mapped data pair).  This method is useful for clients that wish
to access the stored key value, as opposed to the key used to do the
actual lookup (these need not always be the same).

Redefined operator[] to use FindAndConstruct() (same logic).

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43594 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoconstified several pointer arguments for methods in the Deserializer.
Ted Kremenek [Wed, 31 Oct 2007 22:42:03 +0000 (22:42 +0000)]
constified several pointer arguments for methods in the Deserializer.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43583 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoFix a regression in test/CodeGen/X86/2007-04-24-VectorCrash.ll introduced
Dan Gohman [Wed, 31 Oct 2007 21:36:31 +0000 (21:36 +0000)]
Fix a regression in test/CodeGen/X86/2007-04-24-VectorCrash.ll introduced
by r43510. Gracefully handle constants with vector type that aren't
ConstantVector or ConstantAggregateZero.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43579 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoAdd a preverifier pass to check that every basic block ends in a terminator, so that...
Owen Anderson [Wed, 31 Oct 2007 21:04:18 +0000 (21:04 +0000)]
Add a preverifier pass to check that every basic block ends in a terminator, so that we don't segfault when verifying invalid code.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43578 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoImplemented deserialization of references. References are handled
Ted Kremenek [Wed, 31 Oct 2007 19:58:32 +0000 (19:58 +0000)]
Implemented deserialization of references.  References are handled
just like pointers, except that they cannot be backpatched.  This
means that references are essentially non-owning pointers where the
referred object must be deserialized prior to the reference being
deserialized.  Because of the nature of references, this ordering of
objects is always possible.

Fixed a bug in backpatching code (returning the backpatched pointer
would accidentally include a bit flag).

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43570 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoAdded Serializer::EmitRef to deal with emitting arbitrary references.
Ted Kremenek [Wed, 31 Oct 2007 18:23:21 +0000 (18:23 +0000)]
Added Serializer::EmitRef to deal with emitting arbitrary references.
Modified Serializer::EmitPtr to handle const pointers.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43565 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoChanged access control within FoldingSet for some ivars from "private"
Ted Kremenek [Wed, 31 Oct 2007 17:12:47 +0000 (17:12 +0000)]
Changed access control within FoldingSet for some ivars from "private"
to "protected".  This allows iterators to work.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43559 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoMake ARM and X86 LowerMEMCPY identical by moving the isThumb check into getMaxInlineS...
Rafael Espindola [Wed, 31 Oct 2007 14:39:58 +0000 (14:39 +0000)]
Make ARM and X86 LowerMEMCPY identical by moving the isThumb check into getMaxInlineSizeThreshold
and by restructuring the X86 version.

New I just have to move this to a common place :-)

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43554 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoFix a typo in a comment.
Dan Gohman [Wed, 31 Oct 2007 14:35:39 +0000 (14:35 +0000)]
Fix a typo in a comment.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43553 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoMake ARM an X86 memcpy expansion more similar to each other.
Rafael Espindola [Wed, 31 Oct 2007 11:52:06 +0000 (11:52 +0000)]
Make ARM an X86 memcpy expansion more similar to each other.
Now both subtarget define getMaxInlineSizeThreshold and the expansion uses it.

This should not change generated code.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43552 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoPromotion of sdiv/srem/udiv/urem.
Duncan Sands [Wed, 31 Oct 2007 08:57:43 +0000 (08:57 +0000)]
Promotion of sdiv/srem/udiv/urem.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43551 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoAdd a newline at the end of the file.
Duncan Sands [Wed, 31 Oct 2007 08:49:24 +0000 (08:49 +0000)]
Add a newline at the end of the file.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43550 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agofix validation
Chris Lattner [Wed, 31 Oct 2007 07:30:39 +0000 (07:30 +0000)]
fix validation

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43549 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agookay, fine, make me finish this chapter. :)
Chris Lattner [Wed, 31 Oct 2007 07:29:43 +0000 (07:29 +0000)]
okay, fine, make me finish this chapter. :)

Feedback appreciated!

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43548 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoadd the code for expression code that we'll add, though most of the
Chris Lattner [Wed, 31 Oct 2007 06:47:39 +0000 (06:47 +0000)]
add the code for expression code that we'll add, though most of the
description is missing.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43547 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoAdd the first half of chapter 5: if/then/else.
Chris Lattner [Wed, 31 Oct 2007 06:30:21 +0000 (06:30 +0000)]
Add the first half of chapter 5: if/then/else.
To come: for statement.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43546 91177308-0d34-0410-b5e6-96231b3b80d8

17 years ago__main is dead along with llvm-gcc3.
Chris Lattner [Wed, 31 Oct 2007 05:53:31 +0000 (05:53 +0000)]
__main is dead along with llvm-gcc3.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43545 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoAdd the skeleton of a better PHI elimination pass.
Owen Anderson [Wed, 31 Oct 2007 03:37:57 +0000 (03:37 +0000)]
Add the skeleton of a better PHI elimination pass.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43542 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoSome fixes to get MachineDomTree working better.
Owen Anderson [Wed, 31 Oct 2007 03:30:14 +0000 (03:30 +0000)]
Some fixes to get MachineDomTree working better.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43541 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoMake i64=expand_vector_elt(v2i64) work in 32-bit mode.
Dale Johannesen [Wed, 31 Oct 2007 00:32:36 +0000 (00:32 +0000)]
Make i64=expand_vector_elt(v2i64) work in 32-bit mode.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43535 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoAt end of LSR, replace uses of now constant (as result of SplitCriticalEdge) PHI...
Evan Cheng [Tue, 30 Oct 2007 23:45:15 +0000 (23:45 +0000)]
At end of LSR, replace uses of now constant (as result of SplitCriticalEdge) PHI node with the constant value.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43533 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoAdded member function "size()" to FoldingSet to return the number of
Ted Kremenek [Tue, 30 Oct 2007 23:35:55 +0000 (23:35 +0000)]
Added member function "size()" to FoldingSet to return the number of
nodes in the FoldingSet.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43531 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoNew test.
Devang Patel [Tue, 30 Oct 2007 23:07:47 +0000 (23:07 +0000)]
New test.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43527 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoIt's not safe to tell SplitCriticalEdge to merge identical edges. It may delete the...
Evan Cheng [Tue, 30 Oct 2007 22:27:26 +0000 (22:27 +0000)]
It's not safe to tell SplitCriticalEdge to merge identical edges. It may delete the phi instruction that's being processed.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43524 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoAdd missing SSE builtins: CVTPD2PI, CVTPS2PI,
Dale Johannesen [Tue, 30 Oct 2007 22:15:38 +0000 (22:15 +0000)]
Add missing SSE builtins:  CVTPD2PI, CVTPS2PI,
CVTTPD2PI, CVTTPS2PI, CVTPI2PD, CVTPI2PS.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43523 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoTypo.
Evan Cheng [Tue, 30 Oct 2007 20:11:21 +0000 (20:11 +0000)]
Typo.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43511 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoAdd support for folding binary operators with vector zero operands.
Dan Gohman [Tue, 30 Oct 2007 19:00:49 +0000 (19:00 +0000)]
Add support for folding binary operators with vector zero operands.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43510 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoFix for visibility warnings generated by gcc-4.2.
Duncan Sands [Tue, 30 Oct 2007 13:14:37 +0000 (13:14 +0000)]
Fix for visibility warnings generated by gcc-4.2.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43500 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoAdd support for expanding trunc stores. Consider
Duncan Sands [Tue, 30 Oct 2007 12:50:39 +0000 (12:50 +0000)]
Add support for expanding trunc stores.  Consider
storing an i170 on a 32 bit machine.  This is first
promoted to a trunc-i170 store of an i256.  On a
little-endian machine this expands to a store of
an i128 and a trunc-i42 store of an i128.  The
trunc-i42 store is further expanded to a trunc-i42
store of an i64, then to a store of an i32 and a
trunc-i10 store of an i32.  At this point the operand
type is legal (i32) and expansion stops (legalization
of the trunc-i10 needs to be handled in LegalizeDAG.cpp).
On big-endian machines the high bits are stored first,
and some bit-fiddling is needed in order to generate
aligned stores.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43499 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoIf a call to getTruncStore is for a normal store,
Duncan Sands [Tue, 30 Oct 2007 12:40:58 +0000 (12:40 +0000)]
If a call to getTruncStore is for a normal store,
offload to getStore rather than trying to handle
both cases at once (the assertions for example
assume the store really is truncating).

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43498 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoFix argument types for PSLLQ, PSRLQ.
Dale Johannesen [Tue, 30 Oct 2007 01:44:33 +0000 (01:44 +0000)]
Fix argument types for PSLLQ, PSRLQ.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43490 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoAdd missing MMX PSUBQ.
Dale Johannesen [Tue, 30 Oct 2007 01:18:38 +0000 (01:18 +0000)]
Add missing MMX PSUBQ.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43488 91177308-0d34-0410-b5e6-96231b3b80d8

17 years ago- Bug fixes.
Evan Cheng [Mon, 29 Oct 2007 22:07:18 +0000 (22:07 +0000)]
- Bug fixes.
- Allow icmp rewrite using an iv / stride of a smaller integer type.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43480 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoUpdated VC++ build system
Hartmut Kaiser [Mon, 29 Oct 2007 21:56:15 +0000 (21:56 +0000)]
Updated VC++ build system

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43479 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoFix a DAGCombiner abort on a bitcast from a scalar to a vector.
Dan Gohman [Mon, 29 Oct 2007 20:44:42 +0000 (20:44 +0000)]
Fix a DAGCombiner abort on a bitcast from a scalar to a vector.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43470 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoDon't bitcast from pointer-to-vector to pointer-to-array when
Dan Gohman [Mon, 29 Oct 2007 20:34:35 +0000 (20:34 +0000)]
Don't bitcast from pointer-to-vector to pointer-to-array when
lowering load and store instructions.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43468 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoUse an array instead of a fixed-length std::vector.
Dan Gohman [Mon, 29 Oct 2007 20:24:00 +0000 (20:24 +0000)]
Use an array instead of a fixed-length std::vector.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43467 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoDo a real assert if there is an unhandled vector instruction instead
Dan Gohman [Mon, 29 Oct 2007 20:14:29 +0000 (20:14 +0000)]
Do a real assert if there is an unhandled vector instruction instead
of just printing to cerr.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43466 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoEnable more fold (sext (load x)) -> (sext (truncate (sextload x)))
Evan Cheng [Mon, 29 Oct 2007 19:58:20 +0000 (19:58 +0000)]
Enable more fold (sext (load x)) -> (sext (truncate (sextload x)))
transformation. Previously, it's restricted by ensuring the number of load uses
is one. Now the restriction is loosened up by allowing setcc uses to be
"extended" (e.g. setcc x, c, eq -> setcc sext(x), sext(c), eq).

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43465 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoAdd explicit keywords.
Dan Gohman [Mon, 29 Oct 2007 19:52:04 +0000 (19:52 +0000)]
Add explicit keywords.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43464 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoUpdate a comment to reflect the current code.
Dan Gohman [Mon, 29 Oct 2007 19:32:39 +0000 (19:32 +0000)]
Update a comment to reflect the current code.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43463 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoRemove an unused function argument.
Dan Gohman [Mon, 29 Oct 2007 19:31:25 +0000 (19:31 +0000)]
Remove an unused function argument.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43462 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoFix a typo in a comment.
Dan Gohman [Mon, 29 Oct 2007 19:26:14 +0000 (19:26 +0000)]
Fix a typo in a comment.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43461 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoAvoid calling ValidStride when not all uses are addresses.
Dan Gohman [Mon, 29 Oct 2007 19:23:53 +0000 (19:23 +0000)]
Avoid calling ValidStride when not all uses are addresses.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43460 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoFixed warning concerning implicit conversion from a NULL pointer
Ted Kremenek [Mon, 29 Oct 2007 18:43:39 +0000 (18:43 +0000)]
Fixed warning concerning implicit conversion from a NULL pointer
constant to an unsigned int.  We now just directly assign the literal 0.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43459 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoupdate testcase
Chris Lattner [Mon, 29 Oct 2007 17:06:35 +0000 (17:06 +0000)]
update testcase

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43452 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoAvoid doing something dumb like rewriting using a 64-bit iv in 32-bit mode.
Evan Cheng [Mon, 29 Oct 2007 07:57:50 +0000 (07:57 +0000)]
Avoid doing something dumb like rewriting using a 64-bit iv in 32-bit mode.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43446 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoadd a note.
Chris Lattner [Mon, 29 Oct 2007 06:19:48 +0000 (06:19 +0000)]
add a note.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43444 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoModel stacksave and stackrestore as both writing memory, since we
Chris Lattner [Mon, 29 Oct 2007 05:47:52 +0000 (05:47 +0000)]
Model stacksave and stackrestore as both writing memory, since we
don't model their dependences on allocas correctly.  This fixes
PR1745.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43442 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoAdd a first attempt at dominator information for MBB's. Use with caution: this has...
Owen Anderson [Mon, 29 Oct 2007 04:50:50 +0000 (04:50 +0000)]
Add a first attempt at dominator information for MBB's.  Use with caution: this has been tested to compile.  It has not yet been confirmed to generate correct analysis.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43438 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoI am not sure this is a good idea to be an option, but rename the option for
Chris Lattner [Mon, 29 Oct 2007 03:14:55 +0000 (03:14 +0000)]
I am not sure this is a good idea to be an option, but rename the option for
now.  It conflicts with clang's -pedantic flag.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43431 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoAdd support for the x86-64 'q' regigster modifier, and add support for the
Chris Lattner [Mon, 29 Oct 2007 03:09:07 +0000 (03:09 +0000)]
Add support for the x86-64 'q' regigster modifier, and add support for the
b/h/w/k/q inline asm memory modifiers, which are just ignored.  This fixes
PR1748 and CodeGen/X86/2007-10-28-inlineasm-q-modifier.ll

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43430 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoFix PR1749 and InstCombine/2007-10-28-EmptyField.ll by handling
Chris Lattner [Mon, 29 Oct 2007 02:40:02 +0000 (02:40 +0000)]
Fix PR1749 and InstCombine/2007-10-28-EmptyField.ll by handling
zero-length fields better.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43427 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoFix PR1752 and LoopSimplify/2007-10-28-InvokeCrash.ll: terminators
Chris Lattner [Mon, 29 Oct 2007 02:30:37 +0000 (02:30 +0000)]
Fix PR1752 and LoopSimplify/2007-10-28-InvokeCrash.ll: terminators
can have uses too.  Wouldn't it be nice if invoke didn't exist? :)

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43426 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoFixed assertion in Deserializer::~Deserializer that checks for
Ted Kremenek [Sun, 28 Oct 2007 23:38:38 +0000 (23:38 +0000)]
Fixed assertion in Deserializer::~Deserializer that checks for
pointers that were not backpatched (previously checked the wrong invariant).

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43425 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoAdd 'pedantic' mode to verifier rejecting syntactically valid, but 'bad' due to other...
Anton Korobeynikov [Sun, 28 Oct 2007 22:50:32 +0000 (22:50 +0000)]
Add 'pedantic' mode to verifier rejecting syntactically valid, but 'bad' due to other reasons code

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43424 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoUpdated backpatching logic during object deserialization to perform
Ted Kremenek [Sun, 28 Oct 2007 21:17:59 +0000 (21:17 +0000)]
Updated backpatching logic during object deserialization to perform
eager backpatching instead of waithing until all objects have been
deserialized.  This allows us to reduce the memory footprint needed
for backpatching.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43422 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoThe guaranteed alignment of ptr+offset is only the minimum of
Duncan Sands [Sun, 28 Oct 2007 12:59:45 +0000 (12:59 +0000)]
The guaranteed alignment of ptr+offset is only the minimum of
of offset and the alignment of ptr if these are both powers of
2.  While the ptr alignment is guaranteed to be a power of 2,
there is no reason to think that offset is.  For example, if
offset is 12 (the size of a long double on x86-32 linux) and
the alignment of ptr is 8, then the alignment of ptr+offset
will in general be 4, not 8.  Introduce a function MinAlign,
lifted from gcc, for computing the minimum guaranteed alignment.
I've tried to fix up everywhere under lib/CodeGen/SelectionDAG/.
I also changed some places that weren't wrong (because both values
were a power of 2), as a defensive change against people copying
and pasting the code.
Hopefully someone who cares about alignment will review the rest
of LLVM and fix up the remaining places.  Since I'm on x86 I'm
not very motivated to do this myself...

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43421 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoNew entry.
Evan Cheng [Sun, 28 Oct 2007 04:01:09 +0000 (04:01 +0000)]
New entry.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43420 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoFixed bug where default SerializeTrait<>::Materialize would not return the materializ...
Ted Kremenek [Fri, 26 Oct 2007 23:44:59 +0000 (23:44 +0000)]
Fixed bug where default SerializeTrait<>::Materialize would not return the materialized object pointer.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43413 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoTest to make sure that if we have an unaligned memcpy, it will still compile.
Bill Wendling [Fri, 26 Oct 2007 23:43:35 +0000 (23:43 +0000)]
Test to make sure that if we have an unaligned memcpy, it will still compile.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43412 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoA number of LSR fixes:
Evan Cheng [Fri, 26 Oct 2007 23:08:19 +0000 (23:08 +0000)]
A number of LSR fixes:
- ChangeCompareStride only reuse stride that is larger than current stride. It
  will let the general reuse mechanism to try to reuse a smaller stride.
- Watch out for multiplication overflow in ChangeCompareStride.
- Replace std::set with SmallPtrSet.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43408 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoAdded SerializeAPInt.cpp and DeserializeAPInt.cpp to the XCode project.
Ted Kremenek [Fri, 26 Oct 2007 21:53:37 +0000 (21:53 +0000)]
Added SerializeAPInt.cpp and DeserializeAPInt.cpp to the XCode project.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43406 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoAdded serialization support for APInt.
Ted Kremenek [Fri, 26 Oct 2007 21:50:10 +0000 (21:50 +0000)]
Added serialization support for APInt.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43405 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoFixed incorrect "path name" in preamble (comment) of header file.
Ted Kremenek [Fri, 26 Oct 2007 20:44:02 +0000 (20:44 +0000)]
Fixed incorrect "path name" in preamble (comment) of header file.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43402 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoFixed incorrect "path name" in preamble (comment) of header file.
Ted Kremenek [Fri, 26 Oct 2007 20:42:45 +0000 (20:42 +0000)]
Fixed incorrect "path name" in preamble (comment) of header file.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43401 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoOn second thought. Remove this as it should never be generated in the first
Bill Wendling [Fri, 26 Oct 2007 20:34:37 +0000 (20:34 +0000)]
On second thought. Remove this as it should never be generated in the first
place.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43400 91177308-0d34-0410-b5e6-96231b3b80d8

17 years ago- Remove the hacky code that forces a memcpy. Alignment is taken care of in the
Bill Wendling [Fri, 26 Oct 2007 20:24:42 +0000 (20:24 +0000)]
- Remove the hacky code that forces a memcpy. Alignment is taken care of in the
  FE.
- Explicitly pass in the alignment of the load & store.
- XFAIL 2007-10-23-UnalignedMemcpy.ll because llc has a bug that crashes on
  unaligned pointers.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43398 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoAdded default implementation of SerializeTrait<> that dispatches to
Ted Kremenek [Fri, 26 Oct 2007 20:23:27 +0000 (20:23 +0000)]
Added default implementation of SerializeTrait<> that dispatches to
calling member functions of the target type to perform type-specific
serialization.

Added version of ReadPtr that allows passing references to uintptr_t
(useful for smart pointers).

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43396 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoFix a crash. Make sure TLI is not null.
Evan Cheng [Fri, 26 Oct 2007 17:24:46 +0000 (17:24 +0000)]
Fix a crash. Make sure TLI is not null.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43384 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoFix off-by-one stack offset computations (dwarf information) for callee-saved
Anton Korobeynikov [Fri, 26 Oct 2007 09:13:24 +0000 (09:13 +0000)]
Fix off-by-one stack offset computations (dwarf information) for callee-saved
registers in case, when FP pointer was eliminated. This should fixes misc. random
EH-related crahses, when stuff is compiled with -fomit-frame-pointer.
Thanks Duncan for nailing this bug!

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43381 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoclo/clz aren't supported on mips I. Keep them around for when we'll
Eric Christopher [Fri, 26 Oct 2007 04:00:13 +0000 (04:00 +0000)]
clo/clz aren't supported on mips I. Keep them around for when we'll
want them later (mips32/64).

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43380 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoMake a comment better.
Owen Anderson [Fri, 26 Oct 2007 03:47:14 +0000 (03:47 +0000)]
Make a comment better.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43379 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoMore fleshing out of docs/Passes.html, plus some typo fixes and
Gordon Henriksen [Fri, 26 Oct 2007 03:03:51 +0000 (03:03 +0000)]
More fleshing out of docs/Passes.html, plus some typo fixes and
improved wording in source files.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43377 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoLoosen up iv reuse to allow reuse of the same stride but a larger type when truncatin...
Evan Cheng [Fri, 26 Oct 2007 01:56:11 +0000 (01:56 +0000)]
Loosen up iv reuse to allow reuse of the same stride but a larger type when truncating from the larger type to smaller type is free.
e.g.
Turns this loop:
LBB1_1: # entry.bb_crit_edge
        xorl    %ecx, %ecx
        xorw    %dx, %dx
        movw    %dx, %si
LBB1_2: # bb
        movl    L_X$non_lazy_ptr, %edi
        movw    %si, (%edi)
        movl    L_Y$non_lazy_ptr, %edi
        movw    %dx, (%edi)
addw    $4, %dx
incw    %si
incl    %ecx
cmpl    %eax, %ecx
jne     LBB1_2  # bb

into

LBB1_1: # entry.bb_crit_edge
        xorl    %ecx, %ecx
        xorw    %dx, %dx
LBB1_2: # bb
        movl    L_X$non_lazy_ptr, %esi
        movw    %cx, (%esi)
        movl    L_Y$non_lazy_ptr, %esi
        movw    %dx, (%esi)
        addw    $4, %dx
incl    %ecx
        cmpl    %eax, %ecx
        jne     LBB1_2  # bb

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43375 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoSilenced a VC++ warning.
Hartmut Kaiser [Thu, 25 Oct 2007 23:49:14 +0000 (23:49 +0000)]
Silenced a VC++ warning.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43374 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoUpdated backpatching during object deserialization to support "smart"
Ted Kremenek [Thu, 25 Oct 2007 23:40:35 +0000 (23:40 +0000)]
Updated backpatching during object deserialization to support "smart"
pointers that employ unused bits in a pointer to store extra data.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43373 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoClarified operator precedence.
Hartmut Kaiser [Thu, 25 Oct 2007 23:15:31 +0000 (23:15 +0000)]
Clarified operator precedence.
Silenced VC++ warning.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43372 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoDisambiguated variable name to comply with VC++'s archaic variable scoping rules.
Hartmut Kaiser [Thu, 25 Oct 2007 22:57:48 +0000 (22:57 +0000)]
Disambiguated variable name to comply with VC++'s archaic variable scoping rules.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43369 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoUpdated VC++ build system
Hartmut Kaiser [Thu, 25 Oct 2007 22:56:13 +0000 (22:56 +0000)]
Updated VC++ build system

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43368 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoDo not rewrite compare instruction using iv of a different stride if the new
Evan Cheng [Thu, 25 Oct 2007 22:45:20 +0000 (22:45 +0000)]
Do not rewrite compare instruction using iv of a different stride if the new
stride may be rewritten using the stride of the compare instruction.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43367 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoSupport non-POSIX hosts by removing use of strncasecmp.
Dale Johannesen [Thu, 25 Oct 2007 21:54:43 +0000 (21:54 +0000)]
Support non-POSIX hosts by removing use of strncasecmp.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43364 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoChanged XXX to FIXME, and added comment to the README file
Bill Wendling [Thu, 25 Oct 2007 19:49:32 +0000 (19:49 +0000)]
Changed XXX to FIXME, and added comment to the README file

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43359 91177308-0d34-0410-b5e6-96231b3b80d8

17 years agoAdded special treatment of serializing NULL pointers.
Ted Kremenek [Thu, 25 Oct 2007 18:42:52 +0000 (18:42 +0000)]
Added special treatment of serializing NULL pointers.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43357 91177308-0d34-0410-b5e6-96231b3b80d8