Subject: nfsd: don't recursively call nfsd4_cb_layout_fail
authorChristoph Hellwig <hch@lst.de>
Thu, 5 Mar 2015 13:17:31 +0000 (14:17 +0100)
committerJ. Bruce Fields <bfields@redhat.com>
Thu, 19 Mar 2015 19:49:27 +0000 (15:49 -0400)
commit133d558216d9db3617a9fdeebd1bce9afff5f973
treee7c6952832c7631f5a0b80e868c54a1d1e42c6f6
parent06e5801b8cb3fc057d88cb4dc03c0b64b2744cda
Subject: nfsd: don't recursively call nfsd4_cb_layout_fail

Due to a merge error when creating c5c707f9 ("nfsd: implement pNFS
layout recalls"), we recursively call nfsd4_cb_layout_fail from itself,
leading to stack overflows.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Fixes: c5c707f9 ("nfsd: implement pNFS layout recalls")
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
---
 fs/nfsd/nfs4layouts.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/nfsd/nfs4layouts.c b/fs/nfsd/nfs4layouts.c
index 3c1bfa1..1028a06 100644
--- a/fs/nfsd/nfs4layouts.c
+++ b/fs/nfsd/nfs4layouts.c
@@ -587,8 +587,6 @@ nfsd4_cb_layout_fail(struct nfs4_layout_stateid *ls)

  rpc_ntop((struct sockaddr *)&clp->cl_addr, addr_str, sizeof(addr_str));

- nfsd4_cb_layout_fail(ls);
-
  printk(KERN_WARNING
  "nfsd: client %s failed to respond to layout recall. "
  "  Fencing..\n", addr_str);
--
1.9.1
fs/nfsd/nfs4layouts.c