iscsi-target: Reject mutual authentication with reflected CHAP_C
authorNicholas Bellinger <nab@linux-iscsi.org>
Fri, 6 Jun 2014 01:08:57 +0000 (18:08 -0700)
committerNicholas Bellinger <nab@linux-iscsi.org>
Fri, 6 Jun 2014 02:45:01 +0000 (19:45 -0700)
commit1d2b60a5545942b1376cb48c1d55843d71e3a08f
tree9fc479d44697e7f27c416b359c98231416fdc3d0
parent5256ffdbdc1cb7e5ea69727698079c6f31b59a4f
iscsi-target: Reject mutual authentication with reflected CHAP_C

This patch adds an explicit check in chap_server_compute_md5() to ensure
the CHAP_C value received from the initiator during mutual authentication
does not match the original CHAP_C provided by the target.

This is in line with RFC-3720, section 8.2.1:

   Originators MUST NOT reuse the CHAP challenge sent by the Responder
   for the other direction of a bidirectional authentication.
   Responders MUST check for this condition and close the iSCSI TCP
   connection if it occurs.

Reported-by: Tejas Vaykole <tejas.vaykole@calsoftinc.com>
Cc: stable@vger.kernel.org # 3.1+
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/iscsi/iscsi_target_auth.c