net-tcp: fix panic in tcp_fastopen_cache_set()
authorEric Dumazet <edumazet@google.com>
Wed, 13 Nov 2013 23:00:46 +0000 (15:00 -0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 14 Nov 2013 21:33:18 +0000 (16:33 -0500)
commitdccf76ca6b626c0c4a4e09bb221adee3270ab0ef
tree655cb86c3c54d9b5ac9cb05f632bf0cd16077a4a
parentb869ccfab1e324507fa3596e3e1308444fb68227
net-tcp: fix panic in tcp_fastopen_cache_set()

We had some reports of crashes using TCP fastopen, and Dave Jones
gave a nice stack trace pointing to the error.

Issue is that tcp_get_metrics() should not be called with a NULL dst

Fixes: 1fe4c481ba637 ("net-tcp: Fast Open client - cookie cache")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Dave Jones <davej@redhat.com>
Cc: Yuchung Cheng <ycheng@google.com>
Acked-by: Yuchung Cheng <ycheng@google.com>
Tested-by: Dave Jones <davej@fedoraproject.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp_metrics.c