spi: orion: fix incorrect handling of cell-index DT property
authorThomas Petazzoni <thomas.petazzoni@free-electrons.com>
Sun, 27 Jul 2014 21:53:19 +0000 (23:53 +0200)
committerMark Brown <broonie@linaro.org>
Mon, 28 Jul 2014 21:30:43 +0000 (22:30 +0100)
commite06871cd2c92e5c65d7ca1d32866b4ca5dd4ac30
treef29742cee9356fa0883df89eba0473207832bb62
parent7171511eaec5bf23fb06078f59784a3a0626b38f
spi: orion: fix incorrect handling of cell-index DT property

In commit f814f9ac5a81 ("spi/orion: add device tree binding"), Device
Tree support was added to the spi-orion driver. However, this commit
reads the "cell-index" property, without taking into account the fact
that DT properties are big-endian encoded.

Since most of the platforms using spi-orion with DT have apparently
not used anything but cell-index = <0>, the problem was not
visible. But as soon as one starts using cell-index = <1>, the problem
becomes clearly visible, as the master->bus_num gets a wrong value
(actually it gets the value 0, which conflicts with the first bus that
has cell-index = <0>).

This commit fixes that by using of_property_read_u32() to read the
property value, which does the appropriate endianness conversion when
needed.

Fixes: f814f9ac5a81 ("spi/orion: add device tree binding")
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
Cc: <stable@vger.kernel.org> # v3.6+
drivers/spi/spi-orion.c